On Sun, 2024-11-24 at 07:32 +, Hangbin Liu wrote:
> The test.py should not be run separately. It should be run via run.sh,
> which will do some sanity checks first. Move the test.py from TEST_PROGS
> to TEST_FILES.
This looks fine to me. Thanks for the catch!
Reviewed-by: Allison
ch also specifies to import ip() function from the utils
> module.
>
> Signed-off-by: Alessandro Zanni
I think this one looks ok. Thanks Alessandro!
Reviewed-by: Allison Henderson
> ---
>
> Notes:
> v2:
> modified the way the parent path is added
> add
On Tue, 2024-09-24 at 14:49 +0200, Javier Carrasco wrote:
> The generated include.sh should be ignored by git. Create a new
> gitignore and add the file to the list.
>
> Signed-off-by: Javier Carrasco
Thanks!
Reviewed-by: Allison Henderson
> ---
> tools/testing/selftests/
vier Carrasco
Ok, looks good. Thanks for catching this
Reviewed-by: Allison Henderson
> ---
> tools/testing/selftests/net/rds/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/rds/Makefile
> b/tools/testin
ion name is also not easy to understand, rename it to
> "dax_iomap_copy_around()", which means it copys data around the
> range.
>
> Signed-off-by: Shiyang Ruan
> Reviewed-by: Darrick J. Wong
>
I think the new changes look good
Reviewe
;
> Also, the flag needs to be renamed to PAGE_MAPPING_DAX_SHARED.
>
The new changes look reasonable to me
Reviewed-by: Allison Henderson
> Signed-off-by: Shiyang Ruan
> ---
> fs/dax.c | 38 ++--
> --
> include/linux/mm_t
y,
Dr. Allison Neher
+226 58779013
On Mon, May 06, 2019 at 11:53:44AM -0500, Steve French via samba-technical
wrote:
> I think strcpy is clearer - but I don't think it can overflow since if
> R, W or W were written to "message" then cinode->oplock would be
> non-zero so we would never strcap "None"
Ahem. In Samba we have :
lib/ut
Looks ok to me. Thanks for the clean up.
Reviewed-by: Allison Henderson
On 3/11/19 9:22 AM, Darrick J. Wong wrote:
From: Darrick J. Wong
Remove typedefs and consolidate local variable initialization.
Signed-off-by: Darrick J. Wong
---
fs/xfs/libxfs/xfs_dir2_leaf.c | 33
Looks fine. You can add my review. Thx!
Reviewed-by: Allison Henderson
On 3/11/19 9:19 AM, Darrick J. Wong wrote:
From: Darrick J. Wong
Smatch complains about the following:
fs/xfs/libxfs/xfs_dir2_leaf.c:848 xfs_dir2_leaf_addname() error:
uninitialized symbol 'lowstale'.
fs/
On Mon, Apr 03, 2017 at 11:36:48AM -0700, Jeremy Allison wrote:
> On Mon, Apr 03, 2017 at 02:18:44PM -0400, Jeff Layton wrote:
> > On Mon, 2017-04-03 at 11:09 -0700, Jeremy Allison wrote:
> > >
> > > CIFS has a way to reserve space. Look into "allocation size"
On Mon, Apr 03, 2017 at 02:18:44PM -0400, Jeff Layton wrote:
> On Mon, 2017-04-03 at 11:09 -0700, Jeremy Allison wrote:
> > On Mon, Apr 03, 2017 at 01:47:37PM -0400, Jeff Layton wrote:
> > > On Mon, 2017-04-03 at 07:32 -0700, Matthew Wilcox wrote:
> > > > On Mon, Ap
On Mon, Apr 03, 2017 at 01:47:37PM -0400, Jeff Layton wrote:
> On Mon, 2017-04-03 at 07:32 -0700, Matthew Wilcox wrote:
> > On Mon, Apr 03, 2017 at 06:28:38AM -0400, Jeff Layton wrote:
> > > On Mon, 2017-04-03 at 14:25 +1000, NeilBrown wrote:
> > > > Also I think that EIO should always over-ride EN
On Tue, Dec 06, 2016 at 10:25:22PM +0100, Miklos Szeredi wrote:
> On Tue, Dec 6, 2016 at 10:13 PM, Jeremy Allison wrote:
> > On Tue, Dec 06, 2016 at 03:15:29PM -0500, J. Bruce Fields wrote:
> >> On Fri, Dec 02, 2016 at 10:57:42AM +0100, Miklos Szeredi wrote:
> >> > O
On Tue, Dec 06, 2016 at 03:15:29PM -0500, J. Bruce Fields wrote:
> On Fri, Dec 02, 2016 at 10:57:42AM +0100, Miklos Szeredi wrote:
> > On Tue, Oct 11, 2016 at 2:50 PM, Andreas Gruenbacher
> > wrote:
> > > Normally, deleting a file requires MAY_WRITE access to the parent
> > > directory. With rich
On Tue, May 10, 2016 at 06:18:10AM +0200, Volker Lendecke wrote:
> On Tue, May 10, 2016 at 12:02:33AM +0200, Andreas Gruenbacher wrote:
> > What more can I do to finally get this merged?
>
> While I am not the one to comment on kernel specifics, from a pure Samba
> user space perspective let me sa
On Tue, Mar 15, 2016 at 12:11:03AM -0700, Christoph Hellwig wrote:
> On Fri, Mar 11, 2016 at 05:11:51PM +0100, Andreas Gruenbacher wrote:
> > > while breaking a lot of assumptions,
> >
> > The model is designed specifically to be compliant with the POSIX
> > permission model. What assumptions are
On Mon, Mar 14, 2016 at 12:02:13AM +0100, Andreas Gruenbacher wrote:
> On Sat, Mar 12, 2016 at 12:02 AM, Jeremy Allison wrote:
> > On Fri, Mar 11, 2016 at 02:05:16PM -0600, Steve French wrote:
> >> Sounds like I need to quickly rework the SMB3 ACL helper functions
> >>
On Fri, Mar 11, 2016 at 02:05:16PM -0600, Steve French wrote:
> Sounds like I need to quickly rework the SMB3 ACL helper functions
> for cifs.ko
>
> Also do you know where is the current version of the corresponding
> vfs_richacl for
> Samba which works with the current RichACL format?
I have a p
On Fri, Apr 24, 2015 at 01:03:57PM +0200, Andreas Gruenbacher wrote:
> Hello,
>
> here's another update of the richacl patch queue. The changes since the last
> posting (https://lwn.net/Articles/638242/) include:
>
> * The nfs client now allocates pages for received acls on demand like the
>
On Thu, May 14, 2015 at 04:24:13PM -0700, Linus Torvalds wrote:
> On Thu, May 14, 2015 at 3:09 PM, Jeremy Allison wrote:
> >
> > Of course we tell people to just set their filesystems
> > up using mkfs.xfs -n version=ci :-).
>
> So ASCII-only case-insensitivity is s
On Wed, May 13, 2015 at 08:52:59PM -0700, Linus Torvalds wrote:
> On Wed, May 13, 2015 at 8:30 PM, Al Viro wrote:
> >
> > Maybe... I'd like to see the profiles, TBH - especially getxattr() and
> > access() frequency on various loads. Sure, make(1) and cc(1) really care
> > about stat() very much
On Wed, May 13, 2015 at 10:47:44PM +0200, Andreas Grünbacher wrote:
> 2015-05-13 22:28 GMT+02:00 Jeremy Allison :
> > On Wed, May 13, 2015 at 10:22:21PM +0200, Andreas Grünbacher wrote:
> >>
> >> That being said, a daemon like Samba can "fake" full Automatic
&
On Wed, May 13, 2015 at 10:22:21PM +0200, Andreas Grünbacher wrote:
>
> That being said, a daemon like Samba can "fake" full Automatic
> Inheritance by creating files and then updating the inherited acls
> appropriately. This will inevitably be racy, but unless someone
> implements a way to create
On Wed, May 13, 2015 at 12:37:41PM -0700, Daniel Phillips wrote:
> On 05/13/2015 12:09 PM, Martin Steigerwald wrote:
>
> > "Assume good faith" can help here. No amount of accusing people of bad
> > intention will change them. The only thing you have the power to change is
> > your approach. You
On Mon, Mar 30, 2015 at 01:37:58PM -0700, Andrew Morton wrote:
> On Mon, 30 Mar 2015 13:32:27 -0700 Jeremy Allison wrote:
>
> > On Mon, Mar 30, 2015 at 01:26:25PM -0700, Andrew Morton wrote:
> > >
> > > cons:
> > >
> > > d) fincore() is mo
On Mon, Mar 30, 2015 at 01:26:25PM -0700, Andrew Morton wrote:
>
> cons:
>
> d) fincore() is more expensive
>
> e) fincore() will very occasionally block
The above is the killer for Samba. If fincore
returns true but when we schedule the pread
we block, we're hosed.
Once we block, we're done s
On Mon, Mar 30, 2015 at 12:36:04AM -0700, Christoph Hellwig wrote:
> On Fri, Mar 27, 2015 at 08:58:54AM -0700, Jeremy Allison wrote:
> > The problem with the above is that we can't tell the difference
> > between pread2() returning a short read because the pages are not
>
On Fri, Mar 27, 2015 at 09:30:46AM -0700, Andrew Morton wrote:
>
> But from an interface perspective the behaviour you're asking for is
> insane, frankly - if the kernel copied out 8k of data then pread2()
> should return 8k. Otherwise there's no way for userspace to know that
> the 8k copy actua
On Fri, Mar 27, 2015 at 02:01:59AM -0700, Andrew Morton wrote:
> On Fri, 27 Mar 2015 01:48:33 -0700 Christoph Hellwig
> wrote:
>
> > On Fri, Mar 27, 2015 at 01:35:16AM -0700, Andrew Morton wrote:
> > > fincore() doesn't have to be ugly. Please address the design issues I
> > > raised. How is p
On Thu, Jan 08, 2015 at 11:28:40AM -0500, Milosz Tanski wrote:
> >
>
> Andrew I got busier with my other job related things between the
> Thanksgiving & Christmas then anticipated. However, I have updated and
> taken apart the patchset into two pieces (preadv2 and pwritev2). That
> should make ev
On Mon, Nov 03, 2014 at 10:49:24AM -0800, Eric Rannaud wrote:
> On Mon, Nov 3, 2014 at 9:06 AM, Andy Lutomirski wrote:
> >> That doesn't help because we explicitly reject O_RDONLY when combined
> >> with O_TMPFILE.
> >
> > I think I'm missing something. How is an O_RDONLY temporary file
> > usefu
On Wed, Apr 16, 2014 at 10:00:46PM +0200, Michael Kerrisk (man-pages) wrote:
> [CC += Jeremy Allison]
>
> On Wed, Apr 16, 2014 at 8:57 PM, Jeff Layton wrote:
> > Sorry to spam so many lists, but I think this needs widespread
> > distribution and consensus.
> >
>
On Mon, Mar 31, 2014 at 11:44:59AM +0100, One Thousand Gnomes wrote:
> On Wed, 26 Mar 2014 17:23:24 -0700
> Andy Lutomirski wrote:
>
> > Hi various people who care about user-space NFS servers and/or
> > security-relevant APIs.
> >
> > I propose the following set of new syscalls:
> >
> > int cr
On Thu, Mar 27, 2014 at 11:46:39AM -0700, Andy Lutomirski wrote:
> On Thu, Mar 27, 2014 at 11:26 AM, Jeremy Allison wrote:
> >
> > Amen to that :-).
> >
> > However, after talking with Jeff and Jim at CollabSummit,
> > I was 'encouraged' to make m
On Thu, Mar 27, 2014 at 07:01:26AM -0700, Jeff Layton wrote:
> On Thu, 27 Mar 2014 14:06:32 +0100
> Florian Weimer wrote:
>
> > On 03/27/2014 02:02 PM, Jeff Layton wrote:
> >
> > >> This interface does not address the long-term lack of POSIX
> > >> compliance in setuid and friends, which are req
On Mon, Feb 03, 2014 at 10:31:27PM +, Al Viro wrote:
>
> > And the fact is, filesystems with hardlinks and path-name-based
> > operations do exist. cifs with the unix extensions is one of them.
>
> Pox on Tridge...
Actually you have to blame me for that. Tridge always
*HATED* the UNIX extens
On Fri, 11 Oct 2013 15:36:43 -0600 Andreas Dilger wrote:
> >
> > At this point, my main questions are:
> >
> > 1) does this look useful, particularly for fileserver implementors?
Yes from the Samba perspective. We'll have to keep the old
code around for compatibility with non-Linux OS'es, but t
On Tue, Jul 23, 2013 at 05:10:27PM +1000, Dave Chinner wrote:
> So, we are nesting up to 32 page locks here. That's bad. And we are
> nesting kmap() calls for all the pages individually - is that even
> safe to do?
>
> So, what happens when we've got 16 pages in, and the filesystem has
> allocated
Hi Steve and Jeff (and others).
Here is a patch that Samba vendors have been using
to implement recvfile (copy directly from socket
to file). It can improve write performance on boxes
by a significant amount (10% or more).
I'm not qualified to evaluate this code, can someone
who is (hi there Stev
On Thu, Feb 21, 2013 at 01:51:53PM +, Myklebust, Trond wrote:
> On Thu, 2013-02-21 at 12:37 +0100, Ric Wheeler wrote:
> > We have debated the need to have a system call to allow for offloading copy
> > operations, for example to an NFS server (part to the new NFS 4.2
> > specification), SCSI
On Thu, Dec 06, 2012 at 04:37:27PM -0500, Theodore Ts'o wrote:
> On Thu, Dec 06, 2012 at 01:33:29PM -0800, Jeremy Allison wrote:
> > > I'm confused; why would a userspace application need to be able to
> > > request this behavior?
> >
> > This isn&#
On Thu, Dec 06, 2012 at 04:31:33PM -0500, Theodore Ts'o wrote:
> On Thu, Dec 06, 2012 at 11:57:52AM -0800, Jeremy Allison wrote:
> >
> > And this is where things get really ugly of course :-).
> >
> > For the CIFSFS client they're expecting to be able to
&
On Thu, Dec 06, 2012 at 11:57:52AM -0800, Jeremy Allison wrote:
> On Thu, Dec 06, 2012 at 07:49:49PM +, Alan Cox wrote:
> > On Thu, 6 Dec 2012 22:26:28 +0400
> > Pavel Shilovsky wrote:
> >
> > > Network filesystems CIFS, SMB2.0, SMB3.0 and NFSv4 have such
On Thu, Dec 06, 2012 at 07:49:49PM +, Alan Cox wrote:
> On Thu, 6 Dec 2012 22:26:28 +0400
> Pavel Shilovsky wrote:
>
> > Network filesystems CIFS, SMB2.0, SMB3.0 and NFSv4 have such flags - this
> > change can benefit cifs and nfs modules. While this change is ok for
> > network filesystem
On Tue, Jun 19, 2007 at 03:05:07AM -0400, Theodore Tso wrote:
>
> There is a partial implementation lieing around somewhere, but there
> were a number of problems we ran into that were discussed in the
> slidedeck. Basically, if the only program accessing the files
> containing forks was the Samb
On Mon, Jun 18, 2007 at 06:10:21PM -0400, Theodore Tso wrote:
> On Mon, Jun 18, 2007 at 02:31:14PM -0700, H. Peter Anvin wrote:
> > And that makes them different from extended attributes, how?
> >
> > Both of these really are nothing but ad hocky syntactic sugar for
> > directories, sometimes comb
On Tue, Jun 19, 2007 at 12:26:57AM +0200, Jörn Engel wrote:
>
> Pointless here means that _I_ don't see the point. Maybe there are
> valid uses for extended attributes. If there are, noone has explained
> them to me yet.
Samba uses them to store DOS'ism's that you don't want in your
POSIX files
On Mon, Jun 18, 2007 at 02:31:14PM -0700, H. Peter Anvin wrote:
> And that makes them different from extended attributes, how?
Streams on systems that support them allow lseek and are
accessed by fd's. EA's are always a blob of data, read/written
in their entirity.
Jeremy.
-
To unsubscribe from
On Mon, Jun 18, 2007 at 01:29:56PM -0400, Theodore Tso wrote:
> On Mon, Jun 18, 2007 at 09:16:30AM -0700, alan wrote:
> >
> > I just wish that people would learn from the mistakes of others. The
> > MacOS is a prime example of why you do not want to use a forked
> > filesystem, yet some people
On Thu, May 03, 2007 at 09:46:05AM -0500, Gerald Carter wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Simo,
>
> > I guess DFS referrals can work cross protocol, so if you are redirected
> > from a longhorn server to a windoes 2000 or a samba server you want to
> > be able to follow
On Wed, May 02, 2007 at 12:16:38PM -0400, Theodore Tso wrote:
> On Tue, May 01, 2007 at 02:23:25PM -0700, Andrew Morton wrote:
> > On Tue, 1 May 2007 13:43:18 -0700
> > "Cabot, Mason B" <[EMAIL PROTECTED]> wrote:
> >
> > > I've been testing the NAS performance of ext3/Openfiler 2.2 against
> > > N
On Tue, Apr 03, 2007 at 02:17:59PM -0500, Steve French wrote:
> Now merged into cifs-2.6 git tree. Thanks to Q and Wilhelm
Up to date SVN please ! :-).
Jeremy.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo
On Thu, Mar 01, 2007 at 03:23:19PM -0500, Jeff Garzik wrote:
> I certainly agree that we want something like this.
>
> posix_fallocate() is the glibc interface we want to be compatible with
> (which your definition is, AFAICS).
This would be great for Samba. Windows clients do this a lot
Je
t and find it's address
2. Read the kernel page table to find the physical address of the
module location
thanks,
Allison
Allison wrote:
> Hi,
>
> Since module is loaded in non-contiguous memory, there has to be an
> entry in the kernel page table for all modules that are loaded
helpful.
thanks,
Allison
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Isn't the kernel code segment marked read-only ? How can the module
write into the function text in the kernel ? Shouldn't this cause some
kind of protection fault ?
thanks,
Allison
Lee Revell wrote:
> On Fri, 2005-04-15 at 18:15 +, Allison wrote:
> > Once these are loa
SucKIT is a rootkit that gets loaded as a kernel module
and adds new system calls. Some other rootkits change machine
instructions in several kernel functions.
Once these are loaded into the kernel, is there no way the kernel
functions can be protected ?
thanks,
Allison
-
To unsubscribe from this
. If I want to hide a function which is part of the kernel from
kernel modules, is this possible ideally ?
thanks,
Allison
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
Right now , I am just learn. trying a test module that lists out all the modules
Allison
Arjan van de Ven wrote:
> On Thu, 2005-04-14 at 19:53 +0000, Allison wrote:
> >
> > I am trying to access the module list kernel data structure from a
> > kernel module. If I gather c
mean which file ?)? Do I use
kernel_thread function to create a new thread ?
Do I need to cleanup when the system exists ?
What function should I call ?
thanks,
Allison
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTE
I am trying to simply print out the module names and code sizes.
I am just learning how to rtraverse these data structures.
Also, on what basis is the decision made whether to export a symbol or not ?
thanks,
Allison
Arjan van de Ven wrote:
> On Thu, 2005-04-14 at 19:53 +0000, Allison wr
?
thanks,
Allison
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi,
Is it possible to compile a 2.4.20 kernel on a 2.6 system ?
And use the new image successfully ?
thanks,
Allison
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
efore the application quits ?
How does this work in Linux. I was curious if such a functionality
already exists in Linux. If not, what are the issues involved in
implementing this functionality.
thanks
Allison
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" i
page itself, will a scatter gather DMA make
sure that the processor cannot modify any of these data structures
till the DMA is complete ? I am using Linux 2.6 and the i386
architecture.
thanks,
Allison
On Sat, 12 Mar 2005 17:23:23 -0800, Matt Mackall <[EMAIL PROTECTED]> wrote:
> On Sa
y
if you want more timely feedback, else I'll wait for the next
kernel-traffic summary and take my answer off line (in the
grand tradition of polite radio talk show call in listeners :-).
Cheers,
Jeremy Allison,
Samba Team.
--
67 matches
Mail list logo
