On Tue Jul 15, 2025 at 5:40 PM CEST, Alexei Starovoitov wrote:
> On Tue, Jul 15, 2025 at 7:31 AM Will Deacon wrote:
>>
>> On Tue, Jul 15, 2025 at 04:02:25PM +0200, Alexis Lothoré wrote:
>> > On Tue Jul 15, 2025 at 3:32 PM CEST, Will Deacon wrote:
>> > > On W
On Tue Jul 15, 2025 at 3:32 PM CEST, Will Deacon wrote:
> On Wed, Jul 09, 2025 at 10:36:55AM +0200, Alexis Lothoré (eBPF Foundation)
> wrote:
>> While introducing support for 9+ arguments for tracing programs on
>> ARM64, commit 9014cf56f13d ("bpf, arm64: Support up to 1
On Sat Jun 14, 2025 at 12:35 AM CEST, Alexei Starovoitov wrote:
> On Fri, Jun 13, 2025 at 1:59 AM Alexis Lothoré
> wrote:
>>
>> On Fri Jun 13, 2025 at 10:32 AM CEST, Peter Zijlstra wrote:
>> > On Fri, Jun 13, 2025 at 10:26:37AM +0200, Alexis Lothoré wrote:
[...]
&
On Fri Jun 13, 2025 at 10:32 AM CEST, Peter Zijlstra wrote:
> On Fri, Jun 13, 2025 at 10:26:37AM +0200, Alexis Lothoré wrote:
>> Hi Peter,
>>
>> On Fri Jun 13, 2025 at 10:11 AM CEST, Peter Zijlstra wrote:
>> > On Fri, Jun 13, 2025 at 09:37:11AM +0200, Alexis Lothoré
Hi Peter,
On Fri Jun 13, 2025 at 10:11 AM CEST, Peter Zijlstra wrote:
> On Fri, Jun 13, 2025 at 09:37:11AM +0200, Alexis Lothoré (eBPF Foundation)
> wrote:
>> When the target function receives more arguments than available
>> registers, the additional arguments are passed on
Hi Alexei,
On Thu Jun 5, 2025 at 6:09 PM CEST, Alexei Starovoitov wrote:
> On Thu, Jun 5, 2025 at 12:35 AM Alexis Lothoré
> wrote:
>>
>> Hi Ihor,
>>
>> On Wed Jun 4, 2025 at 7:31 PM CEST, Ihor Solodrai wrote:
>> > On 6/4/25 2:02 AM, Alexis Lothoré wrote
attributes can not be represented by DWARF, I'll have to
find another way of getting those packing/alignment modifications on data
type (eg: re-use/share btf__align_of from libbpf, as suggested by Andrii,
but it may not able to cover all cases).
Thanks,
Alexis
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
discussed earlier, those may suffer
from the same kind of issue mentioned above.
On Wed Apr 23, 2025 at 9:24 PM CEST, Alexis Lothoré wrote:
> Hi Andrii,
>
> On Wed Apr 23, 2025 at 7:15 PM CEST, Andrii Nakryiko wrote:
>> On Thu, Apr 17, 2025 at 12:14 AM Alexis Lothoré
>> wro
Hi Xu, thanks for the review
On Tue May 27, 2025 at 10:11 AM CEST, Xu Kuohai wrote:
> On 5/22/2025 6:14 PM, Alexis Lothoré wrote:
>
> [...]
>
>> -static void save_args(struct jit_ctx *ctx, int args_off, int nregs)
>> +struct arg_aux {
>> +/* how many args are
n BTF info. Such cases are denied for now to make sure not to
read incorrect values.
Signed-off-by: Xu Kuohai
Co-developed-by: Alexis Lothoré (eBPF Foundation)
Signed-off-by: Alexis Lothoré (eBPF Foundation)
---
Changes in v3:
- switch back -EOPNOTSUPP to -ENOTSUPP
- fix comment style
- remove useles
specific cases like struct passed
on stack and larger types.
[1]
https://lore.kernel.org/all/20230917150752.69612-1-xukuo...@huaweicloud.com/#t
Signed-off-by: Alexis Lothoré (eBPF Foundation)
---
Changes in v3:
- switch back -EOPNOTSUPP to -ENOTSUPP
- fix comment style
- group intializations for a
On Tue May 27, 2025 at 11:09 AM CEST, Xu Kuohai wrote:
> On 5/27/2025 4:45 PM, Alexis Lothoré wrote:
>
> [...]
>
>>>> + /* We can not know for sure about exact alignment needs for
>>>> + * struct passed on stack, so deny those
>>>>
n BTF info. Such cases are denied for now to make sure not to
read incorrect values.
Signed-off-by: Xu Kuohai
Co-developed-by: Alexis Lothoré (eBPF Foundation)
Signed-off-by: Alexis Lothoré (eBPF Foundation)
---
Changes in v2:
- refuse attachment to functions passing structs on stack
- use simpler
specific cases like struct passed
on stack and larger types.
[1]
https://lore.kernel.org/all/20230917150752.69612-1-xukuo...@huaweicloud.com/#t
Signed-off-by: Alexis Lothoré (eBPF Foundation)
---
Changes in v2:
- remove alignment computation from btf.c
- deduce alignment constraints directly in j
On Mon Apr 28, 2025 at 10:41 PM CEST, Alexis Lothoré wrote:
> On Mon Apr 28, 2025 at 6:52 PM CEST, Eduard Zingerman wrote:
>> Alexis Lothoré writes:
> If things really behaved correctly, f would not have the correct value but
> would still be handled as a 16 bytes value, so the
On Mon Apr 28, 2025 at 6:52 PM CEST, Eduard Zingerman wrote:
> Alexis Lothoré writes:
>
> [...]
>
>>> The function listened to is defined as accepting 'struct
>>> bpf_testmod_struct_arg_7',
>>> at the same time this function uses 'struct bpf
Hello Eduard,
On Mon Apr 28, 2025 at 9:01 AM CEST, Eduard Zingerman wrote:
> On Fri, 2025-04-11 at 22:32 +0200, Alexis Lothoré (eBPF Foundation) wrote:
>> When dealing with large types (>8 bytes), ARM64 trampolines need to take
>> extra care about the arguments alignment to r
Hello Alexei,
On Fri Apr 25, 2025 at 1:14 AM CEST, Alexei Starovoitov wrote:
> On Thu, Apr 24, 2025 at 6:38 AM Alexis Lothoré
> wrote:
[...]
>> > With DWARF info, we might not need to detect the structure alignment
>> > anymore,
>> > since the DW_AT_loca
Hi Xu,
On Thu Apr 24, 2025 at 2:00 PM CEST, Xu Kuohai wrote:
> On 4/24/2025 3:24 AM, Alexis Lothoré wrote:
>> Hi Andrii,
>>
>> On Wed Apr 23, 2025 at 7:15 PM CEST, Andrii Nakryiko wrote:
>>> On Thu, Apr 17, 2025 at 12:14 AM Alexis Lothoré
>>> wrote:
>&
Hi Andrii,
On Wed Apr 23, 2025 at 7:15 PM CEST, Andrii Nakryiko wrote:
> On Thu, Apr 17, 2025 at 12:14 AM Alexis Lothoré
> wrote:
>>
>> Hi Andrii,
>>
>> On Wed Apr 16, 2025 at 11:24 PM CEST, Andrii Nakryiko wrote:
>> > On Fri, Apr 11, 2025 at 1:32 PM Alexi
On Mon Apr 21, 2025 at 4:14 AM CEST, Xu Kuohai wrote:
> On 4/21/2025 12:02 AM, Alexis Lothoré wrote:
>> Hi Xu,
>>
>> On Thu Apr 17, 2025 at 4:10 PM CEST, Xu Kuohai wrote:
>>> On 4/17/2025 3:14 PM, Alexis Lothoré wrote:
>>>> Hi Andrii,
>>>
Hi Xu,
On Thu Apr 17, 2025 at 4:10 PM CEST, Xu Kuohai wrote:
> On 4/17/2025 3:14 PM, Alexis Lothoré wrote:
>> Hi Andrii,
>>
>> On Wed Apr 16, 2025 at 11:24 PM CEST, Andrii Nakryiko wrote:
>>> On Fri, Apr 11, 2025 at 1:32 PM Alexis Lothoré (eBPF Foundation)
>
Hi Andrii,
On Wed Apr 16, 2025 at 11:24 PM CEST, Andrii Nakryiko wrote:
> On Fri, Apr 11, 2025 at 1:32 PM Alexis Lothoré (eBPF Foundation)
> wrote:
>>
>> In order to properly JIT the trampolines needed to attach BPF programs
>> to functions, some architectures like ARM6
Hello Jiri,
On Mon Apr 14, 2025 at 1:04 PM CEST, Jiri Olsa wrote:
> On Fri, Apr 11, 2025 at 10:32:10PM +0200, Alexis Lothoré (eBPF Foundation)
> wrote:
[...]
>> +for_each_member(i, t, member) {
>> +mtype = btf_type_by_id(btf, member->type);
>>
remaining
arguments starting from this one are pushed to the stack for passing.
Signed-off-by: Xu Kuohai
Co-developed-by: Alexis Lothoré
Signed-off-by: Alexis Lothoré
---
arch/arm64/net/bpf_jit_comp.c | 235 --
1 file changed, 182 insertions(+), 53 deletion
evive
your work to try to handle the missing points and make this feature integrated ?
Thanks,
Alexis
[0] https://lore.kernel.org/bpf/20230917150752.69612-1-xukuo...@huaweicloud.com/
[1] https://lore.kernel.org/bpf/20240705125336.46820-1-puran...@kernel.org/
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
coming patch.
> Update the test_xdp_redirect.sh to use the program name instead of the
> section name to load the BPF program.
>
> Signed-off-by: Bastien Curutchet (eBPF Foundation)
>
LGTM :)
Reviewed-by: Alexis Lothoré (eBPF Foundation)
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
ogs.xdp_dummy_prog ?
(same for all progs below)
Thanks,
Alexis
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
NETWORK);
> +
> + close_netns(nstoken);
> +
> + nstoken = open_netns(NS2);
> + if (!ASSERT_OK_PTR(nstoken, "open NS2"))
> + goto close;
> +
> + SYS(close, "ping -c 1 %s.1", IPV4_NETWORK);
Is it really useful to check ping orig
he automated mail answer when a series on
which I am the author is merged (ie: I get the final mail thanks to ML
subscription, not because I am in the recipient list). The target address looks
broken:
"Alexis Lothoré
"@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org
I am not sure if the is
On 11/15/24 16:33, Stanislav Fomichev wrote:
> On 11/14, Alexis Lothoré (eBPF Foundation) wrote:
>> network_helpers.h provides helpers to compute checksum for pseudo
>> headers but no helpers to compute the global checksums.
>>
>> Before adding those, rename the pseud
On 11/15/24 17:11, Stanislav Fomichev wrote:
> On 11/14, Alexis Lothoré (eBPF Foundation) wrote:
>> +if (!ASSERT_GE(err, 0, "do_rx"))
>> +break;
>
> You seem to be already doing similar ASSERT_GE inside the do_rx, maybe
> dr
On 11/15/24 16:54, Stanislav Fomichev wrote:
> On 11/14, Alexis Lothoré (eBPF Foundation) wrote:
>> +static inline __sum16 build_udp_v4_csum(const struct iphdr *iph, __u8
>> l4_proto,
>> +__u16 l4_len,
Hello Stanislas,
On 11/15/24 16:32, Stanislav Fomichev wrote:
> On 11/14, Alexis Lothoré (eBPF Foundation) wrote:
>> +static unsigned long add_csum_hword(const __u16 *start, int num_u16)
>> +{
>> +unsigned long sum = 0;
>> +int i;
>> +
&
On 11/13/24 18:50, Stanislav Fomichev wrote:
> On 11/13, Alexis Lothoré wrote:
>> On 11/13/24 14:53, Alexis Lothoré (eBPF Foundation) wrote:
>>
>> [...]
>>
>>> + ns = open_netns(TEST_NS);
>>> + bpf_prog_detach2(prog_fd, 0, BPF_FLOW_DISSECTOR);
&
On 11/13/24 18:58, Stanislav Fomichev wrote:
> On 11/13, Alexis Lothoré (eBPF Foundation) wrote:
>> test_flow_dissector.sh loads flow_dissector program and subprograms,
>> creates and configured relevant tunnels and interfaces, and ensure that
>> the bpf dissection is actuall
Hello Stanislas, thanks for the reviews !
On 11/13/24 18:42, Stanislav Fomichev wrote:
> On 11/13, Alexis Lothoré (eBPF Foundation) wrote:
>> The flow_dissector runs plenty of tests over diffent kind of packets,
>> grouped into three categories: skb mode, non-skb mode with direct
On 11/13/24 14:53, Alexis Lothoré (eBPF Foundation) wrote:
[...]
> + ns = open_netns(TEST_NS);
> + bpf_prog_detach2(prog_fd, 0, BPF_FLOW_DISSECTOR);
> + close_netns(ns);
I would like to mention that I initially planned to directly delete the
namespace to perform the tes
On 10/19/24 02:30, Martin KaFai Lau wrote:
> On 10/16/24 11:35 AM, Alexis Lothoré (eBPF Foundation) wrote:
[...]
>> + switch (ip_mode) {
>> + case TEST_MODE_IPV4:
>> + sock_family = AF_INET;
>> + srv_addr = SERVER_ADDR_IPV4;
>> +
Hi Martin, thanks for the review !
On 10/19/24 01:57, Martin KaFai Lau wrote:
> On 10/16/24 11:35 AM, Alexis Lothoré (eBPF Foundation) wrote:
>> btf_skc_cls_ingress.c currently runs two subtests, and create a
>> dedicated network namespace for each, but never cleans up the creat
Hello Martin,
On 10/11/24 03:23, Martin KaFai Lau wrote:
> On 10/9/24 3:12 AM, Alexis Lothoré (eBPF Foundation) wrote:
>> - int err, prog_fd, map_fd;
>> + int err, prog_fd, prog_redir_fd, map_fd;
>> + struct nstoken *nstoken = NULL;
>> __u32 idx = 0;
&
bottom of the todo list for now.
ACK, thanks
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
logic as the series in progress you have pointed.
Once done, test_xdp_features.sh could be let as-is. Let me know if we should
stillmove it elsewhere instead of keeping it in selftests
(tools/bpf/xdp_features/ maybe ?)
And noted for the most relevant tests to convert after that, thanks :)
v ? Or it is a bigger hint that the whole test
about xdp features could be moved there (and then tested by net kselftests
rather than by ebpf ci specifically) ? @Lorenzo and eBPF tests maintainers, any
opinion ?
Thanks,
Alexis
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
to block progress.
> But, FWIIW, the comment above is not a Kernel doc, yet starts with '/**'.
> I suggest that it should start with '/*' instead.
ACK. I'll wait for more comments on the series, and add the fix to the
corresponding revision, if any.
Thanks,
Alexis
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Hey Maxime,
On 9/9/24 23:18, Maxime Chevallier wrote:
> Hi Alexis,
>
> On Mon, 09 Sep 2024 22:02:07 +0200
> Alexis Lothoré (eBPF Foundation) wrote:
[...]
>> +static void *run_dut_echo_thread(void *arg)
>> +{
>> +struct test_data *t = (struct test_d
46 matches
Mail list logo
