Re: [PATCH] proc: Fix uninitialized byte read in get_mm_cmdline()

2019-07-13 Thread Alexey Izbyshev
On 7/13/19 10:26 AM, Alexey Dobriyan wrote: > On Fri, Jul 12, 2019 at 09:43:03PM +0300, Alexey Izbyshev wrote: >> On 7/12/19 8:46 PM, Alexey Dobriyan wrote: >>> The proper fix to all /proc/*/cmdline problems is to revert >>> >>> f5b65348fd77839b50e79b

Re: [PATCH] proc: revert /proc/*/cmdline rewrite

2019-07-13 Thread Alexey Izbyshev
On 7/13/19 10:32 AM, Alexey Dobriyan wrote: > /proc/*/cmdline continues to cause problems: > > https://lkml.org/lkml/2019/4/5/825 > Subject get_mm_cmdline and userspace (Perl) changing argv0 > > https://marc.info/?l=linux-kernel&m=156294831308786&w=4 > [PATCH] proc: Fix un

Re: [PATCH] proc: Fix uninitialized byte read in get_mm_cmdline()

2019-07-12 Thread Alexey Izbyshev
On 7/13/19 12:17 AM, Jakub Jankowski wrote: > On 2019-07-12, Alexey Izbyshev wrote: > >> On 7/12/19 8:46 PM, Alexey Dobriyan wrote: >>> The proper fix to all /proc/*/cmdline problems is to revert >>> >>> f5b65348fd77839b50e79bc0a5e536832ea52d8d

Re: [PATCH] proc: Fix uninitialized byte read in get_mm_cmdline()

2019-07-12 Thread Alexey Izbyshev
On 7/12/19 8:46 PM, Alexey Dobriyan wrote: > On Fri, Jul 12, 2019 at 06:36:26PM +0200, Oleg Nesterov wrote: >> On 07/12, Alexey Izbyshev wrote: >>> >>> --- a/fs/proc/base.c >>> +++ b/fs/proc/base.c >>> @@ -275,6 +275,8 @@ static ssize_t get_mm_cmdlin

[PATCH] proc: Fix uninitialized byte read in get_mm_cmdline()

2019-07-12 Thread Alexey Izbyshev
ss_remote_vm(). Fixes: f5b65348fd77 ("proc: fix missing final NUL in get_mm_cmdline() rewrite") Cc: Alexey Dobriyan Cc: Oleg Nesterov Signed-off-by: Alexey Izbyshev --- This patch was initially sent to accompanied with a little program that exploits the bug to dump the kernel page u