Re: [PATCH] proc: meminfo: Replace kB with KiB in output

On 11 April 2016 at 08:12, Michal Hocko wrote: > On Sun 10-04-16 17:23:11, Alexandru Juncu wrote: >> Current values are based on multiples of 1024 (powers of 2) >> which means that the values in meminfo are not kilobytes >> (1000 bytes) but kibibytes (1024 bytes). The corre

[RFC] proc: meminfo: Replace kB with KiB in output

Hi! I was helping somebody write some documentation about meminfo and I started explaining that memory values are mostly multiples of 1024 and that binary prefixes are preferred. The output of /proc/meminfo is hardcoded to be in 'kB' which should mean 1000 bytes (one kilobytes). But judging by t

[PATCH] proc: meminfo: Replace kB with KiB in output

Current values are based on multiples of 1024 (powers of 2) which means that the values in meminfo are not kilobytes (1000 bytes) but kibibytes (1024 bytes). The correct prefix for that would be 'Ki' so the output should be 'KiB'. Signed-off-by: Alexandru Juncu --- fs

[PATCH] dm1105: remove unneeded not-null test

i2c_adap is a field of a struct and will always be allocated so its address will never be null. Suggested by coccinelle, manually verified. Signed-off-by: Alexandru Juncu --- drivers/media/pci/dm1105/dm1105.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media

Re: [PATCH] TTY: synclink: replace bitmasks add operation with OR operation.

On 27 July 2013 11:14, Alexandru Juncu wrote: > Found with coccinelle, manually fixed and verified. > > Signed-off-by: Alexandru Juncu > --- > drivers/tty/synclink.c | 130 > > 1 file changed, 65 insertions(+), 65 deletion

[PATCH] TTY: synclink: replace bitmasks add operation with OR operation.

Found with coccinelle, manually fixed and verified. Signed-off-by: Alexandru Juncu --- drivers/tty/synclink.c | 130 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/drivers/tty/synclink.c b/drivers/tty/synclink.c index 8eaf1ab

[PATCH] MIPS:Netlogic: Remove redundant value in operation.

From: Alexandru Juncu Removed parameters checked twice in logical OR operation. Suggested by coccinelle and manually verified. Signed-off-by: Alexandru Juncu --- arch/mips/netlogic/xlp/usb-init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/mips/netlogic/xlp/usb

Re: [PATCH] lustre:libcfs: remove redundant code.

On 19 July 2013 19:07, Paul Bolle wrote: > On Fri, 2013-07-19 at 08:46 -0700, Greg Kroah-Hartman wrote: >> Doesn't matter, if there are no users, please just remove it. > > Is that, basically, your approach to staging cleanups? > > I ask because I noticed that "drivers/staging/lustre/lustre/ptlrpc

Re: [PATCH] lustre:libcfs: remove redundant code.

On 19 July 2013 18:21, Pekka Enberg wrote: > On Fri, Jul 19, 2013 at 6:13 PM, Alexandru Juncu wrote: >> I was thinking the same thing, but I hesitated because I didn't know >> how used it was and I didn't want to break something. > > "git grep cfs_strdup&

[PATCH] lustre:libcfs: remove redundant code.

Found using coccinelle. It suggested kmalloc/strcpy should be replaced with kstrdup, but the entire function can be replaced by kstrdup. Signed-off-by: Alexandru Juncu --- drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 13 + 1 file changed, 1 insertion(+), 12 deletions

Re: [PATCH] lustre:libcfs: remove redundant code.

On 19 July 2013 18:08, Pekka Enberg wrote: > On Fri, Jul 19, 2013 at 5:45 PM, Alexandru Juncu wrote: >> Found using coccinelle. It suggested kmalloc/strcpy should be replaced >> with kstrdup, but the entire function can be replaced by kstrdup. >> >> Sig

[PATCH] pcmcia: synclink_cs: replace sum of bitmasks with OR operation.

Suggested by coccinelle and manually verified. Signed-off-by: Alexandru Juncu --- drivers/char/pcmcia/synclink_cs.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c index

[PATCH] mISDN: replace sum of bitmasks with OR operation.

Suggested by coccinelle and manually verified. Signed-off-by: Alexandru Juncu --- drivers/isdn/hardware/mISDN/hfcpci.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c index a7e4939

Re: [RFC] Script for isolating maintainer email.

On 13 July 2013 11:01, Borislav Petkov wrote: > On Sat, Jul 13, 2013 at 10:40:41AM +0300, Alexandru Juncu wrote: >> Hello! >> >> I found the need for a script that doesn't require me to copy part of the >> output from get_maintainer.pl into git send-email and c

[RFC] Script for isolating maintainer email.

body finds it useful. Used on top of get_maintainer.pl, it generates the list of emails required for git send-email. The output can be used as a process expansion into the arguments of git send-email. Example: git send-email $(scripts/get_email.sh my.patch) my.patch Signed-off-by: Alexa

Re: [PATCH] NVMe: replace kmalloc and memset with kzalloc.

It was submitted on the LKML on 6/9 by Tushar Behera. > > Thanks, > -Vishal > > On 7/12/13 9:16 AM, "Alexandru Juncu" wrote: > >>Found using coccinelle. >> >>Signed-off-by: Alexandru Juncu >>--- >> drivers/block/nvme-scsi.c | 24

[PATCH] NVMe: replace kmalloc and memset with kzalloc.

Found using coccinelle. Signed-off-by: Alexandru Juncu --- drivers/block/nvme-scsi.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c index 102de2f..4a4ff4e 100644 --- a/drivers/block/nvme-scsi.c

[PATCH] matroxfb: replace kmalloc and memset with kzalloc.

Signed-off-by: Alexandru Juncu --- drivers/video/matrox/matroxfb_base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/matrox/matroxfb_base.c b/drivers/video/matrox/matroxfb_base.c index 401a56e..2456529 100644 --- a/drivers/video/matrox/matroxfb_base.c