[nouveau] WARNING: possible circular locking dependency detected in linux-next

2021-02-09 Thread Alexander Kapshuk
nouveau/nv84_xuc00f [ 358.920107] nouveau :01:00.0: vp: init failed, -2 [ 358.920523] nouveau :01:00.0: Direct firmware load for nouveau/nv84_xuc103 failed with error -2 [ 358.920556] nouveau :01:00.0: bsp: unable to load firmware nouveau/nv84_xuc103 [ 358.920565] nouveau :01:00.0: bsp: init failed, -2 Thanks. Alexander Kapshuk

Re: [PATCH] ver_linux: Eliminate duplicate code in ldconfig processing logic

2021-01-21 Thread Alexander Kapshuk
On Fri, Jan 8, 2021 at 1:26 PM Alexander Kapshuk wrote: > > The code that acquires the version strings for libc and libcpp is > identical, as is the printversion call. The only difference being the > name of the library being printed. > > Refactor the code by unifying the bits

[PATCH] ver_linux: Eliminate duplicate code in ldconfig processing logic

2021-01-08 Thread Alexander Kapshuk
The code that acquires the version strings for libc and libcpp is identical, as is the printversion call. The only difference being the name of the library being printed. Refactor the code by unifying the bits that are common to both libraries. Signed-off-by: Alexander Kapshuk --- scripts

Re: [PATCH v2] drm/nouveau/kms: Fix NULL pointer dereference in nouveau_connector_detect_depth

2020-11-03 Thread Alexander Kapshuk
On Tue, Oct 13, 2020 at 3:47 PM Alexander Kapshuk wrote: > > This oops manifests itself on the following hardware: > 01:00.0 VGA compatible controller: NVIDIA Corporation G98M [GeForce G 103M] > (rev a1) > > Oct 09 14:17:46 lp-sasha kernel: BUG: kernel NULL pointer deref

[PATCH v2] drm/nouveau/kms: Fix NULL pointer dereference in nouveau_connector_detect_depth

2020-10-13 Thread Alexander Kapshuk
NULL. Fix this by setting edid to the value of the just acquired nv_connector->edid and executing the body of nouveau_connector_set_edid only if nv_connector->edid and edid point to different memory addresses thus preventing nv_connector->edid from being turned into a dangling pointer. Fixes: f28e32d3906e (&qu

[PATCH] drm/nouveau/kms: Fix NULL pointer dereference in nouveau_connector_detect_depth

2020-10-09 Thread Alexander Kapshuk
by setting edid to the value of the just acquired nv_connector->edid and call nouveau_connector_set_edid in the out label only if nv_connector->edid and edid point to different memory addresses thus preventing nv_connector->edid from being turned into a dangling pointer. Fixes: f28e32d3906

Re: nouveau PUSHBUFFER_ERR on 5.9.0-rc2-next-20200824

2020-08-30 Thread Alexander Kapshuk
On Mon, Aug 31, 2020 at 7:30 AM Ben Skeggs wrote: > > On Tue, 25 Aug 2020 at 17:21, Alexander Kapshuk > wrote: > > > > Since upgrading to linux-next based on 5.9.0-rc1 and 5.9.0-rc2 I have > > had my mouse pointer disappear soon after logging in, and I have >

nouveau PUSHBUFFER_ERR on 5.9.0-rc2-next-20200824

2020-08-24 Thread Alexander Kapshuk
Since upgrading to linux-next based on 5.9.0-rc1 and 5.9.0-rc2 I have had my mouse pointer disappear soon after logging in, and I have observed the system freezing temporarily when clicking on objects and when typing text. I have also found records of push buffer errors in dmesg output: [ 6625.4503

Re: [PATCH] kernel/signal.c: Export symbol __lock_task_sighand

2020-06-22 Thread Alexander Kapshuk
On Mon, Jun 22, 2020 at 11:40 AM Christian Brauner wrote: > > On Sun, Jun 21, 2020 at 03:54:37PM +0200, Dominique Martinet wrote: > > Alexander Kapshuk wrote on Sun, Jun 21, 2020: > > > Export symbol __lock_task_sighand, so it is accessible from code compiled > > >

Re: [PATCH] net/9p: Validate current->sighand in client.c

2020-06-21 Thread Alexander Kapshuk
On Sun, Jun 21, 2020 at 4:56 PM Dominique Martinet wrote: > > Alexander Kapshuk wrote on Sun, Jun 21, 2020: > > Fix rcu not being dereferenced cleanly by using the task > > helpers (un)lock_task_sighand instead of spin_lock_irqsave and > > spin_unlock_irqrestore to ensu

[PATCH] net/9p: Validate current->sighand in client.c

2020-06-21 Thread Alexander Kapshuk
Fix rcu not being dereferenced cleanly by using the task helpers (un)lock_task_sighand instead of spin_lock_irqsave and spin_unlock_irqrestore to ensure current->sighand is a valid pointer as suggested in the email referenced below. Signed-off-by: Alexander Kapshuk Link: https://lore.kernel.

[PATCH] kernel/signal.c: Export symbol __lock_task_sighand

2020-06-21 Thread Alexander Kapshuk
See https://lore.kernel.org/lkml/20200620201456.14304-1-alexander.kaps...@gmail.com/. Signed-off-by: Alexander Kapshuk Reported-by: kernel test robot Link: https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org/thread/TMTLPYU6A522JH2VCN3PNZVAP6EE5MDF/ --- kernel/signal.c | 1 + 1 file changed, 1 insertio

Re: [PATCH] net/9p: Validate current->sighand in client.c

2020-06-21 Thread Alexander Kapshuk
On Sun, Jun 21, 2020 at 1:57 PM Dominique Martinet wrote: > > Alexander Kapshuk wrote on Sun, Jun 21, 2020: > > Thanks for your feedback. > > Shall I simply resend the v2 patch with the commit message reworded as > > you suggested, or should I make it a v3 patch instead? &

Re: [PATCH] net/9p: Validate current->sighand in client.c

2020-06-21 Thread Alexander Kapshuk
On Sun, Jun 21, 2020 at 11:45 AM Dominique Martinet wrote: > > Alexander Kapshuk wrote on Sat, Jun 20, 2020: > > Use (un)lock_task_sighand instead of spin_lock_irqsave and > > spin_unlock_irqrestore to ensure current->sighand is a valid pointer as > > suggested in

[PATCH] net/9p: Validate current->sighand in client.c

2020-06-20 Thread Alexander Kapshuk
Use (un)lock_task_sighand instead of spin_lock_irqsave and spin_unlock_irqrestore to ensure current->sighand is a valid pointer as suggested in the email referenced below. Signed-off-by: Alexander Kapshuk Link: https://lore.kernel.org/lkml/20200618190807.GA20699@nautica/ --- net/9p/clien

Re: [PATCH] net/9p: Fix sparse rcu warnings in client.c

2020-06-18 Thread Alexander Kapshuk
On Thu, Jun 18, 2020 at 10:08 PM Dominique Martinet wrote: > > Alexander Kapshuk wrote on Thu, Jun 18, 2020: > > Address sparse nonderef rcu warnings: > > net/9p/client.c:790:17: warning: incorrect type in argument 1 (different > > address spaces) > > net/9p/clien

Re: [PATCH] net/9p: Fix sparse endian warning in trans_fd.c

2020-06-18 Thread Alexander Kapshuk
On Thu, Jun 18, 2020 at 10:09 PM Dominique Martinet wrote: > > Alexander Kapshuk wrote on Thu, Jun 18, 2020: > > Address sparse endian warning: > > net/9p/trans_fd.c:932:28: warning: incorrect type in assignment (different > > base types) > > net/9p/trans_fd.c:

[PATCH] net/9p: Fix sparse endian warning in trans_fd.c

2020-06-18 Thread Alexander Kapshuk
Address sparse endian warning: net/9p/trans_fd.c:932:28: warning: incorrect type in assignment (different base types) net/9p/trans_fd.c:932:28:expected restricted __be32 [addressable] [assigned] [usertype] s_addr net/9p/trans_fd.c:932:28:got unsigned long Signed-off-by: Alexander

[PATCH] net/9p: Fix sparse rcu warnings in client.c

2020-06-18 Thread Alexander Kapshuk
spinlock [noderef] * Signed-off-by: Alexander Kapshuk --- net/9p/client.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/net/9p/client.c b/net/9p/client.c index fc1f3635e5dd..807e0e2e2e5a 100644 --- a/net/9p/client.c +++ b/net/9p/client.c @@ -787,9 +787,15

[tip: core/objtool] x86/insn: Fix awk regexp warnings

2019-10-01 Thread tip-bot2 for Alexander Kapshuk
The following commit has been merged into the core/objtool branch of tip: Commit-ID: 700c1018b86d0d4b3f1f2d459708c0cdf42b521d Gitweb: https://git.kernel.org/tip/700c1018b86d0d4b3f1f2d459708c0cdf42b521d Author:Alexander Kapshuk AuthorDate:Tue, 24 Sep 2019 07:46:59 +03:00

Re: [PATCH RESEND] gen-insn-attr-x86.awk: Fix regexp warnings

2019-09-29 Thread Alexander Kapshuk
On Mon, Sep 30, 2019 at 8:35 AM Borislav Petkov wrote: > > On Tue, Sep 24, 2019 at 07:46:59AM +0300, Alexander Kapshuk wrote: > > gawk 5.0.1 generates the regexp warnings shown below: > > GEN /home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c > > awk: ..

[PATCH RESEND] gen-insn-attr-x86.awk: Fix regexp warnings

2019-09-23 Thread Alexander Kapshuk
s needing escaping, so 'unescape' them. https://www.gnu.org/software/gawk/manual/html_node/Escape-Sequences.html Running diff on the output generated by the script before and after applying the patch reported no differences. Signed-off-by: Alexander Kapshuk Reported-by: kbuild test robot

Re: [PATCH RESEND] gen-insn-attr-x86.awk: Fix regexp warnings

2019-09-23 Thread Alexander Kapshuk
On Mon, Sep 23, 2019 at 1:31 PM Borislav Petkov wrote: > > + Masami. > > On Sun, Sep 22, 2019 at 06:03:28PM +0300, Alexander Kapshuk wrote: > > This patch fixes the regexp warnings shown below: > > Avoid having "This patch" or "This commit" in the co

Re: [PATCH RESEND] gen-insn-attr-x86.awk: Fix regexp warnings

2019-09-23 Thread Alexander Kapshuk
On Mon, Sep 23, 2019 at 12:19 PM Borislav Petkov wrote: > > On Sun, Sep 22, 2019 at 06:03:28PM +0300, Alexander Kapshuk wrote: > > This patch fixes the regexp warnings shown below: > > GEN /home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c > > awk: ../arch

[PATCH RESEND] gen-insn-attr-x86.awk: Fix regexp warnings

2019-09-22 Thread Alexander Kapshuk
/lib/inat-tables.c ~/tmp/inat-tables.c; echo $? 0 [Debugging output] DBG:ext:(66&F2) DBG:match(ext, ...):(66&F2) DBG:match(..., lprefix3_expr):\((F2|!F3|66&F2)\) Signed-off-by: Alexander Kapshuk Reported-by: kbuild test robot --- arch/x86/tools/gen-insn-attr-x86.awk | 4 ++--

[PATCH] gen-insn-attr-x86.awk: Fix regexp warnings

2019-09-21 Thread Alexander Kapshuk
F2) DBG:match(..., lprefix3_expr):\((F2|!F3|66&F2)\) Signed-off-by: Alexander Kapshuk --- arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/tools/gen-insn-attr-x86.awk b/arch/x86/tools/gen-insn-attr-x86.awk index b02a36b2c14f..a

Re: Kernel panic during drm/nouveau init 5.3.0-rc7-next-20190903

2019-09-09 Thread Alexander Kapshuk
On Mon, Sep 9, 2019 at 1:21 PM Stephen Rothwell wrote: > > Hi, > > On Mon, 9 Sep 2019 20:11:59 +1000 Stephen Rothwell > wrote: > > > > If you are bisecting linux-next, I will suggest bisecting between the > > stable branch on linux-next (which is just Linus' tree when I started > > that day) and

Re: Kernel panic during drm/nouveau init 5.3.0-rc7-next-20190903

2019-09-08 Thread Alexander Kapshuk
On Sat, Sep 07, 2019 at 12:32:41PM +0200, Daniel Vetter wrote: > On Sat, Sep 7, 2019 at 11:05 AM Alexander Kapshuk > wrote: > > > > To Whom It May Concern > > > > Every kernel I have built since 5.3.0-rc2-next-20190730 and up to > > 5.3.0-rc7-next-20190

Re: [PATCH AUTOSEL 4.19 06/42] scripts/sphinx-pre-install: fix script for RHEL/CentOS

2019-08-03 Thread Alexander Kapshuk
On Sat, Aug 3, 2019 at 1:37 PM Mauro Carvalho Chehab wrote: > > Em Sat, 3 Aug 2019 13:31:30 +0300 > Alexander Kapshuk escreveu: > > > > - if (! $system_release =~ /Fedora/) { > > > + if (!($system_release =~ /Fedora/)) { > > >

Re: [PATCH AUTOSEL 4.19 06/42] scripts/sphinx-pre-install: fix script for RHEL/CentOS

2019-08-03 Thread Alexander Kapshuk
On Sat, Aug 3, 2019 at 11:19 AM Sasha Levin wrote: > > From: Mauro Carvalho Chehab > > [ Upstream commit b308467c916aa7acc5069802ab76a9f657434701 ] > > There's a missing parenthesis at the script, with causes it to > fail to detect non-Fedora releases (e. g. RHEL/CentOS). > > Tested with Centos 7

Re: Linux 5.2-rc1 - module name conflict

2019-05-21 Thread Alexander Kapshuk
On Tue, May 21, 2019 at 4:01 AM Shuah Khan wrote: > > Hi all, > > I am seeing the following warning on Linux 5.2-rc1 > > warning: same basename if the following are built as modules: >drivers/regulator/88pm800.ko >drivers/mfd/88pm800.ko > > My config has: > > CONFIG_MFD_88PM800=m > > CONFI

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-17 Thread Alexander Kapshuk
On Fri, May 17, 2019 at 11:58 AM Bernd Petrovitsch wrote: > > On 17/05/2019 10:16, Alexander Kapshuk wrote: > [...] > > The 'xargs' '-r' flag is a GNU extension. > > If POSIX compliance is important here, the use of 'cat', 'xargs'

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-17 Thread Alexander Kapshuk
On Fri, May 17, 2019 at 8:33 AM Masahiro Yamada wrote: > > In the recent build test of linux-next, Stephen saw a build error > caused by a broken .tmp_versions/*.mod file: > > https://lkml.org/lkml/2019/5/13/991 > > drivers/net/phy/asix.ko and drivers/net/usb/asix.ko have the same > basename, an

[PATCH] ver_linux: Assign constant RE to variable name for clarity

2019-01-05 Thread Alexander Kapshuk
about the details of implementation. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_linux index a6c728db05ce..810e608baa24 100755 --- a/scripts/ver_linux +++ b/scripts/ver_linux

Re: [PATCH] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-13 Thread Alexander Kapshuk
On Tue, Nov 13, 2018 at 8:32 PM Brian Norris wrote: > > Hi Alexander, > > On Tue, Nov 13, 2018 at 12:36 AM Alexander Kapshuk > wrote: > > > > On Tue, Nov 13, 2018 at 2:09 AM Brian Norris > > wrote: > > > > > > On Mon, Nov 12, 2018 at 10:42:2

Re: [PATCH] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-13 Thread Alexander Kapshuk
On Tue, Nov 13, 2018 at 2:09 AM Brian Norris wrote: > > On Mon, Nov 12, 2018 at 10:42:26AM +0200, Alexander Kapshuk wrote: > > An even simpler approach would be: > > > > { > > git --no-optional-locks status -uno --porcelain 2>/dev/null || > >

Re: [PATCH] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-12 Thread Alexander Kapshuk
On Sun, Nov 11, 2018 at 9:59 PM Alexander Kapshuk wrote: > > On Sun, Nov 11, 2018 at 7:41 PM Genki Sky wrote: > > > > Hi Alexander, > > > > On Sun, 11 Nov 2018 16:48:38 +0200, Alexander Kapshuk > > wrote: > > > Piping the output of the git command

Re: [PATCH] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-11 Thread Alexander Kapshuk
On Sun, Nov 11, 2018 at 7:41 PM Genki Sky wrote: > > Hi Alexander, > > On Sun, 11 Nov 2018 16:48:38 +0200, Alexander Kapshuk > wrote: > > Piping the output of the git command to grep and using the return status > > of grep as the test condition within the if block,

Re: [PATCH] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-11 Thread Alexander Kapshuk
On Sun, Nov 11, 2018 at 4:48 PM Alexander Kapshuk wrote: > > On Sat, Nov 10, 2018 at 10:12 PM Genki Sky wrote: > > > > Hi Andreas, > > > > On Sat, 10 Nov 2018 11:42:11 +0100, Andreas Schwab > > wrote: > > > On Nov 10 2018, Genki Sky wrote: >

Re: [PATCH] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-11 Thread Alexander Kapshuk
On Sat, Nov 10, 2018 at 10:12 PM Genki Sky wrote: > > Hi Andreas, > > On Sat, 10 Nov 2018 11:42:11 +0100, Andreas Schwab > wrote: > > On Nov 10 2018, Genki Sky wrote: > > > On Fri, 9 Nov 2018 10:34:37 -0800, Brian Norris > > > wrote: > > >> + git_status="$(git --no-optional-locks sta

Re: Inclusion of commit e54192b48da7 into stable tree?

2018-09-16 Thread Alexander Kapshuk
On Sun, Sep 16, 2018 at 10:11 PM Rob Herring wrote: > > On Sat, Sep 15, 2018 at 8:35 AM Alexander Kapshuk > wrote: > > > > Is this commit queued up for inclusion into the stable tree? > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/driver

Inclusion of commit e54192b48da7 into stable tree?

2018-09-15 Thread Alexander Kapshuk
Is this commit queued up for inclusion into the stable tree? https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/of/base.c?h=next-20180913&id=e54192b48da75f025ae4b277925eaf6aca1d13bd Applying the patch on top of v4.18.8 fixes the booting problem for me. The contents

Re: please revert commit ce8556cca6 "kbuild: verify that $DEPMOD is installed" introduced in v4.18.4.

2018-08-23 Thread Alexander Kapshuk
On Thu, Aug 23, 2018 at 05:38:27PM +0900, Masahiro Yamada wrote: > Hi Randy, > > > 2018-08-23 8:33 GMT+09:00 Randy Dunlap : > > On 08/22/2018 11:53 AM, H. Nikolaus Schaller wrote: > >> This patch requires that /sbin/depmod is installed and installable on > >> the build host. > >> > >> But not all

[tip:perf/urgent] perf tools: Fix check-headers.sh AND list path of execution

2018-08-18 Thread tip-bot for Alexander Kapshuk
Commit-ID: 51d8aac236493833acf60d9c3b6c42437a18da36 Gitweb: https://git.kernel.org/tip/51d8aac236493833acf60d9c3b6c42437a18da36 Author: Alexander Kapshuk AuthorDate: Sat, 11 Aug 2018 11:39:15 +0300 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 13 Aug 2018 15:46:19 -0300 perf

Re: [PATCH] perf tools: Fix check-headers.sh AND list path of execution

2018-08-13 Thread Alexander Kapshuk
On Mon, Aug 13, 2018 at 9:58 PM Arnaldo Carvalho de Melo wrote: > Thanks, applied the three patches to acme/perf/core. > > - Arnaldo Thanks.

Re: [PATCH] perf tools: Fix check-headers.sh AND list path of execution

2018-08-13 Thread Alexander Kapshuk
On Mon, Aug 13, 2018 at 2:16 PM Jiri Olsa wrote: > > On Sat, Aug 11, 2018 at 11:39:15AM +0300, Alexander Kapshuk wrote: > > The '||' path of execution in the 'test' block of the check_2() function > > may also be taken if file2 does not exist, in which case

[PATCH] perf tools: Fix check-headers.sh AND list path of execution

2018-08-11 Thread Alexander Kapshuk
n at 'file2' The proposed patch converts the code following the '&&' operator into a compound list to be executed in the current process environment only if file2 does exist. Should the files being compared differ, a diff command to compare the files concerned is printed on

Re: [PATCH 3/4] perf tools: Fix check-headers.sh output file variables

2018-07-24 Thread Alexander Kapshuk
On Mon, Jul 23, 2018, 08:01 Jiri Olsa wrote: > On Fri, Jul 20, 2018 at 06:22:49PM +0300, Alexander Kapshuk wrote: > > On Fri, Jul 20, 2018 at 6:16 PM Jiri Olsa wrote: > > > > > > On Fri, Jul 20, 2018 at 11:57:45AM -0300, Arnaldo Carvalho de Melo > wrote: > &g

Re: [PATCH 3/4] perf tools: Fix check-headers.sh output file variables

2018-07-20 Thread Alexander Kapshuk
On Fri, Jul 20, 2018 at 6:16 PM Jiri Olsa wrote: > > On Fri, Jul 20, 2018 at 11:57:45AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, Jul 20, 2018 at 01:00:35PM +0200, Jiri Olsa escreveu: > > > The warning message in check_w function uses wrongly > > > the $file variable instead of $file1 and

[PATCH 2/2] ver_linux: Do not check for ver_linux pattern in version function

2018-05-31 Thread Alexander Kapshuk
pattern being found in the output being parsed may thus be safely omitted. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ver_linux b/scripts/ver_linux index e1dc041f903f..a6c728db05ce 100755 --- a/scripts/ver_linux

[PATCH 1/2] ver_linux: Process input coming from procmaps that matches libc only

2018-05-31 Thread Alexander Kapshuk
Currently, input coming from /proc/self/maps is split into fields without checking whether or not it matches libc.so. This is not efficient. All text processing should only be performed on lines of input that match libc.so. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 12

[PATCH 2/2] ver_linux: Drop redundant calls to system() to test if file is readable

2018-05-12 Thread Alexander Kapshuk
should not be. Instead of testing if a file is accessible and readable via calls to system("test -r " file), rely on the value returned by getline to perform this kind of testing. Getline returns -1 on error, with the code within the while loops not being run. Signed-off-by: Alexander K

[PATCH 1/2] ver_linux: Move stderr redirection from function parameter to function body

2018-05-12 Thread Alexander Kapshuk
Remove stderr redirection to stdout from all the parameters to the version() function, and put it with the body of the version() function instead. This improves code readability. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 53 --- 1 file

Re: [PATCH 1/3] leaking_addresses: skip all /proc/PID except /proc/1

2018-03-03 Thread Alexander Kapshuk
On Thu, Mar 1, 2018 at 11:06 PM, Tobin C. Harding wrote: > On Tue, Feb 27, 2018 at 03:45:09PM +1100, Tobin C. Harding wrote: >> When the system is idle it is likely that most files under /proc/PID >> will be identical for various processes. Scanning _all_ the PIDs under >> /proc is unnecessary an

Re: [PATCH 1/3] leaking_addresses: skip all /proc/PID except /proc/1

2018-02-26 Thread Alexander Kapshuk
On Tue, Feb 27, 2018 at 6:45 AM, Tobin C. Harding wrote: > When the system is idle it is likely that most files under /proc/PID > will be identical for various processes. Scanning _all_ the PIDs under > /proc is unnecessary and implies that we are thoroughly scanning /proc. > This is _not_ the ca

Re: [PATCH] vboxvideo: Fix incorrect type in assignment sparse warning

2018-01-06 Thread Alexander Kapshuk
On Sat, Jan 6, 2018 at 10:00 PM, Hans de Goede wrote: > Hi, > > > On 06-01-18 20:56, Alexander Kapshuk wrote: >> >> On Sat, Jan 6, 2018 at 9:43 PM, Hans de Goede wrote: >>> >>> HI, >>> >>> >>> On 06-01-18 20:30, Alexander

Re: [PATCH] vboxvideo: Fix incorrect type in assignment sparse warning

2018-01-06 Thread Alexander Kapshuk
On Sat, Jan 6, 2018 at 9:43 PM, Hans de Goede wrote: > HI, > > > On 06-01-18 20:30, Alexander Kapshuk wrote: >> >> On Sat, Jan 6, 2018 at 6:00 PM, Hans de Goede wrote: >>> >>> Hi, >>> >>> >>> On 06-01-18 15:20, Alexander K

[PATCH] vboxvideo: Fix incorrect type in assignment sparse warning

2018-01-06 Thread Alexander Kapshuk
On Sat, Jan 6, 2018 at 6:00 PM, Hans de Goede wrote: > Hi, > > > On 06-01-18 15:20, Alexander Kapshuk wrote: >> >> On Mon, Dec 25, 2017 at 04:42:59PM +0200, Alexander Kapshuk wrote: >>> >>> Sparse emitted the following warning: >>> ../drivers/sta

[PATCH] vboxvideo: Fix incorrect type in assignment sparse warning

2018-01-06 Thread Alexander Kapshuk
On Mon, Dec 25, 2017 at 04:42:59PM +0200, Alexander Kapshuk wrote: > Sparse emitted the following warning: > ../drivers/staging/vboxvideo/vbox_fb.c:173:27: warning: incorrect type in > assignment (different address spaces) > ../drivers/staging/vboxvideo/vbox_fb.c:173:27:expected c

[PATCH] vboxvideo: Fix incorrect type in assignment sparse warning

2017-12-25 Thread Alexander Kapshuk
ment to vbva to fix the warning. Signed-off-by: Alexander Kapshuk --- drivers/staging/vboxvideo/vbox_fb.c | 2 +- drivers/staging/vboxvideo/vbox_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbo

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-04 Thread Alexander Kapshuk
On Mon, Dec 4, 2017 at 12:20 PM, wrote: > On Mon, 2017-12-04 at 19:21 +1100, Tobin C. Harding wrote: >> On Mon, Dec 04, 2017 at 10:51:53AM +0530, Kaiwan N Billimoria wrote: >> > > --- >> > diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl >> > index 9906dcf8b807..260b52e456

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-11-29 Thread Alexander Kapshuk
On Wed, Nov 29, 2017 at 12:16 PM, Tobin C. Harding wrote: > On Wed, Nov 29, 2017 at 09:59:59AM +0200, Alexander Kapshuk wrote: >> On Tue, Nov 28, 2017 at 11:10 PM, Tobin C. Harding wrote: >> > On Tue, Nov 28, 2017 at 03:16:24PM +0200, Alexander Kapshuk wrote: >> >>

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-11-29 Thread Alexander Kapshuk
On Tue, Nov 28, 2017 at 11:10 PM, Tobin C. Harding wrote: > On Tue, Nov 28, 2017 at 03:16:24PM +0200, Alexander Kapshuk wrote: >> On Tue, Nov 28, 2017 at 8:32 AM, Tobin C. Harding wrote: >> > Currently, leaking_addresses.pl only supports scanning 64 bit >> > architectu

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-11-28 Thread Alexander Kapshuk
On Tue, Nov 28, 2017 at 8:32 AM, Tobin C. Harding wrote: > Currently, leaking_addresses.pl only supports scanning 64 bit > architectures. This is due to how the regular expressions are formed. We > can do better than this. 32 architectures can be supported if we take > into consideration the kerne

Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination

2017-03-14 Thread Alexander Kapshuk
s##0) ^ rk[4 * i + 1]; > \ > d##2 = TE0(s##2) ^ TE1(s##3) ^ TE2(s##0) ^ TE3(s##1) ^ rk[4 * i + 2]; > \ > d##3 = TE0(s##3) ^ TE1(s##0) ^ TE2(s##1) ^ TE3(s##2) ^ rk[4 * i + 3]; > \ > } while (0) > > On Tue, Mar 14, 2017 at 5:02 PM, Alexander Kapshuk > wr

Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination

2017-03-14 Thread Alexander Kapshuk
On Tue, Mar 14, 2017 at 1:26 PM, Pushkar Jambhlekar wrote: > Description: > There should not be ';' after do ... while(0) in macro defination > > Signed-off-by: Pushkar Jambhlekar > --- > drivers/staging/rtl8188eu/core/rtw_security.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: Linux 4.10.2

2017-03-12 Thread Alexander Kapshuk
On Sun, Mar 12, 2017 at 10:11 PM, Ilia Mirkin wrote: > On Sun, Mar 12, 2017 at 3:05 PM, Greg KH wrote: >> On Sun, Mar 12, 2017 at 01:51:24PM -0500, Robert Nelson wrote: >>> On Sun, Mar 12, 2017 at 8:05 AM, Greg KH wrote: >>> > I'm announcing the release of the 4.10.2 kernel. >>> > >>> > All user

[PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations

2017-03-04 Thread Alexander Kapshuk
Use a single string literal as the fmt argument passed to dev_err() instead of multiple string literals split with an embedded backslash character. Signed-off-by: Alexander Kapshuk --- drivers/staging/fbtft/fb_ssd1331.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations.

2017-02-28 Thread Alexander Kapshuk
On Tue, Feb 28, 2017 at 10:34 PM, Joe Perches wrote: > On Tue, 2017-02-28 at 21:52 +0200, Alexander Kapshuk wrote: >> Use a single fmt string with appropriate verbs as conversion specifiers, >> followed by the original string literals and the integer argument >> instead of

[PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations.

2017-02-28 Thread Alexander Kapshuk
/fbtft/fb_ssd1331.c. Signed-off-by: Alexander Kapshuk --- drivers/staging/fbtft/fb_ssd1331.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c index 26f24e3..6d03041 100644 --- a/drivers/staging

Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER

2016-08-29 Thread Alexander Kapshuk
On Mon, Aug 29, 2016 at 1:11 PM, Jean Delvare wrote: > On Mon, 29 Aug 2016 12:06:34 +0200, Jean Delvare wrote: >> I'm trying to find when the bug was introduced. I have a hard time >> believing it went unnoticed for long. If it fixes your problem I'll >> send a clean patch. > > Broken by: > > comm

[v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER

2016-08-27 Thread Alexander Kapshuk
I get an Oops when loading it87.ko on a 4.7.2 kernel. See below for details: (1). ver_linux If some fields are empty or look unusual you may have an old version. Compare to the current minimal requirements in Documentation/Changes. Linux box1 4.7.2-vanilla #7 SMP Sat Aug 27 09:20:18 EEST 2016 i68

[PATCH 1/3] ver_linux: complete awk implementation

2016-08-22 Thread Alexander Kapshuk
to a function, which makes the script easier to read overall, as well as considerably reduces the number of lines of code. Every attempt has been made to retain the look and the format generated by the current implementation. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux.awk | 89

[PATCH 2/3] ver_linux: shell implementation removed

2016-08-22 Thread Alexander Kapshuk
The shell implementation removed. To be replaced with an all-awk implementation via consecutive patch. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 193 -- 1 file changed, 193 deletions(-) delete mode 100755 scripts/ver_linux

[PATCH 3/3] ver_linux: rename ver_linux.awk to ver_linux

2016-08-22 Thread Alexander Kapshuk
ver_linux.awk renamed to ver_linux. Signed-off-by: Alexander Kapshuk --- scripts/{ver_linux.awk => ver_linux} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename scripts/{ver_linux.awk => ver_linux} (100%) diff --git a/scripts/ver_linux.awk b/scripts/ver_linux similarity ind

Re: Fwd: Fwd: [PATCH 01/32] ver_linux: complete awk implementation

2016-08-22 Thread Alexander Kapshuk
On Mon, Aug 22, 2016 at 1:00 PM, Greg KH wrote: > On Mon, Aug 22, 2016 at 07:14:10AM +0300, Alexander Kapshuk wrote: >> -- Forwarded message -- >> From: Alexander Kapshuk >> Date: Sun, Aug 21, 2016 at 5:07 PM >> Subject: Re: Fwd: [PATCH 01/

Fwd: Fwd: [PATCH 01/32] ver_linux: complete awk implementation

2016-08-21 Thread Alexander Kapshuk
-- Forwarded message -- From: Alexander Kapshuk Date: Sun, Aug 21, 2016 at 5:07 PM Subject: Re: Fwd: [PATCH 01/32] ver_linux: complete awk implementation To: Greg KH On Sun, Aug 21, 2016 at 11:19 AM, Greg KH wrote: > > On Fri, Aug 19, 2016 at 09:12:28PM +0300, Ale

Re: [PATCH 32/32] ver_linux: 'printversion()' function definition

2016-07-02 Thread Alexander Kapshuk
On Tue, Jun 28, 2016 at 5:48 PM, wrote: > On Tue, 28 Jun 2016 17:40:36 +0300, Alexander Kapshuk said: > >> Seeing this is a complete rewrite of the script from the shell >> language into awk, one would not be able to apply the patches >> submitted incrementally to be

Re: [PATCH 32/32] ver_linux: 'printversion()' function definition

2016-06-28 Thread Alexander Kapshuk
On Tue, Jun 28, 2016 at 3:47 PM, wrote: > On Tue, 28 Jun 2016 13:19:06 +0300, Alexander Kapshuk said: >> Definition of the 'printversion()' function. The function tests whether >> the variable that contains the version number is empty, and prints >> the name of the

[PATCH 32/32] ver_linux: 'printversion()' function definition

2016-06-28 Thread Alexander Kapshuk
Definition of the 'printversion()' function. The function tests whether the variable that contains the version number is empty, and prints the name of the utility and its version number as a formatted string, if the version number is not an empty value. Signed-off-by: Alexand

[PATCH 05/32] ver_linux: wrap up call to 'make --version' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'make --version', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/scripts/ver_linux b/scripts

[PATCH 30/32] ver_linux: build a list of kernel modules as a string and print it

2016-06-28 Thread Alexander Kapshuk
Reimplement the code that generates an alphabetically sorted list of kernel modules in awk and print the name of this entry and the list of modules via a function call. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 19 +++ 1 file changed, 7 insertions(+), 12 deletions

[PATCH 07/32] ver_linux: wrap up call to 'mount --version' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'mount --version', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/scripts/ver_linux b/scripts

[PATCH 27/32] ver_linux: wrap up call to 'expr --v' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'expr --v', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_l

[PATCH 02/32] ver_linux: assign the usage message to a variable and print it

2016-06-28 Thread Alexander Kapshuk
This patch assigns the usage message to a 'usage' variable and prints it. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_linux index 30ecc6c..2f1d494 100755 --- a/scripts

[PATCH 03/32] ver_linux: execute 'uname -a' from awk

2016-06-28 Thread Alexander Kapshuk
Execute 'uname -a' using the awk system() function. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_linux index 2f1d494..c509f09 100755 --- a/scripts/ver_linux +++ b/scripts

[PATCH 04/32] ver_linux: wrap up call to 'gcc -dumpversion' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'gcc -dumpversion', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/scripts/ver_linux b/scripts

[PATCH 31/32] ver_linux: 'version()' function definition

2016-06-28 Thread Alexander Kapshuk
Definition of the 'version()' function. The function encapsulates the algorithm that extracts the version number of the utility being queried, and returns it as a value. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 11 +++ 1 file changed, 11 insertions(+) di

[PATCH 08/32] ver_linux: wrap up call to 'depmod -V' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'depmod -V', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_l

[PATCH 10/32] ver_linux: wrap up call to 'fsck.jfs -V' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'fsck.jfs -V', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_l

[PATCH 16/32] ver_linux: wrap up call to 'quota -V' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'quota -V', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_l

[PATCH 20/32] ver_linux: wrap up querying for version of 'Linux C Library' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up querying for version of 'Linux C Library', and the resulting formatted output in an awk function. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_l

[PATCH 14/32] ver_linux: wrap up call to 'pccardctl -V' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'pccardctl -V', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_l

[PATCH 15/32] ver_linux: wrap up call to 'cardmgr -V' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'cardmgr -V', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_l

[PATCH 06/32] ver_linux: wrap up call to 'ld -v' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'ld -v', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_linux ind

[PATCH 12/32] ver_linux: wrap up call to 'fsck.reiser4 -V' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'fsck.reiser4 -V', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_l

[PATCH 13/32] ver_linux: wrap up call to 'xfs_db -V' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'xfs_db -V', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_l

[PATCH 11/32] ver_linux: wrap up call to 'reiserfsck -V' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'reiserfsck -V', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_l

[PATCH 09/32] ver_linux: wrap up call to 'tune2fs' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'tune2fs', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_l

[PATCH 21/32] ver_linux: wrap up call to 'ldd --version' in awk function

2016-06-28 Thread Alexander Kapshuk
Wrap up the call to 'ldd --version', the code to process its output, and the resulting formatted output in awk functions. Signed-off-by: Alexander Kapshuk --- scripts/ver_linux | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_l

  1   2   3   >