Re: [PATCH 1/1] lib: scatterlist: Fix SGL length in sg_split() if !CONFIG_NEED_SG_DMA_LENGTH

2021-04-19 Thread Alexander Egorenkov
Christoph Hellwig writes: > On Sun, Apr 18, 2021 at 08:14:41AM +0000, Alexander Egorenkov wrote: >> If CONFIG_NEED_SG_DMA_LENGTH is NOT enabled then sg_dma_len() is an alias >> for the length field in a SGL. In that case sg_split() wrongly resets >> the length of split SGLs

[PATCH 1/2] lib: scatterlist: Fix loop termination condition in sg_calculate_split()

2021-04-18 Thread Alexander Egorenkov
. Signed-off-by: Alexander Egorenkov --- lib/sg_split.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/sg_split.c b/lib/sg_split.c index 3d9b32084d78..0920affd12ee 100644 --- a/lib/sg_split.c +++ b/lib/sg_split.c @@ -60,15 +60,16 @@ static int

[PATCH 2/2] lib: scatterlist: Fix incorrect SG offset in sg_split_phys()

2021-04-18 Thread Alexander Egorenkov
sg_split_phys() incorrectly resets the offset of all split SGLs but the first one to 0. This is wrong because one of the original SGLs might have the offset != 0. Signed-off-by: Alexander Egorenkov --- lib/sg_split.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/sg_split.c b/lib

[PATCH 1/1] lib: scatterlist: Fix SGL length in sg_split() if !CONFIG_NEED_SG_DMA_LENGTH

2021-04-18 Thread Alexander Egorenkov
If CONFIG_NEED_SG_DMA_LENGTH is NOT enabled then sg_dma_len() is an alias for the length field in a SGL. In that case sg_split() wrongly resets the length of split SGLs to zero after it was set correctly before. Signed-off-by: Alexander Egorenkov --- lib/sg_split.c | 3 ++- 1 file changed, 2

Re: regression: 9a56493f6942 "uts: Use generic ns_common::count" broke makedumpfile 1.6.7

2021-01-11 Thread Alexander Egorenkov
Kirill Tkhai writes: > Hi, Alexander, > > On 16.12.2020 14:02, Mike Galbraith wrote: >> Greetings, >> >> With this commit, bisected and confirmed, kdump stops working here, >> makedumpfile saying "check_release: Can't get the kernel version". > > hasn't your commit 55d9e11398a4 "kdump: append ut

[PATCH v3 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

2020-09-30 Thread Alexander Egorenkov
' available in VMCOREINFO because tools like 'crash-utility' and 'makedumpfile' must be able to read it from crash dumps. Signed-off-by: Alexander Egorenkov --- v2 -> v3: * Added documentation to vmcoreinfo.rst * Use the short form of the commit reference v1 -

[PATCH v2 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

2020-09-24 Thread Alexander Egorenkov
2107.stgit@localhost.localdomain Make the offset of the field 'uts_namespace.name' available in VMCOREINFO because tools like 'crash-utility' and 'makedumpfile' must be able to read it from crash dumps. Signed-off-by: Alexander Egorenkov --- kernel/crash_core.c | 1 + 1 fi