Re: [PATCH RESEND] mac802154: Fix uninit-value access in ieee802154_hdr_push_sechdr

2023-12-14 Thread Alexander Aring
Hi, On Thu, Dec 14, 2023 at 10:01 PM Alexander Aring wrote: > > Hi, > > On Mon, Dec 4, 2023 at 3:57 AM Miquel Raynal > wrote: > > > > Hi Zhang, > > > > zhang_shur...@foxmail.com wrote on Sat, 2 Dec 2023 22:58:52 +0800: > > > > > The syz

Re: [PATCH RESEND] mac802154: Fix uninit-value access in ieee802154_hdr_push_sechdr

2023-12-14 Thread Alexander Aring
Hi, On Mon, Dec 4, 2023 at 3:57 AM Miquel Raynal wrote: > > Hi Zhang, > > zhang_shur...@foxmail.com wrote on Sat, 2 Dec 2023 22:58:52 +0800: > > > The syzkaller reported an issue: > > Subject should start with [PATCH wpan] > > > > > BUG: KMSAN: uninit-value in ieee802154_hdr_push_sechdr > > net

Re: [PATCH] [v2] ieee802154: ca8210: Fix a potential UAF in ca8210_probe

2023-09-26 Thread Alexander Aring
Hi, On Tue, Sep 26, 2023 at 4:29 AM Stefan Schmidt wrote: > > Hello. > > On 26.09.23 10:02, Miquel Raynal wrote: > > Hi Dinghao, > > > > dinghao@zju.edu.cn wrote on Tue, 26 Sep 2023 11:22:44 +0800: > > > >> If of_clk_add_provider() fails in ca8210_register_ext_clock(), > >> it calls clk_unreg

Re: [PATCH] net: mac802154: fix WARNING in ieee802154_del_device

2021-04-12 Thread Alexander Aring
Hi, On Mon, 12 Apr 2021 at 06:58, Pavel Skripkin wrote: > > syzbot reported WARNING in ieee802154_del_device. The problem > was in uninitialized mutex. In case of NL802154_IFTYPE_MONITOR > mutex won't be initialized, but ieee802154_del_device() accessing it. > > Reported-by: syzbot+bf8b5834b7ec22

Re: [PATCH] net: fix shift-out-of-bounds in nl802154_new_interface

2021-04-06 Thread Alexander Aring
Hi, On Mon, 5 Apr 2021 at 15:58, Pavel Skripkin wrote: > > syzbot reported shift-out-of-bounds in nl802154_new_interface. > The problem was in signed representation of enum nl802154_iftype > > enum nl802154_iftype { > /* for backwards compatibility TODO */ > NL802154_IFTYPE_UNSPEC

Re: [PATCH v2] net: mac802154: Fix general protection fault

2021-04-05 Thread Alexander Aring
; gerrit public mirror. I'm using it to check patches with syzbot. Change > ids are useless outside gerrit, so it shouldn't be here. > > Btw, should I sent v2 or this is already fixed? Otherwise the patch looks good. May Stefan can fix this. Acked-by: Alexander Aring - Alex

Re: [PATCH v2] net: mac802154: Fix general protection fault

2021-04-04 Thread Alexander Aring
Hi, On Thu, 4 Mar 2021 at 10:25, Pavel Skripkin wrote: > > syzbot found general protection fault in crypto_destroy_tfm()[1]. > It was caused by wrong clean up loop in llsec_key_alloc(). > If one of the tfm array members is in IS_ERR() range it will > cause general protection fault in clean up fun

Re: [PATCH] net: fix NULL ptr dereference in nl802154_del_llsec_key

2021-04-04 Thread Alexander Aring
Hi, On Sat, 3 Apr 2021 at 11:18, Pavel Skripkin wrote: > > syzbot reported NULL ptr dereference in nl802154_del_llsec_key()[1] > The problem was in case of info->attrs[NL802154_ATTR_SEC_KEY] == NULL. > nla_parse_nested_deprecated()[2] doesn't check this condition before calling > nla_len()[3] >

Re: [PATCH] net: mac802154: Fix null pointer dereference

2021-03-04 Thread Alexander Aring
Hi, On Thu, 4 Mar 2021 at 04:23, Pavel Skripkin wrote: ... > > > > I think this need to be: > > > > if (!IS_ERR_OR_NULL(key->tfm[i])) > > > > otherwise we still run into issues for the current iterator when > > key->tfm[i] is in range of IS_ERR(). > > Oh... I got it completly wrong, I'm sorry. If

Re: [PATCH] net: mac802154: Fix null pointer dereference

2021-03-03 Thread Alexander Aring
Hi, On Wed, 3 Mar 2021 at 11:28, Pavel Skripkin wrote: > > syzbot found general protection fault in crypto_destroy_tfm()[1]. > It was caused by wrong clean up loop in llsec_key_alloc(). > If one of the tfm array members won't be initialized it will cause > NULL dereference in crypto_destroy_tfm()

Re: UBSAN: shift-out-of-bounds in nl802154_new_interface

2021-02-23 Thread Alexander Aring
Hi, On Tue, 23 Feb 2021 at 18:48, Jakub Kicinski wrote: > > Alex, there seems to be a few more syzbot reports for nl802154 beyond > what you posted fixes for. Are you looking at these? Yes, I have it on my list. I will try to fix them at the weekend. - Alex

Re: [RFC net-next 1/4] net: Reserve protocol identifiers for EnOcean

2019-01-31 Thread Alexander Aring
Hi, On Wed, Jan 30, 2019 at 02:42:29AM +0100, Andreas Färber wrote: > Hi Alex, > > Am 29.01.19 um 13:57 schrieb Alexander Aring: > > On Tue, Jan 29, 2019 at 06:01:27AM +0100, Andreas Färber wrote: > >> EnOcean wireless technology is based on ASK (ERP1) and FSK (ERP2) &

Re: [RFC net-next 1/4] net: Reserve protocol identifiers for EnOcean

2019-01-29 Thread Alexander Aring
Hi, On Tue, Jan 29, 2019 at 06:01:27AM +0100, Andreas Färber wrote: > EnOcean wireless technology is based on ASK (ERP1) and FSK (ERP2) modulations > for sub-GHz and on IEEE 802.15.4 for 2.4 GHz. > I am not sure what you try to do here. If I see that correctly you want to add for some special pr

Re: [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig

2018-12-28 Thread Alexander Aring
On Fri, Dec 28, 2018 at 05:57:53AM +0100, Andreas Färber wrote: > Hi Alexander and Xue Liu, > > Am 24.12.18 um 16:32 schrieb Alexander Aring: > > On Tue, Dec 18, 2018 at 02:50:58PM +0100, Xue Liu wrote: > >> On Mon, 17 Dec 2018 at 15:19, Andreas Färber wrote: > >&

Re: [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig

2018-12-24 Thread Alexander Aring
Hi, On Tue, Dec 18, 2018 at 02:50:58PM +0100, Xue Liu wrote: > Hello Andreas, > > On Mon, 17 Dec 2018 at 15:19, Andreas Färber wrote: > > > > Hello Xue Liu, > > > > Am 17.12.18 um 09:50 schrieb Xue Liu: > > > I have a question about the architecture of your module. AFAIK LoRaWAN > > > is already

Re: [PATCH net-next] ieee802154: ca8210: fix possible u8 overflow in ca8210_rx_done

2018-12-11 Thread Alexander Aring
Hi Stefan, On Tue, Dec 11, 2018 at 09:26:37AM +0100, Stefan Schmidt wrote: > Hello Dave. > > On 11.12.18 07:01, David Miller wrote: > > From: YueHaibing > > Date: Tue, 11 Dec 2018 11:13:39 +0800 > > > >> gcc warning this: > >> > >> drivers/net/ieee802154/ca8210.c:730:10: warning: > >> comparis

Re: [bisected] Stack overflow after fs: "switch the IO-triggering parts of umount to fs_pin" (was net namespaces kernel stack overflow)

2018-04-19 Thread Alexander Aring
y for the stuff created by SB_KERNMOUNT mounts, *not* for >> their copies. >> >> Cc: sta...@kernel.org >> Signed-off-by: Al Viro > > Flawless victory! Thanks. > Thanks to all. Also thanks to Kirill for helping me here and doing the main part by bisecting this issue. Finally, my testing stuff which produced this bug also works well now. Tested-by: Alexander Aring - Alex

Re: [PATCH] Bluetooth: 6lowpan: Fix disconnect bug in 6lowpan

2018-01-22 Thread Alexander Aring
Hi, 2018-01-22 8:00 GMT-05:00 Luiz Augusto von Dentz : > Hi Alex, > ... >> >> or is there a special bluetooth API call needed, like the current case >> with debugfs. >> I know hcis are not netdevs, but it bothers me that we running into >> two different worlds on how to deal with that and it just

Re: [PATCH] Bluetooth: 6lowpan: Fix disconnect bug in 6lowpan

2018-01-17 Thread Alexander Aring
Hi, 2018-01-17 7:15 GMT-05:00 Luiz Augusto von Dentz : > Hi, > > On Wed, Jan 17, 2018 at 1:47 AM, Guo Yi wrote: >> This patch fix the bluetooth 6lowpan disconnect fail bug. >> >> The type of the same address type have different define value in HCI layer >> and L2CAP layer.That makes disconnect fa

Re: skb_over_panic using UDP and 6lowpan / fakelb

2017-04-17 Thread Alexander Aring
Hi, sorry for the late reply. On 04/03/2017 07:29 PM, Cong Wang wrote: > (Cc'ing netdev and maintainers) > > On Mon, Mar 27, 2017 at 2:16 AM, David Palma wrote: >> >> Hi, >> >> Sending a simple UDP packet (39 bytes long), over a 6lowpan interface >> (using fakelb), creates a kernel panic (skb_

Re: [ieee802154_unregister_hw] bea5b158ff BUG: scheduling while atomic: swapper/1/0x00000002

2017-02-26 Thread Alexander Aring
Hi, On 02/26/2017 10:43 AM, Fengguang Wu wrote: > Greetings, > > FYI, this debug patch discloses an old-but-still-active bug in > ieee802154/fakelb. The attached reproduce-* script may help debug it. > fixed by: bdca1fd9a6df ("fakelb: fix schedule while atomic"). It should be send to stable.

Re: [PATCH net-next 2/9] libnl: nla_put_le64(): align on a 64-bit area

2016-04-23 Thread Alexander Aring
Hi, On 04/23/2016 07:05 PM, Alexander Aring wrote: ... > > if this is really needed, then nla_put_u64/be64/etc need to be changed also, Okay, I found PATCH 3/9 do it for be64, but what's about u64? - Alex

Re: [PATCH net-next 2/9] libnl: nla_put_le64(): align on a 64-bit area

2016-04-23 Thread Alexander Aring
Hi, On 04/22/2016 06:51 PM, Eric Dumazet wrote: > On Fri, 2016-04-22 at 17:31 +0200, Nicolas Dichtel wrote: >> nla_data() is now aligned on a 64-bit area. >> >> Signed-off-by: Nicolas Dichtel >> --- >> include/net/netlink.h | 8 +--- >> include/net/nl802154.h| 6 ++ >> net/iee

Re: [PATCH] 6lowpan: fix error checking code

2016-02-24 Thread Alexander Aring
d-off-by: Andrzej Hajda Acked-by: Alexander Aring Marcel, can you please apply this patch on bluetooth-next? Thanks. - Alex

Re: [PATCH] mac802154: constify ieee802154_llsec_ops structure

2016-01-04 Thread Alexander Aring
Hi, On Wed, Dec 23, 2015 at 10:36:32PM +0100, Julia Lawall wrote: > The ieee802154_llsec_ops structure is never modified, so declare it as > const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > Acked-by: Alexander Aring Marcel, can you

Re: [PATCH v2 0/8] Raspberry Pi 2 support.

2015-12-22 Thread Alexander Aring
On Mon, Dec 21, 2015 at 03:07:44PM -0800, Eric Anholt wrote: ... > > > > But still getting this panic, your patches does not contain some > > defconfig, so I still try to figure out what I need to enable to get it > > working. Maybe it is some missing config entry which should be enabled. > > > > B

Re: [PATCH v2 0/8] Raspberry Pi 2 support.

2015-12-22 Thread Alexander Aring
On Tue, Dec 22, 2015 at 12:11:32AM +0100, Arnd Bergmann wrote: > On Sunday 20 December 2015, Alexander Aring wrote: > > On Fri, Dec 18, 2015 at 11:08:26AM +0100, Alexander Aring wrote: > > > [0.00] Memory policy: Data cache writeback > > > [0.00] BUG

Re: [PATCH v2 6/8] ARM: bcm2835: Add devicetree for bcm2836 and Raspberry Pi 2 B

2015-12-22 Thread Alexander Aring
On Wed, Dec 16, 2015 at 03:55:13PM -0800, Eric Anholt wrote: > The Pi 2 B ends up like a Pi 1 B+, with the same peripherals and > pinout, but the CPU and memory layout changed to use the 2836. > > Signed-off-by: Eric Anholt > --- > arch/arm/boot/dts/bcm2836-rpi-2-b.dts | 35 > a

Re: [PATCH v2 0/8] Raspberry Pi 2 support.

2015-12-20 Thread Alexander Aring
On Fri, Dec 18, 2015 at 11:08:26AM +0100, Alexander Aring wrote: ... > Uncompressing Linux... done, booting the kernel. > [0.00] Booting Linux on physical CPU 0x0 > [0.00] Initializing cgroup subsys cpuset > [0.00] Initializing cgroup subsys cpu >

Re: [PATCH v2 0/8] Raspberry Pi 2 support.

2015-12-18 Thread Alexander Aring
On Fri, Dec 18, 2015 at 11:08:26AM +0100, Alexander Aring wrote: > Hi Eric, > > On Wed, Dec 16, 2015 at 03:55:07PM -0800, Eric Anholt wrote: > > This is a major rewrite of the previous Raspberry Pi 2 submission. > > SMP support is now included, and the DT includes are cl

Re: [PATCH v2 0/8] Raspberry Pi 2 support.

2015-12-18 Thread Alexander Aring
Hi Eric, On Wed, Dec 16, 2015 at 03:55:07PM -0800, Eric Anholt wrote: > This is a major rewrite of the previous Raspberry Pi 2 submission. > SMP support is now included, and the DT includes are cleaned up to > avoid massive duplication. > > The branch (based on 4.4-rc5, to get the USB regression

Re: [PATCH v2 4/8] ARM: bcm2835: Split the DT for peripherals from the DT for the CPU

2015-12-18 Thread Alexander Aring
Hi Eric, On Wed, Dec 16, 2015 at 03:55:11PM -0800, Eric Anholt wrote: > The set of peripherals remained constant across bcm2835 (Raspberry Pi > 1) and bcm2836 (Raspberry Pi 2), but the CPU was swapped out. Split > the files so that we can include just peripheral setup in 2836. > > Signed-off-by:

Re: [PATCH v2 1/5] power: domain: add pm_genpd_exit

2015-12-09 Thread Alexander Aring
Hi, On Tue, Dec 08, 2015 at 10:59:00AM -0800, Kevin Hilman wrote: > Jon Hunter writes: > > > On 04/12/15 17:45, Eric Anholt wrote: > >> From: Alexander Aring > >> > >> This patch adds function pm_genpd_exit for undo a pm_genpd_init. This > >> is

Re: [PATCH 4/6] net: ieee802154: Remove redundant spi driver bus initialization

2015-07-13 Thread Alexander Aring
On Tue, Jun 23, 2015 at 10:52:52PM +0800, Antonio Borneo wrote: > In ancient times it was necessary to manually initialize the bus > field of an spi_driver to spi_bus_type. These days this is done in > spi_register_driver(), so we can drop the manual assignment. > Marcel, I don't see this patch

Re: [PATCH] mac802154: fix typo in header guard

2015-03-19 Thread Alexander Aring
On Thu, Mar 19, 2015 at 02:46:26PM +0100, Paul Bolle wrote: > On Thu, 2015-03-19 at 14:37 +0100, Alexander Aring wrote: > > On Thu, Mar 19, 2015 at 09:23:40PM +0800, Nicolas Iooss wrote: > > > Signed-off-by: Nicolas Iooss > > > Fixes: b6eea9ca354a ("mac802

Re: [PATCH] mac802154: fix typo in header guard

2015-03-19 Thread Alexander Aring
Marcel, On Thu, Mar 19, 2015 at 09:23:40PM +0800, Nicolas Iooss wrote: > Signed-off-by: Nicolas Iooss > Fixes: b6eea9ca354a ("mac802154: introduce driver-ops header") Acked-by: Alexander Aring can you please queue this into bluetooth-next or even bluetooth? Thanks. - Alex -

Re: [PATCH 13/15] ieee802154: don't export static symbol

2015-03-11 Thread Alexander Aring
> @@ > identifier r.f; > declarer name EXPORT_SYMBOL; > @@ > > -EXPORT_SYMBOL(f); > // > > Signed-off-by: Julia Lawall Acked-by: Alexander Aring Marcel can you please queue this into bluetooth-next, or even bluetooth? Thanks. - Alex -- To unsubscribe from this list:

Re: [PATCH] at86rf230: assign wait_for_completion_timeout to appropriately typed var

2015-02-14 Thread Alexander Aring
On Sun, Feb 08, 2015 at 10:34:34AM +0100, Alexander Aring wrote: > On Sun, Feb 08, 2015 at 03:55:00AM -0500, Nicholas Mc Guire wrote: > > return type of wait_for_completion_timeout is unsigned long not int. > > As rc is used here only for wait_for_completion_timeout the type is sim

Re: [PATCH] at86rf230: assign wait_for_completion_timeout to appropriately typed var

2015-02-08 Thread Alexander Aring
uire Acked-by: Alexander Aring Marcel, can you please queue this for bluetooth-next. Should be able to apply against bluetooth-next. Thanks. - Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH] ieee802154: fix error handling in ieee802154fake_probe()

2014-11-14 Thread Alexander Aring
Hi, On Sat, Nov 15, 2014 at 02:11:59AM +0300, Alexey Khoroshilov wrote: > In case of any failure ieee802154fake_probe() just calls unregister_netdev(). > But it does not look safe to unregister netdevice before it was registered. > > The patch implements straightforward resource deallocation in c

Re: [PATCH] trivial: net/mac802154: Fix Kconfig typo

2014-10-01 Thread Alexander Aring
Hi Julien, On Wed, Oct 01, 2014 at 12:06:58PM +0200, Julien Catalano wrote: > Signed-off-by: Julien Catalano > --- > net/mac802154/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/mac802154/Kconfig b/net/mac802154/Kconfig > index 1818a99..aa462b4 100644 > ---

Re: [PATCH 1/1 net-next] ieee802154: fix __init functions

2014-09-30 Thread Alexander Aring
an_frags_sysctl_register > > > > Suggested-by: Alexander Aring > > Signed-off-by: Fabian Frederick > > --- > > net/ieee802154/reassembly.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > when trying to apply this to bluetooth-next kernel,

Re: [PATCH 1/1 linux-next] ieee802154: add __init to lowpan_frags_sysctl_register

2014-09-30 Thread Alexander Aring
Hi, On Tue, Sep 30, 2014 at 10:34:08PM +0200, Fabian Frederick wrote: > lowpan_frags_sysctl_register is only called by __init lowpan_net_frag_init > (part of the lowpan module). > > Signed-off-by: Fabian Frederick > --- > This is untested. > > net/ieee802154/reassembly.c | 4 ++-- > 1 file cha

Re: [PATCH net-next] MAINTAINERS: Add section for MRF24J40 IEEE 802.15.4 radio driver

2014-08-16 Thread Alexander Aring
On Sat, Aug 16, 2014 at 05:09:03PM -0400, Alan Ott wrote: > Alan is the original author of the driver. This change was discussed > with the 802.15.4 subsystem maintainer, Alexander Aring. > Acked-by: Alexander Aring -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH] 6lowpan: Allow 6LoWPAN to be modular

2014-08-07 Thread Alexander Aring
On Thu, Aug 07, 2014 at 05:06:43PM +0200, Geert Uytterhoeven wrote: > Change config symbol 6LOWPAN from type bool to type tristate, so > 6LoWPAN can be built modular, just like IPV6 > Acked-by: Alexander Aring -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: Modular 6LoWPAN? (was: Re: 6lowpan: introduce new net/6lowpan directory)

2014-08-07 Thread Alexander Aring
a2ebea2243d19 > > Commit: 2c6bed7cfcd3f594ed9e4d6919fa2ebea2243d19 > > Parent: 6c53823ae0e10e723131055e1e65dd6a328a228e > > Refname:refs/heads/master > > Author: Alexander Aring > > AuthorDate: Fri Jul 11 10:24:18 2014 +0200 > > Committer: Marcel Holtmann > > CommitD

Re: [Linux-zigbee-devel] [PATCH net-next v9 3/9] net: nl802154 - make add_iface take name assign type

2014-07-18 Thread Alexander Aring
On Thu, Jul 17, 2014 at 04:19:31PM -0700, David Miller wrote: > From: Tom Gundersen > Date: Thu, 17 Jul 2014 10:06:04 +0200 > > > @@ -192,8 +193,10 @@ int ieee802154_add_iface(struct sk_buff *skb, struct > > genl_info *info) > > if (devname[nla_len(info->attrs[IEEE802154_ATTR_DEV_NAM

Re: [PATCH v7 09/33] net: nl802154 - make add_iface take name assign type

2014-07-10 Thread Alexander Aring
On Thu, Jul 10, 2014 at 10:17:14AM +0200, Tom Gundersen wrote: > Signed-off-by: Tom Gundersen > Cc: Dmitry Eremin-Solenikov > Cc: linux-zigbee-de...@lists.sourceforge.net Acked-by: Alexander Aring - Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&q

Re: [Linux-zigbee-devel] [PATCH net-next v2] 6lowpan: mac802154: fix coding style issues

2014-06-27 Thread Alexander Aring
nes > CHECK: braces {} should be used on all arms of this statement > > Signed-off-by: Varka Bhadram Tested-by: Alexander Aring -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH net-next v5 1/3] ieee802154: cc2520: adds driver for TI CC2520 radio

2014-06-19 Thread Alexander Aring
On Thu, Jun 19, 2014 at 05:34:30PM +0530, Varka Bhadram wrote: > Hi Alex, > > Thanks for the comments > > On 06/19/2014 04:14 PM, Alexander Aring wrote: > >Hi Varka, > > > >why do you add new features while you trying to get the first version > >mainline? &

Re: [PATCH net-next v5 1/3] ieee802154: cc2520: adds driver for TI CC2520 radio

2014-06-19 Thread Alexander Aring
Hi Varka, why do you add new features while you trying to get the first version mainline? On Thu, Jun 19, 2014 at 02:08:48PM +0530, Varka Bhadram wrote: > This patch adds the driver support for the cc2520 radio. > > Driver support: > - Tx and Rx of IEEE-802.15.4 packets. > - Energy D

Re: [Linux-zigbee-devel] [PATCH net-next v1 1/3] ieee802154: cc2520: adds driver for TI CC2520 radio

2014-06-17 Thread Alexander Aring
Hi, On Tue, Jun 17, 2014 at 02:45:42PM +0530, Varka Bhadram wrote: > On 06/17/2014 02:11 PM, Alexander Aring wrote: > > > > > Hi Varka, ... > > > + > > > +/* Generic Functions */ > > > +static int > > >

Re: [Linux-zigbee-devel] [PATCH net-next v1 1/3] ieee802154: cc2520: adds driver for TI CC2520 radio

2014-06-17 Thread Alexander Aring
Hi Varka, you are on v2 not v1. :-) On Tue, Jun 17, 2014 at 12:44:56PM +0530, Varka Bhadram wrote: > This patch adds the driver support for TI cc2520 radio. > > Few points about CC2520: > - The CC2520 is TI's second generation IEEE 802.15.4 RF transceiver > for the 2.4 GHz unlicense

Re: [Linux-zigbee-devel] [PATCH net-next 1/3] ieee802154: cc2520: driver for TI cc2520 radio

2014-06-16 Thread Alexander Aring
Hi, On Mon, Jun 16, 2014 at 02:21:19PM +0530, Varka Bhadram wrote: ... > >>+ > >>+static void cc2520_unregister(struct cc2520_private *priv) > >>+{ > >>+ ieee802154_unregister_device(priv->dev); > >>+ ieee802154_free_device(priv->dev); > >>+} > >Only used in remove callback of module. It's sma

Re: [Linux-zigbee-devel] [PATCH net-next 1/3] ieee802154: cc2520: driver for TI cc2520 radio

2014-06-16 Thread Alexander Aring
Hi Varka, On Mon, Jun 16, 2014 at 10:21:56AM +0530, Varka Bhadram wrote: > Maybe some more information about this chip in the commit msg? > Signed-off-by: Varka Bhadram > --- > drivers/net/ieee802154/cc2520.c | 805 > +++ > include/linux/spi/cc2520.h

Re: [Linux-zigbee-devel] [PATCH net-next v3] mrf24j40: added device managed APIs

2014-05-29 Thread Alexander Aring
Hi Varka, On Thu, May 29, 2014 at 03:57:38PM +0530, Varka Bhadram wrote: > changes since v2: > 1. removed unwanted label implementation. > > When we use devm_* APIs ,probe() failed also the memory > will be freed automatically. Thanks to Alex > > -Varka Bhadram > > you should provide a "wel

Re: [Linux-zigbee-devel] [PATCH net-next v2] mrf24j40: add managed API's provided by device layer

2014-05-29 Thread Alexander Aring
Hi Varka, On Thu, May 29, 2014 at 11:35:35AM +0530, Varka Bhadram wrote: > forgot to use devm_* for spi buff. > sorry for that. > > -Varka Bhadram > > Signed-off-by: Varka Bhadram > --- > drivers/net/ieee802154/mrf24j40.c | 21 + > 1 file changed, 9 insertions(+), 12 dele

Re: [Linux-zigbee-devel] [PATCH] 6lowpan: nuke net_ieee802154_lowpan() accessor when 6lowpan is disabled

2014-04-24 Thread Alexander Aring
Hi Luis, On Thu, Apr 24, 2014 at 10:25:58AM -0700, Luis R. Rodriguez wrote: > On Thu, Apr 24, 2014 at 9:44 AM, Alexander Aring wrote: > > Hi, > > > > On Tue, Apr 22, 2014 at 12:03:58PM -0700, Luis R. Rodriguez wrote: > >> From: "Luis R. Rodriguez" >

Re: [Linux-zigbee-devel] [PATCH] 6lowpan: nuke net_ieee802154_lowpan() accessor when 6lowpan is disabled

2014-04-24 Thread Alexander Aring
Hi, On Tue, Apr 22, 2014 at 12:03:58PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > Johannes noted this is not needed, all of the fragment > accessors don't need CONFIG_NET_NS. This goes test compiled with > CONFIG_BT_6LOWPAN=y and a disabled CONFIG_NET_NS. > a little note a

Re: [PATCH 1/3] 6lowpan: add helper to get 6lowpan namespace

2014-04-22 Thread Alexander Aring
On Tue, Apr 22, 2014 at 08:45:15PM +0200, Johannes Berg wrote: > On Tue, 2014-04-22 at 19:58 +0200, Luis R. Rodriguez wrote: > > > > > > +#if IS_ENABLED(CONFIG_IEEE802154_6LOWPAN) > > > > > [...] > > > > > +#else > > > > > +static inline struct netns_ieee802154_lowpan * > > > > > +net_ieee802154_l

Re: [PATCH 1/3] 6lowpan: add helper to get 6lowpan namespace

2014-04-22 Thread Alexander Aring
Hi, On Tue, Apr 22, 2014 at 11:44:46AM +0200, Johannes Berg wrote: > On Thu, 2014-04-17 at 18:22 -0700, Luis R. Rodriguez wrote: > > > +#if IS_ENABLED(CONFIG_IEEE802154_6LOWPAN) > > [...] > > +#else > > +static inline struct netns_ieee802154_lowpan * > > +net_ieee802154_lowpan(struct net *net) >

Re: linux-next: Tree for Jan 14 (lowpan, 802.15.4)

2014-01-15 Thread Alexander Aring
Hi Dmitry, On Wed, Jan 15, 2014 at 02:54:56AM +0400, Dmitry Eremin-Solenikov wrote: > Hello, > > > On Tue, Jan 14, 2014 at 9:49 PM, Randy Dunlap wrote: > > > > On 01/13/2014 09:51 PM, Stephen Rothwell wrote: > > > Hi all, > > > > > > This tree fails (more than usual) the powerpc allyesconfig bu

Re: [PATCH] 6lowpan: Sync default hardware address of lowpan links to their wpan

2013-10-05 Thread Alexander Aring
On Sat, Oct 05, 2013 at 09:01:52PM -0400, Alan Ott wrote: > On 10/05/2013 08:24 PM, Alexander Aring wrote: > >Hi Alan, > > > >On Sat, Oct 05, 2013 at 05:38:00PM -0400, Alan Ott wrote: > >>When a lowpan link to a wpan device is created, set the hardware address > &g

Re: [PATCH] 6lowpan: Sync default hardware address of lowpan links to their wpan

2013-10-05 Thread Alexander Aring
Hi Alan, On Sat, Oct 05, 2013 at 05:38:00PM -0400, Alan Ott wrote: > When a lowpan link to a wpan device is created, set the hardware address > of the lowpan link to that of the wpan device. > > Signed-off-by: Alan Ott > --- > net/ieee802154/6lowpan.c | 3 +++ > 1 file changed, 3 insertions(+)

Re: [PATCH 1/1] 6lowpan: Fix fragmentation with link-local compressed addresses

2013-05-19 Thread Alexander Aring
rk.zigbee.devel/1717 > > I came across a similar solution but didn't submit it as another patch > already existed. > This patch instead focus on fragmented packet with link-local address > compression, > which is related but a different bug. > > 2013/5/19 Alexander Aring

Re: [PATCH 1/1] 6lowpan: Fix fragmentation with link-local compressed addresses

2013-05-19 Thread Alexander Aring
Hi David, can you use a link-layer address on the current net-next kernel? I am asking because I can't use a link-layer address currently. Your patch doesn't help to solve my problem with link-layer addresses. To your patch: We get the link-layer addresses from skb not from the allocated frame