On 2020-07-19 1:50 p.m., Karol Herbst wrote:
> On Fri, Jul 17, 2020 at 9:52 PM Alex Hung wrote:
>>
>> On 2020-07-17 1:05 p.m., Karol Herbst wrote:
>>> It's hard to figure out what systems are actually affected and right now I
>>> don't see a good way o
prevent power savings on systems those workaround
> applies to, which might be any so those should get removed asap and if
> new issues arrise removing those please do a proper bug report and we can
> look into it and come up with a proper fix (and keep this patch out until
> we resol
On 2020-06-11 1:24 a.m., Kai-Heng Feng wrote:
>
>
>> On Jun 11, 2020, at 01:41, Alex Hung wrote:
>>
>> On 2020-06-10 9:49 a.m., mario.limoncie...@dell.com wrote:
>>>> -Original Message-
>>>> From: platform-driver-x86-ow...@vger.kernel.org
dev_info(&dev->dev,
>> "intel-hid: created platform device\n");
>>
>> +if (!strcmp(acpi_device_hid(dev), "HPQ6001"))
>> +hp_wireless_present = true;
(Resend with format removed)
This can impact all HP systems that do not have this problem. How about
a DMI quirk that is limited to this particular system?
>
> Just having the ACPI device present doesn't actually mean that the user
> has a kernel compiled with hp-wireless or that it has finished initializing.
>
> I would think this needs a better handshake in case hp-wireless was unloaded
> or not present so the event could still come through intel-hid in this
> circumstance.
>
>> +
>> return AE_OK;
>> }
>>
>> --
>> 2.17.1
>
--
Cheers,
Alex Hung
On Fri, Mar 9, 2018 at 5:33 AM, Jean Delvare wrote:
> Hi Alex,
>
> On Tue, 27 Feb 2018 22:48:14 -0800, Alex Hung wrote:
>> OEM strings are defined by each OEM and they contain customized and
>> useful OEM information. Supporting it provides more flexible uses of
>&g
OEM strings are defined by each OEM and they contain customized and
useful OEM information. Supporting it provides more flexible uses of
the dmi_matches function.
Signed-off-by: Alex Hung
---
drivers/firmware/dmi_scan.c | 11 +--
include/linux/mod_devicetable.h | 1 +
2 files
may be problematic, for example, if the image
>> cannot be saved (eg. due to an I/O issue with storage).
>>
>> Signed-off-by: Rafael J. Wysocki
>
> + Alex Hung
>
> Queued to testing, thank you Rafael.
Thank you Rafael for catching this.
>
>> ---
>> d
name = "Intel HID 5 button array";
priv->array->id.bustype = BUS_HOST;
The patch, on top of previous patches, is tested on Latitude 7480
Reviewed-and-tested-by: Alex Hung
ou have an access to hardware to test? I wouldn't going to
> apply this until I get your tag(s) (in the best case
> Reviewed-and-tested-by).
The patches look good and tested on Latitude 7480
Reviewed-and-tested-by: Alex Hung
>
> --
> With Best Regards,
> Andy Shevchenko
e minor
> coding style tweaks suggested along the way.
>
> Alex, in the light of your findings quoted above, would it be okay to
> also apply your Tested-by to all patches?
Certainly.
Tested-by: Alex Hung
>
> Jacek, Pavel, which linux-leds branch would you like me to base v3 on?
>
> --
> Best regards,
> Michał Kępień
--
Cheers,
Alex Hung
does not work, I can see no changes to
>> > either drivers/leds/dell-led.c or sound/pci/hda/dell_wmi_helper.c.
>> > Kernel configuration issue?
>>
>> I was surprised too, and I compiled it twice and installed on both
>> Ubuntu 16.04 and 16.10.
>>
>> I would guess it is config too. On 4.9, it was using Ubuntu default.
>> On 4.10rc8, I am pretty much using the instruction on
>> https://wiki.ubuntu.com/KernelTeam/GitKernelBuild. The .config is
>> available @ http://paste.ubuntu.com/24001113/
>
> CONFIG_DELL_SMBIOS is not set in that .config. That prevents you from
> enabling CONFIG_LEDS_DELL_NETBOOKS, which is required for the microphone
> mute LED to work without this patch series applied.
>
>>
>>
>> >
>> >>
>> >> 7. Applied and compiled downloaded patches to kernel 4.10 rc8
>> >>
>> >> -> Microphone mute led does not work
>> >
>> > No surprises here if it really does not work with 4.10-rc8.
>
> My remark regarding CONFIG_DELL_LAPTOP also applies to 4.10-rc8 with
> this patch series applied.
>
> Thanks again for your work on this,
>
> --
> Best regards,
> Michał Kępień
--
Cheers,
Alex Hung
too, and I compiled it twice and installed on both
Ubuntu 16.04 and 16.10.
I would guess it is config too. On 4.9, it was using Ubuntu default.
On 4.10rc8, I am pretty much using the instruction on
https://wiki.ubuntu.com/KernelTeam/GitKernelBuild. The .config is
available @ http://paste.ubuntu.com/24001113/
>
>>
>> 7. Applied and compiled downloaded patches to kernel 4.10 rc8
>>
>> -> Microphone mute led does not work
>
> No surprises here if it really does not work with 4.10-rc8.
>
> --
> Best regards,
> Michał Kępień
--
Cheers,
Alex Hung
ches 2-4 touch it.
>
> Anthony, have you and your team perhaps had a chance to test this patch
> series on actual hardware?
>
> Thanks,
>
> --
> Best regards,
> Michał Kępień
--
Cheers,
Alex Hung
Hi Ingo,
I agree with you but it can affect a lot of systems according to
163ea310b68bdde89b1ac633fbf8c0db290d3f86.
Do you think we should invert 163ea310 instead?
On Thu, Jul 14, 2016 at 8:58 PM, Ingo Molnar wrote:
>
> * Alex Hung wrote:
>
>> Dell Optiplex 7450 AIO works
I tried this patch on a Latitude with ACPI Device with DELLABCE and
this patch fixes the problem.
Tested-by: Alex Hung
On Sat, Mar 12, 2016 at 7:49 AM, Gabriele Mazzotta
wrote:
> Some BIOSes unconditionally send an ACPI notification to RBTN when the
> system is resuming from suspend
On Fri, Jul 10, 2015 at 4:52 AM, Darren Hart wrote:
> On Tue, Jul 07, 2015 at 04:25:18PM +0200, Pali Rohár wrote:
>> On Monday 06 July 2015 15:43:28 Darren Hart wrote:
>> > On Mon, Jul 06, 2015 at 09:35:40AM +0800, Alex Hung wrote:
>> > > ATK4001 is an ACPI device f
15:10:39 Alex Hung wrote:
>> Thanks for the support. I will create v3 based with LED triggers.
>>
>> Just for information. ASUS's wording is as below:
>>
>> Fn+F2 can be used to turn on or off all radio capabilities in the
>> device (as known as airplane mo
e the term airplane-mode do if
asus-rbtn is not preferred. Let me know if there are any suggestions.
On Wed, Jul 1, 2015 at 7:48 PM, Pali Rohár wrote:
> On Wednesday 01 July 2015 00:09:41 Alex Hung wrote:
>> ATK4001 is an independent ACPI device, and Method(HSWC) is its method
>> to con
Take some machine which has some
> configurable led exported in /sys/class/leds/ and try to set some
> trigger via "trigger" entry.
>
> I think that default trigger for led device (from kernel) can be set via
> "default_trigger" property in struct led_classdev. See fil
Pali,
Thanks for comments, but will you be able to provide more details so
it is more clear how this works?
On Mon, Jun 29, 2015 at 8:29 PM, Pali Rohár wrote:
> On Friday 26 June 2015 23:24:10 Alex Hung wrote:
>> On Fri, Jun 26, 2015 at 10:56 PM, Pali Rohár wrote:
>> >
On Fri, Jun 26, 2015 at 10:56 PM, Pali Rohár wrote:
> Hi!
>
> On Wednesday 24 June 2015 10:57:51 Alex Hung wrote:
>> ASUS introduced a new approach to handle wireless hotkey
>> since Windows 8. When the hotkey is pressed, BIOS generates
>> a notification 0x88 to a new
-rbtn.c
diff --git a/MAINTAINERS b/MAINTAINERS
index d8afd29..03711ce 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1673,6 +1673,12 @@ S: Maintained
F: drivers/platform/x86/asus*.c
F: drivers/platform/x86/eeepc*.c
+ASUS RADIO BUTTON DRIVER
+M: Alex Hung
+L: platform-driver
:19PM +0200, Pali Rohár wrote:
>> Looks like everything is OK. Test3 is expected to not work correctly as
>> driver is not loaded...
>>
>> On Wednesday 06 May 2015 17:11:08 Alex Hung wrote:
>> > The test was updated @
>> > https://docs.google.com/spreadsheet
re they purchased.
On Wed, May 6, 2015 at 5:23 AM, Gabriele Mazzotta
wrote:
> On Thursday 30 April 2015 09:44:29 Pali Rohár wrote:
>> On Thursday 30 April 2015 14:06:27 Alex Hung wrote:
>> > Method ABRT is to be used by driver to disable BIOS handling of radio
>> > button.
gt;> devices) and export them via rfkill interface. These events
>> are also used in dell-laptop driver instead i8042 filter hook
>> function (when acpi device is available).
>>
>> In v2 was added support for laptops which have toggle button
>> instead HW slider switch. F
gt; > On Wednesday 29 April 2015 11:51:04 Pali Rohár
>> > > > > > > > > wrote:
>> > > > > > > > > > This is an ACPI driver for Dell laptops
>> > > > > > > > > > which receive HW switch events. It exp
er.
>
> Alex, can you check if scancode of wireless change generated by
> BIOS is on all machines same: 136 (0x88)? And is send by keyboard
> controller (not acpi/wmi)?
>
> On Thursday 25 December 2014 04:13:02 Alex Hung wrote:
>> I usually prefer to stick with formal d
n't think holiday is quite
over for everybody. I will send updates when there is any.
On Mon, Dec 29, 2014 at 4:32 PM, Pali Rohár wrote:
> On Monday 29 December 2014 08:27:21 Alex Hung wrote:
>> On Fri, Dec 26, 2014 at 5:55 AM, Gabriele Mazzotta
>>
>> wrote:
>> >
the scancode table
(http://download.microsoft.com/download/1/6/1/161ba512-40e2-4cc9-843a-923143f3456c/translate.pdf)
and found 0x88 is already used - it is the "break" ("release" in Linux
term) code for "7" (the one above Y/U, not number pad). It can be
verified
40 PM, Gabriele Mazzotta
wrote:
> On Wednesday 24 December 2014 17:13:45 Alex Hung wrote:
>> I uploaded acpidump files [1] (except for XPS 13 which is not
>> available), and this should help clarify what has been tested.
>>
>> Does Inspirion 5721 does not have either DELLAB
stems, but I may need some more detailed instructions.
On Tue, Dec 23, 2014 at 3:16 AM, Gabriele Mazzotta
wrote:
> On Monday 22 December 2014 15:27:57 Alex Hung wrote:
>> = Testing =
>>
>> I tested six Dell systems for two sets of patches for dell radio
>> button - tw
patch which can
>> correctly set rfkill state by software on laptops of your fn key
>> type.
>
> That's what happens on my laptop, but Alex said that the laptops on
> which he worked, ARBT was empty, so I guess it's not always a choice.
> In order not to break things
x27;s suggestion and Pali's
dell-rbtn.c (btw, will there be updates?). However, I will need a few
days to do the comparison.
Any suggested test cases?
Cheers,
Alex Hung
On Tue, Dec 2, 2014 at 4:42 PM, Pali Rohár wrote:
> On Wednesday 26 November 2014 00:05:28 Darren Hart wrote:
>> On S
g at other platform drivers code some add() methods do give
>> information to the user via pr_{err,warn,info} macros, some don't. My
>> first patch to deal with this just removed the err variable like you
>> have wrote but Darren Hart and Rafael J. Wysocki commented that maybe i
34 matches
Mail list logo
