[PATCH v2] netfilter: xt_hashlimit: Fix integer divide round to zero.

2017-02-06 Thread Alban Browaeys
ives: 0 as user2creds output Setting burst to "1" typically solve the issue ... but setting it to "40" does too ! This is on 32bit arch calling into revision 2 of hashlimit. Signed-off-by: Alban Browaeys --- v2: - fix missing conditional statement in revision 1 case .

Re: [PATCH] netfilter: xt_hashlimit: Fix integer divide round to zero.

2017-02-06 Thread Alban Browaeys
Le lundi 06 février 2017 à 14:04 +0100, Pablo Neira Ayuso a écrit : > On Sat, Feb 04, 2017 at 11:47:31PM +0100, Alban Browaeys wrote: > > diff --git a/net/netfilter/xt_hashlimit.c > > b/net/netfilter/xt_hashlimit.c > > index 10063408141d..df75ad643eef 100644 > > --- a/n

[PATCH] netfilter: xt_hashlimit: Fix integer divide round to zero.

2017-02-04 Thread Alban Browaeys
ives: 0 as user2creds output Setting burst to "1" typically solve the issue ... but setting it to "40" does too ! This is on 32bit arch calling into revision 2 of hashlimit. Signed-off-by: Alban Browaeys --- net/netfilter/xt_hashlimit.c | 18 -- 1 fil

Re: Unable to boot linux-next build

2016-10-19 Thread Alban Browaeys
Le dimanche 11 septembre 2016 à 20:00 +0200, Quentin Lambert a écrit : > > On 09/09/2016 10:31, Quentin Lambert wrote: > >   I have been trying to build and boot the last version available > > on linux-next. > >   During the build I am being prompted with "has no CRC!" warnings > > for a bunch > >

Re: genirq: Setting trigger mode 0 for irq 11 failed (txx9_irq_set_type+0x0/0xb8)

2016-09-16 Thread Alban Browaeys
Le vendredi 16 septembre 2016 à 13:55 +0100, Marc Zyngier a écrit : > At that stage, I'm not sure I should care. Does the workaround make > your > platform usable? However awkward this was all about logs and clearing worries. There was no change in behavior  between the three cases : upstream, ups

Re: genirq: Setting trigger mode 0 for irq 11 failed (txx9_irq_set_type+0x0/0xb8)

2016-09-16 Thread Alban Browaeys
Le vendredi 16 septembre 2016 à 08:51 +0100, Marc Zyngier a écrit : > Hi Alban, > > On 16/09/16 00:02, Alban Browaeys wrote: > > I am seeing this on arm odroid u2 devicetree : > > genirq: Setting trigger mode 0 for irq 16 failed > > (gic_set_type+0x0/0x64) >

Re: genirq: Setting trigger mode 0 for irq 11 failed (txx9_irq_set_type+0x0/0xb8)

2016-09-15 Thread Alban Browaeys
Le mercredi 14 septembre 2016 à 21:25 +0200, Geert Uytterhoeven a écrit : > JFYI, with v4.8-rc6 I'm seeing > > genirq: Setting trigger mode 0 for irq 11 failed > (txx9_irq_set_type+0x0/0xb8) > > on rbtx4927. This did not happen with v4.8-rc3. txx9_irq_set_type receives a type IRQ_TYPE_NONE

Re: [PATCH 1/2] clk: Fix __clk_get access to already freed owner field.

2015-02-06 Thread Alban Browaeys
Le jeudi 05 février 2015 à 13:45 -0800, Stephen Boyd a écrit : > On 02/05/15 13:30, Alban Browaeys wrote: > >> Thanks for the information. Can you please try the patch in this other > >> thread[1]? I think you're seeing the same problem. > >> > >

Re: [PATCH 1/2] clk: Fix __clk_get access to already freed owner field.

2015-02-05 Thread Alban Browaeys
> > Thanks for the information. Can you please try the patch in this other > thread[1]? I think you're seeing the same problem. > > [1] https://lkml.org/lkml/2015/2/5/595 This fixes both oops : the one from __clk_get and the next from hlist_del. Thanks Alban -- To unsubscribe from this list:

Re: [PATCH 2/2] clk: Fix OOPS calling hlist_del on an already poisoned hlist.

2015-02-05 Thread Alban Browaeys
Le jeudi 05 février 2015 à 11:33 -0800, Stephen Boyd a écrit : > On 02/05/15 10:24, Alban Browaeys wrote: > > Put is called more than once, thus hlist_del ends up on a poisoned > > list. > > Why is clk_put() called more than once on the same clk pointer? Where > does

Re: [PATCH 1/2] clk: Fix __clk_get access to already freed owner field.

2015-02-05 Thread Alban Browaeys
Le jeudi 05 février 2015 à 11:30 -0800, Stephen Boyd a écrit : > > Signed-off-by: Alban Browaeys > > --- > > drivers/clk/clk.c | 17 + > > 1 file changed, 9 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk

[PATCH 2/2] clk: Fix OOPS calling hlist_del on an already poisoned hlist.

2015-02-05 Thread Alban Browaeys
Put is called more than once, thus hlist_del ends up on a poisoned list. Move hlist_del to the __clk_release handler managed by kref instead of calling it in _clk_put. Fixes: 1c8e600440c7 ("clk: Add rate constraints to clocks") Signed-off-by: Alban Browaeys --- drivers/clk/clk.c |

[PATCH 1/2] clk: Fix __clk_get access to already freed owner field.

2015-02-05 Thread Alban Browaeys
_release call instead of plain __clk_put. Fixes: 035a61c314eb ("clk: Make clk API return per-user struct clk instances) Signed-off-by: Alban Browaeys --- drivers/clk/clk.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/c

usb: misc: usb3503: connect and intn mismatch in OF vs variable assignments

2013-08-16 Thread Alban Browaeys
hub->gpio_intn  = of_get_named_gpio(np, "connect-gpios", 0); and hub->gpio_connect = of_get_named_gpio(np, "intn-gpios", 0); I guess they should be switched , that is connect-gpios bound to hub->gpio_connect and intn-gpios to hub->gpio_int. Sorry not to provides a patch. I thought that this issu

[PATCH 4/4] [media] em28xx: Fix vidioc fmt vid cap v4l2 compliance

2013-07-16 Thread Alban Browaeys
Set fmt.pix.priv to zero in vidioc_g_fmt_vid_cap and vidioc_try_fmt_vid_cap. Catched by v4l2-compliance. Signed-off-by: Alban Browaeys --- drivers/media/usb/em28xx/em28xx-video.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media

[PATCH 3/4] [media] em28xx: usb power config is in the low byte.

2013-07-16 Thread Alban Browaeys
According to the em2860 datasheet, eeprom byte 08H is Chip Configuration Low Byte and 09H is High Byte. Usb power configuration is in the Low byte (same as the usb audio class config). Signed-off-by: Alban Browaeys --- drivers/media/usb/em28xx/em28xx-i2c.c | 6 +++--- 1 file changed, 3

[PATCH 2/4] [media] em28xx: i2s 5 sample rates is a subset of 3 one.

2013-07-16 Thread Alban Browaeys
As: EM28XX_CHIPCFG_I2S_3_SAMPRATES 0x20 EM28XX_CHIPCFG_I2S_5_SAMPRATES 0x30 the board chipcfg is 0xf0 thus if 3_SAMPRATES is tested first and matches while it is a 5_SAMPRATES. Signed-off-by: Alban Browaeys --- drivers/media/usb/em28xx/em28xx-core.c | 8 1 file changed, 4 insertions

[PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.

2013-07-16 Thread Alban Browaeys
Set the config structure pointer to the eeprom data pointer (data, here eedata dereferenced) not the pointer to the pointer to the eeprom data (eedata itself). Signed-off-by: Alban Browaeys --- drivers/media/usb/em28xx/em28xx-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: thoughts on kernel security issues

2005-01-18 Thread Alban Browaeys
Bill Davidsen tmr.com> writes: > > With no disrespect, I don't believe you have ever been a full-time > employee system administrator for any commercial or government > organization, and I don't believe you have any experience trying to do > security when change must be reviewed by technicall

Re: Linux Kernel Audit Project?

2005-01-16 Thread Alban Browaeys
John Richard Moser comcast.net> writes: > Is there an official Linux Kernel Audit Project to actively and > aggressively security audit all patches going into the Linux Kernel, or > do they just get a cursory scan for bugs and obvious screwups? >From a user point of view , there is at least trac