Re: [PATCH net-next 3/4] virtio_net: Use new RSS config structs

2025-04-05 Thread Akihiko Odaki
On 2025/03/20 10:50, Jason Wang wrote: On Wed, Mar 19, 2025 at 12:48 PM Akihiko Odaki wrote: On 2025/03/19 10:43, Jason Wang wrote: On Tue, Mar 18, 2025 at 5:57 PM Akihiko Odaki wrote: The new RSS configuration structures allow easily constructing data for VIRTIO_NET_CTRL_MQ_RSS_CONFIG as

[PATCH net-next v2 4/4] virtio_net: Allocate rss_hdr with devres

2025-03-23 Thread Akihiko Odaki
virtnet_probe() lacks the code to free rss_hdr in its error path. Allocate rss_hdr with devres so that it will be automatically freed. Fixes: 86a48a00efdf ("virtio_net: Support dynamic rss indirection table size") Signed-off-by: Akihiko Odaki Acked-by: Jason Wang Tested-by: Lei Yang

[PATCH net-next v2 0/4] virtio_net: Fixes and improvements

2025-03-22 Thread Akihiko Odaki
Jason Wang recently proposed an improvement to struct virtio_net_rss_config: https://lore.kernel.org/r/CACGkMEud0Ki8p=z299q7b4qedonpydzbvqhhxcnvk_vo-kd...@mail.gmail.com This patch series implements it and also fixes a few minor bugs I found when writing patches. Signed-off-by: Akihiko Odaki

[PATCH net-next v2 2/4] virtio_net: Fix endian with virtio_net_ctrl_rss

2025-03-20 Thread Akihiko Odaki
Mark the fields of struct virtio_net_ctrl_rss as little endian as they are in struct virtio_net_rss_config, which it follows. Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.") Signed-off-by: Akihiko Odaki Acked-by: Jason Wang Tested-by: Lei Yang Acked-by:

[PATCH net-next v2 1/4] virtio_net: Split struct virtio_net_rss_config

2025-03-20 Thread Akihiko Odaki
struct virtio_net_rss_config was less useful in actual code because of a flexible array placed in the middle. Add new structures that split it into two to avoid having a flexible array in the middle. Suggested-by: Jason Wang Signed-off-by: Akihiko Odaki Acked-by: Jason Wang Tested-by: Lei Yang

[PATCH net-next v2 3/4] virtio_net: Use new RSS config structs

2025-03-20 Thread Akihiko Odaki
The new RSS configuration structures allow easily constructing data for VIRTIO_NET_CTRL_MQ_RSS_CONFIG as they strictly follow the order of data for the command. Signed-off-by: Akihiko Odaki Tested-by: Lei Yang Acked-by: Michael S. Tsirkin --- drivers/net/virtio_net.c | 117

Re: [PATCH net-next 3/4] virtio_net: Use new RSS config structs

2025-03-20 Thread Akihiko Odaki
On 2025/03/21 9:35, Jason Wang wrote: On Thu, Mar 20, 2025 at 1:36 PM Akihiko Odaki wrote: On 2025/03/20 10:50, Jason Wang wrote: On Wed, Mar 19, 2025 at 12:48 PM Akihiko Odaki wrote: On 2025/03/19 10:43, Jason Wang wrote: On Tue, Mar 18, 2025 at 5:57 PM Akihiko Odaki wrote: The new

Re: [PATCH net-next 3/4] virtio_net: Use new RSS config structs

2025-03-18 Thread Akihiko Odaki
On 2025/03/19 10:43, Jason Wang wrote: On Tue, Mar 18, 2025 at 5:57 PM Akihiko Odaki wrote: The new RSS configuration structures allow easily constructing data for VIRTIO_NET_CTRL_MQ_RSS_CONFIG as they strictly follow the order of data for the command. Signed-off-by: Akihiko Odaki

Re: [PATCH net-next 3/4] virtio_net: Use new RSS config structs

2025-03-18 Thread Akihiko Odaki
On 2025/03/19 10:22, Xuan Zhuo wrote: On Tue, 18 Mar 2025 18:56:53 +0900, Akihiko Odaki wrote: The new RSS configuration structures allow easily constructing data for VIRTIO_NET_CTRL_MQ_RSS_CONFIG as they strictly follow the order of data for the command. Signed-off-by: Akihiko Odaki

[PATCH net-next 1/4] virtio_net: Split struct virtio_net_rss_config

2025-03-18 Thread Akihiko Odaki
struct virtio_net_rss_config was less useful in actual code because of a flexible array placed in the middle. Add new structures that split it into two to avoid having a flexible array in the middle. Suggested-by: Jason Wang Signed-off-by: Akihiko Odaki --- include/uapi/linux/virtio_net.h | 13

[PATCH net-next 4/4] virtio_net: Allocate rss_hdr with devres

2025-03-18 Thread Akihiko Odaki
virtnet_probe() lacks the code to free rss_hdr in its error path. Allocate rss_hdr with devres so that it will be automatically freed. Fixes: 86a48a00efdf ("virtio_net: Support dynamic rss indirection table size") Signed-off-by: Akihiko Odaki --- drivers/net/virtio_net.c | 10

[PATCH net-next 0/4] virtio_net: Fixes and improvements

2025-03-18 Thread Akihiko Odaki
Jason Wang recently proposed an improvement to struct virtio_net_rss_config: https://lore.kernel.org/r/CACGkMEud0Ki8p=z299q7b4qedonpydzbvqhhxcnvk_vo-kd...@mail.gmail.com This patch series implements it and also fixes a few minor bugs I found when writing patches. Signed-off-by: Akihiko Odaki

[PATCH net-next 2/4] virtio_net: Fix endian with virtio_net_ctrl_rss

2025-03-18 Thread Akihiko Odaki
Mark the fields of struct virtio_net_ctrl_rss as little endian as they are in struct virtio_net_rss_config, which it follows. Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.") Signed-off-by: Akihiko Odaki --- drivers/net/virtio_net.c | 30 +++

[PATCH net-next 3/4] virtio_net: Use new RSS config structs

2025-03-18 Thread Akihiko Odaki
The new RSS configuration structures allow easily constructing data for VIRTIO_NET_CTRL_MQ_RSS_CONFIG as they strictly follow the order of data for the command. Signed-off-by: Akihiko Odaki --- drivers/net/virtio_net.c | 117 +-- 1 file changed, 43

[PATCH] selftests: Override command line in lib.mk

2025-03-05 Thread Akihiko Odaki
make it and similar ones will be effective even when TEST_GEN_PROGS and similar variables are specified in the command line. Signed-off-by: Akihiko Odaki --- tools/testing/selftests/lib.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/li

Re: [PATCH] vhost/net: Set num_buffers for virtio 1.0

2024-12-26 Thread Akihiko Odaki
.com>> wrote: > > > > On Sun, Sep 15, 2024 at 10:35:53AM +0900, Akihiko Odaki wrote: > > > The specification says the device MUST set num_buffers to 1 if > > > VIRTIO_NET_F_MRG_RXBUF has not been negotiated. > > > > > > Fixes: 41e3

[PATCH] vhost/net: Set num_buffers for virtio 1.0

2024-09-14 Thread Akihiko Odaki
The specification says the device MUST set num_buffers to 1 if VIRTIO_NET_F_MRG_RXBUF has not been negotiated. Fixes: 41e3e42108bc ("vhost/net: enable virtio 1.0") Signed-off-by: Akihiko Odaki --- drivers/vhost/net.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) di

Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers

2015-12-18 Thread Akihiko Odaki
No, it doesn't work. On 12/19/2015 12:06 AM, Bastien Nocera wrote: > On Mon, 2015-12-14 at 21:50 +0900, Akihiko Odaki wrote: >> Use multitouch driver instead of microsoft one for Microsoft Surface >> Type Covers. >> >> By using MT_CLS_EXPORT_ALL_INPUTS, the keyb

Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers

2015-12-18 Thread Akihiko Odaki
> > Anyway, keys working with hid-microsoft also work with > hid-multitouch, so It's ready for merging, I think. > > On 12/15/2015 01:39 AM, Donavan Lance wrote: >> On Mon, Dec 14, 2015 at 8:22 AM, Bastien Nocera >> > wrote: >>> On Mon, 2015-12-1

Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers

2015-12-17 Thread Akihiko Odaki
ork with hid-multitouch, so It's ready for merging, I think. On 12/15/2015 01:39 AM, Donavan Lance wrote: > On Mon, Dec 14, 2015 at 8:22 AM, Bastien Nocera > wrote: >> On Mon, 2015-12-14 at 21:50 +0900, Akihiko Odaki wrote: >>> Use multitouch driver instead of mi

[PATCH 1/2] HID: Use multitouch driver for Type Covers

2015-12-14 Thread Akihiko Odaki
Use multitouch driver instead of microsoft one for Microsoft Surface Type Covers. By using MT_CLS_EXPORT_ALL_INPUTS, the keyboards function as well as the multitouch pads do. Signed-off-by: Akihiko Odaki --- drivers/hid/hid-core.c | 14 -- drivers/hid/hid-microsoft.c | 10

[PATCH 2/2] HID: Add new Japanese Surface 3 Pro Type Cover

2015-12-14 Thread Akihiko Odaki
Add support for the new Japanese version of Microsoft Surface 3 Pro Type Cover. Signed-off-by: Akihiko Odaki --- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-multitouch.c| 3 +++ drivers/hid/usbhid/hid-quirks.c | 1 + 3 files changed, 5 insertions(+) diff --git a/drivers/hid/hid