ting the section header name. Since both these sections are SHF_ALLOC, it
should be okay to nest the check
within that if - which is what was happening prior to the refactor too.
I have tested that with the patch, loading a malformed kernel module no longer
results in the oops.
Signed-off-by: Ab
to be triggered and cause cascading
failures. To mitigate this, initiate a get bss call in
cfg80211_connect_done itself and hold it to ensure that the BSS
instance does not get expired.
Signed-off-by: Abhishek Kumar
---
net/wireless/sme.c | 21 +
1 file changed, 13 insertions
Fixed alignment of multi-line comment.
Added a * for each line of the comment.
Signed-off-by: Abhishek C
---
drivers/android/binder.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index c119736ca56a..700719c58147
er to clear the event filter.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Archie Pusaka
Reviewed-by: Alain Michaud
---
Changes in v3:
* Minor change to if statement
Changes in v2:
* Removed hci_dev_lock from hci_cc_set_event_filter since flags are
set/cleared atomically
include/net/blue
tests).
Thanks
Abhishek
Changes in v3:
* Minor change to if statement
Changes in v2:
* Removed hci_dev_lock from hci_cc_set_event_filter since flags are
set/cleared atomically
Abhishek Pandit-Subedi (1):
Bluetooth: Remove unneeded commands for suspend
include/net/bluetooth/hci.h | 1 +
net
tests).
Thanks
Abhishek
Changes in v2:
* Removed hci_dev_lock from hci_cc_set_event_filter since flags are
set/cleared atomically
Abhishek Pandit-Subedi (1):
Bluetooth: Remove unneeded commands for suspend
include/net/bluetooth/hci.h | 1 +
net/bluetooth/hci_event.c | 24
er to clear the event filter.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Archie Pusaka
Reviewed-by: Alain Michaud
---
Changes in v2:
* Removed hci_dev_lock from hci_cc_set_event_filter since flags are
set/cleared atomically
include/net/bluetooth/hci.h | 1 +
net/bluetooth/hci_event.c
This patch seems to address the comments on v2. Overall this patch LGTM.
Reviewed-by: Abhishek Kumar
On Tue, Feb 23, 2021 at 6:29 AM Youghandhar Chintala
wrote:
>
> Currently in the shutdown callback we wait for recovery to complete
> before freeing up the resources. This results in a
er to clear the event filter.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Archie Pusaka
Reviewed-by: Alain Michaud
---
include/net/bluetooth/hci.h | 1 +
net/bluetooth/hci_event.c | 31 ++
net/bluetooth/hci_request.c | 44 +++--
3
spend thread when that is the case.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Archie Pusaka
---
Here is an HCI trace when the issue occurred.
< HCI Command: LE Create Connection (0x08|0x000d) plen 25
#18 [hci0] 2021-02-03 21:42:35.130208
tests).
Thanks
Abhishek
Abhishek Pandit-Subedi (2):
Bluetooth: Notify suspend on le conn failed
Bluetooth: Remove unneeded commands for suspend
include/net/bluetooth/hci.h | 1 +
net/bluetooth/hci_conn.c| 10 +
net/bluetooth/hci_event.c | 31 ++
net
LGTM! If no one has any objections, I would be happy to see this
considered for upstream.
Reviewed-by: Abhishek Kumar
Thanks
Abhishek
On Tue, Dec 15, 2020 at 9:30 AM Youghandhar Chintala
wrote:
>
> Many wifi drivers (e.g. ath10k using qualcomm wifi chipsets)
> support silent target
ws are, or atleast what are
the challenges. As you said the task is much bigger with so many
firmware branches. As long as you feel it is scalable for coming
years, we should be good.
As far as the patch is concerned, it LGTM.
Reviewed-by: Abhishek Kumar
Thanks
Abhishek
Since using DELBA frame to APs to re-establish BA session has a
dependency on APs and also some APs may not honour the DELBA frame. I
am fine with having the disconnect/reconnect solution. The change
looks good to me.
Reviewed-by: Abhishek Kumar
Thanks
Abhishek
On Thu, Jan 28, 2021 at 12:08 AM
Thanks Max. Patch v3 looks good to me.
Reviewed-by: Abhishek Pandit-Subedi
On Thu, Jan 21, 2021 at 5:59 PM wrote:
>
> From: Max Chou
>
> By this change, it will enable WBS supported on the specific Realtek BT
> devices, such as RTL8822C and RTL8852A.
> In the future, it&
e.
>
> Tested-by: Hilda Wu
> Reviewed-by: Abhishek Pandit-Subedi
> Signed-off-by: Max Chou
>
> ---
> v2:
> - edit the null check
> ---
> drivers/bluetooth/btrtl.c | 28
> 1 file changed, 24 insertions(+), 4 deletions(-)
>
> d
Refactor gpio reset to use a common gpio reset function.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
---
drivers/bluetooth/btusb.c | 59 +--
1 file changed, 19 insertions(+), 40 deletions(-)
diff --git a/drivers/bluetooth/btusb.c b
5, etc) in
subsequent changes.
Thanks
Abhishek
Abhishek Pandit-Subedi (3):
Bluetooth: btusb: Refactor gpio reset
Bluetooth: btusb: Trigger gpio reset quicker
Bluetooth: btusb: Expose reset gpio to debugfs
drivers/bluetooth/btusb.c | 107 +++---
1 file c
If btusb has a reset gpio, expose it to userspace so we can toggle the
reset gpio directly. This is useful for testing and error recovery.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
---
drivers/bluetooth/btusb.c | 46 +++
1 file
flight so they recommend
resetting on the third failed command).
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
Reviewed-by: Daniel Winkler
---
drivers/bluetooth/btusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers
a null-check on btrtl_dev->ic_info right above this switch
statement
(https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=b649813eadbc062d8682f7a20aa025275707dd1f).
Is this still necessary with this change? (Sorry, I missed this during
our previous review).
>
> --
> 2.17.1
>
Abhishek
l role)
Signed-off-by: Abhishek Pandit-Subedi
---
Changes in v2:
- Added nullcheck with goto done
drivers/bluetooth/btrtl.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 1abf6a4d6727..24f03a1f8d57 100644
--- a/drivers/blu
l role)
Signed-off-by: Abhishek Pandit-Subedi
---
drivers/bluetooth/btrtl.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 1abf6a4d672734f..978f3c773856b05 100644
--- a/drivers/bluetooth/b
rs like
"tx_mac_seq_by_fw" are initialized. This does not seem to be scalable
and probably these parameters can be auto populated based on FW
capabilities and so we don't have to maintain the static array.
Thoughts?
-Abhishek
Signed-off-by: Abhishek Pandit-Subedi
---
drivers/bluetooth/btrtl.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 94df4e94999d5c8..1abf6a4d672734f 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers
etion handler.
Thanks,
Abhishek
On Mon, Dec 21, 2020 at 6:35 AM Dmitry Osipenko wrote:
>
> 04.12.2020 06:14, Howard Chung пишет:
> > From: Abhishek Pandit-Subedi
> >
> > When suspending, mark SUSPEND_SCAN_ENABLE and SUSPEND_SCAN_DISABLE tasks
> > correctly when either
Just like MGMT_OP_START_DISCOVERY, we should reject
MGMT_OP_START_SERVICE_DISCOVERY with MGMT_STATUS_BUSY when we are paused
for suspend.
Signed-off-by: Abhishek Pandit-Subedi
---
On ChromeOS, we started getting reports of scanning failing after
resuming from suspend. The root cause was that
ernel/git/bluetooth/bluetooth-next.git/commit/?id=36afe87ac10fd71f98c40ccf9923b83e0d3fab68
This fix was tested after reverting all our local patches, applying the
upstream patches and this patch on top.
Thanks
Abhishek
Abhishek Pandit-Subedi (1):
Bluetooth: Remove hci_req_le_suspend_config
in Michaud
Signed-off-by: Abhishek Pandit-Subedi
---
net/bluetooth/hci_request.c | 25 -
1 file changed, 8 insertions(+), 17 deletions(-)
diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
index 71bffd745472043..5aa7bd5030a218c 100644
--- a/net
d=320'
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1
Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1
Signed-off-by: Abhishek Kumar
---
Changes in v3:
- Resurreted Patch V1 because as per discussion we do need two
fallback board names and
e picked (2), right?
> >
> > Do we expect board-2.bin to not be populated with the bdf with variant
> > field (if its necessary ?)
>
> The whole fact that there is a fallback to begin with implies that
> there can be a mismatch between the board-2.bin and the device t
Re-send to NXP email addresses for Chin-Ran Lo and Amitkumar Karwar
(Marvell wireless IP acquired by NXP)
On Tue, Nov 24, 2020 at 11:02 AM Abhishek Pandit-Subedi
wrote:
>
> Hi Marcel,
>
>
> On Mon, Nov 23, 2020 at 3:46 AM Marcel Holtmann wrote:
> >
> > Hi Abhishek,
Hi Marcel,
On Mon, Nov 23, 2020 at 3:46 AM Marcel Holtmann wrote:
>
> Hi Abhishek,
>
> > This patch series adds support for a quirk that will power down the
> > Bluetooth controller when suspending and power it back up when resuming.
> >
> > On Marvell SDIO
*/
Nit: The comment will throw a checkpatch warning. "networking block
comments don't use an empty /* line, use /* Comment..."
-Abhishek
meter, power_down_suspend (which defaults to false).
Signed-off-by: Abhishek Pandit-Subedi
---
drivers/bluetooth/btmrvl_sdio.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index 33d58b30c5acfc..e2e4917b4fe589 100644
Some older controllers fail to enter a quiescent state reliably when
supporting remote wake. For those cases, add a quirk that will power
down the controller when suspending and power it back up when resuming.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
---
include/net
Rename clean_up_hci_state and move to the core header so that we can
power down the controller from within the kernel rather than just via
mgmt commands.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Daniel Winkler
Reviewed-by: Miao-chen Chou
---
include/net/bluetooth/hci_core.h | 2
h_AdapterSRHealth (basic suite)
- bluetooth_AdapterSRHealth.sr_reconnect_classic_hid_stress
- bluetooth_AdapterSRHealth.sr_reconnect_le_hid_stress
Thanks,
Abhishek
Abhishek Pandit-Subedi (3):
Bluetooth: Rename and move clean_up_hci_state
Bluetooth: Add quirk to power down on suspend
Bluetooth
e the
crash dump triggering + waiting in multiple places (and if you get the
spurious wake bug WHILE doing SSR, it won't re-trigger the same
restart over and over).
Abhishek
> ---
> drivers/bluetooth/hci_qca.c | 99
> -
> 1 file cha
m the firmware.
>
Looks like the length for each tag is already being validated in
ath10k_wmi_tlv_iter() and would return error if the length does not
match against the wmi policy., so I think the tlv message validation
is already being done. Kalle, Is the expectation here is to do
anything addition
This patch extends ath10k_core_create_board_name function to support chip id
based BDF selection and not add provision for fallback_boardname2, thus
introducing lesser lines of code.
(no changes since v1)
Abhishek Kumar (1):
ath10k: add option for chip-id based BDF selection
drivers/net
d=320'
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1
Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1
Signed-off-by: Abhishek Kumar
---
(no changes since v1)
drivers/net/wireless/ath/ath10k/core.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
Apologies for the delay, was busy so could not work on V2 . I have
started working on V2 patch. Will upload by today/tomorrow.
Abhishek
On Thu, Nov 5, 2020 at 11:11 PM Kalle Valo wrote:
>
> Abhishek Kumar wrote:
>
> > In some devices difference in chip-id should be enough
of cpuidle
states in the driver by the user. Will add the capability of this
driver to be used as a module in subsequent patches.
Original idea and discussion for this patch can be found at:
https://lkml.org/lkml/2019/12/17/655
Signed-off-by: Abhishek Goel
---
v1->v2 : Changes adapted f
Additionally tested on ath10k based non-QMI platform
Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1
Tested-by: Abhishek Kumar
-Abhishek
ged. Please consider this patch abandoned.
Abhishek
On Mon, Oct 19, 2020 at 10:56 PM Greg Kroah-Hartman
wrote:
>
> On Mon, Oct 19, 2020 at 03:32:57PM -0700, Abhishek Pandit-Subedi wrote:
> > Add a check to make sure the kobj is created and in sysfs before sending
> > a change eve
It looks like we hadn't merged an earlier update to crnv32.bin in ChromeOS:
ad1da95 - QCA : Updated firmware files for WCN3991 (3 weeks ago)
After merging that commit, everything is working as expected.
--
Tested-by: Abhishek Pandit-Subedi
On Mon, Oct 19, 2020 at 2:37 PM Abhishek P
d=320'
Signed-off-by: Abhishek Kumar
---
drivers/net/wireless/ath/ath10k/core.c | 45 +++---
1 file changed, 34 insertions(+), 11 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/core.c
b/drivers/net/wireless/ath/ath10k/core.c
index a3f15cc89a10..767bb9d6a
nt on
wakeup_sysfs_add/remove)
Signed-off-by: Abhishek Pandit-Subedi
---
lib/kobject_uevent.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index 7998affa45d49a..f08197e907d5ce 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -473,6 +4
s/bus/usb/devices/2-3
> Check class of first interface ...
> No access to first interface. Exit
I've added a patch to fix the former problem here and confirmed via
udevadm monitor that no CHANGE requests are seen for devices before they
emit the ADD event.
Thanks
Abhis
Nack.
This resulted in a boot loop on ChromeOS. It looks like only
'crbtfw32.tlv' was changed and not 'crnv32.bin'.
Abhishek
On Sat, Oct 17, 2020 at 8:33 AM wrote:
>
>
> Hi Team,
>
> Please include updated firmware bin for WCN3991.
>
> Snapshot of
822CS capabilities to show it supports wideband speech
and has valid le states (allows central peripheral role).
Signed-off-by: Abhishek Pandit-Subedi
---
drivers/bluetooth/hci_h5.c | 53 +++---
1 file changed, 44 insertions(+), 9 deletions(-)
diff --git a/drivers/blue
Reviewed-by: Abhishek Pandit-Subedi
On Tue, Oct 6, 2020 at 8:20 AM Balakrishna Godavarthi
wrote:
>
> From: Venkata Lakshmi Narayana Gubba
>
> Currently qca_suspend() is relied on IBS mechanism. During
> FW download and memory dump collections, IBS will be disabled.
> In t
Reviewed-by: Abhishek Pandit-Subedi
On Mon, Oct 5, 2020 at 11:33 PM Balakrishna Godavarthi
wrote:
>
> Currently driver only retries to download FW if FW downloading
> is failed. Sometimes observed command timeout for version request
> command, if this happen on some platforms duri
WCN3991 supports connectable advertisements so we need to add the valid
le states quirk so the 'central-peripheral' role is exposed in
userspace.
Signed-off-by: Abhishek Pandit-Subedi
---
Example result showing the central-peripheral role correctly.
localhost # bluetoothctl show
Con
+ Alex Lu (who contributed the original change)
Hi Kai-Heng,
On Thu, Sep 24, 2020 at 12:10 AM Kai-Heng Feng
wrote:
>
> [+Cc linux-usb]
>
> Hi Abhishek,
>
> > On Sep 24, 2020, at 04:41, Abhishek Pandit-Subedi
> > wrote:
> >
> > Hi Kai-Heng,
>
x27;t cut off power during suspend, maybe you
shouldn't set the BTUSB_WAKEUP_DISABLE flag for that controller.
I would prefer this doesn't get accepted in its current state.
Abhishek
On Wed, Sep 23, 2020 at 10:56 AM Kai-Heng Feng
wrote:
>
> Realtek bluetooth controller may fail
set of cpuidle
states in the driver. Will add the capability of this driver to be used
as a module in subsequent patches.
Original idea and discussion for this patch can be found at:
https://lkml.org/lkml/2019/12/17/655
Signed-off-by: Abhishek Goel
---
v1-> v2 : Includes minor changes adap
lock: 0xff804410aac0, .magic: , .owner: /-1,
.owner_cpu: 0
[ 3465.430332] Causing a watchdog bite!
Signed-off-by: Abhishek Pandit-Subedi
Reported-by: Balakrishna Godavarthi
Reviewed-by: Manish Mandlik
---
We had some more data available (outside of dmesg and oops) that led us
to suspect a
Data length: 0x0d
Name (short): Chromebook
> HCI Event: Command Complete (0x0e) plen 4
LE Set Extended Scan Response Data (0x08|0x0038) ncmd 1
Status: Invalid HCI Command Parameters (0x12)
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Daniel Winkler
---
net
Add the controller suspend and resume events, which will signal when
Bluetooth has completed preparing for suspend and when it's ready for
resume.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
Reviewed-by: Sonny Sasaka
---
Changes in v2:
- Added suspend/resume even
Update device disconnect event with reason 0x5 to indicate that device
disconnected because the controller is suspending.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
Reviewed-by: Sonny Sasaka
---
Changes in v2: None
include/net/bluetooth/mgmt.h | 1 +
net/bluetooth
spend state: Page scanning and/or passive scanning (2)
@ MGMT Event: Controller Resumed (0x002e) plen 8
Wake reason: Remote wake due to peer device connection (2)
LE Address: CD:F3:CD:13:C5:9A (OUI CD-F3-CD)
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen
.
Patch for btmon changes: https://patchwork.kernel.org/patch/11743863/
Please take a look.
Abhishek
Changes in v2:
- Added suspend/resume events to list of mgmt events
Abhishek Pandit-Subedi (3):
Bluetooth: Add mgmt suspend and resume events
Bluetooth: Add suspend reason for device disconnect
Update device disconnect event with reason 0x5 to indicate that device
disconnected because the controller is suspending.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
Reviewed-by: Sonny Sasaka
---
include/net/bluetooth/mgmt.h | 1 +
net/bluetooth/mgmt.c | 4
spend state: Page scanning and/or passive scanning (2)
@ MGMT Event: Controller Resumed (0x002e) plen 8
Wake reason: Remote wake due to peer device connection (2)
LE Address: CD:F3:CD:13:C5:9A (OUI CD-F3-CD)
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen
.
Patch for btmon changes: https://patchwork.kernel.org/patch/11743863/
Please take a look.
Abhishek
Abhishek Pandit-Subedi (3):
Bluetooth: Add mgmt suspend and resume events
Bluetooth: Add suspend reason for device disconnect
Bluetooth: Emit controller suspend and resume events
include/net
Add the controller suspend and resume events, which will signal when
Bluetooth has completed preparing for suspend and when it's ready for
resume.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
Reviewed-by: Sonny Sasaka
---
include/net/bluetooth/hci_core.h
Unregister_pm_notifier is a blocking call so suspend tasks should be
cleared beforehand. Otherwise, the notifier will wait for completion
before returning (and we encounter a 2s timeout on resume).
Fixes: 0e9952804ec9c8 (Bluetooth: Clear suspend tasks on unregister)
Signed-off-by: Abhishek Pandit
Unregister_pm_notifier is a blocking call so suspend tasks should be
cleared beforehand. Otherwise, the notifier will wait for completion
before returning (and we encounter a 2s timeout on resume).
Fixes: 0e9952804ec9c8 (Bluetooth: Clear suspend tasks on unregister)
Signed-off-by: Abhishek Pandit
v2 sent with fix.
On Mon, Aug 31, 2020 at 8:49 AM Marcel Holtmann wrote:
>
> Hi Abhishek,
>
> > While unregistering, make sure to clear the suspend tasks before
> > cancelling the work. If the unregister is called during resume from
> > suspend, this will unnecessaril
While unregistering, make sure to clear the suspend tasks before
cancelling the work. If the unregister is called during resume from
suspend, this will unnecessarily add 2s to the resume time otherwise.
Fixes: 4e8c36c3b0d73d (Bluetooth: Fix suspend notifier race)
Signed-off-by: Abhishek Pandit
Please disregard this earlier email without the Fixes tag.
On Wed, Aug 26, 2020 at 3:26 PM Abhishek Pandit-Subedi
wrote:
>
> While unregistering, make sure to clear the suspend tasks before
> cancelling the work. If the unregister is called during resume from
> suspend, this will u
While unregistering, make sure to clear the suspend tasks before
cancelling the work. If the unregister is called during resume from
suspend, this will unnecessarily add 2s to the resume time otherwise.
Fixes: 4e8c36c3b0d73d (Bluetooth: Fix suspend notifier race)
Signed-off-by: Abhishek Pandit
While unregistering, make sure to clear the suspend tasks before
cancelling the work. If the unregister is called during resume from
suspend, this will unnecessarily add 2s to the resume time otherwise.
Signed-off-by: Abhishek Pandit-Subedi
---
This was discovered with RT8822CE using the btusb
. finding spurious wakes
due to BT in suspend stress tests, asserting that wakeup from peers
occurred as expected in tests)
Abhishek
On Tue, Aug 4, 2020 at 10:11 AM Abhishek Pandit-Subedi
wrote:
>
> Hi,
>
> Gentle reminder that this is waiting for feedback. Related userspace
> chan
lock: 0xff804410aac0, .magic: , .owner: /-1,
.owner_cpu: 0
[ 3465.430332] Causing a watchdog bite!
Signed-off-by: Abhishek Pandit-Subedi
Reported-by: Balakrishna Godavarthi
Reviewed-by: Manish Mandlik
---
We had some more data available (outside of dmesg and oops) that led us
to suspect a
Data length: 0x0d
Name (short): Chromebook
> HCI Event: Command Complete (0x0e) plen 4
LE Set Extended Scan Response Data (0x08|0x0038) ncmd 1
Status: Invalid HCI Command Parameters (0x12)
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Daniel Winkler
---
net
Hi,
Gentle reminder that this is waiting for feedback. Related userspace
changes are here to see how we plan on using it:
https://patchwork.kernel.org/project/bluetooth/list/?series=325777
Thanks
Abhishek
On Tue, Jul 28, 2020 at 6:42 PM Abhishek Pandit-Subedi
wrote:
>
>
> Hi Marcel,
to enable autosuspend on working
systems so it should be reverted. Disabling autosuspend should be done
via module param or udev in userspace instead.
Signed-off-by: Abhishek Pandit-Subedi
---
We have a few Chromebooks using the RTL 8822CE part over USB and they
are running without problems with
spend state: Page scanning and/or passive scanning (2)
@ MGMT Event: Controller Resumed (0x002e) plen 8
Wake reason: Remote wake due to peer device connection (2)
LE Address: CD:F3:CD:13:C5:9A (OUI CD-F3-CD)
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen
Add the controller suspend and resume events, which will signal when
Bluetooth has completed preparing for suspend and when it's ready for
resume.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
Reviewed-by: Sonny Sasaka
---
include/net/bluetooth/hci_core.h
.
Please take a look.
Abhishek
Abhishek Pandit-Subedi (3):
Bluetooth: Add mgmt suspend and resume events
Bluetooth: Add suspend reason for device disconnect
Bluetooth: Emit controller suspend and resume events
include/net/bluetooth/hci_core.h | 6 +++
include/net/bluetooth/mgmt.h | 16
Update device disconnect event with reason 0x5 to indicate that device
disconnected because the controller is suspending.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
Reviewed-by: Sonny Sasaka
---
include/net/bluetooth/mgmt.h | 1 +
net/bluetooth/mgmt.c | 4
t;)
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
---
Hi Marcel,
This fixes a race between hci_unregister_dev and the suspend notifier.
The suspend notifier handler seemed to be scheduling commands even after
it was cleaned up and this was resulting in a panic in cmd_timeou
I sent this a bit too quick without a Fixes tag. Please disregard. v3 coming up.
On Tue, Jul 28, 2020 at 9:53 AM Abhishek Pandit-Subedi
wrote:
>
> Unregister from suspend notifications and cancel suspend preparations
> before running hci_dev_do_close. Otherwise, the suspend notifier m
[ 832.751147] kthread+0x138/0x140
[ 832.754377] ? pr_cont_work+0x58/0x58
[ 832.758037] ? kthread_blkcg+0x2e/0x2e
[ 832.761787] ret_from_fork+0x22/0x40
[ 832.846191] ---[ end trace fa93f466da517212 ]---
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
---
Hi Marcel,
This
Unregister from suspend notifications and cancel suspend preparations
before running hci_dev_do_close. Otherwise, the suspend notifier may
race with unregister and cause cmd_timeout even after hdev has been
freed.
Signed-off-by: Abhishek Pandit-Subedi
Reviewed-by: Miao-chen Chou
---
Hi Marcel
set of cpuidle
states in the driver. Will add the capability of this driver to be used
as a module in subsequent patches.
Original idea and discussion for this patch can be found at:
https://lkml.org/lkml/2019/12/17/655
Signed-off-by: Abhishek Goel
---
drivers/cpuidle/Kconfig| 9
innocuous since the
power_supply initializes fully in the next line:
kern :err : [5.918034] power_supply ADP1: Error in uevent for
wakeup_sysfs_add: -11
kern :info : [5.918300] ACPI: AC Adapter [ADP1] (on-line)
Abhishek
On Mon, Jul 13, 2020 at 10:30 PM kernel test robot
wrote:
>
On Wed, Jul 8, 2020 at 12:34 PM Randy Dunlap wrote:
>
> Hi again,
>
> On 7/8/20 12:25 PM, Abhishek Bhardwaj wrote:
> > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> > index b277a2db62676..1f85374a0b812 100644
> > --- a/arch/x86/kvm/Kconfig
> > +++
a compile time thing rather than adding
extra code plus whatever miniscule time at runtime to pass an
extra argument.
- Finally, it doesn't preclude the runtime / kernel command line way.
Users are free to use those as well.
Signed-off-by: Abhishek Bhardwaj
---
Changes in v5:
- Fix ind
On Mon, Jul 6, 2020 at 8:14 AM Waiman Long wrote:
>
> On 7/5/20 5:51 PM, Abhishek Bhardwaj wrote:
>
> That is why I said a comment will have to be added to highlight this
> dependency. For instance,
>
> +/*
> + * Three of the enums are explicitly assigned as the KVM_VMENTR
a compile time thing rather than adding
extra code plus whatever miniscule time at runtime to pass an
extra argument.
- Finally, it doesn't preclude the runtime / kernel command line way.
Users are free to use those as well.
Signed-off-by: Abhishek Bhardwaj
---
Changes in v4:
- Add mot
nable to emit a changed event when adding or removing attributes on
the device.
Signed-off-by: Abhishek Pandit-Subedi
---
Changes in v5:
- Ignore return from kobject_uevent when adding to sysfs
Changes in v4:
- Fix warning where returning from void and tested on device
Changes in v3:
- Simpl
-3:1.1
(usb)
Thanks
Abhishek
Changes in v5:
- Ignore return from kobject_uevent when adding to sysfs
Changes in v4:
- Fix warning where returning from void and tested on device
Changes in v3:
- Simplified error handling
Changes in v2:
- Add newline at end of bt_dev_err
Abhishek Pandit-Subedi (1):
Sounds good to me. Patch v5 incoming after compile-test.
Thanks
Abhishek
On Tue, Jul 7, 2020 at 10:16 AM Rafael J. Wysocki wrote:
>
> On Tue, Jul 7, 2020 at 6:48 PM Abhishek Pandit-Subedi
> wrote:
> >
> > Hi Rafael,
> >
> > (resent in plain text)
> >
>
Hi Rafael,
(resent in plain text)
On Tue, Jul 7, 2020 at 9:28 AM Rafael J. Wysocki wrote:
>
> On Tue, Jul 7, 2020 at 6:24 PM Abhishek Pandit-Subedi
> wrote:
> >
> > Udev rules that depend on the power/wakeup attribute don't get triggered
> > correctly if dev
Built and tested on Chromebook w/ 5.4 kernel.
Sorry about the churn -- will start building with warnings = errors
before I send patches upstream.
Thanks
Abhishek
On Tue, Jul 7, 2020 at 9:24 AM Abhishek Pandit-Subedi
wrote:
>
> Udev rules that depend on the power/wakeup attribute don
-3:1.1
(usb)
Thanks
Abhishek
Changes in v4:
- Fix warning where returning from void and tested on device
Changes in v3:
- Simplified error handling
Changes in v2:
- Add newline at end of bt_dev_err
Abhishek Pandit-Subedi (1):
power: Emit changed uevent on wakeup_sysfs_add/remove
drivers/b
1 - 100 of 792 matches
Mail list logo
