[PATCH v6] ftrace: support early boot function tracing

2019-01-14 Thread Abderrahmane Benbachir
which function to save and which one to discard. Signed-off-by: Abderrahmane Benbachir Cc: Steven Rostedt Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Mathieu Desnoyers Cc: Linux Kernel --- --- arch/x86/Kconfig| 1 + arch/x86/kernel/ftrace_32.S | 45 -- arch/x86/kernel/ftrac

[PATCH v5] ftrace: support early boot function tracing

2019-01-12 Thread Abderrahmane Benbachir
/ not traced), then during the callback from mcount hook, we do binary search lookup to decide which function to save and which one to discard. Signed-off-by: Abderrahmane Benbachir Cc: Steven Rostedt Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org --- ar

[PATCH v5] ftarce: support early boot function tracing

2018-12-10 Thread Abderrahmane Benbachir
d with live patching, we use ftrace_filter and ftrace_notrace to find which functions to be filtered (traced / not traced), then during the callback from mcount hook, we do binary search lookup to decide which function to be save or not. Signed-off-by: Abderrahmane Benbachir Cc: Steven Rostedt Cc

[PATCH v4] ftrace: support early boot function tracing

2018-12-06 Thread Abderrahmane Benbachir
emory setup. Dynamic tracing is not implemented with live patching, we use ftrace_filter and ftrace_notrace to find which functions to be filtered (traced / not traced), then during the callback from mcount hook, we do binary search lookup to decide which function to be save or not. Signed-off-by: A

Re: [RFC PATCH v3] ftrace: support very early function tracing

2018-11-29 Thread Abderrahmane Benbachir
+Paul, +Eddie and +Feng. Hi Steven, any update regarding this patch. I'm including some folks from server performance analysis team in microsoft, they are currently investigating early boot-up latencies using ftrace. Abderrahmane Benbachir a écrit : Hi Steve, I believe this pat

[RFC PATCH v3] ftrace: support very early function tracing

2018-10-24 Thread Abderrahmane Benbachir
ed-off-by: Abderrahmane Benbachir Cc: Steven Rostedt Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org --- arch/x86/Kconfig| 1 + arch/x86/kernel/ftrace_32.S | 45 -- arch/x86/kernel/ftrace_64.S | 14 ++ include/linux/ftrace.h | 16

[PATCH] trace: instrument security and console initcall

2018-03-22 Thread Abderrahmane Benbachir
Hi Steve,  This is the patch for security & console initcall's instrumentation Signed-off-by: Abderrahmane Benbachir Cc: Steven Rostedt Cc: Ingo Molnar Cc: Peter Zijlstra Cc: linux-kernel@vger.kernel.org --- kernel/printk/printk.c | 7 ++- security/security.c| 8 +++-

Re: [RFC PATCH] ftrace: support boot level tracing

2018-03-20 Thread Abderrahmane Benbachir
Steven Rostedt a écrit : On Tue, 20 Mar 2018 14:22:56 -0400 Abderrahmane Benbachir wrote: Would something like this work for you? Yes this is working great. I have also instrumented console and security initcalls, I used your previous patch, changes are below

[RFC PATCH] ftrace: support boot level tracing

2018-03-20 Thread Abderrahmane Benbachir
trace_bootlevel_start_handler: Start early boot level < [0.456659] : intel_pmu_init <-init_hw_perf_events [0.457299] : p6_pmu_init <-intel_pmu_init [0.457851] : numachip_system_init <-do_one_initcall ... Signed-off-by: Abderrahmane Benbachir Cc: Steven Rostedt Cc:

Re: Very Early boot time stamps support

2017-11-29 Thread Abderrahmane Benbachir
Pavel Tatashin a écrit : Hi Abderrahmane, I'm implementing a feature in ftrace to enable very early function tracing, I'm using tsc when x86_tsc feature is available, but it seems that you did similar work in your patch "[PATCH v9 0/6] Early boot time stamps for x86". I need to record times

Very Early boot time stamps support

2017-11-21 Thread Abderrahmane Benbachir
Hi Pavel, I'm implementing a feature in ftrace to enable very early function tracing, I'm using tsc when x86_tsc feature is available, but it seems that you did similar work in your patch "[PATCH v9 0/6] Early boot time stamps for x86". I need to record timestamps at the start of start_ke

[RFC PATCH v2 improved] ftrace: support very early function tracing

2017-11-08 Thread Abderrahmane Benbachir
notrace to find which functions to be filtered (traced / not traced), then during the callback from mcount hook, we do binary search lookup to decide which function to be save or not. Signed-off-by: Abderrahmane Benbachir Cc: Steven Rostedt Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Mathieu Desnoy

Re: [RFC PATCH v2] ftrace: support very early function tracing

2017-11-08 Thread Abderrahmane Benbachir
I implemented the ring_buffer_set_clock solution and I have some questions. void __init ftrace_early_fill_ringbuffer(void *data) { ... ring_buffer_set_clock(tr->trace_buffer.buffer, early_trace_clock); preempt_disable_notrace(); for (i = 0; i < vearly_entries_count; i++)

Re: [RFC PATCH v2] ftrace: support very early function tracing

2017-11-08 Thread Abderrahmane Benbachir
Steven Rostedt a écrit : ring_buffer_set_clock(tr->trace_buffer.buffer, early_trace_clock); Then have: static u64 early_timestamp __initdata; static __init u64 early_trace_clock(void) { return early_timestamp; } Then we can have: + p

[RFC PATCH v2] ftrace: support very early function tracing

2017-11-07 Thread Abderrahmane Benbachir
filtered (traced / not traced), then during the callback from mcount hook, we do binary search lookup to decide which function to be save or not. Signed-off-by: Abderrahmane Benbachir Cc: Steven Rostedt Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Mathieu Desnoyers Cc: linux-kernel@vger.kernel.

Re: [PATCH] init/main.c: check for null pointer before calling initcall

2017-10-27 Thread Abderrahmane Benbachir
David Daney a écrit : On 10/27/2017 11:22 AM, Thomas Gleixner wrote: On Fri, 27 Oct 2017, David Daney wrote: On 10/27/2017 09:47 AM, Abderrahmane Benbachir wrote: Simple check to prevent kernel panic when initcall does not exit Interesting, under what circumstances do you observe the

[PATCH] init/main.c: check for null pointer before calling initcall

2017-10-27 Thread Abderrahmane Benbachir
Simple check to prevent kernel panic when initcall does not exit Signed-off-by: Abderrahmane Benbachir --- init/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/init/main.c b/init/main.c index 0ee9c6866ada..220fd2822b61 100644 --- a/init/main.c +++ b/init/main.c @@ -817,6 +817,9