RE: (2) [PATCH] fs: fat: add check for dir size in fat_calc_dir_size

2020-06-30 Thread AMIT SAHRAWAT
  > There are many implementation that doesn't follow the spec strictly. And > when I tested in past, Windows also allowed to read the directory beyond > that limit. I can't recall though if there is in real case or just test > case though. >>> Thanks Ogawa, yes there are many implementations, pref

RE:(2) [PATCH] fs: fat: add check for dir size in fat_calc_dir_size

2020-06-30 Thread AMIT SAHRAWAT
e are no such error reported on our side. We had to trace to check the point of stuck in simple 'ls -lR'. Thanks & Regards, Amit Sahrawat     - Original Message - Sender : OGAWA Hirofumi  Date : 2020-06-30 16:38 (GMT+5:30) Title : Re: [PATCH] fs: fat: add check

RE: Re: ftrace/module: Move ftrace_release_mod() to ddebug_cleanup label

2017-12-11 Thread AMIT SAHRAWAT
but since ftrace_module_init() >> is not return with minimum changes it should be in ddebug_cleanup label. >> >> >> Signed-off-by: Namit Gupta >> Reviewed-by: Amit Sahrawat > >Linus really looks down on this type of "Reviewed-by" tags. They are >m

Re: Ext4: deadlock occurs when running fsstress and ENOSPC errors are seen.

2014-04-21 Thread Amit Sahrawat
Hi Darrick, Thanks for the reply, sorry for responding late. On Wed, Apr 16, 2014 at 11:16 PM, Darrick J. Wong wrote: > On Wed, Apr 16, 2014 at 01:21:34PM +0530, Amit Sahrawat wrote: >> Sorry Ted, if it caused the confusion. >> >> There were actually 2 parts to the pro

Re: Ext4: deadlock occurs when running fsstress and ENOSPC errors are seen.

2014-04-16 Thread Amit Sahrawat
running. Again, Sorry for the confusion. But the intention was just to show the original problem and what we did in order to replicate the problem. Thanks & Regards, Amit Sahrawat On Wed, Apr 16, 2014 at 10:37 AM, Theodore Ts'o wrote: > On Wed, Apr 16, 2014 at 10:30:10AM +0530, Ami

Re: Ext4: deadlock occurs when running fsstress and ENOSPC errors are seen.

2014-04-15 Thread Amit Sahrawat
finish_plug(&plug); goto out_writepages; } After making these changes, as soon as there is corruption – the FS is marked RO and all pending DIRTY writes are cleared. So, the hang is not seen. But we have a doubt about the possible side-effects of this

Ext4: deadlock occurs when running fsstress and ENOSPC errors are seen.

2014-04-15 Thread Amit Sahrawat
Initially in normal write path, when the disk was almost full – we got hung for the ‘sync’ because the flusher (which is busy in the writepages is not responding). Before the hung task, we also found the logs like: EXT4-fs error (device sda1): ext4_mb_generate_buddy:742: group 1493, 0 clusters in

Re: [PATCH RESEND 3/3] usb: storage: update usb devices for write cache quirk in quirk list.

2012-07-11 Thread Amit Sahrawat
Hi James, Please have a look at the patchset and share your opinion. If there is anything more to it - please let us know. Thanks & Regards, Amit Sahrawat On Sun, Jul 8, 2012 at 8:35 AM, Namjae Jeon wrote: > From: Namjae Jeon > > Update information of Seagate Portable HDD and W