Hi David
02.03.2015, 03:17, "David Fries" :
> You are correct, it would be a race condition if it doesn't increment
> the refcnt before unlocking the mutex, and it should get the mutex
> before unref. Here's an updated version, I haven't even tried to
> compile it.
>
> What do you think Evgeniy?
Hi Dan
20.02.2015, 13:53, "Dan Carpenter" :
> "sl->family->fops" and "fops" are the same thing, but it's nicer to use
> "fops" everywhere.
>
> Signed-off-by: Dan Carpenter
Looks good to me, thank you
Acked-by: Evgeniy Polyakov
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index 181f41c..
Hi
08.11.2014, 02:30, "NeilBrown" :
> This driver has no 'compatible' string and so is not found when
> using device-tree.
>
> Add one with value to match
> hdqw1w: 1w@480b2000 {
> device in omap3.dtsi.
>
> Signed-off-by: NeilBrown
Looks good to me
Acked-by: Evgeniy Polyakov
--
Hi
08.11.2014, 02:33, "NeilBrown" :
> 1/ change request_module call to zero-pad single digit
> family numbers. This appears to be the intention of
> the code, but not what it actually does.
>
> This means that the alias created for W1_FAMILY_SMEM_01
> might actually be useful.
>
> 2/
Hi
10.11.2014, 01:37, "David Fries" :
> These issues were found by Dan Carpenter with a static checker.
> Evgeniy are you okay with these?
>
> [PATCH 1/2] cn: verify msg->len before making callback
> [PATCH 2/2] w1: avoid potential u16 overflow
Both patches look good, thank you
Acked-by: Evgeniy
Hi everyone
This looks good to me
Greg, please pull it into your tree
Thank you
25.10.2014, 16:27, "Alexander Stein" :
> Adjust the bulk message timeout to the other ones (1000ms). Otherwise the
> following dmesg errors can be seen on a Raspberry Pi:
> [ 31.492386] Failed to read 1-wire data f
6 matches
Mail list logo
