Re: [PATCH v2 01/11] firmware: qcom_scm: Introduce PAS context initialization helper

2025-08-19 Thread Mukesh Ojha
On Tue, Aug 19, 2025 at 10:47:45PM +0530, Pavan Kondeti wrote: > On Tue, Aug 19, 2025 at 10:24:36PM +0530, Mukesh Ojha wrote: > > Currently, remoteproc and non-remoteproc subsystems use different > > variants of the MDT loader helper API, primarily due to the handling of > > the metadata context. R

[PATCH] selftests/ftrace: Split worlds in return string

2025-08-19 Thread Bartlomiej Kubik
Split concatenated words in return string. Signed-off-by: Bartlomiej Kubik --- tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ftrace/test.d/event/event-no-pid.tc b/tools/testing/selftests/ft

[PATCH] selftests/timers: Improve POSIX timer test messages

2025-08-19 Thread I Viswanath
- Break up the ksft_print_msg statements to follow the 80 char rule. - Capitalize "POSIX" and rephrase messages for better readability. - Clarify that false negatives may occur in tests relying on timers if other threads run on the CPU. Signed-off-by: I Viswanath --- tools/testing/selftests/ti

Re: [PATCH v6 4/9] scsi: Always define blogic_pci_tbl structure

2025-08-19 Thread Martin K. Petersen
Hi Nathan! >> Applied to 6.18/scsi-staging, thanks! > > I think I will need this change to apply patch 7 [1] to kbuild-next > without any issues [2]. If there is little risk of conflict, could I > take it with your Ack? Sure, no problem. Dropped the patch from my tree. Acked-by: Martin K. Pete

Re: [PATCH v2 13/20] x86/mm: enable page table sharing

2025-08-19 Thread Anthony Yznaga
Hi Yongting, On 8/18/25 2:44 AM, Yongting Lin wrote: Thank you! Anthony. Yep, I checked the comments in arch/mm/x86/fault.c file which says as your advices in previous email. I changed my code in kernel 5.5 as below: if (unlikely(is_shared_vma) && ((fault & VM_FAULT_RETRY) &&

Re: [PATCH bpf-next v2 1/7] rcu: add rcu_read_lock_dont_migrate()

2025-08-19 Thread Menglong Dong
On Tue, Aug 19, 2025 at 10:58 PM Paul E. McKenney wrote: > > On Tue, Aug 19, 2025 at 05:34:18PM +0800, Menglong Dong wrote: > > migrate_disable() is called to disable migration in the kernel, and it is > > often used together with rcu_read_lock(). > > > > However, with PREEMPT_RCU disabled, it's u

Re: [PATCH v5] remoteproc: Use of_reserved_mem_region_* functions for "memory-region"

2025-08-19 Thread Dmitry Baryshkov
On Tue, Aug 19, 2025 at 04:38:27PM -0500, Rob Herring (Arm) wrote: > Use the newly added of_reserved_mem_region_to_resource() and > of_reserved_mem_region_count() functions to handle "memory-region" > properties. > > The error handling is a bit different in some cases. Often > "memory-region" is o

Re: [PATCH V2 14/20] cxl/region: Add devm_cxl_pmem_add_region() for pmem region creation

2025-08-19 Thread Dave Jiang
On 7/30/25 5:12 AM, Neeraj Kumar wrote: > devm_cxl_pmem_add_region() is used to create cxl region based on region > information scanned from LSA. > > devm_cxl_add_region() is used to just allocate cxlr and its fields are > filled later by userspace tool using device attributes (*_store()). > >

Re: [PATCH v2] arch/x86/kvm/ioapic: Remove license boilerplate with bad FSF address

2025-08-19 Thread Sean Christopherson
On Mon, 28 Jul 2025 17:28:43 +0200, Thomas Huth wrote: > The Free Software Foundation does not reside in "59 Temple Place" > anymore, so we should not mention that address in the source code here. > But instead of updating the address to their current location, let's > rather drop the license boile

Re: [PATCH] selftests: harness: Rework is_signed_type() to avoid collision with overflow.h

2025-08-19 Thread Sean Christopherson
On Tue, 24 Jun 2025 16:19:30 -0700, Sean Christopherson wrote: > Rename is_signed_type() to is_signed_var() to avoid colliding with a macro > of the same name defined by linux/overflow.h. Note, overflow.h's version > takes a type as the input, whereas the harness's version takes a variable! > > T

Re: [PATCH v2 4/8] selftests/mm: Add -Wunused family of flags

2025-08-19 Thread Andrew Morton
On Mon, 18 Aug 2025 10:16:35 +0200 Kevin Brodsky wrote: > > # Avoid accidental wrong builds, due to built-in rules working just a > > little > > # bit too well--but not quite as well as required for our situation here. > > # > > @@ -35,6 +34,7 @@ MAKEFLAGS += --no-builtin-rules > > > > CFL

[PATCH] rseq/selftests: Use weak symbol reference, not definition, to link with glibc

2025-08-19 Thread Sean Christopherson
Add "extern" to the glibc-defined weak rseq symbols to convert the rseq selftest's usage from weak symbol definitions to weak symbol _references_. Effectively re-defining the glibc symbols wreaks havoc when building with -fno-common, e.g. generates segfaults when running multi-threaded programs, as

[PATCH] selftests/x86: fix coding style errors in test_syscall_vdso.c

2025-08-19 Thread Raphael Pinsonneault-Thibeault
fix 68 checkpatch errors in tools/testing/selftests/x86/test_syscall_vdso.c: add void to function definitions without parameters fix whitespace in charp array definitions fix whitespace in printf statements Signed-off-by: Raphael Pinsonneault-Thibeault --- for the whitespace errors, attempted to

[PATCH v5] remoteproc: Use of_reserved_mem_region_* functions for "memory-region"

2025-08-19 Thread Rob Herring (Arm)
Use the newly added of_reserved_mem_region_to_resource() and of_reserved_mem_region_count() functions to handle "memory-region" properties. The error handling is a bit different in some cases. Often "memory-region" is optional, so failed lookup is not an error. But then an error in of_reserved_mem

Re: [PATCH] selftests/futex: Fix some futex_numa_mpol subtests

2025-08-19 Thread Waiman Long
On 8/19/25 8:22 AM, André Almeida wrote: Hi Waiman, Em 10/08/2025 19:27, Waiman Long escreveu: The "Memory out of range" subtest of futex_numa_mpol assumes that memory access outside of the mmap'ed area is invalid. That may not be the case depending on the actual memory layout of the test appli

[PATCH] selftests/powerpc: fix spelling errors across test sources

2025-08-19 Thread Nikil Paul S
Fix a number of minor spelling mistakes in selftests/powerpc sources, including ptrace, tm, pmu, math, alignment, and gzip tests. These changes improve readability of test messages and comments without affecting functionality as only comments were edited. Signed-off-by: Nikil Paul S --- .../self

Re: [PATCH] selftests/livepatch: Ignore NO_SUPPORT line in dmesg

2025-08-19 Thread Ricardo B . Marlière
On Tue Aug 19, 2025 at 2:37 PM -03, Ricardo B. Marlière wrote: > Some systems might disable unloading a livepatch and when running tests on > them they fail like the following: oops, sorry.. Please ignore this patch, this should be handled downstream along with https://github.com/openSUSE/kernel-

Re: [PATCH V2 03/20] nvdimm/namespace_label: Add namespace label changes as per CXL LSA v2.1

2025-08-19 Thread Ira Weiny
Neeraj Kumar wrote: > CXL 3.2 Spec mentions CXL LSA 2.1 Namespace Labels at section 9.13.2.5 > Modified __pmem_label_update function using setter functions to update > namespace label as per CXL LSA 2.1 > > Signed-off-by: Neeraj Kumar [snip] > > +static inline void nsl_set_type(struct nvdimm_

Re: [v17,6/7] rust: samples: add a module parameter to the rust_minimal sample

2025-08-19 Thread Darin Morrison
> Showcase the rust module parameter support by adding a module parameter to > the `rust_minimal` sample. > > Reviewed-by: Benno Lossin > Signed-off-by: Andreas Hindborg > --- > samples/rust/rust_minimal.rs | 10 ++ > 1 file changed, 10 insertions(+) > diff --git a/samples/rust/rust_min

Re: [PATCH V2 07/20] nvdimm/namespace_label: Update namespace init_labels and its region_uuid

2025-08-19 Thread Ira Weiny
Neeraj Kumar wrote: > nd_mapping->labels maintains the list of labels present into LSA. > init_labels() prepares this list while adding new label into LSA > and updates nd_mapping->labels accordingly. During cxl region > creation nd_mapping->labels list and LSA was updated with one > region label.

Re: [PATCH v16] exec: Fix dead-lock in de_thread with ptrace_attach

2025-08-19 Thread Bernd Edlinger
Hi Kees, thanks for your response. On 8/19/25 06:36, Kees Cook wrote: > On Mon, Aug 18, 2025 at 10:53:43PM +0200, Bernd Edlinger wrote: >> This introduces signal->exec_bprm, which is used to >> fix the case when at least one of the sibling threads >> is traced, and therefore the trace process may

Re: [PATCH 2/3] remoteproc: qcom_q6v5: Avoid handling handover twice

2025-08-19 Thread Dmitry Baryshkov
On Tue, Aug 19, 2025 at 05:05:13PM +0200, Stephan Gerhold wrote: > On Tue, Aug 19, 2025 at 02:41:55PM +0300, Dmitry Baryshkov wrote: > > On Tue, Aug 19, 2025 at 01:08:03PM +0200, Stephan Gerhold wrote: > > > A remoteproc could theoretically signal handover twice. This is unexpected > > > > theoret

Re: [PATCH 1/3] remoteproc: qcom_q6v5: Avoid disabling handover IRQ twice

2025-08-19 Thread Dmitry Baryshkov
On Tue, Aug 19, 2025 at 04:55:09PM +0200, Stephan Gerhold wrote: > On Tue, Aug 19, 2025 at 02:44:26PM +0300, Dmitry Baryshkov wrote: > > On Tue, Aug 19, 2025 at 01:08:02PM +0200, Stephan Gerhold wrote: > > > enable_irq() and disable_irq() are reference counted, so we must make sure > > > that each

Re: [PATCH] selftests: riscv: Add README for RISC-V KSelfTest

2025-08-19 Thread Andrew Jones
On Fri, Aug 15, 2025 at 11:37:24PM +0530, Bala-Vignesh-Reddy wrote: > Add a README file for RISC-V specific kernel selftests under > tools/testing/selftests/riscv/. This mirrors the existing README > for arm64, providing clear guidance on how the tests are architecture > specific and skipped on non

Re: [PATCH V2 05/20] nvdimm/region_label: Add region label updation routine

2025-08-19 Thread Ira Weiny
RE Subject: [PATCH V2 05/20] nvdimm/region_label: Add region label updation routine ^^^ update Neeraj Kumar wrote: > Added __pmem_region_label_update region la

[PATCH] selftests/livepatch: Ignore NO_SUPPORT line in dmesg

2025-08-19 Thread Ricardo B . Marlière
#x27; | \ sed 's/^\[[ 0-9.]*\] //' | \ sed 's/^\[[ ]*[CT][0-9]*\] //') --- base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585 change-id: 20250819-selftests-lp_taint_flag-c96f5b9b2ed9 Best regards, -- Ricardo B. Marlière

Re: [PATCH 0/6] ONE_REG interface for SBI FWFT extension

2025-08-19 Thread Radim Krčmář
2025-08-19T21:22:27+05:30, Anup Patel : > On Tue, Aug 19, 2025 at 5:13 PM Radim Krčmář wrote: >> >> 2025-08-19T12:00:43+05:30, Anup Patel : >> > On Mon, Aug 18, 2025 at 3:59 PM Radim Krčmář >> > wrote: >> >> >> >> 2025-08-14T21:25:42+05:30, Anup Patel : >> >> > This series adds ONE_REG interface

Re: [PATCH v4] remoteproc: Use of_reserved_mem_region_* functions for "memory-region"

2025-08-19 Thread Rob Herring
On Thu, Aug 14, 2025 at 1:52 AM Dmitry Baryshkov wrote: > > On Wed, Aug 13, 2025 at 04:48:03PM -0500, Rob Herring (Arm) wrote: > > Use the newly added of_reserved_mem_region_to_resource() and > > of_reserved_mem_region_count() functions to handle "memory-region" > > properties. > > > > The error h

Re: [PATCH v2 01/11] firmware: qcom_scm: Introduce PAS context initialization helper

2025-08-19 Thread Pavan Kondeti
On Tue, Aug 19, 2025 at 10:24:36PM +0530, Mukesh Ojha wrote: > Currently, remoteproc and non-remoteproc subsystems use different > variants of the MDT loader helper API, primarily due to the handling of > the metadata context. Remoteproc subsystems retain this context until > authentication and res

[PATCH v2 10/11] remoteproc: qcom: pas: Enable Secure PAS support with IOMMU managed by Linux

2025-08-19 Thread Mukesh Ojha
Most Qualcomm platforms feature a proprietary hypervisor (such as Gunyah or QHEE), which typically handles IOMMU configuration. This includes mapping memory regions and device memory resources for remote processors by intercepting qcom_scm_pas_auth_and_reset() calls. These mappings are later remove

Re: [PATCH v5 3/5] selftests/mm: reimplement is_backed_by_thp() with more precise check

2025-08-19 Thread Zi Yan
On 19 Aug 2025, at 12:50, Zi Yan wrote: > On 19 Aug 2025, at 4:54, David Hildenbrand wrote: > >> On 18.08.25 20:46, Zi Yan wrote: >>> and rename it to is_backed_by_folio(). >>> >>> is_backed_by_folio() checks if the given vaddr is backed a folio with >>> a given order. It does so by: >>> 1. gettin

[PATCH v2 11/11] media: iris: Enable Secure PAS support with IOMMU managed by Linux

2025-08-19 Thread Mukesh Ojha
Most Qualcomm platforms feature a proprietary hypervisor (such as Gunyah or QHEE), which typically handles IOMMU configuration. This includes mapping memory regions and device memory resources for remote processors by intercepting qcom_scm_pas_auth_and_reset() calls. These mappings are later remove

[PATCH v2 08/11] soc: qcom: mdt_loader: Add helper functions to map and unmap resources

2025-08-19 Thread Mukesh Ojha
Most Qualcomm platforms feature a proprietary hypervisor (Gunyah, QHEE), which normally takes care of the IOMMU configuration for remote processors by intercepting qcom_scm_pas_auth_and_reset() calls. When the aforementioned hypervisor is absent, the OS must perform the configuration instead. To d

[PATCH v2 09/11] remoteproc: pas: Extend parse_fw callback to parse resource table

2025-08-19 Thread Mukesh Ojha
Extend parse_fw callback to include SMC call to get resource table from TrustZone to leverage resource table parse and mapping and unmapping code reuse from the framework. Signed-off-by: Mukesh Ojha --- drivers/remoteproc/qcom_q6v5_pas.c | 33 +++-- drivers/soc/qcom/mdt_

[PATCH v2 07/11] firmware: qcom_scm: Add qcom_scm_pas_get_rsc_table() to get resource table

2025-08-19 Thread Mukesh Ojha
Qualcomm remote processor may rely on both static and dynamic resources for its functionality. Static resources typically refer to memory-mapped addresses required by the subsystem and are often embedded within the firmware binary and dynamic resources, such as shared memory in DDR etc., are determ

[PATCH v2 06/11] remoteproc: Move resource table data structure to its own header

2025-08-19 Thread Mukesh Ojha
The resource table data structure has traditionally been associated with the remoteproc framework, where the resource table is included as a section within the remote processor firmware binary. However, it is also possible to obtain the resource table through other means—such as from a reserved mem

[PATCH v2 05/11] firmware: qcom_scm: Add shmbridge support to pas_init/release function

2025-08-19 Thread Mukesh Ojha
Qualcomm SoCs running with QHEE (Qualcomm Hypervisor Execution Environment—a library present in the Gunyah hypervisor) utilize the Peripheral Authentication Service (PAS) from Qualcomm TrustZone (TZ) also called QTEE(Qualcomm Trusted Execution Environment firmware) to securely authenticate and rese

[PATCH v2 04/11] firmware: qcom_scm: Simplify qcom_scm_pas_init_image()

2025-08-19 Thread Mukesh Ojha
Simplify qcom_scm_pas_init_image() by making the memory allocation, copy and free work in a separate function then the actual SMC call. Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom/qcom_scm.c | 59 ++-- 1 file changed, 34 insertions(+), 25 deletions(-) diff -

[PATCH v2 03/11] firmware: qcom_scm: Add a prep version of auth_and_reset function

2025-08-19 Thread Mukesh Ojha
Qualcomm SoCs running with QHEE (Qualcomm Hypervisor Execution Environment—a library present in the Gunyah hypervisor) utilize the Peripheral Authentication Service (PAS) from TrustZone (TZ) firmware to securely authenticate and reset remote processors via a sequence of SMC calls such as qcom_scm_p

[PATCH v2 02/11] soc: qcom: mdtloader: Add context aware qcom_mdt_pas_load() helper

2025-08-19 Thread Mukesh Ojha
Currently, remoteproc and non-remoteproc subsystems use different variants of the MDT loader helper API, primarily due to the handling of the metadata context. Remoteproc subsystems retain this context until authentication and reset, while non-remoteproc subsystems (e.g., video, graphics) do not re

[PATCH v2 00/11] Peripheral Image Loader support for Qualcomm SoCs running Linux host at EL2

2025-08-19 Thread Mukesh Ojha
This is a further continuation with a new approach to the topic discussed in [1] regarding the enablement of Secure Peripheral Image Loader support on Qualcomm SoCs when Linux runs at EL2. A few months ago, we also discussed the challenges at Linaro Connect 2025 [2] related to enabling remoteproc

[PATCH v2 01/11] firmware: qcom_scm: Introduce PAS context initialization helper

2025-08-19 Thread Mukesh Ojha
Currently, remoteproc and non-remoteproc subsystems use different variants of the MDT loader helper API, primarily due to the handling of the metadata context. Remoteproc subsystems retain this context until authentication and reset, while non-remoteproc subsystems (e.g., video, graphics) do not re

Re: [PATCH v5 3/5] selftests/mm: reimplement is_backed_by_thp() with more precise check

2025-08-19 Thread Zi Yan
On 19 Aug 2025, at 4:54, David Hildenbrand wrote: > On 18.08.25 20:46, Zi Yan wrote: >> and rename it to is_backed_by_folio(). >> >> is_backed_by_folio() checks if the given vaddr is backed a folio with >> a given order. It does so by: >> 1. getting the pfn of the vaddr; >> 2. checking kpageflags

[PATCH v19 8/8] selftests/clone3: Test shadow stack support

2025-08-19 Thread Mark Brown
Add basic test coverage for specifying the shadow stack for a newly created thread via clone3(), including coverage of the newly extended argument structure. We check that a user specified shadow stack can be provided, and that invalid combinations of parameters are rejected. In order to facilita

[PATCH v19 6/8] selftests/clone3: Factor more of main loop into test_clone3()

2025-08-19 Thread Mark Brown
In order to make it easier to add more configuration for the tests and more support for runtime detection of when tests can be run pass the structure describing the tests into test_clone3() rather than picking the arguments out of it and have that function do all the per-test work. No functional c

[PATCH v19 5/8] selftests/clone3: Remove redundant flushes of output streams

2025-08-19 Thread Mark Brown
Since there were widespread issues with output not being flushed the kselftest framework was modified to explicitly set the output streams unbuffered in commit 58e2847ad2e6 ("selftests: line buffer test program's stdout") so there is no need to explicitly flush in the clone3 tests. Reviewed-by: Ke

[PATCH v19 4/8] fork: Add shadow stack support to clone3()

2025-08-19 Thread Mark Brown
Unlike with the normal stack there is no API for configuring the shadow stack for a new thread, instead the kernel will dynamically allocate a new shadow stack with the same size as the normal stack. This appears to be due to the shadow stack series having been in development since before the more

[PATCH v19 7/8] selftests/clone3: Allow tests to flag if -E2BIG is a valid error code

2025-08-19 Thread Mark Brown
The clone_args structure is extensible, with the syscall passing in the length of the structure. Inside the kernel we use copy_struct_from_user() to read the struct but this has the unfortunate side effect of silently accepting some overrun in the structure size providing the extra data is all zero

[PATCH v19 1/8] arm64/gcs: Return a success value from gcs_alloc_thread_stack()

2025-08-19 Thread Mark Brown
Currently as a result of templating from x86 code gcs_alloc_thread_stack() returns a pointer as an unsigned int however on arm64 we don't actually use this pointer value as anything other than a pass/fail flag. Simplify the interface to just return an int with 0 on success and a negative error code

[PATCH v19 3/8] selftests: Provide helper header for shadow stack testing

2025-08-19 Thread Mark Brown
While almost all users of shadow stacks should be relying on the dynamic linker and libc to enable the feature there are several low level test programs where it is useful to enable without any libc support, allowing testing without full system enablement. This low level testing is helpful during b

[PATCH v19 2/8] Documentation: userspace-api: Add shadow stack API documentation

2025-08-19 Thread Mark Brown
There are a number of architectures with shadow stack features which we are presenting to userspace with as consistent an API as we can (though there are some architecture specifics). Especially given that there are some important considerations for userspace code interacting directly with the feat

[PATCH v19 0/8] fork: Support shadow stacks in clone3()

2025-08-19 Thread Mark Brown
[ I think at this point everyone is OK with the ABI, and the x86 implementation has been tested so hopefully we are near to being able to get this merged? If there are any outstanding issues let me know and I can look at addressing them. The one possible issue I am aware of is that the RI

Re: [PATCH V2 04/20] nvdimm/label: CXL labels skip the need for 'interleave-set cookie'

2025-08-19 Thread Ira Weiny
Neeraj Kumar wrote: > CXL LSA v2.1 utilizes the region labels stored in the LSA for interleave > set configuration instead of interleave-set cookie used in previous LSA > versions. As interleave-set cookie is not required for CXL LSA v2.1 format > so skip its usage for CXL LSA 2.1 format > > Signe

[PATCH v2] selftests/futex: fix typos and grammar in futex_priv_hash

2025-08-19 Thread Gopi Krishna Menon
Fix multiple typos and small grammar issues in help text, comments and test messages in futex_priv_hash test. Signed-off-by: Gopi Krishna Menon --- Changelog : Changes since v1: - Dropped hunk which is already addressed by https://lore.kernel.org/all/20250808112458.831212-1-colin.i.k...@g

Re: [PATCH V2 03/20] nvdimm/namespace_label: Add namespace label changes as per CXL LSA v2.1

2025-08-19 Thread Ira Weiny
Neeraj Kumar wrote: > CXL 3.2 Spec mentions CXL LSA 2.1 Namespace Labels at section 9.13.2.5 > Modified __pmem_label_update function using setter functions to update > namespace label as per CXL LSA 2.1 But why? And didn't we just remove nd_namespace_label in patch 2? Why are we now defining acc

Re: [PATCH 0/6] ONE_REG interface for SBI FWFT extension

2025-08-19 Thread Anup Patel
On Tue, Aug 19, 2025 at 5:13 PM Radim Krčmář wrote: > > 2025-08-19T12:00:43+05:30, Anup Patel : > > On Mon, Aug 18, 2025 at 3:59 PM Radim Krčmář > > wrote: > >> > >> 2025-08-14T21:25:42+05:30, Anup Patel : > >> > This series adds ONE_REG interface for SBI FWFT extension implemented > >> > by KVM

Re: [PATCH V2 02/20] nvdimm/label: Prep patch to accommodate cxl lsa 2.1 support

2025-08-19 Thread Ira Weiny
Neeraj Kumar wrote: > LSA 2.1 format introduces region label, which can also reside > into LSA along with only namespace label as per v1.1 and v1.2 > > As both namespace and region labels are of same size of 256 bytes. Soft-NAK Having 2 data structures of the same size is not a reason to combine

Re: [PATCH] nvdimm/pfn_dev: Remove redundant semicolons

2025-08-19 Thread Markus Elfring
> Remove unnecessary semicolons. You propose to omit only a single character behind a comment, don't you? Regards, Markus

Re: [PATCH 2/3] remoteproc: qcom_q6v5: Avoid handling handover twice

2025-08-19 Thread Stephan Gerhold
On Tue, Aug 19, 2025 at 02:41:55PM +0300, Dmitry Baryshkov wrote: > On Tue, Aug 19, 2025 at 01:08:03PM +0200, Stephan Gerhold wrote: > > A remoteproc could theoretically signal handover twice. This is unexpected > > theoretically or practically? > You could easily trigger handover again from a c

Re: [PATCH bpf-next v2 1/7] rcu: add rcu_read_lock_dont_migrate()

2025-08-19 Thread Paul E. McKenney
On Tue, Aug 19, 2025 at 05:34:18PM +0800, Menglong Dong wrote: > migrate_disable() is called to disable migration in the kernel, and it is > often used together with rcu_read_lock(). > > However, with PREEMPT_RCU disabled, it's unnecessary, as rcu_read_lock() > will always disable preemption, whic

Re: [PATCH 1/3] remoteproc: qcom_q6v5: Avoid disabling handover IRQ twice

2025-08-19 Thread Stephan Gerhold
On Tue, Aug 19, 2025 at 02:44:26PM +0300, Dmitry Baryshkov wrote: > On Tue, Aug 19, 2025 at 01:08:02PM +0200, Stephan Gerhold wrote: > > enable_irq() and disable_irq() are reference counted, so we must make sure > > that each enable_irq() is always paired with a single disable_irq(). If we > > call

Re: [syzbot] [x86?] BUG: soft lockup in xfrm_timer_handler

2025-08-19 Thread Dave Hansen
On 8/18/25 00:59, syzbot wrote: > Call Trace: > ... > spin_lock include/linux/spinlock.h:351 [inline] > __xfrm_state_delete+0xba/0xca0 net/xfrm/xfrm_state.c:818 > xfrm_timer_handler+0x18f/0xa00 net/xfrm/xfrm_state.c:716 > __run_hrtimer kernel/time/hrtimer.c:1761 [inline] > __hrtimer_run_queu

Re: next-20250818: rust: `ARCH_KMALLOC_MINALIGN` is defined multiple times

2025-08-19 Thread Miguel Ojeda
On Tue, Aug 19, 2025 at 10:40 AM Naresh Kamboju wrote: > > Build regressions were detected on multiple architectures (arm, arm64, > riscv) with the Linux next-20250818 tag when building with Rust-enabled > configurations (rust-gcc and rust-clang) from selftests/rust/config. > > Duplicate definitio

[PATCH] nvdimm/pfn_dev: Remove redundant semicolons

2025-08-19 Thread Liao Yuanhong
Remove unnecessary semicolons. Signed-off-by: Liao Yuanhong --- drivers/nvdimm/pfn_devs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c index 8f3e816e805d..d5798aba9ad9 100644 --- a/drivers/nvdimm/pfn_devs.c +++ b/driver

Re: [PATCH] vhost: Fix ioctl # for VHOST_[GS]ET_FORK_FROM_OWNER

2025-08-19 Thread Lei Yang
Tested this patch with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Tue, Aug 19, 2025 at 7:25 PM Michael S. Tsirkin wrote: > > On Mon, Aug 18, 2025 at 11:39:57PM -0700, Namhyung Kim wrote: > > The VHOST_[GS]ET_FEATURES_ARRAY ioctl already took 0x83 and it would >

[PATCH] proc: /proc filesystem check error message

2025-08-19 Thread Mallikarjun Thammanavar
Improve /proc filesystem check error message when filesystem type is unexpected Signed-off-by: Mallikarjun Thammanavar --- tools/testing/selftests/proc/read.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/proc/read.c b/tools/testing/selftests/proc/r

Re: [PATCH] selftests/futex: Fix some futex_numa_mpol subtests

2025-08-19 Thread André Almeida
Hi Waiman, Em 10/08/2025 19:27, Waiman Long escreveu: The "Memory out of range" subtest of futex_numa_mpol assumes that memory access outside of the mmap'ed area is invalid. That may not be the case depending on the actual memory layout of the test application. When that subtest was run on an x8

[PATCH] params: Replace __modinit with __init_or_module

2025-08-19 Thread Petr Pavlu
Remove the custom __modinit macro from kernel/params.c and instead use the common __init_or_module macro from include/linux/module.h. Both provide the same functionality. Signed-off-by: Petr Pavlu --- kernel/params.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --

[PATCH] module: Remove unused __INIT*_OR_MODULE macros

2025-08-19 Thread Petr Pavlu
Remove the __INIT_OR_MODULE, __INITDATA_OR_MODULE and __INITRODATA_OR_MODULE macros. These were introduced in commit 8b5a10fc6fd0 ("x86: properly annotate alternatives.c"). Only __INITRODATA_OR_MODULE was ever used, in arch/x86/kernel/alternative.c. In 2011, commit dc326fca2b64 ("x86, cpu: Clean up

Re: [PATCH 3/3] remoteproc: qcom_q6v5_pas: Shutdown lite ADSP DTB on X1E

2025-08-19 Thread Dmitry Baryshkov
On Tue, Aug 19, 2025 at 01:08:04PM +0200, Stephan Gerhold wrote: > The ADSP firmware on X1E has separate firmware binaries for the main > firmware and the DTB. The same applies for the "lite" firmware loaded by > the boot firmware. > > When preparing to load the new ADSP firmware we shutdown the l

Re: [PATCH 0/6] ONE_REG interface for SBI FWFT extension

2025-08-19 Thread Radim Krčmář
2025-08-19T12:00:43+05:30, Anup Patel : > On Mon, Aug 18, 2025 at 3:59 PM Radim Krčmář wrote: >> >> 2025-08-14T21:25:42+05:30, Anup Patel : >> > This series adds ONE_REG interface for SBI FWFT extension implemented >> > by KVM RISC-V. >> >> I think it would be better to ONE_REG the CSRs (medeleg/m

Re: [PATCH 1/3] remoteproc: qcom_q6v5: Avoid disabling handover IRQ twice

2025-08-19 Thread Dmitry Baryshkov
On Tue, Aug 19, 2025 at 01:08:02PM +0200, Stephan Gerhold wrote: > enable_irq() and disable_irq() are reference counted, so we must make sure > that each enable_irq() is always paired with a single disable_irq(). If we > call disable_irq() twice followed by just a single enable_irq(), the IRQ > wil

Re: [PATCH 0/2] Fix vsock error-handling regression introduced in v6.17-rc1

2025-08-19 Thread Stefan Hajnoczi
On Mon, Aug 18, 2025 at 07:03:53PM +0100, Will Deacon wrote: > Hi all, > > Here are a couple of patches fixing the vsock error-handling regression > found by syzbot [1] that I introduced during the recent merge window. > > Cheers, > > Will > > [1] https://lore.kernel.org/all/689a3d92.050a0220.7

Re: [PATCH 2/3] remoteproc: qcom_q6v5: Avoid handling handover twice

2025-08-19 Thread Dmitry Baryshkov
On Tue, Aug 19, 2025 at 01:08:03PM +0200, Stephan Gerhold wrote: > A remoteproc could theoretically signal handover twice. This is unexpected theoretically or practically? > and would break the reference counting for the handover resources (power > domains, clocks, regulators, etc), so add a chec

Re: [PATCH] vhost: Fix ioctl # for VHOST_[GS]ET_FORK_FROM_OWNER

2025-08-19 Thread Michael S. Tsirkin
On Mon, Aug 18, 2025 at 11:39:57PM -0700, Namhyung Kim wrote: > The VHOST_[GS]ET_FEATURES_ARRAY ioctl already took 0x83 and it would > result in a build error when the vhost uapi header is used for perf tool > build like below. > > In file included from trace/beauty/ioctl.c:93: > tools/perf/tr

Re: [PATCH 0/2] Fix vsock error-handling regression introduced in v6.17-rc1

2025-08-19 Thread Michael S. Tsirkin
On Mon, Aug 18, 2025 at 07:03:53PM +0100, Will Deacon wrote: > Hi all, > > Here are a couple of patches fixing the vsock error-handling regression > found by syzbot [1] that I introduced during the recent merge window. > > Cheers, > > Will > > [1] https://lore.kernel.org/all/689a3d92.050a0220.7

[PATCH 2/3] remoteproc: qcom_q6v5: Avoid handling handover twice

2025-08-19 Thread Stephan Gerhold
A remoteproc could theoretically signal handover twice. This is unexpected and would break the reference counting for the handover resources (power domains, clocks, regulators, etc), so add a check to prevent that from happening. Signed-off-by: Stephan Gerhold --- drivers/remoteproc/qcom_q6v5.c

[PATCH 1/3] remoteproc: qcom_q6v5: Avoid disabling handover IRQ twice

2025-08-19 Thread Stephan Gerhold
enable_irq() and disable_irq() are reference counted, so we must make sure that each enable_irq() is always paired with a single disable_irq(). If we call disable_irq() twice followed by just a single enable_irq(), the IRQ will remain disabled forever. For the error handling path in qcom_q6v5_wait

[PATCH 0/3] remoteproc: qcom_q6v5: Misc fixes to prepare for reusing the "lite" ADSP FW

2025-08-19 Thread Stephan Gerhold
On X1E, the boot firmware already loads a "lite" ADSP firmware that provides essential functionality such as charging, battery status and USB-C detection. Only the audio functionality is missing. Since the full ADSP firmware is device-specific and needs to be manually copied by the user, it would b

[PATCH 3/3] remoteproc: qcom_q6v5_pas: Shutdown lite ADSP DTB on X1E

2025-08-19 Thread Stephan Gerhold
The ADSP firmware on X1E has separate firmware binaries for the main firmware and the DTB. The same applies for the "lite" firmware loaded by the boot firmware. When preparing to load the new ADSP firmware we shutdown the lite_pas_id for the main firmware, but we don't shutdown the corresponding l

Re: [PATCH RFC 3/5] pmdomain: marvell: Add PXA1908 power domains

2025-08-19 Thread Ulf Hansson
On Wed, 6 Aug 2025 at 19:35, Duje Mihanović wrote: > > Marvell's PXA1908 SoC has a few power domains for its VPU, GPU, image > processor and DSI PHY. Add a driver to control these. > > Signed-off-by: Duje Mihanović FYI, overall this looks okay to me, but I will review your next version more in d

Re:Re: [PATCH v7 2/2] selftests/bpf: Force -O2 for USDT selftests to cover SIB handling logic

2025-08-19 Thread 赵佳炜
> libbpf/usdt can reject that if 'ti' is a static variable. But how can we do that? It seems we cannot determine whether a variable is static during the preprocessing phase. At 2025-08-19 01:35:04, "Yonghong Song" wrote: > > >On 8/17/25 6:43 AM, 赵佳炜 wrote: >> >> >> >> >> >> >> Hi, Yon

[PATCH bpf-next v2 1/7] rcu: add rcu_read_lock_dont_migrate()

2025-08-19 Thread Menglong Dong
migrate_disable() is called to disable migration in the kernel, and it is often used together with rcu_read_lock(). However, with PREEMPT_RCU disabled, it's unnecessary, as rcu_read_lock() will always disable preemption, which will also disable migration. Introduce rcu_read_lock_dont_migrate() an

[PATCH bpf-next v2 3/7] bpf: use rcu_read_lock_dont_migrate() for bpf_inode_storage_free()

2025-08-19 Thread Menglong Dong
Use rcu_read_lock_dont_migrate() and rcu_read_unlock_migrate() in bpf_inode_storage_free to obtain better performance when PREEMPT_RCU is not enabled. Signed-off-by: Menglong Dong --- v2: - use rcu_read_lock_dont_migrate() instead of rcu_migrate_disable() --- kernel/bpf/bpf_inode_storage.c | 6 +

[PATCH bpf-next v2 2/7] bpf: use rcu_read_lock_dont_migrate() for bpf_cgrp_storage_free()

2025-08-19 Thread Menglong Dong
Use rcu_read_lock_dont_migrate() and rcu_read_unlock_migrate() in bpf_cgrp_storage_free to obtain better performance when PREEMPT_RCU is not enabled. Signed-off-by: Menglong Dong --- v2: - use rcu_read_lock_dont_migrate() instead of rcu_migrate_disable() --- kernel/bpf/bpf_cgrp_storage.c | 6 ++-

[PATCH bpf-next v2 5/7] bpf: use rcu_read_lock_dont_migrate() for bpf_task_storage_free()

2025-08-19 Thread Menglong Dong
Use rcu_read_lock_dont_migrate() and rcu_read_unlock_migrate() in bpf_task_storage_free to obtain better performance when PREEMPT_RCU is not enabled. Signed-off-by: Menglong Dong --- v2: - use rcu_read_lock_dont_migrate() instead of rcu_migrate_disable() --- kernel/bpf/bpf_task_storage.c | 6 ++-

[PATCH bpf-next v2 7/7] bpf: use rcu_read_lock_dont_migrate() for trampoline.c

2025-08-19 Thread Menglong Dong
Use rcu_read_lock_dont_migrate() and rcu_read_unlock_migrate() in trampoline.c to obtain better performance when PREEMPT_RCU is not enabled. Signed-off-by: Menglong Dong --- v2: - use rcu_read_lock_dont_migrate() instead of rcu_migrate_disable() --- kernel/bpf/trampoline.c | 18 ++---

[PATCH bpf-next v2 6/7] bpf: use rcu_read_lock_dont_migrate() for bpf_prog_run_array_cg()

2025-08-19 Thread Menglong Dong
Use rcu_read_lock_dont_migrate() and rcu_read_unlock_migrate() in bpf_prog_run_array_cg to obtain better performance when PREEMPT_RCU is not enabled. Signed-off-by: Menglong Dong --- v2: - use rcu_read_lock_dont_migrate() instead of rcu_migrate_disable() --- kernel/bpf/cgroup.c | 6 ++ 1 fil

[PATCH bpf-next v2 4/7] bpf: use rcu_read_lock_dont_migrate() for bpf_iter_run_prog()

2025-08-19 Thread Menglong Dong
Use rcu_read_lock_dont_migrate() and rcu_read_unlock_migrate() in bpf_iter_run_prog to obtain better performance when PREEMPT_RCU is not enabled. Signed-off-by: Menglong Dong --- v2: - use rcu_read_lock_dont_migrate() instead of rcu_migrate_disable() --- kernel/bpf/bpf_iter.c | 6 ++ 1 file

[PATCH bpf-next v2 0/7] bpf: introduce and use rcu_read_lock_dont_migrate

2025-08-19 Thread Menglong Dong
migrate_disable() and rcu_read_lock() are used to together in many case in bpf. However, when PREEMPT_RCU is not enabled, rcu_read_lock() will disable preemption, which indicate migrate_disable(), so we don't need to call it in this case. In this series, we introduce rcu_read_lock_dont_migrate and

Re: [PATCH 2/6] RISC-V: KVM: Introduce feature specific reset for SBI FWFT

2025-08-19 Thread Nutty.Liu
On 8/14/2025 11:55 PM, Anup Patel wrote: The SBI FWFT feature values must be reset upon VCPU reset so introduce feature specific reset callback for this purpose. Signed-off-by: Anup Patel --- arch/riscv/kvm/vcpu_sbi_fwft.c | 30 -- 1 file changed, 28 insertions(

Re: [PATCH 1/6] RISC-V: KVM: Set initial value of hedeleg in kvm_arch_vcpu_create()

2025-08-19 Thread Nutty.Liu
On 8/14/2025 11:55 PM, Anup Patel wrote: The hedeleg may be updated by ONE_REG interface before the VCPU is run at least once hence set the initial value of hedeleg in kvm_arch_vcpu_create() instead of kvm_riscv_vcpu_setup_config(). Signed-off-by: Anup Patel --- arch/riscv/kvm/vcpu.c | 3 ++

Re: [PATCH v5 3/5] selftests/mm: reimplement is_backed_by_thp() with more precise check

2025-08-19 Thread David Hildenbrand
On 18.08.25 20:46, Zi Yan wrote: and rename it to is_backed_by_folio(). is_backed_by_folio() checks if the given vaddr is backed a folio with a given order. It does so by: 1. getting the pfn of the vaddr; 2. checking kpageflags of the pfn; if order is greater than 0: 3. checking kpageflags of t

next-20250818: rust: `ARCH_KMALLOC_MINALIGN` is defined multiple times

2025-08-19 Thread Naresh Kamboju
failures across affected toolchains. First seen on next-20250818 Good: next-20250815 Bad: next-20250818 and next-20250819 Regression Analysis: - New regression? yes - Reproducibility? yes * arm, build - rustclang-lkftconfig-kselftest - rustgcc-lkftconfig-kselftest * arm64, build - rustclang

Re: [PATCH] selftests/futex: fix typos and grammar in futex_priv_hash

2025-08-19 Thread Sebastian Andrzej Siewior
On 2025-08-15 15:09:39 [+0530], Gopi Krishna Menon wrote: > --- a/tools/testing/selftests/futex/functional/futex_priv_hash.c > +++ b/tools/testing/selftests/futex/functional/futex_priv_hash.c > @@ -115,7 +115,7 @@ static void usage(char *prog) > { > printf("Usage: %s\n", prog); > print

Re: [PATCH v4 4/7] mm/selftests: Fix split_huge_page_test failure on systems with 64KB page size

2025-08-19 Thread Aboorva Devarajan
On Sat, 2025-08-16 at 14:31 +, Wei Yang wrote: > On Sat, Aug 16, 2025 at 09:31:10AM +0530, Aboorva Devarajan wrote: > > From: Donet Tom > > > > The split_huge_page_test fails on systems with a 64KB base page > > size. > > This is because the order of a 2MB huge page is different: > > > > On

Re: [PATCH] kselftest/futex : fixed typo errors

2025-08-19 Thread Sebastian Andrzej Siewior
On 2025-08-15 21:21:47 [+0530], hariconsci...@gmail.com wrote: > From: HariKrishna > > fixed typo errors in kselftest of futex module > > Signed-off-by: HariKrishna Addressed by https://lore.kernel.org/all/20250815093942.8595-1-krishnagopi...@gmail.com/ Sebastian

Re: [PATCH][next] selftests/futex: Fix help test for option -g

2025-08-19 Thread Sebastian Andrzej Siewior
On 2025-08-08 12:24:58 [+0100], Colin Ian King wrote: > Currently the help text for the -g option contains a spelling > mistake, a space before a \n and is a little hard to comprehend. > Fix it. > > Fixes: cda95faef7bc ("selftests/futex: Add futex_priv_hash") > Signed-off-by: Colin Ian King Revi

Re: [Fixup PATCH] mm/selftests: Fix formattig in split_huge_page_test

2025-08-19 Thread Aboorva Devarajan
On Tue, 2025-08-19 at 09:28 +0200, David Hildenbrand wrote: > On 19.08.25 09:25, David Hildenbrand wrote: > > On 19.08.25 06:12, Aboorva Devarajan wrote: > > > Removed an extra space in split_huge_page_test that was introduced > > > by commit 4b76e221794b ("mm/selftests: fix split_huge_page_test >

[PATCH 2/2] kunit: Only output a test plan if we're using kunit_array_gen_params

2025-08-19 Thread David Gow
In 6a2a027e254b ("kunit: Enable direct registration of parameter arrays to a KUnit test"), we now output a test plan for parameterised tests which use parameter arrays. This uses the size of the array (via the ARRAY_SIZE macro) to determine the number of subtests, which otherwise was indeterminate

  1   2   >