[PATCH net-next, v4] selftest: Add selftest for multicast address notifications

2025-06-13 Thread Yuyang Huang
This commit adds a new kernel selftest to verify RTNLGRP_IPV4_MCADDR and RTNLGRP_IPV6_MCADDR notifications. The test works by adding and removing a dummy interface and then confirming that the system correctly receives join and removal notifications for the 224.0.0.1 and ff02::1 multicast addresses

Re: [PATCH net-next, v3] selftest: Add selftest for multicast address notifications

2025-06-13 Thread Yuyang Huang
Thanks for the suggestion. >Perhaps move these to lib.sh as a separate commit? >They seem generic. I am looking at the existing test cases, and it seems that each case is doing its own way of handling the end_test()/run_cmd(). It's non-trivial to unify everything into lib.sh, and it seems to be a

Re: [PATCH v3 RESEND] selftests: filesystems: Add functional test for the abort file in fusectl

2025-06-13 Thread Chen Linxuan
On Thu, Jun 12, 2025 at 4:56 PM Miklos Szeredi wrote: > > On Tue, 10 Jun 2025 at 04:10, Chen Linxuan wrote: > > > > This patch add a simple functional test for the "abort" file > > in fusectlfs (/sys/fs/fuse/connections/ID/about). > > > > A simple fuse daemon is added for testing. > > > > Related

Re: [PATCH v17 2/6] remoteproc: Add TEE support

2025-06-13 Thread kernel test robot
Hi Arnaud, kernel test robot noticed the following build warnings: [auto build test WARNING on 19272b37aa4f83ca52bdf9c16d5d81bdd1354494] url: https://github.com/intel-lab-lkp/linux/commits/Arnaud-Pouliquen/remoteproc-core-Introduce-rproc_pa_to_va-helper/20250613-172251 base

[PATCH v2] gendwarfksyms: Fix structure type overrides

2025-06-13 Thread Sami Tolvanen
As we always iterate through the entire die_map when expanding type strings, recursively processing referenced types in type_expand_child() is not actually necessary. Furthermore, the type_string kABI rule added in commit c9083467f7b9 ("gendwarfksyms: Add a kABI rule to override type strings") can

Re: [PATCH] gendwarfksyms: Fix structure type overrides

2025-06-13 Thread Sami Tolvanen
Hi Petr, On Fri, Jun 13, 2025 at 12:52 PM Petr Pavlu wrote: > > Nit: This code was the only user of __cache_was_expanded() and > __cache_mark_expanded(). It is now possible to merge > __cache_was_expanded() into cache_was_expanded() and > __cache_mark_expanded() into cache_mark_expanded(). Nice

Re: [PATCH net-next RFC] selftests: net: add netpoll basic functionality test

2025-06-13 Thread Jakub Kicinski
On Fri, 13 Jun 2025 05:47:50 -0700 Breno Leitao wrote: > > Or is there another way that the packets could be observed, e.g., > > counters. > > Unfortunately netpoll doesn't expose any data, thus, it is hard to get > it. > > I have plans to create a configfs for netpoll, so, we can check for >

Re: [PATCH net-next, v3] selftest: Add selftest for multicast address notifications

2025-06-13 Thread Jakub Kicinski
On Thu, 12 Jun 2025 11:05:14 +0900 Yuyang Huang wrote: > +VERBOSE=0 > +PAUSE=no > +PAUSE_ON_FAIL=no > + > +source lib.sh > + > +# set global exit status, but never reset nonzero one. > +check_err() > +{ > + if [ $ret -eq 0 ]; then > + ret=$1 > + fi > + [ -n "$2" ] && echo "$

[PATCH net-next v3] page_pool: import Jesper's page_pool benchmark

2025-06-13 Thread Mina Almasry
From: Jesper Dangaard Brouer We frequently consult with Jesper's out-of-tree page_pool benchmark to evaluate page_pool changes. Import the benchmark into the upstream linux kernel tree so that (a) we're all running the same version, (b) pave the way for shared improvements, and (c) maybe one day

[PATCH 1/2] vhost: vringh: Remove unused iotlb functions

2025-06-13 Thread linux
From: "Dr. David Alan Gilbert" The functions: vringh_abandon_iotlb() vringh_notify_disable_iotlb() and vringh_notify_enable_iotlb() were added in 2020 by commit 9ad9c49cfe97 ("vringh: IOTLB support") but have remained unused. Remove them. Signed-off-by: Dr. David Alan Gilbert --- drive

[PATCH 2/2] vhost: vringh: Remove unused functions

2025-06-13 Thread linux
From: "Dr. David Alan Gilbert" The functions: vringh_abandon_kern() vringh_abandon_user() vringh_iov_pull_kern() and vringh_iov_push_kern() were all added in 2013 by commit f87d0fbb5798 ("vringh: host-side implementation of virtio rings.") but have remained unused. Remove them. Signed-o

[PATCH 0/2] vringh small unused functions

2025-06-13 Thread linux
From: "Dr. David Alan Gilbert" Hi, The following pair of patches remove a bunch of small functions that have been unused for a long time. Dave Dr. David Alan Gilbert (2): vhost: vringh: Remove unused iotlb functions vhost: vringh: Remove unused functions drivers/vhost/vringh.c | 104 ---

Re: [PATCH bpf 2/7] bpf/x86: prevent trampoline attachment when args location on stack is uncertain

2025-06-13 Thread Alexei Starovoitov
On Fri, Jun 13, 2025 at 1:59 AM Alexis Lothoré wrote: > > On Fri Jun 13, 2025 at 10:32 AM CEST, Peter Zijlstra wrote: > > On Fri, Jun 13, 2025 at 10:26:37AM +0200, Alexis Lothoré wrote: > >> Hi Peter, > >> > >> On Fri Jun 13, 2025 at 10:11 AM CEST, Peter Zijlstra wrote: > >> > On Fri, Jun 13, 2025

Re: [PATCH v4 7/7] mm/maps: execute PROCMAP_QUERY ioctl under per-vma locks

2025-06-13 Thread Andrii Nakryiko
On Wed, Jun 4, 2025 at 4:12 PM Suren Baghdasaryan wrote: > > Utilize per-vma locks to stabilize vma after lookup without taking > mmap_lock during PROCMAP_QUERY ioctl execution. While we might take > mmap_lock for reading during contention, we do that momentarily only > to lock the vma. > This cha

[PATCH net-next v4 6/6] Revert "bnxt_en: bring back rtnl_lock() in the bnxt_open() path"

2025-06-13 Thread Stanislav Fomichev
This reverts commit 325eb217e41fa14f307c7cc702bd18d0bb38fe84. udp_tunnel infra doesn't need RTNL, should be safe to get back to only netdev instance lock. Cc: Michael Chan Reviewed-by: Aleksandr Loktionov Signed-off-by: Stanislav Fomichev --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 36 +++

[PATCH net-next v4 5/6] netdevsim: remove udp_ports_sleep

2025-06-13 Thread Stanislav Fomichev
Now that there is only one path in udp_tunnel, there is no need to have udp_ports_sleep knob. Remove it and adjust the test. Cc: Michael Chan Reviewed-by: Aleksandr Loktionov Signed-off-by: Stanislav Fomichev --- drivers/net/netdevsim/netdevsim.h | 2 -- drivers/net/netdevsim/udp_

[PATCH net-next v4 4/6] net: remove redundant ASSERT_RTNL() in queue setup functions

2025-06-13 Thread Stanislav Fomichev
The existing netdev_ops_assert_locked() already asserts that either the RTNL lock or the per-device lock is held, making the explicit ASSERT_RTNL() redundant. Cc: Michael Chan Signed-off-by: Stanislav Fomichev --- net/core/dev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/core/dev.

[PATCH net-next v4 3/6] udp_tunnel: remove rtnl_lock dependency

2025-06-13 Thread Stanislav Fomichev
Drivers that are using ops lock and don't depend on RTNL lock still need to manage it because udp_tunnel's RTNL dependency. Introduce new udp_tunnel_nic_lock and use it instead of rtnl_lock. Drop non-UDP_TUNNEL_NIC_INFO_MAY_SLEEP mode from udp_tunnel infra (udp_tunnel_nic_device_sync_work needs to

[PATCH net-next v4 2/6] vxlan: drop sock_lock

2025-06-13 Thread Stanislav Fomichev
We won't be able to sleep soon in vxlan_offload_rx_ports and won't be able to grab sock_lock. Instead of having separate spinlock to manage sockets, rely on rtnl lock. This is similar to how geneve manages its sockets. Signed-off-by: Stanislav Fomichev --- drivers/net/vxlan/vxlan_core.c | 3

[PATCH net-next v4 1/6] geneve: rely on rtnl lock in geneve_offload_rx_ports

2025-06-13 Thread Stanislav Fomichev
udp_tunnel_push_rx_port will grab mutex in the next patch so we can't use rcu. geneve_offload_rx_ports is called from geneve_netdevice_event for NETDEV_UDP_TUNNEL_PUSH_INFO and NETDEV_UDP_TUNNEL_DROP_INFO which both have ASSERT_RTNL. Entries are added to and removed from the sock_list under rtnl lo

[PATCH net-next v4 0/6] udp_tunnel: remove rtnl_lock dependency

2025-06-13 Thread Stanislav Fomichev
Recently bnxt had to grow back a bunch of rtnl dependencies because of udp_tunnel's infra. Add separate (global) mutext to protect udp_tunnel state. v4: - grab lock in more places, specifically netlink and notifiers (Jakub) - convert geneve and vxlan notifiers to (sleepable) rtnl lock v3: - fix 2

Re: [PATCH] virtio_fs: Remove redundant spinlock in virtio_fs_request_complete()

2025-06-13 Thread kernel test robot
Hi lirongqing, kernel test robot noticed the following build warnings: [auto build test WARNING on mszeredi-fuse/for-next] [also build test WARNING on linus/master v6.16-rc1 next-20250613] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v4 0/7] use per-vma locks for /proc/pid/maps reads and PROCMAP_QUERY

2025-06-13 Thread Lorenzo Stoakes
On Fri, Jun 13, 2025 at 12:11:43PM -0700, Suren Baghdasaryan wrote: > On Fri, Jun 13, 2025 at 8:01 AM Lorenzo Stoakes > wrote: > > > > Hi Suren, > > > > I promised I'd share VMA merging scenarios so we can be absolutely sure we > > have > > all cases covered, I share that below. I also included i

[PATCH v7 30/30] KVM: selftests: TDX: Test LOG_DIRTY_PAGES flag to a non-GUEST_MEMFD memslot

2025-06-13 Thread Sagi Shahar
From: Yan Zhao Add a selftest to verify that adding flag KVM_MEM_LOG_DIRTY_PAGES to a !KVM_MEM_GUEST_MEMFD memslot does not produce host errors in TDX. Signed-off-by: Yan Zhao Signed-off-by: Sagi Shahar --- tools/testing/selftests/kvm/x86/tdx_vm_test.c | 45 ++- 1 file changed

[PATCH v7 28/30] KVM: selftests: TDX: Add TDX UPM selftest

2025-06-13 Thread Sagi Shahar
From: Ackerley Tng This tests the use of guest memory with explicit TDG.VP.VMCALL calls. Provide a 2MB memory region to the TDX guest with a 40KB focus area at offset 1MB intended to be shared between host and guest. The entire 2MB region starts out as private with the guest filling it with a pa

[PATCH v7 29/30] KVM: selftests: TDX: Add TDX UPM selftests for implicit conversion

2025-06-13 Thread Sagi Shahar
From: Ackerley Tng This tests the use of guest memory without explicit TDG.VP.VMCALL calls. Provide a 2MB memory region to the TDX guest with a 40KB focus area at offset 1MB intended to be shared between host and guest. The guest does not request memory to be shared or private using TDG.VP.VMCAL

[PATCH v7 27/30] KVM: selftests: TDX: Add support for TDG.VP.VEINFO.GET

2025-06-13 Thread Sagi Shahar
From: Ackerley Tng Support TDG.VP.VEINFO.GET that the guest uses to obtain the virtualization exception information of the recent #VE exception. Signed-off-by: Ackerley Tng Signed-off-by: Sagi Shahar --- .../selftests/kvm/include/x86/tdx/tdx.h | 21 +++ tools/testing/sel

[PATCH v7 26/30] KVM: selftests: TDX: Add support for TDG.MEM.PAGE.ACCEPT

2025-06-13 Thread Sagi Shahar
From: Ackerley Tng Add support for TDG.MEM.PAGE.ACCEPT that the guest uses to accept a pending private page, previously added by TDH.MEM.PAGE.AUG or after conversion using the KVM_SET_MEMORY_ATTRIBUTES ioctl(). Signed-off-by: Ackerley Tng Signed-off-by: Sagi Shahar --- tools/testing/selftests

[PATCH v7 25/30] KVM: selftests: KVM: selftests: Expose new vm_vaddr_alloc_private()

2025-06-13 Thread Sagi Shahar
From: Ackerley Tng vm_vaddr_alloc_private allow specifying both the virtual and physical addresses for the allocation. Signed-off-by: Ackerley Tng Signed-off-by: Sagi Shahar --- tools/testing/selftests/kvm/include/kvm_util.h | 3 +++ tools/testing/selftests/kvm/lib/kvm_util.c | 7 +++

[PATCH v7 24/30] KVM: selftests: TDX: Add shared memory test

2025-06-13 Thread Sagi Shahar
From: Ryan Afranji Test that host and guest can exchange data via shared memory. Set up shared memory by first allocating as private and then mapping the same GPA as shared. The guest starts with a request to map a page of memory to shared. This request is done via a hypercall (TDG.VP.VMCALL) fr

[PATCH v7 23/30] KVM: selftests: Add functions to allow mapping as shared

2025-06-13 Thread Sagi Shahar
From: Ackerley Tng virt_map() enforces a private mapping for private memory. Introduce virt_map_shared() that creates a shared mapping for private as well as shared memory. This way, the TD does not have to remap its page tables at runtime. Signed-off-by: Ackerley Tng Signed-off-by: Sagi Shahar

[PATCH v7 22/30] KVM: selftests: TDX: Add TDG.VP.INFO test

2025-06-13 Thread Sagi Shahar
From: Roger Wang Adds a test for TDG.VP.INFO. Introduce __tdx_module_call() that does needed shuffling from function parameters to registers used by the TDCALL instruction that is used by the guest to communicate with the TDX module. The first function parameter is the leaf number indicating whi

[PATCH v7 21/30] KVM: selftests: TDX: Verify the behavior when host consumes a TD private memory

2025-06-13 Thread Sagi Shahar
From: Ryan Afranji The test checks that host can only read fixed values when trying to access the guest's private memory. Signed-off-by: Ryan Afranji Signed-off-by: Sagi Shahar --- tools/testing/selftests/kvm/x86/tdx_vm_test.c | 83 ++- 1 file changed, 82 insertions(+), 1 dele

[PATCH v7 19/30] KVM: selftests: TDX: Add TDX MMIO writes test

2025-06-13 Thread Sagi Shahar
The test verifies MMIO writes of various sizes from the guest to the host. Co-developed-by: Isaku Yamahata Signed-off-by: Isaku Yamahata Signed-off-by: Sagi Shahar --- .../selftests/kvm/include/x86/tdx/tdx.h | 2 + tools/testing/selftests/kvm/lib/x86/tdx/tdx.c | 14 +++ tools/testing/se

[PATCH v7 20/30] KVM: selftests: TDX: Add TDX CPUID TDVMCALL test

2025-06-13 Thread Sagi Shahar
This test issues a CPUID TDVMCALL from inside the guest to get the CPUID values as seen by KVM. Co-developed-by: Isaku Yamahata Signed-off-by: Isaku Yamahata Signed-off-by: Sagi Shahar --- .../selftests/kvm/include/x86/tdx/tdx.h | 4 + tools/testing/selftests/kvm/lib/x86/tdx/tdx.c | 25

[PATCH v7 18/30] KVM: selftests: TDX: Add TDX MMIO reads test

2025-06-13 Thread Sagi Shahar
The test verifies MMIO reads of various sizes from the host to the guest. Co-developed-by: Isaku Yamahata Signed-off-by: Isaku Yamahata Signed-off-by: Sagi Shahar --- .../selftests/kvm/include/x86/tdx/tdx.h | 4 + .../selftests/kvm/include/x86/tdx/tdx_util.h | 1 + .../selftests/kvm/i

[PATCH v7 16/30] KVM: selftests: TDX: Add TDX MSR read/write tests

2025-06-13 Thread Sagi Shahar
The test verifies reads and writes for MSR registers with different access level. Signed-off-by: Sagi Shahar --- .../selftests/kvm/include/x86/tdx/tdx.h | 4 + tools/testing/selftests/kvm/lib/x86/tdx/tdx.c | 27 +++ tools/testing/selftests/kvm/x86/tdx_vm_test.c | 193 +-

[PATCH v7 17/30] KVM: selftests: TDX: Add TDX HLT exit test

2025-06-13 Thread Sagi Shahar
From: Erdem Aktas The test verifies that the guest runs TDVMCALL and the guest vCPU enters to the halted state. Co-developed-by: Sagi Shahar Signed-off-by: Sagi Shahar Signed-off-by: Erdem Aktas Signed-off-by: Sagi Shahar --- .../selftests/kvm/include/x86/tdx/tdx.h | 2 + tools/testi

[PATCH v7 14/30] KVM: selftests: TDX: Add TDX IO writes test

2025-06-13 Thread Sagi Shahar
The test verifies IO writes of various sizes from the guest to the host. Signed-off-by: Sagi Shahar --- .../selftests/kvm/include/x86/tdx/tdcall.h| 3 + tools/testing/selftests/kvm/x86/tdx_vm_test.c | 79 ++- 2 files changed, 81 insertions(+), 1 deletion(-) diff --git a/too

[PATCH v7 15/30] KVM: selftests: TDX: Add TDX IO reads test

2025-06-13 Thread Sagi Shahar
The test verifies IO reads of various sizes from the host to the guest. Signed-off-by: Sagi Shahar --- tools/testing/selftests/kvm/x86/tdx_vm_test.c | 76 ++- 1 file changed, 75 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/x86/tdx_vm_test.c b/tools/test

[PATCH v7 13/30] KVM: selftests: TDX: Add basic TDG.VP.VMCALL test

2025-06-13 Thread Sagi Shahar
The test calls TDG.VP.VMCALL hypercall from the guest and verifies the expected returned values. TDG.VP.VMCALL hypercall is a subleaf of TDG.VP.VMCALL to enumerate which TDG.VP.VMCALL sub leaves are supported. This hypercall is for future enhancement of the Guest-Host-Communication Interface (GHC

[PATCH v7 12/30] KVM: selftests: TDX: Add basic TDX CPUID test

2025-06-13 Thread Sagi Shahar
The test reads CPUID values from inside a TD VM and compare them to expected values. The test targets CPUID values which are virtualized as "As Configured", "As Configured (if Native)", "Calculated", "Fixed" and "Native" according to the TDX spec. Co-developed-by: Isaku Yamahata Signed-off-by: I

[PATCH v7 11/30] KVM: selftests: TDX: Adding test case for TDX port IO

2025-06-13 Thread Sagi Shahar
Verifies TDVMCALL READ and WRITE operations. Signed-off-by: Sagi Shahar --- .../selftests/kvm/include/x86/tdx/test_util.h | 20 + .../selftests/kvm/lib/x86/tdx/test_util.c | 35 + tools/testing/selftests/kvm/x86/tdx_vm_test.c | 78 ++- 3 files changed, 130 inserti

[PATCH v7 10/30] KVM: selftests: TDX: Add report_fatal_error test

2025-06-13 Thread Sagi Shahar
The test checks report_fatal_error functionality. TD guest can use TDG.VP.VMCALL to report the fatal error it has experienced. TD guest is requesting a termination with the error information that include 16 general-purpose registers. Co-developed-by: Binbin Wu Signed-off-by: Binbin Wu Signed-of

[PATCH v7 09/30] KVM: selftests: TDX: Add TDX lifecycle test

2025-06-13 Thread Sagi Shahar
From: Erdem Aktas Adding a test to verify TDX lifecycle by creating a TD and running a dummy TDG.VP.VMCALL inside it. Co-developed-by: Sagi Shahar Signed-off-by: Sagi Shahar Co-developed-by: Ackerley Tng Signed-off-by: Ackerley Tng Co-developed-by: Reinette Chatre Signed-off-by: Reinette C

[PATCH v7 06/30] KVM: selftests: Add helper functions to create TDX VMs

2025-06-13 Thread Sagi Shahar
From: Erdem Aktas TDX requires additional IOCTLs to initialize VM and vCPUs to add private memory and to finalize the VM memory. Also additional utility functions are provided to manipulate a TD, similar to those that manipulate a VM in the current selftest framework. A TD's initial register sta

[PATCH v7 08/30] KVM: selftests: TDX: Update load_td_memory_region() for VM memory backed by guest memfd

2025-06-13 Thread Sagi Shahar
From: Ackerley Tng If guest memory is backed by restricted memfd + UPM is being used, hence encrypted memory region has to be registered + Can avoid making a copy of guest memory before getting TDX to initialize the memory region Signed-off-by: Ackerley Tng Signed-off-by: Sagi Shahar ---

[PATCH v7 07/30] KVM: selftests: TDX: Use KVM_TDX_CAPABILITIES to validate TDs' attribute configuration

2025-06-13 Thread Sagi Shahar
From: Ackerley Tng This also exercises the KVM_TDX_CAPABILITIES ioctl. Suggested-by: Isaku Yamahata Co-developed-by: Isaku Yamahata Signed-off-by: Isaku Yamahata Signed-off-by: Ackerley Tng Signed-off-by: Sagi Shahar --- .../selftests/kvm/lib/x86/tdx/tdx_util.c| 17

[PATCH v7 05/30] KVM: selftests: Update kvm_init_vm_address_properties() for TDX

2025-06-13 Thread Sagi Shahar
From: Isaku Yamahata Let kvm_init_vm_address_properties() initialize vm->arch.{s_bit, tag_mask} similar to SEV. Set shared bit position based on guest maximum physical address width instead of maximum physical address width, because that is what KVM uses, refer to setup_tdparams_eptp_controls(),

[PATCH v7 04/30] KVM: selftests: Add vCPU descriptor table initialization utility

2025-06-13 Thread Sagi Shahar
From: Ackerley Tng Turn vCPU descriptor table initialization into a utility for use by tests needing finer control, for example for TDX TD creation. Signed-off-by: Ackerley Tng Signed-off-by: Sagi Shahar --- tools/testing/selftests/kvm/include/x86/processor.h | 1 + tools/testing/selftests/kv

[PATCH v7 02/30] KVM: selftests: Expose function that sets up sregs based on VM's mode

2025-06-13 Thread Sagi Shahar
From: Ackerley Tng This allows initializing sregs without setting vCPU registers in KVM. No functional change intended. Signed-off-by: Ackerley Tng Signed-off-by: Sagi Shahar --- .../selftests/kvm/include/x86/processor.h | 1 + .../testing/selftests/kvm/lib/x86/processor.c | 45

[PATCH v7 03/30] KVM: selftests: Store initial stack address in struct kvm_vcpu

2025-06-13 Thread Sagi Shahar
From: Ackerley Tng TDX guests' registers cannot be initialized directly using vcpu_regs_set(), hence the stack pointer needs to be initialized by the guest itself, running boot code beginning at the reset vector. Store the stack address as part of struct kvm_vcpu so that it can be accessible lat

[PATCH v7 01/30] KVM: selftests: Add function to allow one-to-one GVA to GPA mappings

2025-06-13 Thread Sagi Shahar
From: Ackerley Tng One-to-one GVA to GPA mappings can be used in the guest to set up boot sequences during which paging is enabled, hence requiring a transition from using physical to virtual addresses in consecutive instructions. Signed-off-by: Ackerley Tng Signed-off-by: Sagi Shahar --- ...

[PATCH v7 00/30] TDX KVM selftests

2025-06-13 Thread Sagi Shahar
This is v7 of the TDX selftests now that the base TDX patches have been accepted. This series is based on v6.16-rc1 No major changes from v6 asside from rebasing. Thanks, Changes from v6: - Rebased on top of v6.16-rc1 Ackerley Tng (12): KVM: selftests: Add function to allow one-to-one GVA to

Re: [PATCH v4 0/7] use per-vma locks for /proc/pid/maps reads and PROCMAP_QUERY

2025-06-13 Thread Suren Baghdasaryan
On Fri, Jun 13, 2025 at 8:01 AM Lorenzo Stoakes wrote: > > Hi Suren, > > I promised I'd share VMA merging scenarios so we can be absolutely sure we > have > all cases covered, I share that below. I also included information on split. Thanks Lorenzo! This is great and very helpful. > > Hopefully

Re: Virtio interrupt remapping

2025-06-13 Thread Demi Marie Obenour
On 6/13/25 14:13, Jean-Philippe Brucker wrote: > Hi, > > On Fri, Jun 13, 2025 at 01:08:07PM -0400, Demi Marie Obenour wrote: >> I’m working on virtio-IOMMU interrupt remapping for Spectrum OS [1], >> and am running into a problem. All of the current interrupt remapping >> drivers use __init code

Re: Virtio interrupt remapping

2025-06-13 Thread Jean-Philippe Brucker
Hi, On Fri, Jun 13, 2025 at 01:08:07PM -0400, Demi Marie Obenour wrote: > I’m working on virtio-IOMMU interrupt remapping for Spectrum OS [1], > and am running into a problem. All of the current interrupt remapping > drivers use __init code during initialization, and I’m not sure how to > plumb t

Re: [PATCH v2] remoteproc: xlnx: allow single core use in split mode

2025-06-13 Thread Tanmay Shah
On 6/13/25 12:18 PM, Mathieu Poirier wrote: Good day, On Tue, Jun 10, 2025 at 12:27:38PM -0700, Tanmay Shah wrote: It's a valid use case to have only one core enabled in cluster in split mode. Remove exact core count expecatation from the driver. I suggest: "When operating in split mode,

Re: [PATCH v2] remoteproc: xlnx: allow single core use in split mode

2025-06-13 Thread Mathieu Poirier
Good day, On Tue, Jun 10, 2025 at 12:27:38PM -0700, Tanmay Shah wrote: > It's a valid use case to have only one core enabled in cluster in split > mode. Remove exact core count expecatation from the driver. I suggest: "When operating in split mode, it is a valid usecase to have only one core ena

Virtio interrupt remapping

2025-06-13 Thread Demi Marie Obenour
I’m working on virtio-IOMMU interrupt remapping for Spectrum OS [1], and am running into a problem. All of the current interrupt remapping drivers use __init code during initialization, and I’m not sure how to plumb the struct virtio_device * into the IOMMU initialization code. What is the proper

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-13 Thread Vladimir Zapolskiy
On 6/13/25 12:33, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [RFC PATCH 1/1] nvdimm: allow exposing RAM carveouts as NVDIMM DIMM devices

2025-06-13 Thread Mike Rapoport
On Thu, Jun 12, 2025 at 02:12:42PM -0700, jane@oracle.com wrote: > > On 6/12/2025 1:31 AM, Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" > > > > There are use cases, for example virtual machine hosts, that create > > "persistent" memory regions using memmap= option on x86 or dum

Re: [PATCH v3 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()

2025-06-13 Thread David Hildenbrand
On 13.06.25 16:00, Lorenzo Stoakes wrote: On Fri, Jun 13, 2025 at 03:53:58PM +0200, David Hildenbrand wrote: On 13.06.25 15:49, Oscar Salvador wrote: On Fri, Jun 13, 2025 at 11:27:01AM +0200, David Hildenbrand wrote: Marking PMDs that map a "normal" refcounted folios as special is against our

Re: [PATCH net] virtio-net: drop the multi-buffer XDP packet in zerocopy

2025-06-13 Thread Bui Quang Minh
On 6/11/25 03:37, Jakub Kicinski wrote: On Tue, 10 Jun 2025 22:18:32 +0700 Bui Quang Minh wrote: Furthermore, we are in the zerocopy so we cannot linearize by allocating a large enough buffer to cover the whole frame then copy the frame data to it. That's not zerocopy anymore. Also, XDP socket z

Re: [PATCH net-next v3 2/3] vsock/test: Introduce get_transports()

2025-06-13 Thread Luigi Leonardi
Hi Michal, On Wed, Jun 11, 2025 at 09:56:51PM +0200, Michal Luczaj wrote: Return a bitmap of registered vsock transports. As guesstimated by grepping /proc/kallsyms (CONFIG_KALLSYMS=y) for known symbols of type `struct vsock_transport`, or `struct virtio_transport` in case the vsock_transport

Re: [PATCH net-next v2 4/4] netdevsim: account dropped packet length in stats on queue free

2025-06-13 Thread Breno Leitao
On Fri, Jun 13, 2025 at 07:55:07AM -0700, Jakub Kicinski wrote: > On Fri, 13 Jun 2025 07:47:11 -0700 Breno Leitao wrote: > > > static void nsim_queue_free(struct nsim_rq *rq) > > > { > > > + struct net_device *dev = rq->napi.dev; > > > + > > > hrtimer_cancel(&rq->napi_timer); > > > + dev_dstats

Re: [PATCH v4 0/7] use per-vma locks for /proc/pid/maps reads and PROCMAP_QUERY

2025-06-13 Thread Lorenzo Stoakes
Hi Suren, I promised I'd share VMA merging scenarios so we can be absolutely sure we have all cases covered, I share that below. I also included information on split. Hopefully this is useful! And maybe we can somehow put in a comment or commit msg or something somewhere? Not sure if a bit much f

Re: [PATCH net-next v3 1/3] vsock/test: Introduce vsock_bind_try() helper

2025-06-13 Thread Luigi Leonardi
On Wed, Jun 11, 2025 at 09:56:50PM +0200, Michal Luczaj wrote: Create a socket and bind() it. If binding failed, gracefully return an error code while preserving `errno`. Base vsock_bind() on top of it. Suggested-by: Stefano Garzarella Reviewed-by: Stefano Garzarella Signed-off-by: Michal Luc

Re: [PATCH net-next v2 4/4] netdevsim: account dropped packet length in stats on queue free

2025-06-13 Thread Jakub Kicinski
On Fri, 13 Jun 2025 07:47:11 -0700 Breno Leitao wrote: > > static void nsim_queue_free(struct nsim_rq *rq) > > { > > + struct net_device *dev = rq->napi.dev; > > + > > hrtimer_cancel(&rq->napi_timer); > > + dev_dstats_rx_dropped_add(dev, rq->skb_queue.qlen); > > This is wrong and it wi

Re: [PATCH net-next v2 4/4] netdevsim: account dropped packet length in stats on queue free

2025-06-13 Thread Breno Leitao
On Fri, Jun 13, 2025 at 03:40:01AM -0700, Breno Leitao wrote: > Add a call to dev_dstats_rx_dropped_add() in nsim_queue_free() to > account for the number of packets dropped when purging the skb queue. > > This improves the accuracy of RX drop statistics reported by > netdevsim. > > Suggested-by:

Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Correct the interrupt number

2025-06-13 Thread Dmitry Baryshkov
On Thu, Jun 12, 2025 at 10:39:32AM +0800, Lijuan Gao wrote: > Correct the interrupt number of ready and handover in the DTS example. > > Fixes: af5da7b0944c ("dt-bindings: remoteproc: qcom,sa8775p-pas: Document the > SA8775p ADSP, CDSP and GPDSP") > Signed-off-by: Lijuan Gao > --- > Documentati

Re: [PATCH net-next RFC] selftests: net: add netpoll basic functionality test

2025-06-13 Thread Breno Leitao
On Fri, Jun 13, 2025 at 09:43:35AM -0400, Willem de Bruijn wrote: > Breno Leitao wrote: > > > > +def check_traffic_flowing(cfg: NetDrvEpEnv, netdevnl: NetdevFamily) -> > > > > int: > > > > +"""Check if traffic is flowing on the interface""" > > > > +stat1 = get_stats(cfg, netdevnl) > > >

Re: [PATCH v3 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()

2025-06-13 Thread Lorenzo Stoakes
On Fri, Jun 13, 2025 at 03:53:58PM +0200, David Hildenbrand wrote: > On 13.06.25 15:49, Oscar Salvador wrote: > > On Fri, Jun 13, 2025 at 11:27:01AM +0200, David Hildenbrand wrote: > > > Marking PMDs that map a "normal" refcounted folios as special is > > > against our rules documented for vm_norma

Re: [PATCH v3 3/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pud()

2025-06-13 Thread Oscar Salvador
On Fri, Jun 13, 2025 at 11:27:02AM +0200, David Hildenbrand wrote: > Marking PUDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(). normal (refcounted) > folios shall never have the page table mapping marked as special. > > Fortunately, there

Re: [PATCH v3 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()

2025-06-13 Thread David Hildenbrand
On 13.06.25 15:49, Oscar Salvador wrote: On Fri, Jun 13, 2025 at 11:27:01AM +0200, David Hildenbrand wrote: Marking PMDs that map a "normal" refcounted folios as special is against our rules documented for vm_normal_page(): normal (refcounted) folios shall never have the page table mapping marke

Re: [PATCH v3 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()

2025-06-13 Thread Oscar Salvador
On Fri, Jun 13, 2025 at 03:49:46PM +0200, Oscar Salvador wrote: > Reviewed-by: Oscar salvador Fat-fingers on a Friday afternoon: Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs

Re: [PATCH v3 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()

2025-06-13 Thread Oscar Salvador
On Fri, Jun 13, 2025 at 11:27:01AM +0200, David Hildenbrand wrote: > Marking PMDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(): normal (refcounted) > folios shall never have the page table mapping marked as special. > > Fortunately, there

Re: [PATCH net-next RFC] selftests: net: add netpoll basic functionality test

2025-06-13 Thread Willem de Bruijn
Breno Leitao wrote: > Hello Willem, > > On Thu, Jun 12, 2025 at 10:35:54PM -0400, Willem de Bruijn wrote: > > Breno Leitao wrote: > > > Add a basic selftest for the netpoll polling mechanism, specifically > > > targeting the netpoll poll() side. > > > > > > The test creates a scenario where netwo

Re: [PATCH v3 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()

2025-06-13 Thread Oscar Salvador
On Fri, Jun 13, 2025 at 11:27:00AM +0200, David Hildenbrand wrote: > We setup the cache mode but ... don't forward the updated pgprot to > insert_pfn_pud(). > > Only a problem on x86-64 PAT when mapping PFNs using PUDs that > require a special cachemode. > > Fix it by using the proper pgprot wher

Re: [PATCH net-next RFC] selftests: net: add netpoll basic functionality test

2025-06-13 Thread Breno Leitao
Hello Willem, On Thu, Jun 12, 2025 at 10:35:54PM -0400, Willem de Bruijn wrote: > Breno Leitao wrote: > > Add a basic selftest for the netpoll polling mechanism, specifically > > targeting the netpoll poll() side. > > > > The test creates a scenario where network transmission is running at > > ma

Re: [PATCH] gendwarfksyms: Fix structure type overrides

2025-06-13 Thread Petr Pavlu
On 6/9/25 5:49 PM, Sami Tolvanen wrote: > As we always iterate through the entire die_map when expanding > type strings, recursively processing referenced types in > type_expand_child() is not actually necessary. Furthermore, > the type_string kABI rule added in commit c9083467f7b9 > ("gendwarfksym

[PATCH] selftest/mm: Skip if fallocate() is unsupported in gup_longterm

2025-06-13 Thread Mark Brown
Currently gup_longterm assumes that filesystems support fallocate() and uses that to allocate space in files, however this is an optional feature and is in particular not implemented by NFSv3 which is commonly used in CI systems leading to spurious failures. Check for lack of support and report a s

[PATCH net-next v3 8/8] selftests: net: add netconsole test for cmdline configuration

2025-06-13 Thread Breno Leitao
Add a new selftest to verify netconsole module loading with command line arguments. This test exercises the init_netconsole() path and validates proper parsing of the netconsole= parameter format. The test: - Loads netconsole module with cmdline configuration instead of dynamic reconfiguration -

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-13 Thread Bryan O'Donoghue
On 13/06/2025 10:33, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht Add bindings for qcom,msm8939-camss in order to support the camera subsystem for MSM8939. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Vincent Knecht --- .../bindings/media/qcom,msm8939-camss.yaml | 254

[PATCH net-next v3 7/8] selftests: net: Refactor cleanup logic in lib_netcons.sh

2025-06-13 Thread Breno Leitao
Extract the network device and namespace cleanup logic from the cleanup() function into a new do_cleanup() helper in lib_netcons.sh. The do_cleanup() function only unconfigure the network and printk, while cleanup() cleans the netconsole targets plus the network and printk. This refactoring let t

[PATCH net-next v3 6/8] netconsole: improve code style in parser function

2025-06-13 Thread Breno Leitao
Split assignment from conditional checks and use preferred null pointer check style (!delim instead of == NULL) in netconsole_parser_cmdline(). This improves code readability and follows kernel coding style conventions. Signed-off-by: Breno Leitao --- drivers/net/netconsole.c | 15 ++

[PATCH net-next v3 5/8] netconsole: rename functions to better reflect their purpose

2025-06-13 Thread Breno Leitao
Rename netpoll_parse_options() to netconsole_parser_cmdline() and netpoll_print_options() to netconsole_print_banner() to better describe what these functions actually do within the netconsole context. Also fix minor code style issues including variable declaration ordering and spacing. These fun

[PATCH net-next v3 4/8] netpoll: move netpoll_print_options to netconsole

2025-06-13 Thread Breno Leitao
Move netpoll_print_options() from net/core/netpoll.c to drivers/net/netconsole.c and make it static. This function is only used by netconsole, so there's no need to export it or keep it in the public netpoll API. This reduces the netpoll API surface and improves code locality by keeping netconsole

[PATCH net-next v3 3/8] netpoll: relocate netconsole-specific functions to netconsole module

2025-06-13 Thread Breno Leitao
Move netpoll_parse_ip_addr() and netpoll_parse_options() from the generic netpoll module to the netconsole module where they are actually used. These functions were originally placed in netpoll but are only consumed by netconsole. This refactoring improves code organization by: - Removing unnece

[PATCH net-next v3 2/8] netpoll: expose netpoll logging macros in public header

2025-06-13 Thread Breno Leitao
Move np_info(), np_err(), and np_notice() macros from internal implementation to the public netpoll header file to make them available for use by netpoll consumers. These logging macros provide consistent formatting for netpoll-related messages by automatically prefixing log output with the netpol

[PATCH net-next v3 1/8] netpoll: remove __netpoll_cleanup from exported API

2025-06-13 Thread Breno Leitao
Since commit 97714695ef90 ("net: netconsole: Defer netpoll cleanup to avoid lock release during list traversal"), netconsole no longer uses __netpoll_cleanup(). With no remaining users, remove this function from the exported netpoll API. The function remains available internally within netpoll for

[PATCH net-next v3 0/8] netpoll: Untangle netconsole and netpoll

2025-06-13 Thread Breno Leitao
Initially netpoll and netconsole were created together, and some functions are in the wrong file. Seperate netconsole-only functions in netconsole, avoiding exports. 1. Expose netpoll logging macros in the public header to enable consistent log formatting across netpoll consumers. 2. Relocate

Re: [PATCH net-next v2 7/7] selftest: netconsole: add test for cmdline configuration

2025-06-13 Thread Breno Leitao
On Thu, Jun 12, 2025 at 03:05:42PM -0700, Jakub Kicinski wrote: > On Wed, 11 Jun 2025 07:18:56 -0700 Breno Leitao wrote: > > Add a new selftest to verify netconsole module loading with command > > line arguments. This test exercises the init_netconsole() path and > > validates proper parsing of the

[PATCH net-next v2 4/4] netdevsim: account dropped packet length in stats on queue free

2025-06-13 Thread Breno Leitao
Add a call to dev_dstats_rx_dropped_add() in nsim_queue_free() to account for the number of packets dropped when purging the skb queue. This improves the accuracy of RX drop statistics reported by netdevsim. Suggested-by: Jakub Kicinski Signed-off-by: Breno Leitao --- drivers/net/netdevsim/net

[PATCH net-next v2 3/4] net: add dev_dstats_rx_dropped_add() helper

2025-06-13 Thread Breno Leitao
Introduce the dev_dstats_rx_dropped_add() helper to allow incrementing the rx_drops per-CPU statistic by an arbitrary value, rather than just one. This is useful for drivers or code paths that need to account for multiple dropped packets at once, such as when dropping entire queues. Signed-off-by:

[PATCH net-next v2 2/4] netdevsim: collect statistics at RX side

2025-06-13 Thread Breno Leitao
When the RX side of netdevsim was added, the RX statistics were missing, making the driver unusable for GenerateTraffic() test framework. This patch adds proper statistics tracking on RX side, complementing the TX path. Signed-off-by: Breno Leitao --- drivers/net/netdevsim/netdev.c | 12 +++

[PATCH net-next v2 1/4] netdevsim: migrate to dstats stats collection

2025-06-13 Thread Breno Leitao
Replace custom statistics tracking with the kernel's dstats infrastructure to simplify code and improve consistency with other network drivers. This change: - Sets dev->pcpu_stat_type = NETDEV_PCPU_STAT_DSTATS for automatic automatic allocation and deallocation. - Removes manual stats fields and

[PATCH net-next v2 0/4] netdevsim: implement RX statistics using NETDEV_PCPU_STAT_DSTATS

2025-06-13 Thread Breno Leitao
The netdevsim driver previously lacked RX statistics support, which prevented its use with the GenerateTraffic() test framework, as this framework verifies traffic flow by checking RX byte counts. This patch migrates netdevsim from its custom statistics collection to the NETDEV_PCPU_STAT_DSTATS fr

[PATCH v5 4/4] arm64: dts: qcom: msm8939: Add camss and cci

2025-06-13 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Add the camera subsystem and CCI used to interface with cameras on the Snapdragon 615. Reviewed-by: Konrad Dybcio Signed-off-by: Vincent Knecht --- arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi | 4 + arch/arm64/boot/dts/qcom/msm8939.dtsi| 146 +++

[PATCH v5 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-06-13 Thread Vincent Knecht via B4 Relay
From: Vincent Knecht Some devices need writing values to VFE VBIF registers. Add helper functions to do this. Reviewed-by: Bryan O'Donoghue Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/Makefile | 1 + drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 12

  1   2   >