Re: [PATCH v4 04/38] perf: Add a EVENT_GUEST flag

2025-05-18 Thread Namhyung Kim
Hello, On Mon, Mar 24, 2025 at 05:30:44PM +, Mingwei Zhang wrote: > From: Kan Liang > > Current perf doesn't explicitly schedule out all exclude_guest events > while the guest is running. There is no problem with the current > emulated vPMU. Because perf owns all the PMU counters. It can mas

Re: [PATCH net-next v1 1/9] net: devmem: move list_add to net_devmem_bind_dmabuf.

2025-05-18 Thread Taehee Yoo
On Mon, May 19, 2025 at 11:35 AM Mina Almasry wrote: > > It's annoying for the list_add to be outside net_devmem_bind_dmabuf, but > the list_del is in net_devmem_unbind_dmabuf. Make it consistent by > having both the list_add/del be inside the net_devmem_[un]bind_dmabuf. > > Cc: ap420...@gmail.com

Re: [PATCH] selftests: Add functional test for the abort file in fusectl

2025-05-18 Thread Amir Goldstein
On Mon, May 19, 2025 at 7:58 AM Chen Linxuan wrote: > > On Thu, May 15, 2025 at 6:27 PM Amir Goldstein wrote: > > > > On Thu, May 15, 2025 at 9:35 AM Chen Linxuan > > wrote: > > > > > > + ret = read(test_fd, path_buf, sizeof(path_buf)); > > > + ASSERT_LT(ret, 0); > > > > Nice! > > I

Re: [PATCH] selftests: Add functional test for the abort file in fusectl

2025-05-18 Thread Chen Linxuan
On Thu, May 15, 2025 at 6:27 PM Amir Goldstein wrote: > > On Thu, May 15, 2025 at 9:35 AM Chen Linxuan > wrote: > > > > + ret = read(test_fd, path_buf, sizeof(path_buf)); > > + ASSERT_LT(ret, 0); > > Nice! > I guess you could also verify errno == ENOTCONN or whatever it is > in this

Re: [PATCH v5] remoteproc: Add device awake calls in rproc boot and shutdown path

2025-05-18 Thread Souradeep Chowdhury
Gentle Reminder On 5/14/2025 1:03 PM, Souradeep Chowdhury wrote: Gentle Reminder On 4/8/2025 4:13 PM, Souradeep Chowdhury wrote: Add device awake calls in case of rproc boot and rproc shutdown path. Currently, device awake call is only present in the recovery path of remoteproc. If an user s

Re: [PATCH v4 32/38] KVM: nVMX: Add nested virtualization support for mediated PMU

2025-05-18 Thread Mi, Dapeng
On 5/16/2025 9:33 PM, Sean Christopherson wrote: > This shortlog is unnecessarily confusing. It reads as if supported for > running > L2 in a vCPU with a mediated PMU is somehow lacking. > > On Mon, Mar 24, 2025, Mingwei Zhang wrote: >> Add nested virtualization support for mediated PMU by comb

Re: [PATCH v4 24/38] KVM: x86/pmu: Exclude PMU MSRs in vmx_get_passthrough_msr_slot()

2025-05-18 Thread Mi, Dapeng
On 5/16/2025 10:45 PM, Sean Christopherson wrote: > On Fri, May 16, 2025, Sean Christopherson wrote: >> On Mon, Mar 24, 2025, Mingwei Zhang wrote: >>> Reject PMU MSRs interception explicitly in >>> vmx_get_passthrough_msr_slot() since interception of PMU MSRs are >>> specially handled in intel_pa

Re: [PATCH v4 23/38] KVM: x86/pmu: Configure the interception of PMU MSRs

2025-05-18 Thread Mi, Dapeng
On 5/16/2025 9:34 PM, Sean Christopherson wrote: > On Mon, Mar 24, 2025, Mingwei Zhang wrote: >> +static void amd_pmu_update_msr_intercepts(struct kvm_vcpu *vcpu) >> +{ >> +struct kvm_pmu *pmu = vcpu_to_pmu(vcpu); >> +struct vcpu_svm *svm = to_svm(vcpu); >> +int msr_clear = !!(kvm_med

Re: [PATCH v4 29/38] KVM: x86/pmu: Switch host/guest PMU context at vm-exit/vm-entry

2025-05-18 Thread Mi, Dapeng
On 5/16/2025 9:26 PM, Sean Christopherson wrote: > On Mon, Mar 24, 2025, Mingwei Zhang wrote: >> +/* >> + * Clear hardware selector MSR content and its counter to avoid >> + * leakage and also avoid this guest GP counter get accidentally >> + * enabled during host running when hos

Re: [PATCH v3 5/6] arm64: dts: qcom: qcs615: add ADSP and CDSP nodes

2025-05-18 Thread Lijuan Gao
在 5/18/2025 12:59 AM, Konrad Dybcio 写道: On 5/17/25 12:11 AM, Dmitry Baryshkov wrote: On Fri, May 16, 2025 at 11:27:06AM +0800, Lijuan Gao wrote: Add nodes for remoteprocs: ADSP and CDSP for QCS615 SoC to enable proper remoteproc functionality. Reviewed-by: Konrad Dybcio Signed-off-by: Liju

Re: [PATCH v4 27/38] KVM: x86/pmu: Handle PMU MSRs interception and event filtering

2025-05-18 Thread Mi, Dapeng
On 5/17/2025 4:54 AM, Sean Christopherson wrote: > On Fri, May 16, 2025, Dapeng Mi wrote: >> On 3/25/2025 1:31 AM, Mingwei Zhang wrote: >>> + if (kvm_mediated_pmu_enabled(pmu_to_vcpu(pmu))) { >>> + bool allowed = check_pmu_event_filter(pmc); >>> + >>> + if (pmc_is_gp(pmc)) {

[PATCH net-next v1 9/9] net: devmem: ncdevmem: remove unused variable

2025-05-18 Thread Mina Almasry
This variable is unused and can be removed. Signed-off-by: Mina Almasry --- tools/testing/selftests/drivers/net/hw/ncdevmem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/drivers/net/hw/ncdevmem.c b/tools/testing/selftests/drivers/net/hw/ncdevmem.c index ca723722a8

[PATCH net-next v1 0/9] Devmem TCP minor cleanups and ksft improvements

2025-05-18 Thread Mina Almasry
Minor cleanups to the devmem tcp code, and not-so-minor improvements to the ksft. For the cleanups: - Address comment from Paolo post-merge. - Fix whitespace. - Add improvement dropped from Taehee's fix patch. For the ksft: - Add support for ipv4 environment. - Add support for drivers that are li

[PATCH net-next v1 6/9] net: devmem: ksft: add exit_wait to make rx test pass

2025-05-18 Thread Mina Almasry
This exit_wait seems necessary to make the rx side test pass for me. I think this is just missed from the original test add patch. Add it now. Signed-off-by: Mina Almasry --- tools/testing/selftests/drivers/net/hw/devmem.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/too

[PATCH net-next v1 7/9] net: devmem: ksft: add 5 tuple FS support

2025-05-18 Thread Mina Almasry
ncdevmem supports drivers that are limited to either 3-tuple or 5-tuple FS support, but the ksft is currently 3-tuple only. Support drivers that have 5-tuple FS supported by adding a ksft arg. Signed-off-by: Mina Almasry --- .../testing/selftests/drivers/net/hw/devmem.py | 17 +++--

[PATCH net-next v1 1/9] net: devmem: move list_add to net_devmem_bind_dmabuf.

2025-05-18 Thread Mina Almasry
It's annoying for the list_add to be outside net_devmem_bind_dmabuf, but the list_del is in net_devmem_unbind_dmabuf. Make it consistent by having both the list_add/del be inside the net_devmem_[un]bind_dmabuf. Cc: ap420...@gmail.com Signed-off-by: Mina Almasry --- net/core/devmem.c | 5 ++

[PATCH net-next v1 8/9] net: devmem: ksft: upgrade rx test to send 1K data

2025-05-18 Thread Mina Almasry
The current test just sends "hello\nworld" and verifies that is the string received on the RX side. That is fine, but improve the test a bit by sending 1K data. The test should be improved further to send more data, but for now this should be a welcome improvement. The test will send a repeating p

[PATCH net-next v1 5/9] net: devmem: ksft: add ipv4 support

2025-05-18 Thread Mina Almasry
ncdevmem supports both ipv4 and ipv6, but the ksft is currently ipv6-only. Propagate the ipv4 support to the ksft, so that folks that are limited to these networks can also test. Signed-off-by: Mina Almasry --- .../selftests/drivers/net/hw/devmem.py| 33 --- 1 file chang

[PATCH net-next v1 3/9] net: devmem: preserve sockc_err

2025-05-18 Thread Mina Almasry
Preserve the error code returned by sock_cmsg_send and return that on err. Signed-off-by: Mina Almasry --- net/ipv4/tcp.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index b7b6ab41b496..45abe5772157 100644 --- a/n

[PATCH net-next v1 4/9] net: devmem: ksft: remove ksft_disruptive

2025-05-18 Thread Mina Almasry
As far as I can tell the ksft_disruptive here is unnecessary. These tests are largerly independent, and when one test fails, it's nice to know the results from all the other test cases. Signed-off-by: Mina Almasry --- tools/testing/selftests/drivers/net/hw/devmem.py | 3 --- 1 file changed, 3 d

[PATCH net-next v1 2/9] page_pool: fix ugly page_pool formatting

2025-05-18 Thread Mina Almasry
Minor cleanup; this line is badly formatted. Signed-off-by: Mina Almasry --- net/core/page_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/page_pool.c b/net/core/page_pool.c index 974f3eef2efa..4011eb305cee 100644 --- a/net/core/page_pool.c +++ b/net/core

Re: [PATCH net-next v2] vhost/net: Defer TX queue re-enable until after sendmsg

2025-05-18 Thread Jon Kohler
> On May 18, 2025, at 5:38 PM, Michael S. Tsirkin wrote: > > !---| > CAUTION: External Email > > |---! > > On Sat, Apr 19, 2025 at 06:05:18PM -0700, Jon Kohler wrot

Re: [PATCH net-next v2] vhost/net: Defer TX queue re-enable until after sendmsg

2025-05-18 Thread Michael S. Tsirkin
On Sat, Apr 19, 2025 at 06:05:18PM -0700, Jon Kohler wrote: > In handle_tx_copy, TX batching processes packets below ~PAGE_SIZE and > batches up to 64 messages before calling sock->sendmsg. > > Currently, when there are no more messages on the ring to dequeue, > handle_tx_copy re-enables kicks on

Re: [PATCH 00/19] virtio_ring in order support

2025-05-18 Thread Michael S. Tsirkin
On Wed, Mar 26, 2025 at 07:39:47AM +0100, Eugenio Perez Martin wrote: > On Mon, Mar 24, 2025 at 3:44 PM Lei Yang wrote: > > > > QE tested this series of patches with virtio-net regression tests, > > everything works fine. > > > > Hi Lei, > > Is it possible to test this series also with virtio-ne

Re: [PATCH v2 0/8] irqbypass: Cleanups and a perf improvement

2025-05-18 Thread Michael S. Tsirkin
On Fri, May 16, 2025 at 04:07:26PM -0700, Sean Christopherson wrote: > The two primary goals of this series are to make the irqbypass concept > easier to understand, and to address the terrible performance that can > result from using a list to track connections. > > For the first goal, track the

[PATCH] selftests/filesystems: Fix build of anon_inode_test

2025-05-18 Thread Mark Brown
The anon_inode_test test fails to build due to attempting to include a nonexisting overlayfs/wrapper.h: anon_inode_test.c:10:10: fatal error: overlayfs/wrappers.h: No such file or directory 10 | #include "overlayfs/wrappers.h" | ^~ This is due to 0bd92b9fe53

[PATCH] selftests/mm: Deduplicate second mmap() of 5*PAGE_SIZE at base

2025-05-18 Thread Mark Brown
The map_fixed_noreplace test does two blocks of test starting from a mapping of 5 pages at the base address, logging a test result for each initial mapping. These are logged with the same test name, causing test automation software to see two reports for the same test in a single run. Tweak the log

Re: [PATCH v3 0/5] module: Strict per-modname namespaces

2025-05-18 Thread Petr Pavlu
On 5/17/25 08:48, Masahiro Yamada wrote: > On Wed, May 14, 2025 at 5:48 PM Petr Pavlu wrote: >> >> On 5/2/25 16:12, Peter Zijlstra wrote: >>> Hi! >>> >>> Implement means for exports to be available to an explicit list of named >>> modules. By explicitly limiting the usage of certain exports, the a

Re: [PATCH] dt-bindings: pmem: Convert binding to YAML

2025-05-18 Thread Krzysztof Kozlowski
On 18/05/2025 05:55, Drew Fustini wrote: > Convert the PMEM device tree binding from text to YAML. This will allow > device trees with pmem-region nodes to pass dtbs_check. > > Signed-off-by: Drew Fustini > --- > .../devicetree/bindings/pmem/pmem-region.yaml | 49 +++ I don't see

Re: [PATCH v2 2/5] arm64: dts: qcom: sc8280xp: Fix node order

2025-05-18 Thread Dmitry Baryshkov
On Sat, May 17, 2025 at 07:27:51PM +0200, Konrad Dybcio wrote: > From: Konrad Dybcio > > Certain /soc@0 subnodes are very out of order. Reshuffle them. > > Signed-off-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 574 > - > 1 file changed,

Re: [PATCH v2 5/5] arm64: dts: qcom: sc8280xp-crd: Enable SLPI

2025-05-18 Thread Dmitry Baryshkov
On Sat, May 17, 2025 at 07:27:54PM +0200, Konrad Dybcio wrote: > From: Konrad Dybcio > > Enable the SLPI remoteproc and declare the firmware path. > > Signed-off-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 6 ++ > 1 file changed, 6 insertions(+) > Reviewed-by: D

Re: [PATCH v2 3/5] arm64: dts: qcom: sc8280xp: Add SLPI

2025-05-18 Thread Dmitry Baryshkov
On Sat, May 17, 2025 at 07:27:52PM +0200, Konrad Dybcio wrote: > From: Konrad Dybcio > > SC8280XP features a SLPI (Sensor Low Power Island) core. Describe it. > > Signed-off-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 99 > ++ > 1 file ch

Re: [PATCH bpf-next v3 05/11] bpf, arm64, powerpc: Add bpf_jit_bypass_spec_v1/v4()

2025-05-18 Thread Hari Bathini
On 01/05/25 1:05 pm, Luis Gerhorst wrote: JITs can set bpf_jit_bypass_spec_v1/v4() if they want the verifier to skip analysis/patching for the respective vulnerability. For v4, this will reduce the number of barriers the verifier inserts. For v1, it allows more programs to be accepted. The pr

Re: [PATCH bpf-next v2 06/11] bpf, arm64, powerpc: Change nospec to include v1 barrier

2025-05-18 Thread Hari Bathini
On 21/04/25 2:47 pm, Luis Gerhorst wrote: This changes the semantics of BPF_NOSPEC (previously a v4-only barrier) to always emit a speculation barrier that works against both Spectre v1 AND v4. If mitigation is not needed on an architecture, the backend should set bpf_jit_bypass_spec_v4/v1().

[PATCH] module: release codetag section when module load fails

2025-05-18 Thread David Wang
When module load failed after memory for codetag sections ready, codetag section memory was not properly released. This causes memory leak, and if next module load happens to got the same module address, codetag may pick the uninitialized section when manipulating tags during module unload, and lea