Re: [PATCH] virtio-net: disable delayed refill when pausing rx

2025-04-08 Thread Bui Quang Minh
On 4/8/25 14:34, Jason Wang wrote: On Mon, Apr 7, 2025 at 10:27 AM Bui Quang Minh wrote: On 4/7/25 08:03, Xuan Zhuo wrote: On Fri, 4 Apr 2025 16:39:03 +0700, Bui Quang Minh wrote: When pausing rx (e.g. set up xdp, xsk pool, rx resize), we call napi_disable() on the receive queue's napi. In

Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

2025-04-08 Thread Peng Fan
On Tue, Apr 08, 2025 at 10:59:58AM -0600, Mathieu Poirier wrote: >On Tue, 8 Apr 2025 at 09:02, Peng Fan wrote: >> >> On Thu, Apr 03, 2025 at 10:32:39PM +0800, Peng Fan wrote: >> >Hi Bjorn, >> > >> > >> >Thanks for replying this thread. >> > >> >On Wed, Apr 02, 2025 at 08:48:58AM -0500, Bjorn Ander

Re: [PATCH 13/19] virtio_ring: introduce virtqueue ops

2025-04-08 Thread Jason Wang
On Tue, Apr 8, 2025 at 7:37 PM Michael S. Tsirkin wrote: > > On Tue, Apr 08, 2025 at 03:02:35PM +0800, Jason Wang wrote: > > On Mon, Apr 7, 2025 at 4:20 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Mar 24, 2025 at 02:01:21PM +0800, Jason Wang wrote: > > > > This patch introduces virtqueue ops

[PATCH net-next 1/2] vsock: Linger on unsent data

2025-04-08 Thread Michal Luczaj
Change the behaviour of a lingering close(): instead of waiting for all data to be consumed, block until data is considered sent, i.e. until worker picks the packets and decrements virtio_vsock_sock::bytes_unsent down to 0. Do linger on shutdown() just as well. Signed-off-by: Michal Luczaj ---

RE: [PATCH 1/1] selftests/mincore: Allow read-ahead pages to reach the end of the file

2025-04-08 Thread Zhuo, Qiuxu
> From: Shuah Khan > [...] > > Applied for Linux 6.15-rc2 > > https://web.git.kernel.org/pub/scm/linux/kernel/git/shuah/linux- > kselftest.git/log/?h=fixes Thanks for reviewing and considering this fix. -Qiuxu

Re: [PATCH RFC v3 3/8] slab: add sheaf support for batching kfree_rcu() operations

2025-04-08 Thread Harry Yoo
On Mon, Mar 17, 2025 at 03:33:04PM +0100, Vlastimil Babka wrote: > Extend the sheaf infrastructure for more efficient kfree_rcu() handling. > For caches with sheaves, on each cpu maintain a rcu_free sheaf in > addition to main and spare sheaves. > > kfree_rcu() operations will try to put objects o

[PATCH RFT v15 6/8] selftests/clone3: Factor more of main loop into test_clone3()

2025-04-08 Thread Mark Brown
In order to make it easier to add more configuration for the tests and more support for runtime detection of when tests can be run pass the structure describing the tests into test_clone3() rather than picking the arguments out of it and have that function do all the per-test work. No functional c

[GIT PULL] kunit fixes update for Linux 6.15-rc2

2025-04-08 Thread Shuah Khan
Hi Linus, Please pull the following kunit fixes update for Linux 6.15-rc2 Fixes tool to report test count in case of a late test plan when tests are specified before the test plan. Fixes spelling error in the commit that went into 6.15-rc1. diff is attached. thanks, -- Shuah -

Re: [GIT PULL] kunit fixes update for Linux 6.15-rc2

2025-04-08 Thread pr-tracker-bot
The pull request you sent on Tue, 8 Apr 2025 16:31:50 -0600: > git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest > tags/linux_kselftest-kunit-6.15-rc2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a24588245776dafc227243a01bfbeb8a59bafba9 Thank you!

[PATCH RFT v15 3/8] selftests: Provide helper header for shadow stack testing

2025-04-08 Thread Mark Brown
While almost all users of shadow stacks should be relying on the dynamic linker and libc to enable the feature there are several low level test programs where it is useful to enable without any libc support, allowing testing without full system enablement. This low level testing is helpful during b

Re: [PATCH v2] selftests/ptrace/get_syscall_info: fix for MIPS n32

2025-04-08 Thread Shuah Khan
On 3/29/25 08:02, Maciej W. Rozycki wrote: On Sat, 29 Mar 2025, Dmitry V. Levin wrote: +#if defined(_MIPS_SIM) && _MIPS_SIM == _MIPS_SIM_NABI32 +/* + * MIPS N32 is the only architecture where __kernel_ulong_t + * does not match the bitness of syscall arguments. + */ +typedef unsigned long long

Re: spdxcheck: python git module considered harmful (was RE: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo)

2025-04-08 Thread Thomas Gleixner
On Tue, Apr 08 2025 at 17:34, Tim Bird wrote: >> -Original Message- > For what it's worth, I've always been a bit skeptical of the use of the > python git module > in spdxcheck.py. Its use makes it impossible to use spdxcheck on a kernel > source tree > from a tarball (ie, on source not

Re: [PATCH] tests/pid_namespace: Add missing sys/mount.h

2025-04-08 Thread T.J. Mercier
On Tue, Apr 8, 2025 at 3:48 PM Shuah Khan wrote: > > On 4/7/25 16:59, T.J. Mercier wrote: > > pid_max.c: In function ‘pid_max_cb’: > > pid_max.c:42:15: error: implicit declaration of function ‘mount’ > > [-Wimplicit-function-declaration] > > 42 |

Re: [PATCH net 0/2] mptcp: only inc MPJoinAckHMacFailure for HMAC failures

2025-04-08 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 07 Apr 2025 20:26:31 +0200 you wrote: > Recently, during a debugging session using local MPTCP connections, I > noticed MPJoinAckHMacFailure was strangely not zero on the server side. > > The first patch fixes th

Re: [PATCH 1/1] selftests/mincore: Allow read-ahead pages to reach the end of the file

2025-04-08 Thread Shuah Khan
On 4/7/25 20:42, Zhuo, Qiuxu wrote: Hi Shuah Khan, Just a gentle ping regarding this patch. If you have any questions, please feel free to let me know. Thanks! -Qiuxu From: Zhuo, Qiuxu [...] Subject: [PATCH 1/1] selftests/mincore: Allow read-ahead pages to reach the end of the file When run

Re: [v2,05/12] rcutorture: Add tests for SRCU up/down reader primitives

2025-04-08 Thread Paul E. McKenney
On Tue, Apr 08, 2025 at 06:05:19PM -0400, Joel Fernandes wrote: > > > On 4/8/2025 4:58 PM, Paul E. McKenney wrote: > > On Tue, Apr 08, 2025 at 08:18:05PM -, Joel Fernandes wrote: > >> Hello, Paul, > >> > >> On Tue, 8 Apr 2025 20:16:08 GMT, "Paul E. McKenney" wrote: > >>> This commit adds a ne

Re: [PATCH] selftests/futex: futex_waitv wouldblock test should fail

2025-04-08 Thread Shuah Khan
On 4/8/25 08:21, André Almeida wrote: Thank you Edward, Em 04/04/2025 19:12, Edward Liaw escreveu: Testcase should fail if -EWOULDBLOCK is not returned when expected value differs from actual value from the waiter. Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_f

[PATCH v2] selftests: pid_namespace: Add missing sys/mount.h

2025-04-08 Thread T.J. Mercier
pid_max.c: In function ‘pid_max_cb’: pid_max.c:42:15: error: implicit declaration of function ‘mount’ [-Wimplicit-function-declaration] 42 | ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0); | ^ pid_max.c:42:36: error: ‘MS_

Re: [PATCH] tests/pid_namespace: Add missing sys/mount.h

2025-04-08 Thread Shuah Khan
On 4/7/25 16:59, T.J. Mercier wrote: pid_max.c: In function ‘pid_max_cb’: pid_max.c:42:15: error: implicit declaration of function ‘mount’ [-Wimplicit-function-declaration] 42 | ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0); |

Re: [PATCH v3 2/2] selftests: memcg: Increase error tolerance of child memory.current check in test_memcg_protection()

2025-04-08 Thread Roman Gushchin
On Sat, Apr 05, 2025 at 10:40:10PM -0400, Waiman Long wrote: > The test_memcg_protection() function is used for the test_memcg_min and > test_memcg_low sub-tests. This function generates a set of parent/child > cgroups like: > > parent: memory.min/low = 50M > child 0: memory.min/low = 75M, m

Re: [v2,05/12] rcutorture: Add tests for SRCU up/down reader primitives

2025-04-08 Thread Joel Fernandes
Hello, Paul, On Tue, 8 Apr 2025 20:16:08 GMT, "Paul E. McKenney" wrote: > This commit adds a new rcutorture.n_up_down kernel boot parameter > that specifies the number of outstanding SRCU up/down readers, which > begin in kthread context and end in an hrtimer handler. There is a new > kthread ("r

Re: [v2,05/12] rcutorture: Add tests for SRCU up/down reader primitives

2025-04-08 Thread Joel Fernandes
On 4/8/2025 4:58 PM, Paul E. McKenney wrote: > On Tue, Apr 08, 2025 at 08:18:05PM -, Joel Fernandes wrote: >> Hello, Paul, >> >> On Tue, 8 Apr 2025 20:16:08 GMT, "Paul E. McKenney" wrote: >>> This commit adds a new rcutorture.n_up_down kernel boot parameter >>> that specifies the number of o

Re: spdxcheck: python git module considered harmful (was RE: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo)

2025-04-08 Thread Ricardo Ribalda
Hi Tim On Tue, 8 Apr 2025 at 20:12, Greg Kroah-Hartman wrote: > > Let me know if anyone objects to me working up a refactoring of spdxcheck.py > > eliminating the use of the python 'git' module, and submitting it for > > review. > > No objection from me! SGTM. Depending on how much time you ne

Re: [v2,05/12] rcutorture: Add tests for SRCU up/down reader primitives

2025-04-08 Thread Paul E. McKenney
On Tue, Apr 08, 2025 at 08:18:05PM -, Joel Fernandes wrote: > Hello, Paul, > > On Tue, 8 Apr 2025 20:16:08 GMT, "Paul E. McKenney" wrote: > > This commit adds a new rcutorture.n_up_down kernel boot parameter > > that specifies the number of outstanding SRCU up/down readers, which > > begin in

Re: [PATCH RESEND x86-next v4] selftests/x86/lam: fix resource leak in do_uring() and allocate_dsa_pasid()

2025-04-08 Thread Ingo Molnar
* Malaya Kumar Rout wrote: > Exception branch returns without closing > the file descriptors 'file_fd' and 'fd' > > Signed-off-by: Malaya Kumar Rout > --- > tools/testing/selftests/x86/lam.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Why have you ignored this request I

Re: [PATCH v4 0/4] Properly handle module_kobject creation

2025-04-08 Thread Greg KH
On Tue, Apr 08, 2025 at 12:19:22PM -0700, Shyam Saini wrote: > Hi Greg, > > > On 2/27/25 19:49, Shyam Saini wrote: > > > Hi Everyone, > > > > > > This patch series fixes handling of module_kobject creation. > > > A driver expect module_kset list populated with its corresponding > > > module_kobje

Re: [PATCH v4 0/4] Properly handle module_kobject creation

2025-04-08 Thread Shyam Saini
Hi Greg, > On 2/27/25 19:49, Shyam Saini wrote: > > Hi Everyone, > > > > This patch series fixes handling of module_kobject creation. > > A driver expect module_kset list populated with its corresponding > > module_kobject to create its /sys/module//drivers > > directory. > > > > Since, > > [1]

Re: [PATCH net-next] configs/debug: run and debug PREEMPT

2025-04-08 Thread Jakub Kicinski
On Tue, 8 Apr 2025 20:18:26 +0200 Matthieu Baerts wrote: > On 02/04/2025 19:23, Stanislav Fomichev wrote: > > Recent change [0] resulted in a "BUG: using __this_cpu_read() in > > preemptible" splat [1]. PREEMPT kernels have additional requirements > > on what can and can not run with/without preemp

[PATCH RFT v15 2/8] Documentation: userspace-api: Add shadow stack API documentation

2025-04-08 Thread Mark Brown
There are a number of architectures with shadow stack features which we are presenting to userspace with as consistent an API as we can (though there are some architecture specifics). Especially given that there are some important considerations for userspace code interacting directly with the feat

[PATCH RFT v15 4/8] fork: Add shadow stack support to clone3()

2025-04-08 Thread Mark Brown
Unlike with the normal stack there is no API for configuring the shadow stack for a new thread, instead the kernel will dynamically allocate a new shadow stack with the same size as the normal stack. This appears to be due to the shadow stack series having been in development since before the more

[PATCH RFT v15 7/8] selftests/clone3: Allow tests to flag if -E2BIG is a valid error code

2025-04-08 Thread Mark Brown
The clone_args structure is extensible, with the syscall passing in the length of the structure. Inside the kernel we use copy_struct_from_user() to read the struct but this has the unfortunate side effect of silently accepting some overrun in the structure size providing the extra data is all zero

RE:[PATCH RESEND x86-next v4] selftests/x86/lam: fix resource leak in do_uring() and allocate_dsa_pasid()

2025-04-08 Thread Malaya Kumar Rout
Exception branch returns without closing the file descriptors 'file_fd' and 'fd' Signed-off-by: Malaya Kumar Rout --- tools/testing/selftests/x86/lam.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/x86/lam.c b/tools/testing/selftests/x86/la

[PATCH RFT v15 8/8] selftests/clone3: Test shadow stack support

2025-04-08 Thread Mark Brown
Add basic test coverage for specifying the shadow stack for a newly created thread via clone3(), including coverage of the newly extended argument structure. We check that a user specified shadow stack can be provided, and that invalid combinations of parameters are rejected. In order to facilita

[PATCH RFT v15 0/8] fork: Support shadow stacks in clone3()

2025-04-08 Thread Mark Brown
The kernel has recently added support for shadow stacks, currently x86 only using their CET feature but both arm64 and RISC-V have equivalent features (GCS and Zicfiss respectively), I am actively working on GCS[1]. With shadow stacks the hardware maintains an additional stack containing only the

Re:[PATCH RESEND bpf-next v2] selftests/bpf: close the file descriptor to avoid resource leaks

2025-04-08 Thread Malaya Kumar Rout
Static Analyis for bench_htab_mem.c with cppcheck:error tools/testing/selftests/bpf/benchs/bench_htab_mem.c:284:3: error: Resource leak: fd [resourceLeak] tools/testing/selftests/bpf/prog_tests/sk_assign.c:41:3: error: Resource leak: tc [resourceLeak] fix the issue by closing the file descriptor

spdxcheck: python git module considered harmful (was RE: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo)

2025-04-08 Thread Bird, Tim
> -Original Message- > From: Gon Solo > It's a known problem: > https://github.com/gitpython-developers/GitPython/issues/2003 > https://github.com/python/cpython/issues/118761#issuecomment-2661504264 > For what it's worth, I've always been a bit skeptical of the use of the python git mo

[PATCH v17 12/15] selftests: pci_endpoint: Add doorbell test case

2025-04-08 Thread Frank Li
Add doorbell test case. Signed-off-by: Frank Li --- change from v14 to v16 - Add set IRQ type change from v13 to v14 - merge to selftests framework --- .../selftests/pci_endpoint/pci_endpoint_test.c | 28 ++ 1 file changed, 28 insertions(+) diff --git a/tools/testing/se

Re: spdxcheck: python git module considered harmful (was RE: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo)

2025-04-08 Thread Greg Kroah-Hartman
On Tue, Apr 08, 2025 at 05:34:20PM +, Bird, Tim wrote: > > -Original Message- > > From: Gon Solo > > It's a known problem: > > https://github.com/gitpython-developers/GitPython/issues/2003 > > https://github.com/python/cpython/issues/118761#issuecomment-2661504264 > > > > For what it

Re: [PATCH net 2/2] selftests: mptcp: validate MPJoin HMacFailure counters

2025-04-08 Thread Simon Horman
On Mon, Apr 07, 2025 at 08:26:33PM +0200, Matthieu Baerts (NGI0) wrote: > The parent commit fixes an issue around these counters where one of them > -- MPJoinAckHMacFailure -- was wrongly incremented in some cases. > > This makes sure the counter is always 0. It should be incremented only > in cas

Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

2025-04-08 Thread Mathieu Poirier
On Tue, 8 Apr 2025 at 09:02, Peng Fan wrote: > > On Thu, Apr 03, 2025 at 10:32:39PM +0800, Peng Fan wrote: > >Hi Bjorn, > > > > > >Thanks for replying this thread. > > > >On Wed, Apr 02, 2025 at 08:48:58AM -0500, Bjorn Andersson wrote: > >>On Wed, Apr 02, 2025 at 09:43:55AM +0800, Peng Fan wrote:

Re: [PATCH net 1/2] mptcp: only inc MPJoinAckHMacFailure for HMAC failures

2025-04-08 Thread Simon Horman
On Mon, Apr 07, 2025 at 08:26:32PM +0200, Matthieu Baerts (NGI0) wrote: > Recently, during a debugging session using local MPTCP connections, I > noticed MPJoinAckHMacFailure was not zero on the server side. The > counter was in fact incremented when the PM rejected new subflows, > because the 'sub

Re: [v3,4/12] rcutorture: Make torture.sh --do-rt use CONFIG_PREEMPT_RT

2025-04-08 Thread Paul E. McKenney
On Tue, Apr 08, 2025 at 02:29:19PM -, Joel Fernandes wrote: > Hello, Paul, > > On Tue, 8 Apr 2025 14:23:32 GMT, "Paul E. McKenney" wrote: > > The torture.sh --do-rt command-line parameter is intended to mimic -rt > > kernels. Now that CONFIG_PREEMPT_RT is upstream, this commit makes this > >

Re: [PATCH v8 4/8] vhost: Introduce vhost_worker_ops in vhost_worker

2025-04-08 Thread Mike Christie
On 4/8/25 4:45 AM, Cindy Lu wrote: > On Tue, Apr 8, 2025 at 12:06 AM Mike Christie > wrote: >> >> On 4/7/25 3:17 AM, Michael S. Tsirkin wrote: >>> On Fri, Mar 28, 2025 at 06:02:48PM +0800, Cindy Lu wrote: Abstract vhost worker operations (create/stop/wakeup) into an ops structure to prep

Re: [PATCH v2 2/2] x86/sgx: Implement EUPDATESVN and opportunistically call it during first EPC page alloc

2025-04-08 Thread Jarkko Sakkinen
On Tue, Apr 08, 2025 at 06:54:14AM +, Reshetova, Elena wrote: > > > > On Tue, Apr 08, 2025 at 09:40:14AM +0300, Jarkko Sakkinen wrote: > > > On Tue, Apr 08, 2025 at 12:06:32AM +, Huang, Kai wrote: > > > > On Mon, 2025-04-07 at 08:23 +, Reshetova, Elena wrote: > > > > > > On Fri, Apr 04

Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

2025-04-08 Thread Peng Fan
On Thu, Apr 03, 2025 at 10:32:39PM +0800, Peng Fan wrote: >Hi Bjorn, > > >Thanks for replying this thread. > >On Wed, Apr 02, 2025 at 08:48:58AM -0500, Bjorn Andersson wrote: >>On Wed, Apr 02, 2025 at 09:43:55AM +0800, Peng Fan wrote: >>> On Tue, Apr 01, 2025 at 10:05:03AM -0600, Mathieu Poirier wr

Re: [v3,4/12] rcutorture: Make torture.sh --do-rt use CONFIG_PREEMPT_RT

2025-04-08 Thread Joel Fernandes
Hello, Paul, On Tue, 8 Apr 2025 14:23:32 GMT, "Paul E. McKenney" wrote: > The torture.sh --do-rt command-line parameter is intended to mimic -rt > kernels. Now that CONFIG_PREEMPT_RT is upstream, this commit makes this > mimicking more precise. > > Note that testing of RCU priority boosting is d

Re: [PATCH] virtio-net: disable delayed refill when pausing rx

2025-04-08 Thread Jakub Kicinski
On Tue, 8 Apr 2025 11:28:54 +0200 Paolo Abeni wrote: > >> When napi_disable is called on an already disabled napi, it will sleep > >> in napi_disable_locked while still holding the netdev_lock. As a result, > >> later napi_enable gets stuck too as it cannot acquire the netdev_lock. > >> This leads

Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-04-08 Thread Iuliana Prodan
On 4/8/2025 4:46 PM, Mathieu Poirier wrote: On Tue, 8 Apr 2025 at 02:47, Iuliana Prodan wrote: Hello Mathieu, On 4/7/2025 7:17 PM, Mathieu Poirier wrote: Good morning, On Thu, Apr 03, 2025 at 01:01:24PM +0300, Iuliana Prodan (OSS) wrote: From: Iuliana Prodan Some DSP firmware requires a F

Re: [PATCH] selftests/futex: futex_waitv wouldblock test should fail

2025-04-08 Thread André Almeida
Thank you Edward, Em 04/04/2025 19:12, Edward Liaw escreveu: Testcase should fail if -EWOULDBLOCK is not returned when expected value differs from actual value from the waiter. Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock") Signed-off-by

Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-04-08 Thread Mathieu Poirier
On Tue, 8 Apr 2025 at 02:47, Iuliana Prodan wrote: > > Hello Mathieu, > > On 4/7/2025 7:17 PM, Mathieu Poirier wrote: > > Good morning, > > > > On Thu, Apr 03, 2025 at 01:01:24PM +0300, Iuliana Prodan (OSS) wrote: > >> From: Iuliana Prodan > >> > >> Some DSP firmware requires a FW_READY signal be

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-08 Thread Ackerley Tng
Christian Brauner writes: > On Mon, Apr 07, 2025 at 04:46:48PM +0200, David Hildenbrand wrote: > > > > Fwiw, b4 allows to specify dependencies so you can b4 shazam/am and it > will pull in all prerequisite patches: > > b4 prep --edit-deps Edit the series dependencies in your defined >

Re: [PATCH] virtio-net: disable delayed refill when pausing rx

2025-04-08 Thread Paolo Abeni
On 4/8/25 9:34 AM, Jason Wang wrote: > On Mon, Apr 7, 2025 at 10:27 AM Bui Quang Minh > wrote: >> On 4/7/25 08:03, Xuan Zhuo wrote: >>> On Fri, 4 Apr 2025 16:39:03 +0700, Bui Quang Minh >>> wrote: When pausing rx (e.g. set up xdp, xsk pool, rx resize), we call napi_disable() on the r

[PATCH RFC v7 8/8] KVM: guest_memfd: selftests: Add tests for mmap and NUMA policy support

2025-04-08 Thread Shivank Garg
Add tests for memory mapping and NUMA memory policy binding in guest_memfd. This extends the existing selftests by adding proper validation for: - Basic mmap() functionality - KVM GMEM set_policy and get_policy() vm_ops functionality using mbind() and get_mempolicy() - NUMA policy application bef

Re: [PATCH] vhost/net: remove zerocopy support

2025-04-08 Thread Jason Wang
On Tue, Apr 8, 2025 at 9:18 AM Jon Kohler wrote: > > > > > On Apr 6, 2025, at 7:14 PM, Jason Wang wrote: > > > > !---| > > CAUTION: External Email > > > > |---! > > > >

Re: [PATCHv6 net-next 1/2] wireguard: selftests: convert iptables to nft

2025-04-08 Thread Phil Sutter
Hi, On Tue, Apr 08, 2025 at 08:16:51AM +, Hangbin Liu wrote: > Convert the selftest to nft as it is the replacement for iptables, which > is used by default in most releases. > > Signed-off-by: Hangbin Liu What are the changes since v5, please? Thanks, Phil

[PATCH bpf-next v4 0/3] bpf: Fix use-after-free of sockmap

2025-04-08 Thread Jiayuan Chen
Syzkaller reported this issue [1]. The current sockmap has a dependency on sk_socket in both read and write stages, but there is a possibility that sk->sk_socket is released during the process, leading to panic situations. For a detailed reproduction, please refer to the description in the v2: htt

Re: [PATCH v8 4/8] vhost: Introduce vhost_worker_ops in vhost_worker

2025-04-08 Thread Cindy Lu
On Tue, Apr 8, 2025 at 12:06 AM Mike Christie wrote: > > On 4/7/25 3:17 AM, Michael S. Tsirkin wrote: > > On Fri, Mar 28, 2025 at 06:02:48PM +0800, Cindy Lu wrote: > >> Abstract vhost worker operations (create/stop/wakeup) into an ops > >> structure to prepare for kthread mode support. > >> > >> S

[PATCH RFC v7 2/8] mm/mempolicy: Export memory policy symbols

2025-04-08 Thread Shivank Garg
KVM guest_memfd wants to implement support for NUMA policies just like shmem already does using the shared policy infrastructure. As guest_memfd currently resides in KVM module code, we have to export the relevant symbols. In the future, guest_memfd might be moved to core-mm, at which point the sy

Re: [PATCH v8 8/8] vhost: Add a KConfig knob to enable IOCTL VHOST_FORK_FROM_OWNER

2025-04-08 Thread Michael S. Tsirkin
On Fri, Mar 28, 2025 at 06:02:52PM +0800, Cindy Lu wrote: > Introduce a new config knob `CONFIG_VHOST_ENABLE_FORK_OWNER_IOCTL`, > to control the availability of the `VHOST_FORK_FROM_OWNER` ioctl. > When CONFIG_VHOST_ENABLE_FORK_OWNER_IOCTL is set to n, the ioctl > is disabled, and any attempt to us

Re: [PATCH 0/7] irqbypass: Cleanups and a perf improvement

2025-04-08 Thread Michael S. Tsirkin
On Fri, Apr 04, 2025 at 02:14:42PM -0700, Sean Christopherson wrote: > The two primary goals of this series are to make the irqbypass concept > easier to understand, and to address the terrible performance that can > result from using a list to track connections. > > For the first goal, track the

[PATCH v5] remoteproc: Add device awake calls in rproc boot and shutdown path

2025-04-08 Thread Souradeep Chowdhury
Add device awake calls in case of rproc boot and rproc shutdown path. Currently, device awake call is only present in the recovery path of remoteproc. If an user stops and starts rproc by using the sysfs interface, then on pm suspension the firmware fails to load as the request_firmware call under

[PATCH RFC v7 0/8] Add NUMA mempolicy support for KVM guest-memfd

2025-04-08 Thread Shivank Garg
KVM's guest-memfd memory backend currently lacks support for NUMA policy enforcement, causing guest memory allocations to be distributed arbitrarily across host NUMA nodes regardless of the policy specified by the VMM. This occurs because conventional userspace NUMA control mechanisms like mbind()

[PATCH RFC v7 6/8] KVM: guest_memfd: Add slab-allocated inode cache

2025-04-08 Thread Shivank Garg
Add dedicated inode structure (kvm_gmem_inode_info) and slab-allocated inode cache for guest memory backing, similar to how shmem handles inodes. This adds the necessary allocation/destruction functions and prepares for upcoming guest_memfd NUMA policy support changes. Signed-off-by: Shivank Garg

[PATCH RFC v7 7/8] KVM: guest_memfd: Enforce NUMA mempolicy using shared policy

2025-04-08 Thread Shivank Garg
Previously, guest-memfd allocations followed local NUMA node id in absence of process mempolicy, resulting in arbitrary memory allocation. Moreover, mbind() couldn't be used since memory wasn't mapped to userspace in the VMM. Enable NUMA policy support by implementing vm_ops for guest-memfd mmap o

[PATCH RFC v7 5/8] KVM: guest_memfd: Make guest mem use guest mem inodes instead of anonymous inodes

2025-04-08 Thread Shivank Garg
From: Ackerley Tng Using guest mem inodes allows us to store metadata for the backing memory on the inode. Metadata will be added in a later patch to support HugeTLB pages. Metadata about backing memory should not be stored on the file, since the file represents a guest_memfd's binding with a st

[PATCH RFC v7 1/8] mm/filemap: Add mempolicy support to the filemap layer

2025-04-08 Thread Shivank Garg
From: Shivansh Dhiman Add NUMA mempolicy support to the filemap allocation path by introducing new APIs that take a mempolicy argument: - filemap_grab_folio_mpol() - filemap_alloc_folio_mpol() - __filemap_get_folio_mpol() These APIs allow callers to specify a NUMA policy during page cache alloca

[PATCH RFC v7 3/8] security: Export security_inode_init_security_anon for KVM guest_memfd

2025-04-08 Thread Shivank Garg
KVM guest_memfd is implementing its own inodes to store metadata for backing memory using a custom filesystem. This requires the ability to initialize anonymous inode using security_inode_init_security_anon(). As guest_memfd currently resides in the KVM module, we need to export this symbol for us

Re: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-08 Thread Gon Solo
It's a known problem: https://github.com/gitpython-developers/GitPython/issues/2003 https://github.com/python/cpython/issues/118761#issuecomment-2661504264

Re: [PATCH] selftests: mptcp: add comment for getaddrinfo

2025-04-08 Thread Paolo Abeni
On 4/8/25 5:09 AM, zhenwei pi wrote: > On 4/8/25 09:43, Geliang Tang wrote: >> On Mon, 2025-04-07 at 16:51 +0800, zhenwei pi wrote: >>> mptcp_connect.c is a startup tutorial of MPTCP programming, however >>> there is a lack of ai_protocol(IPPROTO_MPTCP) usage. Add comment for >>> getaddrinfo MPTCP

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-04-08 Thread Richard Fitzgerald
On 19/03/2025 11:05 pm, Nico Pache wrote: FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit tooling. Fixes: dd0b6b1f29b9 ("firmware: cs_dsp: Add KU

[PATCH bpf-next v4 3/3] selftests/bpf: Add edge case tests for sockmap

2025-04-08 Thread Jiayuan Chen
Add edge case tests for sockmap. Signed-off-by: Jiayuan Chen --- .../selftests/bpf/prog_tests/socket_helpers.h | 13 +++- .../selftests/bpf/prog_tests/sockmap_basic.c | 60 +++ 2 files changed, 72 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/prog_tests/

Re: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-08 Thread Gon Solo
> > checkpatch suddenly broke for me with the same error as shown here and the > > patch fixed it. > > > > Tested-by: Duje Mihanović Turns out, it was not enough; the variable is used later. How about the following patch? >From 763f25c8ca2e29f343bfd109a17501de71b38d43 Mon Sep 17 00:00:00 2001

Re: [PATCH v8 5/8] vhost: Reintroduce kthread mode support in vhost

2025-04-08 Thread Cindy Lu
On Tue, Apr 8, 2025 at 12:04 AM Mike Christie wrote: > > On 3/28/25 5:02 AM, Cindy Lu wrote: > > +static int vhost_kthread_worker_create(struct vhost_worker *worker, > > +struct vhost_dev *dev, const char > > *name) > > +{ > > + struct task_struct *task; >

Re: [PATCH] selftests/futex: futex_waitv wouldblock test should fail

2025-04-08 Thread Thomas Gleixner
On Fri, Apr 04 2025 at 22:12, Edward Liaw wrote: > Testcase should fail if -EWOULDBLOCK is not returned when expected value > differs from actual value from the waiter. > > Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test > sys_futex_waitv() wouldblock") > Signed-off-by: E

Re: [PATCH 13/19] virtio_ring: introduce virtqueue ops

2025-04-08 Thread Jason Wang
On Mon, Apr 7, 2025 at 4:20 PM Michael S. Tsirkin wrote: > > On Mon, Mar 24, 2025 at 02:01:21PM +0800, Jason Wang wrote: > > This patch introduces virtqueue ops which is a set of the callbacks > > that will be called for different queue layout or features. This would > > help to avoid branches for

Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-04-08 Thread Iuliana Prodan
Hello Mathieu, On 4/7/2025 7:17 PM, Mathieu Poirier wrote: Good morning, On Thu, Apr 03, 2025 at 01:01:24PM +0300, Iuliana Prodan (OSS) wrote: From: Iuliana Prodan Some DSP firmware requires a FW_READY signal before proceeding, while others do not. Therefore, add support to handle i.MX DSP-s

Re: [PATCH v9 08/26] remoteproc: k3-r5: Refactor sequential core power up/down operations

2025-04-08 Thread Beleswar Prasad Padhi
Hi Andrew, On 07/04/25 19:15, Andrew Davis wrote: On 3/17/25 7:06 AM, Beleswar Padhi wrote: The existing implementation of the waiting mechanism in "k3_r5_cluster_rproc_init()" waits for the "released_from_reset" flag to be set as part of the firmware boot process in "k3_r5_rproc_start()". The

Re: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-08 Thread Gon Solo
> checkpatch suddenly broke for me with the same error as shown here and the > patch fixed it. > > Tested-by: Duje Mihanović Same for me. Tested-by: Andreas Wendleder

Re: [PATCH v9 05/26] remoteproc: k3-m4: Use k3_rproc_mem_data structure for memory info

2025-04-08 Thread Beleswar Prasad Padhi
Hi Andrew, On 07/04/25 19:13, Andrew Davis wrote: On 3/17/25 7:06 AM, Beleswar Padhi wrote: The ti_k3_m4_remoteproc.c driver previously hardcoded device memory region addresses and names. Change this to use the k3_rproc_mem_data structure to store memory information. This aligns with DSP and R5

[PATCHv6 net-next 0/2] wireguard: selftests: use nftables for testing

2025-04-08 Thread Hangbin Liu
This patch set convert the wireguard selftest to nftables, as iptables is deparated and nftables is the default framework of most releases. v6: fix typo in patch 1/2. Update the description (Phil Sutter) v5: remove the counter in nft rules and link nft statically (Jason A. Donenfeld) v4: no update

[PATCHv6 net-next 1/2] wireguard: selftests: convert iptables to nft

2025-04-08 Thread Hangbin Liu
Convert the selftest to nft as it is the replacement for iptables, which is used by default in most releases. Signed-off-by: Hangbin Liu --- tools/testing/selftests/wireguard/netns.sh | 29 ++ 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/tools/testing/selft

Re: [PATCH v2] selftests/bpf: close the file descriptor to avoid resource leaks

2025-04-08 Thread Hou Tao
On 4/7/2025 6:01 PM, Malaya Kumar Rout wrote: > Static Analyis for bench_htab_mem.c with cppcheck:error > tools/testing/selftests/bpf/benchs/bench_htab_mem.c:284:3: > error: Resource leak: fd [resourceLeak] > tools/testing/selftests/bpf/prog_tests/sk_assign.c:41:3: > error: Resource leak: tc [re

Re: [PATCH v9 02/26] remoteproc: k3-r5: Refactor Data Structures to Align with DSP and M4

2025-04-08 Thread Beleswar Prasad Padhi
On 07/04/25 19:03, Andrew Davis wrote: On 3/17/25 7:05 AM, Beleswar Padhi wrote: Currently, struct members such as mem, num_mems, reset, tsp, ti_sci and ti_sci_id are part of the k3_r5_core structure. To align the rproc->priv data structure of the R5 remote processor with that of the DSP and M

Re: [PATCH v3 0/6] KVM: guest_memfd: support for uffd minor

2025-04-08 Thread Christian Brauner
On Mon, Apr 07, 2025 at 04:46:48PM +0200, David Hildenbrand wrote: > On 07.04.25 16:24, Liam R. Howlett wrote: > > * Nikita Kalyazin [250407 10:05]: > > > > > > > ... > > > > > > > > > > All of this is extremely confusing because the onus of figuring out what > > > > the final code will look l

Re: [PATCH v9 01/26] remoteproc: k3-r5: Re-order internal memory initialization function

2025-04-08 Thread Beleswar Prasad Padhi
On 07/04/25 18:59, Andrew Davis wrote: On 3/17/25 7:05 AM, Beleswar Padhi wrote: The core's internal memory data structure will be refactored to be part of the k3_r5_rproc structure in a future commit. As a result, internal memory initialization will need to be performed inside k3_r5_cluster_r

Re: [PATCH] virtio-net: disable delayed refill when pausing rx

2025-04-08 Thread Jason Wang
On Mon, Apr 7, 2025 at 10:27 AM Bui Quang Minh wrote: > > On 4/7/25 08:03, Xuan Zhuo wrote: > > On Fri, 4 Apr 2025 16:39:03 +0700, Bui Quang Minh > > wrote: > >> When pausing rx (e.g. set up xdp, xsk pool, rx resize), we call > >> napi_disable() on the receive queue's napi. In delayed refill_wo

Re: [PATCH v3] selftests/x86/lam: fix resource leak in do_uring() and allocate_dsa_pasid()

2025-04-08 Thread Ingo Molnar
* Malaya Kumar Rout wrote: > Exception branch returns without closing > the file descriptors 'file_fd' and 'fd' > > Signed-off-by: Malaya Kumar Rout > --- > tools/testing/selftests/x86/lam.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/self

Re: [PATCH net-next v25 00/23] Introducing OpenVPN Data Channel Offload

2025-04-08 Thread Antonio Quartulli
Hi, On 08/04/2025 08:34, Jiri Slaby wrote: Given: > +#define OVPN_FAMILY_NAME    "ovpn" and > ctx->ovpn_dco_id = genl_ctrl_resolve(ctx->nl_sock, OVPN_FAMILY_NAME); Is there also an openvpn branch understanding the new (in-kernel) naming? I.e. something like s/ovpn-dco-v2/ovpn/? As with 2.

Re: [PATCH net-next v25 00/23] Introducing OpenVPN Data Channel Offload

2025-04-08 Thread Jiri Slaby
On 07. 04. 25, 21:46, Antonio Quartulli wrote: Notable changes since v24: * disable TCP disconnections of attached sockets (tcp_disconnect() returns -EBUSY) - similarly to kTLS. * used rcu_replace_pointer instead of rcu_dereference_protected+rcu_assign_pointer * dropped useless skb->ignore_df

Re: [PATCH] dt-bindings: virtio: pci-iommu: Add ref to pci-device.yaml

2025-04-08 Thread Jean-Philippe Brucker
On Mon, Apr 07, 2025 at 11:53:40AM -0500, Rob Herring (Arm) wrote: > The virtio pci-iommu is a PCI device, so it should have a reference to > the pci-device.yaml schema. The pci-device.yaml schema defines the 'reg' > format as a schema, so the text description for 'reg' can be dropped. > > Signed-

[PATCH bpf-next v4 1/3] bpf, sockmap: avoid using sk_socket after free when sending

2025-04-08 Thread Jiayuan Chen
The sk->sk_socket is not locked or referenced, and during the call to skb_send_sock(), there is a race condition with the release of sk_socket. All types of sockets(tcp/udp/unix/vsock) will be affected. Race conditions: ''' CPU0 CPU1 skb_send_sock sendmsg_unlocked