Re: [PATCH] selftests/bpf: close the file descriptor to avoid resource leaks

2025-03-31 Thread Hou Tao
On 3/24/2025 2:42 PM, Malaya Kumar Rout wrote: > Static Analyis for bench_htab_mem.c with cppcheck:error > tools/testing/selftests/bpf/benchs/bench_htab_mem.c:284:3: > error: Resource leak: fd [resourceLeak] > tools/testing/selftests/bpf/prog_tests/sk_assign.c:41:3: > error: Resource leak: tc [r

Re: [PATCH v4] hrtimers: Force migrate away hrtimers queued after CPUHP_AP_HRTIMERS_DYING

2025-03-31 Thread 張維哲
On Wed, 2025-03-26 at 17:44 +0100, Frederic Weisbecker wrote: > > It's not the first time I get such a report on an out of tree > kernel. The problem is I don't know if the tainted modules are > involved. But something is probably making an offline CPU visible > within > the hierarchy on get_nohz_

Re: [PATCH 01/10] cgroup/cpuset: Fix race between newly created partition and dying one

2025-03-31 Thread Waiman Long
On 3/31/25 7:13 PM, Tejun Heo wrote: Hello, On Sun, Mar 30, 2025 at 05:52:39PM -0400, Waiman Long wrote: ... One possible way to fix this is to iterate the dying cpusets as well and avoid using the exclusive CPUs in those dying cpusets. However, this can still cause random partition creation fa

[PATCH v2 05/12] rcutorture: Add tests for SRCU up/down reader primitives

2025-03-31 Thread Paul E. McKenney
This commit adds a new rcutorture.n_up_down kernel boot parameter that specifies the number of outstanding SRCU up/down readers, which begin in kthread context and end in an hrtimer handler. There is a new kthread ("rcu_torture_updown") that scans an per-reader array looking for elements whose rea

Re: [PATCH net 0/4] mptcp: misc. fixes for 6.15-rc0

2025-03-31 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski : On Fri, 28 Mar 2025 15:27:15 +0100 you wrote: > Here are 4 unrelated patches: > > - Patch 1: fix a NULL pointer when two SYN-ACK for the same request are > handled in parallel. A fix for up to v5.9. > > - Patch 2: sel

Re: [PATCH 10/10] selftest/cgroup: Add a remote partition transition test to test_cpuset_prs.sh

2025-03-31 Thread Tejun Heo
On Sun, Mar 30, 2025 at 05:52:48PM -0400, Waiman Long wrote: > The current cgroup directory layout for running the partition state > transition tests is mainly suitable for testing local partitions as > well as with a mix of local and remote partitions. It is not that > suitable for doing extensive

[PATCH v2 04/12] rcutorture: Make torture.sh --do-rt use CONFIG_PREEMPT_RT

2025-03-31 Thread Paul E. McKenney
The torture.sh --do-rt command-line parameter is intended to mimic -rt kernels. Now that CONFIG_PREEMPT_RT is upstream, this commit makes this mimicking more precise. Note that testing of RCU priority boosting is disabled in favor of forward-progress testing of RCU callbacks. If it turns out to

Re: [PATCH 01/10] cgroup/cpuset: Fix race between newly created partition and dying one

2025-03-31 Thread Tejun Heo
Hello, On Sun, Mar 30, 2025 at 05:52:39PM -0400, Waiman Long wrote: ... > One possible way to fix this is to iterate the dying cpusets as well and > avoid using the exclusive CPUs in those dying cpusets. However, this > can still cause random partition creation failures or other anomalies > due to

[PATCH v2 0/12]

2025-03-31 Thread Paul E. McKenney
Hello! The following series improves testing of SRCU-fast and SRCU up/down, deprecates SRCU-lite, enables torture.sh to skip non-debug testing, and adds testing for Rust's RCU bindings. The Rust RCU patch is very much in RFC state, but I am posting it anyway for wider exposure. 1. Make srcu

[PATCH 2/3] selftests: coredump: Use waitpid() instead of busy-wait

2025-03-31 Thread Nam Cao
The test waits for coredump to finish by busy-waiting for the stackdump_values file to be created. The maximum wait time is 10 seconds. This doesn't work for slow machine (qemu-system-riscv64), because coredump takes longer. Switch to use waitpid(). With this, the stack_values file doesn't need

Re: [PATCH 1/3] rcu: Replace magic number with meaningful constant in rcu_seq_done_exact()

2025-03-31 Thread Paul E. McKenney
On Mon, Mar 31, 2025 at 11:14:10PM +0200, Frederic Weisbecker wrote: > Le Mon, Mar 31, 2025 at 11:28:47AM -0700, Paul E. McKenney a écrit : > > > So I'm unfortunately asking again if it wouldn't be a good idea to have a > > > single > > > global state counter that lives in the root node so that we

Re: [PATCH 1/3] rcu: Replace magic number with meaningful constant in rcu_seq_done_exact()

2025-03-31 Thread Frederic Weisbecker
Le Mon, Mar 31, 2025 at 11:28:47AM -0700, Paul E. McKenney a écrit : > > So I'm unfortunately asking again if it wouldn't be a good idea to have a > > single > > global state counter that lives in the root node so that we don't have it > > duplicated in rcu_state.gp_seq. > > > > This involves som

[ANNOUNCE] 5.10.235-rt129

2025-03-31 Thread Luis Claudio R. Goncalves
Hello RT-list! I'm pleased to announce the 5.10.235-rt129 stable release. While working on the stable update 5.10.235-rt128, a build problem on the be2net driver was discovered on RT. That inconvenience was fixed, hence the release of 5.10.235-rt129. You can get this release via the git tree at:

[PATCH v2 08/12] rcutorture: Complain if an ->up_read() is delayed more than 10 seconds

2025-03-31 Thread Paul E. McKenney
The down/up SRCU reader testing uses an hrtimer handler to exit the SRCU read-side critical section. This might be delayed, and if delayed for too long, it can prevent the rcutorture run from completing. This commit therefore complains if the hrtimer handler is delayed for more than ten seconds.

[PATCH v2 01/12] rcutorture: Make srcu_lockdep.sh check kernel Kconfig

2025-03-31 Thread Paul E. McKenney
The srcu_lockdep.sh currently blindly trusts the rcutorture SRCU-P scenario to build its kernel with lockdep enabled. Of course, this dependency might not be obvious to someone rebalancing SRCU scenarios. This commit therefore adds code to srcu_lockdep.sh that verifies that the .config file has lo

[PATCH v2 02/12] rcutorture: Make srcu_lockdep.sh check reader-conflict handling

2025-03-31 Thread Paul E. McKenney
Mixing different flavors of RCU readers is forbidden, for example, you should not use srcu_read_lock() and srcu_read_lock_nmisafe() on the same srcu_struct structure. There are checks for this, but these checks are not tested on a regular basis. This commit therefore adds such tests to srcu_lockd

[PATCH v2 09/12] rcutorture: Check for ->up_read() without matching ->down_read()

2025-03-31 Thread Paul E. McKenney
This commit creates counters in the rcu_torture_one_read_state_updown structure that check for a call to ->up_read() that lacks a matching call to ->down_read(). While in the area, add end-of-run cleanup code that prevents calls to rcu_torture_updown_hrt() from happening after the test has moved o

[PATCH v2 03/12] rcutorture: Split out beginning and end from rcu_torture_one_read()

2025-03-31 Thread Paul E. McKenney
The rcu_torture_one_read() function is designed for RCU readers that are confined to a task, such that a single thread of control extends from the beginning of a given RCU read-side critical section to its end. This does not suffice for things like srcu_down_read() and srcu_up_read(), where the cr

Re: [PATCH 1/3] rcu: Replace magic number with meaningful constant in rcu_seq_done_exact()

2025-03-31 Thread Paul E. McKenney
On Mon, Mar 31, 2025 at 12:10:58AM +0200, Frederic Weisbecker wrote: > Le Thu, Mar 27, 2025 at 10:09:48AM -0700, Paul E. McKenney a écrit : > > On Wed, Mar 26, 2025 at 10:42:52PM +, Joel Fernandes wrote: > > > > > > > > > > On Mar 26, 2025, at 6:33 PM, Paul E. McKenney > > > > wrote: > > >

Re: [PATCH] DAX: warn when kmem regions are truncated for memory block alignment.

2025-03-31 Thread Gregory Price
On Fri, Mar 21, 2025 at 02:07:31PM -0400, Gregory Price wrote: > Device capacity intended for use as system ram should be aligned to the > architecture-defined memory block size or that capacity will be silently > truncated and capacity stranded. > > As hotplug dax memory becomes more prevelant, t

Re: [PATCH v2 2/2] x86/sgx: Implement EUPDATESVN and opportunistically call it during first EPC page alloc

2025-03-31 Thread Jarkko Sakkinen
On Mon, Mar 31, 2025 at 07:26:45AM +, Reshetova, Elena wrote: > > > > + default: > > > > + pr_err("EUPDATESVN: unknown error %d\n", ret); > > > > + break; > > > > + } > > > > > > Overall, I think you're right in that "inversion" does make sense, > > > now

[PATCH 3/3] selftests: coredump: Raise timeout to 2 minutes

2025-03-31 Thread Nam Cao
The test's runtime (nearly 20s) is dangerously close to the limit (30s) on qemu-system-riscv64: $ time ./stackdump_test > /dev/null real0m19.210s user0m0.077s sys 0m0.359s There could be machines slower than qemu-system-riscv64. Therefore raise the test timeout to 2 minutes to be safe

[PATCH 1/3] selftests: coredump: Properly initialize pointer

2025-03-31 Thread Nam Cao
The buffer pointer "line" is not initialized. This pointer is passed to getline(). It can still work if the stack is zero-initialized, because getline() can work with a NULL pointer as buffer. But this is obviously broken. This bug shows up while running the test on a riscv64 machine. Fix it by

Re: [PATCH net-next v24 00/23] Introducing OpenVPN Data Channel Offload

2025-03-31 Thread Sabrina Dubroca
2025-03-28, 10:14:27 +0100, Antonio Quartulli wrote: > Hi Sabrina, > > do you plan to drop more comments at the patchset at this point? Yes, I had a couple of small comments here and there that I didn't think strictly required a respin, but I'll send them out now since there'll be more iteration.

[PATCH AUTOSEL 6.13 01/16] srcu: Force synchronization for srcu_get_delay()

2025-03-31 Thread Sasha Levin
From: "Paul E. McKenney" [ Upstream commit d31e31365b5b6c0cdfc74d71be87234ced564395 ] Currently, srcu_get_delay() can be called concurrently, for example, by a CPU that is the first to request a new grace period and the CPU processing the current grace period. Although concurrent access is harm

[PATCH AUTOSEL 6.14 01/18] srcu: Force synchronization for srcu_get_delay()

2025-03-31 Thread Sasha Levin
From: "Paul E. McKenney" [ Upstream commit d31e31365b5b6c0cdfc74d71be87234ced564395 ] Currently, srcu_get_delay() can be called concurrently, for example, by a CPU that is the first to request a new grace period and the CPU processing the current grace period. Although concurrent access is harm

Re: [PATCH v9 1/3] rust: str: add radix prefixed integer parsing functions

2025-03-31 Thread Andreas Hindborg
"Miguel Ojeda" writes: > On Fri, Mar 21, 2025 at 10:18 AM Andreas Hindborg > wrote: >> >> Add the trait `ParseInt` for parsing string representations of integers >> where the string representations are optionally prefixed by a radix >> specifier. Implement the trait for the primitive integer ty

Re: [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-31 Thread Andrea della Porta
Hi song, On 10:15 Thu 20 Mar , Song Liu wrote: > With proper exception boundary detection, it is possible to implment > arch_stack_walk_reliable without sframe. > > Note that, arch_stack_walk_reliable does not guarantee getting reliable > stack in all scenarios. Instead, it can reliably detec

Re: [PATCH v8 0/8] vhost: Add support of kthread API

2025-03-31 Thread Lei Yang
QE tested this series of v8 with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Fri, Mar 28, 2025 at 6:04 PM Cindy Lu wrote: > > In commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads"), > the vhost now uses vhost_task and operates as a child of the > own

Re: [PATCH v2 12/16] selftests: vDSO: parse_vdso: Use UAPI headers instead of libc headers

2025-03-31 Thread Mark Brown
On Fri, Mar 28, 2025 at 05:08:26PM -0600, Shuah Khan wrote: > On 3/26/25 07:02, Mark Brown wrote: > > This bug is now in mainline. A fix was posted by Thomas the day after > > the original report: > > > > https://lore.kernel.org/r/20250321-uapi-consistency-v1-1-439070118...@linutronix.de >

Re: [PATCH v3 2/2] arm64: Implement HAVE_LIVEPATCH

2025-03-31 Thread Andrea della Porta
On 10:15 Thu 20 Mar , Song Liu wrote: > This is largely based on [1] by Suraj Jitindar Singh. > > Test coverage: > > - Passed manual tests with samples/livepatch. > - Passed all but test-kprobe.sh in selftests/livepatch. > test-kprobe.sh is expected to fail, because arm64 doesn't have > K

Re: [PATCH v9 1/3] rust: str: add radix prefixed integer parsing functions

2025-03-31 Thread Miguel Ojeda
On Fri, Mar 21, 2025 at 10:18 AM Andreas Hindborg wrote: > > Add the trait `ParseInt` for parsing string representations of integers > where the string representations are optionally prefixed by a radix > specifier. Implement the trait for the primitive integer types. > > Tested-by: Daniel Almeida

Re: [PATCH v2 1/2] time/timekeeping: Fix possible inconsistencies in _COARSE clockids

2025-03-31 Thread Miroslav Lichvar
On Thu, Mar 27, 2025 at 06:32:27PM +0100, Thomas Gleixner wrote: > On Thu, Mar 27 2025 at 16:42, Miroslav Lichvar wrote: > > On Thu, Mar 27, 2025 at 10:22:31AM +0100, Thomas Gleixner wrote: > > To clearly see the difference with the new code, I made an attempt > > to update the old linux-tktest sim