Re: [syzbot] [wpan?] WARNING in __dev_change_net_namespace (3)

2025-03-26 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:f6e0150b2003 Merge tag 'mtd/for-6.15' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1025619858 kernel config: https://syzkaller.appspot.com/x/.config?x=46a0719

Re: [PATCH 2/3] of: Simplify of_dma_set_restricted_buffer() to use of_for_each_phandle()

2025-03-26 Thread Chen-Yu Tsai
On Thu, Mar 27, 2025 at 2:53 AM Rob Herring wrote: > > On Wed, Mar 26, 2025 at 1:44 AM Chen-Yu Tsai wrote: > > > > Hi, > > > > On Tue, Mar 18, 2025 at 7:29 AM Rob Herring (Arm) wrote: > > > > > > Simplify of_dma_set_restricted_buffer() by using of_property_present() > > > and of_for_each_phandle

Re: [PATCH 5/9] rcutorture: Add tests for SRCU up/down reader primitives

2025-03-26 Thread Z qiang
> > This commit adds a new rcutorture.n_up_down kernel boot parameter > that specifies the number of outstanding SRCU up/down readers, which > begin in kthread context and end in an hrtimer handler. There is a new > kthread ("rcu_torture_updown") that scans an per-reader array looking > for elemen

[GIT PULL] kunit next update for Linux 6.15-rc1

2025-03-26 Thread Shuah Khan
Hi Linus, Please pull the following kunit next update for Linux 6.15-rc1. kunit tool: - Changes to kunit tool to use qboot on QEMU x86_64, and build GDB scripts. - Fixes kunit tool bug in parsing test plan. - Adds test to kunit tool to check parsing late test plan. kunit: - Clarifies kunit_skip

[PATCH] selftests/filesystems: remove duplicate sys/types.h header

2025-03-26 Thread Chen Ni
Remove duplicate header which is included twice. Signed-off-by: Chen Ni --- tools/testing/selftests/filesystems/utils.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/filesystems/utils.c b/tools/testing/selftests/filesystems/utils.c index e553c89c5b19..06419bf4ba19 1

[GIT PULL] Kselftest next update for Linux 6.15-rc1

2025-03-26 Thread Shuah Khan
Hi Linus, Please pull the following kselftest next update for Linux 6.15-rc1. Fixes bugs and cleans up code in tracing, ftrace, and user_events tests. Adds missing executables to ftrace gitignore. diff is attached. thanks, -- Shuah -

Re: [PATCH 2/4] x86/sgx: Change counter sgx_nr_free_pages -> sgx_nr_used_pages

2025-03-26 Thread Jarkko Sakkinen
On Mon, Mar 24, 2025 at 12:19:37PM +, Reshetova, Elena wrote: > > > On Fri, Mar 21, 2025 at 02:34:41PM +0200, Elena Reshetova wrote: > > > sgx_nr_free_pages is an atomic that is used to keep track of > > > free EPC pages and detect whenever page reclaiming should start. > > > Since successful

Re: [PATCH v2 09/10] vhost-scsi: log event queue write descriptors

2025-03-26 Thread Mike Christie
On 3/17/25 6:55 PM, Dongli Zhang wrote: > Log write descriptors for the event queue, leveraging vhost_get_vq_desc() > to retrieve the array of write descriptors to obtain the log buffer. > > There is only one path for event queue. > > Suggested-by: Joao Martins > Signed-off-by: Dongli Zhang R

Re: [PATCH v2 09/10] vhost-scsi: log event queue write descriptors

2025-03-26 Thread Mike Christie
On 3/17/25 6:55 PM, Dongli Zhang wrote: > Log write descriptors for the event queue, leveraging vhost_get_vq_desc() > to retrieve the array of write descriptors to obtain the log buffer. > > There is only one path for event queue. > > Suggested-by: Joao Martins > Signed-off-by: Dongli Zhang Re

Re: [PATCH v2 06/10] vhost-scsi: cache log buffer in I/O queue vhost_scsi_cmd

2025-03-26 Thread Mike Christie
On 3/17/25 7:04 PM, Dongli Zhang wrote: > @@ -1390,6 +1424,24 @@ vhost_scsi_handle_vq(struct vhost_scsi *vs, struct > vhost_virtqueue *vq) > goto err; > } > > + if (unlikely(vq_log && log_num)) { > + if (!cmd->tvc_log) > +

Re: [PATCH 2/3] rcu: Add warning to ensure rcu_seq_done_exact() is working

2025-03-26 Thread Paul E. McKenney
On Wed, Mar 26, 2025 at 10:50:13PM +, Joel Fernandes wrote: > > > > On Mar 26, 2025, at 6:36 PM, Paul E. McKenney wrote: > > > > On Mon, Mar 24, 2025 at 01:01:54PM -0400, Joel Fernandes wrote: > >> The previous patch improved the rcu_seq_done_exact() function by adding > >> a meaningful co

Re: [PATCH v2 05/10] vhost-scsi: adjust vhost_scsi_get_desc() to log vring descriptors

2025-03-26 Thread Mike Christie
On 3/17/25 6:55 PM, Dongli Zhang wrote: > Adjust vhost_scsi_get_desc() to facilitate logging of vring descriptors. > > Add new arguments to allow passing the log buffer and length to > vhost_get_vq_desc(). > > In addition, reset 'log_num' since vhost_get_vq_desc() may reset it only > after certai

Re: [PATCH bpf-next v3 2/3] bpf, sockmap: avoid using sk_socket after free when reading

2025-03-26 Thread Jiayuan Chen
March 20, 2025 at 08:34, "Cong Wang" wrote: > > On Mon, Mar 17, 2025 at 05:22:55PM +0800, Jiayuan Chen wrote: > > > > > There are potential concurrency issues, as shown below. > > > > ''' > > > > CPU0 CPU1 > > > > sk_psock_verdict_data_ready: > > > > socket *sock = sk->sk_socket > > >

Re: [PATCH 1/3] rcu: Replace magic number with meaningful constant in rcu_seq_done_exact()

2025-03-26 Thread Joel Fernandes
> On Mar 26, 2025, at 6:33 PM, Paul E. McKenney wrote: > > On Mon, Mar 24, 2025 at 01:01:53PM -0400, Joel Fernandes wrote: >> The rcu_seq_done_exact() function checks if a grace period has completed by >> comparing sequence numbers. It includes a guard band to handle sequence >> number >> wra

Re: [PATCH 2/3] rcu: Add warning to ensure rcu_seq_done_exact() is working

2025-03-26 Thread Joel Fernandes
> On Mar 26, 2025, at 6:36 PM, Paul E. McKenney wrote: > > On Mon, Mar 24, 2025 at 01:01:54PM -0400, Joel Fernandes wrote: >> The previous patch improved the rcu_seq_done_exact() function by adding >> a meaningful constant for the guardband. >> >> Ensure that this is working for the future by

Re: [PATCH v2 0/4] tools/nolibc: MIPS: entrypoint cleanups and N32/N64 ABIs

2025-03-26 Thread Sebastian Andrzej Siewior
On 2025-03-26 22:51:54 [+0100], Thomas Weißschuh wrote: > > mips32le works as-is. > > For mips64le I had to s/-march=mips64r6/-march=mips64r2 to match the > > ABI. Which makes me wonder: Why do do we need to pass -march here and > > can't rely on toolchain defaults? > > The goal here is to have an

Re: [PATCH 2/3] rcu: Add warning to ensure rcu_seq_done_exact() is working

2025-03-26 Thread Paul E. McKenney
On Mon, Mar 24, 2025 at 01:01:54PM -0400, Joel Fernandes wrote: > The previous patch improved the rcu_seq_done_exact() function by adding > a meaningful constant for the guardband. > > Ensure that this is working for the future by a quick check during > rcu_gp_init(). > > Signed-off-by: Joel Fern

Re: [PATCH 3/3] rcu: Comment on the extraneous delta test on rcu_seq_done_exact()

2025-03-26 Thread Paul E. McKenney
On Mon, Mar 24, 2025 at 01:01:55PM -0400, Joel Fernandes wrote: > From: Frederic Weisbecker > > The numbers used in rcu_seq_done_exact() lack some explanation behind > their magic. Especially after the commit: > > 85aad7cc4178 ("rcu: Fix get_state_synchronize_rcu_full() GP-start > detection

Re: [PATCH 1/3] rcu: Replace magic number with meaningful constant in rcu_seq_done_exact()

2025-03-26 Thread Paul E. McKenney
On Mon, Mar 24, 2025 at 01:01:53PM -0400, Joel Fernandes wrote: > The rcu_seq_done_exact() function checks if a grace period has completed by > comparing sequence numbers. It includes a guard band to handle sequence number > wraparound, which was previously expressed using the magic number calculat

Re: [PATCH v2 01/10] vhost-scsi: protect vq->log_used with vq->mutex

2025-03-26 Thread Mike Christie
On 3/17/25 6:55 PM, Dongli Zhang wrote: > The vhost-scsi completion path may access vq->log_base when vq->log_used is > already set to false. > > vhost-thread QEMU-thread > > vhost_scsi_complete_cmd_work() > -> vhost_add_used() >-> vhost_add_used_n() > if (unli

Re: [PATCH v2 03/10] vhost-scsi: Fix vhost_scsi_send_status()

2025-03-26 Thread Mike Christie
On 3/17/25 6:55 PM, Dongli Zhang wrote: > Although the support of VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 was > signaled by the commit 664ed90e621c ("vhost/scsi: Set > VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 feature bits"), > vhost_scsi_send_bad_target() still assumes the response in a single > d

Re: [PATCH v2 02/10] vhost-scsi: Fix vhost_scsi_send_bad_target()

2025-03-26 Thread Mike Christie
On 3/17/25 6:55 PM, Dongli Zhang wrote: > Although the support of VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 was > signaled by the commit 664ed90e621c ("vhost/scsi: Set > VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 feature bits"), > vhost_scsi_send_bad_target() still assumes the response in a single > d

Re: [PATCH v2 0/4] tools/nolibc: MIPS: entrypoint cleanups and N32/N64 ABIs

2025-03-26 Thread Thomas Weißschuh
On 2025-03-26 21:54:34+0100, Sebastian Andrzej Siewior wrote: > On 2025-02-25 18:02:34 [+0100], Thomas Weißschuh wrote: > > Introduce support for the N32 and N64 ABIs. As preparation, the > > entrypoint is first simplified significantly. Thanks to Maciej for all > > the valuable information. > > >

Re: [PATCH v4 21/38] KVM: x86/pmu/vmx: Save/load guest IA32_PERF_GLOBAL_CTRL with vm_exit/entry_ctrl

2025-03-26 Thread Mingwei Zhang
On Wed, Mar 26, 2025 at 9:51 AM Chen, Zide wrote: > > > > On 3/24/2025 10:31 AM, Mingwei Zhang wrote: > > From: Dapeng Mi > > > > Intel processor (vmx) provides capability to save/load guest > > IA32_PERF_GLOBAL_CTRL at vm-exit/vm-entry by setting > > VM_EXIT_SAVE_IA32_PERF_GLOBAL_CTRL bit in VM-

Re: [PATCH v2 0/4] tools/nolibc: MIPS: entrypoint cleanups and N32/N64 ABIs

2025-03-26 Thread Sebastian Andrzej Siewior
On 2025-02-25 18:02:34 [+0100], Thomas Weißschuh wrote: > Introduce support for the N32 and N64 ABIs. As preparation, the > entrypoint is first simplified significantly. Thanks to Maciej for all > the valuable information. > > Signed-off-by: Thomas Weißschuh Tested-by: Sebastian Andrzej Siewior

Re: [RFC PATCH v3 5/8] KVM: arm64: Introduce module param to partition the PMU

2025-03-26 Thread Oliver Upton
On Wed, Mar 26, 2025 at 05:38:34PM +, James Clark wrote: > On 25/03/2025 6:32 pm, Colton Lewis wrote: > > > I don't know if this is a stupid idea, but instead of having a fixed > > > number for the partition, wouldn't it be nice if we could trap and > > > increment HPMN on the first guest use o

Re: [PATCH v3 3/3] openrisc: Add cacheinfo support

2025-03-26 Thread Stafford Horne
On Mon, Mar 24, 2025 at 01:25:44AM +0530, Sahil Siddiq wrote: > Add cacheinfo support for OpenRISC. > > Currently, a few CPU cache attributes pertaining to OpenRISC processors > are exposed along with other unrelated CPU attributes in the procfs file > system (/proc/cpuinfo). However, a few cache

Re: [PATCH 4/4] x86/sgx: Implement ENCLS[EUPDATESVN] and opportunistically call it during first EPC page alloc

2025-03-26 Thread Jarkko Sakkinen
On Mon, Mar 24, 2025 at 12:26:38PM +, Reshetova, Elena wrote: > > > On Fri, Mar 21, 2025 at 02:34:43PM +0200, Elena Reshetova wrote: > > > SGX architecture introduced a new instruction called EUPDATESVN [1] > > > to Ice Lake. It allows updating security SVN version, given that EPC > > > is co

Re: [PATCH 3/4] x86/sgx: Define error codes for ENCLS[EUPDATESVN]

2025-03-26 Thread Jarkko Sakkinen
On Mon, Mar 24, 2025 at 12:21:14PM +, Reshetova, Elena wrote: > > > > On Fri, Mar 21, 2025 at 02:34:42PM +0200, Elena Reshetova wrote: > > > Add error codes for ENCLS[EUPDATESVN], then SGX CPUSVN update > > > process can know the execution state of EUPDATESVN. > > > > > > > Enumerate the err

Re: [PATCH net-next v2 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests

2025-03-26 Thread Jakub Kicinski
On Wed, 26 Mar 2025 19:48:16 + Dmitry Safonov wrote: > On Tue, 25 Mar 2025 at 13:15, Jakub Kicinski wrote: > > > > On Wed, 19 Mar 2025 03:13:33 + Dmitry Safonov via B4 Relay wrote: > > > Should fix flaky tcp-ao/connect-deny-ipv6 test. > > > Begging pardon for the delay since the report a

Re: [PATCH net-next v2 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests

2025-03-26 Thread Dmitry Safonov
On Tue, 25 Mar 2025 at 13:15, Jakub Kicinski wrote: > > On Wed, 19 Mar 2025 03:13:33 + Dmitry Safonov via B4 Relay wrote: > > Should fix flaky tcp-ao/connect-deny-ipv6 test. > > Begging pardon for the delay since the report and for sending it this > > late in the release cycle. > > Better late

Re: [PATCH 1/4] x86/sgx: Add total number of EPC pages

2025-03-26 Thread Jarkko Sakkinen
On Mon, Mar 24, 2025 at 12:12:41PM +, Reshetova, Elena wrote: > > On Fri, Mar 21, 2025 at 02:34:40PM +0200, Elena Reshetova wrote: > > > In order to successfully execute ENCLS[EUPDATESVN], EPC must be empty. > > > SGX already has a variable sgx_nr_free_pages that tracks free > > > EPC pages. Ad

Re: [PATCH v2 2/2] KVM: selftests: access_tracking_perf_test: add option to skip the sanity check

2025-03-26 Thread Maxim Levitsky
On Tue, 2025-03-25 at 11:01 -0700, James Houghton wrote: > On Mon, Mar 24, 2025 at 6:57 PM Maxim Levitsky wrote: > > Add an option to skip sanity check of number of still idle pages, > > and set it by default to skip, in case hypervisor or NUMA balancing > > is detected. > > > > Signed-off-by: Ma

Re: [PATCH v2 2/2] KVM: selftests: access_tracking_perf_test: add option to skip the sanity check

2025-03-26 Thread Sean Christopherson
On Wed, Mar 26, 2025, James Houghton wrote: > On Wed, Mar 26, 2025 at 11:41 AM Sean Christopherson > wrote: > > Then the auto resolving works as below, and as James pointed out, the assert > > becomes > > > > TEST_ASSERT(!warn_only, ); > > I think the auto-resolving below nee

bug report for linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c

2025-03-26 Thread David Binderman
Hello there, Static analyser cppcheck says: > linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c:1061:11: style: int > result is assigned to long long variable. If the variable is long long to > avoid loss of information, then you have loss of information. > [truncLongCastAssignment] > linu

Re: [PATCH v1] selftests/mm/cow: fix minor memory leak in child_vmsplice_memcmp_fn()

2025-03-26 Thread David Hildenbrand
On 25.03.25 19:22, Malaya Kumar Rout wrote: Static Analyis for cow.c: error Exception branch exits without releasing memory 'old' and 'new' fix the issue by releasing the allocated memory. Signed-off-by: Malaya Kumar Rout --- https://lore.kernel.org/linux-mm/20230404031256.78330-1-jiangf...@

Re: [PATCH v2 2/2] KVM: selftests: access_tracking_perf_test: add option to skip the sanity check

2025-03-26 Thread James Houghton
On Wed, Mar 26, 2025 at 11:41 AM Sean Christopherson wrote: > > On Tue, Mar 25, 2025, James Houghton wrote: > > On Mon, Mar 24, 2025 at 6:57 PM Maxim Levitsky wrote: > > > > > > Add an option to skip sanity check of number of still idle pages, > > > and set it by default to skip, in case hypervis

Re: [PATCH 2/3] of: Simplify of_dma_set_restricted_buffer() to use of_for_each_phandle()

2025-03-26 Thread Rob Herring
On Wed, Mar 26, 2025 at 1:44 AM Chen-Yu Tsai wrote: > > Hi, > > On Tue, Mar 18, 2025 at 7:29 AM Rob Herring (Arm) wrote: > > > > Simplify of_dma_set_restricted_buffer() by using of_property_present() > > and of_for_each_phandle() iterator. > > > > Signed-off-by: Rob Herring (Arm) > > --- > > dr

Re: [PATCH v2 2/2] KVM: selftests: access_tracking_perf_test: add option to skip the sanity check

2025-03-26 Thread Sean Christopherson
On Tue, Mar 25, 2025, James Houghton wrote: > On Mon, Mar 24, 2025 at 6:57 PM Maxim Levitsky wrote: > > > > Add an option to skip sanity check of number of still idle pages, > > and set it by default to skip, in case hypervisor or NUMA balancing > > is detected. > > > > Signed-off-by: Maxim Levits

Re: [PATCH v4] hrtimers: Force migrate away hrtimers queued after CPUHP_AP_HRTIMERS_DYING

2025-03-26 Thread Frederic Weisbecker
Hi Walter Chang, Le Wed, Mar 26, 2025 at 05:46:38AM +, Walter Chang (張維哲) a écrit : > On Tue, 2025-01-21 at 09:08 -0800, Paul E. McKenney wrote: > > On Sat, Jan 18, 2025 at 12:24:33AM +0100, Frederic Weisbecker wrote: > > > hrtimers are migrated away from the dying CPU to any online target > >

[PATCH v3] rpmsg: qcom_smd: Improve error handling for qcom_smd_parse_edge

2025-03-26 Thread Luca Weiss
When the mailbox driver has not probed yet, the error message "failed to parse smd edge" is just going to confuse users, so improve the error prints a bit. Cover the last remaining exits from qcom_smd_parse_edge with proper error prints, especially the one for the mbox_chan deserved dev_err_probe

Re: [PATCH 1/2] dt-bindings: remoteproc: stm32-rproc: Add firmware-name property

2025-03-26 Thread Conor Dooley
On Wed, Mar 26, 2025 at 09:39:11AM +0100, Arnaud Pouliquen wrote: > Add the 'firmware-name' property to the remote processor binding > to allow specifying the default firmware name in the device tree. > > Signed-off-by: Arnaud Pouliquen > --- > .../devicetree/bindings/remoteproc/st,stm32-rproc.y

Re: [RFC PATCH v3 5/8] KVM: arm64: Introduce module param to partition the PMU

2025-03-26 Thread James Clark
On 25/03/2025 6:32 pm, Colton Lewis wrote: Hi James, Thanks for the review. James Clark writes: On 13/02/2025 6:03 pm, Colton Lewis wrote: For PMUv3, the register MDCR_EL2.HPMN partitiones the PMU counters into two ranges where counters 0..HPMN-1 are accessible by EL1 and, if allowed, EL

Re: [PATCH v3 2/3] openrisc: Introduce new utility functions to flush and invalidate caches

2025-03-26 Thread Stafford Horne
On Mon, Mar 24, 2025 at 01:25:43AM +0530, Sahil Siddiq wrote: > According to the OpenRISC architecture manual, the dcache and icache may > not be present. When these caches are present, the invalidate and flush > registers may be absent. The current implementation does not perform > checks to verif

Re: [PATCH v4 21/38] KVM: x86/pmu/vmx: Save/load guest IA32_PERF_GLOBAL_CTRL with vm_exit/entry_ctrl

2025-03-26 Thread Chen, Zide
On 3/24/2025 10:31 AM, Mingwei Zhang wrote: > From: Dapeng Mi > > Intel processor (vmx) provides capability to save/load guest > IA32_PERF_GLOBAL_CTRL at vm-exit/vm-entry by setting > VM_EXIT_SAVE_IA32_PERF_GLOBAL_CTRL bit in VM-exit-ctrl or > VM_ENTRY_LOAD_IA32_PERF_GLOBAL_CTRL bit in VM-entr

Re: [PATCH v3 1/3] openrisc: Refactor struct cpuinfo_or1k to reduce duplication

2025-03-26 Thread Stafford Horne
On Mon, Mar 24, 2025 at 01:25:42AM +0530, Sahil Siddiq wrote: > The "cpuinfo_or1k" structure currently has identical data members for > different cache components. > > Remove these fields out of struct cpuinfo_or1k and into its own struct. > This reduces duplication while keeping cpuinfo_or1k exte

Re: [PATCH 15/19] virtio_ring: factor out core logic of buffer detaching

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 7:01 AM Jason Wang wrote: > > Factor out core logic of buffer detaching and leave the id population > to the caller so in order can just call the core logic. > Acked-by: Eugenio Pérez > Signed-off-by: Jason Wang > --- > drivers/virtio/virtio_ring.c | 17 +--

Re: [PATCH net-next v2] vsock/test: Add test for null ptr deref when transport changes

2025-03-26 Thread Stefano Garzarella
On Wed, Mar 26, 2025 at 04:14:20PM +0100, Luigi Leonardi wrote: Hi Michal, On Wed, Mar 19, 2025 at 01:27:35AM +0100, Michal Luczaj wrote: On 3/14/25 10:27, Luigi Leonardi wrote: Add a new test to ensure that when the transport changes a null pointer dereference does not occur[1]. Note that th

Re: [RFC][PATCH] sched,livepatch: Untangle cond_resched() and live-patching

2025-03-26 Thread Miroslav Benes
> void __klp_sched_try_switch(void) > { > - if (likely(!klp_patch_pending(current))) > - return; > - > /* >* This function is called from cond_resched() which is called in many >* places throughout the kernel. Using the klp_mutex here might > @@ -377,14 +365

Re: [PATCH 13/19] virtio_ring: introduce virtqueue ops

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 7:01 AM Jason Wang wrote: > > This patch introduces virtqueue ops which is a set of the callbacks > that will be called for different queue layout or features. This would > help to avoid branches for split/packed and will ease the future > implementation like in order. > A

Re: [PATCH net-next v2] vsock/test: Add test for null ptr deref when transport changes

2025-03-26 Thread Luigi Leonardi
Hi Michal, On Wed, Mar 19, 2025 at 01:27:35AM +0100, Michal Luczaj wrote: On 3/14/25 10:27, Luigi Leonardi wrote: Add a new test to ensure that when the transport changes a null pointer dereference does not occur[1]. Note that this test does not fail, but it may hang on the client side if it t

[PATCH] selftests: vDSO: vdso_standalone_test_x86: Replace source file with symlink

2025-03-26 Thread Thomas Weißschuh
ne_test_x86.c @@ -0,0 +1 @@ +vdso_test_gettimeofday.c \ No newline at end of file --- base-commit: 1e26c5e28ca5821a824e90dd359556f5e9e7b89f change-id: 20250326-vdso-selftests-fix-vdso_standalone_test_x86-c3a77b57ccbd Best regards, -- Thomas Weißschuh

Re: [RFC][PATCH] sched,livepatch: Untangle cond_resched() and live-patching

2025-03-26 Thread Peter Zijlstra
On Wed, Mar 26, 2025 at 03:37:50PM +0100, Miroslav Benes wrote: > If I remember correctly, we had something like this in the old kGraft > implementation of the live patching (SUSE way). We exactly had a hook > somewhere in the kthread freezing code. This looks much cleaner and as far > as I kno

Re: [RFC][PATCH] sched,livepatch: Untangle cond_resched() and live-patching

2025-03-26 Thread Miroslav Benes
On Wed, 26 Mar 2025, Peter Zijlstra wrote: > On Wed, Mar 26, 2025 at 03:37:50PM +0100, Miroslav Benes wrote: > > > If I remember correctly, we had something like this in the old kGraft > > implementation of the live patching (SUSE way). We exactly had a hook > > somewhere in the kthread freezin

Re: [RFC][PATCH] sched,livepatch: Untangle cond_resched() and live-patching

2025-03-26 Thread Miroslav Benes
Hi, On Wed, 26 Mar 2025, Peter Zijlstra wrote: > On Wed, Mar 26, 2025 at 10:49:10AM +0100, Petr Mladek wrote: > > On Mon 2025-03-24 14:49:09, Peter Zijlstra wrote: > > > > > > With the goal of deprecating / removing VOLUNTARY preempt, live-patch > > > needs to stop relying on cond_resched() to m

Re: [PATCH 18/19] virtio_ring: factor out split indirect detaching logic

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 7:02 AM Jason Wang wrote: > > Factor out the split indirect descriptor detaching logic in order to > make it be reused by the in order support. > Acked-by: Eugenio Pérez > Signed-off-by: Jason Wang > --- > drivers/virtio/virtio_ring.c | 63 -

Re: [PATCH 17/19] virtio_ring: move next_avail_idx to vring_virtqueue

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 7:01 AM Jason Wang wrote: > > This variable is used by packed virtqueue now, moving it to > vring_virtqueue to make it possible to be reused by split virtqueue > in-order implementation. > Acked-by: Eugenio Pérez > Signed-off-by: Jason Wang > --- > drivers/virtio/virti

Re: [PATCH 16/19] virtio_ring: factor out core logic for updating last_used_idx

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 7:01 AM Jason Wang wrote: > > Factor out the core logic for updating last_used_idx to be reused by > the packed in order implementation. > Acked-by: Eugenio Pérez > Signed-off-by: Jason Wang > --- > drivers/virtio/virtio_ring.c | 43 +---

Re: [PATCH 14/19] virtio_ring: determine descriptor flags at one time

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 7:01 AM Jason Wang wrote: > > Let's determine the last descriptor by counting the number of sg. This > would be consistent with packed virtqueue implementation and ease the > future in-order implementation. > Acked-by: Eugenio Pérez > Signed-off-by: Jason Wang > --- >

Re: [PATCH net-next v24 09/23] ovpn: implement packet processing

2025-03-26 Thread Antonio Quartulli
On 26/03/2025 13:43, Qingfang Deng wrote: On Wed, Mar 26, 2025 at 6:22 PM Antonio Quartulli wrote: This is not what we want. Got it. You could replace it with atomic_fetch_add_unless(&pid->seq_num, 1, 0) and check if it wraps around to zero. What about the first time when seq_num is 0? It w

Re: [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-26 Thread Miroslav Benes
On Thu, 20 Mar 2025, Song Liu wrote: > With proper exception boundary detection, it is possible to implment > arch_stack_walk_reliable without sframe. > > Note that, arch_stack_walk_reliable does not guarantee getting reliable > stack in all scenarios. Instead, it can reliably detect when the sta

Re: [PATCH 08/19] virtio_ring: switch to use vring_virtqueue for enable_cb_prepare variants

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 6:44 AM Jason Wang wrote: > > Those variants are used internally so let's switch to use > vring_virtqueue as parameter to be consistent with other internal > virtqueue helpers. > Acked-by: Eugenio Pérez > Signed-off-by: Jason Wang > --- > drivers/virtio/virtio_ring.c |

Re: [PATCH v2 12/16] selftests: vDSO: parse_vdso: Use UAPI headers instead of libc headers

2025-03-26 Thread Mark Brown
On Thu, Mar 20, 2025 at 01:23:47PM +, Mark Brown wrote: > On Wed, Feb 26, 2025 at 12:44:51PM +0100, Thomas Weißschuh wrote: > > To allow the usage of parse_vdso.c together with a limited libc like > > nolibc, use the kernels own elf.h and auxvec.h headers. > The vDSO selftests currently fail b

Re: [PATCH 12/19] virtio_ring: use u16 for last_used_idx in virtqueue_poll_split()

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 6:44 AM Jason Wang wrote: > > Use u16 for last_used_idx in virtqueue_poll_split() to align with the > spec. > > Signed-off-by: Jason Wang > --- > drivers/virtio/virtio_ring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_ri

Re: [PATCH net-next v24 09/23] ovpn: implement packet processing

2025-03-26 Thread Qingfang Deng
On Wed, Mar 26, 2025 at 6:22 PM Antonio Quartulli wrote: > >> This is not what we want. > > > > Got it. You could replace it with > > atomic_fetch_add_unless(&pid->seq_num, 1, 0) and check if it wraps > > around to zero. > > What about the first time when seq_num is 0? It will already stop, no? T

Re: [PATCH 5/5] rcu/exp: Warn on CPU lagging for too long within hotplug IPI's blindspot

2025-03-26 Thread Paul E. McKenney
On Wed, Mar 19, 2025 at 10:42:38AM +0100, Frederic Weisbecker wrote: > Le Tue, Mar 18, 2025 at 10:22:33AM -0700, Paul E. McKenney a écrit : > > On Fri, Mar 14, 2025 at 03:36:42PM +0100, Frederic Weisbecker wrote: > > > A CPU within hotplug operations can make the RCU exp kworker lagging if: > > >

Re: [PATCH 11/19] virtio_ring: switch to use vring_virtqueue for detach_unused_buf variants

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 6:44 AM Jason Wang wrote: > > Those variants are used internally so let's switch to use > vring_virtqueue as parameter to be consistent with other internal > virtqueue helpers. > Acked-by: Eugenio Pérez > Signed-off-by: Jason Wang > --- > drivers/virtio/virtio_ring.c |

Re: [PATCH 09/19] virtio_ring: use vring_virtqueue for enable_cb_delayed variants

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 6:44 AM Jason Wang wrote: > > Those variants are used internally so let's switch to use > vring_virtqueue as parameter to be consistent with other internal > virtqueue helpers. > Acked-by: Eugenio Pérez > Signed-off-by: Jason Wang > --- > drivers/virtio/virtio_ring.c |

Re: [PATCH 06/19] virtio_ring: switch to use vring_virtqueue for virtqueue_add variants

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 6:44 AM Jason Wang wrote: > > Those variants are used internally so let's switch to use > vring_virtqueue as parameter to be consistent with other internal > virtqueue helpers. > > Signed-off-by: Jason Wang Acked-by: Eugenio Pérez > --- > drivers/virtio/virtio_ring.c |

Re: [PATCH 10/19] virtio_ring: switch to use vring_virtqueue for disable_cb variants

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 6:44 AM Jason Wang wrote: > > Those variants are used internally so let's switch to use > vring_virtqueue as parameter to be consistent with other internal > virtqueue helpers. > Acked-by: Eugenio Pérez > Signed-off-by: Jason Wang > --- > drivers/virtio/virtio_ring.c |

Re: [PATCH 07/19] virtio: switch to use vring_virtqueue for virtqueue_add variants

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 6:44 AM Jason Wang wrote: > > Those variants are used internally so let's switch to use > vring_virtqueue as parameter to be consistent with other internal > virtqueue helpers. > > Signed-off-by: Jason Wang Acked-by: Eugenio Pérez > --- > drivers/virtio/virtio_ring.c |

Re: [PATCH 05/19] virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare variants

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 6:44 AM Jason Wang wrote: > > Those variants are used internally so let's switch to use > vring_virtqueue as parameter to be consistent with other internal > virtqueue helpers. > > Signed-off-by: Jason Wang Acked-by: Eugenio Pérez > --- > drivers/virtio/virtio_ring.c |

Re: [PATCH 04/19] virtio_ring: switch to use vring_virtqueue for virtqueue resize variants

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 6:44 AM Jason Wang wrote: > > Those variants are used internally so let's switch to use > vring_virtqueue as parameter to be consistent with other internal > virtqueue helpers. > > Signed-off-by: Jason Wang Acked-by: Eugenio Pérez > --- > drivers/virtio/virtio_ring.c |

Re: [PATCH 02/19] virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 6:43 AM Jason Wang wrote: > > Those variants are used internally so let's switch to use > vring_virtqueue as parameter to be consistent with other internal > virtqueue helpers. > > Signed-off-by: Jason Wang Acked-by: Eugenio Pérez > --- > drivers/virtio/virtio_ring.c |

Re: [PATCH 01/19] virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx()

2025-03-26 Thread Eugenio Perez Martin
On Mon, Mar 24, 2025 at 6:43 AM Jason Wang wrote: > > To be consistent with virtqueue_reset(). > > Signed-off-by: Jason Wang Acked-by: Eugenio Pérez > --- > drivers/virtio/virtio_ring.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/virtio/virtio

Re: [RFC][PATCH] sched,livepatch: Untangle cond_resched() and live-patching

2025-03-26 Thread Petr Mladek
On Mon 2025-03-24 14:49:09, Peter Zijlstra wrote: > > With the goal of deprecating / removing VOLUNTARY preempt, live-patch > needs to stop relying on cond_resched() to make forward progress. > > Instead, rely on schedule() with TASK_FREEZABLE set. Just like > live-patching, the freezer needs to

Re: [RFC][PATCH] sched,livepatch: Untangle cond_resched() and live-patching

2025-03-26 Thread Peter Zijlstra
On Wed, Mar 26, 2025 at 10:49:10AM +0100, Petr Mladek wrote: > On Mon 2025-03-24 14:49:09, Peter Zijlstra wrote: > > > > With the goal of deprecating / removing VOLUNTARY preempt, live-patch > > needs to stop relying on cond_resched() to make forward progress. > > > > Instead, rely on schedule()

Re: [PATCH net-next v24 09/23] ovpn: implement packet processing

2025-03-26 Thread Qingfang Deng
Hi Antonio, On Wed, Mar 26, 2025 at 5:41 PM Antonio Quartulli wrote: > >> +/* Get the next packet ID for xmit */ > >> +static inline int ovpn_pktid_xmit_next(struct ovpn_pktid_xmit *pid, u32 > >> *pktid) > >> +{ > >> +const s64 seq_num = atomic64_fetch_add_unless(&pid->seq_num, 1, > >> +

Re: [PATCH v3 1/7] dt-bindings: input: syna,rmi4: document syna,pdt-fallback-desc

2025-03-26 Thread Caleb Connolly
On 3/26/25 07:57, Krzysztof Kozlowski wrote: On 25/03/2025 14:23, Caleb Connolly wrote: On 3/25/25 08:36, Krzysztof Kozlowski wrote: On 24/03/2025 19:00, David Heidelberg wrote: On 10/03/2025 10:45, Krzysztof Kozlowski wrote: On Sat, Mar 08, 2025 at 03:08:37PM +0100, David Heidelberg wro

Re: [PATCH net-next v24 09/23] ovpn: implement packet processing

2025-03-26 Thread Antonio Quartulli
On 26/03/2025 11:03, Qingfang Deng wrote: Hi Antonio, On Wed, Mar 26, 2025 at 5:41 PM Antonio Quartulli wrote: +/* Get the next packet ID for xmit */ +static inline int ovpn_pktid_xmit_next(struct ovpn_pktid_xmit *pid, u32 *pktid) +{ +const s64 seq_num = atomic64_fetch_add_unless(&pid->seq

Re: [PATCH v2] openrisc: Add cacheinfo support

2025-03-26 Thread Stafford Horne
On Sat, Mar 22, 2025 at 07:21:18PM +0530, Sahil Siddiq wrote: > Hi Stafford, > > On 3/18/25 1:13 PM, Stafford Horne wrote: > > On Tue, Mar 18, 2025 at 12:06:30AM +0530, Sahil Siddiq wrote: > > > On 3/17/25 1:55 PM, Geert Uytterhoeven wrote: > > > > On Sun, 16 Mar 2025 at 07:59, Stafford Horne wro

Re: [PATCH v2] selftests/ptrace/get_syscall_info: fix for MIPS n32

2025-03-26 Thread Dmitry V. Levin
Could somebody pick up this patch, please? Nothing has changed since v2, so I have nothing new to add. v2: https://lore.kernel.org/all/20250115233747.ga28...@strace.io/ On Thu, Jan 16, 2025 at 01:37:47AM +0200, Dmitry V. Levin wrote: > MIPS n32 is one of two ILP32 architectures supported by the

Re: [PATCH net-next v24 09/23] ovpn: implement packet processing

2025-03-26 Thread Antonio Quartulli
On 25/03/2025 03:07, Qingfang Deng wrote: [...] -static void ovpn_decrypt_post(struct sk_buff *skb, int ret) +void ovpn_decrypt_post(void *data, int ret) { - struct ovpn_peer *peer = ovpn_skb_cb(skb)->peer; + struct ovpn_crypto_key_slot *ks; + unsigned int payload_offset = 0;

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-26 Thread Mark Brown
On Wed, Mar 19, 2025 at 05:05:39PM -0600, Nico Pache wrote: > FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather > depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the > depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit tooling. > config FW_CS_DSP_KUNI

[PATCH 2/2] drivers: remoteproc: stm32_rproc: Allow to specify firmware default name

2025-03-26 Thread Arnaud Pouliquen
Enhance the stm32_rproc driver to allow enabling the configuration of the firmware name based on the 'firmware-name' property in the device tree, offering flexibility compared to using the remote proc device node name. Signed-off-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 8

[PATCH 1/2] dt-bindings: remoteproc: stm32-rproc: Add firmware-name property

2025-03-26 Thread Arnaud Pouliquen
Add the 'firmware-name' property to the remote processor binding to allow specifying the default firmware name in the device tree. Signed-off-by: Arnaud Pouliquen --- .../devicetree/bindings/remoteproc/st,stm32-rproc.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentati

Re: [PATCH v3 1/7] dt-bindings: input: syna,rmi4: document syna,pdt-fallback-desc

2025-03-26 Thread Krzysztof Kozlowski
On 25/03/2025 14:23, Caleb Connolly wrote: > > > On 3/25/25 08:36, Krzysztof Kozlowski wrote: >> On 24/03/2025 19:00, David Heidelberg wrote: >>> On 10/03/2025 10:45, Krzysztof Kozlowski wrote: On Sat, Mar 08, 2025 at 03:08:37PM +0100, David Heidelberg wrote: > From: Caleb Connolly

Re: [PATCH v4 08/16] rust: kunit: refactor to use `&raw [const|mut]`

2025-03-26 Thread Boqun Feng
On Fri, Mar 21, 2025 at 10:28:06AM +0800, David Gow wrote: [...] > > Anyway, KUnit `#[test]`s are in -- I was not planning to merge this > > now anyway, it should be reviewed a bit more. > I agree this whole series should wait a bit, but do we want to merge patch #1 as early as possible (maybe ri