Re: [PATCH 2/2] input/touchscreen: imagis: document ist3038h

2025-02-24 Thread Krzysztof Kozlowski
On 24/02/2025 10:03, Andras Sebok wrote: > Signed-off-by: Andras Sebok > --- > .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 + Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory yo

Re: [PATCH RFC v2 06/10] slab: sheaf prefilling for guaranteed allocations

2025-02-24 Thread Harry Yoo
On Sat, Feb 22, 2025 at 07:54:16PM -0800, Suren Baghdasaryan wrote: > On Fri, Feb 14, 2025 at 8:27 AM Vlastimil Babka wrote: > > > > Add functions for efficient guaranteed allocations e.g. in a critical > > section that cannot sleep, when the exact number of allocations is not > > known beforehand

Re: [PATCH v6 1/3] x86/paravirt: Move halt paravirt calls under CONFIG_PARAVIRT

2025-02-24 Thread Juergen Gross
On 25.02.25 01:47, Vishal Annapurve wrote: From: "Kirill A. Shutemov" CONFIG_PARAVIRT_XXL is mainly defined/used by XEN PV guests. For other VM guest types, features supported under CONFIG_PARAVIRT are self sufficient. CONFIG_PARAVIRT mainly provides support for TLB flush operations and time re

Re: [PATCH 2/2] Input: goodix-berlin - fix vddio regulator references

2025-02-24 Thread Dmitry Torokhov
On Fri, Jan 03, 2025 at 10:21:36AM +0100, Luca Weiss wrote: > As per dt-bindings the property is called vddio-supply, so use the > correct name in the driver instead of iovdd. The datasheet also calls > the supply 'VDDIO'. > > Fixes: 44362279bdd4 ("Input: add core support for Goodix Berlin Touchsc

Re: [PATCH 1/2] Input: goodix-berlin - fix comment referencing wrong regulator

2025-02-24 Thread Dmitry Torokhov
On Fri, Jan 03, 2025 at 10:21:35AM +0100, Luca Weiss wrote: > In the statement above AVDD gets enabled, and not IOVDD, so fix this > copy-paste mistake. > > Fixes: 44362279bdd4 ("Input: add core support for Goodix Berlin Touchscreen > IC") > Reported-by: Jens Reidel > Signed-off-by: Luca Weiss

Re: [PATCH 2/2] input/touchscreen: imagis: document ist3038h

2025-02-24 Thread Dmitry Torokhov
On Mon, Feb 24, 2025 at 10:03:56AM +0100, Andras Sebok wrote: > Signed-off-by: Andras Sebok Applied after updating commit description, thank you. -- Dmitry

Re: [PATCH 1/2] input/touchscreen: imagis: add support for imagis IST3038H

2025-02-24 Thread Dmitry Torokhov
On Mon, Feb 24, 2025 at 10:03:54AM +0100, Andras Sebok wrote: > Adds support for imagis IST3038H, simular to IST3038C. > Tested on samsung,j5y17lte. > > Signed-off-by: Andras Sebok Applied after updating commit description a bit, thank you. -- Dmitry

Re: [PATCH v7 5/6] rust: str: add radix prefixed integer parsing functions

2025-02-24 Thread Andreas Hindborg
"Janne Grunau" writes: > On Tue, Feb 18, 2025 at 02:00:47PM +0100, Andreas Hindborg wrote: >> Add the trait `ParseInt` for parsing string representations of integers >> where the string representations are optionally prefixed by a radix >> specifier. Implement the trait for the primitive integer

Re: [PATCH v7 07/16] rust: add `io::{Io, IoRaw}` base types

2025-02-24 Thread Alistair Popple
On Fri, Feb 21, 2025 at 04:58:59AM +0100, Miguel Ojeda wrote: > Hi Alistair, > > On Fri, Feb 21, 2025 at 2:20 AM Alistair Popple wrote: > > > > Is this a known issue or limitation? Or is this a bug/rough edge that still > > needs fixing? Or alternatively am I just doing something wrong? Would >

Re: [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss

2025-02-24 Thread Dmitry Baryshkov
On Mon, Feb 24, 2025 at 09:43:48PM +0100, Luca Weiss wrote: > On 24-02-2025 9:27 p.m., Konrad Dybcio wrote: > > On 24.02.2025 1:17 AM, Dmitry Baryshkov wrote: > > > On Sat, Feb 22, 2025 at 02:00:49PM +0100, Luca Weiss wrote: > > > > Set the paths where the device-specific firmware can be found for

Re: [PATCH 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable modem

2025-02-24 Thread Dmitry Baryshkov
On Mon, Feb 24, 2025 at 02:18:55AM +0200, Dmitry Baryshkov wrote: > On Sat, Feb 22, 2025 at 02:00:50PM +0100, Luca Weiss wrote: > > Add the necessary supplies and set an appropriete firmware-name for the > > Nit: appropriate > > > modem and enable it. > > > > Signed-off-by: Luca Weiss > > --- >

Re: [PATCH v6 3/6] vhost: Add the cgroup related function

2025-02-24 Thread kernel test robot
Hi Cindy, kernel test robot noticed the following build warnings: [auto build test WARNING on v6.14-rc3] [also build test WARNING on linus/master next-20250224] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

[PATCH net-next v4 4/4] virtio-net: Use persistent NAPI config

2025-02-24 Thread Joe Damato
Use persistent NAPI config so that NAPI IDs are not renumbered as queue counts change. $ sudo ethtool -l ens4 | tail -5 | egrep -i '(current|combined)' Current hardware settings: Combined: 4 $ ./tools/net/ynl/pyynl/cli.py \ --spec Documentation/netlink/specs/netdev.yaml \ --dump qu

[PATCH net-next v4 3/4] virtio-net: Map NAPIs to queues

2025-02-24 Thread Joe Damato
Use netif_queue_set_napi to map NAPIs to queue IDs so that the mapping can be accessed by user apps, taking care to hold RTNL as needed. $ ethtool -i ens4 | grep driver driver: virtio_net $ sudo ethtool -L ens4 combined 4 $ ./tools/net/ynl/pyynl/cli.py \ --spec Documentation/netlink/specs

[PATCH net-next v4 2/4] virtio-net: Refactor napi_disable paths

2025-02-24 Thread Joe Damato
Create virtnet_napi_disable helper and refactor virtnet_napi_tx_disable to take a struct send_queue. Signed-off-by: Joe Damato --- drivers/net/virtio_net.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio

[PATCH net-next v4 1/4] virtio-net: Refactor napi_enable paths

2025-02-24 Thread Joe Damato
Refactor virtnet_napi_enable and virtnet_napi_tx_enable to take a struct receive_queue. Create a helper, virtnet_napi_do_enable, which contains the logic to enable a NAPI. Signed-off-by: Joe Damato --- drivers/net/virtio_net.c | 37 + 1 file changed, 21 insert

[PATCH net-next v4 0/4] virtio-net: Link queues to NAPIs

2025-02-24 Thread Joe Damato
Greetings: Welcome to v4. Jakub recently commented [1] that I should not hold this series on virtio-net linking queues to NAPIs behind other important work that is on-going and suggested I re-spin, so here we are :) This is a significant refactor from the rfcv3 and as such I've dropped almost al

Re: [PATCH v7 5/6] rust: str: add radix prefixed integer parsing functions

2025-02-24 Thread Miguel Ojeda
On Mon, Feb 24, 2025 at 11:30 PM Janne Grunau wrote: > > The errors go away after exchanging i128 with i64 (while breaking the > parsing for large values). I don't think we can use 128-bit integers unconditionally for all architectures (we could eventually get it to work for some though). So we s

Re: Re: Re: Re: Re: [PATCH 2/2] libbpf: BPF programs dynamic loading and attaching

2025-02-24 Thread Slava Imameev
This reply was resent as the previous email had a missing In-Reply-To in the header. > > > On Mon, 2025-02-10 at 16:06 -0800, Andrii Nakryiko wrote: > > > > Tracking associated maps for a program is not necessary. As long as > > > > the last BPF program using the BPF map is unloaded, the kernel wi

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-24 Thread Weinan Liu
On Mon, Feb 10, 2025 at 12:30 AM Weinan Liu wrote: > I already have a WIP patch to add sframe support to the kernel module. > However, it is not yet working. I had trouble unwinding frames for the > kernel module using the current algorithm. > > Indu has likely identified the issue and will be add

Re: [PATCH RFC v2 00/10] SLUB percpu sheaves

2025-02-24 Thread Suren Baghdasaryan
On Mon, Feb 24, 2025 at 12:53 PM Vlastimil Babka wrote: > > On 2/24/25 02:36, Suren Baghdasaryan wrote: > > On Sat, Feb 22, 2025 at 8:44 PM Suren Baghdasaryan > > wrote: > >> > >> Don't know about this particular part but testing sheaves with maple > >> node cache and stress testing mmap/munmap

[PATCH v6 3/3] x86/tdx: Emit warning if IRQs are enabled during HLT #VE handling

2025-02-24 Thread Vishal Annapurve
Direct HLT instruction execution causes #VEs for TDX VMs which is routed to hypervisor via TDCALL. safe_halt() routines execute HLT in STI-shadow so IRQs need to remain disabled until the TDCALL to ensure that pending IRQs are correctly treated as wake events. Emit warning and fail emulation if IR

[PATCH v6 2/3] x86/tdx: Fix arch_safe_halt() execution for TDX VMs

2025-02-24 Thread Vishal Annapurve
Direct HLT instruction execution causes #VEs for TDX VMs which is routed to hypervisor via TDCALL. If HLT is executed in STI-shadow, resulting #VE handler will enable interrupts before TDCALL is routed to hypervisor leading to missed wakeup events. Current TDX spec doesn't expose interruptibility

[PATCH v6 1/3] x86/paravirt: Move halt paravirt calls under CONFIG_PARAVIRT

2025-02-24 Thread Vishal Annapurve
From: "Kirill A. Shutemov" CONFIG_PARAVIRT_XXL is mainly defined/used by XEN PV guests. For other VM guest types, features supported under CONFIG_PARAVIRT are self sufficient. CONFIG_PARAVIRT mainly provides support for TLB flush operations and time related operations. For TDX guest as well, par

[PATCH v6 0/3] x86/tdx: Fix HLT logic execution for TDX VMs

2025-02-24 Thread Vishal Annapurve
Direct HLT instruction execution causes #VEs for TDX VMs which is routed to hypervisor via TDCALL. safe_halt() routines execute HLT in STI-shadow so IRQs need to remain disabled until the TDCALL to ensure that pending IRQs are correctly treated as wake events. As per current TDX spec, HLT #VE handl

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-24 Thread Song Liu
On Thu, Feb 20, 2025 at 10:33 AM Song Liu wrote: > > > On Thu, Feb 20, 2025 at 10:22 AM Josh Poimboeuf wrote: >> >> On Wed, Feb 19, 2025 at 08:50:09PM -0800, Song Liu wrote: >> > Indu, is this behavior (symbols with same name are not in >> > sorted order from readelf -s) expected? Or is this a bu

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

2025-02-24 Thread Shuah Khan
On 2/24/25 12:26, Steven Rostedt wrote: On Mon, 24 Feb 2025 19:21:26 + Beau Belgrave wrote: Beau? I applied it locally and ensured it passed (seems timing related). Acked-by: Beau Belgrave Thanks Beau, Shuah, Please apply this patch: Acked-by: Steven Rostedt (Google) -- Stev

Re: [PATCH v2 2/2] selftests: sched: skip cs_prctl_test for systems with core scheduling disabled

2025-02-24 Thread Chris Hyser
>From: Sinadin Shan >Sent: Monday, February 24, 2025 7:10 AM >To: Shrikanth Hegde; sh...@kernel.org >Cc: linux-kselft...@vger.kernel.org; linux-kernel@vger.kernel.org; Chris Hyser >Subject: Re: [PATCH v2 2/2] selftests: sched: skip cs_prctl_test for systems >with core scheduling disabled > >On 24

Re: Re: Re: Re: Re: [PATCH 2/2] libbpf: BPF programs dynamic loading and attaching

2025-02-24 Thread Slava Imameev
> > > On Mon, 2025-02-10 at 16:06 -0800, Andrii Nakryiko wrote: > > > > Tracking associated maps for a program is not necessary. As long as > > > > the last BPF program using the BPF map is unloaded, the kernel will > > > > automatically free not-anymore-referenced BPF map. Note that > > > > bpf_ob

Re: [PATCH v7 5/6] rust: str: add radix prefixed integer parsing functions

2025-02-24 Thread Janne Grunau
On Tue, Feb 18, 2025 at 02:00:47PM +0100, Andreas Hindborg wrote: > Add the trait `ParseInt` for parsing string representations of integers > where the string representations are optionally prefixed by a radix > specifier. Implement the trait for the primitive integer types. > > Signed-off-by: And

Re: [PATCH v6 0/6] vhost: Add support of kthread API

2025-02-24 Thread Michael S. Tsirkin
On Sun, Feb 23, 2025 at 11:36:15PM +0800, Cindy Lu wrote: > In commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads"), > the vhost now uses vhost_task and operates as a child of the > owner thread. This aligns with containerization principles. > However, this change has caused c

Re: [PATCH] vduse: add virtio_fs to allowed dev id

2025-02-24 Thread Michael S. Tsirkin
On Tue, Jan 21, 2025 at 11:33:46AM +0100, Eugenio Pérez wrote: > A VDUSE device that implements virtiofs device works fine just by > adding the device id to the whitelist. > > Signed-off-by: Eugenio Pérez OK, but the commit log really should say why you are doing this. And also why is it safe.

Re: [PATCH v6 5/6] vhost: Add new UAPI to support change to task mode

2025-02-24 Thread Michael S. Tsirkin
better subject: vhost: uapi to control task mode (owner vs kthread) On Sun, Feb 23, 2025 at 11:36:20PM +0800, Cindy Lu wrote: > Add a new UAPI to enable setting the vhost device to task mode. better: Add a new UAPI to configure the vhost device to use the kthread mode > The userspace applica

Re: [PATCH v6 5/6] vhost: Add new UAPI to support change to task mode

2025-02-24 Thread Michael S. Tsirkin
On Sun, Feb 23, 2025 at 11:36:20PM +0800, Cindy Lu wrote: > Add a new UAPI to enable setting the vhost device to task mode. > The userspace application can use VHOST_SET_INHERIT_FROM_OWNER > to configure the mode if necessary. > This setting must be applied before VHOST_SET_OWNER, as the worker > w

[RFC PATCH 1/9] bpf/arm64: Unset bypass_spec_v4() instead of ignoring BPF_NOSPEC

2025-02-24 Thread Luis Gerhorst
This changes the semantics of BPF_NOSPEC to always insert a speculation barrier. If this is not needed on some architecture, bypass_spec_v4() should instead return true. Consequently, sanitize_stack_spill is renamed to nospec_result. This later allows us to rely on BPF_NOSPEC from v4 to reduce co

[RFC PATCH 5/9] bpf: Fall back to nospec if v1 verification fails

2025-02-24 Thread Luis Gerhorst
This implements the core of the series and causes the verifier to fall back to mitigating Spectre v1 using speculation barriers. The approach was presented at LPC'24: https://lpc.events/event/18/contributions/1954/ ("Mitigating Spectre-PHT using Speculation Barriers in Linux eBPF") and RAID'24:

[RFC PATCH 6/9] bpf: Allow nospec-protected var-offset stack access

2025-02-24 Thread Luis Gerhorst
Insert a nospec before the access to prevent it from ever using a index that is subject to speculative scalar-confusion. Signed-off-by: Luis Gerhorst Acked-by: Henriette Herzog Cc: Maximilian Ott Cc: Milan Stephan --- kernel/bpf/verifier.c | 15 --- 1 file changed, 8 insertions(+)

Re: [PATCH] selftests/net: deflake GRO tests and fix return value and output

2025-02-24 Thread Jakub Kicinski
On Sun, 23 Feb 2025 07:19:49 -0800 Kevin Krakauer wrote: > Thanks for the review! I'll split this up. Do you think it's better as two > patchsets -- one for stability/deflaking, one for return value and output > cleanup -- or as a single patchset with several commits? Should be fine either way, th

[RFC PATCH 8/9] bpf: Fall back to nospec for sanitization-failures

2025-02-24 Thread Luis Gerhorst
For the now raised REASON_STACK, this allows us to later fall back to nospec for certain errors from push_stack() if we are on a speculative path. Fall back to nospec_result directly for the remaining sanitization errs even if we are not on a speculative path. We must prevent a following mem-acces

[RFC PATCH 9/9] bpf: Cut speculative path verification short

2025-02-24 Thread Luis Gerhorst
This trades verification complexity for runtime overheads due to the nospec inserted because of the EINVAL. With increased limits this allows applying mitigations to large BPF progs such as the Parca Continuous Profiler's prog. However, this requires a jump-seq limit of 256k. In any case, the same

[RFC PATCH 7/9] bpf: Refactor push_stack to return error code

2025-02-24 Thread Luis Gerhorst
Main reason is, that it will later allow us to fall back to a nospec for certain errors in push_stack(). This has the side effect of changing the sanitization-case to returning ENOMEM. However, I believe this is more fitting as I undestand EFAULT to indicate a verifier-internal bug. Downside is,

Re: [PATCH RFC v2 00/10] SLUB percpu sheaves

2025-02-24 Thread Vlastimil Babka
On 2/24/25 02:36, Suren Baghdasaryan wrote: > On Sat, Feb 22, 2025 at 8:44 PM Suren Baghdasaryan wrote: >> >> Don't know about this particular part but testing sheaves with maple >> node cache and stress testing mmap/munmap syscalls shows performance >> benefits as long as there is some delay to l

Re: [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss

2025-02-24 Thread Luca Weiss
On 24-02-2025 9:27 p.m., Konrad Dybcio wrote: On 24.02.2025 1:17 AM, Dmitry Baryshkov wrote: On Sat, Feb 22, 2025 at 02:00:49PM +0100, Luca Weiss wrote: Set the paths where the device-specific firmware can be found for this device. Fairphone 3 was shipped with secure-boot off so any testkey-si

[RFC PATCH 0/9] bpf: Mitigate Spectre v1 using speculation barriers

2025-02-24 Thread Luis Gerhorst
This improves the expressiveness of unprivileged BPF by inserting speculation barriers instead of rejcting the programs. The approach was presented at LPC'24: https://lpc.events/event/18/contributions/1954/ ("Mitigating Spectre-PHT using Speculation Barriers in Linux eBPF") and RAID'24: http

[RFC PATCH 3/9] bpf: Return EFAULT on misconfigurations

2025-02-24 Thread Luis Gerhorst
Mark these cases as non-recoverable, even when they only occur during speculative path verification. Signed-off-by: Luis Gerhorst Acked-by: Henriette Herzog Cc: Maximilian Ott Cc: Milan Stephan --- kernel/bpf/verifier.c | 37 +++-- 1 file changed, 19 insertions

[RFC PATCH 4/9] bpf: Return EFAULT on internal errors

2025-02-24 Thread Luis Gerhorst
This prevents us from trying to recover from these on speculative paths in the future. Signed-off-by: Luis Gerhorst Acked-by: Henriette Herzog Cc: Maximilian Ott Cc: Milan Stephan --- kernel/bpf/verifier.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/bpf/ve

[RFC PATCH 2/9] bpf: Refactor do_check() if/else into do_check_insn()

2025-02-24 Thread Luis Gerhorst
This is required to catch the errors later and fall back to a nospec if on a speculative path. Move code into do_check_insn(), replace "continue" with "return CHECK_NEXT_INSN", "break" with "return ALL_PATHS_CHECKED", "do_print_state = " with "*do_print_state = ", and "goto process_bpf_exit" / fal

Re: [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss

2025-02-24 Thread Konrad Dybcio
On 24.02.2025 1:17 AM, Dmitry Baryshkov wrote: > On Sat, Feb 22, 2025 at 02:00:49PM +0100, Luca Weiss wrote: >> Set the paths where the device-specific firmware can be found for this >> device. >> >> Fairphone 3 was shipped with secure-boot off so any testkey-signed >> firmware is accepted. >> >> S

Re: [PATCH] virtio: break and reset virtio devices on device_shutdown()

2025-02-24 Thread Michael S. Tsirkin
On Mon, Feb 24, 2025 at 08:49:09AM +0100, Eric Auger wrote: > Hi Michael, > > On 2/21/25 12:42 AM, Michael S. Tsirkin wrote: > > Hongyu reported a hang on kexec in a VM. QEMU reported invalid memory > > accesses during the hang. > > > > Invalid read at addr 0x102877002, size 2, region '(null)

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

2025-02-24 Thread Beau Belgrave
On Fri, Feb 21, 2025 at 12:28:42PM -0500, Steven Rostedt wrote: > On Fri, 21 Feb 2025 08:46:31 -0700 > Shuah Khan wrote: > > > On 2/20/25 20:35, realx...@163.com wrote: > > > From: Yiqian Xun > > > > > > In parse_abi function,the dyn_test fails because the > > > enable_file isn’t closed after s

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

2025-02-24 Thread Steven Rostedt
On Mon, 24 Feb 2025 19:21:26 + Beau Belgrave wrote: > > Beau? > > > > I applied it locally and ensured it passed (seems timing related). > > Acked-by: Beau Belgrave Thanks Beau, Shuah, Please apply this patch: Acked-by: Steven Rostedt (Google) -- Steve

Re: [PATCH v2 3/3] rcu: Use _full() API to debug synchronize_rcu()

2025-02-24 Thread Paul E. McKenney
On Mon, Feb 24, 2025 at 02:36:59PM +0100, Uladzislau Rezki (Sony) wrote: > Switch for using of get_state_synchronize_rcu_full() and > poll_state_synchronize_rcu_full() pair for debug a normal > synchronize_rcu() call. > > Just using "not" full APIs to identify if a grace period > is passed or not

Re: [PATCH v2 1/3] rcutorture: Allow a negative value for nfakewriters

2025-02-24 Thread Paul E. McKenney
On Mon, Feb 24, 2025 at 02:36:57PM +0100, Uladzislau Rezki (Sony) wrote: > Currently "nfakewriters" parameter can be set to any value but > there is no possibility to adjust it automatically based on how > many CPUs a system has where a test is run on. > > To address this, if the "nfakewriters" is

Re: [PATCH RFC 3/4] mm/page_alloc_test: Add logic to isolate a node for testing

2025-02-24 Thread Yosry Ahmed
On Mon, Feb 24, 2025 at 02:47:13PM +, Brendan Jackman wrote: > In order to test the page allocator, we need an "instance" of the page > allocator that is not subject to unpredictable perturbation by the live > system. The closest thing that we have to an "instance" of the allocator > is a NUMA

Re: [PATCH RFC 4/4] mm/page_alloc_test: Add smoke-test for page allocation

2025-02-24 Thread Yosry Ahmed
On Mon, Feb 24, 2025 at 02:47:14PM +, Brendan Jackman wrote: > This is the bare minimum to illustrate what KUnit code would look like > that covers the page allocator. > > Even this trivial test illustrates a couple of nice things that are > possible when testing via KUnit > > 1. We can direc

Re: [PATCH v5 1/4] virtio_rtc: Add module and driver core

2025-02-24 Thread Simon Horman
On Wed, Feb 19, 2025 at 08:32:56PM +0100, Peter Hilber wrote: ... > +/** > + * VIORTC_MSG() - extract message from message handle > + * @hdl: message handle > + * > + * Return: struct viortc_msg > + */ > +#define VIORTC_MSG(hdl) ((hdl).msg) > + > +/** > + * VIORTC_MSG_INIT() - initialize message

Re: [PATCH v5 2/4] virtio_rtc: Add PTP clocks

2025-02-24 Thread Simon Horman
On Wed, Feb 19, 2025 at 08:32:57PM +0100, Peter Hilber wrote: ... > +/** > + * viortc_ptp_gettimex64() - PTP clock gettimex64 op > + * Hi Peter, Tooling recognises this as a kernel doc, and complains that there is no documentation present for the function's parameters: ptp, ts, and sts. Flagge

Re: [PATCH bpf-next v3 4/6] selftests/bpf: refactor xdp_context_functional test and bpf program

2025-02-24 Thread Stanislav Fomichev
On 02/24, Marcus Wichelmann wrote: > The existing XDP metadata test works by creating a veth pair and > attaching XDP & TC programs that drop the packet when the condition of > the test isn't fulfilled. The test then pings through the veth pair and > succeeds when the ping comes through. > > While

Re: [PATCH bpf-next v3 5/6] selftests/bpf: add test for XDP metadata support in tun driver

2025-02-24 Thread Stanislav Fomichev
On 02/24, Marcus Wichelmann wrote: > Add a selftest that creates a tap device, attaches XDP and TC programs, > writes a packet with a test payload into the tap device and checks the > test result. This test ensures that the XDP metadata support in the tun > driver is enabled and that the metadata s

Re: [RESEND PATCH v2] wireguard: selftests: Cleanup CONFIG_UBSAN_SANITIZE_ALL

2025-02-24 Thread Jason A. Donenfeld
Applied, thanks.

Re: [PATCH] remoteproc: omap: add comment for is_iomem

2025-02-24 Thread Mathieu Poirier
On Mon, Feb 17, 2025 at 03:58:58PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Address warning: "Function parameter or struct member 'is_iomem' not > described in 'omap_rproc_da_to_va'" with adding comment for is_iomem. > > Reported-by: kernel test robot > Closes: > https://lore.kernel.o

Re: [PATCH bpf-next 0/2] selftests/bpf: Migrate test_xdp_vlan.sh into test_progs

2025-02-24 Thread Stanislav Fomichev
On 02/21, Bastien Curutchet (eBPF Foundation) wrote: > Hi all, > > This patch series continues the work to migrate the script tests into > prog_tests. > > test_xdp_vlan.sh tests the ability of an XDP program to modify the VLAN > ids on the fly. This isn't currently covered by an other test in the

Re: [PATCH bpf-next 2/2] selftests/bpf: Migrate test_xdp_vlan.sh into test_progs

2025-02-24 Thread Stanislav Fomichev
On 02/24, Bastien Curutchet wrote: > Hi Stanislav, > > On 2/21/25 5:14 PM, Stanislav Fomichev wrote: > > On 02/21, Bastien Curutchet (eBPF Foundation) wrote: > > > test_xdp_vlan.sh isn't used by the BPF CI. > > > > > > Migrate test_xdp_vlan.sh in prog_tests/xdp_vlan.c. > > > It uses the same BPF

Re: [PATCH v2 6/7] mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()

2025-02-24 Thread Keith Busch
On Mon, Feb 24, 2025 at 12:44:46PM +0100, Uladzislau Rezki wrote: > On Fri, Feb 21, 2025 at 06:28:49PM +0100, Vlastimil Babka wrote: > > > > > > The warning indicates that this shouldn't be called from a > > > WQ_MEM_RECLAIM workqueue. This workqueue is responsible for bringing up > > > and tearin

[PATCH bpf-next v3 2/6] net: tun: enable transfer of XDP metadata to skb

2025-02-24 Thread Marcus Wichelmann
When the XDP metadata area was used, it is expected that the same metadata can also be accessed from TC, as can be read in the description of the bpf_xdp_adjust_meta helper function. In the tun driver, this was not yet implemented. To make this work, the skb that is being built on XDP_PASS should

[PATCH bpf-next v3 1/6] net: tun: enable XDP metadata support

2025-02-24 Thread Marcus Wichelmann
Enable the support for the bpf_xdp_adjust_meta helper function for XDP buffers initialized by the tun driver. This allows to reserve a metadata area that is useful to pass any information from one XDP program to another one, for example when using tail-calls. Whether this helper function can be us

[PATCH bpf-next v3 0/6] XDP metadata support for tun driver

2025-02-24 Thread Marcus Wichelmann
Hi, thank you for your reviw. As promised, here is V3 of this patch series. I noticed that the updated selftests were flaky sometimes due to the kernel networking stack sending IPv6 multicast listener reports on the created test interfaces. This can be seen here: https://github.com/kernel-patches

[PATCH bpf-next v3 3/6] selftests/bpf: move open_tuntap to network helpers

2025-02-24 Thread Marcus Wichelmann
To test the XDP metadata functionality of the tun driver, it's necessary to create a new tap device first. A helper function for this already exists in lwt_helpers.h. Move it to the common network helpers header, so it can be reused in other tests. Signed-off-by: Marcus Wichelmann --- tools/test

[PATCH bpf-next v3 6/6] selftests/bpf: fix file descriptor assertion in open_tuntap helper

2025-02-24 Thread Marcus Wichelmann
The open_tuntap helper function uses open() to get a file descriptor for /dev/net/tun. The open(2) manpage writes this about its return value: On success, open(), openat(), and creat() return the new file descriptor (a nonnegative integer). On error, -1 is returned and errno is set to indi

Re: [PATCH v7 6/6] rust: add parameter support to the `module!` macro

2025-02-24 Thread Daniel Almeida
Hi Andreas, thanks for working on this, I can see that this patch took a lot of effort. > On 18 Feb 2025, at 10:00, Andreas Hindborg wrote: > > This patch includes changes required for Rust kernel modules to utilize > module parameters. This code implements read only support for integer > types

[PATCH bpf-next v3 5/6] selftests/bpf: add test for XDP metadata support in tun driver

2025-02-24 Thread Marcus Wichelmann
Add a selftest that creates a tap device, attaches XDP and TC programs, writes a packet with a test payload into the tap device and checks the test result. This test ensures that the XDP metadata support in the tun driver is enabled and that the metadata size is correctly passed to the skb. See th

[PATCH bpf-next v3 4/6] selftests/bpf: refactor xdp_context_functional test and bpf program

2025-02-24 Thread Marcus Wichelmann
The existing XDP metadata test works by creating a veth pair and attaching XDP & TC programs that drop the packet when the condition of the test isn't fulfilled. The test then pings through the veth pair and succeeds when the ping comes through. While this test works great for a veth pair, it is h

[PATCH v2 2/3] rcu: Update TREE05.boot to test normal synchronize_rcu()

2025-02-24 Thread Uladzislau Rezki (Sony)
Add extra parameters for rcutorture module. One is the "nfakewriters" which is set -1. There will be created number of test-kthreads which correspond to number of CPUs in a test system. Those threads randomly invoke synchronize_rcu() call. Apart of that "rcu_normal" is set to 1, because it is spec

Re: [PATCH v6 0/6] vhost: Add support of kthread API

2025-02-24 Thread Lei Yang
I tested this series of patches with virtio-net regression tests, everything works fine. Tested-by: Lei Yang On Sun, Feb 23, 2025 at 11:41 PM Cindy Lu wrote: > > In commit 6e890c5d5021 ("vhost: use vhost_tasks for worker threads"), > the vhost now uses vhost_task and operates as a child of the

[PATCH RFC 3/4] mm/page_alloc_test: Add logic to isolate a node for testing

2025-02-24 Thread Brendan Jackman
In order to test the page allocator, we need an "instance" of the page allocator that is not subject to unpredictable perturbation by the live system. The closest thing that we have to an "instance" of the allocator is a NUMA node. So, introduce a new concept of an "isolated" node. This is an exte

[PATCH RFC 1/4] kunit: Allocate assertion data with GFP_ATOMIC

2025-02-24 Thread Brendan Jackman
At present KUnit doesn't handle assertions happening in atomic contexts. A later commit will add tests that make assertions with spinlocks held. In preparation, switch to GFP_ATOMIC. "Just use GFP_ATOMIC" is not generally a solution to this kind of problem: since it uses up memory reserves, inste

[PATCH RFC 2/4] mm/page_alloc_test: Add empty KUnit boilerplate

2025-02-24 Thread Brendan Jackman
Add the Kbuild plumbing to create a new KUnit suite. Create the suite, with no tests inside it. Signed-off-by: Brendan Jackman --- mm/.kunitconfig | 2 ++ mm/Kconfig | 8 mm/Makefile | 2 ++ mm/page_alloc_test.c | 21 + 4 files changed, 33

[PATCH RFC 0/4] mm: KUnit tests for the page allocator

2025-02-24 Thread Brendan Jackman
The page allocator does a lot of stuff that is not visible to the user in any deterministic way. But this stuff is still important and it would be nice to test that behaviour. KUnit is a tool for unit-testing kernel-internal APIs. This is an attempt to adopt it the page allocator. I have been hac

Re: [PATCH 13/16] selftests: vDSO: parse_vdso: Make compatible with nolibc

2025-02-24 Thread Thomas Weißschuh
On Sat, Feb 22, 2025 at 11:24:26AM +0100, Willy Tarreau wrote: > On Mon, Feb 03, 2025 at 10:05:14AM +0100, Thomas Weißschuh wrote: > > nolibc does not provide this header, instead its definitions are > > available unconditionally. > > Please think about reminding which one you're talking about so

[PATCH RFC 4/4] mm/page_alloc_test: Add smoke-test for page allocation

2025-02-24 Thread Brendan Jackman
This is the bare minimum to illustrate what KUnit code would look like that covers the page allocator. Even this trivial test illustrates a couple of nice things that are possible when testing via KUnit 1. We can directly assert that the correct zone was used. (Although note due to the simplis

Re: [PATCH 1/4] mm: allow guard regions in file-backed and read-only mappings

2025-02-24 Thread Lorenzo Stoakes
One thing to note with this series is that it now implies file-backed VMAs which install guard regions will now have an anon_vma installed if not already present (i.e. if not post-CoW MAP_PRIVATE). I have audited kernel source for instances of vma->anon_vma checks and found nowhere where this woul

Re: [PATCH v7 2/6] rust: str: implement `Index` for `BStr`

2025-02-24 Thread Fiona Behrens
Andreas Hindborg writes: > The `Index` implementation on `BStr` was lost when we switched `BStr` from > a type alias of `[u8]` to a newtype. This patch adds back `Index` by > implementing `Index` for `BStr` when `Index` would be implemented for > `[u8]`. > > Signed-off-by: Andreas Hindborg Revi

Re: [PATCH net-next] selftests/net: ensure mptcp is enabled in netns

2025-02-24 Thread Matthieu Baerts
Hi Hangbin, Davide, On 24/02/2025 10:40, Hangbin Liu wrote: > Some distributions may not enable MPTCP by default. All other MPTCP tests > source mptcp_lib.sh to ensure MPTCP is enabled before testing. However, > the ip_local_port_range test is the only one that does not include this > step. This

Re: [PATCH v7 5/6] rust: str: add radix prefixed integer parsing functions

2025-02-24 Thread Andreas Hindborg
"Daniel Almeida" writes: > Hi Andreas, > >> On 18 Feb 2025, at 10:00, Andreas Hindborg wrote: >> >> Add the trait `ParseInt` for parsing string representations of integers >> where the string representations are optionally prefixed by a radix >> specifier. Implement the trait for the primitive i

[PATCH v2 1/3] rcutorture: Allow a negative value for nfakewriters

2025-02-24 Thread Uladzislau Rezki (Sony)
Currently "nfakewriters" parameter can be set to any value but there is no possibility to adjust it automatically based on how many CPUs a system has where a test is run on. To address this, if the "nfakewriters" is set to negative it will be adjusted to num_online_cpus() during torture initializa

[PATCH v2 3/3] rcu: Use _full() API to debug synchronize_rcu()

2025-02-24 Thread Uladzislau Rezki (Sony)
Switch for using of get_state_synchronize_rcu_full() and poll_state_synchronize_rcu_full() pair for debug a normal synchronize_rcu() call. Just using "not" full APIs to identify if a grace period is passed or not might lead to a false kernel splat. Link: https://lore.kernel.org/lkml/Z5ikQeVmVdsWQ

Re: [PATCH v7 5/6] rust: str: add radix prefixed integer parsing functions

2025-02-24 Thread Daniel Almeida
Hi Andreas, > On 18 Feb 2025, at 10:00, Andreas Hindborg wrote: > > Add the trait `ParseInt` for parsing string representations of integers > where the string representations are optionally prefixed by a radix > specifier. Implement the trait for the primitive integer types. > > Signed-off-by:

[PATCH v9 3/3] selftests/rseq: Add test for mm_cid compaction

2025-02-24 Thread Gabriele Monaco
A task in the kernel (task_mm_cid_work) runs somewhat periodically to compact the mm_cid for each process. Add a test to validate that it runs correctly and timely. The test spawns 1 thread pinned to each CPU, then each thread, including the main one, runs in short bursts for some time. During thi

Re: [ANNOUNCE] 5.10.234-rt126

2025-02-24 Thread Luis Claudio R. Goncalves
On Fri, Feb 21, 2025 at 10:50:04AM +0100, Jan Kiszka wrote: > On 19.02.25 23:07, Luis Claudio R. Goncalves wrote: > > Hello RT-list! > > > > I'm pleased to announce the 5.10.234-rt126 stable release. > > > > This release is just an update to the new stable 5.10.234 version and > > no RT-specific

Re: [PATCH RFC v2 05/10] slab: switch percpu sheaves locking to localtry_lock

2025-02-24 Thread Harry Yoo
On Fri, Feb 14, 2025 at 05:27:41PM +0100, Vlastimil Babka wrote: > Instead of local_lock_irqsave(), use localtry_trylock() when potential > callers include irq context, and localtry_lock() otherwise (such as when > we already know the gfp flags allow blocking). > > This should reduce the locking (

[PATCH] selftests/memory-hotplug: debugging improvement

2025-02-24 Thread Leonardo Felipe Takao Hirata
Formats testing messages to improve debugging: - Inserts alignment tabs with printf for testing results - Changes messages to improve readability and understanding Signed-off-by: Leonardo Felipe Takao Hirata --- .../memory-hotplug/mem-on-off-test.sh | 21 --- 1 file chang

Re: [PATCH v2 2/2] selftests: sched: skip cs_prctl_test for systems with core scheduling disabled

2025-02-24 Thread Sinadin Shan
On 24-02-2025 01:49 pm, Shrikanth Hegde wrote: On 2/21/25 17:27, Sinadin Shan wrote: For kernels with CONFIG_SCHED_CORE=n, the sched selftest cs_prctl_test fails with "Not a core sched system" error. Change this to gracefully skip the test for systems with core scheduling disabled. Exiting

[PATCH v2] acpi: nfit: fix narrowing conversion in acpi_nfit_ctl

2025-02-24 Thread Murad Masimov
Syzkaller has reported a warning in to_nfit_bus_uuid(): == only secondary bus families can be translated WARNING: CPU: 0 PID: 15821 at drivers/acpi/nfit/core.c:80 to_nfit_bus_uuid+0x6f/0x90 drivers/acpi/nfit/core.c:79 Modules linked

Re: [PATCH v2 6/7] mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()

2025-02-24 Thread Uladzislau Rezki
On Fri, Feb 21, 2025 at 06:28:49PM +0100, Vlastimil Babka wrote: > On 2/21/25 17:30, Keith Busch wrote: > > On Wed, Aug 07, 2024 at 12:31:19PM +0200, Vlastimil Babka wrote: > >> We would like to replace call_rcu() users with kfree_rcu() where the > >> existing callback is just a kmem_cache_free().

Re: [PATCH v7 0/6] rust: extend `module!` macro with integer parameter support

2025-02-24 Thread Andreas Hindborg
Hi Petr, "Andreas Hindborg" writes: > This series extends the `module!` macro with support module parameters. It > also adds some string to integer parsing functions and updates `BStr` with > a method to strip a string prefix. > > This series stated out as code by Adam Bratschi-Kaye lifted from

[PATCH AUTOSEL 6.6 02/20] selftests/bpf: Fix invalid flag of recv()

2025-02-24 Thread Sasha Levin
From: Jiayuan Chen [ Upstream commit a0c11149509aa905aeec10cf9998091443472b0b ] SOCK_NONBLOCK flag is only effective during socket creation, not during recv. Use MSG_DONTWAIT instead. Signed-off-by: Jiayuan Chen Signed-off-by: Martin KaFai Lau Acked-by: Jakub Sitnicki Acked-by: John Fastaben

[PATCH AUTOSEL 6.12 02/28] selftests/bpf: Fix invalid flag of recv()

2025-02-24 Thread Sasha Levin
From: Jiayuan Chen [ Upstream commit a0c11149509aa905aeec10cf9998091443472b0b ] SOCK_NONBLOCK flag is only effective during socket creation, not during recv. Use MSG_DONTWAIT instead. Signed-off-by: Jiayuan Chen Signed-off-by: Martin KaFai Lau Acked-by: Jakub Sitnicki Acked-by: John Fastaben

[PATCH AUTOSEL 6.13 03/32] selftests/bpf: Fix invalid flag of recv()

2025-02-24 Thread Sasha Levin
From: Jiayuan Chen [ Upstream commit a0c11149509aa905aeec10cf9998091443472b0b ] SOCK_NONBLOCK flag is only effective during socket creation, not during recv. Use MSG_DONTWAIT instead. Signed-off-by: Jiayuan Chen Signed-off-by: Martin KaFai Lau Acked-by: Jakub Sitnicki Acked-by: John Fastaben

[PATCH AUTOSEL 6.13 01/32] selftests/bpf: Adjust data size to have ETH_HLEN

2025-02-24 Thread Sasha Levin
From: Shigeru Yoshida [ Upstream commit c7f2188d68c114095660a950b7e880a1e5a71c8f ] The function bpf_test_init() now returns an error if user_size (.data_size_in) is less than ETH_HLEN, causing the tests to fail. Adjust the data size to ensure it meets the requirement of ETH_HLEN. Signed-off-by:

Re: [PATCH v2 8/9] selftests/mm: Skip map_populate on weird filesystems

2025-02-24 Thread Brendan Jackman
On Fri, 21 Feb 2025 at 19:26, Brendan Jackman wrote: > > It seems that 9pfs does not allow truncating unlinked files, Mark Brown > has noted that NFS may also behave this way. I have not investigated at all but I _think_ over the weekend I saw ftruncate() failure on a QEMU guest where /tmp was tm

  1   2   >