Re: [PATCH] selftets: lib: remove reference to prime_numbers

On Fri, Feb 21, 2025 at 7:57 PM Kees Cook wrote: > > On Mon, 17 Feb 2025 08:30:44 -0500, Tamir Duberstein wrote: > > Remove a leftover shell script reference from commit 313b38a6ecb4 > > ("lib/prime_numbers: convert self-test to KUnit"). > > > > > > I fixed the Subject typos and applied to for-nex

Re: [PATCH] selftets: lib: remove reference to prime_numbers

On Mon, 17 Feb 2025 08:30:44 -0500, Tamir Duberstein wrote: > Remove a leftover shell script reference from commit 313b38a6ecb4 > ("lib/prime_numbers: convert self-test to KUnit"). > > I fixed the Subject typos and applied to for-next/move-kunit-tests, thanks! [1/1] selftets: lib: remove refere

Re: [PATCH net-next] selftests: fib_nexthops: do not mark skipped tests as failed

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Thu, 20 Feb 2025 08:53:26 + you wrote: > The current test marks all unexpected return values as failed and sets ret > to 1. If a test is skipped, the entire test also returns 1, incorrectly > indicating failure

[PATCH RFC v2 2/2] remoteproc: qcom: pas: Add SM8750 MPSS

Add remote processor PAS loaders for SM8750 MPSS (modem), which differs from SM8650 by lack of fifth memory region for Qlink Logging. Signed-off-by: Krzysztof Kozlowski --- Changes in v2: None --- drivers/remoteproc/qcom_q6v5_pas.c | 25 + 1 file changed, 25 insertions(

[PATCH v3] dt-bindings: remoteproc: Add SM8750 CDSP

Add remote processor PAS loader for SM8750 CDSP processor, compatible with earlier SM8650 with minor difference: one more sixth shutdown interrupt. Acked-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski --- Changesin v3: 1. Split MPSS into separate patch, keep the ack. v2: https://lore.ke

[5.10-rt][PATCH 1/2] u64_stats: Introduce u64_stats_set()

From: Ahmed S. Darwish [ Upstream commit f2efdb17928924c9c935c136dea764a081032006 ] Allow to directly set a u64_stats_t value which is used to provide an init function which sets it directly to zero intead of memset() the value. Add u64_stats_set() to the u64_stats API. [bigeasy: commit messag

[PATCH RFC v2 1/2] dt-bindings: remoteproc: Add SM8750 MPSS

Add remote processor PAS loader for SM8750 MPSS (modem). Device looks fully compatible with SM8650, however it lacks fifth memory region for Qlink Logging, according to downstream sources. This is a bit tricky, because updated downstream sources for newer downstream release dropped that fifth mem

Re: [PATCH v2 6/7] mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()

On Wed, Aug 07, 2024 at 12:31:19PM +0200, Vlastimil Babka wrote: > We would like to replace call_rcu() users with kfree_rcu() where the > existing callback is just a kmem_cache_free(). However this causes > issues when the cache can be destroyed (such as due to module unload). > > Currently such m

[PATCH net-next v6 0/8] Some pktgen fixes/improvments (part II)

While taking a look at '[PATCH net] pktgen: Avoid out-of-range in get_imix_entries' ([1]) and '[PATCH net v2] pktgen: Avoid out-of-bounds access in get_imix_entries' ([2], [3]) and doing some tests and code review I detected that the /proc/net/pktgen/... parsing logic does not honour the user given

[PATCH net-next v6 6/8] net: pktgen: fix mpls reset parsing

Fix mpls list reset parsing to work as describe in Documentation/networking/pktgen.rst: pgset "mpls 0"turn off mpls (or any invalid argument works too!) - before the patch $ echo "mpls 0001,0002" > /proc/net/pktgen/lo\@0 $ grep mpls /proc/net/pktgen/lo\@0

[PATCH net-next v6 8/8] selftest: net: add proc_net_pktgen

Add some test for /proc/net/pktgen/... interface. - enable 'CONFIG_NET_PKTGEN=m' in tools/testing/selftests/net/config Signed-off-by: Peter Seiderer --- Changes v5 -> v6 - no changes Changes v4 -> v5 - split up patchset into part i/ii (suggested by Simon Horman) - addapt to dropped patch

[PATCH net-next v6 1/8] net: pktgen: fix mix of int/long

Fix mix of int/long (and multiple conversion from/to) by using consequently size_t for i and max and ssize_t for len and adjust function signatures of hex32_arg(), count_trail_chars(), num_arg() and strn_len() accordingly. Signed-off-by: Peter Seiderer --- Changes v5 -> v6 - adjust to dropped p

[PATCH net-next v6 5/8] net: pktgen: fix access outside of user given buffer in pktgen_if_write()

Honour the user given buffer size for the hex32_arg(), num_arg(), strn_len(), get_imix_entries() and get_labels() calls (otherwise they will access memory outside of the user given buffer). Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v5 -> v6 - adjust to dropped patch '

[PATCH net-next v6 7/8] net: pktgen: remove all superfluous index assignements

Remove all superfluous index ('i += len') assignements (value not used afterwards). Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v5 -> v6 - add rev-by Simon Horman Changes v4 -> v5 - new patch (suggested by Simon Horman) --- net/core/pktgen.c | 52 ++-

[PATCH net-next v6 3/8] net: pktgen: remove some superfluous variable initializing

Remove some superfluous variable initializing before hex32_arg call (as the same init is done here already). Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v5 -> v6 - adjust to dropped patch ''net: pktgen: use defines for the various dec/hex number parsing digits lengt

[PATCH net-next v6 4/8] net: pktgen: fix mpls maximum labels list parsing

Fix mpls maximum labels list parsing up to MAX_MPLS_LABELS/16 entries (instead of up to MAX_MPLS_LABELS - 1). Addresses the following: $ echo "mpls 0f00,0f01,0f02,0f03,0f04,0f05,0f06,0f07,0f08,0f09,0f0a,0f0b,0f0c,0f0d,0f0e,0

[PATCH net-next v6 2/8] net: pktgen: remove extra tmp variable (re-use len instead)

Remove extra tmp variable in pktgen_if_write (re-use len instead). Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v5 -> v6 - no changes Changes v4 -> v5 - split up patchset into part i/ii (suggested by Simon Horman) - add rev-by Simon Horman Changes v3 -> v4 - new

[ANNOUNCE] kmod 34

kmod 34 is out: https://www.kernel.org/pub/linux/utils/kernel/kmod/kmod-34.tar.xz https://www.kernel.org/pub/linux/utils/kernel/kmod/kmod-34.tar.sign By number of commits this is the biggest release ever, although we managed to do it without libkmod additions/removals. There were

Re: [PATCH v2] ww_mutex: convert self-test to KUnit

On Fri, Feb 14, 2025 at 7:37 AM Tamir Duberstein wrote: > > On Fri, Feb 14, 2025 at 4:48 AM Peter Zijlstra wrote: > > > > On Thu, Feb 13, 2025 at 10:42:24AM -0500, Tamir Duberstein wrote: > > > On Thu, Feb 13, 2025 at 6:59 AM Peter Zijlstra > > > wrote: > > > > > > > > On Thu, Feb 13, 2025 at 0

[PATCH v2 3/9] selftests/mm: Skip uffd-stress if userfaultfd not available

It's pretty obvious that the test wouldn't work if you don't have the feature enabled. But, it's still useful to SKIP instead of failing so the reader can immediately tell that this is the reason why. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 4 ++-- 1 file ch

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

On Fri, 21 Feb 2025 08:46:31 -0700 Shuah Khan wrote: > On 2/20/25 20:35, realx...@163.com wrote: > > From: Yiqian Xun > > > > In parse_abi function,the dyn_test fails because the > > enable_file isn’t closed after successfully registering an event. > > By adding wait_for_delete(), the dyn_test

Re: [PATCH v7 3/6] rust: str: implement `AsRef` for `[u8]` and `BStr`

On Tue, 18 Feb 2025 14:00:45 +0100 Andreas Hindborg wrote: > Implement `AsRef` for `[u8]` and `BStr` so these can be used > interchangeably for operations on `BStr`. > > Signed-off-by: Andreas Hindborg Reviewed-by: Gary Guo > --- > rust/kernel/str.rs | 12 > 1 file changed, 12

[PATCH v2 7/9] selftests/mm: Don't fail uffd-stress if too many CPUs

This calculation divides a fixed parameter by an environment-dependent parameter i.e. the number of CPUs. The simple way to avoid machine-specific failures here is to just put a cap on the max value of the latter. Suggested-by: Mateusz Guzik Signed-off-by: Brendan Jackman --- tools/testing/sel

[PATCH v2 1/9] selftests/mm: Report errno when things fail in gup_longterm

Just reporting failure doesn't tell you what went wrong. This can fail in different ways so report errno to help the reader get started debugging. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/gup_longterm.c | 37 ++- 1 file changed, 21 insertions(+),

Re: [PATCH 0/9] vhost-scsi: log write descriptors for live migration (and two bugfix)

Thanks to the suggestion from Mike, I am going re-send v2 with: 1. Re-base on top of the below patchset. [PATCH v2 0/8] vhost-scsi: Memory reduction patches https://yhbt.net/lore/target-devel/20241203191705.19431-1-michael.chris...@oracle.com/ The patchset can clean apply/build on top of the com

Re: [PATCH 0/4] mm: permit guard regions for file-backed/shmem mappings

On Fri, Feb 21, 2025 at 3:04 AM Lorenzo Stoakes wrote: > > On Thu, Feb 20, 2025 at 10:08:36AM -0800, Kalesh Singh wrote: > > On Thu, Feb 20, 2025 at 8:22 AM Suren Baghdasaryan > > wrote: > > > > > > On Thu, Feb 20, 2025 at 5:18 AM Lorenzo Stoakes > > > wrote: > > > > > > > > On Thu, Feb 20, 202

[PATCH v2 4/9] selftests/mm: Skip uffd-wp-mremap if userfaultfd not available

It's obvious that this should fail in that case, but still, save the reader the effort of figuring out that they've run into this by just SKIPping Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-wp-mremap.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v2 8/9] selftests/mm: Skip map_populate on weird filesystems

It seems that 9pfs does not allow truncating unlinked files, Mark Brown has noted that NFS may also behave this way. It doesn't seem quite right to call this a "bug" but it's probably a special enough case that it makes sense for the test to just SKIP if it happens. Signed-off-by: Brendan Jackman

[PATCH v2 9/9] selftests/mm: Skip gup_longerm tests on weird filesystems

Some filesystems don't support funtract()ing unlinked files. They return ENOENT. In that case, skip the test. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/gup_longterm.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/gup_

[PATCH v2 6/9] selftests/mm: Print some details when uffd-stress gets bad params

So this can be debugged more easily. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index ec842bbb9f18e291fa51d

[PATCH v2 5/9] selftests/mm/uffd: Rename nr_cpus -> nr_threads

A later commit will bound this variable so it no longer necessarily matches the number of CPUs. Rename it appropriately. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-common.c | 8 tools/testing/selftests/mm/uffd-common.h | 2 +- tools/testing/selftests/mm

[PATCH v2 2/9] selftests/mm: Fix assumption that sudo is present

If we are root, sudo isn't needed. If we are not root, we need sudo, so skip the test if it isn't present. We already do this for on-fault-limit, but this uses separate infrastructure since that is specifically for sudo-ing to the nobody user. Note this ptrace_skip configuration still fails if th

[PATCH v2 0/9] selftests/mm: Some cleanups from trying to run them

I never had much luck running mm selftests so I spent a couple of hours digging into why. Looks like most of the reason is missing SKIP checks, so this series is just adding a bunch of those that I found. I did not do anything like all of them, just the ones I spotted in gup_longterm, gup_test, mm

Re: [PATCH v2 3/7] iommu: Make iommu_dma_prepare_msi() into a generic operation

On Fri, Feb 21, 2025 at 03:39:45PM +, Robin Murphy wrote: > Yuck. Realistically we are going to have no more than two different > implementations of this; a fiddly callback interface seems overkill. All we > should need in the domain is a simple indicator of *which* MSI translation > scheme is

[5.10-rt][PATCH 0/2] backport of RT fix for nft counter

As 5.10 requires some manual work, here are the two patches needed to address [1]. Note that 5.15-rt already has the fix (f036d9effdba). 6.1-rt and 6.6-rt can pick 4a1d3acd6ea8 without conflicts or dependencies. Pavel, please check 4.19-cip-rt and 4.4-cip-rt. I suspect the task is a bit bigger th

[5.10-rt][PATCH 2/2] netfilter: nft_counter: Use u64_stats_t for statistic.

From: Sebastian Andrzej Siewior [ Upstream commit 4a1d3acd6ea86075e77fcc1188c3fc372833ba73 ] The nft_counter uses two s64 counters for statistics. Those two are protected by a seqcount to ensure that the 64bit variable is always properly seen during updates even on 32bit architectures where the

Re: Re: Re: Re: [PATCH 2/2] libbpf: BPF programs dynamic loading and attaching

On Wed, Feb 12, 2025 at 2:31 PM Martin Kelly wrote: > > On Mon, 2025-02-10 at 16:06 -0800, Andrii Nakryiko wrote: > > > Tracking associated maps for a program is not necessary. As long as > > > the last BPF program using the BPF map is unloaded, the kernel will > > > automatically free not-anymore

Re: [PATCH v2 6/7] mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()

On 2/21/25 17:30, Keith Busch wrote: > On Wed, Aug 07, 2024 at 12:31:19PM +0200, Vlastimil Babka wrote: >> We would like to replace call_rcu() users with kfree_rcu() where the >> existing callback is just a kmem_cache_free(). However this causes >> issues when the cache can be destroyed (such as du

[RFC v2 3/5] virtio_ring: add api for premapped out and in buffer chain

Commit 3ef66af31fea ("virtio_ring: introduce add api for premapped") add functions to add premapped input or output chains to a virtqueue. Add a generic one that supports out+in buffers chains. Signed-off-by: Eugenio Pérez --- drivers/virtio/virtio_ring.c | 35 +++

[RFC v2 0/5] virtiofs: map buffer out of virtqueue lock

This is useful for some setups like swiotlb or VDUSE where the DMA operations are expensive and/or need to be performed with a write lock. After applying these patches, fio read test goes from 1124MiB/s to 1263.14MiB/s. v2: * Follow current add_premapped virtio API * Disable notification more agg

Re: [PATCH v2 2/5] modules: Refactor + kdoc elf_validity_cached_copy

Remove everything that is attacking me this is invalid All information. Has been stolen I’ve been attacked over 2yrs Please stop all of this I didn’t approve any of this Sent from my iPhone

[RFC v2 5/5] virtiofs: Disable notifications more aggresively

Disable notifications right before scheduling, instead of waiting until the work is running. After applying this patch, fio read test goes from 1191MiB/s to 1263.14Mib/s Signed-off-by: Eugenio Pérez --- fs/fuse/virtio_fs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/fuse/virtio_fs.

[RFC v2 4/5] virtiofs: perform DMA operations out of the spinlock

This is useful for some setups like swiotlb or VDUSE where the DMA operations are expensive and/or need to be performed with a write lock. After applying this patch, fio read test goes from 1124MiB/s to 1191MiB/s. Signed-off-by: Eugenio Pérez --- fs/fuse/virtio_fs.c | 40 +++

[RFC v2 2/5] virtiofs: Move stack sg to fuse_req

We need to move the map and unmap out of virtiofs queue lock. We need to store the unmap sgs to call virtqueue_unmap_sgs, so use the request itself. TODO: We need to store the forget sgs too. In my tests it is not called so we're safe. Find a way to force-call it. Signed-off-by: Eugenio Pérez

[RFC v2 1/5] vduse: add virtio_fs to allowed dev id

A VDUSE device that implements virtiofs device works fine just by adding the device id to the whitelist. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- drivers/vdpa/vdpa_user/vduse_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdp

Re: [PATCH v2 2/5] modules: Refactor + kdoc elf_validity_cached_copy

Remove everything that is attacking me this is invalid All information. Has been stolen I’ve been attacked over 2yrs Please stop all of this I didn’t approve any of this Sent from my iPhone

Re: [PATCH bpf-next v2] arm64, bpf: Add 12-argument support for bpf trampoline

Hello everyone, On 7/5/24 14:53, Puranjay Mohan wrote: > The arm64 bpf JIT currently supports attaching the trampoline to > functions with <= 8 arguments. This is because up to 8 arguments can be > passed in registers r0-r7. If there are more than 8 arguments then the > 9th and later arguments are

Re: [PATCH v2 7/7] iommu: Turn iova_cookie to dma-iommu private pointer

On Fri, Feb 21, 2025 at 03:23:22PM +, Robin Murphy wrote: > Eww... What's the issue with just checking the domain type in > iommu_put_dma_cookie()? Is is that IOMMUFD and VFIO type 1 are both doing > their own different thing with IOMMU_DOMAIN_UNMANAGED? Yes > In general it seems like a bad s

Re: [PATCH v2 6/7] mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()

On Fri, Feb 21, 2025 at 5:51 PM Mateusz Guzik wrote: > > On Fri, Feb 21, 2025 at 5:30 PM Keith Busch wrote: > > This patch appears to be triggering a new warning in certain conditions > > when tearing down an nvme namespace's block device. Stack trace is at > > the end. > > > > The warning indica

Re: [PATCH v2 6/7] mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()

On Fri, Feb 21, 2025 at 5:30 PM Keith Busch wrote: > This patch appears to be triggering a new warning in certain conditions > when tearing down an nvme namespace's block device. Stack trace is at > the end. > > The warning indicates that this shouldn't be called from a > WQ_MEM_RECLAIM workqueue.

Re: [PATCH v7 3/6] rust: str: implement `AsRef` for `[u8]` and `BStr`

> On 21 Feb 2025, at 13:01, Daniel Almeida wrote: > > > >> On 18 Feb 2025, at 10:00, Andreas Hindborg wrote: >> >> Implement `AsRef` for `[u8]` and `BStr` so these can be used >> interchangeably for operations on `BStr`. >> >> Signed-off-by: Andreas Hindborg >> --- >> rust/kernel/str.rs

Re: [PATCH bpf-next 2/2] selftests/bpf: Migrate test_xdp_vlan.sh into test_progs

On 02/21, Bastien Curutchet (eBPF Foundation) wrote: > test_xdp_vlan.sh isn't used by the BPF CI. > > Migrate test_xdp_vlan.sh in prog_tests/xdp_vlan.c. > It uses the same BPF programs located in progs/test_xdp_vlan.c and the > same network topology. > Remove test_xdp_vlan*.sh and their Makefile e

Re: [PATCH v7 4/6] rust: str: implement `strip_prefix` for `BStr`

Hi Andreas, > On 18 Feb 2025, at 10:00, Andreas Hindborg wrote: > > Implement `strip_prefix` for `BStr` by deferring to `slice::strip_prefix` > on the underlying `&[u8]`. > > Reviewed-by: Gary Guo > Reviewed-by: Alice Ryhl > Signed-off-by: Andreas Hindborg > --- > > It is also possible to g

Re: [PATCH] selftests/landlock: add binaries to gitignore

On Mon, Feb 10, 2025 at 09:40:57PM +0530, Bharadwaj Raju wrote: > Building the test creates binaries 'wait-pipe' and > 'sandbox-and-launch' which need to be gitignore'd. > > Signed-off-by: Bharadwaj Raju Thanks! > --- > tools/testing/selftests/landlock/.gitignore | 2 ++ > 1 file changed, 2 in

Re: [PATCH v7 3/6] rust: str: implement `AsRef` for `[u8]` and `BStr`

> On 18 Feb 2025, at 10:00, Andreas Hindborg wrote: > > Implement `AsRef` for `[u8]` and `BStr` so these can be used > interchangeably for operations on `BStr`. > > Signed-off-by: Andreas Hindborg > --- > rust/kernel/str.rs | 12 > 1 file changed, 12 insertions(+) > > diff --git

Re: [PATCH v7 2/6] rust: str: implement `Index` for `BStr`

> On 18 Feb 2025, at 10:00, Andreas Hindborg wrote: > > The `Index` implementation on `BStr` was lost when we switched `BStr` from > a type alias of `[u8]` to a newtype. This patch adds back `Index` by > implementing `Index` for `BStr` when `Index` would be implemented for > `[u8]`. > > Signe

Re: [RESEND PATCH 1/2] dt-bindings: remoteproc: Add SM8750 MPSS and CDSP

On 20/02/2025 16:41, Krzysztof Kozlowski wrote: > Add remote processor PAS loaders for SM8750 MPSS (modem) and CDSP > processors. Both are compatible with earlier SM8650 with minor > differences: > 1. SM8750 CDSP has one more sixth shutdown interrupt. > 2. SM8750 MPSS lacks fifth memory region for

Re: [PATCH 3/3] rcu/exp: Remove needless CPU up quiescent state report

Le Wed, Feb 19, 2025 at 06:58:36AM -0800, Paul E. McKenney a écrit : > On Sat, Feb 15, 2025 at 11:23:45PM +0100, Frederic Weisbecker wrote: > > > Before. There was also some buggy debug code in play. Also, to get the > > > failure, it was necessary to make TREE03 disable preemption, as stock > >

Re: [PATCH 3/3] rcu/exp: Remove needless CPU up quiescent state report

Le Wed, Feb 19, 2025 at 07:55:05AM -0800, Paul E. McKenney a écrit : > > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > > > index 86935fe00397..40d6090a33f5 100644 > > > --- a/kernel/rcu/tree.c > > > +++ b/kernel/rcu/tree.c > > > @@ -4347,6 +4347,12 @@ void rcutree_report_cpu_dead(void) > >

Re: [PATCH v7 1/6] rust: str: implement `PartialEq` for `BStr`

> On 18 Feb 2025, at 10:00, Andreas Hindborg wrote: > > Implement `PartialEq` for `BStr` by comparing underlying byte slices. > > Reviewed-by: Alice Ryhl > Reviewed-by: Gary Guo > Signed-off-by: Andreas Hindborg > --- > rust/kernel/str.rs | 6 ++ > 1 file changed, 6 insertions(+) > > d

Re: [PATCH v7 0/6] rust: extend `module!` macro with integer parameter support

Hi Andreas, > On 18 Feb 2025, at 10:00, Andreas Hindborg wrote: > > This series extends the `module!` macro with support module parameters. It > also adds some string to integer parsing functions and updates `BStr` with > a method to strip a string prefix. > > This series stated out as code by

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

On 2/20/25 20:35, realx...@163.com wrote: From: Yiqian Xun In parse_abi function,the dyn_test fails because the enable_file isn’t closed after successfully registering an event. By adding wait_for_delete(), the dyn_test now passes as expected. Signed-off-by: Yiqian Xun --- tools/testing/sel

Re: [PATCH v2 3/7] iommu: Make iommu_dma_prepare_msi() into a generic operation

On 2025-02-20 1:31 am, Nicolin Chen wrote: From: Jason Gunthorpe SW_MSI supports IOMMU to translate an MSI message before the MSI message is delivered to the interrupt controller. On such systems, an iommu_domain must have a translation for the MSI message for interrupts to work. The IRQ subsy

Re: [PATCH v2 7/7] iommu: Turn iova_cookie to dma-iommu private pointer

On 2025-02-21 2:39 pm, Jason Gunthorpe wrote: On Wed, Feb 19, 2025 at 05:31:42PM -0800, Nicolin Chen wrote: Now that iommufd does not rely on dma-iommu.c for any purpose. We can combine the dma-iommu.c iova_cookie and the iommufd_hwpt under the same union. This union is effectively 'owner data'

Re: [PATCH v2 0/7] iommu: Add MSI mapping support with nested SMMU (Part-1 core)

On Wed, Feb 19, 2025 at 05:31:35PM -0800, Nicolin Chen wrote: > > Jason Gunthorpe (5): > genirq/msi: Store the IOMMU IOVA directly in msi_desc instead of > iommu_cookie > genirq/msi: Refactor iommu_dma_compose_msi_msg() > iommu: Make iommu_dma_prepare_msi() into a generic operation > i

Re: [PATCH v2 6/7] iommufd: Implement sw_msi support natively

On Wed, Feb 19, 2025 at 05:31:41PM -0800, Nicolin Chen wrote: > +/* > + * Get a iommufd_sw_msi_map for the msi physical address requested by the irq > + * layer. The mapping to IOVA is global to the iommufd file descriptor, every > + * domain that is attached to a device using the same MSI paramet

Re: [PATCH v2 4/7] irqchip: Have CONFIG_IRQ_MSI_IOMMU be selected by irqchips that need it

> --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -154,7 +154,6 @@ config IOMMU_DMA > select DMA_OPS_HELPERS > select IOMMU_API > select IOMMU_IOVA > - select IRQ_MSI_IOMMU > select NEED_SG_DMA_LENGTH > select NEED_SG_DMA_FLAGS if SWIOTLB Because of

Re: [PATCH v2 7/7] iommu: Turn iova_cookie to dma-iommu private pointer

On Wed, Feb 19, 2025 at 05:31:42PM -0800, Nicolin Chen wrote: > Now that iommufd does not rely on dma-iommu.c for any purpose. We can > combine the dma-iommu.c iova_cookie and the iommufd_hwpt under the same > union. This union is effectively 'owner data' and can be used by the > entity that alloca

Re: [PATCH v2 1/7] genirq/msi: Store the IOMMU IOVA directly in msi_desc instead of iommu_cookie

On Fri, Feb 21, 2025 at 10:28:20AM +0100, Thomas Gleixner wrote: > On Wed, Feb 19 2025 at 17:31, Nicolin Chen wrote: > > Fix the MSI cookie UAF by removing the cookie pointer. The translated IOVA > > address is already known during iommu_dma_prepare_msi() and cannot change. > > Thus, it can simply

Re: [PATCH v2 1/7] genirq/msi: Store the IOMMU IOVA directly in msi_desc instead of iommu_cookie

Hi Jason, On Fri, Feb 21, 2025 at 09:41:12AM -0400, Jason Gunthorpe wrote: > Can I send you a PR instead? I'd like it on a branch so we can work on > the iommufd specific bits that where in v1. Yes, that works as well. Thanks, Joerg

Re: [PATCH v2 1/7] genirq/msi: Store the IOMMU IOVA directly in msi_desc instead of iommu_cookie

On Fri, Feb 21, 2025 at 12:10:46PM +0100, Joerg Roedel wrote: > Hi Nicolin, > > On Fri, Feb 21, 2025 at 10:28:20AM +0100, Thomas Gleixner wrote: > > On Wed, Feb 19 2025 at 17:31, Nicolin Chen wrote: > > > Fix the MSI cookie UAF by removing the cookie pointer. The translated IOVA > > > address is a

[PATCH v2 2/2] selftests: sched: skip cs_prctl_test for systems with core scheduling disabled

For kernels with CONFIG_SCHED_CORE=n, the sched selftest cs_prctl_test fails with "Not a core sched system" error. Change this to gracefully skip the test for systems with core scheduling disabled. Exiting early would also ensure failures reported in obtaining cookie are valid failures and not due

[PATCH v2 1/2] selftests: sched: add sched as a default selftest target

The sched tests are missing a target entry and hence out-of-tree build support. For instance: make -C tools/testing/selftests install INSTALL_PATH=/foo/bar is expected to build the sched tests and place them at /foo/bar. But this is not observed since a TARGET entry is not present for sched. Thi

[PATCH v2 0/2] selftests: sched: Add default target support for sched

This patch series introduces changes to add default build support for the sched tests in selftests. The only test under sched is cs_prctl_test which validates cookies when core scheduling is in effect. This test fails on systems where core scheduling is disabled. The patch series also modifies thi

Re: [PATCH v2 1/7] genirq/msi: Store the IOMMU IOVA directly in msi_desc instead of iommu_cookie

Hi Nicolin, On Fri, Feb 21, 2025 at 10:28:20AM +0100, Thomas Gleixner wrote: > On Wed, Feb 19 2025 at 17:31, Nicolin Chen wrote: > > Fix the MSI cookie UAF by removing the cookie pointer. The translated IOVA > > address is already known during iommu_dma_prepare_msi() and cannot change. > > Thus, i

Re: [PATCH 0/4] mm: permit guard regions for file-backed/shmem mappings

On Thu, Feb 20, 2025 at 10:08:36AM -0800, Kalesh Singh wrote: > On Thu, Feb 20, 2025 at 8:22 AM Suren Baghdasaryan wrote: > > > > On Thu, Feb 20, 2025 at 5:18 AM Lorenzo Stoakes > > wrote: > > > > > > On Thu, Feb 20, 2025 at 01:44:20PM +0100, David Hildenbrand wrote: > > > > On 20.02.25 11:15, Lo

Re: [PATCH v3 3/4] kernel: globalize lookup_or_create_module_kobject()

On Thu, Feb 13 2025, Petr Pavlu wrote: > On 2/11/25 22:48, Shyam Saini wrote: >> lookup_or_create_module_kobject() is marked as static and __init, >> to make it global drop static keyword. >> Since this function can be called from non-init code, use __modinit >> instead of __init, __modinit marke

Re: [PATCH v3 2/4] kernel: refactor lookup_or_create_module_kobject()

On Thu, Feb 13 2025, Petr Pavlu wrote: > On 2/11/25 22:48, Shyam Saini wrote: >> In the unlikely event of the allocation failing, it is better to let >> the machine boot with a not fully populated sysfs than to kill it with >> this BUG_ON(). All callers are already prepared for >> lookup_or_creat

[PATCH sysctl-next v2] selftests/sysctl: fix wording of help messages

Fix grammar such as "number amount of times is recommended" etc -> "the recommended number of times". Signed-off-by: Bharadwaj Raju --- tools/testing/selftests/sysctl/sysctl.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/sysctl/sysctl.sh b/t

[PATCH bpf-next 2/2] selftests/bpf: Migrate test_xdp_vlan.sh into test_progs

test_xdp_vlan.sh isn't used by the BPF CI. Migrate test_xdp_vlan.sh in prog_tests/xdp_vlan.c. It uses the same BPF programs located in progs/test_xdp_vlan.c and the same network topology. Remove test_xdp_vlan*.sh and their Makefile entries. Signed-off-by: Bastien Curutchet (eBPF Foundation) ---

[PATCH bpf-next 1/2] selftests/bpf: test_xdp_vlan: Rename BPF sections

The __load() helper expects BPF sections to be names 'xdp' or 'tc' Rename BPF sections so they can be loaded with the __load() helper in upcoming patch. Rename the BPF functions with their previous section's name. Update the 'ip link' commands in the script to use the program name instead of the s

Re: [ANNOUNCE] 5.10.234-rt126

On 19.02.25 23:07, Luis Claudio R. Goncalves wrote: > Hello RT-list! > > I'm pleased to announce the 5.10.234-rt126 stable release. > > This release is just an update to the new stable 5.10.234 version and > no RT-specific changes have been made. > Was [1] coming too late for this release cycle

Re: [PATCH v2 4/7] irqchip: Have CONFIG_IRQ_MSI_IOMMU be selected by irqchips that need it

On Wed, Feb 19 2025 at 17:31, Nicolin Chen wrote: > From: Jason Gunthorpe > > Currently, IRQ_MSI_IOMMU is selected if DMA_IOMMU is available to provide > an implementation for iommu_dma_prepare/compose_msi_msg(). However, it'll > make more sense for irqchips that call prepare/compose to select it

Re: [PATCH v2 2/7] genirq/msi: Refactor iommu_dma_compose_msi_msg()

On Wed, Feb 19 2025 at 17:31, Nicolin Chen wrote: > From: Jason Gunthorpe > > The two-step process to translate the MSI address involves two functions, > iommu_dma_prepare_msi() and iommu_dma_compose_msi_msg(). > > Previously iommu_dma_compose_msi_msg() needed to be in the iommu layer as > it had

Re: [PATCH v2 1/7] genirq/msi: Store the IOMMU IOVA directly in msi_desc instead of iommu_cookie

On Wed, Feb 19 2025 at 17:31, Nicolin Chen wrote: > Fix the MSI cookie UAF by removing the cookie pointer. The translated IOVA > address is already known during iommu_dma_prepare_msi() and cannot change. > Thus, it can simply be stored as an integer in the MSI descriptor. > > A following patch will

Re: [PATCH] selftests: sched: add sched as a default selftest target

On 21-02-2025 11:30 am, Chris Hyser wrote: From: Chris Hyser Sent: Thursday, February 20, 2025 11:21 PM To: Sinadin Shan; Shrikanth Hegde Cc: linux-kselft...@vger.kernel.org; linux-kernel@vger.kernel.org; sh...@kernel.org Subject: Re: [PATCH] selftests: sched: add sched as a default selftest

Re: [PATCH] selftests/sysctl: fix wording of help messages

On Sun, Feb 16, 2025 at 11:31:50AM +0530, Bharadwaj Raju wrote: > Fix paramter -> parameter, and recomended -> > recommended in sysctl.sh's help messages. > > Also correct grammar: "number amount of times > is recommended" etc -> "the recommended number of > times". > > Signed-off-by: Bharadwaj R

Re: [PATCH] selftests: fix spelling/grammar errors in sysctl/sysctl.sh

On Tue, Jan 28, 2025 at 04:06:55PM +0530, Chandra Pratap wrote: > Fix the grammatical/spelling errors in sysctl/sysctl.sh. > This fixes all errors pointed out by codespell in the file. > > Signed-off-by: Chandra Pratap > --- > tools/testing/selftests/sysctl/sysctl.sh | 6 +++--- > 1 file changed