Re: [PATCH net 0/2] bond: fix xfrm offload feature during init

2025-01-20 Thread Hangbin Liu
On Mon, Jan 20, 2025 at 04:16:49PM +, Cosmin Ratiu wrote: > On Fri, 2025-01-17 at 08:54 +0100, Steffen Klassert wrote: > > > > > > Hi Jianbo, > > > > > > I talked with Sabrina and it looks we can't simply do this. Because > > > both > > > xfrm_add_sa_expire() and xfrm_timer_handler() calling

Re: [PATCH] selftests/.gitignore include missing log file

2025-01-20 Thread Shuah Khan
On 1/16/25 01:59, Khaled Elnaggar wrote: Add tpm2/AsyncTest.log to .gitignore Signed-off-by: Khaled Elnaggar --- Hello After running kselftests, AsyncTest.log file showed when running git status. I just added it. --- tools/testing/selftests/.gitignore | 1 + 1 file changed, 1 insertion(+)

Re: [RFC PATCH 27/39] KVM: guest_memfd: Allow mmapping guest_memfd files

2025-01-20 Thread Peter Xu
On Tue, Sep 10, 2024 at 11:43:58PM +, Ackerley Tng wrote: > @@ -790,6 +791,9 @@ static long kvm_gmem_punch_hole(struct inode *inode, > loff_t offset, loff_t len) >*/ > filemap_invalidate_lock(inode->i_mapping); > > + /* TODO: Check if even_cows should be 0 or 1 */ > + u

Re: [PATCH v2 0/5] Move kvfree_rcu() into SLAB (v2)

2025-01-20 Thread Vlastimil Babka
On 12/16/24 17:46, Paul E. McKenney wrote: > On Mon, Dec 16, 2024 at 04:55:06PM +0100, Uladzislau Rezki wrote: >> On Mon, Dec 16, 2024 at 04:44:41PM +0100, Vlastimil Babka wrote: >> > On 12/16/24 16:41, Uladzislau Rezki wrote: >> > > On Mon, Dec 16, 2024 at 03:20:44PM +0100, Vlastimil Babka wrote:

Re: [PATCH net-next v18 20/25] ovpn: implement peer add/get/dump/delete via netlink

2025-01-20 Thread Antonio Quartulli
On 20/01/2025 11:45, Antonio Quartulli wrote: [...] I'm not sure what this (and the peer flushing on NETDEV_DOWN) is trying to accomplish. Is it a problem to keep peers when the netdevice is down? This is the result of my discussion with Sergey that started in v23 5/23: https://lore.kernel

Re: [GIT PULL] slab updates for 6.14

2025-01-20 Thread Vlastimil Babka
On 1/20/25 18:54, Sasha Levin wrote: > On Fri, Jan 17, 2025 at 03:13:18PM +0100, Vlastimil Babka wrote: >>Hi Linus, >> >>please pull the latest slab updates from: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git >> tags/slab-for-6.14 > > Hi Vlastimil, Hi, > I've ended up pul

Re: [PATCH] selftests/mm/cow : Fix memory leak in child_vmsplice_memcmp_fn()

2025-01-20 Thread David Hildenbrand
On 15.01.25 06:45, liuye wrote: 在 2025/1/14 18:23, David Hildenbrand 写道: On 14.01.25 03:29, liuye wrote: Release memory before exception branch returns to prevent memory leaks. Signed-off-by: liuye ---   tools/testing/selftests/mm/cow.c | 21 -   1 file changed, 16

Re: [PATCH v2 0/6] Extend pmu_counters_test to AMD CPUs

2025-01-20 Thread Colton Lewis
Sean Christopherson writes: On Wed, 18 Sep 2024 20:53:13 +, Colton Lewis wrote: Extend pmu_counters_test to AMD CPUs. As the AMD PMU is quite different from Intel with different events and feature sets, this series introduces a new code path to test it, specifically focusing on the core

Re: [PATCH v2 6/6] KVM: x86: selftests: Test PerfMonV2

2025-01-20 Thread Colton Lewis
Sean Christopherson writes: On Wed, Sep 18, 2024, Colton Lewis wrote: Test PerfMonV2, which defines global registers to enable multiple performance counters with a single MSR write, in its own function. If the feature is available, ensure the global control register has the ability to start

Re: [PATCH v2 5/6] KVM: x86: selftests: Test core events

2025-01-20 Thread Colton Lewis
Sean Christopherson writes: On Wed, Sep 18, 2024, Colton Lewis wrote: Test events on core counters by iterating through every combination of events in amd_pmu_zen_events with every core counter. For each combination, calculate the appropriate register addresses for the event selection/contr

Re: [PATCH v2 4/6] KVM: x86: selftests: Test read/write core counters

2025-01-20 Thread Colton Lewis
Sean Christopherson writes: On Wed, Sep 18, 2024, Colton Lewis wrote: Run a basic test to ensure we can write an arbitrary value to the core counters and read it back. Signed-off-by: Colton Lewis --- .../selftests/kvm/x86_64/pmu_counters_test.c | 54 +++ 1 file changed,

Re: [PATCH net V3] selftests/net/ipsec: Fix Null pointer dereference in rtattr_pack()

2025-01-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Thu, 16 Jan 2025 09:30:37 +0800 you wrote: > From: Liu Ye > > Address Null pointer dereference in rtattr_pack. > > Flagged by cppcheck as: > tools/testing/selftests/net/ipsec.c:230:25: warning: Possible null

Re: [GIT PULL] slab updates for 6.14

2025-01-20 Thread Sasha Levin
On Fri, Jan 17, 2025 at 03:13:18PM +0100, Vlastimil Babka wrote: Hi Linus, please pull the latest slab updates from: git://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git tags/slab-for-6.14 Hi Vlastimil, I've ended up pulling quite a few of the 6.14 PRs into linus-next, and LKFT st

Re: [PATCH v2 3/6] KVM: x86: selftests: Set up AMD VM in pmu_counters_test

2025-01-20 Thread Colton Lewis
Hey Sean, Thanks for the review. Sean Christopherson writes: On Wed, Sep 18, 2024, Colton Lewis wrote: Branch in main() depending on if the CPU is Intel or AMD. They are subject to vastly different requirements because the AMD PMU lacks many properties defined by the Intel PMU including the

Re: [PATCH v2 2/6] KVM: x86: selftests: Define AMD PMU CPUID leaves

2025-01-20 Thread Colton Lewis
Noted about the changelog and the ordering. No objections for how you want to apply it. Sean Christopherson writes: The shortlog is misleading. It's the *leaves* that are being defined, it's the features and properties. On Wed, Sep 18, 2024, Colton Lewis wrote: This defined the CPUID ca

Re: [PATCH net 0/2] bond: fix xfrm offload feature during init

2025-01-20 Thread Cosmin Ratiu
On Fri, 2025-01-17 at 08:54 +0100, Steffen Klassert wrote: > > > > Hi Jianbo, > > > > I talked with Sabrina and it looks we can't simply do this. Because > > both > > xfrm_add_sa_expire() and xfrm_timer_handler() calling > > __xfrm_state_delete() under > > spin lock. If we move the xfrm_dev_state

[GIT PULL] livepatching for 6.14

2025-01-20 Thread Petr Mladek
Hi Linus, please pull the latest changes for the kernel livepatching from git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git tags/livepatching-for-6.14 == - Add a sysfs attribute showing the livepatch ordering. - Some code clean up. -

Re: [PATCH net-next v18 20/25] ovpn: implement peer add/get/dump/delete via netlink

2025-01-20 Thread Antonio Quartulli
On 17/01/2025 12:48, Sabrina Dubroca wrote: [...] 8< diff --git a/drivers/net/ovpn/netlink.c b/drivers/net/ovpn/netlink.c index 72357bb5f30b..19aa4ee6d468 100644 --- a/drivers/net/ovpn/netlink.c +++ b/drivers/net/ovpn/netlink.c @@ -733,6 +733,9 @@ int ovpn_nl_peer_del_doit(stru

Re: [PATCH RFCv2 06/13] iommufd: Make attach_handle generic

2025-01-20 Thread Jason Gunthorpe
On Sat, Jan 18, 2025 at 12:32:49PM -0800, Nicolin Chen wrote: > On Sat, Jan 18, 2025 at 04:23:22PM +0800, Yi Liu wrote: > > On 2025/1/11 11:32, Nicolin Chen wrote: > > > "attach_handle" was added exclusively for the iommufd_fault_iopf_handler() > > > used by IOPF/PRI use cases, along with the "faul

Re: [PATCH net-next v18 12/25] ovpn: implement TCP transport

2025-01-20 Thread Antonio Quartulli
On 17/01/2025 18:14, Sabrina Dubroca wrote: 2025-01-13, 10:31:31 +0100, Antonio Quartulli wrote: +static int ovpn_tcp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, + int flags, int *addr_len) +{ + int err = 0, off, copied = 0, ret; + struct ovpn_s

Re: [PATCH v1 1/2] mm: Clear uffd-wp PTE/PMD state on mremap()

2025-01-20 Thread David Hildenbrand
On 16.01.25 10:04, Ryan Roberts wrote: On 15/01/2025 20:28, Peter Xu wrote: On Tue, Jan 07, 2025 at 02:47:52PM +, Ryan Roberts wrote: When mremap()ing a memory region previously registered with userfaultfd as write-protected but without UFFD_FEATURE_EVENT_REMAP, an inconsistency in flag cle

Re: [PATCH v7 07/16] rust: add `io::{Io, IoRaw}` base types

2025-01-20 Thread Danilo Krummrich
On 1/16/25 11:31 AM, Fiona Behrens wrote: On 19 Dec 2024, at 18:04, Danilo Krummrich wrote: +impl Io { +/// Converts an `IoRaw` into an `Io` instance, providing the accessors to the MMIO mapping. +/// +/// # Safety +/// +/// Callers must ensure that `addr` is the start of

Re: [PATCH v4] vdpa: solidrun: Replace deprecated PCI functions

2025-01-20 Thread Michael S. Tsirkin
On Mon, Jan 20, 2025 at 10:13:03AM +0100, Philipp Stanner wrote: > On Thu, 2024-12-19 at 10:51 +0100, Stefano Garzarella wrote: > > On Thu, Dec 19, 2024 at 10:44:29AM +0100, Philipp Stanner wrote: > > > From: Philipp Stanner > > > > > > The PCI functions > > > > > > pcim_iomap_regions() > > >

Re: [PATCH net-next v18 20/25] ovpn: implement peer add/get/dump/delete via netlink

2025-01-20 Thread Antonio Quartulli
On 20/01/2025 11:09, Sabrina Dubroca wrote: 2025-01-19, 14:12:05 +0100, Antonio Quartulli wrote: On 17/01/2025 18:12, Sabrina Dubroca wrote: 2025-01-17, 13:59:35 +0100, Antonio Quartulli wrote: On 17/01/2025 12:48, Sabrina Dubroca wrote: 2025-01-13, 10:31:39 +0100, Antonio Quartulli wrote:

Re: [PATCH net-next v18 20/25] ovpn: implement peer add/get/dump/delete via netlink

2025-01-20 Thread Sabrina Dubroca
2025-01-19, 14:12:05 +0100, Antonio Quartulli wrote: > On 17/01/2025 18:12, Sabrina Dubroca wrote: > > 2025-01-17, 13:59:35 +0100, Antonio Quartulli wrote: > > > On 17/01/2025 12:48, Sabrina Dubroca wrote: > > > > 2025-01-13, 10:31:39 +0100, Antonio Quartulli wrote: > > > > >int ovpn_nl_peer_ne

Re: [PATCH RFC v3 02/10] sched_getattr: port to copy_struct_to_user

2025-01-20 Thread Florian Weimer
* Xi Ruoyao: >> > So should we drop the test before Glibc-2.41 release?  I'm seeing the >> > failure during my machine test. >> I was waiting for a verdict from the kernel developers.  I didn't expect >> such a change to happen given the alleged UAPI policy. > > But 6.13 is already released withou

Re: [PATCH RFC v3 02/10] sched_getattr: port to copy_struct_to_user

2025-01-20 Thread Xi Ruoyao
On Mon, 2025-01-20 at 06:28 +0100, Florian Weimer wrote: > * Xi Ruoyao: > > > On Wed, 2024-12-11 at 11:23 +0100, Christian Brauner wrote: > > > On Tue, Dec 10, 2024 at 07:14:07PM +0100, Florian Weimer wrote: > > > > * Aleksa Sarai: > > > > > > > > > sched_getattr(2) doesn't care about trailing no

Re: [PATCH v4] vdpa: solidrun: Replace deprecated PCI functions

2025-01-20 Thread Philipp Stanner
On Thu, 2024-12-19 at 10:51 +0100, Stefano Garzarella wrote: > On Thu, Dec 19, 2024 at 10:44:29AM +0100, Philipp Stanner wrote: > > From: Philipp Stanner > > > > The PCI functions > > > > pcim_iomap_regions() > > pcim_iounmap_regions() > > pcim_iomap_table() > > > > have been deprec