Re: [PATCH 0/3 v2] hrtimer: Fix timers queued locally from offline CPUs

2024-12-31 Thread Paul E. McKenney
On Fri, Dec 27, 2024 at 12:30:49AM +0100, Frederic Weisbecker wrote: > 5c0930ccaad5 ("hrtimers: Push pending hrtimers away from outgoing CPU > earlier") > was introduced to fix stalls with scheduler bandwidth timers getting > migrated while some kthreads handling CPU hotplug rely on bandwidth. >

Re: [PATCH v4 3/3] selftests: pci_endpoint: Migrate to Kselftest framework

2024-12-31 Thread Niklas Cassel
On 31 December 2024 20:18:12 CET, Manivannan Sadhasivam wrote: >On Tue, Dec 31, 2024 at 06:42:42PM +0100, Niklas Cassel wrote: >> On Tue, Dec 31, 2024 at 06:43:41PM +0530, Manivannan Sadhasivam wrote: >> >> (...) >> >> > + # RUN pci_ep_data_transfer.dma.COPY_TEST ... >> > + #

Re: [PATCH v4 3/3] selftests: pci_endpoint: Migrate to Kselftest framework

2024-12-31 Thread Manivannan Sadhasivam
On Tue, Dec 31, 2024 at 06:42:42PM +0100, Niklas Cassel wrote: > On Tue, Dec 31, 2024 at 06:43:41PM +0530, Manivannan Sadhasivam wrote: > > (...) > > > + # RUN pci_ep_data_transfer.dma.COPY_TEST ... > > + #OK pci_ep_data_transfer.dma.COPY_TEST > > + ok 11 pci_ep_data

Re: [PATCH v4 2/3] selftests: Move PCI Endpoint tests from tools/pci to Kselftests

2024-12-31 Thread Manivannan Sadhasivam
On Tue, Dec 31, 2024 at 06:17:05PM +0100, Niklas Cassel wrote: > On Tue, Dec 31, 2024 at 06:43:40PM +0530, Manivannan Sadhasivam wrote: > > This just moves the existing tests under tools/pci to > > tools/testing/selftests/pci_endpoint and adjusts the paths in Makefile > > accordingly. Migration to

Re: [PATCH v4 1/3] misc: pci_endpoint_test: Fix the return value of IOCTL

2024-12-31 Thread Manivannan Sadhasivam
On Tue, Dec 31, 2024 at 05:57:47PM +0100, Niklas Cassel wrote: > On Tue, Dec 31, 2024 at 06:43:39PM +0530, Manivannan Sadhasivam wrote: > > IOCTLs are supposed to return 0 for success and negative error codes for > > failure. Currently, this driver is returning 0 for failure and 1 for > > success,

Re: Linux 6.1.120

2024-12-31 Thread Conor Dooley
On Mon, Dec 30, 2024 at 03:47:26PM +0100, Greg Kroah-Hartman wrote: > > > > > For v6.1.x kernels, the cblist_init_generic() is invoke in init task > > > > > context, > > > > > rtp->rtpcp_array is allocated use GFP_KERENL and in the critical > > > > > section > > > > > holding rcu_tasks.cbs_gbl_l

Re: [PATCH v4 3/3] selftests: pci_endpoint: Migrate to Kselftest framework

2024-12-31 Thread Niklas Cassel
On Tue, Dec 31, 2024 at 06:43:41PM +0530, Manivannan Sadhasivam wrote: (...) > + # RUN pci_ep_data_transfer.dma.COPY_TEST ... > + #OK pci_ep_data_transfer.dma.COPY_TEST > + ok 11 pci_ep_data_transfer.dma.COPY_TEST > + # PASSED: 11 / 11 tests passed. > +

Re: [PATCH v4 2/3] selftests: Move PCI Endpoint tests from tools/pci to Kselftests

2024-12-31 Thread Niklas Cassel
On Tue, Dec 31, 2024 at 06:43:40PM +0530, Manivannan Sadhasivam wrote: > This just moves the existing tests under tools/pci to > tools/testing/selftests/pci_endpoint and adjusts the paths in Makefile > accordingly. Migration to Kselftest framework will be done in subsequent > commits. > > Signed-o

[PATCH 3/3 v3] Revert "rcu/nocb: Fix rcuog wake-up from offline softirq"

2024-12-31 Thread Frederic Weisbecker
This reverts commit f7345ccc62a4b880cf76458db5f320725f28e400. swake_up_one_online() has been removed because hrtimers can now assign a proper online target to hrtimers queued from offline CPUs. Therefore remove the related hackery. Reviewed-by: Usama Arif Signed-off-by: Frederic Weisbecker ---

[PATCH 2/3 v3] rcu: Remove swake_up_one_online() bandaid

2024-12-31 Thread Frederic Weisbecker
It's now ok to perform a wake-up from an offline CPU because the resulting armed scheduler bandwidth hrtimers are now correctly targeted by hrtimer infrastructure. Remove the obsolete hackerry. Reviewed-by: Usama Arif Signed-off-by: Frederic Weisbecker --- kernel/rcu/tree.c | 34 +

[PATCH 1/3 v3] hrtimers: Force migrate away hrtimers queued after CPUHP_AP_HRTIMERS_DYING

2024-12-31 Thread Frederic Weisbecker
hrtimers are migrated away from the dying CPU to any online target at the CPUHP_AP_HRTIMERS_DYING stage in order not to delay bandwidth timers handling tasks involved in the CPU hotplug forward progress. However wake ups can still be performed by the outgoing CPU after CPUHP_AP_HRTIMERS_DYING. Tho

[PATCH 0/3 v3] hrtimer: Fix timers queued locally from offline CPUs

2024-12-31 Thread Frederic Weisbecker
5c0930ccaad5 ("hrtimers: Push pending hrtimers away from outgoing CPU earlier") was introduced to fix stalls with scheduler bandwidth timers getting migrated while some kthreads handling CPU hotplug rely on bandwidth. However this has introduced several other issues which used to be confined to RC

Re: [PATCH v4 1/3] misc: pci_endpoint_test: Fix the return value of IOCTL

2024-12-31 Thread Niklas Cassel
On Tue, Dec 31, 2024 at 06:43:39PM +0530, Manivannan Sadhasivam wrote: > IOCTLs are supposed to return 0 for success and negative error codes for > failure. Currently, this driver is returning 0 for failure and 1 for > success, that's not correct. Hence, fix it! > > Reported-by: Greg Kroah-Hartman

[PATCH v4 3/3] selftests: pci_endpoint: Migrate to Kselftest framework

2024-12-31 Thread Manivannan Sadhasivam
Migrate the PCI endpoint test to Kselftest framework. All the tests that were part of the previous pcitest.sh file were migrated. Below is the exclusive list of tests: 1. BAR Tests (BAR0 to BAR5) 2. Consecutive BAR Tests 3. Legacy IRQ Tests 4. MSI Interrupt Tests (MSI1 to MSI32) 5. MSI-X Interrup

[PATCH v4 2/3] selftests: Move PCI Endpoint tests from tools/pci to Kselftests

2024-12-31 Thread Manivannan Sadhasivam
This just moves the existing tests under tools/pci to tools/testing/selftests/pci_endpoint and adjusts the paths in Makefile accordingly. Migration to Kselftest framework will be done in subsequent commits. Signed-off-by: Manivannan Sadhasivam --- Documentation/PCI/endpoint/pci-test-howto.rst

[PATCH v4 1/3] misc: pci_endpoint_test: Fix the return value of IOCTL

2024-12-31 Thread Manivannan Sadhasivam
IOCTLs are supposed to return 0 for success and negative error codes for failure. Currently, this driver is returning 0 for failure and 1 for success, that's not correct. Hence, fix it! Reported-by: Greg Kroah-Hartman Closes: https://lore.kernel.org/all/yvzng5ronxeap...@kroah.com Fixes: 2c156ac71

[PATCH v4 0/3] Migrate PCI Endpoint Subsystem tests to Kselftest

2024-12-31 Thread Manivannan Sadhasivam
Hi, This series carries forward the effort to add Kselftest for PCI Endpoint Subsystem started by Aman Gupta [1] a while ago. I reworked the initial version based on another patch that fixes the return values of IOCTLs in pci_endpoint_test driver and did many cleanups. Since the resulting work mod

Re: [PATCH v2 0/3] sysfs: constify bin_attribute argument of sysfs_bin_attr_simple_read()

2024-12-31 Thread Thomas Weißschuh
On 2024-12-30 16:50:41-0800, Alexei Starovoitov wrote: > On Sat, Dec 28, 2024 at 12:43 AM Thomas Weißschuh > wrote: > > > > Most users use this function through the BIN_ATTR_SIMPLE* macros, > > they can handle the switch transparently. > > > > This series is meant to be merged through the driver