Re: [PATCH RFC] Makefile: Export absolute srctree path for out-of-tree builds

2024-12-20 Thread Masahiro Yamada
On Tue, Dec 17, 2024 at 12:10 PM Li Zhijian wrote: > > Fixes an issue where out-of-tree kselftest builds fail when building > the BPF and bpftools components. The failure occurs because the top-level > Makefile passes a relative srctree path ('..') to its sub-Makefiles, which > leads to errors in

RE: [PATCH bpf] selftests/bpf: add XDP_UMEM_TX_METADATA_LEN flag to umem_config

2024-12-20 Thread Wei Fang
> On Fri, Dec 20, 2024 at 05:18:06PM +0800, Wei Fang wrote: > > The Tx metadata test has been broken since the commit d5e726d9143c > ("xsk: > > Require XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"). > > Nit: > > Fixes tag already include this information. > > The Tx metadata test has bee

RE: [PATCH bpf] selftests/bpf: add XDP_UMEM_TX_METADATA_LEN flag to umem_config

2024-12-20 Thread Wei Fang
> On 12/20, Wei Fang wrote: > > The Tx metadata test has been broken since the commit d5e726d9143c > ("xsk: > > Require XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"). > Because > > this change requires XDP_UMEM_TX_METADATA_LEN flag to be set, > > otherwise xsk_buff_pool::tx_metadata_len wil

Re: [PATCH 0/3] hrtimer: Fix timers queued locally from offline CPUs

2024-12-20 Thread Paul E. McKenney
On Sat, Dec 21, 2024 at 12:26:01AM +0100, Frederic Weisbecker wrote: > Le Fri, Dec 20, 2024 at 03:19:31PM -0800, Paul E. McKenney a écrit : > > On Thu, Dec 19, 2024 at 09:42:48AM -0800, Paul E. McKenney wrote: > > > On Wed, Dec 18, 2024 at 05:50:05PM +0100, Frederic Weisbecker wrote: > > > > 5c0930

Re: [PATCH 1/3] hrtimers: Force migrate away hrtimers queued after CPUHP_AP_HRTIMERS_DYING

2024-12-20 Thread Frederic Weisbecker
Le Thu, Dec 19, 2024 at 10:00:12PM +0300, Usama Arif a écrit : > > @@ -1240,6 +1280,12 @@ static int __hrtimer_start_range_ns(struct hrtimer > > *timer, ktime_t tim, > > > > hrtimer_set_expires_range_ns(timer, tim, delta_ns); > > > > + if (unlikely(!this_cpu_base->online)) { > > +

Re: [PATCH 0/3] hrtimer: Fix timers queued locally from offline CPUs

2024-12-20 Thread Frederic Weisbecker
Le Fri, Dec 20, 2024 at 03:19:31PM -0800, Paul E. McKenney a écrit : > On Thu, Dec 19, 2024 at 09:42:48AM -0800, Paul E. McKenney wrote: > > On Wed, Dec 18, 2024 at 05:50:05PM +0100, Frederic Weisbecker wrote: > > > 5c0930ccaad5 ("hrtimers: Push pending hrtimers away from outgoing CPU > > > earlie

Re: [PATCH 0/3] hrtimer: Fix timers queued locally from offline CPUs

2024-12-20 Thread Paul E. McKenney
On Thu, Dec 19, 2024 at 09:42:48AM -0800, Paul E. McKenney wrote: > On Wed, Dec 18, 2024 at 05:50:05PM +0100, Frederic Weisbecker wrote: > > 5c0930ccaad5 ("hrtimers: Push pending hrtimers away from outgoing CPU > > earlier") > > was introduced to fix stalls with scheduler bandwidth timers getting

[PATCH v2 11/28] module: Use RCU in __is_module_percpu_address().

2024-12-20 Thread Sebastian Andrzej Siewior
The modules list can be accessed under RCU assumption. Use RCU protection instead preempt_disable(). Signed-off-by: Sebastian Andrzej Siewior --- kernel/module/main.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index 71e73

[PATCH v2 13/28] module: Use RCU in search_module_extables().

2024-12-20 Thread Sebastian Andrzej Siewior
search_module_extables() returns an exception_table_entry belonging to a module. The lookup via __module_address() can be performed with RCU protection. The returned exception_table_entry remains valid because the passed address usually belongs to a module that is currently executed. So the module

[PATCH v2 04/28] module: Use RCU in find_kallsyms_symbol().

2024-12-20 Thread Sebastian Andrzej Siewior
The modules list and module::kallsyms can be accessed under RCU assumption. Use rcu_dereference() to reference the kallsyms pointer in find_kallsyms_symbol(). Use a RCU section instead of preempt_disable in callers of find_kallsyms_symbol(). Keep the preempt-disable in module_address_lookup() due

[PATCH v2 26/28] static_call: Use RCU in all users of __module_text_address().

2024-12-20 Thread Sebastian Andrzej Siewior
__module_text_address() can be invoked within a RCU section, there is no requirement to have preemption disabled. Replace the preempt_disable() section around __module_text_address() with RCU. Signed-off-by: Sebastian Andrzej Siewior --- kernel/static_call_inline.c | 13 ++--- 1 file ch

[PATCH v2 18/28] LoongArch/orc: Use RCU in all users of __module_address().

2024-12-20 Thread Sebastian Andrzej Siewior
__module_address() can be invoked within a RCU section, there is no requirement to have preemption disabled. Replace the preempt_disable() section around __module_address() with RCU. Cc: Huacai Chen Cc: WANG Xuerui Cc: loonga...@lists.linux.dev Signed-off-by: Sebastian Andrzej Siewior --- arc

[PATCH v2 14/28] module: Use RCU in all users of __module_address().

2024-12-20 Thread Sebastian Andrzej Siewior
__module_address() can be invoked within a RCU section, there is no requirement to have preemption disabled. Replace the preempt_disable() section around __module_address() with RCU. Signed-off-by: Sebastian Andrzej Siewior --- include/linux/kallsyms.h | 3 +-- kernel/module/kallsyms.c | 5 +---

[PATCH v2 00/28] module: Use RCU instead of RCU-sched.

2024-12-20 Thread Sebastian Andrzej Siewior
Hi, This is an updated version of the inital post after PeterZ made me aware that there are users outside of the module directory. The goal is replace the mix auf rcu_read_lock(), rcu_read_lock_sched() and preempt_disable() with just rcu_read_lock(). I've splitted it into smaller chunks which can

[PATCH v2 12/28] module: Allow __module_address() to be called from RCU section.

2024-12-20 Thread Sebastian Andrzej Siewior
mod_find() uses either the modules list to find a module or a tree lookup (CONFIG_MODULES_TREE_LOOKUP). The list and the tree can both be iterated under RCU assumption (as well as RCU-sched). Remove module_assert_mutex_or_preempt() from __module_address() and entirely since __module_address() is t

[PATCH v2 07/28] module: Use RCU in __find_kallsyms_symbol_value().

2024-12-20 Thread Sebastian Andrzej Siewior
module::kallsyms can be accessed under RCU assumption. Use rcu_dereference() to access module::kallsyms. Update callers. Signed-off-by: Sebastian Andrzej Siewior --- kernel/module/kallsyms.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/kernel/module/kal

[PATCH v2 08/28] module: Use RCU in module_kallsyms_on_each_symbol().

2024-12-20 Thread Sebastian Andrzej Siewior
module::kallsyms can be accessed under RCU assumption. Use rcu_dereference() to access module::kallsyms. Update callers. Signed-off-by: Sebastian Andrzej Siewior --- kernel/module/kallsyms.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/module/kallsyms.c b/ker

[PATCH v2 16/28] ARM: module: Use RCU in all users of __module_text_address().

2024-12-20 Thread Sebastian Andrzej Siewior
__module_text_address() can be invoked within a RCU section, there is no requirement to have preemption disabled. Replace the preempt_disable() section around __module_text_address() with RCU. Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Sebastian Andrzej Siewior ---

[PATCH v2 28/28] cfi: Use RCU while invoking __module_address().

2024-12-20 Thread Sebastian Andrzej Siewior
__module_address() can be invoked within a RCU section, there is no requirement to have preemption disabled. I'm not sure if using rcu_read_lock() will introduce the regression that has been fixed in commit 14c4c8e41511a ("cfi: Use rcu_read_{un}lock_sched_notrace"). Cc: Elliot Berman Cc: Kees Co

[PATCH v2 27/28] bug: Use RCU instead RCU-sched to protect module_bug_list.

2024-12-20 Thread Sebastian Andrzej Siewior
The list module_bug_list relies on module_mutex for writer synchronisation. The list is already RCU style. The list removal is synchronized with modules' synchronize_rcu() in free_module(). Use RCU read lock protection instead of RCU-sched. Cc: Andrew Morton Signed-off-by: Sebastian Andrzej Siew

[PATCH v2 23/28] jump_label: Use RCU in all users of __module_text_address().

2024-12-20 Thread Sebastian Andrzej Siewior
__module_text_address() can be invoked within a RCU section, there is no requirement to have preemption disabled. Replace the preempt_disable() section around __module_text_address() with RCU. Cc: Ard Biesheuvel Cc: Jason Baron Cc: Josh Poimboeuf Cc: Peter Zijlstra Cc: Steven Rostedt Signed-

[PATCH v2 22/28] jump_label: Use RCU in all users of __module_address().

2024-12-20 Thread Sebastian Andrzej Siewior
__module_address() can be invoked within a RCU section, there is no requirement to have preemption disabled. Replace the preempt_disable() section around __module_address() with RCU. Cc: Ard Biesheuvel Cc: Jason Baron Cc: Josh Poimboeuf Cc: Peter Zijlstra Cc: Steven Rostedt Signed-off-by: Se

[PATCH v2 21/28] x86: Use RCU in all users of __module_address().

2024-12-20 Thread Sebastian Andrzej Siewior
__module_address() can be invoked within a RCU section, there is no requirement to have preemption disabled. Replace the preempt_disable() section around __module_address() with RCU. Cc: "H. Peter Anvin" Cc: Borislav Petkov Cc: Dave Hansen Cc: Ingo Molnar Cc: Josh Poimboeuf Cc: Peter Zijlstr

[PATCH v2 15/28] module: Use RCU in all users of __module_text_address().

2024-12-20 Thread Sebastian Andrzej Siewior
__module_text_address() can be invoked within a RCU section, there is no requirement to have preemption disabled. Replace the preempt_disable() section around __module_text_address() with RCU. Signed-off-by: Sebastian Andrzej Siewior --- kernel/module/main.c | 16 +--- 1 file change

[PATCH v2 09/28] module: Remove module_assert_mutex_or_preempt() from try_add_tainted_module().

2024-12-20 Thread Sebastian Andrzej Siewior
module_assert_mutex_or_preempt() is not needed in try_add_tainted_module(). The function checks for RCU-sched or the module_mutex to be acquired. The list_for_each_entry_rcu() below does the same check. Remove module_assert_mutex_or_preempt() from try_add_tainted_module(). Signed-off-by: Sebastia

[PATCH v2 10/28] module: Use RCU in find_symbol().

2024-12-20 Thread Sebastian Andrzej Siewior
module_assert_mutex_or_preempt() is not needed in find_symbol(). The function checks for RCU-sched or the module_mutex to be acquired. The list_for_each_entry_rcu() below does the same check. Remove module_assert_mutex_or_preempt() from try_add_tainted_module(). Use RCU protection to invoke find_s

[PATCH v2 05/28] module: Use RCU in module_get_kallsym().

2024-12-20 Thread Sebastian Andrzej Siewior
The modules list and module::kallsyms can be accessed under RCU assumption. Iterate the modules with RCU protection, use rcu_dereference() to access the kallsyms pointer. Signed-off-by: Sebastian Andrzej Siewior --- kernel/module/kallsyms.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletio

Re: [PATCH v3 3/3] drivers: base: test: Add ...find_device_by...(... NULL) tests

2024-12-20 Thread Shuah Khan
On 12/18/24 22:45, David Gow wrote: On Tue, 17 Dec 2024 at 04:12, Brian Norris wrote: We recently updated these device_match*() (and therefore, various *find_device_by*()) functions to return a consistent 'false' value when trying to match a NULL handle. Add tests for this. This provides regr

[PATCH v2 02/28] module: Begin to move from RCU-sched to RCU.

2024-12-20 Thread Sebastian Andrzej Siewior
The RCU usage in module was introduced in commit d72b37513cdfb ("Remove stop_machine during module load v2") and it claimed not to be RCU but similar. Then there was another improvement in commit e91defa26c527 ("module: don't use stop_machine on module load"). It become a mix of RCU and RCU-sched a

Re: [PATCH v3 1/3] drivers: base: Don't match devices with NULL of_node/fwnode/etc

2024-12-20 Thread Shuah Khan
On 12/18/24 22:45, David Gow wrote: On Tue, 17 Dec 2024 at 04:12, Brian Norris wrote: of_find_device_by_node(), bus_find_device_by_of_node(), bus_find_device_by_fwnode(), ..., all produce arbitrary results when provided with a NULL of_node, fwnode, ACPI handle, etc. This is counterintuitive, a

[PATCH v2 01/28] module: Extend the preempt disabled section in dereference_symbol_descriptor().

2024-12-20 Thread Sebastian Andrzej Siewior
dereference_symbol_descriptor() needs to obtain the module pointer belonging to pointer in order to resolve that pointer. The returned mod pointer is obtained under RCU-sched/ preempt_disable() guarantees and needs to be used within this section to ensure that the module is not removed in the meant

[PATCH v2 03/28] module: Use proper RCU assignment in add_kallsyms().

2024-12-20 Thread Sebastian Andrzej Siewior
add_kallsyms() assigns the RCU pointer module::kallsyms and setups the structures behind it which point to init-data. The module was not published yet, nothing can see the kallsyms pointer and the data behind it. Also module's init function was not yet invoked. There is no need to use rcu_dereferen

Re: [PATCH v3 1/3] drivers: base: Don't match devices with NULL of_node/fwnode/etc

2024-12-20 Thread Greg Kroah-Hartman
On Fri, Dec 20, 2024 at 10:33:51AM -0700, Shuah Khan wrote: > On 12/18/24 22:45, David Gow wrote: > > On Tue, 17 Dec 2024 at 04:12, Brian Norris wrote: > > > > > > of_find_device_by_node(), bus_find_device_by_of_node(), > > > bus_find_device_by_fwnode(), ..., all produce arbitrary results when >

Re: [PATCH RFC] Makefile: Export absolute srctree path for out-of-tree builds

2024-12-20 Thread Quentin Monnet
2024-12-17 11:10 UTC+0800 ~ Li Zhijian > Fixes an issue where out-of-tree kselftest builds fail when building > the BPF and bpftools components. The failure occurs because the top-level > Makefile passes a relative srctree path ('..') to its sub-Makefiles, which > leads to errors in locating neces

[PATCH AUTOSEL 6.12 29/29] bpf: consider that tail calls invalidate packet pointers

2024-12-20 Thread Sasha Levin
From: Eduard Zingerman [ Upstream commit 1a4607ffba35bf2a630aab299e34dd3f6e658d70 ] Tail-called programs could execute any of the helpers that invalidate packet pointers. Hence, conservatively assume that each tail call invalidates packet pointers. Making the change in bpf_helper_changes_pkt_da

Re: [PATCH] selftests/run_kselftest.sh: Fix help string for --per-test-log

2024-12-20 Thread Shuah
On 12/20/24 09:12, Brendan Jackman wrote: This is documented as --per_test_log but the argument is actually --per-test-log. Signed-off-by: Brendan Jackman --- tools/testing/selftests/run_kselftest.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/

Re: [PATCH] nvmem: qcom-spmi-sdam: Set size in struct nvmem_config

2024-12-20 Thread Srinivas Kandagatla
On Fri, 20 Dec 2024 13:22:07 +0100, Luca Weiss wrote: > Let the nvmem core know what size the SDAM is, most notably this fixes > the size of /sys/bus/nvmem/devices/spmi_sdam*/nvmem being '0' and makes > user space work with that file. > > ~ # hexdump -C -s 64 /sys/bus/nvmem/devices/spmi_sdam2/

Re: [PATCH v6 2/2] selftests: tmpfs: Add kselftest support to tmpfs

2024-12-20 Thread Shuah
On 12/19/24 08:29, Shivam Chaudhary wrote: Replace direct error handling with 'ksft_test_result_*' macros for better reporting. Test logs: Before change: - Without root error: unshare, errno 1 - With root No, output After change: - Without root TAP version 13 1..1 ok 2 # SKIP This test ne

Re: [PATCH v7 00/16] Device / Driver PCI / Platform Rust abstractions

2024-12-20 Thread Greg KH
On Thu, Dec 19, 2024 at 06:04:02PM +0100, Danilo Krummrich wrote: > This patch series implements the necessary Rust abstractions to implement > device drivers in Rust. > > This includes some basic generalizations for driver registration, handling of > ID > tables, MMIO operations and device resou

Re: [PATCH] nvmem: qcom-spmi-sdam: Set size in struct nvmem_config

2024-12-20 Thread Vladimir Zapolskiy
On 12/20/24 14:22, Luca Weiss wrote: Let the nvmem core know what size the SDAM is, most notably this fixes the size of /sys/bus/nvmem/devices/spmi_sdam*/nvmem being '0' and makes user space work with that file. ~ # hexdump -C -s 64 /sys/bus/nvmem/devices/spmi_sdam2/nvmem 0040 02 01 0

[PATCH] selftests/run_kselftest.sh: Fix help string for --per-test-log

2024-12-20 Thread Brendan Jackman
This is documented as --per_test_log but the argument is actually --per-test-log. Signed-off-by: Brendan Jackman --- tools/testing/selftests/run_kselftest.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/run_kselftest.sh b/tools/testing/selftests/ru

Re: [PATCH bpf] selftests/bpf: add XDP_UMEM_TX_METADATA_LEN flag to umem_config

2024-12-20 Thread Frank Li
On Fri, Dec 20, 2024 at 05:18:06PM +0800, Wei Fang wrote: > The Tx metadata test has been broken since the commit d5e726d9143c ("xsk: > Require XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"). Nit: Fixes tag already include this information. The Tx metadata test has been broken becasue XDP

Re: [PATCH 0/2] selftest: fix riscv/vector tests

2024-12-20 Thread Andrew Jones
On Fri, Dec 20, 2024 at 05:17:25PM +0800, Yong-Xuan Wang wrote: > Add test counts and pass message to remove warning of riscv/vector tests. > > Yong-Xuan Wang (2): > tools: selftests: riscv: Add pass message for v_initval_nolibc > tools: selftests: riscv: Add test count for vstate_prctl > >

Re: [PATCH bpf] selftests/bpf: add XDP_UMEM_TX_METADATA_LEN flag to umem_config

2024-12-20 Thread Stanislav Fomichev
On 12/20, Wei Fang wrote: > The Tx metadata test has been broken since the commit d5e726d9143c ("xsk: > Require XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"). Because > this change requires XDP_UMEM_TX_METADATA_LEN flag to be set, otherwise > xsk_buff_pool::tx_metadata_len will be initializ

Re: [RFC PATCH 1/2] ptp: add PTP_SYS_OFFSET_STAT for xtstamping with status

2024-12-20 Thread Richard Cochran
On Thu, Dec 19, 2024 at 09:42:03PM +0100, Peter Hilber wrote: > Ioctl PTP_SYS_OFFSET_PRECISE2 provides cross-timestamping of device time > and system time. This can be used for virtualization where (virtualization) > host and guest refer to the same clocksource. It may be preferred to > indicate UT

Re: [PATCH 1/2] fs/proc: do_task_stat: Fix ESP not readable during coredump

2024-12-20 Thread Nam Cao
Hi Oleg, On Tue, Dec 17, 2024 at 04:09:14PM +0100, Oleg Nesterov wrote: > On 12/17, Oleg Nesterov wrote: > > > > On 11/06, Nam Cao wrote: > > > > > > @@ -534,6 +517,23 @@ static int do_task_stat(struct seq_file *m, struct > > > pid_namespace *ns, > > > ppid = task_tgid_nr_ns(task->real_

[PATCH v6 13/13] media: i2c: imx214: Fix link frequency validation

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The driver defines IMX214_DEFAULT_LINK_FREQ 48000, and then IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_FREQ * 8LL) / 10), which works out as 384MPix/s. (The 8 is 4 lanes and DDR.) Parsing the PLL registers with the defined 24MHz input. We're in single PLL mode, so M

[PATCH v6 12/13] media: i2c: imx214: Fix clock handling on probe error or remove

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The driver should disable or unprepare the clock on probe error and on removing the module. Remove regulator_bulk_disable(), because it is called by imx214_power_off(). Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 4 +++- 1 fil

[PATCH v6 11/13] media: i2c: imx214: Add test pattern control

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch This adds V4L2_CID_TEST_PATTERN control support. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 77 -- 1 file changed, 75 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/im

[PATCH v6 10/13] media: i2c: imx214: Verify chip ID

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Check the chip ID and stop probing if it is no imx214 sensor. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/media/i2c/imx214.c b/drivers/med

[PATCH v6 06/13] media: i2c: imx214: Check number of lanes from device tree

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 camera is capable of either two-lane or four-lane operation. Currently only the four-lane mode is supported, as proper pixel rates and link frequences for the two-lane mode are unknown. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/

[PATCH v6 08/13] media: i2c: imx214: Implement vflip/hflip controls

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports horizontal and vertical flipping. Add appropriate controls to the driver. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 68 -- 1 file changed, 60 insertions(+

[PATCH v6 04/13] media: i2c: imx214: Replace register addresses with macros

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Define macros for all the known registers used in the register arrays, and use them to replace the numerical addresses. This improves readability. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 407 ++--

[PATCH v6 01/13] media: i2c: imx214: Use subdev active state

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Port the imx214 sensor driver to use the subdev active state. Move all the format configuration to the subdevice state and simplify the format handling, locking and initialization. While at it, simplify imx214_start_streaming() by removing unneeded goto statements and the c

[PATCH v6 02/13] media: i2c: imx214: Simplify with dev_err_probe()

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Error handling in probe() can be a bit simpler with dev_err_probe(). Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 54 +- 1 file changed, 24 insertions(+), 30 deletions(-) diff --git a

[PATCH v6 09/13] media: i2c: imx214: Add analogue/digital gain control

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports analogue gain up to 8x and digital gain up to 16x. Implement the corresponding controls in the driver. Default gain values are not modified by this patch. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 5

[PATCH v6 03/13] media: i2c: imx214: Convert to CCI register access helpers

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Use the new common CCI register access helpers to replace the private register access helpers in the imx214 driver. This simplifies the driver by reducing the amount of code. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/Kconfig | 1 + d

[PATCH v6 00/13] media: i2c: imx214: Miscellaneous cleanups and improvements

2024-12-20 Thread André Apitzsch via B4 Relay
This patch series is a collection of miscellaneous cleanups and improvements to the imx214 driver. The series converts the driver to the CCI helpers and adds controls needed to make the driver work with libcamera. The changes are inspired by the imx219 driver. Signed-off-by: André Apitzsch ---

[PATCH v6 07/13] media: i2c: imx214: Add vblank and hblank controls

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Add vblank control to allow changing the framerate / higher exposure values. The vblank and hblank controls are needed for libcamera support. While at it, fix the minimal exposure time according to the datasheet. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214

[PATCH v6 05/13] media: i2c: imx214: Drop IMX214_REG_EXPOSURE from mode reg arrays

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value in the mode_ registers arrays, and once via v4l2_ctrl_ops. The latter is enough, drop the former. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 2 -- 1 file

Re: [PATCH] soc: qcom: pd_mapper: Add SM7225 compatible

2024-12-20 Thread Konrad Dybcio
On 20.12.2024 11:15 AM, Luca Weiss wrote: > On Fri Dec 20, 2024 at 10:39 AM CET, Konrad Dybcio wrote: >> On 20.12.2024 9:39 AM, Luca Weiss wrote: >>> The Qualcomm SM7225 is practically identical to SM6350, so add an entry >>> using that data. >>> >>> Signed-off-by: Luca Weiss >>> --- >> >> I think

[PATCH] nvmem: qcom-spmi-sdam: Set size in struct nvmem_config

2024-12-20 Thread Luca Weiss
m->sdam_config.stride = 1; + sdam->sdam_config.size = sdam->size; sdam->sdam_config.word_size = 1; sdam->sdam_config.reg_read = sdam_read; sdam->sdam_config.reg_write = sdam_write; --- base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2 change-id: 20241220-sdam-size-da6adec6fbaa Best regards, -- Luca Weiss

Re: [PATCH net-next v16 03/26] ovpn: add basic interface creation/destruction/management routines

2024-12-20 Thread Donald Hunter
On Thu, 19 Dec 2024 at 01:42, Antonio Quartulli wrote: > > Add basic infrastructure for handling ovpn interfaces. > > Signed-off-by: Antonio Quartulli Tested-by: Donald Hunter

Re: [PATCH net-next v16 02/26] ovpn: add basic netlink support

2024-12-20 Thread Donald Hunter
On Thu, 19 Dec 2024 at 01:42, Antonio Quartulli wrote: > > This commit introduces basic netlink support with family > registration/unregistration functionalities and stub pre/post-doit. > > More importantly it introduces the YAML uAPI description along > with its auto-generated files: > - include/

Re: [PATCH 2/2] clk: qcom: dispcc-sm6350: Add missing parent_map for a clock

2024-12-20 Thread Konrad Dybcio
On 20.12.2024 10:03 AM, Luca Weiss wrote: > If a clk_rcg2 has a parent, it should also have parent_map defined, > otherwise we'll get a NULL pointer dereference when calling clk_set_rate > like the following: > > [3.388105] Call trace: > [3.390664] qcom_find_src_index+0x3c/0x70 (P) >

Re: [PATCH 1/2] clk: qcom: gcc-sm6350: Add missing parent_map for two clocks

2024-12-20 Thread Konrad Dybcio
On 20.12.2024 11:21 AM, Luca Weiss wrote: > On Fri Dec 20, 2024 at 10:42 AM CET, Konrad Dybcio wrote: >> On 20.12.2024 10:03 AM, Luca Weiss wrote: >>> If a clk_rcg2 has a parent, it should also have parent_map defined, >> >> ^ >> freq_tbl > > I was bas

Re: [PATCH 1/2] clk: qcom: gcc-sm6350: Add missing parent_map for two clocks

2024-12-20 Thread Luca Weiss
On Fri Dec 20, 2024 at 10:42 AM CET, Konrad Dybcio wrote: > On 20.12.2024 10:03 AM, Luca Weiss wrote: > > If a clk_rcg2 has a parent, it should also have parent_map defined, > > ^ > freq_tbl I was basing this on that part of the clk-rcg2.c, so for ever

Re: [PATCH] soc: qcom: pd_mapper: Add SM7225 compatible

2024-12-20 Thread Luca Weiss
On Fri Dec 20, 2024 at 10:39 AM CET, Konrad Dybcio wrote: > On 20.12.2024 9:39 AM, Luca Weiss wrote: > > The Qualcomm SM7225 is practically identical to SM6350, so add an entry > > using that data. > > > > Signed-off-by: Luca Weiss > > --- > > I think we should instead add the fallback compatible

Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Drop extra qcom,msm-id value

2024-12-20 Thread Luca Weiss
On Fri Dec 20, 2024 at 10:36 AM CET, Konrad Dybcio wrote: > On 20.12.2024 9:55 AM, Luca Weiss wrote: > > The ID 434 is for SM6350 while 459 is for SM7225. Fairphone 4 is only > > SM7225, so drop the unused 434 entry. > > > > Fixes: 4cbea668767d ("arm64: dts: qcom: sm7225: Add device tree for > >

Re: [PATCH 2/2] clk: qcom: dispcc-sm6350: Add missing parent_map for a clock

2024-12-20 Thread Konrad Dybcio
On 20.12.2024 10:03 AM, Luca Weiss wrote: > If a clk_rcg2 has a parent, it should also have parent_map defined, > otherwise we'll get a NULL pointer dereference when calling clk_set_rate > like the following: Same as patch 1 Konrad

Re: [PATCH 1/2] clk: qcom: gcc-sm6350: Add missing parent_map for two clocks

2024-12-20 Thread Konrad Dybcio
On 20.12.2024 10:03 AM, Luca Weiss wrote: > If a clk_rcg2 has a parent, it should also have parent_map defined, ^ freq_tbl > otherwise we'll get a NULL pointer dereference when calling clk_set_rate > like the following: > > [3.388105] Call trac

Re: [PATCH] soc: qcom: pd_mapper: Add SM7225 compatible

2024-12-20 Thread Konrad Dybcio
On 20.12.2024 9:39 AM, Luca Weiss wrote: > The Qualcomm SM7225 is practically identical to SM6350, so add an entry > using that data. > > Signed-off-by: Luca Weiss > --- I think we should instead add the fallback compatible, like - enum: - asdf,asdf - const: qcom,sm7225 - const: qcom,sm63

Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Drop extra qcom,msm-id value

2024-12-20 Thread Konrad Dybcio
On 20.12.2024 9:55 AM, Luca Weiss wrote: > The ID 434 is for SM6350 while 459 is for SM7225. Fairphone 4 is only > SM7225, so drop the unused 434 entry. > > Fixes: 4cbea668767d ("arm64: dts: qcom: sm7225: Add device tree for Fairphone > 4") > Signed-off-by: Luca Weiss > --- > Completely dropping

[PATCH bpf] selftests/bpf: add XDP_UMEM_TX_METADATA_LEN flag to umem_config

2024-12-20 Thread Wei Fang
The Tx metadata test has been broken since the commit d5e726d9143c ("xsk: Require XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"). Because this change requires XDP_UMEM_TX_METADATA_LEN flag to be set, otherwise xsk_buff_pool::tx_metadata_len will be initialized to 0, which means that the driv

Re: [PATCH] arm64: dts: qcom: sm6350: Fix uart1 interconnect path

2024-12-20 Thread Konrad Dybcio
On 20.12.2024 9:59 AM, Luca Weiss wrote: > The path MASTER_QUP_0 to SLAVE_EBI_CH0 would be qup-memory path and not > qup-config. Since the qup-memory path is not part of the qcom,geni-uart > bindings, just replace that path with the correct path for qup-config. > > Fixes: b179f35b887b ("arm64: dts

[PATCH 1/2] tools: selftests: riscv: Add pass message for v_initval_nolibc

2024-12-20 Thread Yong-Xuan Wang
Add the pass message after we successfully complete the test. Fixes: 5c93c4c72fbc ("selftests: Test RISC-V Vector's first-use handler") Signed-off-by: Yong-Xuan Wang --- tools/testing/selftests/riscv/vector/v_initval_nolibc.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/testing/

[PATCH 2/2] tools: selftests: riscv: Add test count for vstate_prctl

2024-12-20 Thread Yong-Xuan Wang
Add the test count to drop the warning message. "Planned tests != run tests (0 != 1)" Fixes: 7cf6198ce22d ("selftests: Test RISC-V Vector prctl interface") Signed-off-by: Yong-Xuan Wang --- tools/testing/selftests/riscv/vector/vstate_prctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

[PATCH 0/2] selftest: fix riscv/vector tests

2024-12-20 Thread Yong-Xuan Wang
Add test counts and pass message to remove warning of riscv/vector tests. Yong-Xuan Wang (2): tools: selftests: riscv: Add pass message for v_initval_nolibc tools: selftests: riscv: Add test count for vstate_prctl tools/testing/selftests/riscv/vector/v_initval_nolibc.c | 4 tools/testin

Re: Kernel Bug: "KASAN: slab-out-of-bounds Read in jfs_readdir"

2024-12-20 Thread Alexander Potapenko
On Fri, Dec 20, 2024 at 9:07 AM Haichi Wang wrote: > > Dear Linux maintainers and reviewers: > > We are reporting a Linux kernel bug titled **KASAN: slab-out-of-bounds Read > in jfs_readdir**, discovered using a modified version of Syzkaller. > Hello Haichi, Unfortunately right now the bug is n

[PATCH 2/2] clk: qcom: dispcc-sm6350: Add missing parent_map for a clock

2024-12-20 Thread Luca Weiss
If a clk_rcg2 has a parent, it should also have parent_map defined, otherwise we'll get a NULL pointer dereference when calling clk_set_rate like the following: [3.388105] Call trace: [3.390664] qcom_find_src_index+0x3c/0x70 (P) [3.395301] qcom_find_src_index+0x1c/0x70 (L) [

[PATCH 1/2] clk: qcom: gcc-sm6350: Add missing parent_map for two clocks

2024-12-20 Thread Luca Weiss
If a clk_rcg2 has a parent, it should also have parent_map defined, otherwise we'll get a NULL pointer dereference when calling clk_set_rate like the following: [3.388105] Call trace: [3.390664] qcom_find_src_index+0x3c/0x70 (P) [3.395301] qcom_find_src_index+0x1c/0x70 (L) [

[PATCH 0/2] Add missing parent_map to clocks in SM6350 clock drivers

2024-12-20 Thread Luca Weiss
ommit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2 change-id: 20241220-sm6350-parent_map-c03e9b61a718 Best regards, -- Luca Weiss

Re: [PATCH for-next] selftests/alsa: Fix circular dependency involving global-timer

2024-12-20 Thread Takashi Iwai
On Wed, 18 Dec 2024 03:59:31 +0100, Li Zhijian wrote: > > The pattern rule `$(OUTPUT)/%: %.c` inadvertently included a circular > dependency on the global-timer target due to its inclusion in > $(TEST_GEN_PROGS_EXTENDED). This resulted in a circular dependency > warning during the build process. >

[PATCH] arm64: dts: qcom: sm6350: Fix uart1 interconnect path

2024-12-20 Thread Luca Weiss
<&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_QUP_0 0>; interconnect-names = "qup-core", "qup-config"; status = "disabled"; }; --- base-commit: 81

[PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Drop extra qcom,msm-id value

2024-12-20 Thread Luca Weiss
m,board-id = <8 32>; aliases { --- base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2 change-id: 20241220-fp4-msm-id-c775f68604bf Best regards, -- Luca Weiss

[PATCH] soc: qcom: pd_mapper: Add SM7225 compatible

2024-12-20 Thread Luca Weiss
ns, }, { .compatible = "qcom,sm8150", .data = sm8150_domains, }, { .compatible = "qcom,sm8250", .data = sm8250_domains, }, --- base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2 change-id: 20241220-pd-mapper-sm7225-8bd30fa6cb07 Best regards, -- Luca Weiss