On Mon, 16 Dec 2024 12:11:43 -0800, Brian Norris wrote:
> Per commit bebe94b53eb7 ("drivers: base: default KUNIT_* fragments to
> KUNIT_ALL_TESTS"), it seems like we should default to KUNIT_ALL_TESTS.
>
> This enables these platform_device tests for common configurations, such
> as with:
>
> [ ..
The reference count of the device incremented in device_initialize() is
not decremented when device_add() fails. Add a put_device() call before
returning from the function.
Found by code review.
Cc: sta...@vger.kernel.org
Fixes: f2b44cde7e16 ("virtio: split device_register into device_initialize
Hi André,
On Sun, Dec 15, 2024 at 11:35:41PM +0100, André Apitzsch wrote:
> > > @@ -626,9 +637,36 @@ static int imx214_set_format(struct
> > > v4l2_subdev *sd,
> > > __crop->width = mode->width;
> > > __crop->height = mode->height;
> > >
> > > - if (format->which == V4L2_SUB
On Tue, 17 Dec 2024 11:54:32 +0800, Ma Ke wrote:
> When device_add(&dev->dev) failed, calling put_device() to explicitly
> release dev->dev. Otherwise, it could cause double free problem.
Who frees it doublely?
If device_add() failed, the put_device is called inside device_add(),
why we need to c
On 17-12-24, 11:54, Ma Ke wrote:
> When device_add(&dev->dev) failed, calling put_device() to explicitly
> release dev->dev. Otherwise, it could cause double free problem.
>
> Found by code review.
>
> Cc: sta...@vger.kernel.org
> Fixes: 694a1116b405 ("virtio: Bind virtio device to device-tree no
When device_add(&dev->dev) failed, calling put_device() to explicitly
release dev->dev. Otherwise, it could cause double free problem.
Found by code review.
Cc: sta...@vger.kernel.org
Fixes: 694a1116b405 ("virtio: Bind virtio device to device-tree node")
Signed-off-by: Ma Ke
---
drivers/virtio/
Fixes an issue where out-of-tree kselftest builds fail when building
the BPF and bpftools components. The failure occurs because the top-level
Makefile passes a relative srctree path ('..') to its sub-Makefiles, which
leads to errors in locating necessary files.
For example, the following error is
On Sat, Dec 14, 2024 at 3:12 PM Shijith Thotton wrote:
>
> Added support to read the vendor-specific PCI capability to identify the
> type of device being emulated.
>
> Reviewed-by: Dan Carpenter
> Signed-off-by: Shijith Thotton
> ---
Acked-by: Jason Wang
Thanks
On Sat, Dec 14, 2024 at 3:12 PM Shijith Thotton wrote:
>
> Added macro definition for VIRTIO_PCI_CAP_VENDOR_CFG to identify the PCI
> vendor data type in the virtio_pci_cap structure. Defined a new struct
> virtio_pci_vndr_data for the vendor data capability header as per the
> specification.
>
>
On Fri, Dec 13, 2024, Chao Gao wrote:
> On Wed, Nov 27, 2024 at 05:34:17PM -0800, Sean Christopherson wrote:
> >diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
> >index d3c3e1327ca1..8d088a888a0d 100644
> >--- a/arch/x86/kvm/cpuid.c
> >+++ b/arch/x86/kvm/cpuid.c
> >@@ -416,7 +416,7 @@ void
On 16/12/2024 12:50, Antonio Quartulli wrote:
On 16/12/2024 12:09, Sabrina Dubroca wrote:
[...]
Maybe we should call cancel_sync_work(&ovpn_sock->work) inside
ovpn_socket_get()?
So the latter will return NULL only when it is sure that the socket
has been
detached.
At that point we can skip th
Hi,
On Sat, Dec 14, 2024 at 3:34 AM Masahiro Yamada wrote:
>
> On Fri, Nov 22, 2024 at 5:43 AM Sami Tolvanen wrote:
> >
> > +When a symbol pointer is found in DWARF, gendwarfksyms can use its
> > +type for calculating symbol versions even if the symbol is defined
> > +elsewhere. The name of the
On Fri, Dec 13, 2024 at 7:13 PM Eduard Zingerman wrote:
>
> On Fri, 2024-12-13 at 19:44 -0700, Daniel Xu wrote:
>
> [...]
>
> > > > + /* First handle precisely tracked STACK_ZERO, up to
> > > > BPF_REG_SIZE */
> > > > + stype = state->stack[spi].slot_type;
> > > > + for (i = 0;
On 12/12/24 02:02, Geert Uytterhoeven wrote:
When adapting the test to the kselftest framework, a few printf() calls
indicating test progress were not updated.
Fix this by replacing these printf() calls by ksft_print_msg() calls.
Fixes: ce7d101750ff8450 ("selftests: timers: clocksource-switch:
Hello,
On Sat, 14 Dec 2024, David Laight wrote:
> The 'max_avail' value is calculated from the system memory
> size using order_base_2().
> order_base_2(x) is defined as '(x) ? fn(x) : 0'.
> The compiler generates two copies of the code that follows
> and then expands clamp(max, min, PA
Hello:
This series was applied to bpf/bpf-next.git (net)
by Martin KaFai Lau :
On Fri, 13 Dec 2024 16:06:19 +0100 you wrote:
> Hi all,
>
> This patch series continues the work to migrate the script tests into
> prog_tests.
>
> test_xdp_meta.sh uses the BPF programs defined in progs/test_xdp_met
Hi Maciej,
On 12/16/24 7:18 AM, Maciej Wieczor-Retman wrote:
> Sub-NUMA Cluster divides CPUs sharing an L3 cache into separate NUMA
> nodes. Systems may support splitting into either two, three, four or six
> nodes. When SNC mode is enabled the effective amount of L3 cache
> available for allocati
Hi Andre
On Mon, Dec 16, 2024 at 10:01 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Port the imx214 sensor driver to use the subdev active state.
>
> Move all the format configuration to the subdevice state and simplify
> the format handling, locking and initialization.
>
>
From: André Apitzsch
The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value
in the mode_ registers arrays, and once via v4l2_ctrl_ops. The
latter is enough, drop the former.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 2 --
1 file
From: André Apitzsch
Check the chip ID and stop probing if it is no imx214 sensor.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers/media/i2c/imx214.c b/drivers/med
From: André Apitzsch
The imx214 sensor supports analogue gain up to 8x and digital gain up to
16x. Implement the corresponding controls in the driver. Default gain
values are not modified by this patch.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 5
From: André Apitzsch
This adds V4L2_CID_TEST_PATTERN control support.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 77 --
1 file changed, 75 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/im
From: André Apitzsch
The imx214 camera is capable of either two-lane or four-lane operation.
Currently only the four-lane mode is supported, as proper pixel rates
and link frequences for the two-lane mode are unknown.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/
From: André Apitzsch
Port the imx214 sensor driver to use the subdev active state.
Move all the format configuration to the subdevice state and simplify
the format handling, locking and initialization.
While at it, simplify imx214_start_streaming() by removing unneeded goto
statements and the c
This patch series is a collection of miscellaneous cleanups and
improvements to the imx214 driver.
The series converts the driver to the CCI helpers and adds controls
needed to make the driver work with libcamera.
The changes are inspired by the imx219 driver.
Signed-off-by: André Apitzsch
---
From: André Apitzsch
The driver defines IMX214_DEFAULT_LINK_FREQ 48000, and then
IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_FREQ * 8LL) / 10),
which works out as 384MPix/s. (The 8 is 4 lanes and DDR.)
Parsing the PLL registers with the defined 24MHz input. We're in single
PLL mode, so M
From: André Apitzsch
The driver should disable or unprepare the clock on probe error and on
removing the module.
Remove regulator_bulk_disable(), because it is called by
imx214_power_off().
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 4 +++-
1 file changed, 3 insertions(+),
From: André Apitzsch
The imx214 sensor supports horizontal and vertical flipping. Add
appropriate controls to the driver.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 69 --
1 file changed, 61 insertions(+
From: André Apitzsch
Define macros for all the known registers used in the register arrays,
and use them to replace the numerical addresses. This improves
readability.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 407 ++--
From: André Apitzsch
Add vblank control to allow changing the framerate /
higher exposure values.
The vblank and hblank controls are needed for libcamera support.
While at it, fix the minimal exposure time according to the datasheet.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214
From: André Apitzsch
Error handling in probe() can be a bit simpler with dev_err_probe().
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 54 +-
1 file changed, 24 insertions(+), 30 deletions(-)
diff --git a
From: André Apitzsch
Use the new common CCI register access helpers to replace the private
register access helpers in the imx214 driver. This simplifies the driver
by reducing the amount of code.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/Kconfig | 1 +
d
On Sat, Dec 14, 2024 at 11:04 AM Matan Shachnai wrote:
>
> This patch improves (or maintains) the precision of register value tracking
> in BPF_MUL across all possible inputs. It also simplifies
> scalar32_min_max_mul() and scalar_min_max_mul().
>
> As it stands, BPF_MUL is composed of three funct
We recently updated these device_match*() (and therefore, various
*find_device_by*()) functions to return a consistent 'false' value when
trying to match a NULL handle. Add tests for this.
This provides regression-testing coverage for the sorts of bugs that
underly commit 5c8418cf4025 ("PCI/pwrctr
of_find_device_by_node(), bus_find_device_by_of_node(),
bus_find_device_by_fwnode(), ..., all produce arbitrary results when
provided with a NULL of_node, fwnode, ACPI handle, etc. This is
counterintuitive, and the source of a few bugs, such as the one fixed by
commit 5c8418cf4025 ("PCI/pwrctrl: Un
Per commit bebe94b53eb7 ("drivers: base: default KUNIT_* fragments to
KUNIT_ALL_TESTS"), it seems like we should default to KUNIT_ALL_TESTS.
This enables these platform_device tests for common configurations, such
as with:
./tools/testing/kunit/kunit.py run
Signed-off-by: Brian Norris
---
(no
This series:
1. makes the behavior of_find_device_by_node(),
bus_find_device_by_of_node(), bus_find_device_by_fwnode(), etc., more
consistent when provided with a NULL node/handle;
2. adds kunit tests to validate the new NULL-argument behavior; and
3. makes some related improvements and refac
REG_FTR_BITS(FTR_LOWER_SAFE, ID_AA64MMFR0_EL1, ASIDBITS, 0),
REG_FTR_BITS(FTR_LOWER_SAFE, ID_AA64MMFR0_EL1, PARANGE, 0),
REG_FTR_END,
};
---
base-commit: 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
change-id: 20241216-kvm-arm64-fix-set-id-asidbits-9bede25b7ad3
Best regards,
--
Mark Brown
The 'struct module_attribute' sysfs callbacks are about to change to
receive a 'const struct module_attribute *' parameter.
Prepare for that by avoid casting away the constness through
container_of() and using const pointers to 'struct param_attribute'.
Signed-off-by: Thomas Weißschuh
---
kernel
The structure is always read-only due to its placement in the read-only
section __modver. Reflect this at its usage sites.
Also prepare for the const handling of 'struct module_attribute' itself.
Signed-off-by: Thomas Weißschuh
---
include/linux/module.h | 2 +-
kernel/params.c| 4 ++--
These structs are never modified, move them to read-only memory.
This makes the API clearer and also prepares for the constification of
'struct attribute' itself.
While at it, also constify 'modinfo_attrs_count'.
Signed-off-by: Thomas Weißschuh
---
include/linux/module.h | 8
kernel
These structs are never modified, move them to read-only memory.
This makes the API clearer and also prepares for the constification of
'struct attribute' itself.
Signed-off-by: Thomas Weißschuh
---
Thomas Weißschuh (3):
params: Prepare for 'const struct module_attribute *'
module: Ha
On Sat, Dec 14, 2024 at 07:57:20PM +0900, Masahiro Yamada wrote:
> Linus observed that the symbol_request(utf8_data_table) call fails when
> CONFIG_UNICODE=y and CONFIG_TRIM_UNUSED_KSYMS=y.
>
> symbol_get() relies on the symbol data being present in the ksymtab for
> symbol lookups. However, EXPOR
On Wed, 4 Dec 2024 at 04:11, Beleswar Padhi wrote:
>
> This series uses various devm_ helpers to simplify device removal path in
> ti_k3_r5_remoteproc driver. This is the first series in the TI K3
> Remoteproc refactoring as long planned since [0].
>
> Testing Done:
> 1. Tested boot of R5F remotep
On Wed, Dec 11, 2024 at 03:20:07PM +0800, Chen-Yu Tsai wrote:
> When multi-core SCP support was added, the driver was made to populate
> platform devices for all the sub-nodes. This ended up adding platform
> devices for the rpmsg sub-nodes as well, which never actually get used,
> since rpmsg devi
On Mon, Dec 16, 2024 at 04:55:06PM +0100, Uladzislau Rezki wrote:
> On Mon, Dec 16, 2024 at 04:44:41PM +0100, Vlastimil Babka wrote:
> > On 12/16/24 16:41, Uladzislau Rezki wrote:
> > > On Mon, Dec 16, 2024 at 03:20:44PM +0100, Vlastimil Babka wrote:
> > >> On 12/16/24 12:03, Uladzislau Rezki wrote
On Mon, Dec 16, 2024 at 5:31 PM Danilo Krummrich wrote:
>
> Thanks! If nothing else comes up, I'll send you a v7 end of this week
> addressing
> the two minor things I just replied to (remove wrong return statement in
> iounmap() helper, `pci::DeviceId` naming and `Deref` impl).
If you are going
On 12/2/24 15:59, Peter Zijlstra wrote:
> Hi!
>
> Implement a means for exports to be available only to an explicit list of
> named
> modules. By explicitly limiting the usage of certain exports, the abuse
> potential/risk is greatly reduced.
>
> The first 'patch' is an awk scripts that cleans u
On Sun, Dec 15, 2024 at 01:25:45PM +0100, Greg KH wrote:
> On Thu, Dec 12, 2024 at 05:33:46PM +0100, Danilo Krummrich wrote:
> > Add a sample Rust platform driver illustrating the usage of the platform
> > bus abstractions.
> >
> > This driver probes through either a match of device / driver name
On Sun, Dec 15, 2024 at 01:23:22PM +0100, Greg KH wrote:
> On Thu, Dec 12, 2024 at 05:33:40PM +0100, Danilo Krummrich wrote:
> > +impl DeviceId {
> > +const PCI_ANY_ID: u32 = !0;
> > +
> > +/// PCI_DEVICE macro.
> > +pub const fn new(vendor: u32, device: u32) -> Self {
> > +Self
On Thu, Dec 12, 2024 at 05:33:38PM +0100, Danilo Krummrich wrote:
> I/O memory is typically either mapped through direct calls to ioremap()
> or subsystem / bus specific ones such as pci_iomap().
>
> Even though subsystem / bus specific functions to map I/O memory are
> based on ioremap() / iounma
On Fri, Dec 13, 2024 at 08:06:13AM +0100, Dirk Behme wrote:
> On 12.12.24 17:33, Danilo Krummrich wrote:
> > This patch series implements the necessary Rust abstractions to implement
> > device drivers in Rust.
> >
> > This includes some basic generalizations for driver registration, handling
> >
On Mon, Dec 16, 2024 at 04:44:41PM +0100, Vlastimil Babka wrote:
> On 12/16/24 16:41, Uladzislau Rezki wrote:
> > On Mon, Dec 16, 2024 at 03:20:44PM +0100, Vlastimil Babka wrote:
> >> On 12/16/24 12:03, Uladzislau Rezki wrote:
> >> > On Sun, Dec 15, 2024 at 06:30:02PM +0100, Vlastimil Babka wrote:
On Mon, Dec 16, 2024 at 03:20:44PM +0100, Vlastimil Babka wrote:
> On 12/16/24 12:03, Uladzislau Rezki wrote:
> > On Sun, Dec 15, 2024 at 06:30:02PM +0100, Vlastimil Babka wrote:
> >> On 12/12/24 19:02, Uladzislau Rezki (Sony) wrote:
> >> > Hello!
> >> >
> >> > This is v2. It is based on the Linux
On 12/16/24 16:41, Uladzislau Rezki wrote:
> On Mon, Dec 16, 2024 at 03:20:44PM +0100, Vlastimil Babka wrote:
>> On 12/16/24 12:03, Uladzislau Rezki wrote:
>> > On Sun, Dec 15, 2024 at 06:30:02PM +0100, Vlastimil Babka wrote:
>> >> On 12/12/24 19:02, Uladzislau Rezki (Sony) wrote:
>> >> > Hello!
>>
Sub-NUMA Cluster divides CPUs sharing an L3 cache into separate NUMA
nodes. Systems may support splitting into either two, three, four or six
nodes. When SNC mode is enabled the effective amount of L3 cache
available for allocation is divided by the number of nodes per L3.
It's possible to detect
Resctrl selftest prints a message on test failure that Sub-Numa
Clustering (SNC) could be enabled and points the user to check their BIOS
settings. No actual check is performed before printing that message so
it is not very accurate in pinpointing a problem.
When there is SNC support for kernel's
Changes v8:
- Fix Makefile changes.
- Update cover letter SNC status information.
- Add Reinette's reviewed by tag to patch 2/2.
Changes v7:
- Include fallthrough in resctrlfs.c.
- Check fp after opening empty cpus file.
- Correct a comment and merge strings in snprintf().
Changes v6:
- Rebase on
(just a few nits here)
2024-12-11, 22:15:13 +0100, Antonio Quartulli wrote:
> +static inline struct ovpn_crypto_key_slot *
> +ovpn_crypto_key_id_to_slot(const struct ovpn_crypto_state *cs, u8 key_id)
> +{
> + struct ovpn_crypto_key_slot *ks;
> + u8 idx;
> +
> + if (unlikely(!cs))
> +
Hello!
On 2024-12-09 at 11:18:37 -0800, Reinette Chatre wrote:
>Hi Maciej,
>
>On 12/9/24 3:09 AM, Maciej Wieczor-Retman wrote:
>> Sub-NUMA Cluster divides CPUs sharing an L3 cache into separate NUMA
>> nodes. Systems may support splitting into either two, three, four or six
>> nodes. When SNC mode
2024-12-16, 15:09:17 +0100, Antonio Quartulli wrote:
> On 16/12/2024 14:59, Sabrina Dubroca wrote:
> > 2024-12-11, 22:15:15 +0100, Antonio Quartulli wrote:
> > > +static void ovpn_tcp_close(struct sock *sk, long timeout)
> > > +{
> > > + struct ovpn_socket *sock;
> > > +
> > > + rcu_read_lock();
>
On 12/16/24 12:03, Uladzislau Rezki wrote:
> On Sun, Dec 15, 2024 at 06:30:02PM +0100, Vlastimil Babka wrote:
>> On 12/12/24 19:02, Uladzislau Rezki (Sony) wrote:
>> > Hello!
>> >
>> > This is v2. It is based on the Linux 6.13-rc2. The first version is
>> > here:
>> >
>> > https://lore.kernel.org
2024-12-11, 22:15:14 +0100, Antonio Quartulli wrote:
> diff --git a/drivers/net/ovpn/peer.h b/drivers/net/ovpn/peer.h
> index
> 1b427870df2cf972e0f572e046452378358f245a..61c54fb864d990ff3d746f18c9a06d4c950bd1ac
> 100644
> --- a/drivers/net/ovpn/peer.h
> +++ b/drivers/net/ovpn/peer.h
> @@ -13,6 +1
On 16/12/2024 14:59, Sabrina Dubroca wrote:
2024-12-11, 22:15:15 +0100, Antonio Quartulli wrote:
@@ -42,6 +56,31 @@ struct ovpn_peer {
struct in6_addr ipv6;
} vpn_addrs;
struct ovpn_socket *sock;
+
+ /* state of the TCP reading. Needed to keep track of how m
2024-12-11, 22:15:15 +0100, Antonio Quartulli wrote:
> @@ -42,6 +56,31 @@ struct ovpn_peer {
> struct in6_addr ipv6;
> } vpn_addrs;
> struct ovpn_socket *sock;
> +
> + /* state of the TCP reading. Needed to keep track of how much of a
> + * single packet has alrea
On 2024-12-09 at 11:19:32 -0800, Reinette Chatre wrote:
>Hi Maciej,
>
>On 12/9/24 3:09 AM, Maciej Wieczor-Retman wrote:
>>
>> Sub-Numa Clustering (SNC) allows splitting CPU cores, caches and memory
>> into multiple NUMA nodes. When enabled, NUMA-aware applications can
>> achieve better performance
On Sun, Dec 15, 2024 at 06:30:02PM +0100, Vlastimil Babka wrote:
> On 12/12/24 19:02, Uladzislau Rezki (Sony) wrote:
> > Hello!
> >
> > This is v2. It is based on the Linux 6.13-rc2. The first version is
> > here:
> >
> > https://lore.kernel.org/linux-mm/20241210164035.3391747-4-ure...@gmail.com/
> > Is the handler->lock held when we call this function?
>
> I'm not sure how to test this.
>
> > Can you try
> > running the code with lockdep?
>
> /proc/lockdep contains
>
> > f9299231 FD: 89 BD:6 +.+.: imx214:901:(&imx214->ctrls)->_lock
>
> (no idea how to interpret this line)
>
>
On 16/12/2024 12:09, Sabrina Dubroca wrote:
[...]
Maybe we should call cancel_sync_work(&ovpn_sock->work) inside
ovpn_socket_get()?
So the latter will return NULL only when it is sure that the socket has been
detached.
At that point we can skip the following return and continue along the "new
so
2024-12-12, 23:46:11 +0100, Antonio Quartulli wrote:
> On 12/12/2024 17:19, Sabrina Dubroca wrote:
> > 2024-12-11, 22:15:10 +0100, Antonio Quartulli wrote:
> > > +static struct ovpn_socket *ovpn_socket_get(struct socket *sock)
> > > +{
> > > + struct ovpn_socket *ovpn_sock;
> > > +
> > > + rcu_read
On Sun, Dec 15, 2024 at 06:30:02PM +0100, Vlastimil Babka wrote:
> On 12/12/24 19:02, Uladzislau Rezki (Sony) wrote:
> > Hello!
> >
> > This is v2. It is based on the Linux 6.13-rc2. The first version is
> > here:
> >
> > https://lore.kernel.org/linux-mm/20241210164035.3391747-4-ure...@gmail.com/
On Fri, Dec 13, 2024 at 07:39:46PM +0100, Philipp Stanner wrote:
On Fri, 2024-12-13 at 16:10 +0100, Stefano Garzarella wrote:
On Wed, Dec 11, 2024 at 11:47:05AM +0100, Philipp Stanner wrote:
> The PCI functions
>
>pcim_iomap_regions()
>pcim_iounmap_regions()
>pcim_iomap_table()
>
> h
The pkey* files can only be built on architectures that support
pkeys (pkey-helpers.h #error's otherwise). Adding pkey_util.c as
dependency to all $(TEST_GEN_FILES) is therefore a bad idea. Make it
a dependency of the pkeys tests only.
Those tests are built in 32/64-bit variants on x86_64 so we ne
73 matches
Mail list logo
