[PATCH net-next v2 4/5] virtio_ring: add 'flushed' as an argument to virtqueue_reset()

2024-12-02 Thread Koichiro Den
When virtqueue_reset() has actually recycled all unused buffers, additional work may be required in some cases. Relying solely on its return status is fragile, so introduce a new argument 'flushed' to explicitly indicate whether it has really occurred. Signed-off-by: Koichiro Den --- drivers/net

[PATCH net-next v2 5/5] virtio_net: add missing netdev_tx_reset_queue to virtnet_sq_bind_xsk_pool()

2024-12-02 Thread Koichiro Den
virtnet_sq_bind_xsk_pool() flushes tx skbs and then resets tx queue, so DQL counters need to be reset. Fixes: 21a4e3ce6dc7 ("virtio_net: xsk: bind/unbind xsk for tx") Signed-off-by: Koichiro Den --- drivers/net/virtio_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/virtio

[PATCH net-next v2 2/5] virtio_ring: add 'flushed' as an argument to virtqueue_resize()

2024-12-02 Thread Koichiro Den
When virtqueue_resize() has actually recycled all unused buffers, additional work may be required in some cases. Relying solely on its return status is fragile, so introduce a new argument 'flushed' to explicitly indicate whether it has really occurred. Signed-off-by: Koichiro Den --- drivers/ne

[PATCH net-next v2 3/5] virtio_net: add missing netdev_tx_reset_queue() to virtnet_tx_resize()

2024-12-02 Thread Koichiro Den
virtnet_tx_resize() flushes remaining tx skbs, so DQL counters need to be reset. Fixes: c8bd1f7f3e61 ("virtio_net: add support for Byte Queue Limits") Cc: # v6.11+ Signed-off-by: Koichiro Den --- drivers/net/virtio_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/virtio_n

[PATCH net-next v2 1/5] virtio_net: correct netdev_tx_reset_queue() invocation point

2024-12-02 Thread Koichiro Den
When virtnet_close is followed by virtnet_open, some TX completions can possibly remain unconsumed, until they are finally processed during the first NAPI poll after the netdev_tx_reset_queue(), resulting in a crash [1]. Commit b96ed2c97c79 ("virtio_net: move netdev_tx_reset_queue() call before RX

[PATCH net-next v2 0/5] virtio_net: correct netdev_tx_reset_queue() invocation points

2024-12-02 Thread Koichiro Den
When virtnet_close is followed by virtnet_open, some TX completions can possibly remain unconsumed, until they are finally processed during the first NAPI poll after the netdev_tx_reset_queue(), resulting in a crash [1]. Commit b96ed2c97c79 ("virtio_net: move netdev_tx_reset_queue() call before RX

[PATCH] x86/paravirt: remove the wbinvd hook

2024-12-02 Thread Juergen Gross
The wbinvd paravirt hook is a leftover of lguest times. Today it is no longer needed, as all users use the native wbinvd implementation. Remove the hook and rename native_wbinvd() to wbinvd(). Signed-off-by: Juergen Gross --- arch/x86/include/asm/paravirt.h | 7 --- arch/x86/inclu

Re: [RFC PATCH 1/2] x86, lib, xenpv: Add WBNOINVD helper functions

2024-12-02 Thread Juergen Gross
On 03.12.24 05:09, Xin Li wrote: On 12/2/2024 5:44 PM, Kevin Loughlin wrote: On Mon, Dec 2, 2024 at 5:28 PM Andrew Cooper wrote: On 03/12/2024 12:59 am, Kevin Loughlin wrote: diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index d4eb9e1d61b8..c040af2d8eff 10064

Re: [linus:master] [sched, x86] 476e8583ca: WARNING:at_kernel/rcu/update.c:#torture_sched_setaffinity

2024-12-02 Thread Oliver Sang
hi, Sebastian Andrzej Siewior, hi, Paul, On Wed, Nov 27, 2024 at 12:17:49AM +0800, Paul E. McKenney wrote: > On Tue, Nov 26, 2024 at 03:30:24PM +0100, Sebastian Andrzej Siewior wrote: > > On 2024-11-25 22:29:09 [+0800], kernel test robot wrote: > > > Hello, > > Hi, > > > > > by this commit, we se

Re: [PATCH net-next] selftests: net: cleanup busy_poller.c

2024-12-02 Thread Stanislav Fomichev
On 12/03, Joe Damato wrote: > Fix various integer type conversions by using strtoull and a temporary > variable which is bounds checked before being casted into the > appropriate cfg_* variable for use by the test program. > > While here, free the strdup'd cfg string for overall hygenie. Thank yo

[PATCH net-next v12 16/22] ovpn: add support for peer floating

2024-12-02 Thread Antonio Quartulli
A peer connected via UDP may change its IP address without reconnecting (float). Add support for detecting and updating the new peer IP/port in case of floating. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/bind.c | 9 +- drivers/net/ovpn/io.c | 4 + drivers/net/ovpn/peer.c | 237

Re: [RFC PATCH 1/2] x86, lib, xenpv: Add WBNOINVD helper functions

2024-12-02 Thread Xin Li
On 12/2/2024 5:44 PM, Kevin Loughlin wrote: On Mon, Dec 2, 2024 at 5:28 PM Andrew Cooper wrote: On 03/12/2024 12:59 am, Kevin Loughlin wrote: diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index d4eb9e1d61b8..c040af2d8eff 100644 --- a/arch/x86/include/asm/parav

Re: [PATCH net-next] virtio_net: drop netdev_tx_reset_queue() from virtnet_enable_queue_pair()

2024-12-02 Thread Jason Wang
On Tue, Dec 3, 2024 at 10:14 AM Jakub Kicinski wrote: > > On Mon, 2 Dec 2024 12:22:53 +0800 Jason Wang wrote: > > > Fixes: c8bd1f7f3e61 ("virtio_net: add support for Byte Queue Limits") > > > Cc: # v6.11+ > > > Signed-off-by: Koichiro Den > > > > Acked-by: Jason Wang > > I see Tx skb flush in:

Re: [PATCH net-next] virtio_net: drop netdev_tx_reset_queue() from virtnet_enable_queue_pair()

2024-12-02 Thread Koichiro Den
On Tue, Dec 03, 2024 at 10:25:14AM +0800, Jason Wang wrote: > On Tue, Dec 3, 2024 at 10:14 AM Jakub Kicinski wrote: > > > > On Mon, 2 Dec 2024 12:22:53 +0800 Jason Wang wrote: > > > > Fixes: c8bd1f7f3e61 ("virtio_net: add support for Byte Queue Limits") > > > > Cc: # v6.11+ > > > > Signed-off-by:

Re: [PATCH -v2 1/7] module: Convert symbol namespace to string literal

2024-12-02 Thread Greg KH
On Mon, Dec 02, 2024 at 04:15:33PM +0100, Peter Zijlstra wrote: > On Mon, Dec 02, 2024 at 03:59:47PM +0100, Peter Zijlstra wrote: > > Clean up the existing export namespace code along the same lines of > > 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to > > __section("foo")") a

Re: [PATCH 2/2] sched: Move task_mm_cid_work to RCU callback

2024-12-02 Thread Mathieu Desnoyers
+= CC RCU maintainers, reviewers and list. += RSEQ maintainers. On 2024-12-02 09:07, Gabriele Monaco wrote: Currently, the task_mm_cid_work function is called in a task work triggered by a scheduler tick. This can delay the execution of the task for the entire duration of the function. This pat

[PATCH v2] vdpa/vp_vdpa: implement kick_vq_with_data callback

2024-12-02 Thread Yuxue Liu yuxue....@jaguarmicro.com
From: Yuxue Liu Implement the kick_vq_with_data vDPA callback. On kick, we pass the next available data to the hardware by writing it in the kick offset. Signed-off-by: Yuxue Liu --- v2: fix build error for kernel test robot drivers/vdpa/virtio_pci/vp_vdpa.c | 9 + 1 file changed, 9 i

Re: [PATCH net-next] virtio_net: drop netdev_tx_reset_queue() from virtnet_enable_queue_pair()

2024-12-02 Thread Jakub Kicinski
On Mon, 2 Dec 2024 12:22:53 +0800 Jason Wang wrote: > > Fixes: c8bd1f7f3e61 ("virtio_net: add support for Byte Queue Limits") > > Cc: # v6.11+ > > Signed-off-by: Koichiro Den > > Acked-by: Jason Wang I see Tx skb flush in: virtnet_freeze() -> remove_vq_common() -> free_unused_bufs() -> vir

Re: [PATCH] selftests/net: call sendmmsg via udpgso_bench.sh

2024-12-02 Thread Hangbin Liu
On Tue, Dec 03, 2024 at 08:21:29AM +0900, Kenjiro Nakayama wrote: > Currently, sendmmsg is implemented in udpgso_bench_tx.c, > but it is not called by any test script. > > This patch adds a test for sendmmsg in udpgso_bench.sh. > This allows for basic API testing and benchmarking > comparisons wit

Re: [RFC PATCH 1/2] x86, lib, xenpv: Add WBNOINVD helper functions

2024-12-02 Thread Kevin Loughlin
On Mon, Dec 2, 2024 at 5:28 PM Andrew Cooper wrote: > > On 03/12/2024 12:59 am, Kevin Loughlin wrote: > > diff --git a/arch/x86/include/asm/paravirt.h > > b/arch/x86/include/asm/paravirt.h > > index d4eb9e1d61b8..c040af2d8eff 100644 > > --- a/arch/x86/include/asm/paravirt.h > > +++ b/arch/x86/inc

[PATCH net v7 2/3] vsock/test: fix parameter types in SO_VM_SOCKETS_* calls

2024-12-02 Thread Konstantin Shkolnyy
Change parameters of SO_VM_SOCKETS_* to unsigned long long as documented in the vm_sockets.h, because the corresponding kernel code requires them to be at least 64-bit, no matter what architecture. Otherwise they are too small on 32-bit machines. Fixes: 5c338112e48a ("test/vsock: rework message bo

[PATCH net v7 1/3] vsock/test: fix failures due to wrong SO_RCVLOWAT parameter

2024-12-02 Thread Konstantin Shkolnyy
This happens on 64-bit big-endian machines. SO_RCVLOWAT requires an int parameter. However, instead of int, the test uses unsigned long in one place and size_t in another. Both are 8 bytes long on 64-bit machines. The kernel, having received the 8 bytes, doesn't test for the exact size of the param

[PATCH net v7 3/3] vsock/test: verify socket options after setting them

2024-12-02 Thread Konstantin Shkolnyy
Replace setsockopt() calls with calls to functions that follow setsockopt() with getsockopt() and check that the returned value and its size are the same as have been set. (Except in vsock_perf.) Signed-off-by: Konstantin Shkolnyy Reviewed-by: Stefano Garzarella --- tools/testing/vsock/control.

[PATCH net v7 0/3] vsock/test: fix wrong setsockopt() parameters

2024-12-02 Thread Konstantin Shkolnyy
Parameters were created using wrong C types, which caused them to be of wrong size on some architectures, causing problems. The problem with SO_RCVLOWAT was found on s390 (big endian), while x86-64 didn't show it. After the fix, all tests pass on s390. Then Stefano Garzarella pointed out that SO_V

Re: [RFC PATCH 1/2] x86, lib, xenpv: Add WBNOINVD helper functions

2024-12-02 Thread Andrew Cooper
On 03/12/2024 12:59 am, Kevin Loughlin wrote: > diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h > index d4eb9e1d61b8..c040af2d8eff 100644 > --- a/arch/x86/include/asm/paravirt.h > +++ b/arch/x86/include/asm/paravirt.h > @@ -187,6 +187,13 @@ static __always_inline void

[PATCH net-next] selftests: net: cleanup busy_poller.c

2024-12-02 Thread Joe Damato
Fix various integer type conversions by using strtoull and a temporary variable which is bounds checked before being casted into the appropriate cfg_* variable for use by the test program. While here, free the strdup'd cfg string for overall hygenie. Signed-off-by: Joe Damato --- tools/testing/

[RFC PATCH 2/2] KVM: SEV: Prefer WBNOINVD over WBINVD for cache maintenance efficiency

2024-12-02 Thread Kevin Loughlin
AMD CPUs currently execute WBINVD in the host when unregistering SEV guest memory or when deactivating SEV guests. Such cache maintenance is performed to prevent data corruption, wherein the encrypted (C=1) version of a dirty cache line might otherwise only be written back after the memory is writt

[RFC PATCH 1/2] x86, lib, xenpv: Add WBNOINVD helper functions

2024-12-02 Thread Kevin Loughlin
In line with WBINVD usage, add WBONINVD helper functions, accounting for kernels built with and without CONFIG_PARAVIRT_XXL. Signed-off-by: Kevin Loughlin --- arch/x86/include/asm/paravirt.h | 7 +++ arch/x86/include/asm/paravirt_types.h | 1 + arch/x86/include/asm/smp.h|

[RFC PATCH 0/2] KVM: SEV: Prefer WBNOINVD over WBINVD for cache maintenance efficiency

2024-12-02 Thread Kevin Loughlin
AMD CPUs currently execute WBINVD in the host when unregistering SEV guest memory or when deactivating SEV guests. Such cache maintenance is performed to prevent data corruption, wherein the encrypted (C=1) version of a dirty cache line might otherwise only be written back after the memory is writt

Re: [PATCH] vdpa: solidrun: Replace deprecated PCI functions

2024-12-02 Thread kernel test robot
e' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Philipp-Stanner/vdpa-solidrun-Replace-deprecated-PCI-functions/20241202-202728 base: linus/master patch link: https://lore.kernel.org/r/20241202122

[PATCH v5 2/2] virt: pvmemcontrol: add Yuanchu and Pasha as maintainers

2024-12-02 Thread Yuanchu Xie
The pvmemcontrol driver lives under drivers/virt/pvmemcontrol. We specify maintainers for the driver. Signed-off-by: Yuanchu Xie --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1e930c7a58b1..92db5dcf0212 100644 --- a/MAINTAINERS +++ b/MA

[PATCH v5 1/2] virt: pvmemcontrol: control guest physical memory properties

2024-12-02 Thread Yuanchu Xie
Pvmemcontrol provides a way for the guest to control its physical memory properties and enables optimizations and security features. For example, the guest can provide information to the host where parts of a hugepage may be unbacked, or sensitive data may not be swapped out, etc. Pvmemcontrol all

Re: [PATCH bpf-next] tools/testing/selftests/bpf/test_tc_tunnel.sh: Fix wait for server bind

2024-12-02 Thread Stanislav Fomichev
On 12/02, Marco Leogrande wrote: > Commit f803bcf9208a ("selftests/bpf: Prevent client connect before > server bind in test_tc_tunnel.sh") added code that waits for the > netcat server to start before the netcat client attempts to connect to > it. However, not all calls to 'server_listen' were guar

Re: [PATCH v2 0/6] [PATCH 0/6] KUnit test moves / renames

2024-12-02 Thread Rae Moar
On Mon, Dec 2, 2024 at 2:55 AM David Gow wrote: > > As discussed in [1], the KUnit test naming scheme has changed to avoid > name conflicts (and tab-completion woes) with the files being tested. > These renames and moves have caused a nasty set of merge conflicts, so > this series collates and reb

[PATCH] selftests/net: call sendmmsg via udpgso_bench.sh

2024-12-02 Thread Kenjiro Nakayama
Currently, sendmmsg is implemented in udpgso_bench_tx.c, but it is not called by any test script. This patch adds a test for sendmmsg in udpgso_bench.sh. This allows for basic API testing and benchmarking comparisons with GSO. --- tools/testing/selftests/net/udpgso_bench.sh | 3 +++ 1 file change

Re: [PATCH] remoteproc: core: Fix ida_free call while not allocated

2024-12-02 Thread Mathieu Poirier
On Fri, Nov 22, 2024 at 06:51:27PM +0100, Arnaud Pouliquen wrote: > In the rproc_alloc() function, on error, put_device(&rproc->dev) is > called, leading to the call of the rproc_type_release() function. > An error can occurs before ida_alloc is called. > > In such case in rproc_type_release(), th

[PATCH 1/4] remoteproc: wkup_m3: Use devm_pm_runtime_enable() helper

2024-12-02 Thread Andrew Davis
Use device life-cycle managed runtime enable function to simplify probe and exit paths. Signed-off-by: Andrew Davis --- drivers/remoteproc/wkup_m3_rproc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/wkup_m3_rproc.c b/drivers/remoteproc/wkup_m3_rp

[PATCH 4/4] remoteproc: wkup_m3: Use devm_rproc_add() helper

2024-12-02 Thread Andrew Davis
Use the device lifecycle managed add function. This helps prevent mistakes like deleting out of order in cleanup functions and forgetting to delete on error paths. Signed-off-by: Andrew Davis --- drivers/remoteproc/wkup_m3_rproc.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-

[PATCH 3/4] remoteproc: wkup_m3: Use devm_rproc_alloc() helper

2024-12-02 Thread Andrew Davis
Use the device lifecycle managed allocation function. This helps prevent mistakes like freeing out of order in cleanup functions and forgetting to free on error paths. Signed-off-by: Andrew Davis --- drivers/remoteproc/wkup_m3_rproc.c | 28 1 file changed, 8 insertio

[PATCH 2/4] remoteproc: wkup_m3: Use devm action to call PM runtime put sync

2024-12-02 Thread Andrew Davis
This helps prevent mistakes like putting out of order in cleanup functions and forgetting to put sync on error paths. Signed-off-by: Andrew Davis --- drivers/remoteproc/wkup_m3_rproc.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/remotep

[PATCH v2 4/5] remoteproc: keystone: Use devm_gpiod_get() helper

2024-12-02 Thread Andrew Davis
Use device life-cycle managed GPIO get function to simplify probe and exit paths. Signed-off-by: Andrew Davis --- drivers/remoteproc/keystone_remoteproc.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/re

Re: [net PATCH 1/2] selftests: net: lib: fix broken ping with coreutils ping util

2024-12-02 Thread Christian Marangi
On Mon, Dec 02, 2024 at 11:24:29PM +0200, Vladimir Oltean wrote: > On Mon, Dec 02, 2024 at 09:39:15PM +0100, Christian Marangi wrote: > > Mhh the problem seems to be -c > > > > Let me post some outputs... > > > > root@OpenWrt:~# ping -V > > ping from iputils 20240117 > > libcap: no, IDN: no, NLS

Re: [net PATCH 1/2] selftests: net: lib: fix broken ping with coreutils ping util

2024-12-02 Thread Christian Marangi
On Mon, Dec 02, 2024 at 10:28:16PM +0100, Christian Marangi wrote: > On Mon, Dec 02, 2024 at 11:24:29PM +0200, Vladimir Oltean wrote: > > On Mon, Dec 02, 2024 at 09:39:15PM +0100, Christian Marangi wrote: > > > Mhh the problem seems to be -c > > > > > > Let me post some outputs... > > > > > > ro

[PATCH v2 1/5] remoteproc: keystone: Use devm action to release reserved memory

2024-12-02 Thread Andrew Davis
This helps prevent mistakes like freeing out of order in cleanup functions and forgetting to free on error paths. Signed-off-by: Andrew Davis --- Changes for v2: - Keep `goto disable_clk` for this patch to prevent git-bisect issues drivers/remoteproc/keystone_remoteproc.c | 17 ++-

[PATCH v2 3/5] remoteproc: keystone: Use devm action to call PM runtime put sync

2024-12-02 Thread Andrew Davis
This helps prevent mistakes like putting out of order in cleanup functions and forgetting to put sync on error paths. Signed-off-by: Andrew Davis --- drivers/remoteproc/keystone_remoteproc.c | 36 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/re

[PATCH v2 5/5] remoteproc: keystone: Use devm_rproc_add() helper

2024-12-02 Thread Andrew Davis
Use the device lifecycle managed add function. This helps prevent mistakes like deleting out of order in cleanup functions and forgetting to delete on error paths. Signed-off-by: Andrew Davis --- drivers/remoteproc/keystone_remoteproc.c | 12 +--- 1 file changed, 1 insertion(+), 11 delet

[PATCH v2 2/5] remoteproc: keystone: Use devm_pm_runtime_enable() helper

2024-12-02 Thread Andrew Davis
Use device life-cycle managed runtime enable function to simplify probe and exit paths. Signed-off-by: Andrew Davis --- drivers/remoteproc/keystone_remoteproc.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/

Re: [PATCH -v2 1/7] module: Convert symbol namespace to string literal

2024-12-02 Thread Peter Zijlstra
On Mon, Dec 02, 2024 at 03:59:47PM +0100, Peter Zijlstra wrote: > Clean up the existing export namespace code along the same lines of > 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to > __section("foo")") and for the same reason, it is not desired for the > namespace argument t

[PATCH v2 1/3] remoteproc: da8xx: Use devm_rproc_alloc() helper

2024-12-02 Thread Andrew Davis
Use the device lifecycle managed allocation function. This helps prevent mistakes like freeing out of order in cleanup functions and forgetting to free on error paths. Signed-off-by: Andrew Davis --- drivers/remoteproc/da8xx_remoteproc.c | 15 ++- 1 file changed, 6 insertions(+), 9 d

[PATCH -v2 6/7] module: Account for the build time module name mangling

2024-12-02 Thread Peter Zijlstra
Sean noted that scripts/Makefile.lib:name-fix-token rule will mangle the module name with s/-/_/g. Since this happens late in the build, only the kernel needs to bother with this, the modpost tool still sees the original name. Reported-by: Sean Christopherson Signed-off-by: Peter Zijlstra (Intel

[PATCH v2 3/3] remoteproc: da8xx: Use devm_rproc_add() helper

2024-12-02 Thread Andrew Davis
Use the device lifecycle managed add function. This helps prevent mistakes like deleting out of order in cleanup functions and forgetting to delete on error paths. Signed-off-by: Andrew Davis --- drivers/remoteproc/da8xx_remoteproc.c | 20 +--- 1 file changed, 1 insertion(+), 19

[PATCH v2 2/3] remoteproc: da8xx: Use devm action to release reserved memory

2024-12-02 Thread Andrew Davis
This helps prevent mistakes like freeing out of order in cleanup functions and forgetting to free on error paths. Signed-off-by: Andrew Davis --- Changes for v2: - Fix unused var "dev" warning drivers/remoteproc/da8xx_remoteproc.c | 30 +-- 1 file changed, 14 insertion

Re: [net PATCH 1/2] selftests: net: lib: fix broken ping with coreutils ping util

2024-12-02 Thread Vladimir Oltean
On Mon, Dec 02, 2024 at 09:39:15PM +0100, Christian Marangi wrote: > Mhh the problem seems to be -c > > Let me post some outputs... > > root@OpenWrt:~# ping -V > ping from iputils 20240117 > libcap: no, IDN: no, NLS: no, error.h: no, getrandom(): yes, __fpending(): yes > root@OpenWrt:~# ping -c

[PATCH net-next v12 17/22] ovpn: implement peer add/get/dump/delete via netlink

2024-12-02 Thread Antonio Quartulli
This change introduces the netlink command needed to add, delete and retrieve/dump known peers. Userspace is expected to use these commands to handle known peer lifecycles. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/netlink.c | 629 - driver

[PATCH -v2 7/7] module: Provide EXPORT_SYMBOL_GPL_FOR() helper

2024-12-02 Thread Peter Zijlstra
Requested-by: Masahiro Yamada Requested-by: Christoph Hellwig Signed-off-by: Peter Zijlstra (Intel) --- include/linux/export.h | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) --- a/include/linux/export.h +++ b/include/linux/export.h @@ -24,11 +24,23 @@

[PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375

2024-12-02 Thread Luca Weiss
5 -/* SM6350 Power Domain Indexes */ +/* SM6375 Power Domain Indexes */ #define SM6375_VDDCX 0 #define SM6375_VDDCX_AO1 #define SM6375_VDDCX_VFL 2 --- base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37 change-id: 20241202-rpmpd-sm6375-06582e126d7f Best regards

[PATCH net-next v12 02/22] ovpn: add basic netlink support

2024-12-02 Thread Antonio Quartulli
This commit introduces basic netlink support with family registration/unregistration functionalities and stub pre/post-doit. More importantly it introduces the YAML uAPI description along with its auto-generated files: - include/uapi/linux/ovpn.h - drivers/net/ovpn/netlink-gen.c - drivers/net/ovpn

[PATCH net-next v12 09/22] ovpn: implement packet processing

2024-12-02 Thread Antonio Quartulli
This change implements encryption/decryption and encapsulation/decapsulation of OpenVPN packets. Support for generic crypto state is added along with a wrapper for the AEAD crypto kernel API. Signed-off-by: Antonio Quartulli --- drivers/net/Kconfig| 4 + drivers/net/ovpn/Makefile

[PATCH net-next v12 12/22] ovpn: implement multi-peer support

2024-12-02 Thread Antonio Quartulli
With this change an ovpn instance will be able to stay connected to multiple remote endpoints. This functionality is strictly required when running ovpn on an OpenVPN server. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/main.c | 67 +++- drivers/net/ovpn/ovpnstruct.h

[PATCH -v2 0/7] module: Strict per-modname namespaces

2024-12-02 Thread Peter Zijlstra
Hi! Implement a means for exports to be available only to an explicit list of named modules. By explicitly limiting the usage of certain exports, the abuse potential/risk is greatly reduced. The first 'patch' is an awk scripts that cleans up the existing module namespace code along the same lines

Re: [PATCH v6 0/3] vsock/test: fix wrong setsockopt() parameters

2024-12-02 Thread Stefano Garzarella
On Wed, Nov 13, 2024 at 08:35:54AM -0600, Konstantin Shkolnyy wrote: Parameters were created using wrong C types, which caused them to be of wrong size on some architectures, causing problems. The problem with SO_RCVLOWAT was found on s390 (big endian), while x86-64 didn't show it. After the fix

[PATCH net-next v12 10/22] ovpn: store tunnel and transport statistics

2024-12-02 Thread Antonio Quartulli
Byte/packet counters for in-tunnel and transport streams are now initialized and updated as needed. To be exported via netlink. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/Makefile | 1 + drivers/net/ovpn/io.c | 12 +++- drivers/net/ovpn/peer.c | 2 ++ drivers/net/ovpn

[PATCH net-next v12 05/22] ovpn: introduce the ovpn_peer object

2024-12-02 Thread Antonio Quartulli
An ovpn_peer object holds the whole status of a remote peer (regardless whether it is a server or a client). This includes status for crypto, tx/rx buffers, napi, etc. Only support for one peer is introduced (P2P mode). Multi peer support is introduced with a later patch. Along with the ovpn_pee

Re: [PATCH v6 09/18] gendwarfksyms: Limit structure expansion

2024-12-02 Thread Petr Pavlu
On 11/21/24 21:42, Sami Tolvanen wrote: > Expand each structure type only once per exported symbol. This > is necessary to support self-referential structures, which would > otherwise result in infinite recursion, and it's sufficient for > catching ABI changes. > > Types defined in .c files are op

Re: [PATCH] openrisc: place exception table at the head of vmlinux

2024-12-02 Thread Rong Xu
This looks good to me. Reviewed-by: Rong Xu -Rong On Mon, Dec 2, 2024 at 12:33 PM Guenter Roeck wrote: > > On Mon, Dec 02, 2024 at 03:28:22PM +0900, Masahiro Yamada wrote: > > Since commit 0043ecea2399 ("vmlinux.lds.h: Adjust symbol ordering in > > text output section"), the exception table in

[PATCH net-next v12 14/22] ovpn: implement keepalive mechanism

2024-12-02 Thread Antonio Quartulli
OpenVPN supports configuring a periodic keepalive packet. message to allow the remote endpoint detect link failures. This change implements the keepalive sending and timer expiring logic. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/io.c | 77 + drivers/net/ovp

[PATCH bpf-next] tools/testing/selftests/bpf/test_tc_tunnel.sh: Fix wait for server bind

2024-12-02 Thread Marco Leogrande
Commit f803bcf9208a ("selftests/bpf: Prevent client connect before server bind in test_tc_tunnel.sh") added code that waits for the netcat server to start before the netcat client attempts to connect to it. However, not all calls to 'server_listen' were guarded. This patch adds the existing 'wait_

Re: [PATCH] openrisc: place exception table at the head of vmlinux

2024-12-02 Thread Guenter Roeck
On Mon, Dec 02, 2024 at 03:28:22PM +0900, Masahiro Yamada wrote: > Since commit 0043ecea2399 ("vmlinux.lds.h: Adjust symbol ordering in > text output section"), the exception table in arch/openrisc/kernel/head.S > is no longer positioned at the very beginning of the kernel image, which > causes a b

Re: [net PATCH 1/2] selftests: net: lib: fix broken ping with coreutils ping util

2024-12-02 Thread Christian Marangi
On Sat, Nov 30, 2024 at 05:48:40PM +0200, Vladimir Oltean wrote: > On Sat, Nov 30, 2024 at 04:46:14PM +0100, Christian Marangi wrote: > > On Sat, Nov 30, 2024 at 05:43:07PM +0200, Vladimir Oltean wrote: > > > On Sat, Nov 30, 2024 at 12:33:09PM +0100, Christian Marangi wrote: > > > > If the coreutil

[PATCH net-next v12 06/22] ovpn: introduce the ovpn_socket object

2024-12-02 Thread Antonio Quartulli
This specific structure is used in the ovpn kernel module to wrap and carry around a standard kernel socket. ovpn takes ownership of passed sockets and therefore an ovpn specific objects is attached to them for status tracking purposes. Initially only UDP support is introduced. TCP will come in a

[PATCH net-next v12 01/22] net: introduce OpenVPN Data Channel Offload (ovpn)

2024-12-02 Thread Antonio Quartulli
OpenVPN is a userspace software existing since around 2005 that allows users to create secure tunnels. So far OpenVPN has implemented all operations in userspace, which implies several back and forth between kernel and user land in order to process packets (encapsulate/decapsulate, encrypt/decrypt

[PATCH net-next v12 03/22] ovpn: add basic interface creation/destruction/management routines

2024-12-02 Thread Antonio Quartulli
Add basic infrastructure for handling ovpn interfaces. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/Makefile | 1 + drivers/net/ovpn/io.c | 22 + drivers/net/ovpn/io.h | 24 ++ drivers/net/ovpn/main.c | 102 ++

Re: [PATCH v6 2/5] pidfd: add PIDFD_SELF_* sentinels to refer to own thread/process

2024-12-02 Thread Christian Brauner
On Wed, Oct 30, 2024 at 04:37:37PM +, Lorenzo Stoakes wrote: > On Mon, Oct 28, 2024 at 04:06:07PM +, Lorenzo Stoakes wrote: > > I guess I'll try to adapt that and respin a v7 when I get a chance. > > Hm looking at this draft patch, it seems like a total rework of pidfd's > across the board

[PATCH net-next v12 19/22] ovpn: kill key and notify userspace in case of IV exhaustion

2024-12-02 Thread Antonio Quartulli
IV wrap-around is cryptographically dangerous for a number of ciphers, therefore kill the key and inform userspace (via netlink) should the IV space go exhausted. Userspace has two ways of deciding when the key has to be renewed before exhausting the IV space: 1) time based approach: after X se

Re: [PATCH] dt-bindings: power: rpmpd: Fix comment for SM6375

2024-12-02 Thread Dmitry Baryshkov
gt; #define SM6375_VDDCX_AO 1 > #define SM6375_VDDCX_VFL 2 > > --- > base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37 > change-id: 20241202-rpmpd-sm6375-06582e126d7f > > Best regards, > -- > Luca Weiss > -- With best wishes Dmitry

[PATCH net-next v12 13/22] ovpn: implement peer lookup logic

2024-12-02 Thread Antonio Quartulli
In a multi-peer scenario there are a number of situations when a specific peer needs to be looked up. We may want to lookup a peer by: 1. its ID 2. its VPN destination IP 3. its transport IP/port couple For each of the above, there is a specific routing table referencing all peers for fast look u

[PATCH -v2 3/7] module/modpost: Add basename helper

2024-12-02 Thread Peter Zijlstra
Signed-off-by: Peter Zijlstra (Intel) --- scripts/mod/modpost.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1553,6 +1553,16 @@ static void mod_set_crcs(struct module * free(buf); } +static cons

[PATCH net-next v12 11/22] ovpn: implement TCP transport

2024-12-02 Thread Antonio Quartulli
With this change ovpn is allowed to communicate to peers also via TCP. Parsing of incoming messages is implemented through the strparser API. Signed-off-by: Antonio Quartulli --- drivers/net/Kconfig | 1 + drivers/net/ovpn/Makefile | 1 + drivers/net/ovpn/io.c | 4 +

[PATCH net-next v12 21/22] ovpn: add basic ethtool support

2024-12-02 Thread Antonio Quartulli
Implement support for basic ethtool functionality. Note that ovpn is a virtual device driver, therefore various ethtool APIs are just not meaningful and thus not implemented. Signed-off-by: Antonio Quartulli Reviewed-by: Andrew Lunn --- drivers/net/ovpn/main.c | 15 +++ 1 file chan

[PATCH -v2 2/7] module/modpost: Use for() loop

2024-12-02 Thread Peter Zijlstra
Signed-off-by: Peter Zijlstra (Intel) --- scripts/mod/modpost.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1586,12 +1586,9 @@ static void read_symbols(const char *mod license = get_next_mod

[PATCH net-next v12 15/22] ovpn: add support for updating local UDP endpoint

2024-12-02 Thread Antonio Quartulli
In case of UDP links, the local endpoint used to communicate with a given peer may change without a connection restart. Add support for learning the new address in case of change. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/peer.c | 45 + dr

Re: [PATCH -v2 1/7] module: Convert symbol namespace to string literal

2024-12-02 Thread Linus Torvalds
On Mon, 2 Dec 2024 at 07:15, Peter Zijlstra wrote: > > Perhaps we can ask Linus to run this now, before -next fills up again ? Sure. I did an unasked-for scripted 'remove_new' removal right after rc1 for the same reason. If we have these kinds of big scripted things, right after the merge window

[PATCH net-next v12 08/22] ovpn: implement basic RX path (UDP)

2024-12-02 Thread Antonio Quartulli
Packets received over the socket are forwarded to the user device. Implementation is UDP only. TCP will be added by a later patch. Note: no decryption/decapsulation exists yet, packets are forwarded as they arrive without much processing. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/i

Re: [PATCH 2/2] sched: Move task_mm_cid_work to RCU callback

2024-12-02 Thread Gabriele Monaco
> I've used the same task work pattern as NUMA here. What makes it > OK for NUMA and not for mm_cid ? > I didn't investigate the behaviour with the NUMA work, but my rough guess is that this wouldn't even be visible in an isolated environment (i.e. no migrations). Also it doesn't seem to scale li

[PATCH net-next v12 22/22] testing/selftests: add test tool and scripts for ovpn module

2024-12-02 Thread Antonio Quartulli
The ovpn-cli tool can be compiled and used as selftest for the ovpn kernel module. [NOTE: it depends on libmedtls for decoding base64-encoded keys] ovpn-cli implements the netlink and RTNL APIs and can thus be integrated in any script for more automated testing. Along with the tool, 4 scripts ar

Re: [PATCH bpf-next] selftests/bpf: ensure proper root namespace cleanup when test fail

2024-12-02 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov : On Thu, 28 Nov 2024 15:38:43 +0100 you wrote: > serial_test_flow_dissector_namespace manipulates both the root net > namespace and a dedicated non-root net namespace. If for some reason a > program attach on root n

Re: [PATCH v6] acpi: nfit: vmalloc-out-of-bounds Read in acpi_nfit_ctl

2024-12-02 Thread Ira Weiny
Suraj Sonawane wrote: > On 11/18/24 21:56, Suraj Sonawane wrote: [snip] > > > > drivers/acpi/nfit/core.c | 7 ++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > > index 5429ec9ef..a5d47819b 100644 > > --- a/dr

[PATCH net-next v12 18/22] ovpn: implement key add/get/del/swap via netlink

2024-12-02 Thread Antonio Quartulli
This change introduces the netlink commands needed to add, get, delete and swap keys for a specific peer. Userspace is expected to use these commands to create, inspect (non sensitive data only), destroy and rotate session keys for a specific peer. Signed-off-by: Antonio Quartulli --- drivers/n

Re: [PATCH v2 1/4] PCI: qcom-ep: Mark BAR0/BAR2 as 64bit BARs and BAR1/BAR3 as RESERVED

2024-12-02 Thread Bjorn Helgaas
On Mon, Dec 02, 2024 at 06:28:45PM +0530, Manivannan Sadhasivam wrote: > On Fri, Nov 29, 2024 at 01:55:37PM -0600, Bjorn Helgaas wrote: > > On Fri, Nov 29, 2024 at 02:54:12PM +0530, Manivannan Sadhasivam wrote: > > > On all Qcom endpoint SoCs, BAR0/BAR2 are 64bit BARs by default > > > and software

[PATCH -v2 4/7] module: Add module specific symbol namespace support

2024-12-02 Thread Peter Zijlstra
Designate the "MODULE_${modname}" symbol namespace to mean: 'only export to the named module'. Notably, explicit imports of anything in the "MODULE_" space is forbidden. Modules implicitly get the "MODULE_${modname}" namespace added. Signed-off-by: Peter Zijlstra (Intel) --- kernel/module/main.

Re: [PATCH -v2 0/7] module: Strict per-modname namespaces

2024-12-02 Thread Andi Kleen
Peter Zijlstra writes: > Hi! > > Implement a means for exports to be available only to an explicit list of > named > modules. By explicitly limiting the usage of certain exports, the abuse > potential/risk is greatly reduced. Blast from the past: https://lists.linuxcoding.com/kernel/2007-q4/msg

[PATCH net-next v12 04/22] ovpn: keep carrier always on for MP interfaces

2024-12-02 Thread Antonio Quartulli
An ovpn interface configured in MP mode will keep carrier always on and let the user decide when to bring it administratively up and down. This way a MP node (i.e. a server) will keep its interface always up and running, even when no peer is connected. Signed-off-by: Antonio Quartulli --- drive

[PATCH -v2 1/7] module: Convert symbol namespace to string literal

2024-12-02 Thread Peter Zijlstra
Clean up the existing export namespace code along the same lines of 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to __section("foo")") and for the same reason, it is not desired for the namespace argument to be a macro expansion itself. git grep -l -e MODULE_IMPORT_NS -e EXPOR

Re: [PATCH bpf-next] selftests/bpf: ensure proper root namespace cleanup when test fail

2024-12-02 Thread Stanislav Fomichev
On 11/28, Alexis Lothoré (eBPF Foundation) wrote: > serial_test_flow_dissector_namespace manipulates both the root net > namespace and a dedicated non-root net namespace. If for some reason a > program attach on root namespace succeeds while it was expected to > fail, the unexpected program will re

Re: [PATCH v2 0/6] [PATCH 0/6] KUnit test moves / renames

2024-12-02 Thread Andy Shevchenko
On Mon, Dec 02, 2024 at 03:55:37PM +0800, David Gow wrote: > As discussed in [1], the KUnit test naming scheme has changed to avoid > name conflicts (and tab-completion woes) with the files being tested. > These renames and moves have caused a nasty set of merge conflicts, so > this series collates

[PATCH net-next v12 20/22] ovpn: notify userspace when a peer is deleted

2024-12-02 Thread Antonio Quartulli
Whenever a peer is deleted, send a notification to userspace so that it can react accordingly. This is most important when a peer is deleted due to ping timeout, because it all happens in kernelspace and thus userspace has no direct way to learn about it. Signed-off-by: Antonio Quartulli --- dr

Re: [PATCH v6] acpi: nfit: vmalloc-out-of-bounds Read in acpi_nfit_ctl

2024-12-02 Thread Dave Jiang
On 11/18/24 9:26 AM, Suraj Sonawane wrote: > Fix an issue detected by syzbot with KASAN: > > BUG: KASAN: vmalloc-out-of-bounds in cmd_to_func drivers/acpi/nfit/ > core.c:416 [inline] > BUG: KASAN: vmalloc-out-of-bounds in acpi_nfit_ctl+0x20e8/0x24a0 > drivers/acpi/nfit/core.c:459 > > The issue

[PATCH -v2 5/7] module: Extend the MODULE_ namespace parsing

2024-12-02 Thread Peter Zijlstra
Instead of only accepting "MODULE_${name}", extend it with a comma separated list of module names and add tail glob support. That is, something like: "MODULE_foo-*,bar" is now possible. Signed-off-by: Peter Zijlstra (Intel) --- kernel/module/main.c | 39 ++

[PATCH net-next v12 07/22] ovpn: implement basic TX path (UDP)

2024-12-02 Thread Antonio Quartulli
Packets sent over the ovpn interface are processed and transmitted to the connected peer, if any. Implementation is UDP only. TCP will be added by a later patch. Note: no crypto/encapsulation exists yet. Packets are just captured and sent. Signed-off-by: Antonio Quartulli --- drivers/net/Kconf

[PATCH net-next v12 00/22] Introducing OpenVPN Data Channel Offload

2024-12-02 Thread Antonio Quartulli
This is the 12th version of the patchset. Hopefully there are no major flaws that will require more resendings. I am sure we'll have plenty of time to polish up all bells and whistles :-) @Sergey, at the end I think I took in all your suggested changes, maybe with some adaptations. Notable change

  1   2   >