RE: [PATCH v1] selftests/bpf: Fix unnecessary conversion to bool in 'run_subtest'

2024-11-20 Thread John Fastabend
guanjing wrote: > Fixes the following coccicheck: > > tools/testing/selftests/bpf/test_loader.c:1033:64-69: WARNING: conversion to > bool not needed here > > Fixes: 80a4129fcf20 ("selftests/bpf: Add unit tests for > bpf_arena_alloc/free_pages") > Signed-off-by: guanjing > --- I'll argue this

Re: [PATCH 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

2024-11-20 Thread Shijith Thotton
>> @@ -63,44 +80,53 @@ static irqreturn_t octep_vdpa_intr_handler(int irq, >void *data) >> static void octep_free_irqs(struct octep_hw *oct_hw) >> { >> struct pci_dev *pdev = oct_hw->pdev; >> +int irq; >> + >> +for (irq = 0; irq < oct_hw->nb_irqs && oct_hw->irqs; irq++) { >> +

Re: [PATCH 2/4] vdpa/octeon_ep: handle device config change events

2024-11-20 Thread Shijith Thotton
>> >> The first interrupt of the device is used to notify the host about >> device configuration changes, such as link status updates. The ISR >> configuration area is updated to indicate a config change event when >> triggered. >> >> Signed-off-by: Satha Rao >> Signed-off-by: Shijith Thotton >>

Re: [PATCHv2 net-next] selftests: wireguards: use nft by default

2024-11-20 Thread Phil Sutter
Hangbin, On Tue, Nov 19, 2024 at 07:22:21AM +, Hangbin Liu wrote: > On Sun, Nov 17, 2024 at 09:09:00PM +0100, Jason A. Donenfeld wrote: > > On Mon, Nov 11, 2024 at 04:19:02AM +, Hangbin Liu wrote: > > > Use nft by default if it's supported, as nft is the replacement for > > > iptables, >

Re: [PATCH V3] selftests: livepatch: add test cases of stack_order sysfs interface

2024-11-20 Thread zhang warden
> On Oct 24, 2024, at 16:35, Wardenjohn wrote: > > Add selftest test cases to sysfs attribute 'stack_order'. > > Suggested-by: Petr Mladek > Signed-off-by: Wardenjohn > --- > .../testing/selftests/livepatch/test-sysfs.sh | 71 +++ > 1 file changed, 71 insertions(+) > > diff

Re: [PATCH net-next] selftests: net/psock_lib: Handle EINTR and EAGAIN

2024-11-20 Thread Leo Stone
Willem de Bruijn wrote: > Did you observe actual issues or is this based on the comment in the > existing code ("Should really handle EINTR and EAGAIN"). No, this patch was based purely off of the comment, and the examples of similar code in other selftests, e.g. tools/testing/selftests/bpf/xsk.c:

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-11-20 Thread Sergey Ryazanov
On 15.11.2024 16:39, Antonio Quartulli wrote: On 11/11/2024 00:54, Sergey Ryazanov wrote: Another one forgotten question, sorry about this. Please find the question inlined. On 29.10.2024 12:47, Antonio Quartulli wrote:   /* Send user data to the network    */   netdev_tx_t ovpn_net_xmit(stru

Re: [PATCH net-next v11 07/23] ovpn: introduce the ovpn_socket object

2024-11-20 Thread Sergey Ryazanov
On 15.11.2024 16:28, Antonio Quartulli wrote: On 10/11/2024 19:26, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: [...] +static bool ovpn_socket_hold(struct ovpn_socket *sock) +{ +    return kref_get_unless_zero(&sock->refcount); Why do we need to wrap this kref acqui

Re: [PATCH net-next v11 07/23] ovpn: introduce the ovpn_socket object

2024-11-20 Thread Sergey Ryazanov
On 19.11.2024 15:44, Antonio Quartulli wrote: On 15/11/2024 15:28, Antonio Quartulli wrote: [...] +} + +static struct ovpn_socket *ovpn_socket_get(struct socket *sock) +{ +    struct ovpn_socket *ovpn_sock; + +    rcu_read_lock(); +    ovpn_sock = rcu_dereference_sk_user_data(sock->sk); +    if

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-20 Thread Sergey Ryazanov
On 13.11.2024 12:03, Sabrina Dubroca wrote: 2024-11-13, 03:37:13 +0200, Sergey Ryazanov wrote: On 12.11.2024 19:31, Sabrina Dubroca wrote: 2024-11-10, 15:38:27 +0200, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: An ovpn_peer object holds the whole status of a remote pe

Re: [PATCH v2 09/13] media: i2c: imx214: Extract format and crop settings

2024-11-20 Thread André Apitzsch
Hi Ricardo, Am Mittwoch, dem 30.10.2024 um 13:10 +0100 schrieb Ricardo Ribalda Delgado: > Hi > > Aren't you changing the binning mode for 1920x1080  with this patch? > I think that could be considered an ABI change. Is the problem that the ABI changes or that it is not mentioned in the commit me

Re: [GIT PULL] OpenRISC updates for 6.13

2024-11-20 Thread pr-tracker-bot
The pull request you sent on Tue, 19 Nov 2024 17:06:55 +: > https://github.com/openrisc/linux.git tags/for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c66fbc6c3df9ccefbb896695cfc4db279d517ff1 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.ke

Re: [PATCH net-next v11 05/23] ovpn: keep carrier always on

2024-11-20 Thread Sergey Ryazanov
On 15.11.2024 16:13, Antonio Quartulli wrote: On 09/11/2024 02:11, Sergey Ryazanov wrote: On 29.10.2024 12:47, Antonio Quartulli wrote: An ovpn interface will keep carrier always on and let the user decide when an interface should be considered disconnected. This way, even if an ovpn interface

[PATCH] kunit: tool: add ability to parse test metadata

2024-11-20 Thread Rae Moar
Add ability for kunit parser to parse test metadata introduced in KTAPv2. Example of test metadata: KTAP version 2 #:ktap_test: test_name_example #:ktap_speed: slow #:ktap_test_file: /sys/kernel/... 1..1 ok 1 test Also add tests for this feature. Note this patch would no longer allow the

Re: [PATCH v5 10/19] gendwarfksyms: Limit structure expansion

2024-11-20 Thread Sami Tolvanen
On Wed, Oct 30, 2024 at 05:01:17PM +, Sami Tolvanen wrote: > > For pointers, limit structure expansion after the first pointer > in the symbol type. This should be plenty for detecting ABI > differences, but it stops us from pulling in half the kernel for > types that contain pointers to large

Re: [PATCH v2 09/13] media: i2c: imx214: Extract format and crop settings

2024-11-20 Thread Ricardo Ribalda Delgado
Hi André On Wed, Nov 20, 2024 at 9:07 PM André Apitzsch wrote: > > Hi Ricardo, > > Am Mittwoch, dem 30.10.2024 um 13:10 +0100 schrieb Ricardo Ribalda > Delgado: > > Hi > > > > Aren't you changing the binning mode for 1920x1080 with this patch? > > I think that could be considered an ABI change.

Re: [GIT PULL] Kselftest update for Linux 6.13-rc1

2024-11-20 Thread pr-tracker-bot
The pull request you sent on Mon, 18 Nov 2024 13:40:02 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest > tags/linux_kselftest-next-6.13-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/856385e0c56e7739bddea869e7a17f040211a2fc Thank you!

Re: [GIT PULL] livepatching for 6.13

2024-11-20 Thread pr-tracker-bot
The pull request you sent on Mon, 18 Nov 2024 14:04:19 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git > tags/livepatching-for-6.13 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/aa44f41470450f3f4fc74526c1f7369771545205 Thank you!

Re: [PATCH v4] memfd: `MFD_NOEXEC_SEAL` should not imply `MFD_ALLOW_SEALING`

2024-11-20 Thread Barnabás Pőcze
Hi Gentle ping again. I am still hoping we can move forward with this. Regards, Barnabás Pőcze 2024. szeptember 28., szombat 0:09 keltezéssel, Barnabás Pőcze írta: > Hi > > > Gentle ping. Is there any chance we could move forward with this? I am not > aware > of any breakage it would ca

Re: [PATCH v13 4/7] remoteproc: Introduce release_fw optional operation

2024-11-20 Thread Arnaud POULIQUEN
On 11/20/24 17:04, Mathieu Poirier wrote: > On Tue, 19 Nov 2024 at 13:38, Mathieu Poirier > wrote: >> >> On Tue, 19 Nov 2024 at 11:14, Arnaud POULIQUEN >> wrote: >>> >>> Hello Mathieu, >>> >>> On 11/18/24 18:52, Mathieu Poirier wrote: On Mon, Nov 04, 2024 at 02:35:12PM +0100, Arnaud Pouli

Re: [PATCH bpf-next v3 10/14] selftests/bpf: document pseudo-header checksum helpers

2024-11-20 Thread Stanislav Fomichev
On 11/20, Alexis Lothoré (eBPF Foundation) wrote: > network_helpers.h provides helpers to compute checksum for pseudo > headers but no helpers to compute the global checksums. > > Before adding those, clarify csum_tcpudp_magic and csum_ipv6_magic > purpose by adding some documentation. > > Signed

Re: [PATCH v13 4/7] remoteproc: Introduce release_fw optional operation

2024-11-20 Thread Mathieu Poirier
On Tue, 19 Nov 2024 at 13:38, Mathieu Poirier wrote: > > On Tue, 19 Nov 2024 at 11:14, Arnaud POULIQUEN > wrote: > > > > Hello Mathieu, > > > > On 11/18/24 18:52, Mathieu Poirier wrote: > > > On Mon, Nov 04, 2024 at 02:35:12PM +0100, Arnaud Pouliquen wrote: > > >> This patch updates the rproc_ops

Re: [PATCH v13 4/7] remoteproc: Introduce release_fw optional operation

2024-11-20 Thread Arnaud POULIQUEN
On 11/19/24 21:38, Mathieu Poirier wrote: > On Tue, 19 Nov 2024 at 11:14, Arnaud POULIQUEN > wrote: >> >> Hello Mathieu, >> >> On 11/18/24 18:52, Mathieu Poirier wrote: >>> On Mon, Nov 04, 2024 at 02:35:12PM +0100, Arnaud Pouliquen wrote: This patch updates the rproc_ops struct to include

Re: [PATCH bpf-next v3 13/14] selftests/bpf: migrate bpf flow dissectors tests to test_progs

2024-11-20 Thread Stanislav Fomichev
On 11/20, Alexis Lothoré (eBPF Foundation) wrote: > test_flow_dissector.sh loads flow_dissector program and subprograms, > creates and configured relevant tunnels and interfaces, and ensure that > the bpf dissection is actually performed correctly. Similar tests exist > in test_progs (thanks to flo

Re: [PATCH bpf-next v3 12/14] selftests/bpf: add network helpers to generate udp checksums

2024-11-20 Thread Stanislav Fomichev
On 11/20, Alexis Lothoré (eBPF Foundation) wrote: > network_helpers.c provides some helpers to generate ip checksums or ip > pseudo-header checksums, but not for upper layers (eg: udp checksums) > > Add helpers for udp checksum to allow manually building udp packets. > > Signed-off-by: Alexis Lot

Re: [PATCH bpf-next v3 11/14] selftests/bpf: use the same udp and tcp headers in tests under test_progs

2024-11-20 Thread Stanislav Fomichev
On 11/20, Alexis Lothoré (eBPF Foundation) wrote: > Trying to add udp-dedicated helpers in network_helpers involves > including some udp header, which makes multiple test_progs tests build > fail: > > In file included from ./progs/test_cls_redirect.h:13, > from [...]/prog_tests/cl

Re: [PATCH bpf-next v3 09/14] selftests/bpf: move ip checksum helper to network helpers

2024-11-20 Thread Stanislav Fomichev
On 11/20, Alexis Lothoré (eBPF Foundation) wrote: > xdp_metadata test has a small helper computing ipv4 checksums to allow > manually building packets. > > Move this helper to network_helpers to share it with other tests. > > Signed-off-by: Alexis Lothoré (eBPF Foundation) Acked-by: Stanislav F

Re: [PATCH net-next v11 18/23] ovpn: implement peer add/get/dump/delete via netlink

2024-11-20 Thread Sabrina Dubroca
2024-11-20, 12:34:08 +0100, Antonio Quartulli wrote: > On 20/11/2024 12:12, Sabrina Dubroca wrote: [...] > > > > I don't know when userspace would use v4mapped addresses, > > > > > > It happens when listening on [::] with a v6 socket that has no > > > "IPV6_V6ONLY" > > > set to true (you can chec

Re: [PATCH 2/3] libbpf: Remove powerpc prefix from syscall function names

2024-11-20 Thread Saket Kumar Bhaskar
On Fri, Nov 08, 2024 at 10:43:54AM -0800, Andrii Nakryiko wrote: > On Sun, Nov 3, 2024 at 9:00 PM Saket Kumar Bhaskar > wrote: > > > > Since commit 94746890202cf ("powerpc: Don't add __powerpc_ prefix to > > syscall entry points") drops _powerpc prefix to syscall entry points, > > even though pow

Re: [PATCH v13 4/7] remoteproc: Introduce release_fw optional operation

2024-11-20 Thread Mathieu Poirier
On Tue, 19 Nov 2024 at 11:14, Arnaud POULIQUEN wrote: > > Hello Mathieu, > > On 11/18/24 18:52, Mathieu Poirier wrote: > > On Mon, Nov 04, 2024 at 02:35:12PM +0100, Arnaud Pouliquen wrote: > >> This patch updates the rproc_ops struct to include an optional > >> release_fw function. > >> > >> The r

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-20 Thread Hans de Goede
Hi All, On 14-Nov-24 11:31 AM, Uwe Kleine-König wrote: > Hello, > > the kernel modules provided by Tuxedo on > https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers > are licensed under GPLv3 or later. This is incompatible with the > kernel's license and so makes it impossible fo

Re: [PATCH] media: i2c: imx412: Add missing newline to prints

2024-11-20 Thread Luca Weiss
On Mon Nov 18, 2024 at 10:45 PM CET, Luca Weiss wrote: > Add trailing \n to dev_dbg and dev_err prints where missing. > Forgot to add: Fixes: 9214e86c0cc1 ("media: i2c: Add imx412 camera sensor driver") Cc: sta...@vger.kernel.org > Signed-off-by: Luca Weiss > --- > drivers/media/i2c/imx412.c |

[PATCH fixes] riscv: mm: Do not call pmd dtor on vmemmap page table teardown

2024-11-20 Thread Björn Töpel
From: Björn Töpel The vmemmap's, which is used for RV64 with SPARSEMEM_VMEMMAP, page tables are populated using pmd (page middle directory) hugetables. However, the pmd allocation is not using the generic mechanism used by the VMA code (e.g. pmd_alloc()), or the RISC-V specific create_pgd_mapping

Re: [PATCH bpf-next v2 10/13] selftests/bpf: rename pseudo headers checksum computation

2024-11-20 Thread Alexis Lothoré
On 11/15/24 16:33, Stanislav Fomichev wrote: > On 11/14, Alexis Lothoré (eBPF Foundation) wrote: >> network_helpers.h provides helpers to compute checksum for pseudo >> headers but no helpers to compute the global checksums. >> >> Before adding those, rename the pseudo header checksum helper to cla

Re: [PATCH net-next v11 20/23] ovpn: kill key and notify userspace in case of IV exhaustion

2024-11-20 Thread Sabrina Dubroca
2024-11-14, 11:38:51 +0100, Antonio Quartulli wrote: > On 13/11/2024 15:28, Sabrina Dubroca wrote: > > Around that same "which netns" question, ovpn_udp{4,6}_output uses the > > socket's, but ovpn_nexthop_from_rt{4,6} uses the netdev's. > > I think this is ok, because routing related decision shou

Re: [PATCH RFC 2/6] mm/slub: add sheaf support for batching kfree_rcu() operations

2024-11-20 Thread Uladzislau Rezki
On Sun, Nov 17, 2024 at 12:01:01PM +0100, Vlastimil Babka wrote: > On 11/14/24 17:57, Uladzislau Rezki wrote: > > On Tue, Nov 12, 2024 at 05:38:46PM +0100, Vlastimil Babka wrote: > >> --- a/kernel/rcu/tree.c > >> +++ b/kernel/rcu/tree.c > >> @@ -65,6 +65,7 @@ > >> #include > >> #include > >> #

Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

2024-11-20 Thread Sabrina Dubroca
2024-10-29, 11:47:19 +0100, Antonio Quartulli wrote: > +/** > + * struct ovpn_peer - the main remote peer object > + * @ovpn: main openvpn instance this peer belongs to > + * @id: unique identifier > + * @vpn_addrs: IP addresses assigned over the tunnel > + * @vpn_addrs.ipv4: IPv4 assigned to peer

Re: [PATCH RFC 6/6] mm, slub: sheaf prefilling for guaranteed allocations

2024-11-20 Thread Vlastimil Babka
On 11/19/24 03:29, Hyeonggon Yoo wrote: > On Mon, Nov 18, 2024 at 11:26 PM Vlastimil Babka wrote: >> >> On 11/18/24 14:13, Hyeonggon Yoo wrote: >> > On Wed, Nov 13, 2024 at 1:39 AM Vlastimil Babka wrote: >> >> + >> >> +/* >> >> + * Allocate from a sheaf obtained by kmem_cache_prefill_sheaf() >> >

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-11-20 Thread Sabrina Dubroca
2024-10-29, 11:47:21 +0100, Antonio Quartulli wrote: > +static int ovpn_udp4_output(struct ovpn_struct *ovpn, struct ovpn_bind *bind, > + struct dst_cache *cache, struct sock *sk, > + struct sk_buff *skb) > +{ [...] > + if (unlikely(!inet_confirm_

Re: [PATCH net-next v11 18/23] ovpn: implement peer add/get/dump/delete via netlink

2024-11-20 Thread Antonio Quartulli
On 20/11/2024 12:12, Sabrina Dubroca wrote: 2024-11-14, 10:21:18 +0100, Antonio Quartulli wrote: On 13/11/2024 17:56, Sabrina Dubroca wrote: 2024-11-12, 15:19:50 +0100, Antonio Quartulli wrote: On 04/11/2024 16:14, Sabrina Dubroca wrote: 2024-10-29, 11:47:31 +0100, Antonio Quartulli wrote: +

Re: [PATCH net-next v11 18/23] ovpn: implement peer add/get/dump/delete via netlink

2024-11-20 Thread Sabrina Dubroca
2024-11-14, 10:21:18 +0100, Antonio Quartulli wrote: > On 13/11/2024 17:56, Sabrina Dubroca wrote: > > 2024-11-12, 15:19:50 +0100, Antonio Quartulli wrote: > > > On 04/11/2024 16:14, Sabrina Dubroca wrote: > > > > 2024-10-29, 11:47:31 +0100, Antonio Quartulli wrote: > > > > > +static int ovpn_nl_pe

Re: [PATCH] virtio_balloon: Use outer variable 'page'

2024-11-20 Thread Gavin Shan
On 11/20/24 3:49 PM, zhangjiao2 wrote: From: zhang jiao There is no need to define a local variable 'page', just use outer variable 'page'. Signed-off-by: zhang jiao --- drivers/virtio/virtio_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Gavin Shan

[PATCHv2 net 2/2] selftests/rtnetlink.sh: add mngtempaddr test

2024-11-20 Thread Hangbin Liu
Add a test to check the temporary address could be added/removed correctly when mngtempaddr is set or removed/unmanaged. Signed-off-by: Sam Edwards Signed-off-by: Hangbin Liu --- tools/testing/selftests/net/rtnetlink.sh | 95 1 file changed, 95 insertions(+) diff --git

[PATCHv2 net 1/2] net/ipv6: delete temporary address if mngtmpaddr is removed or unmanaged

2024-11-20 Thread Hangbin Liu
RFC8981 section 3.4 says that existing temporary addresses must have their lifetimes adjusted so that no temporary addresses should ever remain "valid" or "preferred" longer than the incoming SLAAC Prefix Information. This would strongly imply in Linux's case that if the "mngtmpaddr" address is del

[PATCHv2 net 0/2] ipv6: fix temporary address not removed correctly

2024-11-20 Thread Hangbin Liu
Currently the temporary address is not removed when mngtmpaddr is deleted or becomes unmanaged. The patch set fixed this issue and add a related test. v2: 1) delete the tempaddrs directly instead of remove them in addrconf_verify_rtnl(Sam Edwards) 2) Update the test case by checking the address

Re: [PATCH] virtio_balloon: Use outer variable 'page'

2024-11-20 Thread David Hildenbrand
On 20.11.24 06:49, zhangjiao2 wrote: From: zhang jiao There is no need to define a local variable 'page', just use outer variable 'page'. Signed-off-by: zhang jiao --- drivers/virtio/virtio_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_

Re: [PATCH] selftests/mount_setattr: Fix failures on 64K PAGE_SIZE kernels

2024-11-20 Thread Christian Brauner
On Sat, 16 Nov 2024 00:41:14 +1100, Michael Ellerman wrote: > Currently the mount_setattr_test fails on machines with a 64K PAGE_SIZE, > with errors such as: > > # RUN mount_setattr_idmapped.invalid_fd_negative ... > mkfs.ext4: No space left on device while writing out and closing f

Re: [PATCH 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

2024-11-20 Thread Dan Carpenter
On Wed, Nov 20, 2024 at 12:34:50PM +0530, Shijith Thotton wrote: > @@ -63,44 +80,53 @@ static irqreturn_t octep_vdpa_intr_handler(int irq, void > *data) > static void octep_free_irqs(struct octep_hw *oct_hw) > { > struct pci_dev *pdev = oct_hw->pdev; > + int irq; > + > + for (irq =