Re: [PATCH v2 7/7] vhost: Add new UAPI to support change to task mode

2024-10-16 Thread Jason Wang
On Tue, Oct 15, 2024 at 6:19 PM Michael S. Tsirkin wrote: > > On Mon, Oct 14, 2024 at 03:56:33PM -0500, Mike Christie wrote: > > On 10/3/24 8:58 PM, Cindy Lu wrote: > > > Add a new UAPI to support setting the vhost device to > > > use task mode. The user space application needs to use > > > VHOST_

Re: [PATCH] virtio_net: fix integer overflow in stats

2024-10-16 Thread Jason Wang
On Thu, Oct 17, 2024 at 1:27 AM Michael S. Tsirkin wrote: > > Static analysis on linux-next has detected the following issue > in function virtnet_stats_ctx_init, in drivers/net/virtio_net.c : > > if (vi->device_stats_cap & VIRTIO_NET_STATS_TYPE_CVQ) { > queue_type = VIRTNE

Re: [PATCH net-next v9 04/23] ovpn: add basic interface creation/destruction/management routines

2024-10-16 Thread Jiri Pirko
Wed, Oct 16, 2024 at 04:24:09PM CEST, anto...@openvpn.net wrote: >On 16/10/2024 10:27, Jiri Pirko wrote: >> Wed, Oct 16, 2024 at 03:03:04AM CEST, anto...@openvpn.net wrote: >> > Add basic infrastructure for handling ovpn interfaces. >> > >> > Signed-off-by: Antonio Quartulli >> > --- >> > drivers

[PATCH -next 2/2] selftests:timers: remove unneeded semicolon

2024-10-16 Thread Jiapeng Chong
No functional modification involved. ./tools/testing/selftests/timers/nsleep-lat.c:62:2-3: Unneeded semicolon. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11406 Signed-off-by: Jiapeng Chong --- tools/testing/selftests/timers/nsleep-lat.c | 2 +- 1 file chang

[PATCH -next 1/2] selftests:timers: remove unneeded semicolon

2024-10-16 Thread Jiapeng Chong
No functional modification involved. ./tools/testing/selftests/timers/nanosleep.c:63:2-3: Unneeded semicolon. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11407 Signed-off-by: Jiapeng Chong --- tools/testing/selftests/timers/nanosleep.c | 2 +- 1 file changed

[PATCH net-next v3 3/3] selftests: nic_performance: Add selftest for performance of NIC driver

2024-10-16 Thread Mohan Prasad J
Add selftest case to check the send and receive throughput. Supported link modes between local NIC driver and partner are varied. Then send and receive throughput is captured and verified. Test uses iperf3 tool. Signed-off-by: Mohan Prasad J --- .../testing/selftests/drivers/net/hw/Makefile |

[PATCH net-next v3 1/3] selftests: nic_link_layer: Add link layer selftest for NIC driver

2024-10-16 Thread Mohan Prasad J
Add selftest file for the link layer tests of a NIC driver. Test for auto-negotiation is added. Add LinkConfig class for changing link layer configs. Selftest makes use of ksft modules and ethtool. Include selftest file in the Makefile. Signed-off-by: Mohan Prasad J --- .../testing/selftests/dri

[PATCH net-next v3 2/3] selftests: nic_link_layer: Add selftest case for speed and duplex states

2024-10-16 Thread Mohan Prasad J
Add selftest case for testing the speed and duplex state of local NIC driver and the partner based on the supported link modes obtained from the ethtool. Speed and duplex states are varied and verified using ethtool. Signed-off-by: Mohan Prasad J --- .../drivers/net/hw/nic_link_layer.py

[PATCH net-next v3 0/3] selftests: Add selftest for link layer and performance testing

2024-10-16 Thread Mohan Prasad J
The series of patches are for doing basic tests of NIC driver. Test comprises checks for auto-negotiation, speed, duplex state and throughput between local NIC and partner. Tools such as ethtool, iperf3 are used. Signed-off-by: Mohan Prasad J --- Changes in v3: - LinkConfig class is included in t

Re: [PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-10-16 Thread Christophe Leroy
just test long symbols by self generated symbols as another test case. In case its useful to you I've put this in a rebased branch 20241016-modules-symtab branch. Feel free to use as you see fit. By reading this, I discovered that was initially added to powerpc by commit 271ca788774a (

Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2024-10-16 Thread John Hubbard
On 10/16/24 3:06 PM, Lorenzo Stoakes wrote: On Wed, Oct 16, 2024 at 02:00:27PM -0600, Shuah Khan wrote: On 10/16/24 04:20, Lorenzo Stoakes wrote: ... diff --git a/tools/testing/selftests/pidfd/pidfd.h b/tools/testing/selftests/pidfd/pidfd.h index 88d6830ee004..1640b711889b 100644 --- a/tools/

The "make headers" requirement, revisited: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2024-10-16 Thread John Hubbard
On 10/16/24 1:00 PM, Shuah Khan wrote: On 10/16/24 04:20, Lorenzo Stoakes wrote: ... diff --git a/tools/testing/selftests/pidfd/pidfd.h b/tools/testing/selftests/pidfd/pidfd.h index 88d6830ee004..1640b711889b 100644 --- a/tools/testing/selftests/pidfd/pidfd.h +++ b/tools/testing/selftests/pidf

Re: [PATCH v2] selftest/tcp-ao: Add filter tests

2024-10-16 Thread Dmitry Safonov
On Wed, 16 Oct 2024 at 06:59, Leo Stone wrote: > > Add tests that check if getsockopt(TCP_AO_GET_KEYS) returns the right > keys when using different filters. > > Sample output: > > > # ok 114 filter keys: by sndid, rcvid, address > > # ok 115 filter keys: by is_current > > # ok 116 filter keys: by

Re: [PATCH 00/12] Module Validation Refactor

2024-10-16 Thread Sami Tolvanen
Hi, On Tue, Oct 15, 2024 at 4:16 PM Matthew Maurer wrote: > > Split out from Extended MODVERSIONS Support [1] > > This series refactors module validation during loading to ensure that > everything is checked on its way in. This is intended to make the code > robust enough that we can more confide

Re: [PATCH v6 1/5] export_report: Rehabilitate script

2024-10-16 Thread Sami Tolvanen
Hi, On Tue, Oct 15, 2024 at 4:19 PM Matthew Maurer wrote: > > The `export_report.pl` script was broken [1] a while back due to a code > cleanup causing the regex to no longer match. Additionally, it assumes a > `modules.order` file containing `.ko` in a build directory with `.mod.c` > files. I ca

[PATCH net-next v4 3/3] connector/cn_proc: Selftest for threads

2024-10-16 Thread Anjali Kulkarni
Test to check if setting PROC_CN_MCAST_NOTIFY in proc connector API, allows a thread's non-zero exit status to be returned to proc_filter. The threads.c program creates 2 child threads. 1st thread handles signal SIGSEGV, and 2nd thread needs to indicate some error condition (value 1) to the kernel

[PATCH net-next v4 1/3] connector/cn_proc: Add hash table for threads

2024-10-16 Thread Anjali Kulkarni
Add a new type PROC_CN_MCAST_NOTIFY to proc connector API, which allows a thread to notify the kernel that is going to exit with a non-zero exit code and specify the exit code in it. When thread exits in the kernel, it will send this exit code as a proc filter notification to any listening process.

[PATCH net-next v4 2/3] connector/cn_proc: Kunit tests for threads hash table

2024-10-16 Thread Anjali Kulkarni
Kunit tests to test hash table add, delete, duplicate add and delete. Add following configs and compile kernel code: CONFIG_CONNECTOR=y CONFIG_PROC_EVENTS=y CONFIG_NET=y CONFIG_KUNIT=m CONFIG_CN_HASH_KUNIT_TEST=m To run kunit tests: sudo modprobe cn_hash_test Output of kunit tests and hash table

[PATCH net-next v4 0/3] Threads support in proc connector

2024-10-16 Thread Anjali Kulkarni
Recently we committed a fix to allow processes to receive notifications for non-zero exits via the process connector module. Commit is a4c9a56e6a2c. However, for threads, when it does a pthread_exit(&exit_status) call, the kernel is not aware of the exit status with which pthread_exit is called. I

Re: [PATCH v6 4/5] modpost: Produce extended MODVERSIONS information

2024-10-16 Thread Sami Tolvanen
Hi Matt, On Tue, Oct 15, 2024 at 4:19 PM Matthew Maurer wrote: > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index 107393a8c48a..d18ff8a1109a 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -1840,15 +1840,56 @@ static void add_versions(struct buffer *b,

Re: [RFC PATCH 26/39] KVM: guest_memfd: Track faultability within a struct kvm_gmem_private

2024-10-16 Thread Jason Gunthorpe
On Wed, Oct 16, 2024 at 07:49:31PM -0400, Peter Xu wrote: > On Wed, Oct 16, 2024 at 07:51:57PM -0300, Jason Gunthorpe wrote: > > On Wed, Oct 16, 2024 at 04:16:17PM -0400, Peter Xu wrote: > > > > > > Is there chance that when !CoCo will be supported, then external modules > > > (e.g. VFIO) can reus

Re: [RFC PATCH 26/39] KVM: guest_memfd: Track faultability within a struct kvm_gmem_private

2024-10-16 Thread Peter Xu
On Wed, Oct 16, 2024 at 07:51:57PM -0300, Jason Gunthorpe wrote: > On Wed, Oct 16, 2024 at 04:16:17PM -0400, Peter Xu wrote: > > > > Is there chance that when !CoCo will be supported, then external modules > > (e.g. VFIO) can reuse the old user mappings, just like before gmemfd? > > > > To suppor

Re: [PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-10-16 Thread Luis Chamberlain
also just test long symbols by self generated symbols as another test case. In case its useful to you I've put this in a rebased branch 20241016-modules-symtab branch. Feel free to use as you see fit. I forget what we concluded on Helge Deller's alignement patches, I think there was a

Re: [PATCH 1/3] KVM: x86, vmx: Add function for event delivery error generation

2024-10-16 Thread Sean Christopherson
On Wed, Oct 16, 2024, Ivan Orlov wrote: > On 10/16/24 22:05, Sean Christopherson wrote: > > On Tue, Oct 15, 2024, Ivan Orlov wrote: > > > > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > > > > > index c67e448c6ebd..afd785e7f3a3 100644 > > > > > --- a/arch/x86/kvm/vmx/vmx.c > > > >

Re: [PATCH v2] selftests: clone3: Use the capget and capset syscall directly

2024-10-16 Thread Shuah Khan
On 10/16/24 03:18, zhouyuhang wrote: 在 2024/10/15 23:31, Shuah Khan 写道: On 10/15/24 04:59, zhouyuhang wrote: From: zhouyuhang The libcap commit aca076443591 ("Make cap_t operations thread safe.") added a __u8 mutex at the beginning of the struct _cap_struct, it changes the offset of the mem

Re: [PATCH 2/3] KVM: vmx, svm, mmu: Process MMIO during event delivery

2024-10-16 Thread Ivan Orlov
On 10/12/24 01:05, Sean Christopherson wrote: +* without VMM intervention, so return a corresponding internal error +* instead (otherwise, vCPU will fall into infinite loop trying to +* deliver the event again and again).

Re: [RFC PATCH 26/39] KVM: guest_memfd: Track faultability within a struct kvm_gmem_private

2024-10-16 Thread Jason Gunthorpe
On Wed, Oct 16, 2024 at 04:16:17PM -0400, Peter Xu wrote: > > Is there chance that when !CoCo will be supported, then external modules > (e.g. VFIO) can reuse the old user mappings, just like before gmemfd? > > To support CoCo, I understand gmem+offset is required all over the places. > However i

Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2024-10-16 Thread Shuah Khan
On 10/16/24 16:06, Lorenzo Stoakes wrote: On Wed, Oct 16, 2024 at 02:00:27PM -0600, Shuah Khan wrote: On 10/16/24 04:20, Lorenzo Stoakes wrote: Add tests to assert that PIDFD_SELF_* correctly refers to the current thread and process. This is only practically meaningful to pidfd_send_signal() a

Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2024-10-16 Thread Lorenzo Stoakes
On Wed, Oct 16, 2024 at 11:06:34PM +0100, Lorenzo Stoakes wrote: [sniip] > > > > The import will be fine and you can control that with -I flag in > > the makefile. Remove these and try to get including linux/pidfd.h > > working. > > I just tried this and it's not fine :) it immediately broke the bu

[PATCH net-next v3 2/3] connector/cn_proc: Kunit tests for threads hash table

2024-10-16 Thread Anjali Kulkarni
Kunit tests to test hash table add, delete, duplicate add and delete. Add following configs and compile kernel code: CONFIG_CONNECTOR=y CONFIG_PROC_EVENTS=y CONFIG_NET=y CONFIG_KUNIT=m CONFIG_CN_HASH_KUNIT_TEST=m To run kunit tests: sudo modprobe cn_hash_test Output of kunit tests and hash table

[PATCH net-next v3 0/3] Threads support in proc connector

2024-10-16 Thread Anjali Kulkarni
Recently we committed a fix to allow processes to receive notifications for non-zero exits via the process connector module. Commit is a4c9a56e6a2c. However, for threads, when it does a pthread_exit(&exit_status) call, the kernel is not aware of the exit status with which pthread_exit is called. I

[PATCH net-next v3 3/3] connector/cn_proc: Selftest for threads

2024-10-16 Thread Anjali Kulkarni
Test to check if setting PROC_CN_MCAST_NOTIFY in proc connector API, allows a thread's non-zero exit status to be returned to proc_filter. The threads.c program creates 2 child threads. 1st thread handles signal SIGSEGV, and 2nd thread needs to indicate some error condition (value 1) to the kernel

[PATCH net-next v3 1/3] connector/cn_proc: Add hash table for threads

2024-10-16 Thread Anjali Kulkarni
Add a new type PROC_CN_MCAST_NOTIFY to proc connector API, which allows a thread to notify the kernel that is going to exit with a non-zero exit code and specify the exit code in it. When thread exits in the kernel, it will send this exit code as a proc filter notification to any listening process.

Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2024-10-16 Thread Lorenzo Stoakes
On Wed, Oct 16, 2024 at 02:00:27PM -0600, Shuah Khan wrote: > On 10/16/24 04:20, Lorenzo Stoakes wrote: > > Add tests to assert that PIDFD_SELF_* correctly refers to the current > > thread and process. > > > > This is only practically meaningful to pidfd_send_signal() and > > pidfd_getfd(), but als

Re: [PATCH 1/3] KVM: x86, vmx: Add function for event delivery error generation

2024-10-16 Thread Ivan Orlov
On 10/16/24 22:05, Sean Christopherson wrote: On Tue, Oct 15, 2024, Ivan Orlov wrote: diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index c67e448c6ebd..afd785e7f3a3 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -6550,19 +6550,10 @@ static int __vmx_handle_exi

Re: [PATCH v2] selftest: hid: add the missing tests directory

2024-10-16 Thread Shuah Khan
On 10/16/24 09:08, Shuah Khan wrote: On 10/16/24 02:27, Benjamin Tissoires wrote: On Oct 15 2024, Yun Lu wrote: Commit 160c826b4dd0 ("selftest: hid: add missing run-hid-tools-tests.sh") has added the run-hid-tools-tests.sh script for it to be installed, but I forgot to add the tests directory t

Re: [PATCH v4 10/19] gendwarfksyms: Limit structure expansion

2024-10-16 Thread Sami Tolvanen
Hi Petr, On Wed, Oct 16, 2024 at 2:16 PM Petr Pavlu wrote: > > On 10/8/24 20:38, Sami Tolvanen wrote: > > /* > > - * These can be emitted for stand-elone assembly code, which means we > > + * These can be emitted for stand-alone assembly code, which means we > >* might run

Re: [PATCH net-next v9 23/23] testing/selftest: add test tool and scripts for ovpn module

2024-10-16 Thread Shuah Khan
On 10/15/24 19:03, Antonio Quartulli wrote: The ovpn-cli tool can be compiled and used as selftest for the ovpn kernel module. It implements the netlink API and can thus be integrated in any script for more automated testing. Along with the tool, 2 scripts are added that perform basic functiona

Re: [PATCH 1/3] KVM: x86, vmx: Add function for event delivery error generation

2024-10-16 Thread Sean Christopherson
On Tue, Oct 15, 2024, Ivan Orlov wrote: > > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > > > index c67e448c6ebd..afd785e7f3a3 100644 > > > --- a/arch/x86/kvm/vmx/vmx.c > > > +++ b/arch/x86/kvm/vmx/vmx.c > > > @@ -6550,19 +6550,10 @@ static int __vmx_handle_exit(struct kvm_vcpu

Re: [RFC PATCH 26/39] KVM: guest_memfd: Track faultability within a struct kvm_gmem_private

2024-10-16 Thread Peter Xu
On Wed, Oct 16, 2024 at 10:45:43AM +0200, David Hildenbrand wrote: > On 16.10.24 01:42, Ackerley Tng wrote: > > Peter Xu writes: > > > > > On Fri, Oct 11, 2024 at 11:32:11PM +, Ackerley Tng wrote: > > > > Peter Xu writes: > > > > > > > > > On Tue, Sep 10, 2024 at 11:43:57PM +, Ackerley

Re: [PATCH v2 1/3] pidfd: extend pidfd_get_pid() and de-duplicate pid lookup

2024-10-16 Thread Lorenzo Stoakes
On Wed, Oct 16, 2024 at 03:00:55PM +0200, Christian Brauner wrote: > On Fri, Oct 11, 2024 at 12:05:55PM +0100, Lorenzo Stoakes wrote: > > The means by which a pid is determined from a pidfd is duplicated, with > > some callers holding a reference to the (pid)fd, and others explicitly > > pinning th

Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2024-10-16 Thread Shuah Khan
On 10/16/24 04:20, Lorenzo Stoakes wrote: Add tests to assert that PIDFD_SELF_* correctly refers to the current thread and process. This is only practically meaningful to pidfd_send_signal() and pidfd_getfd(), but also explicitly test that we disallow this feature for setns() where it would make

Re: [PATCH 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2024-10-16 Thread Shuah Khan
On 10/11/24 02:20, Lorenzo Stoakes wrote: On Thu, Oct 10, 2024 at 05:16:22PM -0600, Shuah Khan wrote: On 10/10/24 12:15, Lorenzo Stoakes wrote: Add tests to assert that PIDFD_SELF_* correctly refers to the current thread and process. This is only practically meaningful to pidfd_send_signal() a

Re: [PATCH v3 1/2] virt: pvmemcontrol: control guest physical memory properties

2024-10-16 Thread Greg Kroah-Hartman
On Wed, Oct 16, 2024 at 12:39:46PM -0700, Yuanchu Xie wrote: > + dev_info(dev->device, > + "pvmemcontrol_vmm_info.ret_errno = %u\n" > + "pvmemcontrol_vmm_info.ret_code = %u\n" > + "pvmemcontrol_vmm_info.major_version = %llu\n" > + "pvmemcontro

Re: [PATCH v3 1/2] virt: pvmemcontrol: control guest physical memory properties

2024-10-16 Thread Greg Kroah-Hartman
On Wed, Oct 16, 2024 at 12:39:46PM -0700, Yuanchu Xie wrote: > Pvmemcontrol provides a way for the guest to control its physical memory > properties and enables optimizations and security features. For example, > the guest can provide information to the host where parts of a hugepage > may be unbac

[PATCH v3 1/2] virt: pvmemcontrol: control guest physical memory properties

2024-10-16 Thread Yuanchu Xie
Pvmemcontrol provides a way for the guest to control its physical memory properties and enables optimizations and security features. For example, the guest can provide information to the host where parts of a hugepage may be unbacked, or sensitive data may not be swapped out, etc. Pvmemcontrol all

[PATCH v3 2/2] virt: pvmemcontrol: add Yuanchu and Pasha as maintainers

2024-10-16 Thread Yuanchu Xie
The pvmemcontrol driver lives under drivers/virt/pvmemcontrol. We specify maintainers for the driver. Signed-off-by: Yuanchu Xie --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index aacccb376c28..5e661f39e07d 100644 --- a/MAINTAINERS +++ b/MA

Re: [PATCH net-next v3 0/9] do not leave dangling sk pointers in pf->create functions

2024-10-16 Thread patchwork-bot+bluetooth
Hello: This series was applied to bluetooth/bluetooth-next.git (master) by Jakub Kicinski : On Mon, 14 Oct 2024 16:37:59 +0100 you wrote: > Some protocol family create() implementations have an error path after > allocating the sk object and calling sock_init_data(). sock_init_data() > attaches t

[PATCH bpf-next 6/6] selftests/bpf: remove test_tcp_check_syncookie

2024-10-16 Thread eBPF Foundation
Now that btf_skc_cls_ingress has the same coverage as test_tcp_check_syncookie, remove the second one and keep the first one as it is integrated in test_progs Signed-off-by: Alexis Lothoré (eBPF Foundation) --- tools/testing/selftests/bpf/.gitignore | 1 - tools/testing/selftests/b

[PATCH bpf-next 5/6] selftests/bpf: test MSS value returned with bpf_tcp_gen_syncookie

2024-10-16 Thread eBPF Foundation
One remaining difference between test_tcp_check_syncookie.sh and btf_skc_cls_ingress is a small test on the mss value embedded in the cookie generated with the eBPF helper. Bring the corresponding test in btf_skc_cls_ingress. Signed-off-by: Alexis Lothoré (eBPF Foundation) --- tools/testing/sel

[PATCH bpf-next 4/6] selftests/bpf: add ipv4 and dual ipv4/ipv6 support in btf_skc_cls_ingress

2024-10-16 Thread eBPF Foundation
btf_skc_cls_ingress test currently checks that syncookie and bpf_sk_assign/release helpers behave correctly in multiple scenarios, but only with ipv4 socket. Increase those helpers coverage by adding testing support for IPv6-only sockets and IPv4/IPv6 sockets. The rework is mostly based on feature

[PATCH bpf-next 3/6] selftests/bpf: get rid of global vars in btf_skc_cls_ingress

2024-10-16 Thread eBPF Foundation
There are a few global variables in btf_skc_cls_ingress.c, which are not really used by different tests. Get rid of those global variables, by performing the following updates: - make srv_sa6 local to the main runner function - make skel local to the main function, and propagate it through functi

[PATCH bpf-next 2/6] selftests/bpf: add missing ns cleanups in btf_skc_cls_ingress

2024-10-16 Thread eBPF Foundation
btf_skc_cls_ingress.c currently runs two subtests, and create a dedicated network namespace for each, but never cleans up the created namespace once the test has ended. Add missing namespace cleanup after each namespace to avoid accumulating namespaces for each new subtest. While at it, switch nam

[PATCH bpf-next 1/6] selftests/bpf: factorize conn and syncookies tests in a single runner

2024-10-16 Thread eBPF Foundation
btf_skc_cls_ingress currently describe two tests, both running a simple tcp server and then initializing a connection to it. The sole difference between the tests is about the tcp_syncookie configuration, and some checks around this feature being enabled/disabled. Share the common code between tho

[PATCH bpf-next 0/6] selftests/bpf: integrate test_tcp_check_syncookie.sh into test_progs

2024-10-16 Thread eBPF Foundation
Hello, this series aims to bring test_tcp_check_syncookie.sh scope into test_progs to make sure that the corresponding tests are also run automatically in CI. This script tests for bpf_tcp_{gen,check}_syncookie and bpf_skc_lookup_tcp, in different contexts (ipv4, v6 or dual, and with tc and xdp pro

Re: [PATCH v2 1/2] virt: pvmemcontrol: control guest physical memory properties

2024-10-16 Thread Greg Kroah-Hartman
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [PATCH v2 1/2] virt: pvmemcontrol: control guest physical memory properties

2024-10-16 Thread Yuanchu Xie
Hi Greg, Are there any other changes that you'd like to see with this driver since your last comments [1]? [1] https://lore.kernel.org/linux-mm/2024051414-untie-deviant-ed35@gregkh/ Thanks, Yuanchu On Mon, Sep 30, 2024 at 6:14 PM Yuanchu Xie wrote: > > I made a mistake. This is supposed to be

Re: [PATCH net-next v2 3/3] connector/cn_proc: Selftest for threads

2024-10-16 Thread Anjali Kulkarni
> On Oct 15, 2024, at 5:32 PM, Liam Howlett wrote: > > * Anjali Kulkarni [241015 17:28]: >> >> >>> On Oct 15, 2024, at 12:27 PM, Liam Howlett wrote: >>> >>> * Anjali Kulkarni [241015 13:30]: Test to check if setting PROC_CN_MCAST_NOTIFY in proc connector API, allows a thread's n

[PATCH] virtio_net: fix integer overflow in stats

2024-10-16 Thread Michael S. Tsirkin
Static analysis on linux-next has detected the following issue in function virtnet_stats_ctx_init, in drivers/net/virtio_net.c : if (vi->device_stats_cap & VIRTIO_NET_STATS_TYPE_CVQ) { queue_type = VIRTNET_Q_TYPE_CQ; ctx->bitmap[queue_type] |= VIRTIO_NET_S

Re: [PATCH] mailbox, remoteproc: k3-m4+: fix compile testing

2024-10-16 Thread Andrew Davis
On 10/16/24 11:02 AM, Mathieu Poirier wrote: On Wed, Oct 16, 2024 at 10:37:35AM -0500, Andrew Davis wrote: On 10/16/24 10:26 AM, Mathieu Poirier wrote: On Mon, Oct 14, 2024 at 09:56:11AM -0500, Andrew Davis wrote: On 10/7/24 8:23 AM, Arnd Bergmann wrote: From: Arnd Bergmann The k3-m4 remote

[PATCH 0/2] Enable compile testing for K3 RemoteProc drivers

2024-10-16 Thread Andrew Davis
Hello all, This is a follow up to [0] that adds the same for the other two K3 RemoteProc drivers. Series is based on rproc-next branch. Thanks, Andrew [0] https://lore.kernel.org/lkml/20241007132441.2732215-1-a...@kernel.org/ Andrew Davis (2): remoteproc: k3-dsp: Add compile testing support

[PATCH 2/2] remoteproc: k3-r5: Add compile testing support

2024-10-16 Thread Andrew Davis
This driver can be compile tested on non-K3 architectures as long as TI_SCI_PROTOCOL is not compiled as a module. Enable this here to improve this driver's build coverage. Signed-off-by: Andrew Davis --- drivers/remoteproc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

[PATCH 1/2] remoteproc: k3-dsp: Add compile testing support

2024-10-16 Thread Andrew Davis
This driver can be compile tested on non-K3 architectures as long as TI_SCI_PROTOCOL is not compiled as a module. Enable this here to improve this driver's build coverage. Signed-off-by: Andrew Davis --- drivers/remoteproc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

Re: [v6 PATCH 1/2] hugetlb: arm64: add mte support

2024-10-16 Thread Catalin Marinas
On Tue, 01 Oct 2024 15:52:19 -0700, Yang Shi wrote: > Enable MTE support for hugetlb. > > The MTE page flags will be set on the folio only. When copying > hugetlb folio (for example, CoW), the tags for all subpages will be copied > when copying the first subpage. > > When freeing hugetlb folio,

Re: [PATCH] kselftest/arm64: Validate that GCS push and write permissions work

2024-10-16 Thread Catalin Marinas
On Sat, 05 Oct 2024 01:17:18 +0100, Mark Brown wrote: > Add trivial assembly programs which give themselves the appropriate > permissions and then execute GCSPUSHM and GCSSTR, they will report errors > by generating signals on the non-permitted instructions. Not using libc > minimises the interacti

Re: [PATCH] kselftest/arm64: Ensure stable names for GCS stress test results

2024-10-16 Thread Catalin Marinas
On Fri, 11 Oct 2024 15:36:25 +0100, Mark Brown wrote: > The GCS stress test program currently uses the PID of the threads it > creates in the test names it reports, resulting in unstable test names > between runs. Fix this by using a thread number instead. > > Applied to arm64 (for-next/gcs), th

[PATCH v2 rcu 3/3] rcu: Finer-grained grace-period-end checks in rcu_dump_cpu_stacks()

2024-10-16 Thread Paul E. McKenney
This commit pushes the grace-period-end checks further down into rcu_dump_cpu_stacks(), and also uses lockless checks coupled with finer-grained locking. The result is that the current leaf rcu_node structure's ->lock is acquired only if a stack backtrace might be needed from the current CPU, and

[PATCH v2 rcu 1/3] rcu: Delete unused rcu_gp_might_be_stalled() function

2024-10-16 Thread Paul E. McKenney
The rcu_gp_might_be_stalled() function is no longer used, so this commit removes it. Signed-off-by: Paul E. McKenney Reviewed-by: Joel Fernandes (Google) --- include/linux/rcutiny.h | 1 - include/linux/rcutree.h | 1 - kernel/rcu/tree_stall.h | 30 -- 3 files chan

[PATCH v2 rcu 2/3] rcu: Stop stall warning from dumping stacks if grace period ends

2024-10-16 Thread Paul E. McKenney
Currently, once an RCU CPU stall warning decides to dump the stalling CPUs' stacks, the rcu_dump_cpu_stacks() function persists until it has gone through the full list. Unfortunately, if the stalled grace periods ends midway through, this function will be dumping stacks of innocent-bystander CPUs

[PATCH v2 rcu 0/3] RCU CPU stall-warning changes for v6.13

2024-10-16 Thread Paul E. McKenney
Hello! This series contains RCU CPU stall-warning changes for v6.13: 1. Delete unused rcu_gp_might_be_stalled() function. 2. Stop stall warning from dumping stacks if grace period ends. 3. Finer-grained grace-period-end checks in rcu_dump_cpu_stacks(). Changes since v1: o

Re: [peterz-queue:sched/lazy] [sched, x86] 74d850cd4c: WARNING:at_kernel/rcu/rcutorture.c:#rcu_torture_stats_print[rcutorture]

2024-10-16 Thread Paul E. McKenney
On Wed, Oct 16, 2024 at 05:40:48PM +0200, Sebastian Andrzej Siewior wrote: > On 2024-10-15 15:47:20 [+0800], kernel test robot wrote: > > Hello, > Hi, > > it took me a while to reproduce this because it does not trigger without > the ltp userland and this is not downloaded properly so I had to > w

Re: [PATCH v3] remoteproc: Add a new remoteproc state RPROC_DEFUNCT

2024-10-16 Thread anish kumar
On Tue, Oct 15, 2024 at 9:57 PM Mukesh Ojha wrote: > > Multiple call to glink_subdev_stop() for the same remoteproc can happen > if rproc_stop() fails from Process-A that leaves the rproc state to > RPROC_CRASHED state later a call to recovery_store from user space in > Process B triggers rproc_tr

Re: [PATCH] mailbox, remoteproc: k3-m4+: fix compile testing

2024-10-16 Thread Mathieu Poirier
On Wed, Oct 16, 2024 at 10:37:35AM -0500, Andrew Davis wrote: > On 10/16/24 10:26 AM, Mathieu Poirier wrote: > > On Mon, Oct 14, 2024 at 09:56:11AM -0500, Andrew Davis wrote: > > > On 10/7/24 8:23 AM, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > > > > > The k3-m4 remoteproc driver was

Re: [PATCH] remoteproc: qcom_q6v5_mss: Re-order writes to the IMEM region

2024-10-16 Thread Doug Anderson
Hi, On Mon, Aug 19, 2024 at 4:40 PM Doug Anderson wrote: > > Hi, > > On Mon, Aug 19, 2024 at 12:30 AM Sibi Sankar wrote: > > > > Any write access to the IMEM region when the Q6 is setting up XPU > > protection on it will result in a XPU violation. Fix this by ensuring > > IMEM writes related to

Re: [PATCH rcu] configs/debug: make sure PROVE_RCU_LIST=y takes effect

2024-10-16 Thread Paul E. McKenney
On Tue, Oct 15, 2024 at 06:11:44PM -0700, Jakub Kicinski wrote: > Commit 0aaa8977acbf ("configs: introduce debug.config for CI-like setup") > added CONFIG_PROVE_RCU_LIST=y to the common CI config, > but RCU_EXPERT is not set, and it's a dependency for > CONFIG_PROVE_RCU_LIST=y. Make sure CIs take a

Re: [peterz-queue:sched/lazy] [sched, x86] 74d850cd4c: WARNING:at_kernel/rcu/rcutorture.c:#rcu_torture_stats_print[rcutorture]

2024-10-16 Thread Sebastian Andrzej Siewior
On 2024-10-15 15:47:20 [+0800], kernel test robot wrote: > Hello, Hi, it took me a while to reproduce this because it does not trigger without the ltp userland and this is not downloaded properly so I had to workaround it. However… > [ 98.006999][ T543] busted-torture: rtc: 639e821e ve

Re: [PATCH] mailbox, remoteproc: k3-m4+: fix compile testing

2024-10-16 Thread Andrew Davis
On 10/16/24 10:26 AM, Mathieu Poirier wrote: On Mon, Oct 14, 2024 at 09:56:11AM -0500, Andrew Davis wrote: On 10/7/24 8:23 AM, Arnd Bergmann wrote: From: Arnd Bergmann The k3-m4 remoteproc driver was merged with incorrect dependencies. Despite multiple people trying to fix this, the version 6

Re: [PATCH v2] module: sign with sha512 instead of sha1 by default

2024-10-16 Thread Sami Tolvanen
Hi Thorsten, On Wed, Oct 16, 2024 at 7:18 AM Thorsten Leemhuis wrote: > > Switch away from using sha1 for module signing by default and use the > more modern sha512 instead, which is what among others Arch, Fedora, > RHEL, and Ubuntu are currently using for their kernels. > > Sha1 has not been co

Re: [PATCH rcu] configs/debug: make sure PROVE_RCU_LIST=y takes effect

2024-10-16 Thread Matthieu Baerts
On 16/10/2024 17:18, Matthieu Baerts wrote: > Hi Jakub, > > On 16/10/2024 03:11, Jakub Kicinski wrote: >> Commit 0aaa8977acbf ("configs: introduce debug.config for CI-like setup") >> added CONFIG_PROVE_RCU_LIST=y to the common CI config, >> but RCU_EXPERT is not set, and it's a dependency for >> C

Re: [PATCH] mailbox, remoteproc: k3-m4+: fix compile testing

2024-10-16 Thread Mathieu Poirier
On Mon, Oct 14, 2024 at 09:56:11AM -0500, Andrew Davis wrote: > On 10/7/24 8:23 AM, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The k3-m4 remoteproc driver was merged with incorrect dependencies. > > Despite multiple people trying to fix this, the version 6.12-rc2 > > remains broken and

Re: [PATCH rcu] configs/debug: make sure PROVE_RCU_LIST=y takes effect

2024-10-16 Thread Matthieu Baerts
Hi Jakub, On 16/10/2024 03:11, Jakub Kicinski wrote: > Commit 0aaa8977acbf ("configs: introduce debug.config for CI-like setup") > added CONFIG_PROVE_RCU_LIST=y to the common CI config, > but RCU_EXPERT is not set, and it's a dependency for > CONFIG_PROVE_RCU_LIST=y. Make sure CIs take advantage >

Re: [PATCH bpf v1 1/2] bpf: fix link info netfilter flags to populate defrag flag

2024-10-16 Thread Daniel Borkmann
On 10/15/24 5:25 PM, Florian Westphal wrote: Tyrone Wu wrote: This patch correctly populates the `bpf_link_info.netfilter.flags` field when user passes the `BPF_F_NETFILTER_IP_DEFRAG` flag. Indeed, thanks for fixing this. Patch and testcase look good, but one nit: Fixes: 84601d6ee68a ("bpf:

Re: [PATCH bpf v1 1/2] bpf: fix link info netfilter flags to populate defrag flag

2024-10-16 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf.git (master) by Daniel Borkmann : On Fri, 11 Oct 2024 19:32:51 + you wrote: > This patch correctly populates the `bpf_link_info.netfilter.flags` field > when user passes the `BPF_F_NETFILTER_IP_DEFRAG` flag. > > Fixes: 84601d6ee68a ("bpf: add bpf_lin

Re: [PATCH RESEND] vdpa: solidrun: Fix UB bug with devres

2024-10-16 Thread Greg KH
On Wed, Oct 16, 2024 at 01:16:32PM +0200, Philipp Stanner wrote: > On Wed, 2024-10-16 at 12:51 +0200, Greg KH wrote: > > On Wed, Oct 16, 2024 at 11:22:48AM +0200, Philipp Stanner wrote: > > > On Wed, 2024-10-16 at 12:08 +0300, Andy Shevchenko wrote: > > > > On Wed, Oct 16, 2024 at 09:25:54AM +0200,

Re: [PATCH v2] selftest: hid: add the missing tests directory

2024-10-16 Thread Shuah Khan
On 10/16/24 02:27, Benjamin Tissoires wrote: On Oct 15 2024, Yun Lu wrote: Commit 160c826b4dd0 ("selftest: hid: add missing run-hid-tools-tests.sh") has added the run-hid-tools-tests.sh script for it to be installed, but I forgot to add the tests directory together. If running the test case wit

Re: [syzbot] [bpf?] KCSAN: data-race in __mod_timer / kvfree_call_rcu

2024-10-16 Thread Uladzislau Rezki
I will have a look at this! On Mon, Oct 14, 2024 at 7:00 PM Paul E. McKenney wrote: > > On Mon, Oct 14, 2024 at 10:27:05AM +0200, Dmitry Vyukov wrote: > > On Mon, 14 Oct 2024 at 08:07, syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit:

Re: [PATCH net-next v9 04/23] ovpn: add basic interface creation/destruction/management routines

2024-10-16 Thread Antonio Quartulli
On 16/10/2024 10:27, Jiri Pirko wrote: Wed, Oct 16, 2024 at 03:03:04AM CEST, anto...@openvpn.net wrote: Add basic infrastructure for handling ovpn interfaces. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/main.c | 115 -- drivers/net/ovpn/ma

Re: [PATCH v3] selftests: tc-testing: Fix spelling errors in cgroup.json and flow.json

2024-10-16 Thread Simon Horman
On Tue, Oct 15, 2024 at 05:00:06PM +, Karan Sanghavi wrote: > This patch corrects typographical errors in the "name" fields of > the JSON objects with IDs "4319" and "4341" in the tc-testing > selftests. > > - "diffferent" is corrected to "different". > - "muliple" is corrected to "multiple".

[PATCH v2] module: sign with sha512 instead of sha1 by default

2024-10-16 Thread Thorsten Leemhuis
Switch away from using sha1 for module signing by default and use the more modern sha512 instead, which is what among others Arch, Fedora, RHEL, and Ubuntu are currently using for their kernels. Sha1 has not been considered secure against well-funded opponents since 2005[1]; since 2011 the NIST an

Re: [PATCH v4 10/19] gendwarfksyms: Limit structure expansion

2024-10-16 Thread Petr Pavlu
On 10/8/24 20:38, Sami Tolvanen wrote: > Expand each structure type only once per exported symbol. This > is necessary to support self-referential structures, which would > otherwise result in infinite recursion, but is still sufficient for > catching ABI changes. > > For pointers, limit structure

[PATCH] remoteproc: qcom_q6v5_pas: disable auto boot for wpss

2024-10-16 Thread Balaji Pothunoori
auto_boot flag ensures to take the firmware and boots it up during the wpss remoteproc start. wpss host driver would like to control the load and unload of the firmware during the load and unload of the driver. Hence, disable the "auto boot" for wpss. Signed-off-by: Balaji Pothunoori --- Cc: ath.

Re: [PATCH v2 1/3] pidfd: extend pidfd_get_pid() and de-duplicate pid lookup

2024-10-16 Thread Christian Brauner
On Fri, Oct 11, 2024 at 12:05:55PM +0100, Lorenzo Stoakes wrote: > The means by which a pid is determined from a pidfd is duplicated, with > some callers holding a reference to the (pid)fd, and others explicitly > pinning the pid. > > Introduce __pidfd_get_pid() which abstracts both approaches and

Re: [RFC PATCH 26/39] KVM: guest_memfd: Track faultability within a struct kvm_gmem_private

2024-10-16 Thread Jason Gunthorpe
On Wed, Oct 16, 2024 at 01:54:32PM +0200, David Hildenbrand wrote: > Likely should be doable. All we need is the generalized concept of a folio > with HVO, and a way to move these folios between owners (e.g., > global<->hugetlb, global<->guest_memfd). +1 HVO seems to become a sticking point in t

Re: [RFC PATCH 26/39] KVM: guest_memfd: Track faultability within a struct kvm_gmem_private

2024-10-16 Thread David Hildenbrand
On 16.10.24 12:48, Vishal Annapurve wrote: On Wed, Oct 16, 2024 at 2:20 PM David Hildenbrand wrote: I also don't know how you treat things like folio_test_hugetlb() on possible assumptions that the VMA must be a hugetlb vma. I'd confess I didn't yet check the rest of the patchset yet - readi

Re: [PATCH RESEND] vdpa: solidrun: Fix UB bug with devres

2024-10-16 Thread Philipp Stanner
On Wed, 2024-10-16 at 12:51 +0200, Greg KH wrote: > On Wed, Oct 16, 2024 at 11:22:48AM +0200, Philipp Stanner wrote: > > On Wed, 2024-10-16 at 12:08 +0300, Andy Shevchenko wrote: > > > On Wed, Oct 16, 2024 at 09:25:54AM +0200, Philipp Stanner wrote: > > > > In psnet_open_pf_bar() and snet_open_vf_b

Re: [PATCH RESEND] vdpa: solidrun: Fix UB bug with devres

2024-10-16 Thread Greg KH
On Wed, Oct 16, 2024 at 11:22:48AM +0200, Philipp Stanner wrote: > On Wed, 2024-10-16 at 12:08 +0300, Andy Shevchenko wrote: > > On Wed, Oct 16, 2024 at 09:25:54AM +0200, Philipp Stanner wrote: > > > In psnet_open_pf_bar() and snet_open_vf_bar() a string later passed > > > to > > > pcim_iomap_regio

Re: [RFC PATCH 26/39] KVM: guest_memfd: Track faultability within a struct kvm_gmem_private

2024-10-16 Thread Vishal Annapurve
On Wed, Oct 16, 2024 at 2:20 PM David Hildenbrand wrote: > > >> I also don't know how you treat things like folio_test_hugetlb() on > >> possible assumptions that the VMA must be a hugetlb vma. I'd confess I > >> didn't yet check the rest of the patchset yet - reading a large series > >> without

Re: [PATCH RESEND] vdpa: solidrun: Fix UB bug with devres

2024-10-16 Thread Andy Shevchenko
On Wed, Oct 16, 2024 at 12:22 PM Philipp Stanner wrote: > On Wed, 2024-10-16 at 12:08 +0300, Andy Shevchenko wrote: > > On Wed, Oct 16, 2024 at 09:25:54AM +0200, Philipp Stanner wrote: ... > > > --- > > > > I haven't found the reason for resending. Can you elaborate here? > > Impatience ;p > > T

[PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2024-10-16 Thread Lorenzo Stoakes
Add tests to assert that PIDFD_SELF_* correctly refers to the current thread and process. This is only practically meaningful to pidfd_send_signal() and pidfd_getfd(), but also explicitly test that we disallow this feature for setns() where it would make no sense. We cannot reasonably wait on our

[PATCH v3 2/3] pidfd: add PIDFD_SELF_* sentinels to refer to own thread/process

2024-10-16 Thread Lorenzo Stoakes
It is useful to be able to utilise pidfd mechanisms to reference the current thread or process (from a userland point of view - thread group leader from the kernel's point of view). Therefore introduce PIDFD_SELF_THREAD to refer to the current thread, and PIDFD_SELF_THREAD_GROUP to refer to the cu

  1   2   >