Re: [PATCH v3] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc

2024-09-25 Thread Krzysztof Kozlowski
On Wed, Sep 25, 2024 at 03:21:37PM +0800, Jingyi Wang wrote: > Document the components used to boot the ADSP, CDSP and GPDSP on the > Qualcomm QCS8300 SoC. Use fallback to indicate the compatibility of the > remoteproc on the QCS8300 with that on the SA8775P. > > Co-developed-by: Xin Liu > Signed

Re: [RFC PATCH 1/4] hazptr: Add initial implementation of hazard pointers

2024-09-25 Thread Mathieu Desnoyers
On 2024-09-25 15:20, Mathieu Desnoyers wrote: [...] static inline bool same_ptr(void *a, void *b) {     asm goto (     "cmpq %[a], %[b]\n\t"     "jne %l[ne]\n\t"     : : [a] "r" (a), [b] "r" (b)     : : ne);     return true; ne:     return false; } Based on the informatio

Re: vhost-vdpa: Refactor copy_to_user() usage in vhost_vdpa_get_config()

2024-09-25 Thread Markus Elfring
>> Assign the return value from a copy_to_user() call to an additional >> local variable so that a kvfree() call and return statement can be >> omitted accordingly. > > Ugly and unidiomatic. > >> This issue was detected by using the Coccinelle software. > > What issue? Opportunities for the reduct

Re: [PATCH v9 4/7] remoteproc: core: Add TEE interface support for firmware release

2024-09-25 Thread Bjorn Andersson
On Fri, Aug 30, 2024 at 11:51:44AM GMT, Arnaud Pouliquen wrote: > Add support for releasing remote processor firmware through > the Trusted Execution Environment (TEE) interface. > > The tee_rproc_release_fw() function is called in the following cases: > > - An error occurs in rproc_start() betwe

Re: [PATCH] remoteproc: qcom: Fix NULL pointer in glink_subdev_stop()

2024-09-25 Thread Bjorn Andersson
On Wed, Sep 25, 2024 at 04:03:51PM +0530, Mukesh Ojha wrote: > Multiple call to glink_subdev_stop() for the same remoteproc can happen > if rproc_stop() fails from Process-A that leaves the rproc state to > RPROC_CRASHED state later a call to recovery_store from user space in > Process B triggers r

[RFC PATCH v1 2/2] KVM: arm64: Allow the RAS feature bit in ID_AA64PFR0_EL1 writable from userspace

2024-09-25 Thread Shaoqin Huang
Currently FEAT_RAS is not writable, this makes migration fail between systems where this feature differ. Allow the FEAT_RAS writable in ID_AA64PFR0_EL1 to let the migration possible when the RAS is differ between two machines. Also update the kselftest to test the RAS field. Signed-off-by: Shaoqi

[RFC PATCH v1 0/2] Allow the RAS feature bit in ID_AA64PFR0_EL1 writable from userspace

2024-09-25 Thread Shaoqin Huang
Currently the RAS feature bit is not writable in ID_AA64PFR0EL1, this makes migration fail when migration from the machine which RAS is 1 to another machine which RAS is 2. Allow RAS writable from userspace would make the migration possible between two machines which RAS is different. Shaoqin Hua

[PATCH] hwspinlock: fix some comments about 'will never sleep'

2024-09-25 Thread Wen Yang
Both __hwspin_trylock and __hwspin_unlock use hwlock->lock, with a special annotation: function will never sleep. However, this requirement is not fulfilled on PREEMPT_RT. Bjorn said: : "will never sleep" comment expresses that the function can be called : in atomic or irq context, not necessarily

Re: [PATCH 0/4] Process some MMIO-related errors without KVM exit

2024-09-25 Thread Sean Christopherson
On Tue, Sep 24, 2024, Ivan Orlov wrote: > On Mon, Sep 23, 2024 at 02:46:17PM -0700, Sean Christopherson wrote: > > > > > > > No. This is not architectural behavior. It's not even remotely > > > > close to > > > > architectural behavior. KVM's behavior isn't great, but making up > > > > _guest v

Re: [PATCH v4 14/16] modules: Support extended MODVERSIONS info

2024-09-25 Thread Matthew Maurer
Thanks for the catch. I've sent up v5 to include that fix. I've also added a changelog and made sure the patches make it to linux-modules@ as Daniel suggested. On Wed, Sep 25, 2024 at 4:00 PM Sami Tolvanen wrote: > > Hi Matt, > > On Tue, Sep 24, 2024 at 09:19:56PM +, Matthew Maurer wrote: >

[PATCH v5 16/16] export_report: Use new version info format

2024-09-25 Thread Matthew Maurer
The new version info format has a superset of symbols in the old format. Since this is a tool for in-tree modules, we don't need to parse the old one with this tool any longer. Signed-off-by: Matthew Maurer --- scripts/export_report.pl | 22 ++ 1 file changed, 10 insertions(+

[PATCH v5 15/16] modpost: Produce extended modversion information

2024-09-25 Thread Matthew Maurer
Generate both the existing modversions format and the new extended one when running modpost. We no longer generate an error on long symbols in modpost, as they can now be appropriately encoded in the extended section. These symbols will be skipped in the previous encoding. Signed-off-by: Matthew

[PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-09-25 Thread Matthew Maurer
Adds a new format for MODVERSIONS which stores each field in a separate ELF section. This initially adds support for variable length names, but could later be used to add additional fields to MODVERSIONS in a backwards compatible way if needed. Any new fields will be ignored by old user tooling, un

[PATCH v5 13/16] export_report: Rehabilitate script

2024-09-25 Thread Matthew Maurer
* modules.order has .o files when in a build dir, support this * .mod.c source layout has changed, update regexes to match * Add a stage 3, to be more robust against additional .mod.c content Signed-off-by: Matthew Maurer --- scripts/export_report.pl | 9 +++-- 1 file changed, 7 insertions(+

[PATCH v5 12/16] module: Reformat struct for code style

2024-09-25 Thread Matthew Maurer
Using commas to declare struct members makes adding new members to this struct not as nice with patch management. Signed-off-by: Matthew Maurer --- kernel/module/internal.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/module/internal.h b/kernel/module/internal

[PATCH v5 11/16] module: Additional validation in elf_validity_cache_strtab

2024-09-25 Thread Matthew Maurer
Validate properties of the strtab that are depended on elsewhere, but were previously unchecked: * String table nonempty (offset 0 is valid) * String table has a leading NUL (offset 0 corresponds to "") * String table is NUL terminated (strfoo functions won't run out of the table while reading).

[PATCH v5 10/16] module: Factor out elf_validity_cache_strtab

2024-09-25 Thread Matthew Maurer
This patch only moves the existing strtab population to a function. Validation comes in a following patch, this is split out to make the new validation checks more clearly separated. Signed-off-by: Matthew Maurer --- kernel/module/main.c | 23 --- 1 file changed, 20 insertion

[PATCH v5 09/16] module: Group section index calculations together

2024-09-25 Thread Matthew Maurer
Group all the index detection together to make the parent function easier to read. Signed-off-by: Matthew Maurer --- kernel/module/main.c | 68 +--- 1 file changed, 51 insertions(+), 17 deletions(-) diff --git a/kernel/module/main.c b/kernel/module/main.c

[PATCH v5 08/16] module: Factor out elf_validity_cache_index_str

2024-09-25 Thread Matthew Maurer
Pull out index validation for the symbol string section. Note that this does not validate the *contents* of the string table, only shape and presence of the section. Signed-off-by: Matthew Maurer --- kernel/module/main.c | 37 - 1 file changed, 28 insertions(

[PATCH v5 07/16] module: Factor out elf_validity_cache_index_sym

2024-09-25 Thread Matthew Maurer
Centralize symbol table detection and property validation. Signed-off-by: Matthew Maurer --- kernel/module/main.c | 73 ++-- 1 file changed, 44 insertions(+), 29 deletions(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index ec638187ffcf..6be

[PATCH v5 06/16] module: Factor out elf_validity_cache_index_mod

2024-09-25 Thread Matthew Maurer
Centralize .gnu.linkonce.this_module detection and property validation. Signed-off-by: Matthew Maurer --- kernel/module/main.c | 129 ++- 1 file changed, 67 insertions(+), 62 deletions(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index 511d

[PATCH v5 05/16] module: Factor out elf_validity_cache_index_info

2024-09-25 Thread Matthew Maurer
Centralize .modinfo detection and property validation. Signed-off-by: Matthew Maurer --- kernel/module/main.c | 82 1 file changed, 68 insertions(+), 14 deletions(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index 6a9159afca02..511d645

[PATCH v5 04/16] module: Factor out elf_validity_cache_secstrings

2024-09-25 Thread Matthew Maurer
Factor out the validation of section names. There are two behavioral changes: 1. Previously, we did not validate non-SHF_ALLOC sections. This may have once been safe, as find_sec skips non-SHF_ALLOC sections, but find_any_sec, which will be used to load BTF if that is enabled, ignores th

[PATCH v5 03/16] module: Factor out elf_validity_cache_sechdrs

2024-09-25 Thread Matthew Maurer
Factor out and document the validation of section headers. Because we now validate all section offsets and lengths before accessing them, we can remove the ad-hoc checks. Signed-off-by: Matthew Maurer --- kernel/module/main.c | 125 --- 1 file changed, 82

[PATCH v5 02/16] module: Factor out elf_validity_ehdr

2024-09-25 Thread Matthew Maurer
Factor out verification of the ELF header and document what is checked. Signed-off-by: Matthew Maurer --- kernel/module/main.c | 70 +--- 1 file changed, 47 insertions(+), 23 deletions(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index 1a2d

[PATCH v5 01/16] module: Take const arg in validate_section_offset

2024-09-25 Thread Matthew Maurer
`validate_section_offset` doesn't modify the info passed in. Make this clear by adjusting the type signature. Signed-off-by: Matthew Maurer --- kernel/module/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index 49b9bca9de12.

[PATCH v5 00/16] Extended MODVERSIONS Support

2024-09-25 Thread Matthew Maurer
This patch series is intended for use alongside the Implement MODVERSIONS for RUST [1] series as a replacement for the symbol name hashing approach used there to enable RUST and MODVERSIONS at the same time. Elsewhere, we've seen a desire for long symbol name support for LTO symbol names [2], and

Re: [PATCH v4 14/16] modules: Support extended MODVERSIONS info

2024-09-25 Thread Sami Tolvanen
Hi Matt, On Tue, Sep 24, 2024 at 09:19:56PM +, Matthew Maurer wrote: > +static void dedotify_ext_version_names(char *str_seq, unsigned long size) > +{ > + unsigned long out = 0; > + unsigned long in; > + char last = '\0'; > + > + for (in = 0; in < size; in++) { > +

[PATCH v3 5/5] selftests: exec: update gitignore for load_address

2024-09-25 Thread Javier Carrasco
The name of the "load_address" objects has been modified, but the corresponding entry in the gitignore file must be updated. Update the load_address entry in the gitignore file to account for the new names, adding an exception to keep on tracking load_address.c. Signed-off-by: Javier Carrasco --

[PATCH v3 4/5] selftests: rds: add gitignore file for include.sh

2024-09-25 Thread Javier Carrasco
The generated include.sh should be ignored by git. Create a new gitignore and add the file to the list. Reviewed-by: Allison Henderson Signed-off-by: Javier Carrasco --- tools/testing/selftests/net/rds/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/net/rd

[PATCH v3 3/5] selftests: rds: add include.sh to EXTRA_CLEAN

2024-09-25 Thread Javier Carrasco
The include.sh file is generated when building the net/rds selftests, but there is no rule to delete it with the clean target. Add the file to EXTRA_CLEAN in order to remove it when required. Reviewed-by: Allison Henderson Signed-off-by: Javier Carrasco --- tools/testing/selftests/net/rds/Makef

[PATCH v3 2/5] selftests: net: add msg_oob to gitignore

2024-09-25 Thread Javier Carrasco
This executable is missing from the corresponding gitignore file. Add msg_oob to the net gitignore list. Signed-off-by: Javier Carrasco --- tools/testing/selftests/net/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/net/.gitignore b/tools/testing/selftests

[PATCH v3 1/5] selftests: core: add unshare_test to gitignore

2024-09-25 Thread Javier Carrasco
This executable is missing from the corresponding gitignore file. Add unshare_test to the core gitignore list. Signed-off-by: Javier Carrasco --- tools/testing/selftests/core/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/core/.gitignore b/tools/testing/s

[PATCH v3 0/5] selftests: gitignore and clean target file additions

2024-09-25 Thread Javier Carrasco
to v2: https://lore.kernel.org/r/20240925-selftests-gitignore-v2-0-def21...@gmail.com Changes in v2: - [PATCH 4/4] add excepction for load_address.c (must be tracked). - Link to v1: https://lore.kernel.org/r/20240924-selftests-gitignore-v1-0-9755ac883...@gmail.com --- Javier Carrasco (5

Re: [PATCH] vhost-vdpa: Refactor copy_to_user() usage in vhost_vdpa_get_config()

2024-09-25 Thread Al Viro
On Wed, Sep 25, 2024 at 08:48:16PM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 25 Sep 2024 20:36:35 +0200 > > Assign the return value from a copy_to_user() call to an additional > local variable so that a kvfree() call and return statement can be > omitted accordingly. Ugly

Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

2024-09-25 Thread Martin KaFai Lau
On 9/25/24 3:37 AM, Martin KaFai Lau wrote: I am not sure which case in xdp_features.c does not have existing coverage in test_progs. From a quick look, it seems only BPF_MAP_TYPE_CPUMAP is missing (please check)? Re: CPUMAP, I noticed there is a xdp_(cpu)map_attach.c test but it only does at

Re: [PATCH net v4 0/2] bpf: devmap: provide rxq after redirect

2024-09-25 Thread Martin KaFai Lau
On 9/19/24 11:12 AM, Paolo Abeni wrote: On 9/11/24 10:41, Florian Kauer wrote: rxq contains a pointer to the device from where the redirect happened. Currently, the BPF program that was executed after a redirect via BPF_MAP_TYPE_DEVMAP* does not have it set. Add bugfix and related selftest. Si

Re: [PATCH v2 00/19] iommufd: Add VIOMMU infrastructure (Part-1)

2024-09-25 Thread Nicolin Chen
On Wed, Sep 25, 2024 at 06:30:20PM +0800, Yi Liu wrote: > Hi Nic, > > On 2024/8/28 00:59, Nicolin Chen wrote: > > This series introduces a new VIOMMU infrastructure and related ioctls. > > > > IOMMUFD has been using the HWPT infrastructure for all cases, including a > > nested IO page table suppo

[PATCH] vhost-vdpa: Refactor copy_to_user() usage in vhost_vdpa_get_config()

2024-09-25 Thread Markus Elfring
From: Markus Elfring Date: Wed, 25 Sep 2024 20:36:35 +0200 Assign the return value from a copy_to_user() call to an additional local variable so that a kvfree() call and return statement can be omitted accordingly. This issue was detected by using the Coccinelle software. Signed-off-by: Markus

Re: [PATCH v2] selftests/damon/access_memory_even: remove unused variables

2024-09-25 Thread Shuah Khan
On 9/23/24 20:14, Ba Jing wrote: By reading the code, I found these variables are never referenced in the code. Just remove them. Signed-off-by: Ba Jing --- Notes: v1: https://lore.kernel.org/all/20240903034300.10443-1-baj...@cmss.chinamobile.com/ v2: Modify the commit subject and commit log.

Re: [PATCH 4/4] selftests: exec: update gitignore for load_address

2024-09-25 Thread Shuah Khan
On 9/25/24 10:25, Javier Carrasco wrote: On 25/09/2024 17:46, Shuah Khan wrote: On 9/24/24 06:49, Javier Carrasco wrote: The name of the "load_address" objects has been modified, but the corresponding entry in the gitignore file must be updated. Update the load_address entry in the gitignore f

Re: [PATCH] clone3: clone3_cap_checkpoint_restore: remove unused MAX_PID_NS_LEVEL macro

2024-09-25 Thread Shuah Khan
On 9/25/24 02:34, Christian Brauner wrote: On Tue, Sep 03, 2024 at 11:36:28AM GMT, Ba Jing wrote: The macro MAX_PID_NS_LEVEL is never referenced in the code, so remove it. Signed-off-by: Ba Jing --- Reviewed-by: Christian Brauner Quick note to say that I will apply the patch after the mer

Re: [PATCH 2/2] selftests: timers: Remove local NSEC_PER_SEC and USEC_PER_SEC defines

2024-09-25 Thread John Stultz
On Wed, Sep 25, 2024 at 8:20 AM Shuah Khan wrote: > > On 9/24/24 17:59, John Stultz wrote: > > On Tue, Sep 24, 2024 at 8:57 AM Shuah Khan > > wrote: > >> > >> Remove local NSEC_PER_SEC and USEC_PER_SEC defines. Pick them up from > >> include/vdso/time64.h. This requires -I $(top_srcdir) to the t

Re: [PATCH] selftests: Makefile: create OUTPUT dir

2024-09-25 Thread Shuah Khan
On 9/20/24 04:38, Jakub Kicinski wrote: On Thu, 19 Sep 2024 09:51:47 -0600 Shuah Khan wrote: @@ -261,6 +261,7 @@ ifdef INSTALL_PATH @ret=1; \ for TARGET in $(TARGETS) $(INSTALL_DEP_TARGETS); do \ BUILD_TARGET=$$BUILD/$$TARGET; \ + mkdir -p $$BUILD_T

Re: [PATCH 1/2] selftests:timers: posix_timers: Fix warn_unused_result in __fatal_error()

2024-09-25 Thread John Stultz
On Tue, Sep 24, 2024 at 8:57 AM Shuah Khan wrote: > > __fatal_error routine doesn't check strerror_r() return value, > which results in the following compile time warning: > > posix_timers.c: In function ‘__fatal_error’: > posix_timers.c:31:9: warning: ignoring return value of ‘strerror_r’ declare

Re: [PATCH v2 1/4] selftests: add unshare_test and msg_oob to gitignore

2024-09-25 Thread Shuah Khan
On 9/25/24 06:23, Javier Carrasco wrote: These executables are missing from their corresponding gitignore files. Add them to the lists. Signed-off-by: Javier Carrasco --- tools/testing/selftests/core/.gitignore | 1 + tools/testing/selftests/net/.gitignore | 1 + 2 files changed, 2 inserti

Re: [PATCH 4/4] selftests: exec: update gitignore for load_address

2024-09-25 Thread Javier Carrasco
On 25/09/2024 17:46, Shuah Khan wrote: > On 9/24/24 06:49, Javier Carrasco wrote: >> The name of the "load_address" objects has been modified, but the >> corresponding entry in the gitignore file must be updated. >> >> Update the load_address entry in the gitignore file to account for >> the new na

Re: [PATCH V2] rpmsg: glink: Add abort_tx check in intent wait

2024-09-25 Thread Bjorn Andersson
On Wed, Sep 25, 2024 at 12:53:28PM +0530, Deepak Kumar Singh wrote: > From: Sarannya S > > On remote susbsystem restart rproc will stop glink subdev which will "When stopping or restarting a remoteproc the glink subdev stop will invoke qcom_glink_native_remove(). Any ..." > trigger qcom_glink_n

Re: [PATCH 4/4] selftests: exec: update gitignore for load_address

2024-09-25 Thread Shuah Khan
On 9/24/24 06:49, Javier Carrasco wrote: The name of the "load_address" objects has been modified, but the corresponding entry in the gitignore file must be updated. Update the load_address entry in the gitignore file to account for the new names. Signed-off-by: Javier Carrasco --- tools/tes

Re: [PATCH] memfd: fuse_mnt: remove unused macro

2024-09-25 Thread Shuah Khan
On 9/2/24 22:44, Ba Jing wrote: The macro FUSE_USE_VERSION is never referenced in the code, just remove it. How did you find this problem and how did you test this change? This patch is incorrect - please see below. When you find unused defines, do check first if they are indeed unused checki

Re: [PATCH 2/2] selftests: timers: Remove local NSEC_PER_SEC and USEC_PER_SEC defines

2024-09-25 Thread Shuah Khan
On 9/24/24 17:59, John Stultz wrote: On Tue, Sep 24, 2024 at 8:57 AM Shuah Khan wrote: Remove local NSEC_PER_SEC and USEC_PER_SEC defines. Pick them up from include/vdso/time64.h. This requires -I $(top_srcdir) to the timers Makefile to include the include/vdso/time64.h. posix_timers test nam

Re: [PATCH 1/2] selftests:timers: posix_timers: Fix warn_unused_result in __fatal_error()

2024-09-25 Thread Shuah Khan
On 9/24/24 09:56, Shuah Khan wrote: __fatal_error routine doesn't check strerror_r() return value, which results in the following compile time warning: posix_timers.c: In function ‘__fatal_error’: posix_timers.c:31:9: warning: ignoring return value of ‘strerror_r’ declared with attribute ‘warn_

Re: [RFC PATCH 1/4] hazptr: Add initial implementation of hazard pointers

2024-09-25 Thread Mathieu Desnoyers
On 2024-09-25 15:10, Mathieu Desnoyers wrote: [...] Cleaner without goto in the user code: #include #include static inline bool same_ptr(void *a, void *b) { asm goto ( "cmpq %[a], %[b]\n\t" "jne %l[ne]\n\t" : : [a] "r" (a), [b] "r" (b) : : ne); return t

Re: [RFC PATCH 1/4] hazptr: Add initial implementation of hazard pointers

2024-09-25 Thread Mathieu Desnoyers
On 2024-09-25 14:47, Mathieu Desnoyers wrote: [...] Like so: #include #define __str_1(x)  #x #define __str(x)    __str_1(x) /* x86-64 */ #define bne_ptr(_a, _b, _label) \     asm goto ( \     "cmpq %[a], %[b]\n\t" \     "jne %l[" __str(_label) "]\n\t" \     : : [a] "r" (_a),

Re: [PATCH 0/2] livepatch: introduce 'stack_order' sysfs interface to klp_patch

2024-09-25 Thread Marcos Paulo de Souza
On Wed, 2024-09-25 at 14:40 +0800, Wardenjohn wrote: > As previous discussion, maintainers think that patch-level sysfs > interface is the > only acceptable way to maintain the information of the order that > klp_patch is > applied to the system. > > However, the previous patch introduce klp_ops

Re: [PATCH v2 7/7] kunit, slub: add test_kfree_rcu() and test_leak_destroy()

2024-09-25 Thread Hyeonggon Yoo
On Sun, Sep 22, 2024 at 11:13 PM Guenter Roeck wrote: > > On 9/21/24 23:16, Hyeonggon Yoo wrote: > > On Sun, Sep 22, 2024 at 6:25 AM Vlastimil Babka wrote: > >> > >> On 9/21/24 23:08, Guenter Roeck wrote: > >>> On 9/21/24 13:40, Vlastimil Babka wrote: > +CC kunit folks > > On 9/20/

Re: [RFC PATCH 1/4] hazptr: Add initial implementation of hazard pointers

2024-09-25 Thread Jonas Oberhauser
Am 9/25/2024 um 1:59 PM schrieb Mathieu Desnoyers: On 2024-09-25 12:45, Boqun Feng wrote: On Wed, Sep 25, 2024 at 12:11:52PM +0200, Jonas Oberhauser wrote: Am 9/25/2024 um 12:02 PM schrieb Boqun Feng: Hi Jonas, Of course, if we are really worried about compilers being too "smart" Ah, I

Re: [RFC PATCH 1/4] hazptr: Add initial implementation of hazard pointers

2024-09-25 Thread Mathieu Desnoyers
On 2024-09-25 14:16, Boqun Feng wrote: On Wed, Sep 25, 2024 at 01:59:06PM +0200, Mathieu Desnoyers wrote: On 2024-09-25 12:45, Boqun Feng wrote: On Wed, Sep 25, 2024 at 12:11:52PM +0200, Jonas Oberhauser wrote: Am 9/25/2024 um 12:02 PM schrieb Boqun Feng: Hi Jonas, Of course, if we are rea

[PATCH v2 4/4] selftests: exec: update gitignore for load_address

2024-09-25 Thread Javier Carrasco
The name of the "load_address" objects has been modified, but the corresponding entry in the gitignore file must be updated. Update the load_address entry in the gitignore file to account for the new names, adding an exception to keep on tracking load_address.c. Signed-off-by: Javier Carrasco --

[PATCH v2 2/4] selftests: rds: add include.sh to EXTRA_CLEAN

2024-09-25 Thread Javier Carrasco
The include.sh file is generated when building the net/rds selftests, but there is no rule to delete it with the clean target. Add the file to EXTRA_CLEAN in order to remove it when required. Reviewed-by: Allison Henderson Signed-off-by: Javier Carrasco --- tools/testing/selftests/net/rds/Makef

[PATCH v2 3/4] selftests: rds: add gitignore file for include.sh

2024-09-25 Thread Javier Carrasco
The generated include.sh should be ignored by git. Create a new gitignore and add the file to the list. Reviewed-by: Allison Henderson Signed-off-by: Javier Carrasco --- tools/testing/selftests/net/rds/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/net/rd

[PATCH v2 1/4] selftests: add unshare_test and msg_oob to gitignore

2024-09-25 Thread Javier Carrasco
These executables are missing from their corresponding gitignore files. Add them to the lists. Signed-off-by: Javier Carrasco --- tools/testing/selftests/core/.gitignore | 1 + tools/testing/selftests/net/.gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/testing/selftests/c

[PATCH v2 0/4] selftsets: gitignore and clean target file additions

2024-09-25 Thread Javier Carrasco
Trivial patches to update the gitignore files unders selftests, and a little addition to EXTRA_CLEAN under net/rds to account for the automatically generated include.sh. Signed-off-by: Javier Carrasco --- Changes in v2: - [PATCH 4/4] add excepction for load_address.c (must be tracked). - Link to

Re: [RFC PATCH 1/4] hazptr: Add initial implementation of hazard pointers

2024-09-25 Thread Boqun Feng
On Wed, Sep 25, 2024 at 01:59:06PM +0200, Mathieu Desnoyers wrote: > On 2024-09-25 12:45, Boqun Feng wrote: > > On Wed, Sep 25, 2024 at 12:11:52PM +0200, Jonas Oberhauser wrote: > > > > > > > > > Am 9/25/2024 um 12:02 PM schrieb Boqun Feng: > > > > Hi Jonas, > > > > > > > > Of > > > > course, if

[PATCH AUTOSEL 6.6 077/139] rcuscale: Provide clear error when async specified without primitives

2024-09-25 Thread Sasha Levin
From: "Paul E. McKenney" [ Upstream commit 11377947b5861fa59bf77c827e1dd7c081842cc9 ] Currently, if the rcuscale module's async module parameter is specified for RCU implementations that do not have async primitives such as RCU Tasks Rude (which now lacks a call_rcu_tasks_rude() function), there

[PATCH AUTOSEL 6.6 071/139] selftests/nolibc: avoid passing NULL to printf("%s")

2024-09-25 Thread Sasha Levin
From: Thomas Weißschuh [ Upstream commit f1a58f61d88642ae1e6e97e9d72d73bc70a93cb8 ] Clang on higher optimization levels detects that NULL is passed to printf("%s") and warns about it. While printf() from nolibc gracefully handles that NULL, it is undefined behavior as per POSIX, so the warning i

[PATCH AUTOSEL 6.10 096/197] rcu-tasks: Fix access non-existent percpu rtpcp variable in rcu_tasks_need_gpcb()

2024-09-25 Thread Sasha Levin
From: Zqiang [ Upstream commit fd70e9f1d85f5323096ad313ba73f5fe3d15ea41 ] For kernels built with CONFIG_FORCE_NR_CPUS=y, the nr_cpu_ids is defined as NR_CPUS instead of the number of possible cpus, this will cause the following system panic: smpboot: Allowing 4 CPUs, 0 hotplug CPUs ... setup_pe

[PATCH AUTOSEL 6.10 102/197] rcuscale: Provide clear error when async specified without primitives

2024-09-25 Thread Sasha Levin
From: "Paul E. McKenney" [ Upstream commit 11377947b5861fa59bf77c827e1dd7c081842cc9 ] Currently, if the rcuscale module's async module parameter is specified for RCU implementations that do not have async primitives such as RCU Tasks Rude (which now lacks a call_rcu_tasks_rude() function), there

Re: [RFC PATCH 1/1] hpref: Hazard Pointers with Reference Counter

2024-09-25 Thread Jonas Oberhauser
Am 9/25/2024 um 1:36 PM schrieb Mathieu Desnoyers: On 2024-09-25 12:06, Jonas Oberhauser wrote: Am 9/25/2024 um 8:35 AM schrieb Mathieu Desnoyers: On 2024-09-25 07:57, Jonas Oberhauser wrote: Hi Mathieu, I haven't read your code in detail but it seems to me you have an ABA bug: as I ex

[PATCH AUTOSEL 6.10 092/197] selftests/nolibc: avoid passing NULL to printf("%s")

2024-09-25 Thread Sasha Levin
From: Thomas Weißschuh [ Upstream commit f1a58f61d88642ae1e6e97e9d72d73bc70a93cb8 ] Clang on higher optimization levels detects that NULL is passed to printf("%s") and warns about it. While printf() from nolibc gracefully handles that NULL, it is undefined behavior as per POSIX, so the warning i

Re: [PATCH 4/4] selftests: exec: update gitignore for load_address

2024-09-25 Thread kernel test robot
: 4d0326b60bb753627437fff0f76bf1525bcda422 patch link: https://lore.kernel.org/r/20240924-selftests-gitignore-v1-4-9755ac883388%40gmail.com patch subject: [PATCH 4/4] selftests: exec: update gitignore for load_address config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20240925/202409251828

Re: [RFC PATCH 1/4] hazptr: Add initial implementation of hazard pointers

2024-09-25 Thread Mathieu Desnoyers
On 2024-09-25 12:45, Boqun Feng wrote: On Wed, Sep 25, 2024 at 12:11:52PM +0200, Jonas Oberhauser wrote: Am 9/25/2024 um 12:02 PM schrieb Boqun Feng: Hi Jonas, Of course, if we are really worried about compilers being too "smart" Ah, I see you know me better and better... we can always d

[PATCH AUTOSEL 6.11 147/244] selftests/bpf: fix uprobe.path leak in bpf_testmod

2024-09-25 Thread Sasha Levin
From: Jiri Olsa [ Upstream commit db61e6a4eee5a7884b2cafeaf407895f253bbaa7 ] testmod_unregister_uprobe() forgets to path_put(&uprobe.path). Signed-off-by: Jiri Olsa Signed-off-by: Oleg Nesterov Signed-off-by: Peter Zijlstra (Intel) Link: https://lore.kernel.org/r/20240801132724.ga8...@redhat

[PATCH AUTOSEL 6.11 119/244] rcuscale: Provide clear error when async specified without primitives

2024-09-25 Thread Sasha Levin
From: "Paul E. McKenney" [ Upstream commit 11377947b5861fa59bf77c827e1dd7c081842cc9 ] Currently, if the rcuscale module's async module parameter is specified for RCU implementations that do not have async primitives such as RCU Tasks Rude (which now lacks a call_rcu_tasks_rude() function), there

[PATCH AUTOSEL 6.11 112/244] rcu-tasks: Fix access non-existent percpu rtpcp variable in rcu_tasks_need_gpcb()

2024-09-25 Thread Sasha Levin
From: Zqiang [ Upstream commit fd70e9f1d85f5323096ad313ba73f5fe3d15ea41 ] For kernels built with CONFIG_FORCE_NR_CPUS=y, the nr_cpu_ids is defined as NR_CPUS instead of the number of possible cpus, this will cause the following system panic: smpboot: Allowing 4 CPUs, 0 hotplug CPUs ... setup_pe

[PATCH AUTOSEL 6.11 108/244] selftests/nolibc: avoid passing NULL to printf("%s")

2024-09-25 Thread Sasha Levin
From: Thomas Weißschuh [ Upstream commit f1a58f61d88642ae1e6e97e9d72d73bc70a93cb8 ] Clang on higher optimization levels detects that NULL is passed to printf("%s") and warns about it. While printf() from nolibc gracefully handles that NULL, it is undefined behavior as per POSIX, so the warning i

Re: [RFC PATCH 1/1] hpref: Hazard Pointers with Reference Counter

2024-09-25 Thread Mathieu Desnoyers
On 2024-09-25 12:06, Jonas Oberhauser wrote: Am 9/25/2024 um 8:35 AM schrieb Mathieu Desnoyers: On 2024-09-25 07:57, Jonas Oberhauser wrote: Hi Mathieu, I haven't read your code in detail but it seems to me you have an ABA bug: as I explained elsewhere, you could read the same pointer afte

RE: [PATCH 0/1] Add KUnit tests for lib/crc16.c

2024-09-25 Thread David Laight
From: Vinicius Peixoto > Sent: 23 September 2024 00:27 > > Hi all, > > This patch was developed during a hackathon organized by LKCAMP [1], > with the objective of writing KUnit tests, both to introduce people to > the kernel development process and to learn about different subsystems > (with the

Re: [GIT PULL] virtio: features, fixes, cleanups

2024-09-25 Thread Michael S. Tsirkin
On Wed, Sep 25, 2024 at 09:38:49AM +0200, Stefano Garzarella wrote: > On Tue, Sep 24, 2024 at 04:50:46PM GMT, Michael S. Tsirkin wrote: > > The following changes since commit 431c1646e1f86b949fa3685efc50b660a364c2b6: > > > > Linux 6.11-rc6 (2024-09-01 19:46:02 +1200) > > > > are available in the

[GIT PULL v2] virtio: features, fixes, cleanups

2024-09-25 Thread Michael S. Tsirkin
Changes from v1: add a missing ack, removing an empty commit that I used to record it. no code changes. The following changes since commit 431c1646e1f86b949fa3685efc50b660a364c2b6: Linux 6.11-rc6 (2024-09-01 19:46:02 +1200) are available in the Git repository at: https://gi

Re: [GIT PULL] virtio: features, fixes, cleanups

2024-09-25 Thread Michael S. Tsirkin
On Tue, Sep 24, 2024 at 04:50:46PM -0400, Michael S. Tsirkin wrote: > The following changes since commit 431c1646e1f86b949fa3685efc50b660a364c2b6: > > Linux 6.11-rc6 (2024-09-01 19:46:02 +1200) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/ms

Re: [RFC PATCH 1/4] hazptr: Add initial implementation of hazard pointers

2024-09-25 Thread Boqun Feng
On Wed, Sep 25, 2024 at 12:11:52PM +0200, Jonas Oberhauser wrote: > > > Am 9/25/2024 um 12:02 PM schrieb Boqun Feng: > > Hi Jonas, > > > > Of > > course, if we are really worried about compilers being too "smart" > > Ah, I see you know me better and better... > > > we can always do the compari

[PATCH] remoteproc: qcom: Fix NULL pointer in glink_subdev_stop()

2024-09-25 Thread Mukesh Ojha
Multiple call to glink_subdev_stop() for the same remoteproc can happen if rproc_stop() fails from Process-A that leaves the rproc state to RPROC_CRASHED state later a call to recovery_store from user space in Process B triggers rproc_trigger_recovery() of the same remoteproc to recover it results

Re: [PATCH v2 00/19] iommufd: Add VIOMMU infrastructure (Part-1)

2024-09-25 Thread Yi Liu
Hi Nic, On 2024/8/28 00:59, Nicolin Chen wrote: This series introduces a new VIOMMU infrastructure and related ioctls. IOMMUFD has been using the HWPT infrastructure for all cases, including a nested IO page table support. Yet, there're limitations for an HWPT-based structure to support some ad

Re: [RFC PATCH 1/4] hazptr: Add initial implementation of hazard pointers

2024-09-25 Thread Jonas Oberhauser
Am 9/25/2024 um 12:02 PM schrieb Boqun Feng: Hi Jonas, Of course, if we are really worried about compilers being too "smart" Ah, I see you know me better and better... we can always do the comparison in asm code, then compilers don't know anything of the equality between 'ptr' and 'head -

Re: [PATCH] selftests/bpf: Add missing va_end.

2024-09-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann : On Tue, 24 Sep 2024 12:55:34 +0800 you wrote: > From: zhang jiao > > There is no va_end after va_copy, just add it. > > Signed-off-by: zhang jiao > --- > tools/testing/selftests/bpf/test_progs.c | 1 + > 1 file c

Re: [RFC PATCH 1/1] hpref: Hazard Pointers with Reference Counter

2024-09-25 Thread Jonas Oberhauser
Am 9/25/2024 um 8:35 AM schrieb Mathieu Desnoyers: On 2024-09-25 07:57, Jonas Oberhauser wrote: Hi Mathieu, I haven't read your code in detail but it seems to me you have an ABA bug: as I explained elsewhere, you could read the same pointer after ABA but you don't synchronize with the new

Re: [RFC PATCH 1/4] hazptr: Add initial implementation of hazard pointers

2024-09-25 Thread Boqun Feng
Hi Jonas, On Fri, Sep 20, 2024 at 09:41:15AM +0200, Jonas Oberhauser wrote: > > > Am 9/17/2024 um 4:33 PM schrieb Boqun Feng: > > +static inline void *__hazptr_tryprotect(hazptr_t *hzp, > > + void *const *p, > > + unsigned long

Re: [PATCH v3] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc

2024-09-25 Thread Dmitry Baryshkov
sa8775p-adsp-pas > >> then: > >>properties: > >> power-domains: > >> @@ -79,9 +93,10 @@ allOf: > >>- if: > >>properties: > >> compatible: > >> - enum: > >> -- qcom,sa

Re: [PATCH v4 01/16] module: Take const arg in validate_section_offset

2024-09-25 Thread Daniel Gomez
On 9/24/2024 11:19 PM, Matthew Maurer wrote: `validate_section_offset` doesn't modify the info passed in. Make this clear by adjusting the type signature. Signed-off-by: Matthew Maurer --- kernel/module/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/module/

Re: [PATCH v3] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc

2024-09-25 Thread Jingyi Wang
sp0-pas >> -- qcom,sa8775p-cdsp1-pas >> + contains: >> +enum: >> + - qcom,sa8775p-cdsp0-pas >> + - qcom,sa8775p-cdsp1-pas >> then: >>properties: >> power-domains: >&g

Re: [PATCH] clone3: clone3_cap_checkpoint_restore: remove unused MAX_PID_NS_LEVEL macro

2024-09-25 Thread Christian Brauner
On Tue, Sep 03, 2024 at 11:36:28AM GMT, Ba Jing wrote: > The macro MAX_PID_NS_LEVEL is never referenced in the code, so remove it. > > Signed-off-by: Ba Jing > --- Reviewed-by: Christian Brauner

Re: [GIT PULL] remoteproc updates for v6.12

2024-09-25 Thread Martyn Welch
On Tue, 2024-09-24 at 12:31 -0700, Linus Torvalds wrote: > On Mon, 23 Sept 2024 at 21:44, Bjorn Andersson > wrote: > > > > remoteproc updates for v6.12 > > Grr. I didn't immediately notice this new Kconfig warning, so now > it's > in my tree: > >   WARNING: unmet direct dependencies detected fo

Re: [PATCH bpf-next v3 1/2] bpf: verifier: Support eliding map lookup nullness

2024-09-25 Thread Alexei Starovoitov
On Tue, Sep 24, 2024 at 12:40 PM Daniel Xu wrote: > > + > +/* Returns constant key value if possible, else -1 */ > +static long get_constant_map_key(struct bpf_verifier_env *env, > +struct bpf_reg_state *key) > +{ > + struct bpf_func_state *state = func(env, k

Re: [PATCH v3] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc

2024-09-25 Thread Dmitry Baryshkov
power-domains: > @@ -98,9 +113,10 @@ allOf: >- if: >properties: > compatible: > - enum: > -- qcom,sa8775p-gpdsp0-pas > -- qcom,sa8775p-gpdsp1-pas > + contains: > +enum: > + - qcom,sa8

Re: [GIT PULL] virtio: features, fixes, cleanups

2024-09-25 Thread Stefano Garzarella
On Tue, Sep 24, 2024 at 04:50:46PM GMT, Michael S. Tsirkin wrote: The following changes since commit 431c1646e1f86b949fa3685efc50b660a364c2b6: Linux 6.11-rc6 (2024-09-01 19:46:02 +1200) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags

Re: [PATCH] virtio_pmem: Add freeze/restore callbacks

2024-09-25 Thread Pankaj Gupta
+CC MST > > Philip Chen wrote: > > > Hi maintainers, > > > > > > Can anyone let me know if this patch makes sense? > > > Any comment/feedback is appreciated. > > > Thanks in advance! > > > > I'm not an expert on virtio but the code looks ok on the surface. I've > > discussed this with Dan a bit a

[PATCH V2] rpmsg: glink: Add abort_tx check in intent wait

2024-09-25 Thread Deepak Kumar Singh
From: Sarannya S On remote susbsystem restart rproc will stop glink subdev which will trigger qcom_glink_native_remove, any ongoing intent wait should be aborted from there otherwise this wait delays glink send which potentially delays glink channel removal as well. This further introduces delay

[PATCH v3] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc

2024-09-25 Thread Jingyi Wang
gpdsp0-pas -- qcom,sa8775p-gpdsp1-pas + contains: +enum: + - qcom,sa8775p-gpdsp0-pas + - qcom,sa8775p-gpdsp1-pas then: properties: power-domains: --- base-commit: 4d0326b60bb753627437fff0f76bf1525bcda422 change-id