Re: [RFC 7/7] vhost: Add new UAPI to support changing Kthread mode

2024-08-25 Thread Christoph Hellwig
On Mon, Aug 26, 2024 at 02:21:52PM +0800, Jason Wang wrote: > > What is the application visible behavior that the API use is the proxy > > for? > > Vhost used to be created by kthreadd but some recent patches change it > to behave like being froked by the owner. So the various attributes > that in

Re: [RFC 7/7] vhost: Add new UAPI to support changing Kthread mode

2024-08-25 Thread Jason Wang
On Wed, Aug 21, 2024 at 1:07 PM Christoph Hellwig wrote: > > On Mon, Aug 19, 2024 at 05:27:33PM +0800, Cindy Lu wrote: > > Add a new UAPI to support setting the vhost device to > > use kthread mode. The user space application needs to use > > VHOST_SET_USE_KTHREAD to set the mode. I think we need

Re: [PATCH v3 1/2] Introduce klp_ops into klp_func structure

2024-08-25 Thread zhang warden
> On Aug 26, 2024, at 04:17, Jiri Kosina wrote: > > I believe that Christoph's "Why?" in fact meant "please include the > rationale for the changes being made (such as the above) in the patch > changelog" :) > > Thanks, > > -- > Jiri Kosina > SUSE Labs > Hi Kosina. OK, the relation on

Re: [PATCH] tracing: Mitigate possible softlockup in __tracing_open()

2024-08-25 Thread Zheng Yejian
On 2024/8/25 23:05, Masami Hiramatsu (Google) wrote: On Sat, 24 Aug 2024 11:03:43 +0800 Zheng Yejian wrote: In __tracing_open(), when max latency tracers took place on the cpu, the time start of its buffer would be updated, then event entries with timestamps being earlier than start of the buf

Re: [RFC] Why is set_config not supported in mlx5_vnet?

2024-08-25 Thread Andrew Lunn
On Fri, Aug 23, 2024 at 11:54:13AM -0500, Carlos Bilbao wrote: > Hello, > > I'm debugging my vDPA setup, and when using ioctl to retrieve the > configuration, I noticed that it's running in half duplex mode: > > Configuration data (24 bytes): >   MAC address: (Mac address) >   Status: 0x0001 >  

Re: [PATCH v3 1/2] Introduce klp_ops into klp_func structure

2024-08-25 Thread Jiri Kosina
On Sun, 25 Aug 2024, zhang warden wrote: > >> 1. Move klp_ops into klp_func structure. > >> Rewrite the logic of klp_find_ops and > >> other logic to get klp_ops of a function. > >> > >> 2. Move definition of struct klp_ops into > >> include/linux/livepatch.h > > > > Why? > > > > Hi, Christoph

Re: [PATCH] tracing: Mitigate possible softlockup in __tracing_open()

2024-08-25 Thread Google
On Sat, 24 Aug 2024 11:03:43 +0800 Zheng Yejian wrote: > In __tracing_open(), when max latency tracers took place on the cpu, > the time start of its buffer would be updated, then event entries with > timestamps being earlier than start of the buffer would be skipped > (see tracing_iter_reset()).

Re: [PATCH v3 1/2] Introduce klp_ops into klp_func structure

2024-08-25 Thread zhang warden
> On Aug 25, 2024, at 12:48, Christoph Hellwig wrote: > > On Thu, Aug 22, 2024 at 11:01:58AM +0800, Wardenjohn wrote: >> 1. Move klp_ops into klp_func structure. >> Rewrite the logic of klp_find_ops and >> other logic to get klp_ops of a function. >> >> 2. Move definition of struct klp_ops in

Re: [RFC 7/7] vhost: Add new UAPI to support changing Kthread mode

2024-08-25 Thread Cindy Lu
On Wed, 21 Aug 2024 at 13:07, Christoph Hellwig wrote: > > On Mon, Aug 19, 2024 at 05:27:33PM +0800, Cindy Lu wrote: > > Add a new UAPI to support setting the vhost device to > > use kthread mode. The user space application needs to use > > VHOST_SET_USE_KTHREAD to set the mode. This setting must

[PATCH v4] x86/cpu: Adjust the error message when BIOS does not support SGX

2024-08-25 Thread WangYuli
When SGX is not supported by the BIOS, the kernel log still output the error 'SGX disabled by BIOS', which can be confusing since there might not be an SGX-related option in the BIOS settings. As a kernel, it's difficult to distinguish between the BIOS not supporting SGX and the BIOS supporting SG

Re: [PATCH v3] x86/cpu: Adjust the error message when BIOS does not support SGX

2024-08-25 Thread WangYuli
On 2024/8/25 16:49, Huang, Kai wrote: Hi Yuli, When Thomas pointed out the "Signed-off-by chain is invalid" in v2: https://lore.kernel.org/all/87zfpx4a0q.ffs@tglx/T/#mdc19b00c10177f3add9deaf505211bf8b3ec7110 I think it meant you either need to have a Co-developed-by for Zelong Xiang, or you

Re: [PATCH v2] uprobes: make trace_uprobe->nhit counter a per-CPU one

2024-08-25 Thread Google
On Tue, 13 Aug 2024 17:41:04 +0200 Oleg Nesterov wrote: > On 08/13, Masami Hiramatsu wrote: > > > > > @@ -62,7 +63,7 @@ struct trace_uprobe { > > > struct uprobe *uprobe; > > > > BTW, what is this change? I couldn't cleanly apply this to the v6.11-rc3. > > Which tree would you

Re: [PATCH v3] x86/cpu: Adjust the error message when BIOS does not support SGX

2024-08-25 Thread Huang, Kai
On Sun, 2024-08-25 at 16:17 +0800, WangYuli wrote: > When SGX is not supported by the BIOS, the kernel log still output > the error 'SGX disabled by BIOS', which can be confusing since > there might not be an SGX-related option in the BIOS settings. > > As a kernel, it's difficult to distinguish b

[PATCH v3] x86/cpu: Adjust the error message when BIOS does not support SGX

2024-08-25 Thread WangYuli
When SGX is not supported by the BIOS, the kernel log still output the error 'SGX disabled by BIOS', which can be confusing since there might not be an SGX-related option in the BIOS settings. As a kernel, it's difficult to distinguish between the BIOS not supporting SGX and the BIOS supporting SG

[PATCH] x86/sgx: Fix a W=1 build warning in function comment

2024-08-25 Thread Kai Huang
Building the SGX code with W=1 generates below warning: arch/x86/kernel/cpu/sgx/main.c:741: warning: Function parameter or struct member 'low' not described in 'sgx_calc_section_metric' arch/x86/kernel/cpu/sgx/main.c:741: warning: Function parameter or struct member 'high' not described in '

Re: [PATCH v2] rust: add `module_params` macro

2024-08-25 Thread Benno Lossin
On 24.08.24 23:23, Trevor Gross wrote: > On Sat, Aug 24, 2024 at 8:16 AM Benno Lossin wrote: >>> We shouldn't enable `const_mut_refs`. It is indeed close to >>> stabilization, but it is still kind of churny right now and we don't >>> want to enable the sharp edges everywhere. >>> >>> If the change