Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-16 Thread Jason Wang
On Wed, Jul 17, 2024 at 2:00 PM Michael S. Tsirkin wrote: > > On Wed, Jul 17, 2024 at 09:19:02AM +0800, Jason Wang wrote: > > On Wed, Jul 10, 2024 at 11:03 AM Jason Wang wrote: > > > > > > On Tue, Jul 9, 2024 at 9:28 PM Michael S. Tsirkin wrote: > > > > > > > > On Tue, Jul 09, 2024 at 04:02:14PM

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-16 Thread Michael S. Tsirkin
On Wed, Jul 17, 2024 at 09:19:02AM +0800, Jason Wang wrote: > On Wed, Jul 10, 2024 at 11:03 AM Jason Wang wrote: > > > > On Tue, Jul 9, 2024 at 9:28 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jul 09, 2024 at 04:02:14PM +0800, Jason Wang wrote: > > > > This patch synchronize operstate with a

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-16 Thread Jason Wang
On Wed, Jul 10, 2024 at 11:03 AM Jason Wang wrote: > > On Tue, Jul 9, 2024 at 9:28 PM Michael S. Tsirkin wrote: > > > > On Tue, Jul 09, 2024 at 04:02:14PM +0800, Jason Wang wrote: > > > This patch synchronize operstate with admin state per RFC2863. > > > > > > This is done by trying to toggle the

Re: [lvc-project] [PATCH] tracing: remove unreachable trace_array_put

2024-07-16 Thread Steven Rostedt
On Tue, 16 Jul 2024 22:19:05 +0300 Nikita Kiryushin wrote: > On 7/16/24 12:45, Alexey Khoroshilov wrote: > > Yes, but there is another possible modification: replacement of call to > > nonseekable_open() by a call to some other function that returns error. > > Current code is already ready for su

Re: [lvc-project] [PATCH] tracing: remove unreachable trace_array_put

2024-07-16 Thread Nikita Kiryushin
On 7/16/24 12:45, Alexey Khoroshilov wrote: Yes, but there is another possible modification: replacement of call to nonseekable_open() by a call to some other function that returns error. Current code is already ready for such modification. The change of which function is called would change

[PATCH v4 2/2] soc: qcom: smp2p: Introduce tracepoint support

2024-07-16 Thread Sudeepgoud Patil
Introduce tracepoint support for smp2p to enable communication logging between local and remote processors. Include tracepoints with information about the remote subsystem name, negotiation details, supported features, bit change notifications, and ssr activity. These logs are useful for debugging

[PATCH v4 0/2] Use of devname for interrupt descriptions and tracepoint support for smp2p

2024-07-16 Thread Sudeepgoud Patil
This commit enhances the smp2p driver by adding support for using the device name in interrupt descriptions and introducing tracepoint functionality. These improvements facilitate more effective debugging of smp2p-related issues. The devname patch, along with the callback to print the irq chip nam

[PATCH v4 1/2] soc: qcom: smp2p: Use devname for interrupt descriptions

2024-07-16 Thread Sudeepgoud Patil
From: Chris Lew When using /proc/interrupts to collect statistics on smp2p interrupt counts, it is hard to distinguish the different instances of smp2p from each other. For example to debug a processor boot issue, the ready and handover interrupts are checked for sanity to ensure the firmware rea

Re: [PATCH 1/6] remoteproc: imx_rproc: correct ddr alias for i.MX8M

2024-07-16 Thread Mathieu Poirier
On Tue, Jul 16, 2024 at 06:49:39PM +0300, Iuliana Prodan wrote: > Hi Mathieu, > > On 7/16/2024 6:16 PM, Mathieu Poirier wrote: > > Good morning, > > > > On Fri, Jul 12, 2024 at 04:34:54PM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > > > The DDR Alias address should be 0x4000 acc

Re: [PATCH 6/6] remoteproc: imx_rproc: handle system off for i.MX7ULP

2024-07-16 Thread Mathieu Poirier
On Fri, Jul 12, 2024 at 04:34:59PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > The i.MX7ULP Cortex-A7 is under control of Cortex-M4. The i.MX7ULP Linux > poweroff and restart rely on rpmsg driver to send a message to Cortex-M4 > firmware. Then Cortex-A7 could poweroff or restart by Cortex-M

Re: [PATCH 5/6] remoteproc: imx_rproc: allow tx_block to be set

2024-07-16 Thread Mathieu Poirier
On Fri, Jul 12, 2024 at 04:34:58PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Current tx_block is set to true, but there is case that no need to wait > response. Linux just needs to send data to remote processor, so let's > allow tx_block could be set to false. Ok, maybe - but this patch

Re: [PATCH 4/6] remoteproc: imx_rproc: merge TCML/U

2024-07-16 Thread Mathieu Poirier
On Fri, Jul 12, 2024 at 04:34:57PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Merge contiguous TCML/U regions into one to avoid load elf files which > has large sections failure. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 18 ++ > 1 file changed

Re: [PATCH 3/6] remoteproc: imx_rproc: initialize workqueue earlier

2024-07-16 Thread Mathieu Poirier
On Fri, Jul 12, 2024 at 04:34:56PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Initialize workqueue before requesting mailbox channel, otherwise if > mailbox interrupt comes before workqueue ready, the imx_rproc_rx_callback > will trigger issue. > > Reviewed-by: Richard Zhu All reviews s

Re: [PATCH 1/6] remoteproc: imx_rproc: correct ddr alias for i.MX8M

2024-07-16 Thread Mathieu Poirier
Good morning, On Fri, Jul 12, 2024 at 04:34:54PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > The DDR Alias address should be 0x4000 according to RM, so correct > it. > > Fixes: 4ab8f9607aad ("remoteproc: imx_rproc: support i.MX8MQ/M") This commit was merged more than 3 years ago...

Re: [RFC PATCH v4] ptp: Add vDSO-style vmclock support

2024-07-16 Thread Peter Hilber
On 16.07.24 14:32, David Woodhouse wrote: > On 16 July 2024 12:54:52 BST, Peter Hilber > wrote: >> On 11.07.24 09:50, David Woodhouse wrote: >>> On Thu, 2024-07-11 at 09:25 +0200, Peter Hilber wrote: IMHO this phrasing is better, since it directly refers to the state of the structu

Re: [PATCH 03/17] MIPS: loongson64: rename __node_data to node_data

2024-07-16 Thread Jiaxun Yang
在2024年7月16日七月 下午7:13,Mike Rapoport写道: > From: "Mike Rapoport (Microsoft)" > > Make definition of node_data match other architectures. > This will allow pulling declaration of node_data to the generic mm code in > the following commit. > > Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by:

[PATCH] LoongArch: KVM: Implement function kvm_arch_para_features

2024-07-16 Thread Bibo Mao
Function kvm_arch_para_features() is to detect supported para features, it can be used by device driver to detect and enable para features, such as extioi irqchip driver to detect KVM_FEATURE_VIRT_EXTIOI. Signed-off-by: Bibo Mao --- arch/loongarch/include/asm/kvm_para.h | 10 ++ arch/loo

Re: [RFC PATCH v4] ptp: Add vDSO-style vmclock support

2024-07-16 Thread David Woodhouse
On 16 July 2024 12:54:52 BST, Peter Hilber wrote: >On 11.07.24 09:50, David Woodhouse wrote: >> On Thu, 2024-07-11 at 09:25 +0200, Peter Hilber wrote: >>> >>> IMHO this phrasing is better, since it directly refers to the state of the >>> structure. >> >> Thanks. I'll update it. >> >>> AFAIU if t

Re: [RFC PATCH v4] ptp: Add vDSO-style vmclock support

2024-07-16 Thread Peter Hilber
On 08.07.24 11:27, David Woodhouse wrote: > + > + /* > + * Time according to time_type field above. > + */ > + uint64_t time_sec; /* Seconds since time_type epoch */ > + uint64_t time_frac_sec; /* (seconds >> 64) */ > + uint64_t time_esterror_picosec;

Re: [RFC PATCH v4] ptp: Add vDSO-style vmclock support

2024-07-16 Thread Peter Hilber
On 11.07.24 09:50, David Woodhouse wrote: > On Thu, 2024-07-11 at 09:25 +0200, Peter Hilber wrote: >> >> IMHO this phrasing is better, since it directly refers to the state of the >> structure. > > Thanks. I'll update it. > >> AFAIU if there would be abnormal delays in store buffers, causing some

Re: [BUG REPORT] kernel BUG at lib/dynamic_queue_limits.c:99!

2024-07-16 Thread xiujianfeng
Hi, On 2024/7/13 8:44, Jakub Kicinski wrote: > On Fri, 12 Jul 2024 17:43:21 -0700 Jakub Kicinski wrote: >> CC: virtio_net maintainers and Jiri who added BQL > > Oh, sounds like the fix may be already posted: > https://lore.kernel.org/all/20240712080329.197605-2-jean-phili...@linaro.org/ Thanks,

[PATCH 17/17] mm: make range-to-target_node lookup facility a part of numa_memblks

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" The x86 implementation of range-to-target_node lookup (i.e. phys_to_target_node() and memory_add_physaddr_to_nid()) relies on numa_memblks. Since numa_memblks are now part of the generic code, move these functions from x86 to mm/numa_memblks.c and select CONFIG_

[PATCH 16/17] arch_numa: switch over to numa_memblks

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" Until now arch_numa was directly translating firmware NUMA information to memblock. Using numa_memblks as an intermediate step has a few advantages: * alignment with more battle tested x86 implementation * availability of NUMA emulation * maintaining node inform

[PATCH 15/17] mm: make numa_memblks more self-contained

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" Introduce numa_memblks_init() and move some code around to avoid several global variables in numa_memblks. Signed-off-by: Mike Rapoport (Microsoft) --- arch/x86/mm/numa.c | 53 - include/linux/numa_memblks.h | 9 + mm/num

[PATCH 14/17] mm: introduce numa_emulation

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" Move numa_emulation codfrom arch/x86 to mm/numa_emulation.c This code will be later reused by arch_numa. No functional changes. Signed-off-by: Mike Rapoport (Microsoft) --- arch/x86/Kconfig | 8 arch/x86/include/asm/numa.h | 12 ---

[PATCH 13/17] mm: move numa_distance and related code from x86 to numa_memblks

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" Move code dealing with numa_distance array from arch/x86 to mm/numa_memblks.c This code will be later reused by arch_numa. No functional changes. Signed-off-by: Mike Rapoport (Microsoft) --- arch/x86/mm/numa.c | 101

[PATCH 12/17] mm: introduce numa_memblks

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" Move code dealing with numa_memblks from arch/x86 to mm/ and add Kconfig options to let x86 select it in its Kconfig. This code will be later reused by arch_numa. No functional changes. Signed-off-by: Mike Rapoport (Microsoft) --- arch/x86/Kconfig

[PATCH 11/17] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" CPU id cannot be negative. Making it unsigned also aligns with declarations in include/asm-generic/numa.h used by arm64 and riscv and allows sharing numa emulation code with these architectures. Signed-off-by: Mike Rapoport (Microsoft) --- arch/x86/include/as

[PATCH 10/17] x86/numa_emu: use a helper function to get MAX_DMA32_PFN

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" This is required to make numa emulation code architecture independent s that it can be moved to generic code in following commits. Signed-off-by: Mike Rapoport (Microsoft) --- arch/x86/include/asm/numa.h | 1 + arch/x86/mm/numa.c | 5 + arch/x86

[PATCH 09/17] x86/numa_emu: split __apicid_to_node update to a helper function

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" This is required to make numa emulation code architecture independent so that it can be moved to generic code in following commits. Signed-off-by: Mike Rapoport (Microsoft) --- arch/x86/include/asm/numa.h | 2 ++ arch/x86/mm/numa.c | 22 +++

[PATCH 08/17] x86/numa_emu: simplify allocation of phys_dist

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" By the time numa_emulation() is called, all physical memory is already mapped in the direct map and there is no need to define limits for memblock allocation. Replace memblock_phys_alloc_range() with memblock_alloc(). Signed-off-by: Mike Rapoport (Microsoft) -

[PATCH 07/17] x86/numa: move FAKE_NODE_* defines to numa_emu

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" The definitions of FAKE_NODE_MIN_SIZE and FAKE_NODE_MIN_HASH_MASK are only used by numa emulation code, make them local to arch/x86/mm/numa_emulation.c Signed-off-by: Mike Rapoport (Microsoft) --- arch/x86/include/asm/numa.h | 2 -- arch/x86/mm/numa_emulation

[PATCH 06/17] x86/numa: simplify numa_distance allocation

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" Allocation of numa_distance uses memblock_phys_alloc_range() to limit allocation to be below the last mapped page. But NUMA initializaition runs after the direct map is populated and there is also code in setup_arch() that adjusts memblock limit to reflect how m

[PATCH 05/17] arch, mm: pull out allocation of NODE_DATA to generic code

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" Architectures that support NUMA duplicate the code that allocates NODE_DATA on the node-local memory with slight variations in reporting of the addresses where the memory was allocated. Use x86 version as the basis for the generic alloc_node_data() function and

[PATCH 04/17] arch, mm: move definition of node_data to generic code

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" Every architecture that supports NUMA defines node_data in the same way: struct pglist_data *node_data[MAX_NUMNODES]; No reason to keep multiple copies of this definition and its forward declarations, especially when such forward declaration is the only

[PATCH 03/17] MIPS: loongson64: rename __node_data to node_data

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" Make definition of node_data match other architectures. This will allow pulling declaration of node_data to the generic mm code in the following commit. Signed-off-by: Mike Rapoport (Microsoft) --- arch/mips/include/asm/mach-loongson64/mmzone.h | 4 ++-- arch/

[PATCH 02/17] MIPS: sgi-ip27: make NODE_DATA() the same as on all other architectures

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" sgi-ip27 is the only system that defines NODE_DATA() differently than the rest of NUMA machines. Add node_data array of struct pglist pointers that will point to __node_data[node]->pglist and redefine NODE_DATA() to use node_data array. This will allow pulling

[PATCH 01/17] mm: move kernel/numa.c to mm/

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" The stub functions in kernel/numa.c belong to mm/ rather than to kernel/ Signed-off-by: Mike Rapoport (Microsoft) --- kernel/Makefile | 1 - mm/Makefile | 1 + {kernel => mm}/numa.c | 0 3 files changed, 1 insertion(+), 1 deletion(-) rename {k

[PATCH 00/17] mm: introduce numa_memblks

2024-07-16 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" Hi, Following the discussion about handling of CXL fixed memory windows on arm64 [1] I decided to bite the bullet and move numa_memblks from x86 to the generic code so they will be available on arm64/riscv and maybe on loongarch sometime later. While it could b

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-16 Thread Halil Pasic
On Wed, 10 Jul 2024 07:42:46 -0400 "Michael S. Tsirkin" wrote: > --- a/drivers/s390/virtio/virtio_ccw.c > +++ b/drivers/s390/virtio/virtio_ccw.c > @@ -694,7 +694,7 @@ static int virtio_ccw_find_vqs(struct virtio_device > *vdev, unsigned nvqs, > { > struct virtio_ccw_device *vcdev = to_vc_

Re: [lvc-project] [PATCH] tracing: remove unreachable trace_array_put

2024-07-16 Thread Alexey Khoroshilov
On 15.07.2024 16:47, Nikita Kiryushin wrote: > As nonseekable_open() documentation states: > "The function is not supposed to ever fail, the only > reason it returns an 'int' and not 'void' is so that it can be plugged > directly into file_operations structure." > > So it seems, that it will not f

Re: [PATCH 1/1] tracing/sched: sched_switch: place prev_comm and next_comm in right order

2024-07-16 Thread Peter Zijlstra
On Mon, Jul 15, 2024 at 03:04:12PM -0400, Steven Rostedt wrote: > > [ Adding sched maintainers, as this is a scheduling trace event ] > > On Wed, 3 Jul 2024 11:33:53 +0800 > Tio Zhang wrote: > > > Switch the order of prev_comm and next_comm in sched_switch's code to > > align with its printing

Re: [PATCH] MAINTAINERS: Add uprobes entry

2024-07-16 Thread Google
On Mon, 15 Jul 2024 19:21:52 +0200 Oleg Nesterov wrote: > On 07/15, Masami Hiramatsu wrote: > > > > Hi Peter, Oleg, > > > > If this is OK for you, please give your Ack. > > Acked-by: Oleg Nesterov > Thanks for the Ack! -- Masami Hiramatsu (Google)

Re: [PATCH] tracing: Update MAINTAINERS file

2024-07-16 Thread Google
On Mon, 15 Jul 2024 14:47:45 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > Gone but never forgotten. > > [ Also moved Daniel's name to be consistent with the alphabetical order ] > Reviewed-by: Masami Hiramatsu (Google) Thank you, > Signed-off-by: Steven Rostedt (Googl

Re: [PATCH 2/6] kallsyms: Emit symbol at the holes in the text

2024-07-16 Thread Masahiro Yamada
On Thu, Jun 13, 2024 at 10:36 PM Zheng Yejian wrote: > > When a weak type function is overridden, its symbol will be removed > from the symbol table, but its code will not be removed. Besides, > due to lacking of size for kallsyms, kernel compute function size by > substracting its symbol address

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-07-16 Thread Greg Kroah-Hartman
On Mon, Jul 15, 2024 at 08:39:59PM +, Sami Tolvanen wrote: > If using unions here is acceptable to everyone, a simple solution > would be to use a known name prefix for the reserved members and teach > gendwarfksyms to only print out the original type for the replaced > ones. For example: > >