Re: [PATCH net-next] virtio_net: Fix napi_skb_cache_put warning

2024-07-12 Thread Jakub Kicinski
On Fri, 12 Jul 2024 04:53:25 -0700 Breno Leitao wrote: > After the commit bdacf3e34945 ("net: Use nested-BH locking for > napi_alloc_cache.") was merged, the following warning began to appear: > >WARNING: CPU: 5 PID: 1 at net/core/skbuff.c:1451 > napi_skb_cache_put+0x82/0x4b0 > >

Re: [BUG REPORT] kernel BUG at lib/dynamic_queue_limits.c:99!

2024-07-12 Thread Jakub Kicinski
On Fri, 12 Jul 2024 17:43:21 -0700 Jakub Kicinski wrote: > CC: virtio_net maintainers and Jiri who added BQL Oh, sounds like the fix may be already posted: https://lore.kernel.org/all/20240712080329.197605-2-jean-phili...@linaro.org/

Re: [BUG REPORT] kernel BUG at lib/dynamic_queue_limits.c:99!

2024-07-12 Thread Jakub Kicinski
CC: virtio_net maintainers and Jiri who added BQL On Fri, 12 Jul 2024 10:12:42 +0800 xiujianfeng wrote: > On 2024/7/12 10:08, xiujianfeng wrote: > > I found a problem with my QEMU environment, and the log is as follows. > > > > After I did the bisect to locate the issue, I found > > 8490dd0592e85

[PATCH v3 4/4] trace: platform/x86/intel/ifs: Add SBAF trace support

2024-07-12 Thread Kuppuswamy Sathyanarayanan
From: Jithu Joseph Add tracing support for the SBAF IFS tests, which may be useful for debugging systems that fail these tests. Log details like test content batch number, SBAF bundle ID, program index and the exact errors or warnings encountered by each HT thread during the test. Reviewed-by: A

[PATCH v3 3/4] platform/x86/intel/ifs: Add SBAF test support

2024-07-12 Thread Kuppuswamy Sathyanarayanan
From: Jithu Joseph In a core, the SBAF test engine is shared between sibling CPUs. An SBAF test image contains multiple bundles. Each bundle is further composed of subunits called programs. When a SBAF test (for a particular core) is triggered by the user, each SBAF bundle from the loaded test i

[PATCH v3 2/4] platform/x86/intel/ifs: Add SBAF test image loading support

2024-07-12 Thread Kuppuswamy Sathyanarayanan
From: Jithu Joseph Structural Based Functional Test at Field (SBAF) is a new type of testing that provides comprehensive core test coverage complementing existing IFS tests like Scan at Field (SAF) or ArrayBist. SBAF device will appear as a new device instance (intel_ifs_2) under /sys/devices/vi

[PATCH v3 1/4] platform/x86/intel/ifs: Refactor MSR usage in IFS test code

2024-07-12 Thread Kuppuswamy Sathyanarayanan
IFS tests such as Scan at Field (SAF) or Structural Based Functional Test at Field (SBAF), require the user to load a test image. The image loading process is similar across these tests, with the only difference being MSR addresses used. To reuse the code between these tests, remove the hard coding

[PATCH v3 0/4] Add SBAF test to IFS

2024-07-12 Thread Kuppuswamy Sathyanarayanan
This patch series adds support for Structural Based Functional Test at Field (SBAF) in the IFS driver. SBAF is a new type of testing that provides comprehensive core test coverage, complementing existing IFS tests like Scan at Field (SAF) and ArrayBist. Granite Rapids (GNR) is the first platform th

Re: [PATCH] tracing: remove unreachable trace_array_put

2024-07-12 Thread Steven Rostedt
On Fri, 12 Jul 2024 23:12:58 +0300 Nikita Kiryushin wrote: > There is a trace_array_put() in check result for > nonseekable_open() in tracing_buffers_open(). However, > it would be never executed as nonseekable_open never fails > (by design). > > Remove the check and associated unreachable code.

Re: [PATCH v2 11/11] perf/uprobe: Add uretprobe timer

2024-07-12 Thread Andrii Nakryiko
+ bpf On Thu, Jul 11, 2024 at 4:07 AM Peter Zijlstra wrote: > > In order to put a bound on the uretprobe_srcu critical section, add a > timer to uprobe_task. Upon every RI added or removed the timer is > pushed forward to now + 1s. If the timer were ever to fire, it would > convert the SRCU 'refe

Re: [PATCH v2 10/11] perf/uprobe: Convert single-step and uretprobe to SRCU

2024-07-12 Thread Andrii Nakryiko
+ bpf On Thu, Jul 11, 2024 at 4:07 AM Peter Zijlstra wrote: > > Both single-step and uretprobes take a refcount on struct uprobe in > handle_swbp() in order to ensure struct uprobe stays extant until a > next trap. > > Since uprobe_unregister() only cares about the uprobe_consumer > life-time, an

Re: [PATCH v2 08/11] perf/uprobe: Convert (some) uprobe->refcount to SRCU

2024-07-12 Thread Andrii Nakryiko
+ bpf On Thu, Jul 11, 2024 at 4:07 AM Peter Zijlstra wrote: > > With handle_swbp() hitting concurrently on (all) CPUs, potentially on > the same uprobe, the uprobe->refcount can get *very* hot. Move the > struct uprobe lifetime into uprobes_srcu such that it covers both the > uprobe and the uprob

Re: [PATCH v2 07/11] perf/uprobe: Split uprobe_unregister()

2024-07-12 Thread Andrii Nakryiko
+ bpf On Thu, Jul 11, 2024 at 4:07 AM Peter Zijlstra wrote: > > With uprobe_unregister() having grown a synchronize_srcu(), it becomes > fairly slow to call. Esp. since both users of this API call it in a > loop. > > Peel off the sync_srcu() and do it once, after the loop. > > Signed-off-by: Pete

Re: [PATCH v2 06/11] perf/uprobe: SRCU-ify uprobe->consumer list

2024-07-12 Thread Andrii Nakryiko
+ bpf@vger, please cc bpf ML for the next revision, these changes are very relevant there as well, thanks On Thu, Jul 11, 2024 at 4:07 AM Peter Zijlstra wrote: > > With handle_swbp() hitting concurrently on (all) CPUs the > uprobe->register_rwsem can get very contended. Add an SRCU instance to >

Re: [PATCH v2 03/11] rbtree: Provide rb_find_rcu() / rb_find_add_rcu()

2024-07-12 Thread Andrii Nakryiko
On Thu, Jul 11, 2024 at 4:07 AM Peter Zijlstra wrote: > > Much like latch_tree, add two RCU methods for the regular RB-tree, > which can be used in conjunction with a seqcount to provide lockless > lookups. > > Signed-off-by: Peter Zijlstra (Intel) > Reviewed-by: Masami Hiramatsu (Google) > ---

[PATCH] tracing: remove unreachable trace_array_put

2024-07-12 Thread Nikita Kiryushin
There is a trace_array_put() in check result for nonseekable_open() in tracing_buffers_open(). However, it would be never executed as nonseekable_open never fails (by design). Remove the check and associated unreachable code. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixe

Re: [PATCH 2/2] selftests/bpf: Change uretprobe syscall number in uprobe_syscall test

2024-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2024 at 6:53 AM Jiri Olsa wrote: > > Fixing the syscall number value. > > Fixes: 9e7f74e64ae5 ("selftests/bpf: Add uretprobe syscall call from user > space test") > Signed-off-by: Jiri Olsa > --- > tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c | 2 +- > 1 file changed,

Re: [PATCH 1/2] uprobe: Change uretprobe syscall scope and number

2024-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2024 at 6:52 AM Jiri Olsa wrote: > > After discussing with Arnd [1] it's preferable to change uretprobe > syscall number to 467 to omit the merge conflict with xattrat syscalls. > > Also changing the ABI to 'common' which will ease up the global > scripts/syscall.tbl management. On

Re: [PATCH v2 00/11] perf/uprobe: Optimize uprobes

2024-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2024 at 6:10 AM Peter Zijlstra wrote: > > On Thu, Jul 11, 2024 at 09:57:44PM -0700, Andrii Nakryiko wrote: > > > Anyways, if you'd like to use it, it's at [0]. All you should need to > > build and run it is: > > > > $ cd examples/c > > $ make -j$(nproc) uprobe-stress > > $ su

Re: [PATCH net-next] virtio_net: Fix napi_skb_cache_put warning

2024-07-12 Thread Breno Leitao
Hello Jakub, On Fri, Jul 12, 2024 at 07:54:32AM -0700, Jakub Kicinski wrote: > On Fri, 12 Jul 2024 04:53:25 -0700 Breno Leitao wrote: > > Subject: [PATCH net-next] virtio_net: Fix napi_skb_cache_put warning > > [PATCH net] for fixes so that the bot knows what to test against :) > No need to repos

Re: [PATCH net-next v3 2/2] vsock/virtio: avoid queuing packets when work queue is empty

2024-07-12 Thread Stefano Garzarella
On Thu, Jul 11, 2024 at 04:58:47PM GMT, Luigi Leonardi via B4 Relay wrote: From: Luigi Leonardi Introduce an optimization in virtio_transport_send_pkt: when the work queue (send_pkt_queue) is empty the packet is Note: send_pkt_queue is just a queue of sk_buff, is not really a work queue.

Re: [PATCH net-next] virtio_net: Fix napi_skb_cache_put warning

2024-07-12 Thread Jakub Kicinski
On Fri, 12 Jul 2024 04:53:25 -0700 Breno Leitao wrote: > Subject: [PATCH net-next] virtio_net: Fix napi_skb_cache_put warning [PATCH net] for fixes so that the bot knows what to test against :) No need to repost (this time).

Re: [PATCH] virtio-pci: Add MSI support

2024-07-12 Thread Manivannan Sadhasivam
+ Jason Wang (email got truncated). On Fri, Jul 12, 2024 at 07:59:14PM +0530, Manivannan Sadhasivam wrote: > Virtio spec has so far only supported MSI-X and INTX for receiving the > interrupts from the virtio device on PCI transport. But this becomes a > limiting factor for devices supporting only

[PATCH] virtio-pci: Add MSI support

2024-07-12 Thread Manivannan Sadhasivam
Virtio spec has so far only supported MSI-X and INTX for receiving the interrupts from the virtio device on PCI transport. But this becomes a limiting factor for devices supporting only MSI (plus INTX emulation) as they have to use the legacy INTX emulation which is limited to one IRQ per PCIe func

Re: [PATCH V2 0/7] vdpa live update

2024-07-12 Thread Steven Sistare
On 7/12/2024 9:18 AM, Steve Sistare wrote: Live update is a technique wherein an application saves its state, exec's to an updated version of itself, and restores its state. Clients of the application experience a brief suspension of service, on the order of 100's of milliseconds, but are otherw

[PATCH] vdpa/octeon_ep: Fix error code in octep_process_mbox()

2024-07-12 Thread Dan Carpenter
Return -EINVAL for invalid signatures. Don't return success. Fixes: 8b6c724cdab8 ("virtio: vdpa: vDPA driver for Marvell OCTEON DPU devices") Signed-off-by: Dan Carpenter --- Nag mode: When we add a new driver, then could we use the patch prefix for the driver not for the subsystem only. BAD:

[PATCH 2/2] selftests/bpf: Change uretprobe syscall number in uprobe_syscall test

2024-07-12 Thread Jiri Olsa
Fixing the syscall number value. Fixes: 9e7f74e64ae5 ("selftests/bpf: Add uretprobe syscall call from user space test") Signed-off-by: Jiri Olsa --- tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftest

[PATCH 1/2] uprobe: Change uretprobe syscall scope and number

2024-07-12 Thread Jiri Olsa
After discussing with Arnd [1] it's preferable to change uretprobe syscall number to 467 to omit the merge conflict with xattrat syscalls. Also changing the ABI to 'common' which will ease up the global scripts/syscall.tbl management. One consequence is we generate uretprobe syscall numbers for AB

[PATCH 0/2] uprobe: Fix uretprobe syscall wiring

2024-07-12 Thread Jiri Olsa
hi, the uretprobe syscall clashed in linux-next tree with xattrat syscalls, so after discussing with Arnd, changing the syscall number to 467. I'm also changing the ABI to 'common' which will ease up the global scripts/syscall.tbl management. I split the change into syscall_64.tbl and selftest ch

Re: [PATCH net-next v3 1/2] vsock/virtio: refactor virtio_transport_send_pkt_work

2024-07-12 Thread Stefano Garzarella
On Thu, Jul 11, 2024 at 04:58:46PM GMT, Luigi Leonardi via B4 Relay wrote: From: Marco Pinna Preliminary patch to introduce an optimization to the enqueue system. All the code used to enqueue a packet into the virtqueue is removed from virtio_transport_send_pkt_work() and moved to the new virt

[PATCH V2 3/7] vhost-vdpa: VHOST_NEW_OWNER

2024-07-12 Thread Steve Sistare
Add an ioctl to transfer file descriptor ownership and pinned memory accounting from one process to another. This is more efficient than VHOST_RESET_OWNER followed by VHOST_SET_OWNER, as that would unpin all physical pages, requiring them to be repinned in the new process. That would cost multipl

[PATCH V2 0/7] vdpa live update

2024-07-12 Thread Steve Sistare
Live update is a technique wherein an application saves its state, exec's to an updated version of itself, and restores its state. Clients of the application experience a brief suspension of service, on the order of 100's of milliseconds, but are otherwise unaffected. Define and implement interfa

[PATCH V2 1/7] vhost-vdpa: count pinned memory

2024-07-12 Thread Steve Sistare
Remember the count of pinned memory for the device. Signed-off-by: Steve Sistare --- drivers/vhost/vdpa.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 63a53680a85c..963f3704bc39 100644 --- a/drivers/vhost/vdpa.c +++

[PATCH V2 7/7] vdpa/mlx5: new owner capability

2024-07-12 Thread Steve Sistare
The mlx5 vdpa device supports ownership transfer to a new process, so advertise VHOST_BACKEND_F_NEW_OWNER. User virtual addresses are not used after they are initially translated to physical, so VHOST_IOTLB_REMAP is not required, hence VHOST_BACKEND_F_IOTLB_REMAP is not advertised. Signed-off-by:

[PATCH V2 5/7] vhost-vdpa: VHOST_IOTLB_REMAP

2024-07-12 Thread Steve Sistare
When device ownership is passed to a new process via VHOST_NEW_OWNER, some devices need to know the new userland addresses of the dma mappings. Define the new iotlb message type VHOST_IOTLB_REMAP to update the uaddr of a mapping. The new uaddr must address the same memory object as originally mapp

[PATCH V2 6/7] vhost-vdpa: VHOST_BACKEND_F_IOTLB_REMAP

2024-07-12 Thread Steve Sistare
Add the VHOST_BACKEND_F_IOTLB_REMAP backend capability, which indicates that VHOST_IOTLB_REMAP is supported. If VHOST_BACKEND_F_IOTLB_REMAP is advertised, then the user must call VHOST_IOTLB_REMAP after ownership of a device is transferred to a new process via VHOST_NEW_OWNER. Disabling the featu

[PATCH V2 2/7] vhost-vdpa: pass mm to bind

2024-07-12 Thread Steve Sistare
Pass the target mm to vhost_vdpa_bind_mm. No functional change. Signed-off-by: Steve Sistare --- drivers/vhost/vdpa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 963f3704bc39..b49e5831b3f0 100644 --- a/drivers/vhost

[PATCH V2 4/7] vhost-vdpa: VHOST_BACKEND_F_NEW_OWNER

2024-07-12 Thread Steve Sistare
Add the VHOST_BACKEND_F_NEW_OWNER backend capability, which indicates that VHOST_NEW_OWNER is supported. Signed-off-by: Steve Sistare --- drivers/vhost/vdpa.c | 7 ++- include/uapi/linux/vhost_types.h | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/v

Re: [PATCH v2 00/11] perf/uprobe: Optimize uprobes

2024-07-12 Thread Peter Zijlstra
On Thu, Jul 11, 2024 at 09:57:44PM -0700, Andrii Nakryiko wrote: > Anyways, if you'd like to use it, it's at [0]. All you should need to > build and run it is: > > $ cd examples/c > $ make -j$(nproc) uprobe-stress > $ sudo ./uprobe-stress -tN -aM -mP -fR > [0] > https://github.com/libbp

[PATCH net-next] virtio_net: Fix napi_skb_cache_put warning

2024-07-12 Thread Breno Leitao
After the commit bdacf3e34945 ("net: Use nested-BH locking for napi_alloc_cache.") was merged, the following warning began to appear: WARNING: CPU: 5 PID: 1 at net/core/skbuff.c:1451 napi_skb_cache_put+0x82/0x4b0 __warn+0x12f/0x340 napi_skb_cache_put+0x82/0x4b0

Re: [PATCH v2 10/11] perf/uprobe: Convert single-step and uretprobe to SRCU

2024-07-12 Thread Oleg Nesterov
On 07/11, Peter Zijlstra wrote: > > uprobe_free_stage1 > call_srcu(&uretprobe_srcu, &uprobe->rcu, uprobe_free_stage2); > > put_uprobe() > if (refcount_dec_and_test) > call_srcu(&uprobes_srcu, &uprobe->rcu, uprobe_free_stage1); > > > So my thinking was since we take uretprobe_srcu

Re: [PATCH 0/2] Cleanup the MAINTAINER's file

2024-07-12 Thread Andi Shyti
Hi Wolfram, On Fri, Jul 12, 2024 at 08:34:11AM GMT, Wolfram Sang wrote: > On Fri, Jul 12, 2024 at 01:19:24AM +0200, Andi Shyti wrote: > > Hi, > > > > while reviewing Wolfram's series, I received some delivery > > failure notifications for e-mails that don't exist anymore. > > > > With this serie

Re: [PATCH v2 00/11] perf/uprobe: Optimize uprobes

2024-07-12 Thread Peter Zijlstra
On Thu, Jul 11, 2024 at 09:57:44PM -0700, Andrii Nakryiko wrote: > You should only need not-too-old Clang to build everything (Clang 12+ > should work, I believe). But do let me know if you run into troubles. A quick look at the thing shows me it's full of BPF gunk :/ Which means, I probably als

Re: [PATCH] test/vsock: add install target

2024-07-12 Thread Stefano Garzarella
On Thu, Jul 11, 2024 at 07:14:55AM GMT, Jakub Kicinski wrote: On Thu, 11 Jul 2024 15:38:01 +0200 Stefan Hajnoczi wrote: > Usually vsock tests test both the driver (virtio-vsock) in the guest and the > device in the host kernel (vhost-vsock). So I usually run the tests in 2 > nested VMs to test t

[PATCH 6/6] remoteproc: imx_rproc: handle system off for i.MX7ULP

2024-07-12 Thread Peng Fan (OSS)
From: Peng Fan The i.MX7ULP Cortex-A7 is under control of Cortex-M4. The i.MX7ULP Linux poweroff and restart rely on rpmsg driver to send a message to Cortex-M4 firmware. Then Cortex-A7 could poweroff or restart by Cortex-M4 to configure the i.MX7ULP power controller properly. However the reboot

[PATCH 5/6] remoteproc: imx_rproc: allow tx_block to be set

2024-07-12 Thread Peng Fan (OSS)
From: Peng Fan Current tx_block is set to true, but there is case that no need to wait response. Linux just needs to send data to remote processor, so let's allow tx_block could be set to false. Reviewed-by: Jacky Bai Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 12 ++-

[PATCH 4/6] remoteproc: imx_rproc: merge TCML/U

2024-07-12 Thread Peng Fan (OSS)
From: Peng Fan Merge contiguous TCML/U regions into one to avoid load elf files which has large sections failure. Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b/

[PATCH 3/6] remoteproc: imx_rproc: initialize workqueue earlier

2024-07-12 Thread Peng Fan (OSS)
From: Peng Fan Initialize workqueue before requesting mailbox channel, otherwise if mailbox interrupt comes before workqueue ready, the imx_rproc_rx_callback will trigger issue. Reviewed-by: Richard Zhu Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 4 ++-- 1 file changed, 2 ins

[PATCH 2/6] remoteproc: imx_rproc: use imx specific hook for find_loaded_rsc_table

2024-07-12 Thread Peng Fan (OSS)
From: Peng Fan If there is a resource table device tree node, use the address as the resource table address, otherwise use the address(where .resource_table section loaded) inside the Cortex-M elf file. And there is an update in NXP SDK that Resource Domain Control(RDC) enabled to protect TCM, l

[PATCH 1/6] remoteproc: imx_rproc: correct ddr alias for i.MX8M

2024-07-12 Thread Peng Fan (OSS)
From: Peng Fan The DDR Alias address should be 0x4000 according to RM, so correct it. Fixes: 4ab8f9607aad ("remoteproc: imx_rproc: support i.MX8MQ/M") Reported-by: Terry Lv Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH 0/6] remoteproc: imx_rproc: various patches for misc

2024-07-12 Thread Peng Fan (OSS)
: 20240712-imx_rproc-25f3ab753c58 Best regards, -- Peng Fan

Re: [PATCH 1/1] remoteproc: mediatek: Support multiple reserved memory regions

2024-07-12 Thread AngeloGioacchino Del Regno
Il 03/07/24 13:53, Shun-yi Wang ha scritto: From: "shun-yi.wang" SCP supports multiple reserved memory regions, intended for specific hardwards. Signed-off-by: shun-yi.wang --- drivers/remoteproc/mtk_scp.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) di

[ANNOUNCE] 4.19.317-rt137

2024-07-12 Thread Daniel Wagner
Hello RT-list! I'm pleased to announce the 4.19.317-rt137 stable release. This just updates this series to the latest stable upstream release. No RT specific changes. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git branch: