Re: [PATCH] LoongArch: make the users of larch_insn_gen_break() constant

2024-06-29 Thread Oleg Nesterov
On 06/30, Huacai Chen wrote: > > > +static __init int check_emit_break(void) > > +{ > > + BUG_ON(UPROBE_SWBP_INSN != larch_insn_gen_break(BRK_UPROBE_BP)); > > + BUG_ON(UPROBE_XOLBP_INSN != larch_insn_gen_break(BRK_UPROBE_XOLBP)); > > + return 0; > > +} > > +arch_initcall(check_em

Re: [PATCH v4 1/2] rust: add static_key_false

2024-06-29 Thread hev
Hi Alice On Fri, Jun 28, 2024 at 9:24 PM Alice Ryhl wrote: > > Add just enough support for static key so that we can use it from > tracepoints. Tracepoints rely on `static_key_false` even though it is > deprecated, so we add the same functionality to Rust. > > It is not possible to use the existi

Re: [PATCH] LoongArch: make the users of larch_insn_gen_break() constant

2024-06-29 Thread Huacai Chen
Hi, Oleg, On Sat, Jun 29, 2024 at 11:05 PM Oleg Nesterov wrote: > > LoongArch defines UPROBE_SWBP_INSN as a function call and this breaks > arch_uprobe_trampoline() which uses it to initialize a static variable. > > Add the new "__builtin_constant_p" helper, __emit_break(), and redefine > the cur

[PATCH] LoongArch: make the users of larch_insn_gen_break() constant

2024-06-29 Thread Oleg Nesterov
LoongArch defines UPROBE_SWBP_INSN as a function call and this breaks arch_uprobe_trampoline() which uses it to initialize a static variable. Add the new "__builtin_constant_p" helper, __emit_break(), and redefine the current users of larch_insn_gen_break() to use it. The patch adds check_emit_br

Re: [PATCH] LoongArch: uprobes: make UPROBE_SWBP_INSN/UPROBE_XOLBP_INSN constant

2024-06-29 Thread Huacai Chen
On Sat, Jun 29, 2024 at 9:40 PM Oleg Nesterov wrote: > > On 06/29, Tiezhu Yang wrote: > > > > On Thu, 27 Jun 2024 19:38:06 +0200 > > Oleg Nesterov wrote: > > > > ... > > > > > > > +arch_initcall(check_emit_break); > > > > > + > > > > > > > > I wouldn't even bother with this, but whatever. > > > >

Re: [PATCH] LoongArch: uprobes: make UPROBE_SWBP_INSN/UPROBE_XOLBP_INSN constant

2024-06-29 Thread Oleg Nesterov
On 06/29, Tiezhu Yang wrote: > > On Thu, 27 Jun 2024 19:38:06 +0200 > Oleg Nesterov wrote: > > ... > > > > > +arch_initcall(check_emit_break); > > > > + > > > > > > I wouldn't even bother with this, but whatever. > > > > Agreed, this looks a bit ugly. I did this only because I can not test > > thi

Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Name the regulators

2024-06-29 Thread Konrad Dybcio
On 27.06.2024 3:15 PM, Luca Weiss wrote: > Without explicitly specifying names for the regulators they are named > based on the DeviceTree node name. This results in multiple regulators > with the same name, making debug prints and regulator_summary impossible > to reason about. > > Signed-off-by:

Re: [PATCH v2 2/2] ARM: dts: qcom-msm8226-samsung-ms013g: Add initial device tree

2024-06-29 Thread Konrad Dybcio
On 29.06.2024 11:01 AM, Luca Weiss wrote: > On Donnerstag, 27. Juni 2024 21:30:52 MESZ Raymond Hackley wrote: >> Samsung Galaxy Grand 2 is a phone based on MSM8226. It's similar to the >> other Samsung devices based on MSM8226 with only a few minor differences. >> >> The device trees contain initia

Re: [PATCH V3 1/2] soc: qcom: smp2p: Use devname for interrupt descriptions

2024-06-29 Thread Konrad Dybcio
On 27.06.2024 12:48 PM, Sudeepgoud Patil wrote: > From: Chris Lew > > When using /proc/interrupts to collect statistics on smp2p interrupt > counts, it is hard to distinguish the different instances of smp2p from > each other. For example to debug a processor boot issue, the ready and > handover

Re: [PATCH] soc: qcom: smsm: Add missing mailbox dependency to Kconfig

2024-06-29 Thread Konrad Dybcio
On 28.06.2024 7:30 PM, Luca Weiss wrote: > Since the smsm driver got the ability to interact with the mailbox using > the mailbox subsystem and not just syscon, we need to add the dependency > to kconfig as well to avoid compile errors. > > Fixes: 75287992f58a ("soc: qcom: smsm: Support using mail

Re: [PATCH] LoongArch: uprobes: make UPROBE_SWBP_INSN/UPROBE_XOLBP_INSN constant

2024-06-29 Thread Tiezhu Yang
On Thu, 27 Jun 2024 19:38:06 +0200 Oleg Nesterov wrote: ... > > > +arch_initcall(check_emit_break); > > > + > > > > I wouldn't even bother with this, but whatever. > > Agreed, this looks a bit ugly. I did this only because I can not test > this (hopefully trivial) patch and the maintainers didn

Re: [PATCH v2 2/2] ARM: dts: qcom-msm8226-samsung-ms013g: Add initial device tree

2024-06-29 Thread Luca Weiss
On Donnerstag, 27. Juni 2024 21:30:52 MESZ Raymond Hackley wrote: > Samsung Galaxy Grand 2 is a phone based on MSM8226. It's similar to the > other Samsung devices based on MSM8226 with only a few minor differences. > > The device trees contain initial support with: > - GPIO keys > - Regulator h