Re: [PATCH] wl1251: Fix possible buffer overflow in wl1251_cmd_scan

2021-04-17 Thread Kalle Valo
Lee Gibson writes: > Function wl1251_cmd_scan calls memcpy without checking the length. > A user could control that length and trigger a buffer overflow. > Fix by checking the length is within the maximum allowed size. > > Signed-off-by: Lee Gibson Please fix the commit log, the user cannot con

Re: [PATCH v2 00/16] Multigenerational LRU Framework

2021-04-17 Thread Michel Lespinasse
On Thu, Apr 15, 2021 at 01:13:13AM -0600, Yu Zhao wrote: > Page table scanning doesn't replace the existing rmap walk. It is > complementary and only happens when it is likely that most of the > pages on a system under pressure have been referenced, i.e., out of > *inactive* pages, by definition of

Re: [PATCH] bcma: remove unused function

2021-04-17 Thread Kalle Valo
Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/bcma/driver_mips.c:55:20: warning: unused function > 'mips_write32' [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Patch applied to wireless-drivers-next.git, thanks. fa84df705260 bcma: rem

Re: [PATCH] wil6210: wmi: Remove useless code

2021-04-17 Thread Kalle Valo
Jiapeng Chong wrote: > Fix the following whitescan warning: > > An unsigned value can never be less than 0. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Patch applied to wireless-drivers-next.git, thanks. 5e6087559e85 wil6210: wmi: Remove useless code -- https://patchwork.k

Re: [PATCH] carl9170: remove get_tid_h

2021-04-17 Thread Kalle Valo
Christophe JAILLET wrote: > 'get_tid_h()' is the same as 'ieee80211_get_tid()'. > So this function can be removed to save a few lines of code. > > Signed-off-by: Christophe JAILLET > Acked-by: Christian Lamparter Patch applied to wireless-drivers-next.git, thanks. cf366b154704 carl9170: remo

Re: mwl8k: Fix a double Free in mwl8k_probe_hw

2021-04-17 Thread Kalle Valo
Lv Yunlong wrote: > In mwl8k_probe_hw, hw->priv->txq is freed at the first time by > dma_free_coherent() in the call chain: > if(!priv->ap_fw)->mwl8k_init_txqs(hw)->mwl8k_txq_init(hw, i). > > Then in err_free_queues of mwl8k_probe_hw, hw->priv->txq is freed > at the second time by mwl8k_txq_dein

Re: [1/4] brcmfmac: Remove duplicate struct declaration

2021-04-17 Thread Kalle Valo
Wan Jiabing wrote: > struct brcmf_bus is declared twice. One has been declared > at 37th line. Remove the duplicate. > > Signed-off-by: Wan Jiabing 2 patches applied to wireless-drivers-next.git, thanks. d663bc3317c9 brcmfmac: Remove duplicate struct declaration 444a9af68b5c wilc1000: Remove

Re: [2/2] wl3501: fix typo of 'Networks' in comment

2021-04-17 Thread Kalle Valo
Eric Lin wrote: > Signed-off-by: Eric Lin > Reported-by: Gustavo A. R. Silva Patch applied to wireless-drivers-next.git, thanks. 7f50ddc5d4fe wl3501: fix typo of 'Networks' in comment -- https://patchwork.kernel.org/project/linux-wireless/patch/20210331010418.1632816-2-dslin1...@gmail.com/

Re: libertas: struct lbs_private is declared duplicately

2021-04-17 Thread Kalle Valo
Wan Jiabing wrote: > struct lbs_private has been declared at 22nd line. > Remove the duplicate. > > Signed-off-by: Wan Jiabing Patch applied to wireless-drivers-next.git, thanks. d3240418a662 libertas: struct lbs_private is declared duplicately -- https://patchwork.kernel.org/project/linux-

Re: [PATCH] brcmfmac: A typo fix

2021-04-17 Thread Kalle Valo
Bhaskar Chowdhury wrote: > s/revsion/revision/ > > Signed-off-by: Bhaskar Chowdhury Patch applied to wireless-drivers-next.git, thanks. 705b5cfab183 brcmfmac: A typo fix -- https://patchwork.kernel.org/project/linux-wireless/patch/20210323043657.1466296-1-unixbhas...@gmail.com/ https://wir

Re: [PATCH v2] rsi: fix comment syntax in file headers

2021-04-17 Thread Kalle Valo
Aditya Srivastava wrote: > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > There are some files in drivers/net/wireless/rsi which follow this syntax > in their file headers, i.e. start with '/**' like comments, which causes > unexpected warnings f

Re: [PATCH] hostap: Fix memleak in prism2_config

2021-04-17 Thread Kalle Valo
Dinghao Liu wrote: > When prism2_hw_config() fails, we just return an error code > without any resource release, which may lead to memleak. > > Signed-off-by: Dinghao Liu Nobody reviewed this, so dropping the patch. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/lin

Re: [PATCH] brcmsmac: fix shift on 4 bit masked value

2021-04-17 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > The calculation of offtune_val seems incorrect, the u16 value in > pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then > shifted 8 places right so that always ends up as a zero result. I > believe the intended shift was 4 bits to the r

[PATCH] base: power: runtime.c: Remove a unnecessary space

2021-04-17 Thread Sebastian Fricke
Remove a redundant space to improve the quality of the comment. Signed-off-by: Sebastian Fricke --- Side-note: I found this while reading the code, I don't believe it is important but I thought it doesn't hurt to fix it. --- drivers/base/power/runtime.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 2/2] mmc: block: Update ext_csd.cache_ctrl if it was written

2021-04-17 Thread Avri Altman
The cache function can be turned ON and OFF by writing to the CACHE_CTRL byte (EXT_CSD byte [33]). However, card->ext_csd.cache_ctrl is only set on init if cache size > 0. Fix that by explicitly setting ext_csd.cache_ctrl on ext-csd write. Signed-off-by: Avri Altman --- drivers/mmc/core/block

[PATCH v2 1/2] mmc: block: Issue flush only if allowed

2021-04-17 Thread Avri Altman
The cache may be flushed to the nonvolatile storage by writing to FLUSH_CACHE byte (EXT_CSD byte [32]). When in command queueing mode, the cache may be flushed by issuing a CMDQ_TASK_ DEV_MGMT (CMD48) with a FLUSH_CACHE op-code. Either way, verify that The cache function is turned ON before doing

[PATCH v2 0/2] Do not flush cache when it is disabled

2021-04-17 Thread Avri Altman
v1 -> v2: - Attend Adrian's comments Cache is a temporary storage space in an eMMC device. Volatile by nature, the cache should in typical case reduce the access time compared to an access to the main nonvolatile storage. The cache function can be turned ON and OFF. Once OFF, the host is not exp

Re: [PATCH] rtl8xxxu: Fix device info for RTL8192EU devices

2021-04-17 Thread Kalle Valo
Pascal Terjan wrote: > Based on 2001:3319 and 2357:0109 which I used to test the fix and > 0bda:818b and 2357:0108 for which I found efuse dumps online. > > == 2357:0109 == > === Before === > Vendor: Realtek > Product: \x03802.11n NI > Serial: > === After === > Vendor: Realtek > Product: 802.11n

Re: [PATCH] rsi: fix error return code of rsi_load_9116_firmware()

2021-04-17 Thread Kalle Valo
Jia-Ju Bai wrote: > When kmemdup() returns NULL to ta_firmware, no error return code of > rsi_load_9116_firmware() is assigned. > To fix this bug, status is assigned with -ENOMEM in this case. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Someone needs to review this. Patch set to

Re: [PATCH] ti: wlcore: fix error return code of wl1271_cmd_build_ps_poll()

2021-04-17 Thread Kalle Valo
Jia-Ju Bai wrote: > When ieee80211_pspoll_get() returns NULL to skb, no error return code of > wl1271_cmd_build_ps_poll() is assigned. > To fix this bug, ret is assigned with -ENOMEM in this case. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Someone needs to review this. Patch set

Re: [PATCH] ti: wlcore: fix error return code of wl1271_suspend()

2021-04-17 Thread Kalle Valo
Jia-Ju Bai wrote: > When wl is NULL, no error return code of wl1271_suspend() is assigned. > To fix this bug, ret is assigned with -EINVAL in this case. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Someone needs to review this. Patch set to Changes Requested. -- https://patchwor

Re: [PATCH] marvell: libertas_tf: fix error return code of if_usb_prog_firmware()

2021-04-17 Thread Kalle Valo
Jia-Ju Bai wrote: > When check_fwfile_format() fails, no error return code of > if_usb_prog_firmware() is assigned. > To fix this bug, ret is assigned with -EINVAL as error return code. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Someone needs to review this. Patch set to Changes

[PATCH 2/2] kconfig: highlight xconfig 'comment' lines with '***'

2021-04-17 Thread Randy Dunlap
Mark Kconfig "comment" lines with "*** ***" so that it is clear that these lines are comments and not some kconfig item that cannot be modified. This is helpful in some menus to be able to provide a menu "sub-heading" for groups of similar config items. This also makes the comments be presented

[PATCH 1/2] kconfig: highlight gconfig 'comment' lines with '***'

2021-04-17 Thread Randy Dunlap
Mark Kconfig "comment" lines with "*** ***" so that it is clear that these lines are comments and not some kconfig item that cannot be modified. This is helpful in some menus to be able to provide a menu "sub-heading" for groups of similar config items. This also makes the comments be presented

Re: [PATCH 1/2] srcu: Fix broken node geometry after early ssp init

2021-04-17 Thread Paul E. McKenney
On Sat, Apr 17, 2021 at 03:16:49PM +0200, Frederic Weisbecker wrote: > On Wed, Apr 14, 2021 at 08:55:38AM -0700, Paul E. McKenney wrote: > > > diff --git a/kernel/rcu/rcu.h b/kernel/rcu/rcu.h > > > index 75ed367d5b60..24db97cbf76b 100644 > > > --- a/kernel/rcu/rcu.h > > > +++ b/kernel/rcu/rcu.h > >

[Patch] blk-wbt: fix a divide-by-zero error in rwb_arm_timer()

2021-04-17 Thread Cong Wang
From: Cong Wang We hit a divide error in rwb_arm_timer() and crash dump shows rqd->scale_step is 16777215 (0xff in hex), so the expression "(rqd->scale_step + 1) << 8)" is 0x1, which is just beyond 32-bit integer range, hence it is truncated to 0 and int_sqrt(0) returns 0 too, so we e

Re: PROBLEM: DoS Attack on Fragment Cache

2021-04-17 Thread Willy Tarreau
On Sat, Apr 17, 2021 at 10:26:30PM -0400, Matt Corallo wrote: > Sure, there are better ways to handle the reassembly cache overflowing, but > that is pretty unrelated to the fact that waiting 30 full seconds for a > fragment to come in doesn't really make sense in today's networks (the 30 > second

Re: [PATCH v4 3/5] RISC-V: Initial DTS for Microchip ICICLE board

2021-04-17 Thread Atish Patra
On Sat, Apr 17, 2021 at 8:36 PM Atish Patra wrote: > > On Mon, Mar 29, 2021 at 10:04 AM Vitaly Wool wrote: > > > > On Sat, Mar 27, 2021 at 6:24 PM Alex Ghiti wrote: > > > > > > Hi Atish, > > > > > > Le 3/3/21 à 3:02 PM, Atish Patra a écrit : > > > > Add initial DTS for Microchip ICICLE board hav

Re: [PATCH 5/9] sched: prctl() core-scheduling interface

2021-04-17 Thread Joel Fernandes
On Wed, Apr 07, 2021 at 07:00:33PM +0200, Peter Zijlstra wrote: > On Thu, Apr 01, 2021 at 03:10:17PM +0200, Peter Zijlstra wrote: > > > Current hard-coded policies are: > > > > - a user can clear the cookie of any process they can set a cookie for. > >Lack of a cookie *might* be a security i

Re: [PATCH v4 3/5] RISC-V: Initial DTS for Microchip ICICLE board

2021-04-17 Thread Atish Patra
On Mon, Mar 29, 2021 at 10:04 AM Vitaly Wool wrote: > > On Sat, Mar 27, 2021 at 6:24 PM Alex Ghiti wrote: > > > > Hi Atish, > > > > Le 3/3/21 à 3:02 PM, Atish Patra a écrit : > > > Add initial DTS for Microchip ICICLE board having only > > > essential devices (clocks, sdhci, ethernet, serial, etc

[PATCH v3 2/2] cpupower: Fix amd cpu (family >= 0x17) active state issue

2021-04-17 Thread 徐福海
From: xufuhai If the read_msr function is executed by a non-root user, the function returns -1, which means that there is no permission to access /dev/cpu/%d/msr, but cpufreq_has_boost_support should also return -1 immediately, and should not follow the original logic to return 0, which will ca

Re: [git pull] drm/vmwgfx fixes for 5.12-rc8

2021-04-17 Thread pr-tracker-bot
The pull request you sent on Sun, 18 Apr 2021 09:48:56 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2021-04-18 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/aba5970c4da0059ed8052188a341a85ac8845d6f Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [GIT PULL] SCSI fixes for 5.12-rc6

2021-04-17 Thread pr-tracker-bot
The pull request you sent on Sat, 17 Apr 2021 18:46:43 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c98ff1d013d2d53911c4b3e8ba14c7cd141cf1ed Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH v4 0/5] Add Microchip PolarFire Soc Support

2021-04-17 Thread Atish Patra
On Mon, Mar 29, 2021 at 9:17 PM Palmer Dabbelt wrote: > > On Wed, 03 Mar 2021 12:02:48 PST (-0800), Atish Patra wrote: > > This series adds minimal support for Microchip Polar Fire Soc Icicle kit. > > It is rebased on v5.12-rc1 and depends on clock support. > > Only MMC and ethernet drivers are en

Re: [PATCH v4 1/2] binfmt_flat: allow not offsetting data start

2021-04-17 Thread Greg Ungerer
On 17/4/21 2:54 pm, Damien Le Moal wrote: On 2021/04/17 13:52, Greg Ungerer wrote: On 17/4/21 11:10 am, Damien Le Moal wrote: Commit 2217b9826246 ("binfmt_flat: revert "binfmt_flat: don't offset the data start"") restored offsetting the start of the data section by a number of words defined

Re: PROBLEM: DoS Attack on Fragment Cache

2021-04-17 Thread Matt Corallo
Sure, there are better ways to handle the reassembly cache overflowing, but that is pretty unrelated to the fact that waiting 30 full seconds for a fragment to come in doesn't really make sense in today's networks (the 30 second delay that is used today appears to even be higher than RFC 791 sugg

Re: [PATCH 12/12] dt-bindings: soc: qcom: aoss: Delete unused power-domain definitions

2021-04-17 Thread Stephen Boyd
Quoting Sibi Sankar (2021-04-16 05:03:58) > Delete unused power-domain definitions exposed by AOSS QMP. > > Signed-off-by: Sibi Sankar > --- Reviewed-by: Stephen Boyd

Re: [PATCH 10/12] arm64: dts: qcom: sm8250: Use QMP binding to control load state

2021-04-17 Thread Stephen Boyd
Quoting Sibi Sankar (2021-04-16 05:03:56) > Use the Qualcomm Mailbox Protocol (QMP) binding to control the load > state resources on SM8250 SoCs and drop deprecated power-domains exposed > by AOSS QMP node. > > Signed-off-by: Sibi Sankar > --- Reviewed-by: Stephen Boyd

Re: [PATCH 11/12] arm64: dts: qcom: sm8350: Use QMP binding to control load state

2021-04-17 Thread Stephen Boyd
Quoting Sibi Sankar (2021-04-16 05:03:57) > Use the Qualcomm Mailbox Protocol (QMP) binding to control the load > state resources on SM8350 SoCs and drop deprecated power-domains exposed > by AOSS QMP node. > > Signed-off-by: Sibi Sankar > --- Reviewed-by: Stephen Boyd

Re: [PATCH 09/12] arm64: dts: qcom: sm8150: Use QMP binding to control load state

2021-04-17 Thread Stephen Boyd
Quoting Sibi Sankar (2021-04-16 05:03:55) > Use the Qualcomm Mailbox Protocol (QMP) binding to control the load > state resources on SM8150 SoCs and drop deprecated power-domains exposed > by AOSS QMP node. > > Signed-off-by: Sibi Sankar > --- Reviewed-by: Stephen Boyd

Re: [PATCH 08/12] arm64: dts: qcom: sdm845: Use QMP binding to control load state

2021-04-17 Thread Stephen Boyd
Quoting Sibi Sankar (2021-04-16 05:03:54) > Use the Qualcomm Mailbox Protocol (QMP) binding to control the load > state resources on SDM845 SoCs and drop deprecated power-domains exposed > by AOSS QMP node. > > Signed-off-by: Sibi Sankar > --- Reviewed-by: Stephen Boyd

Re: [PATCH 07/12] arm64: dts: qcom: sc7280: Use QMP binding to control load state

2021-04-17 Thread Stephen Boyd
Quoting Sibi Sankar (2021-04-16 05:03:53) > Use the Qualcomm Mailbox Protocol (QMP) binding to control the load > state resources on SC7280 SoCs and drop deprecated power-domains exposed > by AOSS QMP node. > > Signed-off-by: Sibi Sankar > --- Reviewed-by: Stephen Boyd

Re: [PATCH 06/12] arm64: dts: qcom: sc7180: Use QMP binding to control load state

2021-04-17 Thread Stephen Boyd
Quoting Sibi Sankar (2021-04-16 05:03:52) > Use the Qualcomm Mailbox Protocol (QMP) binding to control the load > state resources on SC7180 SoCs and drop deprecated power-domains exposed > by AOSS QMP node. > > Signed-off-by: Sibi Sankar > --- Reviewed-by: Stephen Boyd

Re: [PATCH 02/12] soc: qcom: aoss: Drop power domain support

2021-04-17 Thread Stephen Boyd
Quoting Sibi Sankar (2021-04-16 05:03:48) > The load state resources are expected to follow the life cycle of the > remote processor it tracks. However, modeling load state resources as > power-domains result in them getting turned off during system suspend > and thereby falling out of sync with th

Re: [PATCH V2 5/9] platform/x86: intel_pmc_core: Get LPM requirements for Tiger Lake

2021-04-17 Thread David E. Box
On Sat, 2021-04-17 at 10:52 +0200, Hans de Goede wrote: > Hi David, > > On 4/17/21 5:12 AM, David E. Box wrote: > > From: Gayatri Kammela > > > > Platforms that support low power modes (LPM) such as Tiger Lake > > maintain > > requirements for each sub-state that a readable in the PMC. > > Howev

Re: [PATCH 03/12] dt-bindings: remoteproc: qcom: pas: Add QMP bindings

2021-04-17 Thread Stephen Boyd
Quoting Sibi Sankar (2021-04-16 05:03:49) > Add Qualcomm Mailbox Protocol (QMP) binding to replace the power domains > exposed by the AOSS QMP node. > > Signed-off-by: Sibi Sankar > --- Reviewed-by: Stephen Boyd

Re: [PATCH 04/12] dt-bindings: remoteproc: qcom: Add QMP bindings

2021-04-17 Thread Stephen Boyd
Quoting Sibi Sankar (2021-04-16 05:03:50) > Add Qualcomm Mailbox Protocol (QMP) binding to replace the power domains > exposed by the AOSS QMP node. > > Signed-off-by: Sibi Sankar > --- Reviewed-by: Stephen Boyd

Re: [PATCH 01/12] dt-bindings: soc: qcom: aoss: Drop power-domain bindings

2021-04-17 Thread Stephen Boyd
Quoting Sibi Sankar (2021-04-16 05:03:47) > Drop power-domain bindings exposed by AOSS QMP node. > > Signed-off-by: Sibi Sankar > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces

2021-04-17 Thread Stephen Boyd
Quoting Jessica Yu (2021-04-15 06:04:35) > +++ Stephen Boyd [09/04/21 18:52 -0700]: > >diff --git a/include/linux/module.h b/include/linux/module.h > >index 59f094fa6f74..4bf869f6c944 100644 > >--- a/include/linux/module.h > >+++ b/include/linux/module.h > >@@ -11,6 +11,7 @@ > > > > #include > > #

[GIT PULL] SCSI fixes for 5.12-rc6

2021-04-17 Thread James Bottomley
This libsas fix is for a problem that occurs when trying to change the cache type of an ATA device and the libiscsi one is a regression fix from this merge window. git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Jolly Shah (1): scsi: libsas: R

Re: [PATCH V2 5/9] platform/x86: intel_pmc_core: Get LPM requirements for Tiger Lake

2021-04-17 Thread David E. Box
On Sat, 2021-04-17 at 11:00 +0200, Hans de Goede wrote: > Hi, > > On 4/17/21 5:12 AM, David E. Box wrote: > > From: Gayatri Kammela > > > > Platforms that support low power modes (LPM) such as Tiger Lake > > maintain > > requirements for each sub-state that a readable in the PMC. > > However, un

Re: PROBLEM: DoS Attack on Fragment Cache

2021-04-17 Thread Keyu Man
Willy's words make sense to me and I agree that the existing fragments should be evicted when the new one comes in and the cache is full. Though the attacker can still leverage this to flush the victim's cache, as mentioned previously, since fragments are likely to be assembled in a very short time

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-17 Thread Joel Fernandes
On Tue, Apr 06, 2021 at 10:16:12AM -0400, Tejun Heo wrote: > Hello, > > On Mon, Apr 05, 2021 at 02:46:09PM -0400, Joel Fernandes wrote: > > Yeah, its at http://lore.kernel.org/r/20200822030155.ga414...@google.com > > as mentioned above, let me know if you need any more details about > > usecase. >

Re: PROBLEM: DoS Attack on Fragment Cache

2021-04-17 Thread Matt Corallo
See-also "[PATCH] Reduce IP_FRAG_TIME fragment-reassembly timeout to 1s, from 30s" (and the two resends of it) - given the size of the default cache (4MB) and the time that it takes before we flush the cache (30 seconds) you only need about 1Mbps of fragments to hit this issue. While DoS attacks

Re: [PATCH] media: atomisp: silence "dubious: !x | !y" warning

2021-04-17 Thread Ashish Kalra
On Sat, Apr 17, 2021 at 08:56:13PM +0200, Mauro Carvalho Chehab wrote: > Em Sat, 17 Apr 2021 21:06:27 +0530 > Ashish Kalra escreveu: > > > Upon running sparse, "warning: dubious: !x | !y" is brought to notice > > for this file. Logical and bitwise OR are basically the same in this > > context so

Re: [PATCH] media: atomisp: silence "dubious: !x | !y" warning

2021-04-17 Thread Ashish Kalra
On Sat, Apr 17, 2021 at 09:31:32PM +, David Laight wrote: > From: Mauro Carvalho Chehab > > Sent: 17 April 2021 19:56 > > > > Em Sat, 17 Apr 2021 21:06:27 +0530 > > Ashish Kalra escreveu: > > > > > Upon running sparse, "warning: dubious: !x | !y" is brought to notice > > > for this file. Lo

[tip:timers/core] BUILD SUCCESS 2d036dfa5f10df9782f5278fc591d79d283c1fad

2021-04-17 Thread kernel test robot
allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a003-20210417 x86_64 randconfig-a002-20210417 x86_64

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Al Viro
On Sat, Apr 17, 2021 at 03:11:49PM -0700, Linus Torvalds wrote: > On Sat, Apr 17, 2021 at 1:35 PM Al Viro wrote: > > > > No, wait - we have non-NULL buf->prev_reclen, so we'll hit > > with buf->error completely ignored. Nevermind. > > Yeah, I'm pretty sure I even tested that -EINTR case at one p

[PATCH] crypto: camellia: drop duplicate "depends on CRYPTO"

2021-04-17 Thread Randy Dunlap
All 5 CAMELLIA crypto driver Kconfig symbols have a duplicate "depends on CRYPTO" line but they are inside an "if CRYPTO"/"endif # if CRYPTO" block, so drop the duplicate "depends" lines. These 5 symbols still depend on CRYPTO. Fixes: 584fffc8b196 ("[CRYPTO] kconfig: Ordering cleanup") Fixes: 0b9

[PATCH 2/3] rtc: pcf8523: add alarm support

2021-04-17 Thread Alexandre Belloni
Alarm support requires unconditionally disabling clock out because it is using the int1 pin. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 181 +- 1 file changed, 180 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf8523.c b/dri

[PATCH 3/3] rtc: pcf8523: report oscillator failures

2021-04-17 Thread Alexandre Belloni
Report oscillator failures and invalid date/time on RTC_VL_READ. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index feadab8e3bd3..bb23379bbfc

[PATCH 1/3] rtc: pcf8523: remove useless define

2021-04-17 Thread Alexandre Belloni
Drop DRIVER_NAME as it is only used once Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index 5e1e7b2a8c9a..fe3ab41d8326 100644 --- a/drivers/rtc/rtc-pcf85

Re: [PATCH 05/15] x86: Implement function_nocfi

2021-04-17 Thread Andy Lutomirski
On Sat, Apr 17, 2021 at 4:53 PM Thomas Gleixner wrote: > > On Sat, Apr 17 2021 at 16:19, Andy Lutomirski wrote: > > On Fri, Apr 16, 2021 at 4:40 PM Kees Cook wrote: > >> Okay, you're saying you want __builtin_gimme_body_p() to be a constant > >> expression for the compiler, not inline asm? > > >

Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang

2021-04-17 Thread Joe Perches
On Sat, 2021-04-17 at 14:30 -0400, Jes Sorensen wrote: > On 4/17/21 1:52 PM, Kalle Valo wrote: > > "Gustavo A. R. Silva" wrote: > > > > > In preparation to enable -Wimplicit-fallthrough for Clang, fix > > > multiple warnings by replacing /* fall through */ comments with > > > the new pseudo-keywo

Re: mmu.c:undefined reference to `patch__hash_page_A0'

2021-04-17 Thread Randy Dunlap
HI-- I no longer see this build error. However: On 2/27/21 2:24 AM, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 3fb6d0e00efc958d01c2f109c8453033a2d96796 > commit: 259149cf7c3c6195e6199e045ca988c31d081cab powerpc/32s: On

[PATCH v2 3/3] rtc: rtc_update_irq_enable: rework UIE emulation

2021-04-17 Thread Alexandre Belloni
Now that the core is aware of whether alarms are available, it is possible to decide whether UIE emulation is required before actually trying to set the alarm. This greatly simplifies rtc_update_irq_enable because there is now only one error value to track and is not relying on the return value of

[PATCH v2 2/3] rtc: ds1307: remove flags

2021-04-17 Thread Alexandre Belloni
flags is now unused, drop it. Tested-by: Łukasz Stelmach Reviewed-by: Łukasz Stelmach Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1307.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 76d67c419f7d..089509d0a3a0 100644 -

[PATCH v2 1/3] rtc: ds1307: replace HAS_ALARM by RTC_FEATURE_ALARM

2021-04-17 Thread Alexandre Belloni
The core now has RTC_FEATURE_ALARM for the driver to indicate whether alarms are available. Use that instead of HAS_ALARM to ensure the alarm callbacks are not even called. Tested-by: Łukasz Stelmach Reviewed-by: Łukasz Stelmach Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1307.c | 4

[tip:locking/urgent] BUILD SUCCESS 84a24bf8c52e66b7ac89ada5e3cfbe72d65c1896

2021-04-17 Thread kernel test robot
-20210417 x86_64 randconfig-a002-20210417 x86_64 randconfig-a005-20210417 x86_64 randconfig-a001-20210417 x86_64 randconfig-a006-20210417 x86_64 randconfig-a004-20210417 i386 randconfig-a003-20210417 i386

[tip:sched/core] BUILD SUCCESS 9406415f46f6127fd31bb66f0260f7a61a8d2786

2021-04-17 Thread kernel test robot
allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a003-20210417 i386 randconfig-a006-20210417 i386 randconfig-a001-20210417 i386

Re: [PATCH 05/15] x86: Implement function_nocfi

2021-04-17 Thread Thomas Gleixner
On Sat, Apr 17 2021 at 16:19, Andy Lutomirski wrote: > On Fri, Apr 16, 2021 at 4:40 PM Kees Cook wrote: >> Okay, you're saying you want __builtin_gimme_body_p() to be a constant >> expression for the compiler, not inline asm? > > Yes. > > I admit that, in the trivial case where the asm code is *no

[PATCH] imx-sc: remove .read_alarm

2021-04-17 Thread Alexandre Belloni
The RTC core properly handles RTC without .read_alarm and doesn't use it to set alarms. .read_alarm can be safely dropped. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-imx-sc.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/rtc/rtc-imx-sc.c b/drivers/rtc/rtc-imx-

Re: [PATCH v8 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-17 Thread Paul E. McKenney
On Sat, Apr 17, 2021 at 02:47:18PM +0200, Thomas Gleixner wrote: > On Tue, Apr 13 2021 at 21:36, Paul E. McKenney wrote: > > Bah, hit send too quick. > > > + cpumask_clear(&cpus_ahead); > > + cpumask_clear(&cpus_behind); > > + preempt_disable(); > > Daft. Would migrate_disable() be bette

[git pull] drm/vmwgfx fixes for 5.12-rc8

2021-04-17 Thread Dave Airlie
Hi Linus, Back from holidays and this was in the cracks (Zack forgot to cc Daniel/lists), I've just piled it onto drm fixes. It contains two regression fixes for vmwgfx, one due to a refactor which meant locks were being used before initialisation, and the other in fixing up some warnings from th

Re: [PATCH v8 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-17 Thread Paul E. McKenney
On Sat, Apr 17, 2021 at 02:28:22PM +0200, Thomas Gleixner wrote: > On Tue, Apr 13 2021 at 21:36, Paul E. McKenney wrote: > > diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c > > index 1fc0962c89c0..97eeaf164296 100644 > > --- a/arch/x86/kernel/kvmclock.c > > +++ b/arch/x86/kerne

Re: [PATCH v8 clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-04-17 Thread Paul E. McKenney
On Sun, Apr 18, 2021 at 01:15:26AM +0200, Thomas Gleixner wrote: > On Sat, Apr 17 2021 at 15:54, Paul E. McKenney wrote: > > On Sat, Apr 17, 2021 at 02:24:23PM +0200, Thomas Gleixner wrote: > >> I so wish we could just delete all of this horror instead of making it > >> more horrible. > > > > Revis

drivers/md/dm-log-writes.c:452:12: warning: stack frame size of 1184 bytes in function 'log_writes_kthread'

2021-04-17 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 194cf4825638256e9afe1d360831aa5379b3517a commit: 309dca309fc39a9e3c31b916393b74bd174fd74e block: store a block_device pointer in struct bio date: 3 months ago config: powerpc64-randconfig-r032-20210418 (at

Re: [PATCH 05/15] x86: Implement function_nocfi

2021-04-17 Thread Andy Lutomirski
On Fri, Apr 16, 2021 at 4:40 PM Kees Cook wrote: > > > 1. I defined a function in asm. I want to tell clang that this > > function is defined in asm, and for clang to behave accordingly: > > > > .globl func > > func: > > ; do stuff > > > > later: > > > > extern void func(void) [something here];

Re: [PATCH v8 clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-04-17 Thread Thomas Gleixner
On Sat, Apr 17 2021 at 15:54, Paul E. McKenney wrote: > On Sat, Apr 17, 2021 at 02:24:23PM +0200, Thomas Gleixner wrote: >> I so wish we could just delete all of this horror instead of making it >> more horrible. > > Revisit deleting it in five years if there are no issues, whatever > "issue" might

Re: [PATCH] Fix set apic mode from x2apic enabled bit patch

2021-04-17 Thread Thomas Gleixner
Mike! On Sun, Apr 18 2021 at 00:39, Thomas Gleixner wrote: > If you can't come up with something sensible anytime soon before the > merge window opens then I'm simply going to revert 41e2da9b5e67 and you > can try again for the next cycle. so I just figured out that Boris wasted his time once mor

Re: build failure of malta_qemu_32r6_defconfig

2021-04-17 Thread Sudip Mukherjee
Hi Thomas, On Fri, Apr 9, 2021 at 1:17 PM Thomas Bogendoerfer wrote: > > On Thu, Apr 08, 2021 at 09:42:11AM +0800, YunQiang Su wrote: > > Sudip Mukherjee 于2021年4月8日周四 上午2:26写道: > > > > > > Hi Thomas, > > > > > > I was building v5.10.28 with malta_qemu_32r6_defconfig and noticed that > > > it fai

Re: [PATCH v8 clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-04-17 Thread Paul E. McKenney
On Sat, Apr 17, 2021 at 02:24:23PM +0200, Thomas Gleixner wrote: > On Tue, Apr 13 2021 at 21:35, Paul E. McKenney wrote: > > #define WATCHDOG_INTERVAL (HZ >> 1) > > #define WATCHDOG_THRESHOLD (NSEC_PER_SEC >> 4) > > +#define WATCHDOG_MAX_SKEW (NSEC_PER_SEC >> 6) > > That's ~15ms which is a tad l

Re: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-17 Thread Matthew Wilcox
On Sat, Apr 17, 2021 at 09:18:57PM +, David Laight wrote: > Ugly as well. Thank you for expressing your opinion. Again.

Re: [PATCH] Fix set apic mode from x2apic enabled bit patch

2021-04-17 Thread Thomas Gleixner
Mike! On Thu, Apr 15 2021 at 17:06, Mike Travis wrote: I'm slowly getting tired of the fact that every patch coming from you fails to comply with the minimal requirements of the documented procedures. $subject: [PATCH] Fix set apic mode from x2apic enabled bit patch Documentation clearly states

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Linus Torvalds
On Sat, Apr 17, 2021 at 1:35 PM Al Viro wrote: > > No, wait - we have non-NULL buf->prev_reclen, so we'll hit > with buf->error completely ignored. Nevermind. Yeah, I'm pretty sure I even tested that -EINTR case at one point. Of course, it could easily have gotten broken again, so that's not a

Re: [PATCH] block: fix io hung by block throttle

2021-04-17 Thread Junxiao Bi
On 4/17/21 3:10 AM, Hillf Danton wrote: --- a/block/blk-rq-qos.c +++ b/block/blk-rq-qos.c @@ -260,19 +260,17 @@ void rq_qos_wait(struct rq_wait *rqw, void *private_data, .cb = acquire_inflight_cb, .private_data = private_data, }; - bool has_sleeper;

RE: [PATCH] media: atomisp: silence "dubious: !x | !y" warning

2021-04-17 Thread David Laight
From: Mauro Carvalho Chehab > Sent: 17 April 2021 19:56 > > Em Sat, 17 Apr 2021 21:06:27 +0530 > Ashish Kalra escreveu: > > > Upon running sparse, "warning: dubious: !x | !y" is brought to notice > > for this file. Logical and bitwise OR are basically the same in this > > context so it doesn't

Re: [PATCH 2/2] mm: Indicate pfmemalloc pages in compound_head

2021-04-17 Thread Matthew Wilcox
On Sat, Apr 17, 2021 at 09:13:45PM +, David Laight wrote: > > struct {/* page_pool used by netstack */ > > - /** > > -* @dma_addr: might require a 64-bit value on > > -* 32-bit architectures. > > -

RE: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-17 Thread David Laight
From: Matthew Wilcox > Sent: 17 April 2021 03:45 > > Replacement patch to fix compiler warning. ... > static inline dma_addr_t page_pool_get_dma_addr(struct page *page) > { > - return page->dma_addr; > + dma_addr_t ret = page->dma_addr[0]; > + if (sizeof(dma_addr_t) > sizeof(unsigne

RE: [PATCH 2/2] mm: Indicate pfmemalloc pages in compound_head

2021-04-17 Thread David Laight
From: Matthew Wilcox (Oracle) > Sent: 17 April 2021 00:07 > > The net page_pool wants to use a magic value to identify page pool pages. > The best place to put it is in the first word where it can be clearly a > non-pointer value. That means shifting dma_addr up to alias with ->index, > which me

Re: [PATCH 00/13] [RFC] Rust support

2021-04-17 Thread Richard Weinberger
On Thu, Apr 15, 2021 at 2:41 AM wrote: > Regarding compilers, we support Clang-built kernels as well as > `LLVM=1` builds where possible (i.e. as long as supported by > the ClangBuiltLinux project). We also maintain some configurations > of GCC-built kernels working, but they are not intended to b

Re: [PATCH -next] PCI: remove unused variable rdev

2021-04-17 Thread Chaitanya Kulkarni
On 4/17/21 04:44, Bixuan Cui wrote: > Fix the build warning: > > drivers/pci/quirks.c: In function ‘quirk_amd_nvme_fixup’: > drivers/pci/quirks.c:312:18: warning: unused variable ‘rdev’ > [-Wunused-variable] > struct pci_dev *rdev; > ^~~~ > > Fixes: 9597624ef606 ('nvme: put som

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Al Viro
On Sat, Apr 17, 2021 at 08:30:42PM +, Al Viro wrote: > and that thing is still there. However, it does *NOT* do what it might > appear to be doing; it ends up with getdents() returning -EINVAL instead. > What we need is > buf->error = -EINTR; > in addition to that return

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Al Viro
[tytso Cc'd] On Sat, Apr 17, 2021 at 06:09:44PM +, Al Viro wrote: > > Al - fairly trivial patch applied, comments? > > Should be fine... FWIW, I've a patch in the same area, making those suckers > return bool. Seeing that they are only ever called via dir_emit(), > dir_emit_dot() > and di

Re: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-17 Thread Matthew Wilcox
On Sat, Apr 17, 2021 at 09:32:06PM +0300, Ilias Apalodimas wrote: > > +static inline void page_pool_set_dma_addr(struct page *page, dma_addr_t > > addr) > > +{ > > + page->dma_addr[0] = addr; > > + if (sizeof(dma_addr_t) > sizeof(unsigned long)) > > + page->dma_addr[1] = addr >> 16 >

PPC_FPU, ALTIVEC: enable_kernel_fp, put_vr, get_vr

2021-04-17 Thread Randy Dunlap
Hi, kernel test robot reports: >> drivers/cpufreq/pmac32-cpufreq.c:262:2: error: implicit declaration of >> function 'enable_kernel_fp' [-Werror,-Wimplicit-function-declaration] enable_kernel_fp(); ^ when # CONFIG_PPC_FPU is not set CONFIG_ALTIVEC=y I see at least one oth

Re: [PATCH 3/3] i2c: mediatek: Use scl_int_delay_ns to compensate clock-stretching

2021-04-17 Thread Wolfram Sang
On Sat, Apr 17, 2021 at 02:46:52PM +0800, Qii Wang wrote: > The parameters of tSU,STA/tHD,STA/tSU,STOP maybe out of spec due > to device clock-stretch or circuit loss, we could get a suitable > scl_int_delay_ns from i2c_timings to compensate these parameters > to meet the spec via EXT_CONF register

Re: [PATCH 2/3] i2c: mediatek: Fix wrong dma sync flag

2021-04-17 Thread Wolfram Sang
On Sat, Apr 17, 2021 at 02:46:51PM +0800, Qii Wang wrote: > The right flag is apdma_sync when apdma remove hand-shake signel. > > Signed-off-by: Qii Wang Added: Fixes: 05f6f7271a38 ("i2c: mediatek: Fix apdma and i2c hand-shake timeout") and applied to for-next, thanks! signature.asc Descrip

Re: [PATCH 1/3] i2c: mediatek: Fix send master code at more than 1MHz

2021-04-17 Thread Wolfram Sang
On Sat, Apr 17, 2021 at 02:46:50PM +0800, Qii Wang wrote: > There are some omissions in the previous patch about replacing > I2C_MAX_FAST_MODE__FREQ with I2C_MAX_FAST_MODE_PLUS_FREQ and > need to fix it. > > Fixes: b44658e755b5("i2c: mediatek: Send i2c master code at more than 1MHz") > Signed-off-

[PATCH] capabilities: require CAP_SETFCAP to map uid 0 (v3.2)

2021-04-17 Thread Serge E. Hallyn
A process running as uid 0 but without cap_setfcap currently can simply unshare a new user namespace with uid 0 mapped to 0. While this task will not have new capabilities against the parent namespace, there is a loophole due to the way namespaced file capabilities work. File capabilities valid i

  1   2   3   4   >