[PATCH] ceph: minor coding style tweaks

Fixed some coding style issues, improve code reading. 1. Move the pointer location 2. Move brace position 3. Alignment to open parenthesis This patch adds whitespace to clearly separate the parameters. Signed-off-by: Zhiyuan Dai --- fs/ceph/addr.c | 3 +-- fs/ceph/cache.c | 14 +

Re: [PATCH v13 2/4] phy: Add ethernet serdes configuration option

On 29-01-21, 14:07, Steen Hegelund wrote: > Provide a new ethernet phy configuration structure, that > allow PHYs used for ethernet to be configured with > speed, media type and clock information. This lgtm, Kishon ? > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund > Reviewed-by

[PATCH] fscache: rectify minor kernel-doc issues

The command './scripts/kernel-doc -none include/linux/fscache.h' reports some minor mismatches of the kernel-doc and function signature, which are easily resolved. Rectify the kernel-doc, such that no issues remain for fscache.h. Signed-off-by: Lukas Bulwahn --- applies cleanly on current master

Re: [PATCH v6 3/7] phy: phy-hi3670-usb3: move driver from staging into phy

On 27-01-21, 20:08, Mauro Carvalho Chehab wrote: > The phy USB3 driver for Hisilicon 970 (hi3670) is ready > for mainstream. Mode it from staging into the main driver's > phy/ directory. I guess Greg will pick this, so: Acked-By: Vinod Koul -- ~Vinod

Re: [Linaro-mm-sig] [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error

Am 03.02.21 um 21:20 schrieb Suren Baghdasaryan: [SNIP] If there is a reason to set this flag other than historical use of carveout memory then we wanted to catch such cases and fix the drivers that moved to using dmabuf heaps. However maybe there are other reasons and if so I would be very grate

Re: [PATCH v4 0/5] Promote Hikey 970 USB phy out of staging

On 26-01-21, 18:49, Greg Kroah-Hartman wrote: > On Tue, Jan 19, 2021 at 11:44:38AM +0100, Mauro Carvalho Chehab wrote: > > Hi Vinod/Rob, > > > > This series moves the Hikey 970 USB PHY driver out of staging. > > > > Patches 1 to 4 contain the fixes from staging. Patch 5 moves the > > driver from

[PATCH] scsi: isci: Remove redundant initialization of variable 'status'

This patch removes unneeded return variables. It fixes the following warning detected by coccinelle: ./drivers/scsi/isci/request.c:1483:17-23: Unneeded variable: "status". Return "SCI_SUCCESS" on line 1503 ./drivers/scsi/isci/request.c:2157:17-23: Unneeded variable: "status". Return "SCI_SUCCESS" o

[PATCH v2 2/2] drivers/clocksource: Fixup csky,mptimer compile error with CPU_CK610

From: Guo Ren The timer-mp-csky.c only could support CPU_CK860 and it will compile error with CPU_CK610. It has been selected in arch/csky/Kconfig. Signed-off-by: Guo Ren Cc: Daniel Lezcano Cc: Thomas Gleixner Cc: Marc Zyngier --- drivers/clocksource/Kconfig | 2 +- 1 file changed, 1 inser

[PATCH v2 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU_CK610

From: Guo Ren The irq-csky-mpintc.c only could support CPU_CK860 and it will compile error with CPU_CK610. It has beed selected in arch/csky/Kconfig Signed-off-by: Guo Ren Cc: Marc Zyngier --- drivers/irqchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- v2: Drop the str

Re: [PATCH v4 5/5] phy: phy-hi3670-usb3: move driver from staging into phy

On 19-01-21, 11:44, Mauro Carvalho Chehab wrote: > The phy USB3 driver for Hisilicon 970 (hi3670) is ready > for mainstream. Mode it from staging into the main driver's > phy/ directory. Acked-By: Vinod Koul I think it makes sense if Greg applies this as well -- ~Vinod

Re: [PATCH v8 0/2] Kbuild: DWARF v5 support

On Wed, Feb 3, 2021 at 10:58 PM Sedat Dilek wrote: > > I guess I need to test harder to get a Tested-by credit :-)? You're right Sedat, I'm sorry. Your testing is invaluable; thank you for taking the time to help and credit is a powerful incentive. It can be difficult to know whether to carry f

Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names

On Thu, Feb 04, 2021 at 08:58:20AM +0200, Tony Lindgren wrote: > * Drew Fustini [210127 02:04]: > > Based on linux-gpio discussion [1], it is best practice to make the > > gpio-line-names unique. Generic names like "[ethernet]" are replaced > > with the name of the unique signal on the AM3358 SoC

[PATCH net-next] xfrm: Return the correct errno code

When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. Signed-off-by: Zheng Yongjun --- net/xfrm/xfrm_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index d0c32a8fcc4a..ad63a6c77edd 100644 --- a/net/xfrm/xfr

Re: [PATCH V7 6/6] of: unittest: Statically apply overlays using fdtoverlay

On 03-02-21, 19:54, Rob Herring wrote: > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index b00855b247e0..886d2e6c58f0 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -66,6 +66,9 @@ multi-used := $(multi-used-y) $(multi-used-m) > real-obj-y := $(foreach m, $(o

[PATCH v2] firewire: convert sysfs sprintf/snprintf family to sysfs_emit

Fix the following coccicheck warning: ./drivers/firewire/core-device.c:375:8-16: WARNING: use scnprintf or sprintf. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- Changes in v2: - Modified print format. drivers/firewire/core-device.c | 6 ++ 1 file changed, 2 insertions(+), 4

Re: [PATCH] ath11k: remove h from printk format specifier

t...@redhat.com wrote: > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is already done and %hx and %hhx is useless > so do not encourag

Re: linux-next: build warning after merge of the drivers-x86 tree

Hi Stephen, Andy, On 2/4/21 6:13 AM, Stephen Rothwell wrote: > Hi all, > > After merging the drivers-x86 tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > drivers/platform/x86/intel_scu_wdt.c: In function 'register_mid_wdt': > drivers/platform/x86/intel_scu_wdt.c:

Re: [PATCH] ath10k: remove h from printk format specifier

t...@redhat.com wrote: > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is already done and %hx and %hhx is useless > so do not encourag

[PATCH net-next] net: sched: Return the correct errno code

When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. Signed-off-by: Zheng Yongjun --- net/sched/em_nbyte.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/em_nbyte.c b/net/sched/em_nbyte.c index 2c1192a2ee5e..a83b237cbeb0 100644 --- a/net/sched/em

Re: [PATCH] kprobes: Warn if the kprobe is reregistered

On 2/3/21 8:29 PM, Masami Hiramatsu wrote: Warn if the kprobe is reregistered, since there must be a software bug (actively used resource must not be re-registered) and caller must be fixed. Signed-off-by: Masami Hiramatsu Acked-by: Ananth N Mavinakayanahalli

[PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

When a change of memory map occurs, the hardware resources are destroyed and then re-created again with the new memory map. In such case, we need to restore the hardware available and used indices. The driver failed to restore the used index which is added here. Also, since the driver also fails t

[PATCH] scsi: lpfc: Remove unneeded return variable

This patch removes unneeded return variables, using only '1' instead. It fixes the following warning detected by coccinelle: Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/scsi/lpfc/lpfc_sli.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/l

Re: [PATCH 1/2] quota: Add mountpath based quota support

On Tue, Feb 02, 2021 at 07:02:41PM +0100, Jan Kara wrote: > Hum, let me think out loud. The path we pass to Q_QUOTAON is a path to > quota file - unless the filesystem stores quota in hidden files in which > case this argument is just ignored. You're right we could require that > specifically for Q

Re: [PATCH] ceph: minor coding style tweaks

On Thu, 2021-02-04 at 14:32 +0800, Zhiyuan Dai wrote: > Fixed some coding style issues, improve code reading. Might describe the patch does 3 things: o Move the pointer location struct foo* bar; -> struct foo *bar; o Move brace position from struct foo { to str

[PATCH v4 1/1] mm/highmem: Remove deprecated kmap_atomic

From: Ira Weiny kmap_atomic() is being deprecated in favor of kmap_local_page(). Replace the uses of kmap_atomic() within the highmem code. On profiling clear_huge_page() using ftrace an improvement of 62% was observed on the below setup. Setup:- Below data has been collected on Qualcomm's SM7

[PATCH v4 0/1] mm/highmem: Remove deprecated kmap_atomic

Updated the commit text. Changelog: Added my test data to Ira's v3 patch. Ira Weiny (1): mm/highmem: Remove deprecated kmap_atomic include/linux/highmem.h | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) -- 2.17.1

Re: [RFC PATCH v0] mm/slub: Let number of online CPUs determine the slub page order

On Wed, 3 Feb 2021 at 12:10, Bharata B Rao wrote: > > On Wed, Jan 27, 2021 at 12:04:01PM +0100, Vlastimil Babka wrote: > > On 1/27/21 10:10 AM, Christoph Lameter wrote: > > > On Tue, 26 Jan 2021, Will Deacon wrote: > > > > > >> > Hm, but booting the secondaries is just a software (kernel) action?

AW: [PATCH v1] leds: lp50xx: add setting of default intensity from DT

Helo Pavel, > > > Yes, sounds reasonable. Could we get default intensity of 100% on all > > > channels if nothing else is specified? > > > > > > Or maybe simply "if intensity is not specified, start with 100%, and > > > use explicit =0 if other color is expected". > > > > > Mh, if someone is alrea

[PATCH] x86: Remove HPET_EMULATE_RTC depends on RTC

The RTC config option was removed in commit f52ef24be21a ("rtc/alpha: remove legacy rtc driver") Signed-off-by: Anand K Mistry --- arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 21f851179ff0..37775478d86f 100644 ---

[PATCH net-next] net: Return the correct errno code

When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. Signed-off-by: Zheng Yongjun --- net/mpls/af_mpls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index f2868a8a50c3..7e73611c48dd 100644 --- a/net/mpls/af_mpls.c

AW: [PATCH v1] leds: lp50xx: add setting of default intensity from DT

Hello Pavel, hello Marek > > Is the property default-intensity documented in DT bindings? I updated the documentation in leds-lp50xx.yaml. Is it this what you mean? > > Wouldn't it be better if the property was used in the multi-led node > > instead of the channel node? I.e. > > multi-led@3 {

Re: [PATCH RFC v1 2/6] swiotlb: convert variables to arrays

On Wed, Feb 03, 2021 at 03:37:05PM -0800, Dongli Zhang wrote: > This patch converts several swiotlb related variables to arrays, in > order to maintain stat/status for different swiotlb buffers. Here are > variables involved: > > - io_tlb_start and io_tlb_end > - io_tlb_nslabs and io_tlb_used > -

[PATCH net-next] dccp: Return the correct errno code

When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. Signed-off-by: Zheng Yongjun --- net/dccp/feat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dccp/feat.c b/net/dccp/feat.c index 788dd629c420..4cb813bee7b4 100644 --- a/net/dccp/feat.c +++ b/net/d

Re: [PATCH v2] x86/fault: Send a SIGBUS to user process always for hwpoison page access.

Hi Aili, On Mon, Feb 01, 2021 at 04:17:49PM +0800, Aili Yao wrote: > When one page is already hwpoisoned by AO action, process may not be > killed, the process mapping this page may make a syscall include this > page and result to trigger a VM_FAULT_HWPOISON fault, if it's in kernel > mode it may

[PATCH net-next] ipv6: Return the correct errno code

When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. Signed-off-by: Zheng Yongjun --- net/ipv6/addrconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 8b6eb384bac7..347b95bc00fd 100644 --- a/net/ipv6/addrco

[PATCH net-next] net: ipv4: Return the correct errno code

When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. Signed-off-by: Zheng Yongjun --- net/ipv4/devinet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 123a6d39438f..fa586e915621 100644 --- a/net/ipv4/devinet.c

[PATCH] scsi: ipr: Remove unneeded return variable

This patch removes unneeded return variables, using only '0' instead. It fixes the following warning detected by coccinelle: ./drivers/scsi/ipr.c:9508:5-7: Unneeded variable: "rc". Return "0" on line 9524 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/scsi/ipr.c | 3 +-- 1 file cha

Re: Kernel version numbers after 4.9.255 and 4.4.255

On 04. 02. 21, 7:20, Greg Kroah-Hartman wrote: On Thu, Feb 04, 2021 at 05:59:42AM +, Jari Ruusu wrote: Greg, I hope that your linux kernel release scripts are implemented in a way that understands that PATCHLEVEL= and SUBLEVEL= numbers in top-level linux Makefile are encoded as 8-bit numbers

Re: [v6 PATCH 03/11] mm: vmscan: use shrinker_rwsem to protect shrinker_maps allocation

On 03.02.2021 20:20, Yang Shi wrote: > Since memcg_shrinker_map_size just can be changed under holding shrinker_rwsem > exclusively, the read side can be protected by holding read lock, so it sounds > superfluous to have a dedicated mutex. > > Kirill Tkhai suggested use write lock since: > > *

[PATCH] crypto: picoxcell - convert sysfs sprintf/snprintf family to sysfs_emit

Fix the following coccicheck warning: ./drivers/crypto/picoxcell_crypto.c:1201:8-16: WARNING: use scnprintf or sprintf. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/crypto/picoxcell_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto

Re: [v6 PATCH 02/11] mm: vmscan: consolidate shrinker_maps handling code

On 03.02.2021 20:20, Yang Shi wrote: > The shrinker map management is not purely memcg specific, it is at the > intersection > between memory cgroup and shrinkers. It's allocation and assignment of a > structure, > and the only memcg bit is the map is being stored in a memcg structure. So > mo

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

On Thu, Jan 14, 2021 at 12:07 AM Nathan Chancellor wrote: > > On Wed, Jan 13, 2021 at 02:38:27PM -0800, Andrii Nakryiko wrote: > > Hm.. Just saw Linus proposing using $(error-if) in Kconfig for an > > unrelated issue ([0]). If we can make this work, then it would catch > > such issue early on, yet

Re: [v6 PATCH 01/11] mm: vmscan: use nid from shrink_control for tracepoint

On 03.02.2021 20:20, Yang Shi wrote: > The tracepoint's nid should show what node the shrink happens on, the start > tracepoint > uses nid from shrinkctl, but the nid might be set to 0 before end tracepoint > if the > shrinker is not NUMA aware, so the traceing log may show the shrink happens >

Re: [PATCH] add chan->cl check in mbox_chan_received_data()

Oh, I see, thank you 2021-02-01 14:28 GMT+08:00, Jassi Brar : > On Thu, Jan 7, 2021 at 5:53 AM haidong yao wrote: >> >> Hi Jassi Brar >> >> Thank you very much for your reply. >> >> Look at the function sprd_mbox_outbox_isr . >> >> Chan is !NULL. >> >> chan->cl is NULL when the client driver not

Re: [PATCH] vdpa/mlx5: Restore the hardware used index after change map

On Wed, Feb 03, 2021 at 12:33:26PM -0800, Si-Wei Liu wrote: > On Tue, Feb 2, 2021 at 10:48 PM Eli Cohen wrote: > > > > On Tue, Feb 02, 2021 at 09:14:02AM -0800, Si-Wei Liu wrote: > > > On Tue, Feb 2, 2021 at 6:34 AM Eli Cohen wrote: > > > > > > > > When a change of memory map occurs, the hardware

[PATCH] scsi: qla4xxx: Remove unneeded return variable

This patch removes unneeded return variables, using only '0' instead. It fixes the following warning detected by coccinelle: ./drivers/scsi/qla4xxx/ql4_os.c:3642:5-7: Unneeded variable: "rc". Return "0" on line 3741 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/scsi/qla4xxx/ql4_os

Re: [PATCH v2 1/2] platform/chrome: cros_ec: Import Type C control command

Hi Prashant, On Tue, 2 Feb 2021 18:15:37 -0800, Prashant Malani wrote: > This command is used to communicate with the Chrome Embedded Controller > (EC) regarding USB Type C events and state. > > These header updates are included in the latest Chrome OS EC headers [1] > > [1] > https://chromium.g

[PATCH] usb: host: ehci: remove casting dma_alloc_coherent

Remove casting the values returned by dma_alloc_coherent. Signed-off-by: Xu Wang --- drivers/usb/host/ehci-mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-mem.c b/drivers/usb/host/ehci-mem.c index 6361d81272bc..769329032257 100644 --- a/drivers/usb

[rcu:willy-maple 175/202] mm/ksm.c:979 unmerge_and_remove_all_rmap_items() error: uninitialized symbol 'mm'.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git willy-maple head: 7e346d2845b4bd77663394f39fa70456e0084c86 commit: 3fd77bfa4f25fa2e3caec024c69168bf6a0ca8d7 [175/202] mm/ksm: Use maple tree iterators instead of vma linked list config: x86_64-randconfig-m001-20210202

[PATCH v4 2/2] iommu: add Unisoc IOMMU basic driver

From: Chunyan Zhang This IOMMU module can be used by Unisoc's multimedia devices, such as display, Image codec(jpeg) and a few signal processors, including VSP(video), GSP(graphic), ISP(image), and CPP(camera pixel processor), etc. Signed-off-by: Chunyan Zhang --- drivers/iommu/Kconfig |

Re: [PATCH 03/14] cxl/mem: Find device capabilities

On Wed, Feb 03, 2021 at 01:23:31PM -0800, Dan Williams wrote: > > I'd prefer to keep the helpers for now as I do find them helpful, and so far > > nobody else who has touched the code has complained. If you feel strongly, I > > will change it. > > After seeing the options, I think I'd prefer to no

Re: [PATCH] platform/chrome: cros_ec_typec: Decouple partner removal

Hi Prashant, On Tue, 2 Feb 2021 14:40:01 -0800, Prashant Malani wrote: > Currently, we return if there is no partner present when > !PD_CTRL_RESP_ENABLED_CONNECTED, without proceeding further. This ties > partner removal to cable removal, whereas the two should be independent. > > Update the chec

[PATCH v4 1/2] dt-bindings: iommu: add bindings for sprd IOMMU

From: Chunyan Zhang This IOMMU module can be used by Unisoc's multimedia devices, such as display, Image codec(jpeg) and a few signal processors, including VSP(video), GSP(graphic), ISP(image), and CPP(camera pixel processor), etc. Signed-off-by: Chunyan Zhang --- .../devicetree/bindings/iommu

[PATCH v4 0/2] Add Unisoc IOMMU basic driver

From: Chunyan Zhang Changes since v3: * Rebased on iommu/next, and fixed compile error reported by kernel test robot ; * %s/iommu/IOMMU/ properly in the whole patchset. Changes since v2: * Added a WARN and return 0 if an invalid iova was passed to sprd_iommu_iova_to_phys(); * Changed the name

[next] Unable to handle kernel NULL pointer dereference at - pc : gpiodevice_release

While running kselftest gpio mockup test case on qualcomm dragonboard 410c the following kernel crash reported on Linux next tag 20210203. # selftests: gpio: gpio-mockup.sh # 1. Module load tests # 1.1. dynamic allocation of gpio # ./gpio-mockup.sh: line 106: ./gpio-mockup-cdev: No such file or

Re: [PATCH 1/3] kunit: add kunit.filter_glob cmdline option to filter suites

Hi Daniel, url: https://github.com/0day-ci/linux/commits/Daniel-Latypov/kunit-support-running-subsets-of-test-suites-from/20210204-074405 base: 88bb507a74ea7d75fa49edd421eaa710a7d80598 config: x86_64-randconfig-m001-20210202 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If y

[PATCH] crypto: cavium: remove casting dma_alloc_coherent

Remove casting the values returned by dma_alloc_coherent. Signed-off-by: Xu Wang --- drivers/crypto/cavium/cpt/cptvf_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/cavium/cpt/cptvf_main.c b/drivers/crypto/cavium/cpt/cptvf_main.c index f016448e4

Re: [PATCH v15 04/14] KVM: x86: Add #CP support in guest exception dispatch

On Wed, Feb 03, 2021 at 01:46:42PM -0800, Sean Christopherson wrote: > On Wed, Feb 03, 2021, Yang Weijiang wrote: > > Add handling for Control Protection (#CP) exceptions, vector 21, used > > and introduced by Intel's Control-Flow Enforcement Technology (CET). > > relevant CET violation case. See

[PATCH] mmc: cavium: Replace spin_lock_irqsave with spin_lock in hard IRQ

It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context. Signed-off-by: Xiaofei Tan --- drivers/mmc/host/cavium.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/cavium.c b/drivers/mmc/host/cavium.c in

[PATCH v4 2/2] nbd: share exception handling code by goto put_nbd

Replace the following two statements by the statement “goto put_nbd;” nbd_put(nbd); return 0; Signed-off-by: Sun Ke --- drivers/block/nbd.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 3c9b3bf3f4c2..ec

[PATCH v4 1/2] nbd: Fix NULL pointer in flush_workqueue

Open /dev/nbdX first, the config_refs will be 1 and the pointers in nbd_device are still null. Disconnect /dev/nbdX, then reference a null recv_workq. The protection by config_refs in nbd_genl_disconnect is useless. [ 656.366194] BUG: kernel NULL pointer dereference, address: 0020 [

[PATCH v4 0/2] fix a NULL pointer bug and simplify the code

v4: Share exception handling code for if branches and move put_nbd adjustment to a separate patch. v3: Do not use unlock and add put_nbd. v2: Use jump target unlock. Sun Ke (2): nbd: Fix NULL pointer in flush_workqueue nbd: share exception handling code by goto put_nbd drivers/block

Re: [PATCH v5 3/3] PM / devfreq: Add required OPPs support to passive governor

On Thu, Feb 4, 2021 at 10:49 AM Viresh Kumar wrote: > > On 03-02-21, 17:24, Hsin-Yi Wang wrote: > > From: Saravana Kannan > > > > Look at the required OPPs of the "parent" device to determine the OPP that > > is required from the slave device managed by the passive governor. This > > allows havin

Re: [PATCH 1/2] dt-bindings: phy: qcom,qmp: Add SC8180X USB phy

On 20-01-21, 17:43, Bjorn Andersson wrote: > Add compatibles for the Qualcomm QMP PHY binding for the SuperSpeed USB > phys found in the SC8180x platform. Applied, thanks -- ~Vinod

Re: [PATCH 1/2] dt-bindings: phy: qcom,qmp: Add SC8180X UFS to the QMP binding

On 20-01-21, 14:45, Bjorn Andersson wrote: > Add compatible for the SC8180x UFS PHY to the QMP binding. Applied, thanks -- ~Vinod

Re: [PATCH] vdpa/mlx5: Restore the hardware used index after change map

On Wed, Feb 03, 2021 at 12:33:26PM -0800, Si-Wei Liu wrote: > On Tue, Feb 2, 2021 at 10:48 PM Eli Cohen wrote: > > > > On Tue, Feb 02, 2021 at 09:14:02AM -0800, Si-Wei Liu wrote: > > > On Tue, Feb 2, 2021 at 6:34 AM Eli Cohen wrote: > > > > > > > > When a change of memory map occurs, the hardware

[PATCH] net: bridge: mcast: Use ERR_CAST instead of ERR_PTR(PTR_ERR())

Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)). net/bridge/br_multicast.c:1246:9-16: WARNING: ERR_CAST can be used with mp Generated by: scripts/coccinelle/api/err_cast.cocci Signed-off-by: Xu Wang --- net/bridge/br_multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH] firewire: convert sysfs sprintf/snprintf family to sysfs_emit

On Thu, 2021-02-04 at 14:50 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/firewire/core-device.c:375:8-16: WARNING: use scnprintf or > sprintf. [] > diff --git a/drivers/firewire/core-device.c b/drivers/firewire/core-device.c [] > @@ -372,8 +372,7 @@ static ssiz

[rcu:willy-maple 164/202] fs/proc/task_mmu.c:941 show_smaps_rollup() error: uninitialized symbol 'vma_start'.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git willy-maple head: 7e346d2845b4bd77663394f39fa70456e0084c86 commit: c4e6b1dfcb6f997eb870e859ab84ca9f39572eab [164/202] fs/proc/task_mmu: Stop using linked list and highest_vm_end config: x86_64-randconfig-m001-20210202

[PATCH] media: atomisp: Remove unneeded return variable

This patch removes unneeded return variables, using only '0' instead. It fixes the following warning detected by coccinelle: ./drivers/staging/media/atomisp/pci/sh_css_mipi.c:39:5-8: Unneeded variable: "err". Return "0" on line 44 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/stag

[RFC 3/3] dma-contiguous: Type cast MAX_ORDER as unsigned int

Type cast MAX_ORDER as unsigned int to fix the following build warning. In file included from ./include/linux/kernel.h:14, from ./include/asm-generic/bug.h:20, from ./arch/arm64/include/asm/bug.h:26, from ./include/linux/bug.h:5,

[rcu:willy-maple 137/202] mm/mmap.c:1895 mmap_region() error: uninitialized symbol 'next'.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git willy-maple head: 7e346d2845b4bd77663394f39fa70456e0084c86 commit: 059c8a0bb9679195f39e18eaa5b3f548f13e7226 [137/202] mm/mmap: Change mmap_region to use maple tree state config: x86_64-randconfig-m001-20210202 (attach

[RFC 2/3] arm64/hugetlb: Enable HUGETLB_PAGE_SIZE_VARIABLE

MAX_ORDER which invariably depends on FORCE_MAX_ZONEORDER can be a variable for a given page size, depending on whether TRANSPARENT_HUGEPAGE is enabled or not. In certain page size and THP combinations HUGETLB_PAGE_ORDER can be greater than MAX_ORDER, making it unusable as pageblock_order. This en

[RFC 1/3] mm/page_alloc: Fix pageblock_order when HUGETLB_PAGE_ORDER >= MAX_ORDER

With HUGETLB_PAGE_SIZE_VARIABLE enabled, pageblock_order cannot be assigned as HUGETLB_PAGE_ORDER when it is greater than or equal to MAX_ORDER during set_pageblock_order(). Otherwise the following warning is triggered during boot as detected on an arm64 platform. WARNING: CPU: 5 PID: 124 at mm/v

Re: [PATCH] bus: omap_l3_noc: mark l3 irqs as IRQF_NO_THREAD

* Grygorii Strashko [210128 21:16]: > The main purpose of l3 IRQs is to catch OCP bus access errors and identify > corresponding code places by showing call stack, so it's important to > handle L3 interconnect errors as fast as possible. On RT these IRQs will > became threaded and will be schedule

[RFC 0/3] mm/page_alloc: Fix pageblock_order with HUGETLB_PAGE_SIZE_VARIABLE

The following warning gets triggered while trying to boot a 64K page size without THP config kernel on arm64 platform. WARNING: CPU: 5 PID: 124 at mm/vmstat.c:1080 __fragmentation_index+0xa4/0xc0 Modules linked in: CPU: 5 PID: 124 Comm: kswapd0 Not tainted 5.11.0-rc6-4-ga0ea7d62002 #159 Hardwa

Re: [PATCH v8 0/2] Kbuild: DWARF v5 support

On Thu, Feb 4, 2021 at 7:40 AM Nick Desaulniers wrote: > > DWARF v5 is the latest standard of the DWARF debug info format. > > DWARF5 wins significantly in terms of size and especially so when mixed > with compression (CONFIG_DEBUG_INFO_COMPRESSED). > > Link: http://www.dwarfstd.org/doc/DWARF5.pdf

Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names

* Drew Fustini [210127 02:04]: > Based on linux-gpio discussion [1], it is best practice to make the > gpio-line-names unique. Generic names like "[ethernet]" are replaced > with the name of the unique signal on the AM3358 SoC ball corresponding > to the gpio line. "[NC]" is also renamed to the st

Re: [PATCH] kprobes: Warn if the kprobe is reregistered

On 2021/02/03 11:59PM, Masami Hiramatsu wrote: > Warn if the kprobe is reregistered, since there must be > a software bug (actively used resource must not be re-registered) > and caller must be fixed. > > Signed-off-by: Masami Hiramatsu > --- > kernel/kprobes.c | 13 - > 1 file cha

Re: [PATCH v2 3/3] arch/arm/configs: Enable VMSPLIT_2G in imx_v6_v7_defconfig

On Tue, Feb 2, 2021 at 11:50 PM Arnd Bergmann wrote: > > On Wed, Feb 3, 2021 at 3:37 AM Alistair Francis wrote: > > > > On Thu, Jan 28, 2021 at 11:13 PM Shawn Guo wrote: > > > > > > On Sun, Jan 17, 2021 at 10:03:01AM -0800, Alistair Francis wrote: > > > > The reMarkable2 requires VMSPLIT_2G, so

Re: [PATCH] x86: Add a prompt for HPET_EMULATE_RTC

On Thu, 4 Feb 2021 at 17:30, Randy Dunlap wrote: > > On 2/3/21 10:13 PM, Anand K. Mistry wrote: > >> Hi, > >> > >> When you run "make olddefconfig", should this "depends on" > >> line evaluate to true or false? > > > > True. RTC_DRV_CMOS=y by default on x86 systems and HPET_TIMER also > > appears

Re: [PATCH 1/2] vdpa/mlx5: Avoid unnecessary query virtqueue

On Wed, Feb 03, 2021 at 03:19:40PM -0800, Si-Wei Liu wrote: > On Tue, Feb 2, 2021 at 9:16 PM Jason Wang wrote: > > > > > > On 2021/2/3 上午1:54, Si-Wei Liu wrote: > > > On Tue, Feb 2, 2021 at 1:23 AM Eli Cohen wrote: > > >> On Tue, Feb 02, 2021 at 12:38:51AM -0800, Si-Wei Liu wrote: > > >>> Thanks

RE: [RFC PATCH v1 0/4] vfio: Add IOPF support for VFIO passthrough

> From: Shenming Lu > Sent: Tuesday, February 2, 2021 2:42 PM > > On 2021/2/1 15:56, Tian, Kevin wrote: > >> From: Alex Williamson > >> Sent: Saturday, January 30, 2021 6:58 AM > >> > >> On Mon, 25 Jan 2021 17:03:58 +0800 > >> Shenming Lu wrote: > >> > >>> Hi, > >>> > >>> The static pinning and

[PATCH] media: atomisp: Remove unneeded return variable

This patch removes unneeded return variables, using only '0' instead. It fixes the following warning detected by coccinelle: ./drivers/staging/media/atomisp/pci/sh_css_mipi.c:39:5-8: Unneeded variable: "err". Return "0" on line 44 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/stag

[PATCH] firewire: convert sysfs sprintf/snprintf family to sysfs_emit

Fix the following coccicheck warning: ./drivers/firewire/core-device.c:375:8-16: WARNING: use scnprintf or sprintf. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/firewire/core-device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firewire

Re: [PATCH] ARM: dts: am33xx: add aliases for mmc interfaces

* Måns Rullgård [210129 11:40]: > Tony Lindgren writes: > > > * Mans Rullgard [210128 18:09]: > >> Without DT aliases, the numbering of mmc interfaces is unpredictable. > >> Adding them makes it possible to refer to devices consistently. The > >> popular suggestion to use UUIDs obviously doesn

[PATCH v8 2/2] Kbuild: implement support for DWARF v5

DWARF v5 is the latest standard of the DWARF debug info format. GCC 11 will change the implicit default DWARF version, if left unspecified, to DWARF v5. DWARF5 wins significantly in terms of size when mixed with compression (CONFIG_DEBUG_INFO_COMPRESSED). 363Mvmlinux.clang12.dwarf5.compressed

[PATCH v8 1/2] Kbuild: make DWARF version a choice

Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is the default. Does so in a way that's forward compatible with existing configs, and makes adding future versions more straightforward. GCC since ~4.8 has defaulted to this DWARF version implicitly. Reviewed-by: Nathan Chancellor

[PATCH v8 0/2] Kbuild: DWARF v5 support

DWARF v5 is the latest standard of the DWARF debug info format. DWARF5 wins significantly in terms of size and especially so when mixed with compression (CONFIG_DEBUG_INFO_COMPRESSED). Link: http://www.dwarfstd.org/doc/DWARF5.pdf Patch 1 is a cleanup that lays the ground work and isn't DWARF v5

Re: [PATCH] ALSA: usb-audio: endpoint : remove redundant check before usb_free_coherent()

On Thu, 04 Feb 2021 03:05:18 +0100, Xu Wang wrote: > > usb_free_coherent() is safe with NULL addr and this check is > not required. The check there isn't about NULL buffer or not; instead it checks whether the buffer was allocated for each or it shares the single buffer (for sync endpoints). In

[PATCH] drm/komeda: convert sysfs sprintf/snprintf family to sysfs_emit

Fix the following coccicheck warning: ./drivers/gpu/drm/arm/display/komeda/komeda_dev.c:97:8-16: WARNING: use scnprintf or sprintf. ./drivers/gpu/drm/arm/display/komeda/komeda_dev.c:88:8-16: WARNING: use scnprintf or sprintf. ./drivers/gpu/drm/arm/display/komeda/komeda_dev.c:65:8-16: WARNING: us

Re: [PATCH v14 8/8] mm: hugetlb: optimize the code with the help of the compiler

On 2021/2/4 11:50, Muchun Song wrote: > We cannot optimize if a "struct page" crosses page boundaries. If > it is true, we can optimize the code with the help of a compiler. > When free_vmemmap_pages_per_hpage() returns zero, most functions are > optimized by the compiler. > > Signed-off-by: Muchu

[PATCH] ceph: minor coding style tweaks

Fixed some coding style issues, improve code reading. Signed-off-by: Zhiyuan Dai --- fs/ceph/addr.c | 3 +-- fs/ceph/cache.c | 14 +++--- fs/ceph/caps.c | 2 +- fs/ceph/dir.c| 6 +++--- fs/ceph/export.c | 2 +- fs/ceph/inode.c | 6 +++--- fs/ceph/lo

[PATCH 1/1] PCI/AER: Change to use helper pcie_aer_is_native() in some places

Use helper function pcie_aer_is_native() in some places to keep the code tidy. No function changes. Signed-off-by: Xiaofei Tan --- drivers/pci/pcie/aer.c | 4 ++-- drivers/pci/pcie/err.c | 2 +- drivers/pci/pcie/portdrv_core.c | 2 +- 3 files changed, 4 insertions(+), 4 deletio

Re: [PATCH][next] usb: cdnsp: Fix spelling mistake "delagete" -> "delegate"

On Thu, Feb 04, 2021 at 05:07:16AM +, Pawel Laszczak wrote: > Hi Dan, > > >> From: Colin Ian King > >> > >> There is a spelling mistake in a literal string. Fix it. > >> > >> Signed-off-by: Colin Ian King > >> --- > >> drivers/usb/cdns3/cdnsp-ep0.c | 2 +- > >> 1 file changed, 1 insertion(+

Re: [PATCH] x86: Add a prompt for HPET_EMULATE_RTC

On 2/3/21 10:13 PM, Anand K. Mistry wrote: >> Hi, >> >> When you run "make olddefconfig", should this "depends on" >> line evaluate to true or false? > > True. RTC_DRV_CMOS=y by default on x86 systems and HPET_TIMER also > appears to default yes (on x86-64 if I'm reading this right). > > Oddly, t

[PATCH] btrfs: Remove unneeded return variable

This patch removes unneeded return variables, using only '0' instead. It fixes the following warning detected by coccinelle: ./fs/btrfs/extent_map.c:299:5-8: Unneeded variable: "ret". Return "0" on line 331 ./fs/btrfs/disk-io.c:4402:5-8: Unneeded variable: "ret". Return "0" on line 4410 Reported-b

Re: [PATCH] usb: pd: Reland VDO definitions of PD2.0

On Thu, Feb 04, 2021 at 02:17:56PM +0800, Kyle Tso wrote: > On Thu, Feb 4, 2021 at 8:55 AM Kyle Tso wrote: > > > > Hi, Benson and Prashant, > > > > On Thu, Feb 4, 2021 at 8:50 AM Kyle Tso wrote: > > > > > > Reland VDO definitions of PD Revision 2.0 as they are still used in > > > PD2.0 products.

Re: [PATCH] usb: typec: remove unused variable ‘ret’ in typec_partner_set_pd_revision

On Thu, Feb 04, 2021 at 09:24:30AM +0800, Ye Bin wrote: > Fix follow warning: > drivers/usb/typec/class.c:763:6: warning: unused variable ‘ret’ > [-Wunused-variable] > int ret; > ^~~ > > Reported-by: Hulk Robot > Signed-off-by: Ye Bin > --- > drivers/usb/typec/class.c | 2 -- > 1 file

Re: [PATCH v2 1/4] arm64: kasan: don't populate vmalloc area for CONFIG_KASAN_VMALLOC

> On Sat, 9 Jan 2021 at 11:33, Lecopzer Chen wrote: > > > > Linux support KAsan for VMALLOC since commit 3c5c3cfb9ef4da9 > > ("kasan: support backing vmalloc space with real shadow memory") > > > > Like how the MODULES_VADDR does now, just not to early populate > > the VMALLOC_START between VMALLO

  1   2   3   4   5   6   7   8   9   10   >