Re: [PATCH 1/5] arm64: dts: imx8mm-evk: Replace deprecated phy reset properties

2020-08-29 Thread Shawn Guo
On Sun, Aug 23, 2020 at 01:15:04PM +0200, Krzysztof Kozlowski wrote: > Use preferred properties of phy node instead of deprecated > phy-reset-gpios (and others). This avoids copying deprecated code into > future DTSes. > > Signed-off-by: Krzysztof Kozlowski Applied all, thanks.

Re: [RFC PATCH -rc] gcov: Protect from uninitialized number of functions provided by GCC

2020-08-29 Thread Leon Romanovsky
On Sat, Aug 29, 2020 at 5:12 PM Colin Ian King wrote: > > On 27/08/2020 14:39, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > The kernel compiled with GCC 10.2.1 and KASAN together with GCOV enabled > > produces the following splats while reloading modules. > > > > First splat [1] is ge

[GIT PULL] dma-mapping fix for 5.9

2020-08-29 Thread Christoph Hellwig
The following changes since commit 15bc20c6af4ceee97a1f90b43c0e386643c071b4: Merge tag 'tty-5.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty (2020-08-26 10:58:20 -0700) are available in the Git repository at: git://git.infradead.org/users/hch/dma-mapping.git tags/dma-ma

[PATCH 02/19] block: merge drivers/base/map.c into block/genhd.c

2020-08-29 Thread Christoph Hellwig
Now that there is just a single user of the kobj_map functionality left, merge it into the user to prepare for additional simplications. Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman --- block/genhd.c| 130 + drivers/base/Makefile

[PATCH 06/19] block: add an optional probe callback to major_names

2020-08-29 Thread Christoph Hellwig
Add a callback to the major_names array that allows a driver to override how to probe for dev_t that doesn't currently have a gendisk registered. This will help separating the lookup of the gendisk by dev_t vs probe action for a not currently registered dev_t. Signed-off-by: Christoph Hellwig ---

[PATCH 11/19] loop: use __register_blkdev to allocate devices on demand

2020-08-29 Thread Christoph Hellwig
Use the simpler mechanism attached to major_name to allocate a brd device when a currently unregistered minor is accessed. Signed-off-by: Christoph Hellwig --- drivers/block/loop.c | 30 -- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/drivers/block/l

[PATCH 12/19] md: use __register_blkdev to allocate devices on demand

2020-08-29 Thread Christoph Hellwig
Use the simpler mechanism attached to major_name to allocate a brd device when a currently unregistered minor is accessed. Signed-off-by: Christoph Hellwig Acked-by: Song Liu --- drivers/md/md.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/m

[PATCH 03/19] block: cleanup del_gendisk a bit

2020-08-29 Thread Christoph Hellwig
Merge three hidden gendisk checks into one. Signed-off-by: Christoph Hellwig --- block/genhd.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/block/genhd.c b/block/genhd.c index cb9a51be35b053..df6485223a2c3d 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -

[PATCH 05/19] block: rework requesting modules for unclaimed devices

2020-08-29 Thread Christoph Hellwig
Instead of reusing the ranges in bdev_map, add a new helper that is called if no ranges was found. This is a first step to unpeel and eventually remove the complex ranges structure. Signed-off-by: Christoph Hellwig --- block/genhd.c | 25 +++-- 1 file changed, 15 insertions(

[PATCH 04/19] block: split block_class_lock

2020-08-29 Thread Christoph Hellwig
Split the block_class_lock mutex into one each to protect bdev_map and major_names. Signed-off-by: Christoph Hellwig --- block/genhd.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/block/genhd.c b/block/genhd.c index df6485223a2c3d..0ae6210e1

[PATCH 13/19] ide: switch to __register_blkdev for command set probing

2020-08-29 Thread Christoph Hellwig
ide is the last user of the blk_register_region framework except for the tracking of allocated gendisk. Switch to __register_blkdev, even if that doesn't allow us to trivially find out which command set to probe for. That means we now always request all modules when a user tries to access an uncla

[PATCH 09/19] sd: use __register_blkdev to avoid a modprobe for an unregistered dev_t

2020-08-29 Thread Christoph Hellwig
Switch from using blk_register_region to the probe callback passed to __register_blkdev to disable the request_module call for an unclaimed dev_t in the SD majors. Signed-off-by: Christoph Hellwig --- drivers/scsi/sd.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) d

[PATCH 10/19] brd: use __register_blkdev to allocate devices on demand

2020-08-29 Thread Christoph Hellwig
Use the simpler mechanism attached to major_name to allocate a brd device when a currently unregistered minor is accessed. Signed-off-by: Christoph Hellwig --- drivers/block/brd.c | 39 +++ 1 file changed, 11 insertions(+), 28 deletions(-) diff --git a/driver

[PATCH 14/19] floppy: use a separate gendisk for each media format

2020-08-29 Thread Christoph Hellwig
The floppy driver usually autodetects the media when used with the normal /dev/fd? devices, which also are the only nodes created by udev. But it also supports various aliases that force a given media format. That is currently supported using the blk_register_region framework which finds the floppy

[PATCH 18/19] z2ram: use separate gendisk for the different modes

2020-08-29 Thread Christoph Hellwig
Use separate gendisks (which share a tag_set) for the different operating modes instead of redirecting the gendisk lookup using a probe callback. This avoids potential problems with aliased block_device instances and will eventually allow for removing the blk_register_region framework. Signed-off-

[PATCH 19/19] block: switch gendisk lookup to a simple xarray

2020-08-29 Thread Christoph Hellwig
Now that bdev_map is only used for finding gendisks, we can use a simple xarray instead of the regions tracking structure for it. Signed-off-by: Christoph Hellwig --- block/genhd.c | 208 -- include/linux/genhd.h | 7 -- 2 files changed, 37 inser

[PATCH 16/19] ataflop: use a separate gendisk for each media format

2020-08-29 Thread Christoph Hellwig
The Atari floppy driver usually autodetects the media when used with the ormal /dev/fd? devices, which also are the only nodes created by udev. But it also supports various aliases that force a given media format. That is currently supported using the blk_register_region framework which finds the f

[PATCH 17/19] z2ram: reindent

2020-08-29 Thread Christoph Hellwig
reindent the driver using Lident as the code style was far away from normal Linux code. Signed-off-by: Christoph Hellwig --- drivers/block/z2ram.c | 493 -- 1 file changed, 236 insertions(+), 257 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/b

[PATCH 15/19] amiflop: use separate gendisks for Amiga vs MS-DOS mode

2020-08-29 Thread Christoph Hellwig
Use separate gendisks (which share a tag_set) for the native Amgiga vs the MS-DOS mode instead of redirecting the gendisk lookup using a probe callback. This avoids potential problems with aliased block_device instances and will eventually allow for removing the blk_register_region framework. Sig

[PATCH 01/19] char_dev: replace cdev_map with an xarray

2020-08-29 Thread Christoph Hellwig
None of the complicated overlapping regions bits of the kobj_map are required for the character device lookup, so just a trivial xarray instead. Signed-off-by: Christoph Hellwig --- fs/char_dev.c | 94 +-- fs/dcache.c | 1 - fs/internal.h | 5 -

[PATCH 08/19] swim: don't call blk_register_region

2020-08-29 Thread Christoph Hellwig
The swim driver (unlike various other floppy drivers) doesn't have magic device nodes for certain modes, and already registers a gendisk for each of the floppies supported by a device. Thus the region registered is a no-op and can be removed. Signed-off-by: Christoph Hellwig --- drivers/block/s

[PATCH 07/19] ide: remove ide_{,un}register_region

2020-08-29 Thread Christoph Hellwig
There is no need to ever register the fake gendisk used for ide-tape. Signed-off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke --- drivers/ide/ide-probe.c | 32 drivers/ide/ide-tape.c | 2 -- include/linux/ide.h | 3 --- 3 files changed, 37 deletions

simplify gendisk lookup and remove struct block_device aliases v2

2020-08-29 Thread Christoph Hellwig
Hi all, this series removes the annoying struct block_device aliases, which can happen for a bunch of old floppy drivers (and z2ram). In that case multiple struct block device instances for different dev_t's can point to the same gendisk, without being partitions. The cause for that is the probe

KMSAN: uninit-value in translate_table

2020-08-29 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:ce8056d1 wip: changed copy_from_user where instrumented git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=140f36b690 kernel config: https://syzkaller.appspot.com/x/.

[PATCH trivial] xtensa: fix Kconfig typo

2020-08-29 Thread Randy Dunlap
From: Randy Dunlap Correct trivial typo (ful -> full). Fixes: 76743c0e0915 ("xtensa: move kernel memory layout to platform options") Signed-off-by: Randy Dunlap Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org Cc: Jiri Kosina --- arch/xtensa/Kconfig |2 +- 1 file chan

[gustavoars-linux:testing/fallthrough] BUILD SUCCESS a66bf6afaf6c7977c8e64e77bafb9761fd42ac4c

2020-08-29 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git testing/fallthrough branch HEAD: a66bf6afaf6c7977c8e64e77bafb9761fd42ac4c arm64/cpuinfo: Remove unnecessary fallthrough annotation elapsed time: 720m configs tested: 96 configs skipped: 7 The following configs

[PATCH] igb: read PBA number from flash

2020-08-29 Thread Gal Hammer
Fixed flash presence check for 82576 controllers so the part number string is read and displayed correctly. Signed-off-by: Gal Hammer --- drivers/net/ethernet/intel/igb/igb_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/

Re: [PATCH] USB: integrate macro definitions into include/linux/usb.h

2020-08-29 Thread Xu, Yanfei
I just think it is a clear up to make these macros get togather which have the samilar attributes. That's why :) Thanks, Yanfei On 8/28/20 3:48 PM, Greg KH wrote: On Tue, Aug 25, 2020 at 11:44:21PM +0800, yanfei...@windriver.com wrote: From: Yanfei Xu include/linux/usb.h also contains 'Hard

Re: [PATCH 02/11] kconfig: qconf: update the intro message to match to the current code

2020-08-29 Thread Randy Dunlap
On 8/29/20 1:14 AM, Masahiro Yamada wrote: > I do not think "Although there is no cross reference yet ..." is valid > any longer. > > The cross reference is supported via hyperlinks enabled by the > "show Debug Info" option. > > Update the message. > > Signed-off-by: Masahiro Yamada > --- > >

Re: [PATCH 01/11] kconfig: qconf: reformat the intro message

2020-08-29 Thread Randy Dunlap
On 8/29/20 1:14 AM, Masahiro Yamada wrote: > The introduction message displayed by 'Help -> Introduction' does not > look nice due to excessive new lines. > > Reformat the message. > > Signed-off-by: Masahiro Yamada > --- > > scripts/kconfig/qconf.cc | 29 ++--- > 1 fil

Re: [PATCH 11/11] kconfig: qconf: create QApplication after option checks

2020-08-29 Thread Randy Dunlap
On 8/29/20 1:14 AM, Masahiro Yamada wrote: > 'scripts/kconfig/qconf -h' just calls usage() and exits, with > QApplication unused. > > There is no need to construct QApplication so early. Do it after > the parse stage. > > Signed-off-by: Masahiro Yamada > --- > > scripts/kconfig/qconf.cc | 3 ++

Re: [PATCH 05/11] kconfig: qconf: show data column all the time

2020-08-29 Thread Randy Dunlap
On 8/29/20 1:14 AM, Masahiro Yamada wrote: > The next commit will allow users to edit "int", "hex", "string" > menus in-place from the data column. > > The data column should be always displayed. > > Signed-off-by: Masahiro Yamada > --- > > scripts/kconfig/qconf.cc | 29 +--

Re: [PATCH 06/11] kconfig: qconf: allow to edit "int", "hex", "string" menus in-place

2020-08-29 Thread Randy Dunlap
On 8/29/20 1:14 AM, Masahiro Yamada wrote: > Previously, when you double-clicked the "int", "hex", or "string" menus, > a line-edit gadget showed up to allow you to input the value, which > looked clumsy. > > Also, it was buggy; the editor opened even if the config option was not > editable. For e

Re: ptrace_syscall_32 is failing

2020-08-29 Thread Brian Gerst
On Sat, Aug 29, 2020 at 12:52 PM Andy Lutomirski wrote: > > Seems to be a recent regression, maybe related to entry/exit work changes. > > # ./tools/testing/selftests/x86/ptrace_syscall_32 > [RUN]Check int80 return regs > [OK]getpid() preserves regs > [OK]kill(getpid(), SIGUSR1) preser

[PATCH] KVM: fix memory leak in kvm_io_bus_unregister_dev()

2020-08-29 Thread Rustam Kovhaev
when kmalloc() fails in kvm_io_bus_unregister_dev(), before removing the bus, we should iterate over all other devices linked to it and call kvm_iodevice_destructor() for them Reported-and-tested-by: syzbot+f196caa45793d6374...@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?exti

Re: [PATCH] fat: Avoid oops when bdi->io_pages==0

2020-08-29 Thread Matthew Wilcox
On Sun, Aug 30, 2020 at 10:54:35AM +0900, OGAWA Hirofumi wrote: > Matthew Wilcox writes: > > > On Sun, Aug 30, 2020 at 09:59:41AM +0900, OGAWA Hirofumi wrote: > >> On one system, there was bdi->io_pages==0. This seems to be the bug of > >> a driver somewhere, and should fix it though. Anyway, it

Re: [f2fs-dev] [PATCH] f2fs: prevent compressed file from being disabled after releasing cblocks

2020-08-29 Thread Chao Yu
On 2020-8-28 13:46, Daeho Jeong wrote: From: Daeho Jeong After releasing cblocks, the compressed file can be accidentally disabled in compression mode, since it has zero cblocks. As we are using IMMUTABLE flag to present released cblocks state, we can add IMMUTABLE state check when considering

Re: [PATCH] f2fs: Simplify SEEK_DATA implementation

2020-08-29 Thread Chao Yu
On 2020-8-25 5:48, Matthew Wilcox (Oracle) wrote: Instead of finding the first dirty page and then seeing if it matches the index of a block that is NEW_ADDR, delay the lookup of the dirty bit until we've actually found a block that's NEW_ADDR. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-

Re: {standard input}:1174: Error: inappropriate arguments for opcode 'mpydu'

2020-08-29 Thread Nicolas Pitre
This looks like a buggy compiler to me. On Sun, 30 Aug 2020, kernel test robot wrote: > Hi Nicolas, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: e77aee1326f7691763aa968eee2f57db37840b9d > commit: 60

Re: [RFC/RFT PATCH 3/6] arm64, numa: Move pcibus_to_node definition to generic numa code

2020-08-29 Thread Bjorn Helgaas
On Fri, Aug 28, 2020 at 06:11:50PM -0700, Atish Patra wrote: > On Fri, Aug 28, 2020 at 9:15 AM Bjorn Helgaas wrote: > > On Fri, Aug 28, 2020 at 10:48:30AM +0100, Jonathan Cameron wrote: > > > On Fri, 14 Aug 2020 14:47:22 -0700 > > > Atish Patra wrote: > > > > > > > pcibus_to_node is used only whe

Re: ERROR: modpost: "max_low_pfn" undefined!

2020-08-29 Thread Randy Dunlap
On 8/29/20 7:32 PM, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 1127b219ce9481c84edad9711626d856127d5e51 > commit: f23efcbcc523b09c2ee359a35eb3897dc1764fd3 crypto: ctr - no longer > needs CRYPTO_SEQIV > date: 4 months

ERROR: modpost: "max_low_pfn" undefined!

2020-08-29 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 1127b219ce9481c84edad9711626d856127d5e51 commit: f23efcbcc523b09c2ee359a35eb3897dc1764fd3 crypto: ctr - no longer needs CRYPTO_SEQIV date: 4 months ago config: ia64-randconfig-s031-20200830 (attached as .c

Re: [PATCH AUTOSEL 5.4 10/58] mips: vdso: fix 'jalr t9' crash in vdso code

2020-08-29 Thread Sasha Levin
On Sat, Aug 29, 2020 at 04:37:32PM +0200, Hauke Mehrtens wrote: On 8/29/20 3:56 PM, Sasha Levin wrote: On Sat, Aug 29, 2020 at 03:08:01PM +0200, Hauke Mehrtens wrote: On 3/5/20 6:13 PM, Sasha Levin wrote: From: Victor Kamensky [ Upstream commit d3f703c4359ff06619b2322b91f69710453e6b6d ] Obs

Re: [PATCH] fat: Avoid oops when bdi->io_pages==0

2020-08-29 Thread OGAWA Hirofumi
Matthew Wilcox writes: > On Sun, Aug 30, 2020 at 09:59:41AM +0900, OGAWA Hirofumi wrote: >> On one system, there was bdi->io_pages==0. This seems to be the bug of >> a driver somewhere, and should fix it though. Anyway, it is better to >> avoid the divide-by-zero Oops. >> >> So this check it. >>

Re: [PATCH RFC leds + net-next v4 0/2] Add support for LEDs on Marvell PHYs

2020-08-29 Thread Andrew Lunn
> > > You could make a good guess at matching to two together, but it is > > > error prone. Phys are low level things which the user is not really > > > involved in. They interact with interface names. ethtool, ip, etc, all > > > use interface names. In fact, i don't know of any tool which uses > >

Re: [PATCH 1/3] arm64: dts: imx8mm-evk: remove orphaned pinctrl-names property

2020-08-29 Thread Shawn Guo
On Sun, Aug 23, 2020 at 11:05:03AM +0200, Krzysztof Kozlowski wrote: > The "pinctrl-names" property in iomux node does not make sense on its > own (without "pinctrl-X"). > > Signed-off-by: Krzysztof Kozlowski Applied all, thanks.

Re: [PATCH] ARM: dts: imx6q-kontron-samx6i: Remove old fsl,spi-num-chipselects

2020-08-29 Thread Shawn Guo
On Sun, Aug 23, 2020 at 10:49:20AM +0200, Krzysztof Kozlowski wrote: > The property "fsl,spi-num-chipselects" is gone since commit 790739c4417c > ("dt-bindings: spi: Convert imx cspi to json-schema"). > > Signed-off-by: Krzysztof Kozlowski Applied, thanks.

[PATCH] iomap: fix WARN_ON_ONCE() from unprivileged users

2020-08-29 Thread Qian Cai
It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by unprivileged users which would taint the kernel, or worse - panic if panic_on_warn or panic_on_taint is set. Hence, just convert it to pr_warn_ratelimited() to let users know their workloads are racing. Thanks Dave Chinner for the i

Re: [PATCH RFC 0/2] simple sysfs wrappers for single values

2020-08-29 Thread Joe Perches
On Sat, 2020-08-29 at 17:28 -0700, Joe Perches wrote: > On Sun, 2020-08-30 at 00:37 +0100, Alex Dewar wrote: > > Hi all, > > > > I've noticed there seems to have been a fair amount of discussion around > > the subject of possible helper methods for use in the context of sysfs > > show methods (whi

Re: [PATCH] fat: Avoid oops when bdi->io_pages==0

2020-08-29 Thread Matthew Wilcox
On Sun, Aug 30, 2020 at 09:59:41AM +0900, OGAWA Hirofumi wrote: > On one system, there was bdi->io_pages==0. This seems to be the bug of > a driver somewhere, and should fix it though. Anyway, it is better to > avoid the divide-by-zero Oops. > > So this check it. > > Signed-off-by: OGAWA Hirofumi

[PATCH] fat: Avoid oops when bdi->io_pages==0

2020-08-29 Thread OGAWA Hirofumi
On one system, there was bdi->io_pages==0. This seems to be the bug of a driver somewhere, and should fix it though. Anyway, it is better to avoid the divide-by-zero Oops. So this check it. Signed-off-by: OGAWA Hirofumi Cc: --- fs/fat/fatent.c |2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] block: Set default value to bdi->io_pages instead of zero

2020-08-29 Thread OGAWA Hirofumi
This may not enough to guarantee ->io_pages is not zero though, instead of leaving ->io_pages as zero, this initializing ->io_pages to sane value. (maybe some part of NVMe driver seems to be) Signed-off-by: OGAWA Hirofumi --- block/blk-core.c |1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v2] block: grant IOPRIO_CLASS_RT to CAP_SYS_NICE

2020-08-29 Thread Bart Van Assche
On 2020-08-24 15:10, Khazhismel Kumykov wrote: > CAP_SYS_ADMIN is too broad, and ionice fits into CAP_SYS_NICE's grouping. > > Retain CAP_SYS_ADMIN permission for backwards compatibility. > > Signed-off-by: Khazhismel Kumykov > --- > block/ioprio.c | 2 +- > include/uapi/linux/

arch/mips/boot/compressed/../../../../lib/zlib_inflate/inftrees.c:258: undefined reference to `__ubsan_handle_type_mismatch_v1'

2020-08-29 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 1127b219ce9481c84edad9711626d856127d5e51 commit: 8d58f222e85f01da0c0e1fc1e77986c86de889e2 ubsan: disable UBSAN_ALIGNMENT under COMPILE_TEST date: 4 months ago config: mips-randconfig-r025-20200829

Re: [PATCH V2] sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output

2020-08-29 Thread Joe Perches
On Sat, 2020-08-29 at 16:48 -0700, Joe Perches wrote: > Output defects can exist in sysfs content using sprintf and snprintf. > > sprintf does not know the PAGE_SIZE maximum of the temporary buffer > used for outputting sysfs content and it's possible to overrun the > PAGE_SIZE buffer length. > >

Re: possible deadlock in __lock_task_sighand

2020-08-29 Thread Jens Axboe
This is already fixed, and it went upstream yesterday. #syz fix: io_uring: don't recurse on tsk->sighand->siglock with signalfd -- Jens Axboe

[PATCH] MAINTAINERS: IA64: mark Status as Odd Fixes only

2020-08-29 Thread Randy Dunlap
From: Randy Dunlap IA64 isn't really being maintained, so mark it as Odd Fixes only. Cc: Tony Luck Cc: Fenghua Yu Cc: linux-i...@vger.kernel.org Signed-off-by: Randy Dunlap --- MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200828.orig/MAINTAINERS +++

Re: [PATCH RFC 0/2] simple sysfs wrappers for single values

2020-08-29 Thread Joe Perches
On Sun, 2020-08-30 at 00:37 +0100, Alex Dewar wrote: > Hi all, > > I've noticed there seems to have been a fair amount of discussion around > the subject of possible helper methods for use in the context of sysfs > show methods (which I haven't had a chance to go through in detail yet > -- sorry!)

possible deadlock in __lock_task_sighand

2020-08-29 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:abb3438d Merge tag 'm68knommu-for-v5.9-rc3' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10bb510590 kernel config: https://syzkaller.appspot.com/x/.config?x=978db74cb30aa994 das

Re: [PATCH v9 4/4] scsi: ufs: Prepare HPB read for cached sub-region

2020-08-29 Thread Bart Van Assche
On 2020-08-28 00:19, Daejun Park wrote: > This patch changes the read I/O to the HPB read I/O. Reviewed-by: Bart Van Assche

Re: [PATCH] sysfs: Add sysfs_emit to replace sprintf to PAGE_SIZE buffers.

2020-08-29 Thread Joe Perches
On Sun, 2020-08-30 at 00:53 +0300, Denis Efremov wrote: > > Anyway, this will need updating, likely with better examples. [] > I think it's good to reflect in docs that sysfs_emit_at/sysfs_emit_pos is > only for "legacy" code and should not be used in new code (checkpatch.pl > warning?) > because

[PATCH V2] sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output

2020-08-29 Thread Joe Perches
Output defects can exist in sysfs content using sprintf and snprintf. sprintf does not know the PAGE_SIZE maximum of the temporary buffer used for outputting sysfs content and it's possible to overrun the PAGE_SIZE buffer length. Add a generic sysfs_emit function that knows that the size of the t

Re: [PATCH v9 3/4] scsi: ufs: L2P map management for HPB read

2020-08-29 Thread Bart Van Assche
On 2020-08-28 00:19, Daejun Park wrote: > +static unsigned int ufshpb_host_map_kbytes = 1024; A comment that explains where this value comes from would be welcome. > +static struct ufshpb_req *ufshpb_get_map_req(struct ufshpb_lu *hpb, > + struct ufshpb_sub

Re: [f2fs-dev] [PATCH] f2fs: make fibmap consistent with fiemap for compression chunk

2020-08-29 Thread Chao Yu
On 2020-8-28 11:49, Daeho Jeong wrote: From: Daeho Jeong Currently fibmap returns zero address for compression chunk. But it is not consistent with the output of fiemap, since fiemap returns real pysical block address related to the compression chunk. Therefore I suggest fibmap returns the same

{standard input}:1174: Error: inappropriate arguments for opcode 'mpydu'

2020-08-29 Thread kernel test robot
Hi Nicolas, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e77aee1326f7691763aa968eee2f57db37840b9d commit: 602828c1aade576ac5f3fbd59b4eb014c5fc2414 __div64_const32(): improve the generic C version date: 12 month

[PATCH RFC 1/2] sysfs: add helpers for safely showing simple strings

2020-08-29 Thread Alex Dewar
Add a helper, sysfs_strscpy(), which simply copies a string and appends a newline and NUL char to the end, making sure not to overflow the destination buffer, which MUST be PAGE_SIZE bytes (which is true for buffers in this context). It includes a compile time check for the specified destination bu

[PATCH RFC 2/2] sysfs: add helper macro for showing simple integer values

2020-08-29 Thread Alex Dewar
sysfs attributes are supposed to be only single values, which are printed into a buffer of PAGE_SIZE. Accordingly, for many simple attributes, sprintf() can be used like so: static ssize_t my_show(..., char *buf) { ... return sprintf("%d\n", my_intege

[PATCH RFC 0/2] simple sysfs wrappers for single values

2020-08-29 Thread Alex Dewar
Hi all, I've noticed there seems to have been a fair amount of discussion around the subject of possible helper methods for use in the context of sysfs show methods (which I haven't had a chance to go through in detail yet -- sorry!), so I thought I'd send out a couple of patches I've been working

Re: [PATCH RFC leds + net-next v4 0/2] Add support for LEDs on Marvell PHYs

2020-08-29 Thread Andrew Lunn
On Sun, Aug 30, 2020 at 12:43:51AM +0200, Pavel Machek wrote: > Hi! > > > > > And no, I don't want phydev name there. > > > > > > Ummm. Can we get little more explanation on that? I fear that LED > > > device renaming will be tricky and phydev would work around that > > > nicely. > > > > Hi Pave

[PATCH 1/1] ARM: dts: bcm2711: Enable ddr modes on emmc2 controller

2020-08-29 Thread Tobias Schramm
This patch enables ddr modes for eMMC and SD storage on emmc2, doubling transfer speed. Previously only single data rate modes were used, wasting half the available throughput. The bcm2711 supports both SD and eMMC storage using ddr modes. Testing show that pcb layout of the Raspberry Pi 4 can supp

[PATCH 0/1] Enable ddr modes on emmc2 of Raspberry Pi 4 B

2020-08-29 Thread Tobias Schramm
Currently both micro SD cards and eMMC storage attached to a Pi 4 are running in single data rate mode only. However the controller used supports dual data rate modes. This patch enables ddr modes for both sd and mmc storage. I've verified that there are no issues transferring data in ddr mode usi

Re: [PATCH v9 1/4] scsi: ufs: Add HPB feature related parameters

2020-08-29 Thread Bart Van Assche
On 2020-08-28 00:17, Daejun Park wrote: > This is a patch for parameters to be used for HPB feature. Reviewed-by: Bart Van Assche

Re: [PATCH v9 2/4] scsi: ufs: Introduce HPB feature

2020-08-29 Thread Bart Van Assche
On 2020-08-28 00:18, Daejun Park wrote: > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index 618b253e5ec8..df30622a2b67 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -588,6 +588,24 @@ struct ufs_hba_variant_params { > u16 hba_enable_de

Re: [PATCH RFC leds + net-next v4 0/2] Add support for LEDs on Marvell PHYs

2020-08-29 Thread Pavel Machek
Hi! > > > And no, I don't want phydev name there. > > > > Ummm. Can we get little more explanation on that? I fear that LED > > device renaming will be tricky and phydev would work around that > > nicely. > > Hi Pavel > > The phydev name is not particularly nice: > > !mdio-mux!mdio@1!switch@0!

Re: [PATCH] fs: allow do_renameat2() over bind mounts of the same filesystem.

2020-08-29 Thread Florian Margaine
Matthew Wilcox writes: > On Sat, Aug 29, 2020 at 11:23:34PM +0200, Florian Margaine wrote: >> Al Viro writes: >> >> > On Fri, Aug 28, 2020 at 10:40:35PM +0200, Florian Margaine wrote: >> >> There's currently this seemingly unnecessary limitation that rename() >> >> cannot work over bind mounts

[PATCH 8/8] regulator: tps65910: Constify static regulator_ops

2020-08-29 Thread Rikard Falkeborn
The only usage of these is to assign their address to the ops field in the regulator_desc struct, which is a const pointer. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/regulator/tps65910-regulator.c | 10 +- 1 file ch

[PATCH 6/8] regulator: tps6586x: Constify static regulator_ops

2020-08-29 Thread Rikard Falkeborn
The only usage of these are to assign their address to the ops field in the regulator_desc struct, which is a const pointer. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/regulator/tps6586x-regulator.c | 8 1 file chan

[PATCH 5/8] regulator: tps65090: constify static regulator_ops

2020-08-29 Thread Rikard Falkeborn
The only usages of these are to assign their address to the ops field in the regulator_desc struct, which is a const pointer. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/regulator/tps65090-regulator.c | 8 1 file cha

[PATCH 4/8] regulator: tps65086: Constify static regulator_ops

2020-08-29 Thread Rikard Falkeborn
The only usage of reg_ops and switch_ops is to assign their addresses to the ops field in the regulator_desc struct, which is a const pointer. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/regulator/tps65086-regulator.c | 4 ++-

[PATCH 2/8] regulator: tps6105x: Constify tps6105x_regulator_ops

2020-08-29 Thread Rikard Falkeborn
The only usage of tps6105x_regulator_ops is to assign its address to the ops field in the regulator_desc struct, which is a const pointer. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/regulator/tps6105x-regulator.c | 2 +- 1 file

Re: [PATCH] fs: allow do_renameat2() over bind mounts of the same filesystem.

2020-08-29 Thread Matthew Wilcox
On Sat, Aug 29, 2020 at 11:23:34PM +0200, Florian Margaine wrote: > Al Viro writes: > > > On Fri, Aug 28, 2020 at 10:40:35PM +0200, Florian Margaine wrote: > >> There's currently this seemingly unnecessary limitation that rename() > >> cannot work over bind mounts of the same filesystem, > > > >

[PATCH 0/8] regulator/tps*: Constify static regulator ops

2020-08-29 Thread Rikard Falkeborn
Constify static instances of struct regulator_ops to allow the compiler to put them in read-only memory. Patches are independent. Compile-tested only. Rikard Falkeborn (8): regulator: tps51632: Constify tps51632_dcdc_ops regulator: tps6105x: Constify tps6105x_regulator_ops regulator: tps6236

[PATCH 7/8] regulator: tps65912: Constify static regulator_ops

2020-08-29 Thread Rikard Falkeborn
The only usage of tps65912_ops_dcdc and tps65912_ops_ldo is to assign their address to the ops field in the regulator_desc struct, which is a const pointer. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/regulator/tps65912-regul

[PATCH 3/8] regulator: tps62360: Constify tps62360_dcdc_ops

2020-08-29 Thread Rikard Falkeborn
The only usage of tps62360_dcdc_ops is to assign its address to the ops field in the regulator_desc struct, which is a const pointer. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/regulator/tps62360-regulator.c | 2 +- 1 file chang

[PATCH 1/8] regulator: tps51632: Constify tps51632_dcdc_ops

2020-08-29 Thread Rikard Falkeborn
The only usage of tps51632_dcdc_ops is to assign its address to the ops field in the regulator_desc struct, which is a const pointer. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/regulator/tps51632-regulator.c | 2 +- 1 file chang

Re: [PATCH v2 3/3] bio: convert get_user_pages_fast() --> pin_user_pages_fast()

2020-08-29 Thread John Hubbard
On 8/29/20 8:02 AM, Christoph Hellwig wrote: - size = iov_iter_get_pages(iter, pages, LONG_MAX, nr_pages, &offset); + size = iov_iter_pin_user_pages(iter, pages, LONG_MAX, nr_pages, &offset); This is really a comment to the previous patch, but I only spotted it here: I think the r

Re: [PATCH v2 2/3] iov_iter: introduce iov_iter_pin_user_pages*() routines

2020-08-29 Thread John Hubbard
On 8/29/20 7:58 AM, Christoph Hellwig wrote: On Sat, Aug 29, 2020 at 01:08:52AM -0700, John Hubbard wrote: ... @@ -1280,7 +1281,11 @@ static inline ssize_t __pipe_get_pages(struct iov_iter *i, maxsize = n; n += *start; while (n > 0) { - get_page(*pages++ =

Re: [PATCH v2 1/3] mm/gup: introduce pin_user_page()

2020-08-29 Thread John Hubbard
On 8/29/20 7:54 AM, Christoph Hellwig wrote: On Sat, Aug 29, 2020 at 01:08:51AM -0700, John Hubbard wrote: pin_user_page() is the FOLL_PIN equivalent of get_page(). This was always a missing piece of the pin/unpin API calls (early reviewers of pin_user_pages() asked about it, in fact), but unti

Re: [PATCH] sysfs: Add sysfs_emit to replace sprintf to PAGE_SIZE buffers.

2020-08-29 Thread Denis Efremov
> > Anyway, this will need updating, likely with better examples. > > diff --git a/Documentation/filesystems/sysfs.rst > b/Documentation/filesystems/sysfs.rst > index ab0f7795792b..13c7a86fa6c8 100644 > --- a/Documentation/filesystems/sysfs.rst > +++ b/Documentation/filesystems/sysfs.rst > @@

ATTN: YOUR LATE RELATIVE!!!

2020-08-29 Thread LAWYER JONES!!!
- Good day, I do apologize if the content here under are contrary to your moral ETHICS,but please treat it with absolute secrecy and personal courtesy. I am writing following an opportunity in my office that will be of immense benefit to both of us. It's about my late client who had some hu

Re: [PATCH] ia64: fix min_low_pfn/max_low_pfn build errors

2020-08-29 Thread David Rientjes
On Fri, 28 Aug 2020, Randy Dunlap wrote: > Fix min_low_pfn/max_low_pfn build errors for arch/ia64/: (e.g.) > > ERROR: "max_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined! > ERROR: "min_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined! > ERROR: "min_low_pfn" [drivers/hwtracing/int

Re: [PATCH] microblaze: fix min_low_pfn/max_low_pfn build errors

2020-08-29 Thread David Rientjes
On Fri, 28 Aug 2020, Randy Dunlap wrote: > Fix min_low_pfn/max_low_pfn build errors for arch/microblaze/: (e.g.) > > ERROR: "min_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined! > ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu_sink.ko] > undefined! > ERROR: "min_low_p

Re: Kernel 5.9-rc Regression: Boot failure with nvme

2020-08-29 Thread David Rientjes
On Sat, 29 Aug 2020, Christoph Hellwig wrote: > > Just adding Christoph to the participants list, since at a guess it's > > due to his changes whether they came from the nvme side or the dma > > side.. > > > > Christoph? > > This kinda looks like the sqsize regression we had in earlier 5.9-rc, >

Re: [PATCH v2] usb: dwc3: Stop active transfers before halting the controller

2020-08-29 Thread Thinh Nguyen
Wesley Cheng wrote: > In the DWC3 databook, for a device initiated disconnect or bus reset, the > driver is required to send dependxfer commands for any pending transfers. > In addition, before the controller can move to the halted state, the SW > needs to acknowledge any pending events. If the co

Re: [PATCH v5 2/2] drm: panel: Add novatek nt36672a panel driver

2020-08-29 Thread Sam Ravnborg
Hi Sumit. On Wed, Aug 26, 2020 at 09:33:08PM +0530, Sumit Semwal wrote: > Novatek NT36672a is a generic DSI IC that drives command and video mode > panels. Add the driver for it. > > Right now adding support for some Poco F1 phones that have an LCD panel > from Tianma connected with this IC, with

Re: [PATCH v3 18/18] iio: multiplexer: iio-mux: Simplify with dev_err_probe()

2020-08-29 Thread Peter Rosin
On 2020-08-29 08:47, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Andy Shevchenko Acked-by: Peter Rosin Cheers, Peter

Re: [PATCH v3 12/18] iio: dac: dpot-dac: Simplify with dev_err_probe()

2020-08-29 Thread Peter Rosin
On 2020-08-29 08:47, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Andy Shevchenko Acked-by: Peter Rosin Cheers, Peter

Re: [PATCH v3 09/18] iio: afe: iio-rescale: Simplify with dev_err_probe()

2020-08-29 Thread Peter Rosin
On 2020-08-29 08:47, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Andy Shevchenko Acked-by: Peter Rosin Cheers, Peter

Re: [PATCH v3 03/18] iio: adc: envelope-detector: Simplify with dev_err_probe()

2020-08-29 Thread Peter Rosin
On 2020-08-29 08:47, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Andy Shevchenko Thanks for the re-spin. Acked-by: Peter Ros

Re: [PATCH AUTOSEL 4.19 08/38] media: pci: ttpci: av7110: fix possible buffer overflow caused by bad DMA value in debiirq()

2020-08-29 Thread Sean Young
On Sat, Aug 29, 2020 at 08:16:00PM +0300, Laurent Pinchart wrote: > On Sat, Aug 29, 2020 at 02:10:20PM +0200, Pavel Machek wrote: > > Hi! > > > > > The value av7110->debi_virt is stored in DMA memory, and it is assigned > > > to data, and thus data[0] can be modified at any time by malicious > > >

  1   2   3   4   5   >