Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2020-08-26 Thread Kehuan Feng
Hi Hillf, > Let’s see if TCQ_F_NOLOC is making fq_codel different in your testing. I assume you meant disabling NOLOCK for pfifo_fast. Here is the modification, --- ./net/sched/sch_generic.c.orig 2020-08-24 22:02:04.589830751 +0800 +++ ./net/sched/sch_generic.c 2020-08-27 10:17:10.148977

Re: [PATCH v4 0/2] add regmap-spi-avmm & Intel Max10 BMC chip support

2020-08-26 Thread Lee Jones
On Wed, 26 Aug 2020, Mark Brown wrote: > On Wed, 19 Aug 2020 15:34:55 +0800, Xu Yilun wrote: > > This patchset adds the regmap-spi-avmm to support the Intel SPI Slave to > > AVMM Bus Bridge (spi-avmm) IP block. It also implements the usercase - the > > driver of Intel Max10 BMC chip which integrat

Re: [PATCH] iio: adc: exynos_adc: Replace indio_dev->mlock with own device lock

2020-08-26 Thread Krzysztof Kozlowski
On Wed, Aug 26, 2020 at 04:22:03PM +0300, Alexandru Ardelean wrote: > From: Sergiu Cuciurean > > As part of the general cleanup of indio_dev->mlock, this change replaces > it with a local lock, to protect potential concurrent access to the > completion callback during a conversion. I don't know

[PATCH] net: usb: Fix uninit-was-stored issue in asix_read_phy_addr()

2020-08-26 Thread Himadri Pandya
The buffer size is 2 Bytes and we expect to receive the same amount of data. But sometimes we receive less data and run into uninit-was-stored issue upon read. Hence modify the error check on the return value to match with the buffer size as a prevention. Reported-and-tested by: syzbot+a7e220df5a8

Re: [PATCH] usb: host: ohci-exynos: Fix error handling in exynos_ohci_probe()

2020-08-26 Thread Krzysztof Kozlowski
On Wed, Aug 26, 2020 at 10:49:31PM +0800, Tang Bin wrote: > If the function platform_get_irq() failed, the negative value > returned will not be detected here. So fix error handling in > exynos_ohci_probe(). And when get irq failed, the function > platform_get_irq() logs an error message, so remove

[PATCH v3 1/1] extcon: ptn5150: Set the VBUS and POLARITY property capability

2020-08-26 Thread Ramuthevar,Vadivel MuruganX
From: Ramuthevar Vadivel Murugan Set the capability value of property for VBUS and POLARITY. Signed-off-by: Ramuthevar Vadivel Murugan --- drivers/extcon/extcon-ptn5150.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150

[PATCH v3 0/1]extcon: ptn5150: Add usb-typec support for Intel LGM SoC

2020-08-26 Thread Ramuthevar,Vadivel MuruganX
Add usb-typec detection support for the Intel LGM SoC based boards. Original driver is not supporting usb detection on Intel LGM SoC based boards then we debugged and fixed the issue, but before sending our patches Mr.Krzyszto has sent the same kind of patches, so I have rebased over his latest pa

[PATCH 7/7 net-next] vxlan: fix vxlan_find_sock() documentation for l3mdev

2020-08-26 Thread Fabian Frederick
Since commit aab8cc3630e32 ("vxlan: add support for underlay in non-default VRF") vxlan_find_sock() also checks if socket is assigned to the right level 3 master device when lower device is not in the default VRF. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 5 +++-- 1 file changed

[PATCH 6/7 net-next] vxlan: merge VXLAN_NL2FLAG use in vxlan_nl2conf()

2020-08-26 Thread Fabian Frederick
Sort flag assignment to add readability. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index e9b561b9d23e1..1501a5633a97e 100644 --- a/drivers/net

[PATCH 5/7 net-next] vxlan: add VXLAN_NL2FLAG macro

2020-08-26 Thread Fabian Frederick
Replace common flag assignment with a macro. This could yet be simplified with changelink/supported but it would remove clarity Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 113 +--- include/net/vxlan.h | 10 2 files changed, 23 insertio

[PATCH 4/7 net-next] vxlan: check rtnl_configure_link return code correctly

2020-08-26 Thread Fabian Frederick
rtnl_configure_link is always checked if < 0 for error code. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 14f903d09c010..1e9ab1002281c 100644 --- a/drivers/net/vxlan.c +

[PATCH 3/7 net-next] vxlan: move encapsulation warning

2020-08-26 Thread Fabian Frederick
vxlan_xmit_one() was only called from vxlan_xmit() without rdst and info was already tested. Emit warning in that function instead Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/ne

[PATCH 2/7 net-next] vxlan: add unlikely to vxlan_remcsum check

2020-08-26 Thread Fabian Frederick
small optimization around checking as it's being done in all receptions Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 47c762f7f5b11..cc904f003f158 100644 --- a/drivers/ne

[PATCH 1/7 net-next] vxlan: don't collect metadata if remote checksum is wrong

2020-08-26 Thread Fabian Frederick
call vxlan_remcsum() before md filling in vxlan_rcv() Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index b9fefe27e3e89..47c762f7f5b11 100644 --- a/drivers/net/vxlan.c +

[PATCH] perf/core: Fix hung issue on perf stat command during cpu hotplug

2020-08-26 Thread Kajol Jain
Commit 2ed6edd33a21 ("perf: Add cond_resched() to task_function_call()") added assignment of ret value as -EAGAIN in case function call to 'smp_call_function_single' fails. For non-zero ret value, it did 'ret = !ret ? data.ret : -EAGAIN;', which always assign -EAGAIN to ret and make second if condi

Re: [PATCH v1 4/9] powerpc/vdso: Remove unnecessary ifdefs in vdso_pagelist initialization

2020-08-26 Thread Christophe Leroy
On 08/26/2020 02:58 PM, Michael Ellerman wrote: Christophe Leroy writes: diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c index daef14a284a3..bbb69832fd46 100644 --- a/arch/powerpc/kernel/vdso.c +++ b/arch/powerpc/kernel/vdso.c @@ -718,16 +710,14 @@ static int __init vdso

[PATCH v2 4/4] crypto: sun8i-ss - use kfree_sensitive()

2020-08-26 Thread Denis Efremov
Use kfree_sensitive() instead of open-coding it. Signed-off-by: Denis Efremov --- .../crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c b/drivers/crypto/allwinner

Re: Broadcom WiFi SDIO performance regression after commit "mmc: sdhci: Remove finish_tasklet"

2020-08-26 Thread Adrian Hunter
On 27/08/20 9:07 am, Dmitry Osipenko wrote: > Hello! > > I was debugging WiFi performance problems on Acer A500 tablet device > that has BCM4329 WiFi chip which is connected to NVIDIA Terga20 SoC via > SDIO and found that the following commit causes a solid 5-10 Mbit/s of > WiFi throughput regress

[PATCH v2 0/4] crypto: use kfree_sensitive()

2020-08-26 Thread Denis Efremov
kfree_sensitive() is introduced in commit 453431a54934 ("mm, treewide: rename kzfree() to kfree_sensitive()") and uses memzero_explicit() internally. Thus, we can switch to this API instead of open-coding memzero_explicit() && kfree(). Changes in v2: - if (op->len) check removed Denis Efremov (4

Re: [PATCH] padata: add a reviewer

2020-08-26 Thread Steffen Klassert
On Wed, Aug 26, 2020 at 10:59:23AM -0400, Daniel Jordan wrote: > I volunteer to review padata changes for the foreseeable future. > > Signed-off-by: Daniel Jordan > Cc: Herbert Xu > Cc: Steffen Klassert > Cc: linux-cry...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > MAINTAINERS |

[PATCH v2 3/4] crypto: sun8i-ce - use kfree_sensitive()

2020-08-26 Thread Denis Efremov
Use kfree_sensitive() instead of open-coding it. Signed-off-by: Denis Efremov --- .../crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner

[PATCH v2 2/4] crypto: amlogic - use kfree_sensitive()

2020-08-26 Thread Denis Efremov
Use kfree_sensitive() instead of open-coding it. Signed-off-by: Denis Efremov --- drivers/crypto/amlogic/amlogic-gxl-cipher.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/amlogic/amlogic-gxl-cipher.c

Re: [PATCH 4/4] arm: dts: owl-s500: Add RoseapplePi

2020-08-26 Thread Peter Korsgaard
> "Cristian" == Cristian Ciocaltea writes: > Add a Device Tree for the RoseapplePi SBC. > Signed-off-by: Cristian Ciocaltea Reviewed-by: Peter Korsgaard On a related note: There is now an owl-mmc driver for the s900. From a quick look at the datasheet it looks compatible with the contro

[PATCH v2 1/4] crypto: inside-secure - use kfree_sensitive()

2020-08-26 Thread Denis Efremov
Use kfree_sensitive() instead of open-coding it. Signed-off-by: Denis Efremov --- drivers/crypto/inside-secure/safexcel_hash.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/inside-secure/safexcel_hash.c b/drivers/crypto/inside-secure/safexcel_hash.c index

Re: [PATCH] usb: atm: don't use snprintf() for sysfs attrs

2020-08-26 Thread Rasmus Villemoes
On 25/08/2020 00.23, Alex Dewar wrote: > kernel/cpu.c: don't use snprintf() for sysfs attrs > > As per the documentation (Documentation/filesystems/sysfs.rst), > snprintf() should not be used for formatting values returned by sysfs. > Sure. But then the security guys come along and send a patch s

Re: [PATCH 3/4] libnvdimm: eliminate two unnecessary zero initializations in badrange.c

2020-08-26 Thread Leizhen (ThunderTown)
I will drop this patch, because badrange_add() is unlikely to be called. There's no need to care about trivial performance improvements. On 2020/8/20 22:30, Zhen Lei wrote: > Currently, the "struct badrange_entry" has three members: start, length, > list. In append_badrange_entry(), "start" and "l

Re: Issue with iwd + Linux 5.8.3 + WPA Enterprise

2020-08-26 Thread Ard Biesheuvel
On Thu, 27 Aug 2020 at 00:19, Herbert Xu wrote: > > On Wed, Aug 26, 2020 at 05:42:27PM +0200, Ard Biesheuvel wrote: > > > > I still get a failure in aes_siv_encrypt(), which does not occur with > > the kernel side fix applied. > > Where is this test from? I can't find it in the ell git tree. > It

Re: [PATCH] thermal: sysfs: fall back to vzalloc for cooling device's statistics

2020-08-26 Thread Yue Hu
On Thu, 27 Aug 2020 11:56:46 +0530 Viresh Kumar wrote: > On 27-08-20, 14:20, Yue Hu wrote: > > Currenly, drivers/video/backlight does not call > > thermal_of_cooling_device_register() > > to register thermal cooling device. The issue happened in msm-4.19 kernel > > for > > QCOM/Android platform

Re: [PATCH] fs: Kill DCACHE_DONTCACHE dentry even if DCACHE_REFERENCED is set

2020-08-26 Thread Dave Chinner
On Fri, Aug 21, 2020 at 09:59:53AM +0800, Hao Li wrote: > Currently, DCACHE_REFERENCED prevents the dentry with DCACHE_DONTCACHE > set from being killed, so the corresponding inode can't be evicted. If > the DAX policy of an inode is changed, we can't make policy changing > take effects unless drop

Re: [PATCH 12/30] wireless: ath: wil6210: wmi: Correct misnamed function parameter 'ptr_'

2020-08-26 Thread Lee Jones
On Wed, 26 Aug 2020, Kalle Valo wrote: > Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Function parameter or > > member 'ptr_' not described in 'wmi_buffer_block' > > drivers/net/wireless/ath/wil6210/wmi.c

[PATCH v8 3/3] Wire UFFD up to SELinux

2020-08-26 Thread Lokesh Gidra
From: Daniel Colascione This change gives userfaultfd file descriptors a real security context, allowing policy to act on them. Signed-off-by: Daniel Colascione [Remove owner inode from userfaultfd_ctx] [Use anon_inode_getfd_secure() instead of anon_inode_getfile_secure() in userfaultfd sysca

Re: [PATCH v3 0/7] bugfix and optimize for drivers/nvdimm

2020-08-26 Thread Leizhen (ThunderTown)
Hi all: Any comment? I want to merge patches 1 and 2 into one, then send other patches separately. On 2020/8/20 10:16, Zhen Lei wrote: > v2 --> v3: > 1. Fix spelling error of patch 1 subject: memmory --> memory > 2. Add "Reviewed-by: Oliver O'Halloran " into patch 1 > 3. Rewrite patch descriptio

[PATCH v8 0/3] SELinux support for anonymous inodes and UFFD

2020-08-26 Thread Lokesh Gidra
Userfaultfd in unprivileged contexts could be potentially very useful. We'd like to harden userfaultfd to make such unprivileged use less risky. This patch series allows SELinux to manage userfaultfd file descriptors and in the future, other kinds of anonymous-inode-based file descriptor. SELinux

[PATCH v8 1/3] Add a new LSM-supporting anonymous inode interface

2020-08-26 Thread Lokesh Gidra
From: Daniel Colascione This change adds a new function, anon_inode_getfd_secure, that creates anonymous-node file with individual non-S_PRIVATE inode to which security modules can apply policy. Existing callers continue using the original singleton-inode kind of anonymous-inode file. We can tran

[PATCH v8 2/3] Teach SELinux about anonymous inodes

2020-08-26 Thread Lokesh Gidra
From: Daniel Colascione This change uses the anon_inodes and LSM infrastructure introduced in the previous patch to give SELinux the ability to control anonymous-inode files that are created using the new anon_inode_getfd_secure() function. A SELinux policy author detects and controls these anon

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-26 Thread h...@infradead.org
On Wed, Aug 26, 2020 at 09:43:27PM +, Derrick, Jonathan wrote: > Feel free to review my set to disable the MSI remapping which will make > it perform as well as direct-attached: > > https://patchwork.kernel.org/project/linux-pci/list/?series=325681 So that then we have to deal with your schem

Re: [PATCH v11 00/11] PCI: brcmstb: enable PCIe for STB chips

2020-08-26 Thread Christoph Hellwig
On Tue, Aug 25, 2020 at 10:40:27AM -0700, Florian Fainelli wrote: > Hi, > > On 8/24/2020 12:30 PM, Jim Quinlan wrote: >> >> Patchset Summary: >>Enhance a PCIe host controller driver. Because of its unusual design >>we are foced to change dev->dma_pfn_offset into a more general role >>a

Re: [PATCH 25/32] wireless: ath: wil6210: wmi: Fix formatting and demote non-conforming function headers

2020-08-26 Thread Lee Jones
On Wed, 26 Aug 2020, Kalle Valo wrote: > Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/net/wireless/ath/wil6210/wmi.c:52: warning: Incorrect use of > > kernel-doc format: * Addressing - theory of operations > > drivers/net/wireless/ath/wil6210/wmi.c

Re: [PATCH 2/2] usb: dwc3: Add driver for Xilinx platforms

2020-08-26 Thread Felipe Balbi
Manish Narani writes: > Add a new driver for supporting Xilinx platforms. This driver handles > the USB 3.0 PHY initialization and PIPE control & reset operations for PHY initialization should be done as part of a drivers/phy driver. > ZynqMP platforms. This also handles the USB 2.0 PHY initial

[PATCH] ext4: Fix memleak in add_new_gdb

2020-08-26 Thread Dinghao Liu
When ext4_journal_get_write_access() fails, we should release n_group_desc, iloc.bh, dind and gdb_bh to prevent memleak. It's the same when ext4_handle_dirty_super() fails, but we don't need to release dind here because it has been released before. Signed-off-by: Dinghao Liu --- fs/ext4/resize.c

Re: [PATCH 1/4] arm: dts: owl-s500: Fix incorrect PPI interrupt specifiers

2020-08-26 Thread Peter Korsgaard
> "Cristian" == Cristian Ciocaltea writes: > The PPI interrupts for cortex-a9 were incorrectly specified, fix them. > Fixes: fdfe7f4f9d85 ("ARM: dts: Add Actions Semi S500 and LeMaker Guitar") > Signed-off-by: Cristian Ciocaltea Reviewed-by: Peter Korsgaard -- Bye, Peter Korsgaard

[PATCH v3 2/2] Input: gpio_keys - Simplify with dev_err_probe()

2020-08-26 Thread Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with dev_err_probe() and devm_fwnode_gpiod_get_optional(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Hans de Goede --- Changes since v2: 1. Preserve comment, 2. Include to fix warni

[PATCH v3 1/2] gpio: Add devm_fwnode_gpiod_get_optional() helpers

2020-08-26 Thread Krzysztof Kozlowski
Add devm_fwnode_gpiod_get_optional() and devm_fwnode_gpiod_get_index_optional() helpers, similar to regular devm_gpiod optional versions. Drivers getting GPIOs from a firmware node might use it to remove some boilerplate code. Signed-off-by: Krzysztof Kozlowski --- Changes since v2: 1. Return

Re: [PATCH] ARM: aspeed: g5: Do not set sirq polarity

2020-08-26 Thread Jeremy Kerr
Hi Joel, > A feature was added to the aspeed vuart driver to configure the vuart > interrupt (sirq) polarity according to the LPC/eSPI strapping register. > > Systems that depend on a active low behaviour (sirq_polarity set to 0) > such as OpenPower boxes also use LPC, so this relationship does n

Re: [PATCH] thermal: sysfs: fall back to vzalloc for cooling device's statistics

2020-08-26 Thread Viresh Kumar
On 27-08-20, 14:20, Yue Hu wrote: > Currenly, drivers/video/backlight does not call > thermal_of_cooling_device_register() > to register thermal cooling device. The issue happened in msm-4.19 kernel for > QCOM/Android platform. Backlight in msm-4.19 kernel will register thermal > cooling > device

[PATCH 1/1] watchdog: remove unneeded inclusion of

2020-08-26 Thread Zhen Lei
There has been no reference to "struct sched_param" since commit 94beddacb53c ("sched,watchdog: Convert to sched_set_fifo()"), so there's no need to include any more, delete it. Signed-off-by: Zhen Lei --- drivers/watchdog/watchdog_dev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/driv

Re: [PATCH net backport 5.6.14-5.8.3 v1] net: openvswitch: introduce common code for flushing flows

2020-08-26 Thread Tonghao Zhang
On Wed, Aug 26, 2020 at 6:31 PM Greg KH wrote: > > On Tue, Aug 25, 2020 at 01:25:32PM +0800, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > [ Upstream commit 77b981c82c1df7c7ad32a046f17f007450b46954 ] > > That is not what this commit is :( > > Please fix up and resend with the co

[PATCH net backport to 5.5 - 5.8.3 v2] net: openvswitch: introduce common code for flushing flows

2020-08-26 Thread xiangxia . m . yue
From: Tonghao Zhang [ Upstream commit 1f3a090b9033f69de380c03db3ea1a1015c850cf ] Backport this commit to 5.5 - 5.8.3. To avoid some issues, for example RCU usage warning and double free, we should flush the flows under ovs_lock. This patch refactors table_instance_destroy and introduces table_i

Re: [PATCH v2 1/2] drm/amdkfd: Move the ignore_crat check before the CRAT table get

2020-08-26 Thread Hanjun Guo
On 2020/8/27 12:28, Felix Kuehling wrote: Am 2020-08-26 um 4:29 a.m. schrieb Hanjun Guo: If the ignore_crat is set to non-zero value, it's no point getting the CRAT table, so just move the ignore_crat check before we get the CRAT table. Signed-off-by: Hanjun Guo --- drivers/gpu/drm/amd/amdk

Re: [PATCH v2 2/4] brcmfmac: drop unnecessary "fallthrough" comments

2020-08-26 Thread Dmitry Osipenko
27.08.2020 09:23, Gustavo A. R. Silva пишет: > Hi, > > There is a patch that address this, already: > > https://lore.kernel.org/lkml/20200821063758.GA17783@embeddedor/ > > Thanks Okay, then my patch is unnecessary. Thank you!

arch/parisc/kernel/module.c:965:8: warning: Uninitialized variable: err

2020-08-26 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 15bc20c6af4ceee97a1f90b43c0e386643c071b4 commit: a1326b17ac03a9012cb3d01e434aacb4d67a416c module/ftrace: handle patchable-function-entry date: 10 months ago compiler: hppa-linux-gcc (GCC) 9.3.0 If you fix

Re: [PATCH] thermal: sysfs: fall back to vzalloc for cooling device's statistics

2020-08-26 Thread Yue Hu
On Thu, 27 Aug 2020 10:44:01 +0530 Viresh Kumar wrote: > On 27-08-20, 12:03, Yue Hu wrote: > > Hi Daniel, > > > > Now, i'm just focus on removing the kernel warning based on current code > > logic. > > Commit 8ea229511e06 (thermal: Add cooling device's statistics in sysfs) > > added > > the th

Re: [PATCH v2 2/2] Input: gpio_keys - Simplify with dev_err_probe()

2020-08-26 Thread Krzysztof Kozlowski
On Thu, Aug 27, 2020 at 12:05:51AM +0300, Andy Shevchenko wrote: > On Wednesday, August 26, 2020, Krzysztof Kozlowski wrote: > > > Common pattern of handling deferred probe can be simplified with > > dev_err_probe() and devm_fwnode_gpiod_get_optional(). Less code and > > the error value gets pr

Re: [PATCH v2 2/4] brcmfmac: drop unnecessary "fallthrough" comments

2020-08-26 Thread Gustavo A. R. Silva
Hi, There is a patch that address this, already: https://lore.kernel.org/lkml/20200821063758.GA17783@embeddedor/ Thanks -- Gustavo On 8/27/20 01:04, Dmitry Osipenko wrote: > There is no need to insert the "fallthrough" comment if there is nothing > in-between of case switches. Hence let's remov

Re: [PATCH v2 1/2] gpio: Add devm_fwnode_gpiod_get_optional() helpers

2020-08-26 Thread Krzysztof Kozlowski
On Thu, Aug 27, 2020 at 12:04:13AM +0300, Andy Shevchenko wrote: > On Wednesday, August 26, 2020, Krzysztof Kozlowski wrote: > > > Add devm_fwnode_gpiod_get_optional() and > > devm_fwnode_gpiod_get_index_optional() helpers, similar to regular > > devm_gpiod optional versions. Drivers getting GPI

Re: [PATCH 1/1] block: Set same_page to false in __bio_try_merge_page if ret is false

2020-08-26 Thread Ritesh Harjani
Hello Jens, On 8/21/20 11:41 PM, Ritesh Harjani wrote: If we hit the UINT_MAX limit of bio->bi_iter.bi_size and so we are anyway not merging this page in this bio, then it make sense to make same_page also as false before returning. Without this patch, we hit below WARNING in iomap. This mostly

Re: [PATCH v2 1/4] brcmfmac: increase F2 watermark for BCM4329

2020-08-26 Thread Dmitry Osipenko
27.08.2020 09:04, Dmitry Osipenko пишет: > This patch fixes SDHCI CRC errors during of RX throughput testing on > BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the > checksum problem is observed on NVIDIA Tegra20 SoCs. The good watermark > value is borrowed from downstream BCMDHD d

Re: [PATCH v2 2/2] extcon: ptn5150: Set the VBUS and POLARITY property state

2020-08-26 Thread Ramuthevar, Vadivel MuruganX
Hi, On 27/8/2020 1:35 pm, Chanwoo Choi wrote: Hi, On 8/27/20 2:17 PM, Ramuthevar, Vadivel MuruganX wrote: Hi, On 27/8/2020 12:51 pm, Chanwoo Choi wrote: Hi, You better to change the 'state' word to 'capability'. Actually, this patch doesn't change the value of property. It set the capabilit

Re: [PATCH v3 1/5] arch_topology: validate input frequencies to arch_set_freq_scale()

2020-08-26 Thread Viresh Kumar
On 25-08-20, 12:31, Ionela Voinescu wrote: > On Tuesday 25 Aug 2020 at 11:26:18 (+0530), Viresh Kumar wrote: > > On 24-08-20, 22:02, Ionela Voinescu wrote: > > > The current frequency passed to arch_set_freq_scale() could end up > > > being 0, signaling an error in setting a new frequency. Also, if

[PATCH v4] workqueue: Warn when work flush own workqueue

2020-08-26 Thread Qianli Zhao
From: Qianli Zhao If a workqueue flushes itself then that will lead to a deadlock. Print a warning and a stack trace when this happens. crash> ps 10856 PIDPPID CPU TASK ST COMM 108562 2 ffc873428080 UN [kworker/u16:15] crash> bt 10856 PID: 10856 TASK: ffc8734

Re: [PATCH] Revert "powerpc/powernv/idle: Replace CPU feature check with PVR check"

2020-08-26 Thread Michael Ellerman
Pratik Sampat writes: > On 26/08/20 2:07 pm, Christophe Leroy wrote: >> Le 26/08/2020 à 10:29, Pratik Rajesh Sampat a écrit : >>> Cpuidle stop state implementation has minor optimizations for P10 >>> where hardware preserves more SPR registers compared to P9. >>> The current P9 driver works for P1

Broadcom WiFi SDIO performance regression after commit "mmc: sdhci: Remove finish_tasklet"

2020-08-26 Thread Dmitry Osipenko
Hello! I was debugging WiFi performance problems on Acer A500 tablet device that has BCM4329 WiFi chip which is connected to NVIDIA Terga20 SoC via SDIO and found that the following commit causes a solid 5-10 Mbit/s of WiFi throughput regression after 5.2 kernel: commit c07a48c2651965e84d35cf193d

[PATCH v2 1/4] brcmfmac: increase F2 watermark for BCM4329

2020-08-26 Thread Dmitry Osipenko
This patch fixes SDHCI CRC errors during of RX throughput testing on BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the checksum problem is observed on NVIDIA Tegra20 SoCs. The good watermark value is borrowed from downstream BCMDHD driver and it's matching to the value that is alre

[PATCH v2 3/4] brcmfmac: drop chip id from debug messages

2020-08-26 Thread Dmitry Osipenko
The chip ID was already printed out at the time when debug message about the changed F2 watermark is printed, hence let's drop the unnecessary part of the debug messages. This cleans code a tad and also allows to re-use the F2 watermark debug messages by multiple chips. Suggested-by: Arend van Spr

[PATCH v2 2/4] brcmfmac: drop unnecessary "fallthrough" comments

2020-08-26 Thread Dmitry Osipenko
There is no need to insert the "fallthrough" comment if there is nothing in-between of case switches. Hence let's remove the unnecessary comments in order to make code cleaner a tad. Signed-off-by: Dmitry Osipenko --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 -- drivers/net/

[PATCH v2 0/4] Fixes and improvements for brcmfmac driver

2020-08-26 Thread Dmitry Osipenko
Hello! Recently I was debugging WiFi performance problems on Acer A500 tablet device that got upstreamed recently. This is an older Android device from 2011-2012 that is powered by NVIDIA Tegra20 SoC and it has BCM4329 chip that provides WiFi (SDIO) and Bluetooth (UART). I noticed that WiFi throug

[PATCH v2 4/4] brcmfmac: set F2 SDIO block size to 128 bytes for BCM4329

2020-08-26 Thread Dmitry Osipenko
Setting F2 block size to 128 bytes for BCM4329 allows to significantly improve RX throughput on NVIDIA Tegra20. Before this change the throughput was capped to 30 Mbit/s on Tegra, now throughput is at 40 Mbit/s, which is a maximum throughput for the BCM4329 chip. The F2 block size is borrowed from

Re: [PATCH bpf-next v3 2/4] selftests/bpf: add test for freplace program with write access

2020-08-26 Thread Andrii Nakryiko
On Tue, Aug 25, 2020 at 4:21 PM Udip Pant wrote: > > This adds a selftest that tests the behavior when a freplace target program > attempts to make a write access on a packet. The expectation is that the read > or write > access is granted based on the program type of the linked program and > not

[PATCH 1/1] iommu/vt-d: Use device numa domain if RHSA is missing

2020-08-26 Thread Lu Baolu
If there are multiple NUMA domains but the RHSA is missing in ACPI/DMAR table, we could default to the device NUMA domain as fall back. This also benefits the vIOMMU use case where only a single vIOMMU is exposed, hence no RHSA will be present but device numa domain can be correct. Cc: Jacob Pan

Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged

2020-08-26 Thread Hugh Dickins
On Mon, 24 Aug 2020, Hugh Dickins wrote: > On Tue, 25 Aug 2020, Alex Shi wrote: > > reproduce using our linux-mm random bug collection on NUMA systems. > > >> > > >> OK, I must have missed that this was on ppc. The order makes more sense > > >> now. I will have a look at this next week. > > > > >

Re: [RFC v2] perf/core: Fixes hung issue on perf stat command during cpu hotplug

2020-08-26 Thread Srikar Dronamraju
* Kajol Jain [2020-08-26 20:24:11]: > Commit 2ed6edd33a21 ("perf: Add cond_resched() to task_function_call()") > added assignment of ret value as -EAGAIN in case function > call to 'smp_call_function_single' fails. > For non-zero ret value, it did > 'ret = !ret ? data.ret : -EAGAIN;', which alway

BUG: stack guard page was hit in __zone_watermark_ok

2020-08-26 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:85eb5bc3 net: atheros: switch from 'pci_' to 'dma_' API git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=14e3213990 kernel config: https://syzkaller.appspot.com/x/.config?x=a0437fdd630bee11 dashboar

aarch64-linux-ld: sound/soc/fsl/fsl_asrc_dma.c:211: undefined reference to `dma_request_slave_channel'

2020-08-26 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 15bc20c6af4ceee97a1f90b43c0e386643c071b4 commit: 41206a073ceebc517245677a19f52ba6379b33a9 Merge v5.8-rc6 into drm-next date: 5 weeks ago config: arm64-randconfig-r013-20200826 (attached as .config

[PATCH 1/2] hwmon: (k10temp) Create common functions and macros for Zen CPU families

2020-08-26 Thread Wei Huang
Many SMN thermal registers in Zen CPU families are common across different generations. For long-term code maintenance, it is better to rename these macro and function names to Zen. Signed-off-by: Wei Huang --- drivers/hwmon/k10temp.c | 56 + 1 file change

[PATCH 2/2] hwmon: (k10temp) Define SVI telemetry and current factors for Zen2 CPUs

2020-08-26 Thread Wei Huang
The voltage telemetry registers for Zen2 are different from Zen1. Also the factors of CPU current values are changed on Zen2. Add new definitions for these register. Signed-off-by: Wei Huang --- drivers/hwmon/k10temp.c | 20 1 file changed, 12 insertions(+), 8 deletions(-)

RE: [PATCH v2 1/1] iommu/vt-d: Serialize IOMMU GCMD register modifications

2020-08-26 Thread Tian, Kevin
> From: Lu Baolu > Sent: Thursday, August 27, 2020 12:25 PM > > The VT-d spec requires (10.4.4 Global Command Register, GCMD_REG > General > Description) that: > > If multiple control fields in this register need to be modified, software > must serialize the modifications through multiple writes

Re: [PATCH] perf stat: update POWER9 metrics to utilize other metrics

2020-08-26 Thread Ian Rogers
On Wed, Aug 26, 2020 at 7:06 PM Paul A. Clarke wrote: > > On Wed, Aug 26, 2020 at 09:26:40AM -0700, Ian Rogers wrote: > > On Fri, Aug 14, 2020 at 5:43 AM Arnaldo Carvalho de Melo > > wrote: > > > Em Fri, Aug 14, 2020 at 11:20:42AM +0530, kajoljain escreveu: > > > > On 8/14/20 9:13 AM, Ian Rogers

Re: [RESEND PATCH v4] iommu/mediatek: check 4GB mode by reading infracfg

2020-08-26 Thread Yong Wu
On Wed, 2020-08-26 at 16:56 +0800, Miles Chen wrote: > In previous discussion [1] and [2], we found that it is risky to > use max_pfn or totalram_pages to tell if 4GB mode is enabled. > > Check 4GB mode by reading infracfg register, remove the usage > of the un-exported symbol max_pfn. > > This i

[PATCH] drm/dp: For MST hub, Get max_link_rate&max_lane from extended rx capability field if EXTENDED_RECEIVER_CAPABILITY_FILED_PRESENT is set.

2020-08-26 Thread Koba Ko
Currently, DRM get the capability of the mst hub only from DP_DPCD_REV and get the slower speed even the mst hub can run in the faster speed. As per DP-1.3, First check DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT. If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 1, read the DP_DP13_DPCD_REV to get the fast

[PATCH 2/2] cpufreq: Do WARN() for invalid relation

2020-08-26 Thread Viresh Kumar
The relation can't be invalid here, if it is just WARN() and return 0. Signed-off-by: Viresh Kumar --- include/linux/cpufreq.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 8f141d4c859c..a911e5d06845 100644 --- a/i

[PATCH 1/2] cpufreq: No need to verify cpufreq_driver in show_scaling_cur_freq()

2020-08-26 Thread Viresh Kumar
"cpufreq_driver" is guaranteed to be valid here, no need to check it here. Signed-off-by: Viresh Kumar --- drivers/cpufreq/cpufreq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 02ab56b2a0d8..47aa90f9a7c2 100644

Re: [PATCH v2 2/2] extcon: ptn5150: Set the VBUS and POLARITY property state

2020-08-26 Thread Chanwoo Choi
Hi, On 8/27/20 2:17 PM, Ramuthevar, Vadivel MuruganX wrote: > Hi, > > On 27/8/2020 12:51 pm, Chanwoo Choi wrote: >> Hi, >> >> You better to change the 'state' word to 'capability'. >> Actually, this patch doesn't change the value of property. >> It set the capability value of property. >> >> "Set

Re: [PATCH v2 1/2] extcon: ptn5150: Switch to GENMASK() and BIT() macros

2020-08-26 Thread Ramuthevar, Vadivel MuruganX
Hi, On 27/8/2020 1:26 pm, Chanwoo Choi wrote: - + vendor_id = FIELD_GET(PTN5150_REG_DEVICE_ID_VENDOR, reg_data); + version_id = FIELD_GET(PTN5150_REG_DEVICE_ID_VERSION, reg_data); dev_dbg(info->dev, "Device type: version: 0x%x, vendor: 0x%x\n", version_id, ven

Re: Lockdep warning caused by "driver core: Fix sleeping in invalid context during device link deletion"

2020-08-26 Thread Saravana Kannan
On Thu, Aug 20, 2020 at 8:50 PM Dong Aisheng wrote: > > Hi ALL, > > We met the below WARNING during system suspend on an iMX6Q SDB board > with the latest linus/master branch (v5.9-rc1+) and next-20200820. > v5.8 kernel is ok. So i did bisect and finally found it's caused by > the patch below. > R

Re: [PATCH v2 2/2] extcon: ptn5150: Set the VBUS and POLARITY property state

2020-08-26 Thread Ramuthevar, Vadivel MuruganX
Hi, On 27/8/2020 12:51 pm, Chanwoo Choi wrote: Hi, You better to change the 'state' word to 'capability'. Actually, this patch doesn't change the value of property. It set the capability value of property. "Set the VBUS and POLARITY property capability" Thank you for the review comments, sure

Re: [PATCH v2 1/2] extcon: ptn5150: Switch to GENMASK() and BIT() macros

2020-08-26 Thread Chanwoo Choi
On 8/27/20 12:56 PM, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan > > Switch to GENMASK() and BIT() macros. > > Signed-off-by: Ramuthevar Vadivel Murugan > > Reviewed-by: Krzysztof Kozlowski > --- > drivers/extcon/extcon-ptn5150.c | 43 > +++-

Re: [PATCH] thermal: sysfs: fall back to vzalloc for cooling device's statistics

2020-08-26 Thread Viresh Kumar
On 27-08-20, 12:03, Yue Hu wrote: > Hi Daniel, > > Now, i'm just focus on removing the kernel warning based on current code > logic. > Commit 8ea229511e06 (thermal: Add cooling device's statistics in sysfs) added > the thermal statistics by viresh and viresh gived the patch an acknowledgement > i

linux-next: Tree for Aug 27

2020-08-26 Thread Stephen Rothwell
Hi all, News: There will be no linux-next releases next Monday or Tuesday. Changes since 20200826: The net-next tree gained a conflict against the net tree. Non-merge commits (relative to Linus' tree): 2901 3429 files changed, 100496 insertions(+), 37081 dele

Re: [PATCH 1/2] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-26 Thread Andreas Kemnade
Hi, On Wed, 26 Aug 2020 23:59:50 +0200 Sebastian Reichel wrote: > Hi, > > On Wed, Aug 26, 2020 at 08:28:34PM +0200, Andreas Kemnade wrote: > > On Wed, 26 Aug 2020 19:48:17 +0200 > > Sebastian Reichel wrote: > > > On Sat, Aug 15, 2020 at 06:56:09PM +0200, Andreas Kemnade wrote: > > > > [...

[PATCH v2] debugobjects: install cpu hotplug callback

2020-08-26 Thread qiang.zhang
From: Zqiang Due to cpu hotplug, it may never be online after it's offline, some objects in percpu pool is never free, in order to avoid this happening, install cpu hotplug callback, call this callback func to free objects in percpu pool when cpu going offline. Signed-off-by: Zqiang --- v1->v2

Re: [PATCH] i2c: do not acpi/of match device in i2c_device_probe()

2020-08-26 Thread Sergey Senozhatsky
On (20/08/26 18:16), Andy Shevchenko wrote: > On Wed, Aug 26, 2020 at 11:49:20PM +0900, Sergey Senozhatsky wrote: > > i2c, apparently, can match the same device twice - the first > > time in ->match bus hook (i2c_device_match()), and the second > > one in ->probe (i2c_device_probe()) bus hook. > >

Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444

2020-08-26 Thread Kai Heng Feng
Hi Ville, > On Aug 27, 2020, at 12:24 AM, Ville Syrjälä > wrote: > > On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: >> LSPCON only supports 8 bpc for RGB/YCbCr444. >> >> Set the correct bpp otherwise it renders blank screen. > > Hmm. Does > git://github.com/vsyrjala/linux.git

Re: [PATCH v2 3/3] usb typec: mt6360: Prevent the race condition during module remove

2020-08-26 Thread 啟原黃
Guenter Roeck 於 2020年8月27日 週四 上午11:34寫道: > > On 8/26/20 8:25 PM, cy_huang wrote: > > From: ChiYuan Huang > > > > Prevent the race condition from interrupt and tcpci port unregister > > during module remove. > > > > Signed-off-by: ChiYuan Huang > > Please squash with the first patch of the series

[PATCH v2 1/2] usb typec: mt6360: Add support for mt6360 Type-C driver

2020-08-26 Thread cy_huang
From: ChiYuan Huang Mediatek MT6360 is a multi-functional IC that includes USB Type-C. It works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities. Add fix to Prevent the race condition from interrupt and tcpci port unregister during module remove. Signed-off-b

Re: [PATCH 1/3] dt-bindings: dmaengine: Document qcom,gpi dma binding

2020-08-26 Thread Vinod Koul
On 26-08-20, 08:35, Rob Herring wrote: > On Wed, Aug 26, 2020 at 12:32 AM Vinod Koul wrote: > > > > On 25-08-20, 20:21, Vinod Koul wrote: > > > Hey Rob, > > > > > > On 24-08-20, 11:40, Rob Herring wrote: > > > > On Mon, 24 Aug 2020 14:17:10 +0530, Vinod Koul wrote: > > > > > Add devicetree binding

linux-next: build failure after upgrading sphinx

2020-08-26 Thread Stephen Rothwell
Hi all, Today I upgraded ot sphinx v3.2.1 and got the following error from "make htmldocs": Running Sphinx v3.2.1 enabling CJK for LaTeX builder Extension error: Could not import extension cdomain (exception: cannot import name 'c_funcptr_sig_re' from 'sphinx.domains.c' (/usr/lib/python3/dist-

[PATCH v2 2/2] usb typec: mt6360: Add MT6360 Type-C DT binding documentation

2020-08-26 Thread cy_huang
From: ChiYuan Huang Add a devicetree binding documentation for the MT6360 Type-C driver. Signed-off-by: ChiYuan Huang --- .../bindings/usb/mediatek,mt6360-tcpc.yaml | 73 ++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/

RE: [EXT] Re: [PATCH v2] mwifiex: don't call del_timer_sync() on uninitialized timer

2020-08-26 Thread Ganapathi Bhat
Hi Tetsuo, > > "grep -FrB1 'del_timer' drivers/ | grep -FA1 '.function)'" says that > > currently there are 28 locations which call del_timer[_sync]() only if > > that timer's function field was initialized (because timer_setup() > > sets that timer's function field). Therefore, let's use same app

[tip:ras/core] BUILD SUCCESS 1e36d9c6886849c6f3d3c836370563e6bc1a6ddd

2020-08-26 Thread kernel test robot
allyesconfig mips allmodconfig powerpc defconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a002-20200826 i386

Re: [PATCH v36 22/24] selftests/x86: Add a selftest for SGX

2020-08-26 Thread Nathaniel McCallum
On Thu, Jul 16, 2020 at 9:58 AM Jarkko Sakkinen wrote: > > Add a selftest for SGX. It is a trivial test where a simple enclave > copies one 64-bit word of memory between two memory locations. > > Cc: linux-kselft...@vger.kernel.org > Signed-off-by: Jarkko Sakkinen > --- > tools/testing/selftests

  1   2   3   4   5   6   7   8   9   10   >