[PATCH v5] usb: typec: tcpm: Migrate workqueue to RT priority for processing events

2020-07-30 Thread Badhri Jagan Sridharan
"tReceiverResponse 15 ms Section 6.6.2 The receiver of a Message requiring a response Shall respond within tReceiverResponse in order to ensure that the sender’s SenderResponseTimer does not expire." When the cpu complex is busy running other lower priority work items, TCPM's work queue sometimes

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-30 Thread Christian König
Am 31.07.20 um 08:53 schrieb Greg Kroah-Hartman: On Thu, Jul 30, 2020 at 05:09:07PM -0400, Luben Tuikov wrote: On 2020-07-29 9:49 a.m., Alex Deucher wrote: On Wed, Jul 29, 2020 at 4:11 AM Christian König wrote: Am 28.07.20 um 21:29 schrieb Peilin Ye: Compiler leaves a 4-byte hole near the en

Re: [PATCH v3 2/2] iio: light: as73211: New driver

2020-07-30 Thread Christian Eggers
Good morning Andy, thank you again for the comprehensive feedback! Below I removed everything but possible open points. I'll send v4 soon. Best regards Christian On Thursday, 30 July 2020, 13:31:31 CEST, Andy Shevchenko wrote: > On Thu, Jul 30, 2020 at 1:52 PM Christian Eggers wrote: > > +/** >

Re: [PATCH] MIPS: Provide Kconfig option for default IEEE754 conformance mode

2020-07-30 Thread Huacai Chen
Reviewed-by: Huacai Chen On Fri, Jul 31, 2020 at 2:18 PM Serge Semin wrote: > > On Fri, Jul 31, 2020 at 12:10:16PM +0800, Jiaxun Yang wrote: > > Requested by downstream distros, a Kconfig option for default > > IEEE754 conformance mode allows them to set their mode to > > relaxed by default. > >

Re: [PATCH v2: [linux-4.14.y] ] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-30 Thread Greg KH
On Thu, Jul 30, 2020 at 03:33:42PM -0500, John Donnelly wrote: > From: Mike Snitzer > > Discontinue issuing writethrough write IO in series to the origin and > then cache. > > Use bio_clone_fast() to create a new origin clone bio that will be > mapped to the origin device and then bio_chain() it

[PATCH] scsi: lpfc: Add the missed misc_deregister() for lpfc_init()

2020-07-30 Thread Jing Xiangfeng
lpfc_init() misses to call misc_deregister() in an error path. Add a label 'unregister' to fix it. Signed-off-by: Jing Xiangfeng --- drivers/scsi/lpfc/lpfc_init.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_ini

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-30 Thread Greg Kroah-Hartman
On Thu, Jul 30, 2020 at 05:09:07PM -0400, Luben Tuikov wrote: > On 2020-07-29 9:49 a.m., Alex Deucher wrote: > > On Wed, Jul 29, 2020 at 4:11 AM Christian König > > wrote: > >> > >> Am 28.07.20 um 21:29 schrieb Peilin Ye: > >>> Compiler leaves a 4-byte hole near the end of `dev_info`, causing > >>

Re: upstream boot error: BUG: soft lockup in __do_softirq

2020-07-30 Thread Dmitry Vyukov
On Fri, Jul 31, 2020 at 8:44 AM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:92ed3019 Linux 5.8-rc7 > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=10e84cdf10 > kernel config: https://syzkaller.appspot.com/x/.conf

[PATCH net-next] ip_vti: Fix unused variable warning

2020-07-30 Thread YueHaibing
If CONFIG_INET_XFRM_TUNNEL is set but CONFIG_IPV6 is n, net/ipv4/ip_vti.c:493:27: warning: 'vti_ipip6_handler' defined but not used [-Wunused-variable] Signed-off-by: YueHaibing --- net/ipv4/ip_vti.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c in

Re: [PATCH] arm64/alternatives: move length validation inside the subsection

2020-07-30 Thread Greg KH
On Thu, Jul 30, 2020 at 04:23:31PM +0100, Catalin Marinas wrote: > On Thu, Jul 30, 2020 at 08:13:05AM -0700, Sami Tolvanen wrote: > > On Thu, Jul 30, 2020 at 5:22 AM Catalin Marinas > > wrote: > > > > > > On Wed, Jul 29, 2020 at 02:51:52PM -0700, Sami Tolvanen wrote: > > > > Commit f7b93d42945c (

Re: clocksource: dw_apb_timer: commit 6d2e16a3181b broke Arria10 platform

2020-07-30 Thread Serge Semin
missing clockevent > timers" broke the Arria10 platform. See the bootlog here: > > [0.00] Booting Linux on physical CPU 0x0 > [0.00] Linux version 5.8.0-rc7-next-20200730 (dinguyen@linux-builds1) > (a > rm-linux-gnueabihf-gcc (Linaro GCC 7.2-2017.11) 7.2

[PATCH net 5/5] fsl/fman: fix eth hash table allocation

2020-07-30 Thread Florinel Iordache
Fix memory allocation for ethernet address hash table. The code was wrongly allocating an array for eth hash table which is incorrect because this is the main structure for eth hash table (struct eth_hash_t) that contains inside a number of elements. Fixes: 57ba4c9b ("fsl/fman: Add FMan MAC suppor

[PATCH net 0/5] DPAA FMan driver fixes

2020-07-30 Thread Florinel Iordache
Here are several fixes for the DPAA FMan driver. Florinel Iordache (5): fsl/fman: use 32-bit unsigned integer fsl/fman: fix dereference null return value fsl/fman: fix unreachable code fsl/fman: check dereferencing null pointer fsl/fman: fix eth hash table allocation drivers/net/ethern

[PATCH net 1/5] fsl/fman: use 32-bit unsigned integer

2020-07-30 Thread Florinel Iordache
Potentially overflowing expression (ts_freq << 16 and intgr << 16) declared as type u32 (32-bit unsigned) is evaluated using 32-bit arithmetic and then used in a context that expects an expression of type u64 (64-bit unsigned) which ultimately is used as 16-bit unsigned by typecasting to u16. Fixed

[PATCH net 4/5] fsl/fman: check dereferencing null pointer

2020-07-30 Thread Florinel Iordache
Add a safe check to avoid dereferencing null pointer Fixes: 57ba4c9b ("fsl/fman: Add FMan MAC support") Signed-off-by: Florinel Iordache --- drivers/net/ethernet/freescale/fman/fman_dtsec.c | 4 ++-- drivers/net/ethernet/freescale/fman/fman_memac.c | 3 ++- drivers/net/ethernet/freescale/fman/f

[PATCH net 2/5] fsl/fman: fix dereference null return value

2020-07-30 Thread Florinel Iordache
Check before using returned value to avoid dereferencing null pointer. Fixes: 18a6c85f ("fsl/fman: Add FMan Port Support") Signed-off-by: Florinel Iordache --- drivers/net/ethernet/freescale/fman/fman_port.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net

[PATCH net 3/5] fsl/fman: fix unreachable code

2020-07-30 Thread Florinel Iordache
The parameter 'priority' is incorrectly forced to zero which ultimately induces logically dead code in the subsequent lines. Fixes: 57ba4c9b ("fsl/fman: Add FMan MAC support") Signed-off-by: Florinel Iordache --- drivers/net/ethernet/freescale/fman/fman_memac.c | 1 - 1 file changed, 1 deletion

Re: [PATCH v4 6/6] io_uring: add support for zone-append

2020-07-30 Thread h...@infradead.org
On Fri, Jul 31, 2020 at 06:42:10AM +, Damien Le Moal wrote: > > - We may not be able to use RWF_APPEND, and need exposing a new > > type/flag (RWF_INDIRECT_OFFSET etc.) user-space. Not sure if this > > sounds outrageous, but is it OK to have uring-only flag which can be > > combined with RWF_AP

Re: [PATCH 2/3] driver core: Use rwsem for kill_device() serialization

2020-07-30 Thread Greg Kroah-Hartman
On Thu, Jul 30, 2020 at 11:56:10AM +0200, Lukas Wunner wrote: > On Thu, Jul 30, 2020 at 08:53:26AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Jul 08, 2020 at 03:27:02PM +0200, Lukas Wunner wrote: > > > kill_device() is currently serialized with driver probing by way of the > > > device_lock(). W

Re: [Question] the check of ioeventfd collision in kvm_*assign_ioeventfd_idx

2020-07-30 Thread Paolo Bonzini
On 31/07/20 08:39, Zhenyu Ye wrote: > On 2020/7/31 2:03, Paolo Bonzini wrote: >> Yes, I think it's not needed. Probably the deassign check can be turned into >> an assertion? >> >> Paolo >> > > I think we can do this in the same function, and turnt he check of > p->eventfd into assertion in kvm_d

upstream boot error: BUG: soft lockup in __do_softirq

2020-07-30 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:92ed3019 Linux 5.8-rc7 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10e84cdf10 kernel config: https://syzkaller.appspot.com/x/.config?x=b45e47f6d958ae82 dashboard link: https://syzkaller.appspot

Re: [PATCH v4 6/6] io_uring: add support for zone-append

2020-07-30 Thread Damien Le Moal
On 2020/07/31 3:26, Kanchan Joshi wrote: > On Thu, Jul 30, 2020 at 11:24 PM Jens Axboe wrote: >> >> On 7/30/20 11:51 AM, Kanchan Joshi wrote: >>> On Thu, Jul 30, 2020 at 11:10 PM Pavel Begunkov >>> wrote: On 30/07/2020 20:16, Jens Axboe wrote: > On 7/30/20 10:26 AM, Pavel Begunkov

linux-next: manual merge of the kvm-arm tree with the kvm-fixes tree

2020-07-30 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the kvm-arm tree got a conflict in: arch/arm64/kvm/mmu.c between commit: b757b47a2fcb ("KVM: arm64: Don't inherit exec permission across page-table levels") from the kvm-fixes tree and commit: a0e50aa3f4a8 ("KVM: arm64: Factor out stage 2 page table

Re: [Question] the check of ioeventfd collision in kvm_*assign_ioeventfd_idx

2020-07-30 Thread Zhenyu Ye
On 2020/7/31 2:03, Paolo Bonzini wrote: > Yes, I think it's not needed. Probably the deassign check can be turned into > an assertion? > > Paolo > I think we can do this in the same function, and turnt he check of p->eventfd into assertion in kvm_deassign_ioeventfd_idx(). Just like: ---8<--- s

[PATCH] usb: mtu3: fix panic in mtu3_gadget_disconnect()

2020-07-30 Thread Macpaul Lin
This patch fixes a possible issue when mtu3_gadget_stop() already assigned NULL to mtu->gadget_driver during mtu_gadget_disconnect(). Backtrace: [] notifier_call_chain+0xa4/0x128 [] __atomic_notifier_call_chain+0x84/0x138 [] notify_die+0xb0/0x120 [] die+0x1f8/0x5d0 [] __do_kernel_fault+0x19c/0x280

Re: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-30 Thread Greg KH
On Thu, Jul 30, 2020 at 09:40:32AM -0500, John Donnelly wrote: > > > > On Jul 30, 2020, at 12:21 AM, Greg KH wrote: > > > > On Wed, Jul 29, 2020 at 06:45:46PM -0500, John Donnelly wrote: > >> > >> > >> On 7/29/20 9:16 AM, Mike Snitzer wrote: > >>> On Wed, Jul 29 2020 at 7:55am -0400, > >>> G

Re: add file system helpers that take kernel pointers for the init code v4

2020-07-30 Thread Christoph Hellwig
On Fri, Jul 31, 2020 at 03:14:24AM +0100, Al Viro wrote: > Christoph Hellwig (28): > [snip] > initramfs: switch initramfs unpacking to struct file based APIs > initramfs: switch initramfs unpacking to struct file based APIs > [snip] > > It's not a bisect hazard, of course, but if you d

[PATCH] ASoC: fsl_sai: Fix value of FSL_SAI_CR1_RFW_MASK

2020-07-30 Thread Shengjiu Wang
The fifo_depth is 64 on i.MX8QM/i.MX8QXP, 128 on i.MX8MQ, 16 on i.MX7ULP. Original FSL_SAI_CR1_RFW_MASK value 0x1F is not suitable for these platform, the FIFO watermark mask should be updated according to the fifo_depth. Fixes: a860fac42097 ("ASoC: fsl_sai: Add support for imx7ulp/imx8mq") Signe

Re: [PATCH v3 3/4] iommu: Add iommu_aux_get_domain_for_dev()

2020-07-30 Thread Lu Baolu
Hi Alex, On 2020/7/30 4:25, Alex Williamson wrote: On Tue, 14 Jul 2020 13:57:02 +0800 Lu Baolu wrote: The device driver needs an API to get its aux-domain. A typical usage scenario is: unsigned long pasid; struct iommu_domain *domain; struct device *dev = mdev_dev(

Re: [RFC] ALSA: hda: Add workaround to adapt to Loongson 7A1000 controller

2020-07-30 Thread Takashi Iwai
On Fri, 31 Jul 2020 04:41:54 +0200, Kaige Li wrote: > > There's some issues that cause palyback without a sound on Loongson > platform (3A3000 + 7A1000) with a Realtek ALC269 codec. After lengthy > debugging sessions, we solved it by adding workaround. > > Signed-off-by: Kaige Li Thanks for the

Re: [RFC][PATCH] exec: Conceal the other threads from wakeups during exec

2020-07-30 Thread Oleg Nesterov
Eric, I won't comment the intent, but I too do not understand this idea. On 07/30, Eric W. Biederman wrote: > > [This change requires more work to handle TASK_STOPPED and TASK_TRACED] Yes. And it is not clear to me how can you solve this. > [This adds a new lock ordering dependency siglock -> pi

Re: [PATCH][next] habanalabs: fix incorrect check on failed workqueue create

2020-07-30 Thread Greg Kroah-Hartman
On Thu, Jul 30, 2020 at 01:51:48PM +0300, Oded Gabbay wrote: > On Thu, Jul 30, 2020 at 11:20 AM Colin King wrote: > > > > From: Colin Ian King > > > > The null check on a failed workqueue create is currently null checking > > hdev->cq_wq rather than the pointer hdev->cq_wq[i] and so the test > >

Re: [PATCH] sched: Provide USF for the portable equipment.

2020-07-30 Thread Greg KH
On Thu, Jul 30, 2020 at 09:35:43PM +0800, Dongdong Yang wrote: > From: Dongdong Yang > > The power consumption and UI response are more cared > for by the portable equipment users. USF(User Sensitive > Feedback factor) auxiliary cpufreq governor is > providing more utils adjustment settings to a

Re: [PATCH V4 2/3] mfd: Intel Platform Monitoring Technology support

2020-07-30 Thread Lee Jones
On Wed, 29 Jul 2020, Mark D Rustad wrote: > at 12:58 AM, Lee Jones wrote: > > > If you do: > > > > do { > > int pos; > > > > pos = pci_find_next_ext_capability(pdev, pos, > > PCI_EXT_CAP_ID_DVSEC); > > if (!pos) > > break; > > > > T

Re: [PATCH] MIPS: Provide Kconfig option for default IEEE754 conformance mode

2020-07-30 Thread Serge Semin
On Fri, Jul 31, 2020 at 12:10:16PM +0800, Jiaxun Yang wrote: > Requested by downstream distros, a Kconfig option for default > IEEE754 conformance mode allows them to set their mode to > relaxed by default. That's what should have been here in the first place. Thanks! Reviewed-by: Serge Semin >

[PATCH bpf-next] bpf: fix compilation warning of selftests

2020-07-30 Thread Jianlin Lv
Clang compiler version: 12.0.0 The following warning appears during the selftests/bpf compilation: prog_tests/send_signal.c:51:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] 51 | write(pipe_c2p[1], buf, 1); | ^~~~

Re: [PATCH] sched: Provide USF for the portable equipment.

2020-07-30 Thread Greg KH
On Thu, Jul 30, 2020 at 09:35:42PM +0800, Dongdong Yang wrote: > From: Dongdong Yang > > This patch provides USF(User Sensitive Feedback factor) > auxiliary cpufreq governor to support high level layer > sysfs inodes setting for utils adjustment purpose from > the identified scenario on portable

Re: [PATCH v2] drm/connector: Add of_drm_find_connector

2020-07-30 Thread Daniel Vetter
On Fri, Jul 31, 2020 at 4:33 AM Andy Yan wrote: > > ping > > On 7/3/20 5:45 PM, Andy Yan wrote: > > Add a function to look up a connector by > > device tree node, like what of_drm_find_bridge/panel > > does. > > > > Signed-off-by: Andy Yan > > Reported-by: kernel test robot I'm pretty sure the

Re: [PATCH] drm/amdkfd: Put ACPI table after using it

2020-07-30 Thread Hanjun Guo
On 2020/7/31 10:41, Felix Kuehling wrote: Hi Hanjun, Sorry for the late reply. Thank you for the patch and the explanation. This seems to have been broken since the first version of KFD in 2014. See one suggestion inline. Am 2020-07-22 um 5:48 a.m. schrieb Hanjun Guo: The acpi_get_table() sho

[PATCH v2] exfat: retain 'VolumeFlags' properly

2020-07-30 Thread Tetsuhiro Kohada
Retain ActiveFat, MediaFailure and ClearToZero fields. And, never clear VolumeDirty, if it is dirty at mount. In '3.1.13.3 Media Failure Field' of exfat specification says ... If, upon mounting a volume, the value of this field is 1, implementations which scan the entire volume for media failure

linux-next: build failure after merge of the tip tree

2020-07-30 Thread Stephen Rothwell
Hi all, After merging the tip tree, today's linux-next build (arm multi_v7_defconfig) failed like this: In file included from include/asm-generic/getorder.h:8, from arch/arm/include/asm/page.h:166, from arch/arm/include/asm/thread_info.h:14, from

Re: [PATCH 1/1] iommu/arm-smmu: Implement qcom,skip-init

2020-07-30 Thread Bjorn Andersson
On Wed 22 Jul 13:11 PDT 2020, Konrad Dybcio wrote: > >Is the problem on SDM630 that when you write to SMR/S2CR the device > >reboots? Or that when you start writing out the context bank > >configuration that trips the display and the device reboots? > > I added some debug prints and the phone han

Re: [PATCH] lib: Convert test_uuid.c to KUnit

2020-07-30 Thread Brendan Higgins
On Thu, Jul 30, 2020 at 5:18 AM Arpitha Raghunandan <98.a...@gmail.com> wrote: > > Converts test lib/test_uuid.c to KUnit Can you add some more detail to the commit message? Maybe link to KUnit and say something about why this change is beneficial. > Signed-off-by: Arpitha Raghunandan <98.a...@gm

Re: [PATCH v3 2/4] iommu: Add iommu_aux_at(de)tach_group()

2020-07-30 Thread Lu Baolu
Hi Alex, On 2020/7/31 3:46, Alex Williamson wrote: On Wed, 29 Jul 2020 23:34:40 + "Tian, Kevin" wrote: From: Alex Williamson Sent: Thursday, July 30, 2020 4:04 AM On Thu, 16 Jul 2020 09:07:46 +0800 Lu Baolu wrote: Hi Jacob, On 7/16/20 12:01 AM, Jacob Pan wrote: On Wed, 15 Jul 20

Re: arm64: pointer_auth.h:40:3: error: implicit declaration of function 'get_random_bytes'; did you mean 'get_random_once'?

2020-07-30 Thread Willy Tarreau
On Thu, Jul 30, 2020 at 10:25:41PM -0700, Linus Torvalds wrote: > On Thu, Jul 30, 2020 at 7:16 PM Willy Tarreau wrote: > > > > Don't you want to take Mark's patch anyway in addition to all this ? In > > case anyone meets yet another build issue, they'd have more luck trying > > to revert any other

Re: [PATCH v5 3/4] ARM: dts: sun8i-a83t-tbs-a711: Add support for the vibrator motor

2020-07-30 Thread Marco Felsch
Hi Ondrej, On 20-07-30 15:24, Ondrej Jirman wrote: > The board has a vibrator motor. Hook it to the input subsystem. > > According to the PMIC specification, LDO needs to be enabled (value 0b11) > to achieve the specified max driving current of 150mA. We can't drive > the motor with just GPIO mod

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-07-30 Thread Greg Kroah-Hartman
On Fri, Jul 31, 2020 at 07:53:01AM +0300, Leon Romanovsky wrote: > On Thu, Jul 30, 2020 at 03:20:26PM -0400, Peilin Ye wrote: > > rds_notify_queue_get() is potentially copying uninitialized kernel stack > > memory to userspace since the compiler may leave a 4-byte hole at the end > > of `cmsg`. > >

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-07-30 Thread Greg Kroah-Hartman
On Fri, Jul 31, 2020 at 07:33:06AM +0200, Greg Kroah-Hartman wrote: > On Fri, Jul 31, 2020 at 07:53:01AM +0300, Leon Romanovsky wrote: > > On Thu, Jul 30, 2020 at 03:20:26PM -0400, Peilin Ye wrote: > > > rds_notify_queue_get() is potentially copying uninitialized kernel stack > > > memory to usersp

Re: arm64: pointer_auth.h:40:3: error: implicit declaration of function 'get_random_bytes'; did you mean 'get_random_once'?

2020-07-30 Thread Linus Torvalds
On Thu, Jul 30, 2020 at 7:16 PM Willy Tarreau wrote: > > Don't you want to take Mark's patch anyway in addition to all this ? In > case anyone meets yet another build issue, they'd have more luck trying > to revert any other patch. Right now if they revert one, it breaks the > build in a different

Re: [PATCH -next] 9p: Remove unneeded cast from memory allocation

2020-07-30 Thread Dominique Martinet
Li Heng wrote on Wed, Jul 29, 2020: > Remove casting the values returned by memory allocation function. > > Coccinelle emits WARNING: > > ./fs/9p/vfs_inode.c:226:12-29: WARNING: casting value returned by memory > allocation function to (struct v9fs_inode *) is useless. > > Signed-off-by: Li Hen

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

2020-07-30 Thread 张云海
Remove whitespace at EOL On 2020/7/30 18:39, 张云海 wrote: > Update the patch, add CC list, sample output, and Jiri's PoC. > > On 2020/7/30 14:46, Jiri Slaby wrote: >> Hi, OTOH, you should have CCed all the (public) lists. > >From ad143ede24ff4e61292cc9c96000100aacd97259 Mon Sep 17 00:00:00 2001 F

[PATCH] USB: quirks: Add no-lpm quirk for another Raydium touchscreen

2020-07-30 Thread Kai-Heng Feng
There's another Raydium touchscreen needs the no-lpm quirk: [1.339149] usb 1-9: New USB device found, idVendor=2386, idProduct=350e, bcdDevice= 0.00 [1.339150] usb 1-9: New USB device strings: Mfr=1, Product=2, SerialNumber=0 [1.339151] usb 1-9: Product: Raydium Touch System [1.339

Re: linux-next: build warnings after merge of the mac80211-next tree

2020-07-30 Thread Thomas Pedersen
On 2020-07-30 20:28, Stephen Rothwell wrote: Hi all, After merging the mac80211-next tree, today's linux-next build (x86_64 allmodconfig) produced these warnings: Thanks Stephen. I'll send a fix against mac80211-next to linux-wireless. -- thomas

Re: issue with uninitialized value used in a comparison in gbcodec_mixer_dapm_ctl_put

2020-07-30 Thread Vaibhav Agarwal
On Thu, Jul 30, 2020 at 05:02:22PM +0100, Colin Ian King wrote: > Hi, > > Static analysis with Coverity has detected an uninitialized value being > used in a comparison. The error was detected on a recent change to > drivers/staging/greybus/audio_topology.c however the issue actually > dates back

[PATCH] [net/ethtool] ethnl_set_linkmodes: remove redundant null check

2020-07-30 Thread Gaurav Singh
info cannot be NULL here since its being accessed earlier in the function: nlmsg_parse(info->nlhdr...). Remove this redundant NULL check. Signed-off-by: Gaurav Singh --- net/ethtool/linkmodes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ethtool/linkmodes.c b/net/et

[PATCH 2/3] phy: qcom-qmp: Register as a typec switch for orientation detection

2020-07-30 Thread Wesley Cheng
The lane select switch for USB typec orientation is within the USB QMP PHY. the current device. It could be connected through an endpoint, to an independent device handling the typec detection, ie the QCOM SPMI typec driver. Signed-off-by: Wesley Cheng --- drivers/phy/qualcomm/Kconfig|

[PATCH 0/3] Enable USB type C support on SM8150

2020-07-30 Thread Wesley Cheng
This series adds support for setting of the orientation multiplexor within the QMP PHY based on the detection output from the PM8150B. It will also introduce a role switch in DWC3 QCOM, which is used so that the DWC3 QCOM glue can receive role switch change events, and set the vbus override accord

[PATCH 3/3] usb: dwc3: dwc3-qcom: Find USB connector and register role switch

2020-07-30 Thread Wesley Cheng
If registering a USB typeC connector, the connector node may not be a child of the DWC3 QCOM device. Utilize devcon graph search to lookup if any remote endpoints contain the connector. If a connector is present, the DWC3 QCOM will register a USB role switch to receive role change events, as well

[PATCH 1/3] arm64: boot: dts: qcom: sm8150: Add nodes for PMIC based typec detection

2020-07-30 Thread Wesley Cheng
Introduce required child nodes to enable the PMIC based USB type C driver. This consits of connector and endpoint nodes to drivers, which manage the type C mux and the USB role switch. Signed-off-by: Wesley Cheng --- arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 37 - 1 file

Re: [PATCH] vgacon: Fix an out-of-bounds in vgacon_scrollback_update()

2020-07-30 Thread Jiri Slaby
Hi, On 31. 07. 20, 5:23, Yang Yingliang wrote: > void execute_one(void) > { > intptr_t res = 0; > res = syz_open_dev(0xc, 4, 1); open(/dev/tty1) > if (res != -1) > r[0] = res; > *(uint16_t*)0x2000 = 0xc; > *(uint16_t*)0x2002 = 0x373; > *(uint16_t*)

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-07-30 Thread Leon Romanovsky
On Thu, Jul 30, 2020 at 03:20:26PM -0400, Peilin Ye wrote: > rds_notify_queue_get() is potentially copying uninitialized kernel stack > memory to userspace since the compiler may leave a 4-byte hole at the end > of `cmsg`. > > In 2016 we tried to fix this issue by doing `= { 0 };` on `cmsg`, which

[Linux-kernel-mentees] [PATCH net] openvswitch: Prevent kernel-infoleak in ovs_ct_put_key()

2020-07-30 Thread Peilin Ye
ovs_ct_put_key() is potentially copying uninitialized kernel stack memory into socket buffers, since the compiler may leave a 3-byte hole at the end of `struct ovs_key_ct_tuple_ipv4` and `struct ovs_key_ct_tuple_ipv6`. Fix it by initializing `orig` with memset(). Cc: sta...@vger.kernel.org Fixes:

[PATCH v9 5/5] mm: kasan: Do not panic if both panic_on_warn and kasan_multishot set

2020-07-30 Thread David Gow
KASAN errors will currently trigger a panic when panic_on_warn is set. This renders kasan_multishot useless, as further KASAN errors won't be reported if the kernel has already paniced. By making kasan_multishot disable this behaviour for KASAN errors, we can still have the benefits of panic_on_war

[PATCH v9 4/5] KASAN: Testing Documentation

2020-07-30 Thread David Gow
From: Patricia Alfonso Include documentation on how to test KASAN using CONFIG_TEST_KASAN_KUNIT and CONFIG_TEST_KASAN_MODULE. Signed-off-by: Patricia Alfonso Signed-off-by: David Gow Reviewed-by: Andrey Konovalov Reviewed-by: Dmitry Vyukov Acked-by: Brendan Higgins --- Documentation/dev-to

[PATCH v9 3/5] KASAN: Port KASAN Tests to KUnit

2020-07-30 Thread David Gow
From: Patricia Alfonso Transfer all previous tests for KASAN to KUnit so they can be run more easily. Using kunit_tool, developers can run these tests with their other KUnit tests and see "pass" or "fail" with the appropriate KASAN report instead of needing to parse each KASAN report to test KASA

[PATCH v9 1/5] Add KUnit Struct to Current Task

2020-07-30 Thread David Gow
From: Patricia Alfonso In order to integrate debugging tools like KASAN into the KUnit framework, add KUnit struct to the current task to keep track of the current KUnit test. Signed-off-by: Patricia Alfonso Reviewed-by: Brendan Higgins Signed-off-by: David Gow --- include/linux/sched.h | 4

[PATCH v9 2/5] KUnit: KASAN Integration

2020-07-30 Thread David Gow
From: Patricia Alfonso Integrate KASAN into KUnit testing framework. - Fail tests when KASAN reports an error that is not expected - Use KUNIT_EXPECT_KASAN_FAIL to expect a KASAN error in KASAN tests - Expected KASAN reports pass tests and are still printed when ru

[PATCH v9 0/5] KASAN-KUnit Integration

2020-07-30 Thread David Gow
This patchset contains everything needed to integrate KASAN and KUnit. KUnit will be able to: (1) Fail tests when an unexpected KASAN error occurs (2) Pass tests when an expected KASAN error occurs Convert KASAN tests to KUnit with the exception of copy_user_test because KUnit is unable to test t

Re: [git pull] drm fixes for 5.8-rc8 (part 2)

2020-07-30 Thread pr-tracker-bot
The pull request you sent on Fri, 31 Jul 2020 13:44:54 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2020-07-31 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d8b9faec54ae4bc2fff68bcd0befa93ace8256ce Thank you! -- Deet-doot-dot, I am a bot. https://k

[PATCH] MIPS: BMIPS: Disable pref 30 for buggy CPUs

2020-07-30 Thread Florian Fainelli
Disable pref 30 by utilizing the standard quirk method and matching the affected SoCs: 7344, 7346, 7425. Signed-off-by: Florian Fainelli --- arch/mips/bmips/setup.c | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c index 1930

[PATCH net-next] tun: add missing rcu annotation in tun_set_ebpf()

2020-07-30 Thread Jason Wang
We expecte prog_p to be protected by rcu, so adding the rcu annotation to fix the following sparse warning: drivers/net/tun.c:3003:36: warning: incorrect type in argument 2 (different address spaces) drivers/net/tun.c:3003:36:expected struct tun_prog [noderef] __rcu **prog_p drivers/net/tun.c

Re: [PATCH 1/2] kbuild: move shared library build rules to scripts/gcc-plugins/Makefile

2020-07-30 Thread Masahiro Yamada
On Thu, Jul 30, 2020 at 6:18 AM Kees Cook wrote: > > On Wed, Jul 29, 2020 at 12:15:36PM +0900, Masahiro Yamada wrote: > > The shared library build rules are currently implemented in > > scripts/Makefile.host, but actually GCC-plugin is the only user of > > them. Hence, they do not need to be treew

[PATCH] MIPS: Provide Kconfig option for default IEEE754 conformance mode

2020-07-30 Thread Jiaxun Yang
Requested by downstream distros, a Kconfig option for default IEEE754 conformance mode allows them to set their mode to relaxed by default. Signed-off-by: Jiaxun Yang --- arch/mips/Kconfig| 21 + arch/mips/kernel/cpu-probe.c | 12 +++- 2 files changed, 32

[PATCH] MIPS: Provide Kconfig option for default IEEE754 conformance mode

2020-07-30 Thread Jiaxun Yang
Requested by downstream distros, a Kconfig option for default IEEE754 conformance mode allows them to set their mode to relaxed by default. Signed-off-by: Jiaxun Yang --- arch/mips/Kconfig| 21 + arch/mips/kernel/cpu-probe.c | 12 +++- 2 files changed, 32

Re: linux-next: Tree for Jul 30 [build failure on arm64]

2020-07-30 Thread Stephen Rothwell
Hi all, On Fri, 31 Jul 2020 10:46:52 +0800 Shaokun Zhang wrote: > > There's a build failure on arm64: > > In file included from ./include/linux/compat.h:17:0, > from ./arch/arm64/include/asm/stat.h:13, > from ./include/linux/stat.h:6, > from ./

Re: [PATCH v2] mm: vmstat: fix /proc/sys/vm/stat_refresh generating false warnings

2020-07-30 Thread Hugh Dickins
On Thu, 30 Jul 2020, Roman Gushchin wrote: > On Wed, Jul 29, 2020 at 08:45:47PM -0700, Hugh Dickins wrote: > > > > But a better idea is perhaps to redefine the behavior of > > "echo >/proc/sys/vm/stat_refresh". What if > > "echo someparticularstring >/proc/sys/vm/stat_refresh" were to > > disable

Re: [PATCH v4] scsi: ufs: Cleanup completed request without interrupt notification

2020-07-30 Thread Bart Van Assche
On 2020-07-30 18:30, Stanley Chu wrote: > On Mon, 2020-07-27 at 11:18 +, Avri Altman wrote: >> Looks good to me. >> But better wait and see if Bart have any further reservations. > > Would you have any further suggestions? Today is the first time that I took a look at ufshcd_abort(). The appr

Re: [External] Re: [PATCH 1/2] ftrace: clear module from hash of all ftrace ops

2020-07-30 Thread Chengming Zhou
在 2020/7/29 上午1:26, Steven Rostedt 写道: > On Wed, 29 Jul 2020 00:59:33 +0800 > Chengming Zhou wrote: > > >>> i.e. >>> >>> # echo some_module_function > set_ftrace_filter >>> # rmmod module_with_that_function >>> # insmod module_with_same_address_of_function >>> # echo function > current_t

Re: linux-next: manual merge of the devfreq tree with the arm-soc tree

2020-07-30 Thread Stephen Rothwell
Hi all, On Mon, 27 Jul 2020 20:16:00 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the devfreq tree got a conflict in: > > MAINTAINERS > > between commit: > > 8a9ff8758159 ("MAINTAINERS: Add Krzysztof Kozlowski as maintainer of memory > controllers") > > from the arm-soc

Re: [PATCH] erofs: fold in used-once helper erofs_workgroup_unfreeze_final()

2020-07-30 Thread Gao Xiang
On Fri, Jul 31, 2020 at 11:49:04AM +0800, Chao Yu wrote: > On 2020/7/30 2:02, Gao Xiang wrote: > > It's expected that erofs_workgroup_unfreeze_final() won't > > be used in other places. Let's fold it to simplify the code. > > > > Signed-off-by: Gao Xiang > > Reviewed-by: Chao Yu Thanks for the

drivers/vfio/pci/vfio_pci_nvlink2.c:100:9: error: implicit declaration of function 'mm_iommu_put'; did you mean

2020-07-30 Thread kernel test robot
Hi Chen, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 417385c47ef7ee0d4f48f63f70cca6c1ed6355f4 commit: ee8642162a9edd40daafd3fb894e3fd3f909e361 drm/nouveau: fix build error without CONFIG_IOMMU_API date: 6 mont

Re: [PATCH v2] clk: bcm2835: Do not use prediv with bcm2711's PLLs

2020-07-30 Thread Florian Fainelli
On 7/30/2020 11:26 AM, Nicolas Saenz Julienne wrote: > Contrary to previous SoCs, bcm2711 doesn't have a prescaler in the PLL > feedback loop. Bypass it by zeroing fb_prediv_mask when running on > bcm2711. > > Note that, since the prediv configuration bits were re-purposed, this > was triggerin

Re: [PATCH] erofs: fold in used-once helper erofs_workgroup_unfreeze_final()

2020-07-30 Thread Chao Yu
On 2020/7/30 2:02, Gao Xiang wrote: It's expected that erofs_workgroup_unfreeze_final() won't be used in other places. Let's fold it to simplify the code. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH] erofs: remove WQ_CPU_INTENSIVE flag from unbound wq's

2020-07-30 Thread Chao Yu
On 2020/7/31 10:40, Gao Xiang via Linux-erofs wrote: From: Gao Xiang The documentation [1] says that WQ_CPU_INTENSIVE is "meaningless" for unbound wq. I remove this flag from places where unbound queue is allocated. This is supposed to improve code readability. [1] https://www.kernel.org/doc/h

Re: [PATCH 1/2] rcu/tree: Add a warning if CPU being onlined did not report QS already

2020-07-30 Thread Paul E. McKenney
On Thu, Jul 30, 2020 at 09:42:22PM -0400, Joel Fernandes wrote: > On Thu, Jul 30, 2020 at 09:21:59AM -0700, Paul E. McKenney wrote: > > On Wed, Jul 29, 2020 at 11:02:20PM -0400, Joel Fernandes (Google) wrote: > > > Add a warning if CPU being onlined did not report QS already. This is to > > > simpl

[git pull] drm fixes for 5.8-rc8 (part 2)

2020-07-30 Thread Dave Airlie
Hi Linus, As mentioned previously this contains the nouveau regression fix, amdgpu had 3 fixes outstanding as well, one revert, an info leak and use after free. The use after free is a bit trickier than I'd like, and I've personally gone over it to confirm I'm happy that it is doing what it says.

[PATCH v2 2/2] PCI: Reduce warnings on possible RW1C corruption

2020-07-30 Thread Mark Tomlinson
For hardware that only supports 32-bit writes to PCI there is the possibility of clearing RW1C (write-one-to-clear) bits. A rate-limited messages was introduced by fb2659230120, but rate-limiting is not the best choice here. Some devices may not show the warnings they should if another device has j

[PATCH v2 1/2] PCI: iproc: Set affinity mask on MSI interrupts

2020-07-30 Thread Mark Tomlinson
The core interrupt code expects the irq_set_affinity call to update the effective affinity for the interrupt. This was not being done, so update iproc_msi_irq_set_affinity() to do so. Fixes: 3bc2b2348835 ("PCI: iproc: Add iProc PCIe MSI support") Signed-off-by: Mark Tomlinson --- changes in v2:

[PATCH] acpi: fix 'return' with no value build warning

2020-07-30 Thread Neal Liu
Fixing CFI issue which introduced by commit efe9711214e6 is incomplete. Add return value to fix return-type build warning. Signed-off-by: Neal Liu --- drivers/acpi/processor_idle.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/processor_idle.c b/drivers/

acpi: fix 'return' with no value build warning

2020-07-30 Thread Neal Liu
*** BLURB HERE *** Neal Liu (1): acpi: fix 'return' with no value build warning drivers/acpi/processor_idle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.18.0

[PATCH] mm/memcg: remove useless check on page->mem_cgroup

2020-07-30 Thread Alex Shi
Since readahead page will be charged on memcg too. We don't need to check this exception now. Rmove them is safe as all user pages are charged before use. Signed-off-by: Alex Shi Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: Andrew Morton Cc: cgro...@vger.kernel.org Cc: linux.

linux-next: build warnings after merge of the mac80211-next tree

2020-07-30 Thread Stephen Rothwell
Hi all, After merging the mac80211-next tree, today's linux-next build (x86_64 allmodconfig) produced these warnings: drivers/net/wireless/ath/ath10k/mac.c: In function 'chan_to_phymode': drivers/net/wireless/ath/ath10k/mac.c:558:3: warning: enumeration value 'NL80211_CHAN_WIDTH_1' not handled i

Re: [PATCH v2 1/3] KVM: x86: Deflect unknown MSR accesses to user space

2020-07-30 Thread Jim Mattson
On Thu, Jul 30, 2020 at 4:53 PM Jim Mattson wrote: > > On Thu, Jul 30, 2020 at 4:08 PM Alexander Graf wrote: > > Do you have a particular situation in mind where that would not be the > > case and where we would still want to actually complete an MSR operation > > after the environment changed? >

Re: [PATCH v10 22/28] media: platform: Change the call functions of getting/enable/disable the jpeg's clock

2020-07-30 Thread Xia Jiang
On Thu, 2020-07-30 at 16:34 +, Tomasz Figa wrote: > Hi Xia, > > On Thu, Jul 23, 2020 at 11:04:45AM +0800, Xia Jiang wrote: > > Use the generic of_property_* helpers to get the clock_nums and clocks > > from device tree. > > Use the generic clk_bulk_* helpers to enable and disable clocks. > >

Re: [PATCH v2 3/3] KVM: SVM: Fix disable pause loop exit/pause filtering capability on SVM

2020-07-30 Thread Wanpeng Li
On Thu, 30 Jul 2020 at 19:16, Vitaly Kuznetsov wrote: > > Wanpeng Li writes: > > > On Wed, 29 Jul 2020 at 20:21, Vitaly Kuznetsov wrote: > >> > >> Wanpeng Li writes: > >> > >> > From: Wanpeng Li > >> > > >> > Commit 8566ac8b (KVM: SVM: Implement pause loop exit logic in SVM) drops > >> > disab

[PATCH mmotm] mm: memcontrol: decouple reference counting from page accounting fix

2020-07-30 Thread Hugh Dickins
Moving tasks between mem cgroups with memory.move_charge_at_immigrate 3, while swapping, crashes soon on mmotm (and so presumably on linux-next): for example, spinlock found corrupted when lock_page_memcg() is called. It's as if the mem cgroup structures have been freed too early. Stab in the dark

BUG: unable to handle kernel paging request in __syscall_return_slowpath

2020-07-30 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:04300d66 Merge tag 'riscv-for-linus-5.8-rc7' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13e6fb6490 kernel config: https://syzkaller.appspot.com/x/.config?x=f87a5e4232fdb267 das

[PATCH v3 3/3] KVM: SVM: Fix disable pause loop exit/pause filtering capability on SVM

2020-07-30 Thread Wanpeng Li
From: Wanpeng Li 'Commit 8566ac8b8e7c ("KVM: SVM: Implement pause loop exit logic in SVM")' drops disable pause loop exit/pause filtering capability completely, I guess it is a merge fault by Radim since disable vmexits capabilities and pause loop exit for SVM patchsets are merged at the same

WARNING: ODEBUG bug in cancel_delayed_work

2020-07-30 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:27a2145d ibmvnic: Fix IRQ mapping disposal in error path git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=1427784890 kernel config: https://syzkaller.appspot.com/x/.config?x=ca6448d2af2ba351 dashboard li

WARNING in cancel_delayed_work

2020-07-30 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:83bdc727 random32: remove net_rand_state from the latent e.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10479f1290 kernel config: https://syzkaller.appspot.com/x/.config?x=e59ee776d5aa8d55 das

  1   2   3   4   5   6   7   8   9   10   >