Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

2020-06-24 Thread Greg KH
On Thu, Jun 25, 2020 at 07:46:10AM +0100, Lee Jones wrote: > Kerneldoc syntax is used, but not complete. Descriptions required. > > Prevents warnings like: > > drivers/mfd/wm8350-core.c:136: warning: Function parameter or member > 'wm8350' not described in 'wm8350_reg_lock' > drivers/mfd/wm83

Re: [PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments

2020-06-24 Thread Greg KH
On Thu, Jun 25, 2020 at 07:46:18AM +0100, Lee Jones wrote: > Kerneldoc valication gets confused if syntax isn't "@.*: ". > > Adding the missing colons squashes the following W=1 warnings: > > drivers/mfd/atmel-smc.c:247: warning: Function parameter or member 'conf' not > described in 'atmel_smc_

Re: [PATCH v2 1/2] virtio: VIRTIO_F_IOMMU_PLATFORM -> VIRTIO_F_ACCESS_PLATFORM

2020-06-24 Thread David Hildenbrand
On 25.06.20 01:21, Michael S. Tsirkin wrote: > Rename the bit to match latest virtio spec. > Add a compat macro to avoid breaking existing userspace. > > Signed-off-by: Michael S. Tsirkin > --- > arch/um/drivers/virtio_uml.c | 2 +- > drivers/vdpa/ifcvf/ifcvf_base.h| 2 +- > drivers/

Re: stable-rc/linux-5.6.y bisection: baseline.dmesg.crit on bcm2837-rpi-3-b

2020-06-24 Thread Guillaume Tucker
On 25/06/2020 06:24, kernelci.org bot wrote: > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > * This automated bisection report was sent to you on the basis * > * that you may be involved with the breaking commit it has * > * found. No manual investigation has been done

Re: cocci script from 2016 - assignment in if ?

2020-06-24 Thread Julia Lawall
On Wed, 24 Jun 2020, j...@perches.com wrote: > https://lore.kernel.org/patchwork/patch/649705/ > > Any particular reason this wasn't applied? > > I ask because I added something similar recently to checkpatch. It probably slipped through the cracks at the time the Coccinelle scripts maintainer

Re: [RFC 0/4] futex2: Add new futex interface

2020-06-24 Thread Arnd Bergmann
On Fri, Jun 12, 2020 at 8:51 PM André Almeida wrote: > - The proposed interface uses ktime_t type for absolute timeout, and I > assumed that it should use values in a nsec resolution. If this is true, > we have some problems with i386 ABI, please check out the > COMPAT_32BIT_TIME implementa

[PATCH 10/10] mfd: altera-sysmgr: Supply descriptions for 'np' and 'property' function args

2020-06-24 Thread Lee Jones
Kerneldoc syntax is used, but not complete. Arg descriptions are required. Fixes the following W=1 build warnings: drivers/mfd/altera-sysmgr.c:95: warning: Function parameter or member 'np' not described in 'altr_sysmgr_regmap_lookup_by_phandle' drivers/mfd/altera-sysmgr.c:95: warning: Functi

[PATCH 02/10] mfd: mfd-core: Complete kerneldoc header for devm_mfd_add_devices()

2020-06-24 Thread Lee Jones
Each function parameter should be documented in kerneldoc format. Squashes the following W=1 warnings: drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'dev' not described in 'devm_mfd_add_devices' drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'id' not des

[PATCH 00/10] Fix a bunch more W=1 warnings in MFD

2020-06-24 Thread Lee Jones
Attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (10): mfd: wm8350-core: Supply description wm8350_reg_{un}lock args mfd: mfd-core: Complete kerneldoc header for devm_mfd_add_devices() mfd: db8500-prcmu: Add descripti

[PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

2020-06-24 Thread Lee Jones
Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/mfd/wm8350-core.c:136: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_lock' drivers/mfd/wm8350-core.c:165: warning: Function parameter or member 'wm8350' not descri

[PATCH 07/10] mfd: omap-usb-tll: Provide description for 'pdev' argument to .probe()

2020-06-24 Thread Lee Jones
Kerneldoc syntax is used, but not complete. Arg descriptions required. Prevents warnings like: drivers/mfd/omap-usb-tll.c:204: warning: Function parameter or member 'pdev' not described in 'usbtll_omap_probe Cc: Cc: Tony Lindgren Cc: Keshava Munegowda Cc: Roger Quadros Cc: linux-o...@vger

[PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments

2020-06-24 Thread Lee Jones
Kerneldoc valication gets confused if syntax isn't "@.*: ". Adding the missing colons squashes the following W=1 warnings: drivers/mfd/atmel-smc.c:247: warning: Function parameter or member 'conf' not described in 'atmel_smc_cs_conf_apply' drivers/mfd/atmel-smc.c:268: warning: Function parameter

[PATCH] cpufreq: schedutil: force frequency update when limits change

2020-06-24 Thread Wei Wang
To avoid reducing the frequency of a CPU prematurely, we skip reducing the frequency if the CPU had been busy recently. This should not be done when the limits of the policy are changed, for example due to thermal throttling. We should always get the frequency within the new limits as soon as poss

[PATCH 06/10] mfd: omap-usb-host: Provide description for 'pdev' argument to .probe()

2020-06-24 Thread Lee Jones
Kerneldoc syntax is used, but not complete. Arg descriptions required. Prevents warnings like: drivers/mfd/omap-usb-host.c:531: warning: Function parameter or member 'pdev' not described in 'usbhs_omap_probe' Cc: Cc: Tony Lindgren Cc: Keshava Munegowda Cc: Roger Quadros Cc: linux-o...@vge

[PATCH 03/10] mfd: db8500-prcmu: Add description for 'reset_reason' in kerneldoc

2020-06-24 Thread Lee Jones
Each function parameter should be documented in kerneldoc format. Squashes the following W=1 warnings: drivers/mfd/db8500-prcmu.c:2281: warning: Function parameter or member 'reset_code' not described in 'db8500_prcmu_system_reset' drivers/mfd/db8500-prcmu.c:3012: warning: Function parameter o

[PATCH 04/10] mfd: db8500-prcmu: Remove incorrect function header from .probe() function

2020-06-24 Thread Lee Jones
Not only is the current header incorrect, the isn't actually a need to document the ubiquitous platform probe call. Cc: Cc: Linus Walleij Signed-off-by: Lee Jones --- drivers/mfd/db8500-prcmu.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db85

[PATCH 08/10] mfd: atmel-smc: Silence comparison of unsigned expression < 0 is always false warning (W=1)

2020-06-24 Thread Lee Jones
GENMASK and it's callees conduct checking to ensure the passed parameters are valid. One of those checks is for '< 0'. So if an unsigned value is passed, in an invalid comparison takes place. Judging from the current code, it looks as though 'unsigned int' is the correct type to use, so simply c

[PATCH 05/10] mfd: omap-usb-host: Remove invalid use of kerneldoc syntax

2020-06-24 Thread Lee Jones
Kerneldoc is for documenting function arguments and return values. Prevents warnings like: drivers/mfd/omap-usb-host.c:128: warning: cannot understand function prototype: 'const char * const port_modes[] = ' Cc: Cc: Tony Lindgren Cc: Keshava Munegowda Cc: Roger Quadros Cc: linux-o...@vger.

Re: [PATCH v5 1/2] thermal: add support for the MCU controlled FAN on Khadas boards

2020-06-24 Thread Lee Jones
On Wed, 24 Jun 2020, Neil Armstrong wrote: > The new Khadas VIM2 and VIM3 boards controls the cooling fan via the > on-board microcontroller. > > This implements the FAN control as thermal devices and as cell of the Khadas > MCU MFD driver. > > Signed-off-by: Neil Armstrong > Reviewed-by: Amit

Re: [PATCH v8 2/3] phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gigabit Transceiver

2020-06-24 Thread Michal Simek
Hi Laurent and Vinod, On 24. 06. 20 23:14, Laurent Pinchart wrote: > Hi Vinod, > > On Wed, Jun 24, 2020 at 10:56:35PM +0530, Vinod Koul wrote: >> On 24-06-20, 19:39, Laurent Pinchart wrote: >> > +/* Number of GT lanes */ > +#define NUM_LANES4 Should this

[PATCH v2] vfio/spapr_tce: convert get_user_pages() --> pin_user_pages()

2020-06-24 Thread John Hubbard
This code was using get_user_pages*(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. There is some helpful background in [2]: basically, this is a

linux-next: Tree for Jun 25

2020-06-24 Thread Stephen Rothwell
Hi all, Changes since 20200624: My fixes tree contains: 466d58f824f1 ("device_cgroup: Fix RCU list debugging warning") 9bd7b7c45d71 ("sched: Fix RANDSTRUCT build fail") 2f437faecf71 ("powerpc/boot/dts: Fix dtc "pciex" warnings") The hid tree los

Re: [PATCH] clk: meson: meson8b: Drop CLK_IS_CRITICAL from fclk_div2

2020-06-24 Thread Jerome Brunet
On Sat 20 Jun 2020 at 18:14, Martin Blumenstingl wrote: > Drop CLK_IS_CRITICAL from fclk_div2. This was added because we didn't > know the relation between this clock and RGMII Ethernet. It turns out > that fclk_div2 is used as "timing adjustment clock" to generate the RX > delay on the MAC si

Re: [PATCH v3 3/4] docs: Add documentation for user space client interface

2020-06-24 Thread Manivannan Sadhasivam
On Thu, Jun 25, 2020 at 11:53:27AM +0530, Manivannan Sadhasivam wrote: > On Wed, Jun 24, 2020 at 06:52:20PM -0700, Hemant Kumar wrote: > > Hi Mani, > > > > On 6/18/20 11:39 PM, Manivannan Sadhasivam wrote: > > > On Thu, Jun 11, 2020 at 11:13:43AM -0700, Hemant Kumar wrote: > > > > MHI user space c

[PATCH] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

2020-06-24 Thread Amit Pundir
Add initial dts support for Xiaomi Poco F1 (Beryllium). This initial support is based on upstream Dragonboard 845c (sdm845) device. With this dts patch Beryllium boots AOSP up to ADB shell over USB-C. Supported functionality includes UFS, USB-C (peripheral), microSD card and Vol+/Vol-/power keys.

Re: [PATCH v3 3/4] docs: Add documentation for user space client interface

2020-06-24 Thread Manivannan Sadhasivam
On Wed, Jun 24, 2020 at 06:52:20PM -0700, Hemant Kumar wrote: > Hi Mani, > > On 6/18/20 11:39 PM, Manivannan Sadhasivam wrote: > > On Thu, Jun 11, 2020 at 11:13:43AM -0700, Hemant Kumar wrote: > > > MHI user space client driver is creating device file node > > > for user application to perform fil

Re: [PATCH drivers/misc 0/4] lkdtm: Various clean ups

2020-06-24 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Kees Cook" > An: "Randy Dunlap" > CC: "Richard Weinberger" , "richard" > , "Greg Kroah-Hartman" > , "Prasad Sodagudi" , > "Sami Tolvanen" , > "Amit Daniel Kachhap" , "linux-kselftest" > , "clang-built-linux" > , "linux-kernel" > > Gesendet: Donnerstag,

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-24 Thread Jerry Snitselaar
On Thu Jun 25 20, Jarkko Sakkinen wrote: Acer C720 running Linux v5.3 reports this in klog: tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16) tpm tpm0: tpm_try_transmit: send(): error -5 tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts tpm_tis tpm_tis: Could not get TPM timeout

Re: [PATCH v2 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-24 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月19日 週五 下午6:01寫道: > > MT6873 bus frabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violations are logged and sent to the processor for > further analysis or countermeasures. >

[PATCH] platform/x86: intel_pmc_core: update TGL's LPM0 reg bit map name

2020-06-24 Thread Sathyanarayana Nujella
PMC debug tools use lpm0's 23rd bit to reflect Main PLL, not just Audio PLL. So, update tgl_lpm0 debug reg bit map name. Signed-off-by: Sathyanarayana Nujella Signed-off-by: Arava Jairaj Acked-by: David E. Box --- drivers/platform/x86/intel_pmc_core.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 1/2] KVM: X86: Move ignore_msrs handling upper the stack

2020-06-24 Thread Sean Christopherson
On Mon, Jun 22, 2020 at 06:04:41PM -0400, Peter Xu wrote: > MSR accesses can be one of: > > (1) KVM internal access, > (2) userspace access (e.g., via KVM_SET_MSRS ioctl), > (3) guest access. > > The ignore_msrs was previously handled by kvm_get_msr_common() and > kvm_set_msr_common(), whic

Re: [PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests

2020-06-24 Thread Kees Cook
On Mon, Jun 22, 2020 at 02:21:38PM +0530, Naresh Kamboju wrote: > On Fri, 8 May 2020 at 12:23, Michael Ellerman wrote: > > # Record and dump the results > > -dmesg -c >"$LOG" > > +dmesg | diff --changed-group-format='%>' --unchanged-group-format='' > > "$DMESG" - > "$LOG" || true > > We are fac

Re: [RFC] MFD's relationship with Device Tree (OF)

2020-06-24 Thread Lee Jones
On Wed, 24 Jun 2020, Frank Rowand wrote: > On 2020-06-22 16:03, Michael Walle wrote: > > Am 2020-06-14 12:26, schrieb Michael Walle: > >> Hi Rob, > >> > >> Am 2020-06-10 00:03, schrieb Rob Herring: > >> [..] > >>> Yes, we should use 'reg' whenever possible. If we don't have 'reg', > >>> then you sh

[PATCH] Revert "sched/deadline: Remove cpu_active_mask from cpudl_find()"

2020-06-24 Thread Sai Harshini Nimmala
The original commit 9659e1ee removes checking the cpu_active_mask while finding the best cpu to place a deadline task, citing the reason that this mask rarely changes and removing the check will give performance gains. However, on hotplugging, the cpu dying path has a brief duration between the CPU

Re: [PATCH drivers/misc 0/4] lkdtm: Various clean ups

2020-06-24 Thread Kees Cook
On Wed, Jun 24, 2020 at 06:45:47PM -0700, Randy Dunlap wrote: > Looks like lkdtm/bugs.c needs to get/use arch/x86/include/asm/processor.h > but it actually uses arch/x86/um/asm/processor*.h, which does not have the > needed structs etc. Should I just test for !UML in bugs.c? (This is all for the l

Re: [PATCH v2] Fix undefined operation VMXOFF during reboot and crash

2020-06-24 Thread Sean Christopherson
On Thu, Jun 11, 2020 at 03:48:18PM -0400, David P. Reed wrote: > -/** Disable VMX on the current CPU > +/* Disable VMX on the current CPU > * > - * vmxoff causes a undefined-opcode exception if vmxon was not run > - * on the CPU previously. Only call this function if you know VMX > - * is enabled

Re: [PATCH v2 2/2] Add PWM fan controller driver for LGM SoC

2020-06-24 Thread Uwe Kleine-König
On Thu, Jun 25, 2020 at 12:23:54PM +0800, Tanwar, Rahul wrote: > > Hi Philipp, > > On 18/6/2020 8:25 pm, Philipp Zabel wrote: > > Hi Rahul, > > > > On Thu, 2020-06-18 at 20:05 +0800, Rahul Tanwar wrote: > >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. > >> This PWM controller

Re: [PATCH] mm/spase: never partially remove memmap for early section

2020-06-24 Thread David Hildenbrand
> Am 25.06.2020 um 01:47 schrieb Dan Williams : > > On Wed, Jun 24, 2020 at 3:44 PM Wei Yang > wrote: > [..] >>> So, you are right that there is a mismatch here, but I think the >>> comprehensive fix is to allow early sections to be partially >>> depopulated/repopulated rather than have secti

Re: [PATCH -v2.1] x86/msr: Filter MSR writes

2020-06-24 Thread Sean Christopherson
On Mon, Jun 15, 2020 at 08:38:37AM +0200, Borislav Petkov wrote: > Here's an improved v2 with sparse warnings fixed: > > --- > Disable writing to MSRs from userspace by default. Writes can still be > allowed by supplying the allow_writes=1 module parameter and the kernel > will be tainted so that

Re: [RFC] Reed-Solomon Code: Update no_eras to the actual number of errors

2020-06-24 Thread Joe Perches
On Wed, 2020-06-24 at 22:35 -0700, Kees Cook wrote: > On Wed, Jun 24, 2020 at 09:10:53PM -0700, Aiden Leong wrote: > > Corr and eras_pos are updated to actual correction pattern and erasure > > positions, but no_eras is not. [] > > @@ -312,14 +313,21 @@ > > eras_pos[j++]

Re: [PATCH 2/2] xen/privcmd: Convert get_user_pages*() to pin_user_pages*()

2020-06-24 Thread John Hubbard
On 2020-06-24 20:02, Souptick Joarder wrote: In 2019, we introduced pin_user_pages*() and now we are converting get_user_pages*() to the new API as appropriate. [1] & [2] could be referred for more information. This is case 5 as per document [1]. [1] Documentation/core-api/pin_user_pages.rst [2

Re: [PATCH 3/8] arm64: dts: qcom: sdm630: Add tsens node

2020-06-24 Thread Amit Kucheria
On Wed, Jun 24, 2020 at 8:32 PM Konrad Dybcio wrote: > > Interesting, the downstream DTS only mentions the 0x010AD one.. > Are you sure you're not looking at 636/660? > I looked a bit closer. So there are two instances of the controller but the platform doesn't have as many sensors. So using just

RE: [PATCH -next] scsi: ufs: allow exynos ufs driver to build as module

2020-06-24 Thread Avri Altman
> > Allow Exynos UFS driver to build as a module. > This patch fix the below build issue reported by > kernel build robot. > > drivers/scsi/ufs/ufs-exynos.o: in function `exynos_ufs_probe': > drivers/scsi/ufs/ufs-exynos.c:1231: undefined reference to > `ufshcd_pltfrm_init' > drivers/scsi/ufs/u

Re: [RFC] Reed-Solomon Code: Update no_eras to the actual number of errors

2020-06-24 Thread Kees Cook
On Wed, Jun 24, 2020 at 09:10:53PM -0700, Aiden Leong wrote: > Corr and eras_pos are updated to actual correction pattern and erasure > positions, but no_eras is not. > > When this library is used to recover lost bytes, we normally memset the > lost trunk of bytes to zero as a placeholder. Unfortu

[PATCH] ring-buffer: speed up buffer resets by avoiding synchronize_rcu for each CPU

2020-06-24 Thread Nicholas Piggin
On a 144 thread system, `perf ftrace` takes about 20 seconds to start up, due to calling synchronize_rcu() for each CPU. cat /proc/108560/stack 0xc0003e7eb336f470 __switch_to+0x2e0/0x480 __wait_rcu_gp+0x20c/0x220 synchronize_rcu+0x9c/0xc0 ring_buffer_reset_cpu+0x88/0x2e0

[PATCH 5.7.y] erofs: fix partially uninitialized misuse in z_erofs_onlinepage_fixup

2020-06-24 Thread Gao Xiang
From: Gao Xiang commit 3c597282887fd55181578996dca52ce697d985a5 upstream. Hongyu reported "id != index" in z_erofs_onlinepage_fixup() with specific aarch64 environment easily, which wasn't shown before. After digging into that, I found that high 32 bits of page->private was set to 0x ra

Re: [PATCH v4 4/7] ACPI: button: Use input_device_enabled() helper

2020-06-24 Thread Dmitry Torokhov
On Mon, Jun 08, 2020 at 01:22:08PM +0200, Andrzej Pietrasiewicz wrote: > A new helper is available, so use it. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/acpi/button.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/button.c b/drivers/acpi

Re: [Nouveau] [RESEND PATCH 1/3] nouveau: fix migrate page regression

2020-06-24 Thread Ben Skeggs
On Thu, 25 Jun 2020 at 15:23, Ben Skeggs wrote: > > On Tue, 23 Jun 2020 at 10:51, John Hubbard wrote: > > > > On 2020-06-22 16:38, Ralph Campbell wrote: > > > The patch to add zero page migration to GPU memory inadvertantly included > > > > inadvertently > > > > > part of a future change which br

stable-rc/linux-5.6.y bisection: baseline.dmesg.crit on bcm2837-rpi-3-b

2020-06-24 Thread kernelci.org bot
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem

Re: [Nouveau] [RESEND PATCH 1/3] nouveau: fix migrate page regression

2020-06-24 Thread Ben Skeggs
On Tue, 23 Jun 2020 at 10:51, John Hubbard wrote: > > On 2020-06-22 16:38, Ralph Campbell wrote: > > The patch to add zero page migration to GPU memory inadvertantly included > > inadvertently > > > part of a future change which broke normal page migration to GPU memory > > by copying too much dat

Re: [PATCH v4 3/7] ACPI: button: Access input device's users under appropriate mutex

2020-06-24 Thread Dmitry Torokhov
On Wed, Jun 24, 2020 at 05:00:09PM +0200, Rafael J. Wysocki wrote: > On Mon, Jun 8, 2020 at 1:22 PM Andrzej Pietrasiewicz > wrote: > > > > Inspecting input device's 'users' member should be done under device's > > mutex, so add appropriate invocations. > > > > Signed-off-by: Andrzej Pietrasiewicz

[PATCH 5.4.y] erofs: fix partially uninitialized misuse in z_erofs_onlinepage_fixup

2020-06-24 Thread Gao Xiang
From: Gao Xiang commit 3c597282887fd55181578996dca52ce697d985a5 upstream. Hongyu reported "id != index" in z_erofs_onlinepage_fixup() with specific aarch64 environment easily, which wasn't shown before. After digging into that, I found that high 32 bits of page->private was set to 0x ra

[PATCH 4.19.y] erofs: fix partially uninitialized misuse in z_erofs_onlinepage_fixup

2020-06-24 Thread Gao Xiang
From: Gao Xiang commit 3c597282887fd55181578996dca52ce697d985a5 upstream. Hongyu reported "id != index" in z_erofs_onlinepage_fixup() with specific aarch64 environment easily, which wasn't shown before. After digging into that, I found that high 32 bits of page->private was set to 0x ra

Re: [PATCH 2/2][v3] PM / s2idle: Code cleanup to make s2idle consistent with normal idle path

2020-06-24 Thread Chen Yu
Hi Rafael, On Tue, Jun 23, 2020 at 07:57:59PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Subject: [PATCH] cpuidle: Rearrange s2idle-specific idle state entry code > > Implement call_cpuidle_s2idle() in analogy with call_cpuidle() > for the s2idle-specific idle state entry and inv

Re: [PATCH v6 1/6] tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state

2020-06-24 Thread Bjorn Andersson
On Mon 15 Jun 05:02 PDT 2020, Rajendra Nayak wrote: > geni serial needs to express a perforamnce state requirement on CX > powerdomain depending on the frequency of the clock rates. > Use OPP table from DT to register with OPP framework and use > dev_pm_opp_set_rate() to set the clk/perf state. >

Re: [PATCH v3 08/15] arm64: kvm: Split hyp/switch.c to VHE/nVHE

2020-06-24 Thread kernel test robot
Hi David, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.8-rc2 next-20200624] [cannot apply to kvmarm/next arm64/for-next/core arm-perf/for-next/perf] [If your patch is applied to the wrong git tree, kindly drop us

Re: [v2,net-next 2/4] net: enetc: add support max frame size for tc flower offload

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:29 +0800 > From: Po Liu > > Base on the tc flower offload police action add max frame size by the > parameter 'mtu'. Tc flower device driver working by the IEEE 802.1Qci > stream filter can implement the max frame size filtering. Add it to the > current

Re: [v2,net-next 1/4] net: qos: add tc police offloading action with max frame size limit

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:28 +0800 > From: Po Liu > > Current police offloading support the 'burst'' and 'rate_bytes_ps'. Some > hardware own the capability to limit the frame size. If the frame size > larger than the setting, the frame would be dropped. For the police > action

Re: [v2,net-next 4/4] net: enetc add tc flower offload flow metering policing action

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:31 +0800 > From: Po Liu > > Flow metering entries in IEEE 802.1Qci is an optional function for a > flow filtering module. Flow metering is two rates two buckets and three > color marker to policing the frames. This patch only enable one rate one > bucke

Re: [v2,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:30 +0800 > From: Po Liu > > Hardware device may include more than one police entry. Specifying the > action's index make it possible for several tc filters to share the same > police action when installing the filters. > > Propagate this index to devic

Re: [PATCH V8 0/8] Add interconnect support to QSPI and QUP drivers

2020-06-24 Thread Bjorn Andersson
On Tue 23 Jun 03:38 PDT 2020, Akash Asthana wrote: > This patch series is based on tag "next-20200622" of linux-next tree. > Series applied to the qcom tree, thank you and thanks for the Acks. Regards, Bjorn > High level design: > - QUP wrapper/common driver. >Vote for QUP core on behalf

ath9k broken [was: Linux 5.7.3]

2020-06-24 Thread Jiri Slaby
On 25. 06. 20, 0:05, Gabriel C wrote: > Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman > : >> >> I'm announcing the release of the 5.7.3 kernel. >> > > Hello Greg, > >> Qiujun Huang (5): >> ath9k: Fix use-after-free Read in htc_connect_service >> ath9k: Fix use-after-fr

[Question]many kernel error "neighbour: ndisc_cache: neighbor table overflow!"

2020-06-24 Thread Jack Wang
Hi Folks, In one of our big cluster, due to capacity increase, more servers are added to the cluster, and we saw from many pserver reporting error message below: "neighbour: ndisc_cache: neighbor table overflow!" We've tested increasing the gc_thresh values in sysctl.conf, after reboot, the erro

Re: [PATCH net 0/3] net: bcmgenet: use hardware padding of runt frames

2020-06-24 Thread David Miller
From: Doug Berger Date: Wed, 24 Jun 2020 18:14:52 -0700 > Now that scatter-gather and tx-checksumming are enabled by default > it revealed a packet corruption issue that can occur for very short > fragmented packets. > > When padding these frames to the minimum length it is possible for > the no

Re: [PATCH] venus: move buffer calculation to driver

2020-06-24 Thread dikshita
Hi Stanimir, A gentle reminder for the review. Thanks, Dikshita On 2020-06-09 17:24, Dikshita Agarwal wrote: Right now we get buffer requirements from fw. The call to get these requirements is a blocking call and takes a lot of time. This change calculates all the buffer requirement within dri

Re: [PATCH] venus: move platform specific data to platform file

2020-06-24 Thread dikshita
Hi Stanimir, A gentle reminder for the review. On 2020-05-29 12:37, Dikshita Agarwal wrote: Move all data specific to platform into a separate file. Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/venus/Makefile | 3 +- drivers/media/platform/qcom/venus/core.c

Re: [PATCH] venus: Add platform specific capabilities

2020-06-24 Thread dikshita
Hi Stanimir, A gentle reminder for the review. Thanks, Dikshita On 2020-05-29 12:48, Dikshita Agarwal wrote: Add platform specific capabilities and use them in place of firmware capabilities. Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/venus/core.c | 3 + driv

[PATCH v2] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-24 Thread Jarkko Sakkinen
Re-allocate context and session buffers when needed. Scale them in page increments so that the reallocation is only seldomly required, and thus causes minimal stress to the system. Add a static maximum limit of four pages for buffer sizes. Cc: James Bottomley Suggested-by: Stefan Berger Signed-o

Re: [PATCH] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-24 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 07:24:20AM +0300, Jarkko Sakkinen wrote: > Re-allocate context and session buffers when needed. Scale them in page > increments so that the reallocation is only seldomly required, and thus > causes minimal stress to the system. Add a static maximum limit of four > pages for

[PATCH] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-24 Thread Jarkko Sakkinen
Re-allocate context and session buffers when needed. Scale them in page increments so that the reallocation is only seldomly required, and thus causes minimal stress to the system. Add a static maximum limit of four pages for buffer sizes. Cc: James Bottomley Suggested-by: Stefan Berger Signed-o

Re: [PATCH v2 2/2] Add PWM fan controller driver for LGM SoC

2020-06-24 Thread Tanwar, Rahul
Hi Philipp, On 18/6/2020 8:25 pm, Philipp Zabel wrote: > Hi Rahul, > > On Thu, 2020-06-18 at 20:05 +0800, Rahul Tanwar wrote: >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. >> This PWM controller does not have any other consumer, it is a >> dedicated PWM controller for fan a

[RFC] Reed-Solomon Code: Update no_eras to the actual number of errors

2020-06-24 Thread Aiden Leong
Corr and eras_pos are updated to actual correction pattern and erasure positions, but no_eras is not. When this library is used to recover lost bytes, we normally memset the lost trunk of bytes to zero as a placeholder. Unfortunately, if the lost byte is zero, b[i] is zero too. Without correct no_

[tip:auto-latest] BUILD SUCCESS 9f2a2b6c23758d798f548911f6119def723d1029

2020-06-24 Thread kernel test robot
ig powerpc defconfig powerpc allyesconfig powerpc rhel-kconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a002-20200624 i386 randc

Re: KASAN: null-ptr-deref Write in blk_mq_map_swqueue

2020-06-24 Thread Bart Van Assche
On 2020-06-24 20:01, syzbot wrote: > This bug is marked as fixed by commit: > blk-mq: Fix a recently introduced regression in > But I can't find it in any tested tree for more than 90 days. > Is it a correct commit? Please update it by replying: > #syz fix: exact-commit-title > Until then the bug i

Re: [PATCH] kernel/trace: Add TRACING_ALLOW_PRINTK config option

2020-06-24 Thread Alexei Starovoitov
On Thu, Jun 25, 2020 at 10:00:09AM +0800, Nicolas Boichat wrote: > On Thu, Jun 25, 2020 at 1:25 AM Alexei Starovoitov > wrote: > > > > On Wed, Jun 24, 2020 at 9:07 AM Steven Rostedt wrote: > > > > > > On Wed, 24 Jun 2020 16:45:24 +0800 > > > Nicolas Boichat wrote: > > > > > > > trace_printk is o

Re: linux-next: build failure after merge of the rcu tree

2020-06-24 Thread Paul E. McKenney
On Thu, Jun 25, 2020 at 12:57:53PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the rcu tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > kernel/rcu/tree.c: In function 'rcu_dynticks_eqs_enter': > kernel/rcu/tree.c:251:8: error: implicit declaration of

Re: linux-next: manual merge of the rcu tree with the tip tree

2020-06-24 Thread Paul E. McKenney
On Thu, Jun 25, 2020 at 12:44:52PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the rcu tree got a conflict in: > > include/linux/smp.h > > between commit: > > 380dc20ce843 ("smp, irq_work: Continue smp_call_function*() and irq_work*() > integration") > > from

linux-next: build warning after merge of the scsi tree

2020-06-24 Thread Stephen Rothwell
Hi all, After merging the scsi tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: modpost: missing MODULE_LICENSE() in drivers/scsi/ufs/ufs-exynos.o Introduced by commit 55f4b1f73631 ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos SoCs") (not sure w

Re: [PATCH 1/2] arm64: dts: qcom: sc7180: Switch SPI to use GPIO for CS

2020-06-24 Thread Doug Anderson
Hi, On Wed, Jun 24, 2020 at 6:25 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-06-24 17:08:04) > > The geni SPI protocol appears to have been designed without taking > > Linux needs into account. In all the normal flows it takes care of > > setting chip select itself. However, Linux

Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support

2020-06-24 Thread Stanley Chu
Hi Steev, On Wed, 2020-06-24 at 11:15 -0500, Steev Klimaszewski wrote: > On 6/23/20 8:53 PM, Stanley Chu wrote: > > Hi Steev, > > > > Please help try below simple patch to see if above WriteBooster messages > > can be eliminated. > > > > > > --- > > drivers/scsi/ufs/ufshcd.c | 2 ++ > > 1 file ch

[PATCH v1] driver core: Fix suspend/resume order issue with deferred probe

2020-06-24 Thread Saravana Kannan
Under the following conditions: - driver A is built in and can probe device-A - driver B is a module and can probe device-B - device-A is supplier of device-B Without this patch: 1. device-A is added. 2. device-B is added. 3. dpm_list is now [device-A, device-B]. 4. driver-A defers probe of device

Re: [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-24 Thread Florian Fainelli
On 6/24/2020 4:34 PM, David Miller wrote: > From: Florian Fainelli > Date: Wed, 24 Jun 2020 15:10:51 -0700 > >> Did you mean that you applied v4? It does not look like you pushed your >> local changes to net-next yet, so I cannot tell for sure. > > I ended up applying v4, yes. > OK, just ma

[PATCH v2] scsi: ufs: Disable WriteBooster capability in non-supported UFS device

2020-06-24 Thread Stanley Chu
If UFS device is not qualified to enter the detection of WriteBooster probing by disallowed UFS version or device quirks, then WriteBooster capability in host shall be disabled to prevent any WriteBooster operations in the future. Fixes: 3d17b9b5ab11 ("scsi: ufs: Add write booster feature support"

Re: KASAN: null-ptr-deref Write in blk_mq_map_swqueue

2020-06-24 Thread syzbot
This bug is marked as fixed by commit: blk-mq: Fix a recently introduced regression in But I can't find it in any tested tree for more than 90 days. Is it a correct commit? Please update it by replying: #syz fix: exact-commit-title Until then the bug is still considered open and new crashes with th

linux-next: build failure after merge of the rcu tree

2020-06-24 Thread Stephen Rothwell
Hi all, After merging the rcu tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: kernel/rcu/tree.c: In function 'rcu_dynticks_eqs_enter': kernel/rcu/tree.c:251:8: error: implicit declaration of function 'arch_atomic_add_return'; did you mean 'atomic_add_return'? [-Werror

[PATCH 1/2] xen/privcmd: Corrected error handling path and mark pages dirty

2020-06-24 Thread Souptick Joarder
Previously, if lock_pages() end up partially mapping pages, it used to return -ERRNO due to which unlock_pages() have to go through each pages[i] till *nr_pages* to validate them. This can be avoided by passing correct number of partially mapped pages & -ERRNO separately, while returning from lock_

[PATCH 2/2] xen/privcmd: Convert get_user_pages*() to pin_user_pages*()

2020-06-24 Thread Souptick Joarder
In 2019, we introduced pin_user_pages*() and now we are converting get_user_pages*() to the new API as appropriate. [1] & [2] could be referred for more information. This is case 5 as per document [1]. [1] Documentation/core-api/pin_user_pages.rst [2] "Explicit pinning of user-space pages":

Re: [PATCH v5 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-24 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 05:52:56AM +0300, Jarkko Sakkinen wrote: > On Thu, Jun 25, 2020 at 05:34:38AM +0300, Jarkko Sakkinen wrote: > > On Wed, Jun 24, 2020 at 08:38:25PM -0400, Stefan Berger wrote: > > > On 6/24/20 8:00 PM, Jarkko Sakkinen wrote: > > > > On Tue, Jun 23, 2020 at 08:06:35AM -0400, S

Re: [PATCH v5 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-24 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 05:34:38AM +0300, Jarkko Sakkinen wrote: > On Wed, Jun 24, 2020 at 08:38:25PM -0400, Stefan Berger wrote: > > On 6/24/20 8:00 PM, Jarkko Sakkinen wrote: > > > On Tue, Jun 23, 2020 at 08:06:35AM -0400, Stefan Berger wrote: > > > > From: Stefan Berger > > > > > > > > Recent

[PATCH] [net/ipv6] Remove redundant null check in rt_mt6

2020-06-24 Thread Gaurav Singh
rh cannot be NULL here since its already checked above assignment and is being dereferenced before. Remove the redundant null check. Signed-off-by: Gaurav Singh --- net/ipv6/netfilter/ip6t_rt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6t_rt.c b/n

Re: [PATCH 05/10] mfd: sprd-sc27xx-spi: Fix symbol 'sprd_pmic_detect_charger_type' was not declared warning

2020-06-24 Thread Baolin Wang
Hi Lee, On Wed, Jun 24, 2020 at 11:07 PM Lee Jones wrote: > > Sparse reports: > > drivers/mfd/sprd-sc27xx-spi.c:59:23: warning: symbol > 'sprd_pmic_detect_charger_type' was not declared. Should it be static? > > ... due to a missing header file. > > Cc: > Cc: Orson Zhai > Cc: Baolin Wang > C

[PATCH] [net/ipv6] Remove redundant null check in hbh_mt6

2020-06-24 Thread Gaurav Singh
oh cannot be NULL since its already checked above after assignment and is being dereferenced before. Remove the redundant null check. Signed-off-by: Gaurav Singh --- net/ipv6/netfilter/ip6t_hbh.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6t_hbh.c

linux-next: manual merge of the rcu tree with the tip tree

2020-06-24 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the rcu tree got a conflict in: include/linux/smp.h between commit: 380dc20ce843 ("smp, irq_work: Continue smp_call_function*() and irq_work*() integration") from the tip tree and commit: 7effc6f7b465 ("EXP kernel/smp: Provide CSD lock timeout diagno

[PATCH] [net/ipv6] remove redundant null check in frag_mt6

2020-06-24 Thread Gaurav Singh
fh cannot be NULL since its already checked above after assignment and is being dereferenced before. Remove the redundant null check. Signed-off-by: Gaurav Singh --- net/ipv6/netfilter/ip6t_frag.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6t_frag.

[PATCH] [net/ipv6] Remove redundant null check in ah_mt6

2020-06-24 Thread Gaurav Singh
ah cannot be NULL since its already checked above after assignment and is being dereferenced before in pr(). Remove the redundant null check. Signed-off-by: Gaurav Singh --- net/ipv6/netfilter/ip6t_ah.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6t

cocci script from 2016 - assignment in if ?

2020-06-24 Thread joe
https://lore.kernel.org/patchwork/patch/649705/ Any particular reason this wasn't applied? I ask because I added something similar recently to checkpatch.

Re: [PATCH v5 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-24 Thread Jarkko Sakkinen
On Wed, Jun 24, 2020 at 08:38:25PM -0400, Stefan Berger wrote: > On 6/24/20 8:00 PM, Jarkko Sakkinen wrote: > > On Tue, Jun 23, 2020 at 08:06:35AM -0400, Stefan Berger wrote: > > > From: Stefan Berger > > > > > > Recent extensions of the TPM2 ACPI table added 3 more fields > > > including 12 byte

Re: [PATCH 1/5] Huawei BMA: Adding Huawei BMA driver: host_edma_drv

2020-06-24 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on sparc-next/master] [also build test ERROR on linux/master linus/master ipvs/master v5.8-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as do

[PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-24 Thread Jarkko Sakkinen
Acer C720 running Linux v5.3 reports this in klog: tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16) tpm tpm0: tpm_try_transmit: send(): error -5 tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts tpm_tis tpm_tis: Could not get TPM timeouts and durations tpm_tis 00:08: 1.2 TPM (dev

Re: [PATCH] tpm_tis: Remove the HID IFX0102

2020-06-24 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 02:00:33AM +0300, Jarkko Sakkinen wrote: > Acer C720 running Linux v5.3 reports this in klog: > > tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16) > tpm tpm0: tpm_try_transmit: send(): error -5 > tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts > tpm_tis

  1   2   3   4   5   6   7   8   9   10   >