[PATCH] drm/vc4: fix ref count leak in vc4_v3d_pm_get

2020-06-13 Thread Navid Emamdoost
in vc4_v3d_pm_get, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/vc4/vc4_v3d.c | 1 + 1 file changed, 1 insertion(+)

[PATCH] drm/vc4: fix ref count leak in vc4_dsi_encoder_enable

2020-06-13 Thread Navid Emamdoost
in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/vc4/vc4_dsi.c | 10 ++ 1 file change

[PATCH] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

2020-06-13 Thread Navid Emamdoost
in etnaviv_gpu_submit, etnaviv_gpu_recover_hang, etnaviv_gpu_debugfs, and etnaviv_gpu_init the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost -

Re: [PATCH v3] IB/sa: Resolving use-after-free in ib_nl_send_msg

2020-06-13 Thread Leon Romanovsky
On Tue, Jun 09, 2020 at 07:45:21AM -0700, Divya Indi wrote: > Hi Leon, > > Thanks for taking the time to review. > > Please find my comments inline - > > On 6/9/20 12:00 AM, Leon Romanovsky wrote: > > On Mon, Jun 08, 2020 at 07:46:16AM -0700, Divya Indi wrote: > >> Commit 3ebd2fd0d011 ("IB/sa: Put

[PATCH] mm/slab: Add a __GFP_ACCOUNT GFP flag check for slab allocation

2020-06-13 Thread Muchun Song
When a kmem_cache is initialized with SLAB_ACCOUNT slab flag, we must not call kmem_cache_alloc with __GFP_ACCOUNT GFP flag. In this case, we can be accounted to kmemcg twice. This is not correct. So we add a __GFP_ACCOUNT GFP flag check for slab allocation. We also introduce a new helper named fi

Re: [PATCH v4 2/3] venus: Make debug infrastructure more flexible

2020-06-13 Thread Greg KH
On Sun, Jun 14, 2020 at 01:39:18AM +0300, Stanimir Varbanov wrote: > if (slot == -1) { > - dev_dbg(inst->core->dev, "%s: no free slot\n", __func__); > + VDBGH("no free slot for timestamp\n"); Again, no, you just lost a lot of valuable information by changing to a diff

[PATCH] drm/panfrost: perfcnt: fix ref count leak in panfrost_perfcnt_enable_locked

2020-06-13 Thread Navid Emamdoost
in panfrost_perfcnt_enable_locked, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 10

Re: [PATCH v4 1/3] venus: Add debugfs interface to set firmware log level

2020-06-13 Thread Greg KH
On Sun, Jun 14, 2020 at 01:39:17AM +0300, Stanimir Varbanov wrote: > This will be useful when debugging specific issues related to > firmware HFI interface. > > Signed-off-by: Stanimir Varbanov You didn't cc: any of us on the patchs, like you did on 0/3 :( > --- > drivers/media/platform/qcom/

[PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-06-13 Thread Navid Emamdoost
in panfrost_job_hw_submit, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/panfrost/panfrost_job.c | 8 +--- 1

Re: [PATCH] staging: android: ashmem.c: Cleanup

2020-06-13 Thread Greg KH
On Sun, Jun 14, 2020 at 11:40:42AM +0700, Dio Putra wrote: > Okay, my fault here. Changing the function a little bit didn't help > unfortunately. > > $ cd ~/git/linux/ > $ make CC=clang W=1 M=drivers/staging/android > CC drivers/staging/android/ashmem.o > drivers/staging/android/ashmem.c:4

[PATCH] drm/exynos: fix ref count leak in mic_pre_enable

2020-06-13 Thread Navid Emamdoost
in mic_pre_enable, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/exynos/exynos_drm_mic.c | 2 +- 1 file changed,

[PATCH] Input: stmfts: fix ref count leak in stmfts_input_open

2020-06-13 Thread Navid Emamdoost
in stmfts_input_open, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/input/touchscreen/stmfts.c | 7 +-- 1 file change

linux-next: Tree for Jun 14

2020-06-13 Thread Stephen Rothwell
Hi all, News: The merge window has opened, so please do *not* add v5.9 material to your linux-next included branches until after v5.8-rc1 has been released. Changes since 20200613: My fixes tree contains: 4cb4bfffe2c1 ("device_cgroup: Fix RCU list debugging warning") Non-mer

[PATCH] e1000e: add ifdef to avoid dead code

2020-06-13 Thread Greg Thelen
Commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems") added e1000e_check_me() but it's only called from CONFIG_PM_SLEEP protected code. Thus builds without CONFIG_PM_SLEEP see: drivers/net/ethernet/intel/e1000e/netdev.c:137:13: warning: 'e1000e_check_me' defined but n

Re: [PATCH v2 01/24] dyndbg-docs: eschew file /full/path query in docs

2020-06-13 Thread Greg KH
On Sat, Jun 13, 2020 at 09:57:15AM -0600, Jim Cromie wrote: > Regarding: > commit 2b6783191da7 ("dynamic_debug: add trim_prefix() to provide source-root > relative paths") > commit a73619a845d5 ("kbuild: use -fmacro-prefix-map to make __FILE__ a > relative path") > > 2nd commit broke dynamic-deb

Re: [PATCH v2 23/24] kset-example: add pr_debug()s for easy visibility of its operation

2020-06-13 Thread Greg KH
On Sat, Jun 13, 2020 at 09:57:37AM -0600, Jim Cromie wrote: > put pr_debug()s into most functions, to easily see code operate when > module is loaded and used. > > #> dmesg -w & > #> modprobe kset-example dyndbg=+pfml > #> cat /sys/kernel/kset-example/*/* > --- > samples/kobject/kset-exampl

[PATCH] Input: bma150: fix ref count leak in bma150_open

2020-06-13 Thread Navid Emamdoost
in bma150_open, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/input/misc/bma150.c | 7 +-- 1 file changed, 5 insertio

Re:

2020-06-13 Thread depti mohan
6/14/2020 Been sunday, does your firm function today sar

[PATCH] powerpc/powernv/pci: add ifdef to avoid dead code

2020-06-13 Thread Greg Thelen
Commit dc3d8f85bb57 ("powerpc/powernv/pci: Re-work bus PE configuration") removed a couple pnv_ioda_setup_bus_dma() calls. The only remaining calls are behind CONFIG_IOMMU_API. Thus builds without CONFIG_IOMMU_API see: arch/powerpc/platforms/powernv/pci-ioda.c:1888:13: error: 'pnv_ioda_setup_b

[PATCH] Input: omap4-keypad: fix ref count leak if pm_runtime_get_sync fails

2020-06-13 Thread Navid Emamdoost
calling pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/input/keyboard/omap4-keypad.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(

[PATCH] net: macb: fix ref count leaking via pm_runtime_get_sync

2020-06-13 Thread Navid Emamdoost
in macb_mdio_write, macb_mdio_read, and at91ether_open, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/net/ethernet/cadenc

[PATCH] net: fec: fix ref count leaking when pm_runtime_get_sync fails

2020-06-13 Thread Navid Emamdoost
in fec_enet_mdio_read, fec_enet_mdio_write, fec_enet_get_regs, fec_enet_open and fec_drv_remove, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Em

Re: [PATCH v4 3/9] reset: add BCM6345 reset controller driver

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:38 AM, Álvaro Fernández Rojas wrote: > Add support for resetting blocks through the Linux reset controller > subsystem for BCM63xx SoCs. > > Signed-off-by: Álvaro Fernández Rojas With the kbuild robot error fixed: Reviewed-by: Florian Fainelli Thanks! -- Florian

Re: [PATCH v4 9/9] mips: bmips: add BCM6318 reset controller definitions

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:38 AM, Álvaro Fernández Rojas wrote: > BCM6318 SoCs have a reset controller for certain components. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v4 8/9] mips: bmips: dts: add BCM63268 reset controller support

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:38 AM, Álvaro Fernández Rojas wrote: > BCM63268 SoCs have a reset controller for certain components. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v4 9/9] mips: bmips: dts: add BCM63268 power domain support

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:21 AM, Álvaro Fernández Rojas wrote: > BCM63268 SoCs have a power domain controller to enable/disable certain > components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v4 6/9] soc: bcm: add BCM63xx power domain driver

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:21 AM, Álvaro Fernández Rojas wrote: > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > to enable/disable certain components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v4 5/9] mips: bmips: add BCM6318 power domain definitions

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:21 AM, Álvaro Fernández Rojas wrote: > BCM6318 SoCs have a power domain controller to enable/disable certain > components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v4 4/9] mips: bmips: add BCM63268 power domain definitions

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:21 AM, Álvaro Fernández Rojas wrote: > BCM63268 SoCs have a power domain controller to enable/disable certain > components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v4 3/9] mips: bmips: add BCM6362 power domain definitions

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:21 AM, Álvaro Fernández Rojas wrote: > BCM6362 SoCs have a power domain controller to enable/disable certain > components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli -- Florian

[PATCH] ext4: fix coding style in file.c

2020-06-13 Thread Dio Putra
Fixed a few coding style issues in file.c Signed-off-by: Dio Putra --- fs/ext4/file.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 0d624250a62b..10e4a8389885 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c @@ -145,8 +145,7 @@ sta

Re: [PATCH v4 2/9] mips: bmips: add BCM6328 power domain definitions

2020-06-13 Thread Florian Fainelli
On 6/13/2020 1:21 AM, Álvaro Fernández Rojas wrote: > BCM6328 SoCs have a power domain controller to enable/disable certain > components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] staging: android: ashmem.c: Cleanup

2020-06-13 Thread Dio Putra
Okay, my fault here. Changing the function a little bit didn't help unfortunately. $ cd ~/git/linux/ $ make CC=clang W=1 M=drivers/staging/android CC drivers/staging/android/ashmem.o drivers/staging/android/ashmem.c:418:16: error: cannot assign to variable 'vmfile_fops' with const-qualifi

[PATCH v2] RDMA/rvt: Fix potential memory leak caused by rvt_alloc_rq

2020-06-13 Thread Aditya Pakki
In case of failure of alloc_ud_wq_attr(), the memory allocated by rvt_alloc_rq() is not freed. Fix it by calling rvt_free_rq() using the existing clean-up code. Fixes: d310c4bf8aea ("IB/{rdmavt, hfi1, qib}: Remove AH refcount for UD QPs") Signed-off-by: Aditya Pakki --- v1: Fix incorrect order of

coccinelle issues

2020-06-13 Thread Randy Dunlap
Hi, OK, I've not used Coccinelle and now I am trying to use it. It seems that I am having a few issues. The primary one is when I run spatch (via 'make coccicheck' in the kernel source tree), it tells me: Python error: No module named coccilib.elems I do see "elems.py" in /usr/local/lib64/coccin

[PATCH] media: st-delta: Fix reference count leak in delta_run_work

2020-06-13 Thread Aditya Pakki
delta_run_work() calls delta_get_sync() that increments the reference counter. In case of failure, decrement the reference count by calling delta_put_autosuspend(). Signed-off-by: Aditya Pakki --- drivers/media/platform/sti/delta/delta-v4l2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH] media: bdisp: fix reference count leaks due to pm_runtime_get_sync

2020-06-13 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki --- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH] mtd: rawnand: gpmi: fix reference count leak due to pm_runtime_get_sync

2020-06-13 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki --- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-

Re: [PATCH v2 1/2] perf tools: Fix potential memory leaks in perf events parser

2020-06-13 Thread Chen Wandun
在 2020/6/12 2:50, Markus Elfring 写道: Fix memory leak of in function parse_events_term__sym_hw() and parse_events_term__clone() when error occur. How do you think about a wording variant like the following? Release a configuration object after a string duplication failed. Thank you for y

[PATCH] hwmon: (ina3221) Fix reference count leak in ina3221_write_enable

2020-06-13 Thread Aditya Pakki
ina3221_write_enable() calls pm_runtime_get_sync() that increments the reference counter. In case of failure, decrement the reference count and return the error. Signed-off-by: Aditya Pakki --- drivers/hwmon/ina3221.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hwmon/ina3221.c b/

[PATCH] ASoC: img: Fix a reference count leak in img_i2s_in_set_fmt

2020-06-13 Thread wu000273
From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Signed-off-by: Qiushi

Re: [PATCH v4 3/9] reset: add BCM6345 reset controller driver

2020-06-13 Thread kernel test robot
x27;--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/lvaro-Fern-ndez-Rojas/bmips-add-bcm6345-reset-controller-support/20200613-164237 base: https://git.pengutronix.de/git/pza/linux re

[PATCH] ASoC: img-parallel-out: Fix a reference count leak

2020-06-13 Thread wu000273
From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Signed-off-by: Qiushi

[PATCH] usb: core: fix reference count leak in usb_port_resume

2020-06-13 Thread Aditya Pakki
usb_port_resume() calls pm_runtime_get_sync() that increments the reference counter. In case of failure, decrement the reference count and return the error. Signed-off-by: Aditya Pakki --- drivers/usb/core/hub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/core/hub.c b/drivers

[PATCH] media: sti: Fix reference count leaks

2020-06-13 Thread wu000273
From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Signed-off-by: Qiushi

Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-13 Thread Chun-Kuang Hu
Hi, Neal: Neal Liu 於 2020年6月9日 週二 下午6:25寫道: > > MT6873 bus frabric provides TrustZone security support and data > protection to prevent slaves from being accessed by unexpected > masters. > The security violations are logged and sent to the processor for > further analysis or countermeasures. > >

[PATCH] usb: musb: fix reference count leak in musb_irq_work

2020-06-13 Thread Aditya Pakki
musb_irq_work() calls pm_runtime_get_sync() that increments the reference counter. In case of failure, decrement the reference count and return the error. Signed-off-by: Aditya Pakki --- drivers/usb/musb/musb_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/musb_core.c

[PATCH] media: exynos4-is: Fix several reference count leaks due to pm_runtime_get_sync

2020-06-13 Thread wu000273
From: Qiushi Wu On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Qiushi Wu --- drivers/media/platform/exynos4-is/fimc-isp.c | 4 +++- drivers/media/platform/exynos4-i

[PATCH] usb: dwc3: pci: Fix reference count leak in dwc3_pci_resume_work

2020-06-13 Thread Aditya Pakki
dwc3_pci_resume_work() calls pm_runtime_get_sync() that increments the reference counter. In case of failure, decrement the reference count and return the error. Signed-off-by: Aditya Pakki --- drivers/usb/dwc3/dwc3-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dri

[PATCH] media: exynos4-is: Fix a reference count leak due to pm_runtime_get_sync

2020-06-13 Thread wu000273
From: Qiushi Wu On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Qiushi Wu --- drivers/media/platform/exynos4-is/media-dev.c | 4 +++- 1 file changed, 3 insertions(+),

Re: [PATCH 13/17] watch_queue: Implement mount topology and attribute change notifications [ver #5]

2020-06-13 Thread Ian Kent
On Thu, 2020-04-02 at 17:19 +0200, Miklos Szeredi wrote: > > > Firstly, a watch queue needs to be created: > > > > pipe2(fds, O_NOTIFICATION_PIPE); > > ioctl(fds[1], IOC_WATCH_QUEUE_SET_SIZE, 256); > > > > then a notification can be set up to report notifications via that > > que

[PATCH] omapfb: fix multiple reference count leaks due to pm_runtime_get_sync

2020-06-13 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki --- drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 7 +-- drivers/video/fbdev/omap2/omapfb/dss/dsi.c

[PATCH] media: exynos4-is: Fix a reference count leak

2020-06-13 Thread wu000273
From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Signed-off-by: Qiushi

[PATCH] media: ti-vpe: Fix a missing check and reference count leak

2020-06-13 Thread wu000273
From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. And also, when the call of function vpe_runtime_get() failed, we won't call vpe_runtime_p

[PATCH] drm/v3d: fix reference count leaks due to pm_runtime_get_sync

2020-06-13 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/v3d/v3d_debugfs.c | 8 ++-- drivers/gpu/drm/v3d/v3d_drv.c | 4 +++- drivers/gpu

[PATCH] drm/bridge: fix reference count leaks due to pm_runtime_get_sync()

2020-06-13 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/bridge/cdns-dsi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -

[PATCH] media: stm32-dcmi: Fix a reference count leak

2020-06-13 Thread wu000273
From: Qiushi Wu Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count if pm_runtime_put is not called in error handling paths. Thus replace the jump target "err_release_buffers" by "err_pm_putw". Fixes: 152e0bf60219 ("media: stm32-dcmi: add power

[PATCH] media: s5p-mfc: Fix a reference count leak

2020-06-13 Thread wu000273
From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Fixes: c5086f130a77 ("

[PATCH] cgroup: Refactor two assignments in css_task_iter_next_css_set()

2020-06-13 Thread zzuedu2000
From: Wei Fenghai Combine two assignments for the variable ‘l’ into one statement. Signed-off-by: Wei Fenghai --- kernel/cgroup/cgroup.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 1ea181a58465..c3e6db6e44d8 100644

Re: [PATCH v2] Makefile: Improve compressed debug info support detection

2020-06-13 Thread Masahiro Yamada
On Fri, Jun 12, 2020 at 8:39 AM Nick Desaulniers wrote: > > On Thu, Jun 11, 2020 at 3:03 PM Arvind Sankar wrote: > > > > Commit > > 10e68b02c861 ("Makefile: support compressed debug info") > > added support for compressed debug sections. > > > > Support is detected by checking > > - does the co

[PATCH] drm/radeon: Fix reference count leaks caused by pm_runtime_get_sync

2020-06-13 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/radeon/radeon_display.c | 4 +++- drivers/gpu/drm/radeon/radeon_drv.c | 4 +++- dri

Re: [PATCH] Fix code style in css_task_iter_next_css_set()

2020-06-13 Thread zzuedu2000
Please ignore this patch, I will send a updated one later. Regards, Wei Fenghai

[PATCH] drm/radeon: fix multiple reference count leak

2020-06-13 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the reference count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/radeon/radeon_connectors.c | 20 +++- 1 file changed, 15 insertions(+),

Re: [GIT PULL] more Kbuild updates for v5.8-rc1

2020-06-13 Thread Masahiro Yamada
Hi Linus, On Sun, Jun 14, 2020 at 5:43 AM Linus Torvalds wrote: > > On Sat, Jun 13, 2020 at 10:56 AM Masahiro Yamada wrote: > > > > - fix build rules in binderfs sample > > .. oh, and now that this builds, it also made it obvious that the > .gitignore file was missing. > > Linus Tha

[PATCH] drm/noveau: fix reference count leak in nouveau_debugfs_strap_peek

2020-06-13 Thread Aditya Pakki
nouveau_debugfs_strap_peek() calls pm_runtime_get_sync() that increments the reference count. In case of failure, decrement the ref count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH] drm/nouveau: fix multiple instances of reference count leaks

2020-06-13 Thread Aditya Pakki
On calling pm_runtime_get_sync() the reference count of the device is incremented. In case of failure, decrement the ref count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/nouveau/nouveau_drm.c | 8 ++-- drivers/gpu/drm/nouveau/nouveau_gem.c | 4 +++- 2 files c

[PATCH] drm/noveau: fix reference count leak in nouveau_fbcon_open

2020-06-13 Thread Aditya Pakki
nouveau_fbcon_open() calls calls pm_runtime_get_sync() that increments the reference count. In case of failure, decrement the ref count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

[PATCH] drm/noveau: fix reference count leak in nv50_disp_atomic_commit

2020-06-13 Thread Aditya Pakki
nv50_disp_atomic_commit() calls calls pm_runtime_get_sync and in turn increments the reference count. In case of failure, decrement the ref count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

[PATCH] drm/nouveau: Fix reference count leak in nouveau_connector_detect

2020-06-13 Thread Aditya Pakki
nouveau_connector_detect() calls pm_runtime_get_sync and in turn increments the reference count. In case of failure, decrement the ref count before returning the error. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/nouveau/nouveau_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deleti

[PATCH] Fix null pointer dereference in vector_user_bpf

2020-06-13 Thread Gaurav Singh
The bpf_prog is being checked for !NULL after uml_kmalloc but later its used directly for example: bpf_prog->filter = bpf and is also later returned upon success. Fix this, do a NULL check and return right away. Signed-off-by: Gaurav Singh --- arch/um/drivers/vector_user.c | 8 +--- 1 file

[PATCH 1/3] thermal/cpu-cooling, sched/core: Cleanup thermal pressure definition

2020-06-13 Thread Valentin Schneider
The following commit: 14533a16c46d ("thermal/cpu-cooling, sched/core: Move the arch_set_thermal_pressure() API to generic scheduler code") moved the definition of arch_set_thermal_pressure() to sched/core.c, but kept its declaration in linux/arch_topology.h. When building e.g. an x86 kernel wi

[PATCH 2/3] sched: Cleanup SCHED_THERMAL_PRESSURE setup

2020-06-13 Thread Valentin Schneider
As Russell pointed out [1], this option is severely lacking in the documentation department, and figuring out if one has the required dependencies to benefit from turning it on is not straightforward. Make it non user-visible, and add a bit of help to it. While at it, make it depend on CPU_FREQ_TH

[PATCH 0/3] sched, arch_topology: Thermal pressure configuration cleanup

2020-06-13 Thread Valentin Schneider
Hi folks, This stems from this thread [1] on the list. TL;DR: the thermal pressure config has no helpful documentation, and figuring out if the right dependencies are in place is not easy for a regular user. The current landscape also paints an odd picture: arch_set_thermal_pressure() is hardcod

[PATCH 3/3] arm, arm64: Select CONFIG_SCHED_THERMAL_PRESSURE

2020-06-13 Thread Valentin Schneider
This option now correctly depends on CPU_FREQ_THERMAL, so select it on the architectures that implement the required functions, arch_set_thermal_pressure() and arch_get_thermal_pressure(). Signed-off-by: Valentin Schneider --- arch/arm/Kconfig | 1 + arch/arm64/Kconfig | 1 + 2 files changed,

Re: [RFC,net-next, 1/5] l3mdev: add infrastructure for table to VRF mapping

2020-06-13 Thread David Ahern
On 6/12/20 10:49 AM, Andrea Mayer wrote: > @@ -37,6 +45,15 @@ struct l3mdev_ops { > > #ifdef CONFIG_NET_L3_MASTER_DEV > > +int l3mdev_table_lookup_register(enum l3mdev_type l3type, > + int (*fn)(struct net *net, u32 table_id)); > + > +void l3mdev_table_lookup_unreg

Re: [RFC,net-next, 2/5] vrf: track associations between VRF devices and tables

2020-06-13 Thread David Ahern
On 6/13/20 4:53 PM, Andrea Mayer wrote: > Hi Stephen, > thanks for your questions. > > On Sat, 13 Jun 2020 12:28:59 -0700 > Stephen Hemminger wrote: > >>> + >>> +* Conversely, shared_table is decreased when a vrf is de-associated >>> +* from a table with exactly two associated vrfs. >>>

Re: [RFC,net-next, 0/5] Strict mode for VRF

2020-06-13 Thread David Ahern
On 6/13/20 4:39 PM, Dinesh Dutt wrote: > Understand Andrea. I guess I didn't say it well. What I meant to say was > that the strict mode is the default expected behavior in a classical router. > it has to be off by default for backwards compatibility.

Re: [PATCH] scsi: target/sbp: remove firewire SBP target driver

2020-06-13 Thread Finn Thain
On Sat, 13 Jun 2020, Chris Boot wrote: > I no longer have the time to maintain this subsystem nor the hardware to > test patches with. Then why not patch MAINTAINERS, and orphan it, as per usual practice? $ git log --oneline MAINTAINERS | grep -i orphan > It also doesn't appear to have any act

[PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash

2020-06-13 Thread Sven Van Asbroeck
Cc: linux-...@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Sven Van Asbroeck --- Tree: next-20200613 drivers/mtd/spi-nor/winbond.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c index 5062af10f138..18bdff02f57f 10

Re: BUG: kernel NULL pointer dereference from check_preempt_wakeup()

2020-06-13 Thread Paul E. McKenney
On Sat, Jun 13, 2020 at 07:57:19AM -0700, Paul E. McKenney wrote: > On Sat, Jun 13, 2020 at 09:26:40AM +0200, Thomas Gleixner wrote: > > "Paul E. McKenney" writes: > > > And an update based on your patch (https://paste.debian.net/1151802/) > > > against 44ebe016df3a ("Merge branch 'proc-linus' of

Re: [GIT] Networking

2020-06-13 Thread pr-tracker-bot
The pull request you sent on Sat, 13 Jun 2020 15:54:03 -0700 (PDT): > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/96144c58abe7ff767e754b5b80995f7b8846d49b Thank you! -- Deet-doot-dot, I am

[PATCH] media: camss: Fix a reference count leak.

2020-06-13 Thread wu000273
From: Qiushi Wu Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count if pm_runtime_put_sync is not called in error handling paths. Thus replace the jump target "error_pm_runtime_get" by "err_clocks". Fixes: 02afa816dbbf ("media: camss: Add basic

[PATCH] media: camss: Fix a reference count leak.

2020-06-13 Thread wu000273
From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if PM runtime put is not called in error handling paths. Thus call pm_runtime_put_sync() if pm_runtime_get_sync() fails. Fixes: 02afa816dbbf ("media: cams

[PATCH] media: vsp1: Fix a reference count leak.

2020-06-13 Thread wu000273
From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Fixes: 1e6af546ee66 ("

[PATCH] media: platform: fcp: Fix a reference count leak.

2020-06-13 Thread wu000273
From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Fixes: 6eaafbdb668b ("

Re: [PATCH v2] page_alloc: consider highatomic reserve in wmartermark fast

2020-06-13 Thread Baoquan He
On 06/13/20 at 10:08pm, Jaewon Kim wrote: ... > > > This is an example of ALLOC_HARDER allocation failure. > > > > > > <4>[ 6207.637280] [3: Binder:9343_3:22875] Binder:9343_3: page > > > allocation failure: order:0, mode:0x480020(GFP_ATOMIC), nodemask=(null) > > > <4>[ 6207.637311] [3: Binder

[PATCH] media: rockchip/rga: Fix a reference count leak.

2020-06-13 Thread wu000273
From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Fixes: f7e7b48e6d79 ("[media] rockchip/rga: v4l2 m2m support") Signed-off-by: Qiushi Wu --- drivers/media/platform

[PATCH] media: mtk-jpeg: Fix a reference count leak.

2020-06-13 Thread wu000273
From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Fixes: b2f0d2724ba4 ("[media] vcodec: mediatek: Add Mediatek JPEG Decoder Driver") Signed-off-by: Qiushi Wu --- d

[PATCH] media: rcar-vin: Fix a reference count leak.

2020-06-13 Thread wu000273
From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Fixes: 2a18fbec1dab ("media: rcar-vin: Move pm_runtime_{get,put} out of helpers") Signed-off-by: Qiushi Wu --- dr

[GIT] Networking

2020-06-13 Thread David Miller
1) Fix cfg80211 deadlock, from Johannes Berg. 2) RXRPC fails to send norigications, from David Howells. 3) MPTCP RM_ADDR parsing has an off by one pointer error, fix from Geliang Tang. 4) Fix crash when using MSG_PEEK with sockmap, from Anny Hu. 5) The ucc_geth driver needs __netdev_watchd

Re: [RFC,net-next, 2/5] vrf: track associations between VRF devices and tables

2020-06-13 Thread Andrea Mayer
Hi Stephen, thanks for your questions. On Sat, 13 Jun 2020 12:28:59 -0700 Stephen Hemminger wrote: > > + > > +* Conversely, shared_table is decreased when a vrf is de-associated > > +* from a table with exactly two associated vrfs. > > +*/ > > + int shared_tables; > > Should this

Re: [PATCH] parisc: suppress error messages for 'make clean'

2020-06-13 Thread Helge Deller
On 13.06.20 21:36, Rolf Eike Beer wrote: > Helge Deller wrote: >> On 10.05.20 03:19, Masahiro Yamada wrote: >>> Hi Helge, >>> >>> On Sun, May 10, 2020 at 2:39 AM Helge Deller wrote: > >>> I will drop this patch from my kbuild tree, >>> then you will apply what you think is best >>> to your tree.

Re: [RFC,net-next, 3/5] vrf: add sysctl parameter for strict mode

2020-06-13 Thread Andrea Mayer
On Fri, 12 Jun 2020 10:52:27 -0700 Jakub Kicinski wrote: > drivers/net/vrf.c:1771:49: warning: incorrect type in argument 3 (different > address spaces) > drivers/net/vrf.c:1771:49:expected void * > drivers/net/vrf.c:1771:49:got void [noderef] *buffer > drivers/net/vrf.c:1785:35: warnin

[PATCH v4 2/3] venus: Make debug infrastructure more flexible

2020-06-13 Thread Stanimir Varbanov
Here we introduce few debug macros with levels (low, medium and high) and debug macro for firmware. Enabling the particular level will be done by dynamic debug. For example to enable debug messages with low level: echo 'format "VENUSL" +p' > debugfs/dynamic_debug/control If you want to enable all

[PATCH v4 0/3] Venus dynamic debug

2020-06-13 Thread Stanimir Varbanov
Hello, Time for v4 with following changes: * 1/3 taken comments into account - Greg KH * 2/3 kept the patch version from v2. Cc: jim.cro...@gmail.com Cc: Joe Perches Cc: Jason Baron Cc: Greg Kroah-Hartman I decided to keep 2/3 as it was in v2 of the current patchset where the grouping of KE

[PATCH v4 1/3] venus: Add debugfs interface to set firmware log level

2020-06-13 Thread Stanimir Varbanov
This will be useful when debugging specific issues related to firmware HFI interface. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/Makefile| 2 +- drivers/media/platform/qcom/venus/core.c | 3 +++ drivers/media/platform/qcom/venus/core.h | 3 +++ driver

[PATCH v4 3/3] venus: Add a debugfs file for SSR trigger

2020-06-13 Thread Stanimir Varbanov
The SSR (SubSystem Restart) is used to simulate an error on FW side of Venus. We support following type of triggers - fatal error, div by zero and watchdog IRQ. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/dbgfs.c | 30 +++ 1 file changed, 30 inserti

Re: [PATCH] net: ethernet: ti: ale: fix allmulti for nu type ale

2020-06-13 Thread David Miller
From: Grygorii Strashko Date: Sat, 13 Jun 2020 17:54:14 +0300 > On AM65xx MCU CPSW2G NUSS and 66AK2E/L NUSS allmulti setting does not allow > unregistered mcast packets to pass. > > This happens, because ALE VLAN entries on these SoCs do not contain port > masks for reg/unreg mcast packets, but

Re: [PATCH] net: ethernet: ti: am65-cpsw-nuss: fix ale parameters init

2020-06-13 Thread David Miller
From: Grygorii Strashko Date: Sat, 13 Jun 2020 17:52:59 +0300 > The ALE parameters structure is created on stack, so it has to be reset > before passing to cpsw_ale_create() to avoid garbage values. > > Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth > subsystem drive

Re: [RFC,net-next, 1/5] l3mdev: add infrastructure for table to VRF mapping

2020-06-13 Thread Andrea Mayer
On Fri, 12 Jun 2020 10:51:48 -0700 Jakub Kicinski wrote: > net/l3mdev/l3mdev.c:12:1: warning: symbol 'l3mdev_lock' was not declared. > Should it be static? > > Please make sure it doesn't add errors with W=1 C=1 :) Hi Jakub, thanks for your feedback. sorry, I did not want to add more warnings

  1   2   3   4   >