Re: [PATCH] f2fs: protect new segment allocation in expand_inode_data

2020-06-02 Thread Chao Yu
On 2020/6/1 11:03, Daeho Jeong wrote: > From: Daeho Jeong > > Found a new segemnt allocation without f2fs_lock_op() in > expand_inode_data(). So, when we do fallocate() for a pinned file > and trigger checkpoint very frequently and simultaneously. F2FS gets > stuck in the below code of do_checkpo

Re: [PATCH v2] f2fs: fix retry logic in f2fs_write_cache_pages()

2020-06-02 Thread Chao Yu
On 2020/6/2 20:41, Sahitya Tummala wrote: > In case a compressed file is getting overwritten, the current retry > logic doesn't include the current page to be retried now as it sets > the new start index as 0 and new end index as writeback_index - 1. > This causes the corresponding cluster to be un

Re: [PATCH v4] EDAC/ghes: Setup DIMM label from DMI and use it in error reports

2020-06-02 Thread Robert Richter
On 02.06.20 17:48:43, Borislav Petkov wrote: > On Thu, May 28, 2020 at 12:13:06PM +0200, Robert Richter wrote: > > v4: > > > > * dimm->label: Only update dimm->label in if bank/device is found in > >the SMBIOS table, this keeps current behavior for machines that do > >not provide this in

Re: [PATCH 1/3] dma-direct: provide the ability to reserve per-numa CMA

2020-06-02 Thread kbuild test robot
Hi Barry, I love your patch! Perhaps something to improve: [auto build test WARNING on arm64/for-next/core] [also build test WARNING on linus/master v5.7] [cannot apply to hch-configfs/for-next next-20200602] [if your patch is applied to the wrong git tree, please drop us a note to help improve

Re: cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread Markus Elfring
> Okay, so I don’t have to send the v2 patch. It will become more interesting under which circumstances the presented software development concerns will be taken better into account. Regards, Markus

Re: [PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-02 Thread Takashi Iwai
On Wed, 03 Jun 2020 08:28:09 +0200, Takashi Iwai wrote: > > And, the most suspicious case is the last one, > chip->num_suspended-intf. It means that the device has multiple > USB interfaces and they went to suspend, while the resume isn't > performed for the all suspended interfaces in return. I

[net] seg6: fix seg6_validate_srh() to avoid slab-out-of-bounds

2020-06-02 Thread Ahmed Abdelsalam
The seg6_validate_srh() is used to validate SRH for three cases: case1: SRH of data-plane SRv6 packets to be processed by the Linux kernel. Case2: SRH of the netlink message received from user-space (iproute2) Case3: SRH injected into packets through setsockopt In case1, the SRH can be encoded i

Re: [PATCH] iommu/amd: Fix event counter availability check

2020-06-02 Thread Alexander Monakov
On Tue, 2 Jun 2020, Shuah Khan wrote: > I changed the logic to read config to get max banks and counters > before checking if counters are writable and tried writing to all. > The result is the same and all of them aren't writable. However, > when disable the writable check and assume they are, I

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread wanghai (M)
在 2020/6/3 14:50, Greg Kroah-Hartman 写道: On Wed, Jun 03, 2020 at 02:34:07PM +0800, wanghai (M) wrote: 在 2020/6/3 14:14, Greg Kroah-Hartman 写道: On Wed, Jun 03, 2020 at 09:42:41AM +0800, wanghai (M) wrote: 在 2020/6/3 1:20, Markus Elfring 写道: Fix it by adding a call to kobject_put() in the err

[PATCH] mm: thp: Add new kernel parameters transparent_hugepage_defrag/khugepaged_defrag

2020-06-02 Thread Gavin Guo
There is no way to set up the defrag options in boot time. And it's useful to set it up by default instead of making it work by a systemd/upstart service or put the command to set up defrag inside /etc/rc.local. Signed-off-by: Gavin Guo --- .../admin-guide/kernel-parameters.txt | 18

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread Greg Kroah-Hartman
On Wed, Jun 03, 2020 at 02:34:07PM +0800, wanghai (M) wrote: > > 在 2020/6/3 14:14, Greg Kroah-Hartman 写道: > > On Wed, Jun 03, 2020 at 09:42:41AM +0800, wanghai (M) wrote: > > > 在 2020/6/3 1:20, Markus Elfring 写道: > > > > > Fix it by adding a call to kobject_put() in the error path of > > > > > kob

Re: [PATCHv5 3/5] ext4: mballoc: Introduce pcpu seqcnt for freeing PA to improve ENOSPC handling

2020-06-02 Thread Marek Szyprowski
s-based boards:  BUG: using smp_processor_id() in preemptible [] code: logsave/552  caller is ext4_mb_new_blocks+0x404/0x1300  CPU: 3 PID: 552 Comm: logsave Tainted: G    W 5.7.0-next-20200602 #4  Hardware name: Samsung Exynos (Flattened Device Tree)  [] (unwind_backtrace) from []

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread Markus Elfring
> Please note that you are responding to someone that a lot of kernel > developers and maintainers have blacklisted as being very annoying I can understand that you can occasionally become annoyed. > and not helpful at all. I got the impression that some contributors (including you) found also

Re: [PATCH] efi/libstub: refactor Makefile to not use lib-y syntax

2020-06-02 Thread Ard Biesheuvel
On Wed, 3 Jun 2020 at 07:34, Masahiro Yamada wrote: > > Documentation/kbuild/makefiles.rst says: > > Use of lib-y is normally restricted to `lib/` and `arch/*/lib`. > > I want to disallow lib-y outside of them. > Why? > Add a custom rule to build lib.a, which is linked to the decompressor > fo

[PATCH 1/1] driver core: Fix unbalance probe_count in really_probe()

2020-06-02 Thread Ji-Ze Hong (Peter Hong)
In previous patch, using return -EBUSY in really_probe() instead WARN_ON() only. The following is the partial code. ... atomic_inc(&probe_count); pr_debug("bus: '%s': %s: probing driver %s with device %s\n", drv->bus->name, __func__, drv->name, dev_name(dev

Re: [PATCH 3/6] arm64/vdso: Add time namespace page

2020-06-02 Thread kbuild test robot
Hi Andrei, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on soc/for-next] [also build test WARNING on arm/for-next xlnx/master kvmarm/next v5.7] [cannot apply to arm64/for-next/core next-20200602] [if your patch is applied to the wrong git tree, please drop us a

Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap

2020-06-02 Thread Jason Wang
On 2020/6/3 下午2:34, Michael S. Tsirkin wrote: On Wed, Jun 03, 2020 at 12:18:44PM +0800, Jason Wang wrote: On 2020/6/2 下午9:31, Michael S. Tsirkin wrote: On Tue, Jun 02, 2020 at 02:49:38PM +0800, Jason Wang wrote: On 2020/6/2 下午12:56, Michael S. Tsirkin wrote: On Tue, Jun 02, 2020 at 03:22:49

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-02 Thread Jason Wang
On 2020/6/3 下午2:30, Michael S. Tsirkin wrote: On Wed, Jun 03, 2020 at 02:23:08PM +0800, Jason Wang wrote: BTW now I re-read it I don't understand __vhost_get_user_slow: static void __user *__vhost_get_user_slow(struct vhost_virtqueue *vq, void __us

[PATCH -next] mm/page_alloc.c: Add missing line breaks

2020-06-02 Thread Chen Tao
Add missing line breaks on pr_warn(). Signed-off-by: Chen Tao --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index cef05d3a23f5..0b0f05e1e49e 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -7123,7 +7123,7 @@ static

Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap

2020-06-02 Thread Michael S. Tsirkin
On Wed, Jun 03, 2020 at 12:18:44PM +0800, Jason Wang wrote: > > On 2020/6/2 下午9:31, Michael S. Tsirkin wrote: > > On Tue, Jun 02, 2020 at 02:49:38PM +0800, Jason Wang wrote: > > > On 2020/6/2 下午12:56, Michael S. Tsirkin wrote: > > > > On Tue, Jun 02, 2020 at 03:22:49AM +0800, kbuild test robot wro

Re: [PATCH v2 0/9] Add shared workqueue support for idxd driver

2020-06-02 Thread Vinod Koul
Hi Dave, On 01-06-20, 15:09, Dave Jiang wrote: > Vinod, > Obviously this series won't make it for 5.8 due to being blocked by > Fenghua's PASID series. Do you think you can take patches 4 and 5 > independently? I think these can go into 5.8 and is not dependent on > anything. Thanks. I was out la

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread wanghai (M)
在 2020/6/3 14:14, Greg Kroah-Hartman 写道: On Wed, Jun 03, 2020 at 09:42:41AM +0800, wanghai (M) wrote: 在 2020/6/3 1:20, Markus Elfring 写道: Fix it by adding a call to kobject_put() in the error path of kobject_init_and_add(). Thanks for another completion of the exception handling. Would an o

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Jason Xing
On Wed, Jun 3, 2020 at 1:44 PM Eric Dumazet wrote: > > On Tue, Jun 2, 2020 at 10:05 PM Jason Xing wrote: > > > > Hi Eric, > > > > I'm still trying to understand what you're saying before. Would this > > be better as following: > > 1) discard the tcp_internal_pacing() function. > > 2) remove where

Re: [PATCH v2] exfat: fix memory leak in exfat_parse_param()

2020-06-02 Thread Markus Elfring
> Additionally, there's no point copying param->string in > exfat_parse_param() - just steal it, leaving NULL in param->string. > That's independent from the leak or fix thereof - it's simply > avoiding an extra copy. I find it clearer to provide such a source code adjustment by a separate update

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-02 Thread Michael S. Tsirkin
On Wed, Jun 03, 2020 at 02:23:08PM +0800, Jason Wang wrote: > > > > BTW now I re-read it I don't understand __vhost_get_user_slow: > > > > > > static void __user *__vhost_get_user_slow(struct vhost_virtqueue *vq, > >void __user *addr, unsigned int > >

Re: [PATCH] sound: usb: pcm: fix incorrect power state when playing sound after PM_AUTO suspend

2020-06-02 Thread Takashi Iwai
On Wed, 03 Jun 2020 05:05:15 +0200, Macpaul Lin wrote: > > On Tue, 2020-06-02 at 14:46 +0200, Takashi Iwai wrote: > > On Tue, 02 Jun 2020 13:53:41 +0200, > > Macpaul Lin wrote: > > > > > > This patch fix incorrect power state changed by usb_audio_suspend() > > > when CONFIG_PM is enabled. > > >

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-02 Thread Michael S. Tsirkin
On Wed, Jun 03, 2020 at 05:18:49AM +0100, Al Viro wrote: > On Wed, Jun 03, 2020 at 11:57:11AM +0800, Jason Wang wrote: > > > > How widely do you hope to stretch the user_access areas, anyway? > > > > > > To have best performance for small packets like 64B, if possible, we want to > > disable STA

[PATCH 3/3] dt-bindings: spi: Convert imx lpspi to json-schema

2020-06-02 Thread Anson Huang
Convert the i.MX LPSPI binding to DT schema format using json-schema Signed-off-by: Anson Huang --- .../devicetree/bindings/spi/spi-fsl-lpspi.txt | 29 --- .../devicetree/bindings/spi/spi-fsl-lpspi.yaml | 60 ++ 2 files changed, 60 insertions(+), 29 deletions

[PATCH 1/3] dt-bindings: spi: Convert mxs spi to json-schema

2020-06-02 Thread Anson Huang
Convert the MXS SPI binding to DT schema format using json-schema Signed-off-by: Anson Huang --- Documentation/devicetree/bindings/spi/mxs-spi.txt | 26 -- Documentation/devicetree/bindings/spi/mxs-spi.yaml | 55 ++ 2 files changed, 55 insertions(+), 26 deletions(-)

[PATCH 2/3] dt-bindings: spi: Convert imx cspi to json-schema

2020-06-02 Thread Anson Huang
Convert the i.MX CSPI binding to DT schema format using json-schema, update compatible, remove obsolete properties "fsl,spi-num-chipselects" and update the example based on latest DT file. Signed-off-by: Anson Huang --- .../devicetree/bindings/spi/fsl-imx-cspi.txt | 56 - .../d

[PATCH 0/3] Convert mxs/imx spi/cspi/lpspi binding to json-schema

2020-06-02 Thread Anson Huang
This patch series converts mxs/imx spi/cspi/lpspi binding to json-schema. In fsl-imx-cspi.yaml, also update compatible, remove obsolete properties "fsl,spi-num-chipselects" and update the example based on latest DT file; In spi-fsl-lpspi.yaml, the original maintainer's email address pandy@nxp

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-02 Thread Jason Wang
On 2020/6/3 下午1:46, Michael S. Tsirkin wrote: On Wed, Jun 03, 2020 at 01:18:54PM +0800, Jason Wang wrote: On 2020/6/3 下午12:18, Al Viro wrote: On Wed, Jun 03, 2020 at 11:57:11AM +0800, Jason Wang wrote: How widely do you hope to stretch the user_access areas, anyway? To have best performanc

[PATCH net-next 4/5] hinic: add support to identify physical device

2020-06-02 Thread Luo bin
add support to identify physical device by flashing an LED attached to it with ethtool -p cmd. Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 41 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 2 + .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 1 +

[PATCH net-next 1/5] hinic: add support to set and get pause params

2020-06-02 Thread Luo bin
add support to set pause params with ethtool -A and get pause params with ethtool -a. Also remove set_link_ksettings ops for VF and enable pause by default. Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 100 +- .../net/ethernet/huawei/hinic/hinic_hw_d

[PATCH net-next 2/5] hinic: add support to set and get irq coalesce

2020-06-02 Thread Luo bin
add support to set TX/RX irq coalesce params with ethtool -C and get these params with ethtool -c. Signed-off-by: Luo bin --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 8 + .../net/ethernet/huawei/hinic/hinic_ethtool.c | 294 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.

[PATCH net-next 5/5] hinic: add support to get eeprom information

2020-06-02 Thread Luo bin
add support to get eeprom information from the plug-in module with ethtool -m cmd. Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 68 .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 4 + .../net/ethernet/huawei/hinic/hinic_port.c| 78

[PATCH net-next 3/5] hinic: add self test support

2020-06-02 Thread Luo bin
add support to excute internal and external loopback test with ethtool -t cmd. Signed-off-by: Luo bin --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 6 + .../net/ethernet/huawei/hinic/hinic_ethtool.c | 178 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 3 + .../net/

[PATCH net-next 0/5] hinic: add some ethtool ops support

2020-06-02 Thread Luo bin
patch #1: support to set and get pause params with "ethtool -A/a" cmd patch #2: support to set and get irq coalesce params with "ethtool -C/c" cmd patch #3: support to do self test with "ethtool -t" cmd patch #4: support to identify physical device with "ethtool -p" cmd patch #5

Re: [PATCH 4.4 00/47] 4.4.226-rc2 review

2020-06-02 Thread Naresh Kamboju
git.linaro.org/lkft/arm64-stable-rc.git git branch: 4.4.226-rc2-hikey-20200602-737 git commit: 3f551997d7233bd0a671cbf0312dd475e02c92ee git describe: 4.4.226-rc2-hikey-20200602-737 Test details: https://qa-reports.linaro.org/lkft/linaro-hikey-stable-rc-4.4-oe/build/4.4.226-rc2-hikey-20200602-737 N

RE: [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate

2020-06-02 Thread Stankiewicz, Piotr
> -Original Message- > From: Christoph Hellwig > Sent: Wednesday, June 3, 2020 7:27 AM > To: Stankiewicz, Piotr > Cc: Hunter, Adrian ; Ulf Hansson > ; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where > appropri

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread Greg Kroah-Hartman
On Wed, Jun 03, 2020 at 09:42:41AM +0800, wanghai (M) wrote: > > 在 2020/6/3 1:20, Markus Elfring 写道: > > > Fix it by adding a call to kobject_put() in the error path of > > > kobject_init_and_add(). > > Thanks for another completion of the exception handling. > > > > Would an other patch subject

Re: WARNING in snd_usbmidi_submit_urb/usb_submit_urb

2020-06-02 Thread Greg KH
On Tue, Jun 02, 2020 at 10:41:16PM -0700, syzbot wrote: > syzbot has found a reproducer for the following crash on: > > HEAD commit:1ee08de1 Merge tag 'for-5.8/io_uring-2020-06-01' of git://.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=15f9e51610

Re: [PATCH 4.9 00/55] 4.9.226-rc3 review

2020-06-02 Thread Naresh Kamboju
On Tue, 2 Jun 2020 at 23:44, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.226 release. > There are 55 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Resp

[PATCH] MAINTAINERS: Update maintainer entries for MEN HW

2020-06-02 Thread AGeissler
Remove Andreas Werner as Maintainer of the F21 BMC driver, as he is no longer with the company and add Andreas Geissler as additional Maintainer for all MEN Hardware. Acked-by: Johannes Thumshirn Acked-by: Andreas Werner Signed-off-by: AGeissler --- MAINTAINERS | 12 +++- 1 file chang

[PATCH v2] tools build: Check libasan and libubsan in Makefile.feature

2020-06-02 Thread Tiezhu Yang
When build perf with ASan or UBSan, if libasan or libubsan can not find, the feature-glibc is 0 and there exists the following error log which is wrong, because we can find gnu/libc-version.h in /usr/include, glibc-devel is also installed. [yangtiezhu@linux perf]$ make DEBUG=1 EXTRA_CFLAGS='-fno-o

Re: [RFC] Restrict the untrusted devices, to bind to only a set of "whitelisted" drivers

2020-06-02 Thread Greg Kroah-Hartman
On Wed, Jun 03, 2020 at 02:27:33AM +, Rajat Jain wrote: > On Mon, Jun 1, 2020 at 10:06 PM Greg Kroah-Hartman > wrote: > > > > On Mon, Jun 01, 2020 at 06:25:42PM -0500, Bjorn Helgaas wrote: > > > [+cc Greg, linux-kernel for wider exposure] > > > > Thanks for the cc:, missed this... > > > > > >

Re: linux-sh for-next reactivation

2020-06-02 Thread Yoshinori Sato
On Wed, 03 Jun 2020 07:41:05 +0900, Stephen Rothwell wrote: > > [1 ] > Hi Rich, > > On Tue, 2 Jun 2020 16:28:33 -0400 Rich Felker wrote: > > > > On Tue, Jun 02, 2020 at 03:00:39PM +1000, Stephen Rothwell wrote: > > > Hi Rich, > > > > > > On Mon, 1 Jun 2020 23:11:39 -0400 Rich Felker wrote:

Re: [PATCH 4.14 00/76] 4.14.183-rc2 review

2020-06-02 Thread Naresh Kamboju
On Tue, 2 Jun 2020 at 15:54, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.183 release. > There are 76 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Res

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-02 Thread Michael S. Tsirkin
On Tue, Jun 02, 2020 at 01:43:20PM -0700, Linus Torvalds wrote: > On Tue, Jun 2, 2020 at 1:33 PM Michael S. Tsirkin wrote: > > > > Hmm are you sure we can drop it? access_ok is done in the context > > of the process. Access itself in the context of a kernel thread > > that borrows the same mm. IIU

Re: [PATCH 4.19 00/92] 4.19.126-rc2 review

2020-06-02 Thread Naresh Kamboju
On Tue, 2 Jun 2020 at 15:54, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.126 release. > There are 92 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Res

Re: [PATCH v4 7/7] mtd: spi-nor: macronix: Add Octal 8D-8D-8D supports for Macronix mx25uw51245g

2020-06-02 Thread Pratyush Yadav
On 02/06/20 02:44PM, masonccy...@mxic.com.tw wrote: > > Hi Pratyush, > > > > Subject > > > > Re: [PATCH v4 7/7] mtd: spi-nor: macronix: Add Octal 8D-8D-8D supports > for > > Macronix mx25uw51245g > > > > On 29/05/20 03:36PM, Mason Yang wrote: > > > Macronix mx25uw51245g is a SPI NOR that su

[PATCH 3/4] random: fix an incorrect __user annotation on proc_do_entropy

2020-06-02 Thread Christoph Hellwig
No user pointers for sysctls anymore. Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler") Reported-by: build test robot Signed-off-by: Christoph Hellwig --- drivers/char/random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/random.c b/drive

[PATCH 4/4] trace: fix an incorrect __user annotation on stack_trace_sysctl

2020-06-02 Thread Christoph Hellwig
No user pointers for sysctls anymore. Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler") Reported-by: build test robot Signed-off-by: Christoph Hellwig --- include/linux/ftrace.h | 5 ++--- kernel/trace/trace_stack.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletio

[PATCH 2/4] net/sysctl: remove leftover __user annotations on neigh_proc_dointvec*

2020-06-02 Thread Christoph Hellwig
Remove the leftover __user annotation on the prototypes for neigh_proc_dointvec*. The implementations already got this right, but the headers kept the __user tags around. Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler") Reported-by: build test robot Signed-off-by: Christoph

[PATCH 1/4] net/sysctl: use cpumask_parse in flow_limit_cpu_sysctl

2020-06-02 Thread Christoph Hellwig
cpumask_parse_user works on __user pointers, so this is wrong now. Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler") Reported-by: build test robot Signed-off-by: Christoph Hellwig --- net/core/sysctl_net_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

fixes for work.sysctl

2020-06-02 Thread Christoph Hellwig
Hi Al, a bunch of fixes for the sysctl kernel pointer conversion against your work.sysctl branch. Only the first one is a real behavior fix, the rest just removes left over __user annotations.

Re: [PATCH] h8300: dts: Fix /chosen:stdout-path

2020-06-02 Thread Masahiro Yamada
On Wed, Mar 25, 2020 at 6:53 PM Geert Uytterhoeven wrote: > > arch/h8300/boot/dts/h8s_sim.dts:11.3-25: Warning > (chosen_node_stdout_path): /chosen:stdout-path: property is not a string > arch/h8300/boot/dts/h8300h_sim.dts:11.3-25: Warning > (chosen_node_stdout_path): /chosen:stdout-path

Re: [PATCH v5 00/10] workingset protection/detection on the anonymous LRU list

2020-06-02 Thread Joonsoo Kim
2020년 6월 3일 (수) 오후 12:57, Suren Baghdasaryan 님이 작성: > > On Wed, Apr 8, 2020 at 5:50 PM Joonsoo Kim wrote: > > > > 2020년 4월 9일 (목) 오전 1:55, Vlastimil Babka 님이 작성: > > > > > > On 4/3/20 7:40 AM, js1...@gmail.com wrote: > > > > From: Joonsoo Kim > > > > > > > > Hello, > > > > > > > > This patchset i

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-02 Thread Michael S. Tsirkin
On Wed, Jun 03, 2020 at 01:18:54PM +0800, Jason Wang wrote: > > On 2020/6/3 下午12:18, Al Viro wrote: > > On Wed, Jun 03, 2020 at 11:57:11AM +0800, Jason Wang wrote: > > > > > > How widely do you hope to stretch the user_access areas, anyway? > > > > > > To have best performance for small packets

Re: [PATCH] net: can: remove "WITH Linux-syscall-note" from SPDX tag of C files

2020-06-02 Thread Masahiro Yamada
On Fri, Apr 3, 2020 at 11:35 PM Oliver Hartkopp wrote: > > > > On 03/04/2020 09.37, Masahiro Yamada wrote: > > The "WITH Linux-syscall-note" exception is intended for UAPI headers. > > > > See LICENSES/exceptions/Linux-syscall-note > > > > Signed-off-by: Masahiro Yamada > > Acked-by: Oliver Hartk

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Eric Dumazet
On Tue, Jun 2, 2020 at 10:05 PM Jason Xing wrote: > > Hi Eric, > > I'm still trying to understand what you're saying before. Would this > be better as following: > 1) discard the tcp_internal_pacing() function. > 2) remove where the tcp_internal_pacing() is called in the > __tcp_transmit_skb() fun

Re: [PATCH 05/14] mm: workingset: let cache workingset challenge anon

2020-06-02 Thread Joonsoo Kim
2020년 6월 3일 (수) 오전 1:48, Johannes Weiner 님이 작성: > > On Tue, Jun 02, 2020 at 11:34:17AM +0900, Joonsoo Kim wrote: > > 2020년 6월 2일 (화) 오전 12:56, Johannes Weiner 님이 작성: > > > On Mon, Jun 01, 2020 at 03:14:24PM +0900, Joonsoo Kim wrote: > > > > But, I still think that modified refault activation equati

Re: WARNING in snd_usbmidi_submit_urb/usb_submit_urb

2020-06-02 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:1ee08de1 Merge tag 'for-5.8/io_uring-2020-06-01' of git://.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15f9e51610 kernel config: https://syzkaller.appspot.com/x/.config?x=b46ebd8

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-06-02 Thread Yan Zhao
On Tue, Jun 02, 2020 at 09:55:28PM -0600, Alex Williamson wrote: > On Tue, 2 Jun 2020 23:19:48 -0400 > Yan Zhao wrote: > > > On Tue, Jun 02, 2020 at 04:55:27PM -0600, Alex Williamson wrote: > > > On Wed, 29 Apr 2020 20:39:50 -0400 > > > Yan Zhao wrote: > > > > > > > On Wed, Apr 29, 2020 at 05

[PATCH] efi/libstub: refactor Makefile to not use lib-y syntax

2020-06-02 Thread Masahiro Yamada
Documentation/kbuild/makefiles.rst says: Use of lib-y is normally restricted to `lib/` and `arch/*/lib`. I want to disallow lib-y outside of them. Add a custom rule to build lib.a, which is linked to the decompressor for ARCH=x86, ARCH=arm. For ARCH=arm64, use obj-y to link objects to vmlinux

Re: [PATCH V6 4/5] clk: qcom: Add ipq6018 apss clock controller

2020-06-02 Thread Stephen Boyd
Quoting Sivaprakash Murugesan (2020-06-02 03:47:20) > > On 6/2/2020 1:06 AM, Stephen Boyd wrote: > > Quoting Sivaprakash Murugesan (2020-06-01 05:41:15) > >> On 5/28/2020 7:29 AM, Stephen Boyd wrote: > >>> Quoting Sivaprakash Murugesan (2020-05-27 05:24:51) > diff --git a/drivers/clk/qcom/aps

Re: [PATCH 1/2] remoteproc: qcom: q6v5: Update running state before requesting stop

2020-06-02 Thread Sibi Sankar
Evan, Thanks for taking time to review the series. On 2020-06-02 23:14, Evan Green wrote: On Tue, Jun 2, 2020 at 9:33 AM Sibi Sankar wrote: Sometimes the stop triggers a watchdog rather than a stop-ack. Update the running state to false on requesting stop to skip the watchdog instead. Error

Re: [PATCH v3] iommu/vt-d: Don't apply gfx quirks to untrusted devices

2020-06-02 Thread Mika Westerberg
On Tue, Jun 02, 2020 at 04:26:02PM -0700, Rajat Jain wrote: > +static bool risky_device(struct pci_dev *pdev) > +{ > + if (pdev->untrusted) { > + pci_warn(pdev, > + "Skipping IOMMU quirk for dev (%04X:%04X) on untrusted" > + " PCI link. Plea

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-02 Thread Michael S. Tsirkin
On Wed, Jun 03, 2020 at 02:48:15AM +0100, Al Viro wrote: > On Tue, Jun 02, 2020 at 04:45:05AM -0400, Michael S. Tsirkin wrote: > > So vhost needs to poke at userspace *a lot* in a quick succession. It > > is thus benefitial to enable userspace access, do our thing, then > > disable. Except access_

Re: [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate

2020-06-02 Thread Christoph Hellwig
On Tue, Jun 02, 2020 at 11:20:59AM +0200, Piotr Stankiewicz wrote: > Seeing as there is shorthand available to use when asking for any type > of interrupt, or any type of message signalled interrupt, leverage it. > > Signed-off-by: Piotr Stankiewicz > Reviewed-by: Andy Shevchenko So this crap n

[PATCH 2/3] mailbox: imx: Add runtime PM callback to handle MU clocks

2020-06-02 Thread Anson Huang
Some of i.MX8M SoCs have MU clock, they need to be managed in runtime to make sure the MU clock can be off in runtime, add runtime PM callback to handle MU clock. And on i.MX8MP, the MU clock is combined with power domain and runtime PM is enabled for the clock driver, during noirq suspend/resume

[PATCH 1/3] mailbox: imx: Add context save/restore for suspend/resume

2020-06-02 Thread Anson Huang
From: Dong Aisheng For "mem" mode suspend on i.MX8 SoCs, MU settings could be lost because its power is off, so save/restore is needed for MU settings during suspend/resume. However, the restore can ONLY be done when MU settings are actually lost, for the scenario of settings NOT lost in "freeze"

[PATCH 0/3] Handle mailbox clock/power management related issues

2020-06-02 Thread Anson Huang
Current i.MX mailbox driver mainly supports 2 series i.MX SoCs with different architecture, one is for i.MX8X platforms with SCU inside, the other is for i.MX6/7/8M series without SCU. For i.MX8X, 2 types of MU are supported, one is for system IPC, such kind of MU has no clock/power assignment, th

[PATCH 3/3] mailbox: imx: ONLY IPC MU needs IRQF_NO_SUSPEND flag

2020-06-02 Thread Anson Huang
IPC MU has no power domain assigned and there could be IPC during noirq suspend phase, so IRQF_NO_SUSPEND flag is needed for IPC MU. However, for other MUs, they have power domain assigned and their power will be turned off during noirq suspend phase, but with IRQF_NO_SUSPEND set, their interrupts

Re: [PATCH] arch/x86: reset MXCSR to default in kernel_fpu_begin()

2020-06-02 Thread Petteri Aimonen
Hi, > Is it correct to assume the stuff checked differs from test to test > and done in user-space. > > > undo_evil_state(); > > Is it correct to assume undoing evil differs from test to test > and done in user-space, provide it can be done from userspace. Yes, currently the test works like: d

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-02 Thread Jason Wang
On 2020/6/3 下午12:18, Al Viro wrote: On Wed, Jun 03, 2020 at 11:57:11AM +0800, Jason Wang wrote: How widely do you hope to stretch the user_access areas, anyway? To have best performance for small packets like 64B, if possible, we want to disable STAC not only for the metadata access done by

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-02 Thread Michael S. Tsirkin
On Tue, Jun 02, 2020 at 11:10:57PM +0100, Al Viro wrote: > On Tue, Jun 02, 2020 at 04:42:03PM -0400, Michael S. Tsirkin wrote: > > On Tue, Jun 02, 2020 at 05:30:48PM +0100, Al Viro wrote: > > > On Tue, Jun 02, 2020 at 04:45:05AM -0400, Michael S. Tsirkin wrote: > > > > So vhost needs to poke at use

Re: [PATCH 04/15] ahci: use PCI_IRQ_MSI_TYPES where appropriate

2020-06-02 Thread Christoph Hellwig
On Tue, Jun 02, 2020 at 11:20:12AM +0200, Piotr Stankiewicz wrote: > Seeing as there is shorthand available to use when asking for any type > of interrupt, or any type of message signalled interrupt, leverage it. > > Signed-off-by: Piotr Stankiewicz > Reviewed-by: Andy Shevchenko Im not sure wh

Re: cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread Markus Elfring
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=f359287765c04711ff54fbd11645271d8e5ff763#n465 >> I just used the original author's label, should I replace all his labels >> like'err','err1' with reasonable one. > > No. Do you in

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread Jason Xing
Hi Eric, I'm still trying to understand what you're saying before. Would this be better as following: 1) discard the tcp_internal_pacing() function. 2) remove where the tcp_internal_pacing() is called in the __tcp_transmit_skb() function. If we do so, we could avoid 'too late to give up pacing'.

Re: drm/nouveau/clk/gm20b: Understanding challenges around gm20b_clk_new()

2020-06-02 Thread Markus Elfring
> Ben has explained this problem: > https://lore.kernel.org/patchwork/patch/1249592/ > Since the caller will check "pclk" on failure, we don't need to free > "clk" in gm20b_clk_new() and I think this patch is no longer needed. * I am curious if it can become easier to see the relationships for t

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-02 Thread Anshuman Khandual
On 06/03/2020 08:27 AM, Matthew Wilcox wrote: > On Wed, Jun 03, 2020 at 06:56:57AM +0530, Anshuman Khandual wrote: >> On 06/02/2020 08:31 PM, Matthew Wilcox wrote: >>> On Fri, May 22, 2020 at 09:04:04AM +0530, Anshuman Khandual wrote: This adds the following two new VM events which will hel

Re: [PATCH RFC 1/3] block: add flag 'nowait_requests' into queue limits

2020-06-02 Thread Christoph Hellwig
On Mon, Jun 01, 2020 at 03:37:09PM +0300, Konstantin Khlebnikov wrote: > Add flag for marking bio-based queues which support REQ_NOWAIT. > Set for all request based (mq) devices. > > Stacking device should set it after blk_set_stacking_limits() if method > make_request() itself doesn't delay reque

Re: [PATCH v4 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

2020-06-02 Thread Sumit Garg
On Wed, 3 Jun 2020 at 03:02, Doug Anderson wrote: > > Hi, > > On Fri, May 29, 2020 at 4:27 AM Sumit Garg wrote: > > > > In kgdb context, calling console handlers aren't safe due to locks used > > in those handlers which could in turn lead to a deadlock. Although, using > > oops_in_progress increa

Re: [PATCH v4 1/4] kdb: Re-factor kdb_printf() message write code

2020-06-02 Thread Sumit Garg
On Wed, 3 Jun 2020 at 03:02, Doug Anderson wrote: > > Hi, > > On Fri, May 29, 2020 at 4:27 AM Sumit Garg wrote: > > > > Re-factor kdb_printf() message write code in order to avoid duplication > > of code and thereby increase readability. > > > > Signed-off-by: Sumit Garg > > --- > > kernel/debu

Re: linux-next: manual merge of the akpm-current tree with the tip tree

2020-06-02 Thread Stephen Rothwell
Hi all, On Mon, 25 May 2020 21:04:43 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the akpm-current tree got a conflict in: > > arch/x86/mm/tlb.c > > between commit: > > 83ce56f712af ("x86/mm: Refactor cond_ibpb() to support other use cases") > > from the tip tree and com

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-02 Thread Anshuman Khandual
On 06/02/2020 08:22 PM, Daniel Jordan wrote: > On Mon, Jun 01, 2020 at 09:48:09PM -0700, John Hubbard wrote: >> However, the fact that this is under discussion hints at the need for a >> bit of documentation help. What do you think about adding some notes about >> all of this to, say, Documentat

Re: ARCH=arm64 build breakage for Kbuild for-next branch

2020-06-02 Thread Stephen Rothwell
Hi Masahiro, On Wed, 3 Jun 2020 13:11:59 +0900 Masahiro Yamada wrote: > > If you pull the latest kbuild for-next branch, > ARCH=arm64 will fail to build. > > I will fix it soon. > > For today's linux-next, you can patch > as follows. > (or, you can use the old branch) > > > diff --git a/Make

Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap

2020-06-02 Thread Jason Wang
On 2020/6/2 下午9:31, Michael S. Tsirkin wrote: On Tue, Jun 02, 2020 at 02:49:38PM +0800, Jason Wang wrote: On 2020/6/2 下午12:56, Michael S. Tsirkin wrote: On Tue, Jun 02, 2020 at 03:22:49AM +0800, kbuild test robot wrote: Hi Jason, I love your patch! Yet something to improve: [auto build tes

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-02 Thread Al Viro
On Wed, Jun 03, 2020 at 11:57:11AM +0800, Jason Wang wrote: > > How widely do you hope to stretch the user_access areas, anyway? > > > To have best performance for small packets like 64B, if possible, we want to > disable STAC not only for the metadata access done by vhost accessors but > also t

Re: [PATCH 1/4] dma-mapping: move the remaining DMA API calls out of line

2020-06-02 Thread Alexey Kardashevskiy
On 09/05/2020 18:19, Christoph Hellwig wrote: > On Tue, May 05, 2020 at 02:18:37PM +1000, Alexey Kardashevskiy wrote: >> >> >> On 17/04/2020 17:58, Christoph Hellwig wrote: >>> On Wed, Apr 15, 2020 at 09:21:37PM +1000, Alexey Kardashevskiy wrote: And the fact they were exported leaves possi

ARCH=arm64 build breakage for Kbuild for-next branch

2020-06-02 Thread Masahiro Yamada
Hi Stephen, If you pull the latest kbuild for-next branch, ARCH=arm64 will fail to build. I will fix it soon. For today's linux-next, you can patch as follows. (or, you can use the old branch) diff --git a/Makefile b/Makefile index f80c4ff93ec9..fbb4b95ae648 100644 --- a/Makefile +++ b/Makefil

Re: [PATCH 06/12] PM / devfreq: Add cpu based scaling support to passive_governor

2020-06-02 Thread Chanwoo Choi
Hi Andrew-sh.Cheng, On 6/2/20 9:23 PM, andrew-sh.cheng wrote: > On Thu, 2020-05-28 at 16:17 +0900, Chanwoo Choi wrote: >> Hi Andrew-sh.Cheng, >> >> The exynos-bus.c used the passive governor. >> Even if don't make the problem because DEVFREQ_PARENT_DEV is zero, >> you need to initialize the parent

Re: [PATCH v5 00/10] workingset protection/detection on the anonymous LRU list

2020-06-02 Thread Suren Baghdasaryan
On Wed, Apr 8, 2020 at 5:50 PM Joonsoo Kim wrote: > > 2020년 4월 9일 (목) 오전 1:55, Vlastimil Babka 님이 작성: > > > > On 4/3/20 7:40 AM, js1...@gmail.com wrote: > > > From: Joonsoo Kim > > > > > > Hello, > > > > > > This patchset implements workingset protection and detection on > > > the anonymous LRU l

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-02 Thread Jason Wang
On 2020/6/3 上午9:48, Al Viro wrote: On Tue, Jun 02, 2020 at 04:45:05AM -0400, Michael S. Tsirkin wrote: So vhost needs to poke at userspace *a lot* in a quick succession. It is thus benefitial to enable userspace access, do our thing, then disable. Except access_ok has already been pre-validat

Re: [PATCH 06/12] PM / devfreq: Add cpu based scaling support to passive_governor

2020-06-02 Thread Chanwoo Choi
Hi Andrew-sh.Cheng, Do you know that why cannot show the patches sent from you on mailing list? Even if you sent them to linux-pm mailing list, I cannot find your patches on linux-pm's patchwork[1] and others. [1] https://patchwork.kernel.org/project/linux-pm/list/ Could you find you patch on ma

Re: memory leak in crypto_create_tfm

2020-06-02 Thread Eric Biggers
Probably a bug in crypto/drbg.c. Stephan, can you take a look? On Tue, Jun 02, 2020 at 08:41:21PM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:19409891 Merge tag 'pnp-5.8-rc1' of git://git.kernel.org/p.. > git tree: upstream > console output:

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-06-02 Thread Alex Williamson
On Tue, 2 Jun 2020 23:19:48 -0400 Yan Zhao wrote: > On Tue, Jun 02, 2020 at 04:55:27PM -0600, Alex Williamson wrote: > > On Wed, 29 Apr 2020 20:39:50 -0400 > > Yan Zhao wrote: > > > > > On Wed, Apr 29, 2020 at 05:48:44PM +0800, Dr. David Alan Gilbert wrote: > > > > > > > > > > > > > > > >

Re: [PATCH] xfs/XXX: Add xfs/XXX

2020-06-02 Thread Darrick J. Wong
On Wed, Jun 03, 2020 at 09:56:13AM +0800, Xiao Yang wrote: > On 2020/6/3 2:14, Darrick J. Wong wrote: > > On Tue, Jun 02, 2020 at 04:51:48PM +0800, Xiao Yang wrote: > > > On 2020/4/14 0:30, Darrick J. Wong wrote: > > > > This might be a good time to introduce a few new helpers: > > > > > > > > _re

Re: [GIT PULL] vfs: improve DAX behavior for 5.8, part 2

2020-06-02 Thread pr-tracker-bot
The pull request you sent on Tue, 2 Jun 2020 10:25:50 -0700: > git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/vfs-5.8-merge-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8eeae5bae1239c030ba0b34cac97ebd5e7ec1886 Thank you! -- Deet-doot-dot, I am a bot. htt

  1   2   3   4   5   6   7   8   9   10   >