[PATCH 4/4] workqueue: remove useless unlock() and lock() in series

2020-05-28 Thread Lai Jiangshan
This is no point to unlock() and then lock() the same mutex back to back. Signed-off-by: Lai Jiangshan --- kernel/workqueue.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index c0cbe0de95d0..415893cfb074 100644 --- a/kernel/workqueue.c +++ b/kernel

[PATCH 1/4] workqueue: void unneeded requeuing the pwq in rescuer thread

2020-05-28 Thread Lai Jiangshan
008847f66c3 ("workqueue: allow rescuer thread to do more work.") made the rescuer worker requeue the pwq immediately if there may be more work items which need rescuing instead of waiting for the next mayday timer expiration. Unfortunately, it checks only whether the pool needs help from rescuers,

[PATCH 0/4] workqueue: simple cleanups

2020-05-28 Thread Lai Jiangshan
Simple cleanups found when I was reviewing the lkml patches. Lai Jiangshan (4): workqueue: void unneeded requeuing the pwq in rescuer thread workqueue: rescuer doesn't check wq->rescuer workqueue: free wq->unbound_attrs earlier workqueue: remove useless unlock() and lock() in series Cc: T

Re: [PATCH 08/10] clk: qcom: Add graphics clock controller driver for SM8250

2020-05-28 Thread Sai Prakash Ranjan
Hi Bjorn, On 2020-05-29 06:41, Bjorn Andersson wrote: On Mon 25 May 02:47 PDT 2020, Sai Prakash Ranjan wrote: Hi Jonathan, On 2020-05-25 02:36, Jonathan Marek wrote: > Add support for the graphics clock controller found on SM8250 > based devices. This would allow graphics drivers to probe and

Re: [PATCH v4 2/7] dt-bindings: mdf: ti,j721e-system-controller.yaml: Add J721e

2020-05-28 Thread Roger Quadros
Hi Rob, On 19/05/2020 16:51, Roger Quadros wrote: Add DT binding schema for J721e system controller. Signed-off-by: Roger Quadros --- Changelog: v4 -address comments. Hope this patch is OK now? cheers, -roger  .../mfd/ti,j721e-system-controller.yaml   | 76 +++  1 fi

Re: [PATCH] reiserfs: Replace kmalloc with kcalloc in the comment

2020-05-28 Thread Jan Kara
On Fri 29-05-20 09:02:30, Yi Wang wrote: > From: Liao Pingfang > > Use kcalloc instead of kmalloc in the comment according to > the previous kcalloc() call. > > Signed-off-by: Liao Pingfang Thanks. I've added the patch to my tree.

Re: [PATCH v2 00/12] clean-up the migration target allocation functions

2020-05-28 Thread Joonsoo Kim
2020년 5월 29일 (금) 오전 4:25, Vlastimil Babka 님이 작성: > > On 5/27/20 8:44 AM, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > This patchset clean-up the migration target allocation functions. > > > > * Changes on v2 > > - add acked-by tags > > - fix missing compound_head() call for the patch #3 >

Re: [PATCH] lightnvm: pblk: Fix reference count leak in pblk_sysfs_init.

2020-05-28 Thread Matias Bjørling
On 27/05/2020 23.06, wu000...@umn.edu wrote: From: Qiushi Wu kobject_init_and_add() takes reference even when it fails. Thus, when kobject_init_and_add() returns an error, kobject_put() must be called to properly clean up the kobject. Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-28 Thread Souptick Joarder
On Thu, May 28, 2020 at 12:37 AM John Hubbard wrote: > > On 2020-05-27 01:51, Daniel Vetter wrote: > > On Wed, May 27, 2020 at 10:48:52AM +0200, Daniel Vetter wrote: > >> On Tue, May 26, 2020 at 03:57:45PM -0700, John Hubbard wrote: > >>> On 2020-05-26 14:00, Souptick Joarder wrote: > This co

Re: [PATCH 05/14] mm: workingset: let cache workingset challenge anon

2020-05-28 Thread Joonsoo Kim
2020년 5월 29일 (금) 오전 2:02, Johannes Weiner 님이 작성: > > On Thu, May 28, 2020 at 04:16:50PM +0900, Joonsoo Kim wrote: > > 2020년 5월 27일 (수) 오후 10:43, Johannes Weiner 님이 작성: > > > > > > On Wed, May 27, 2020 at 11:06:47AM +0900, Joonsoo Kim wrote: > > > > 2020년 5월 21일 (목) 오전 8:26, Johannes Weiner 님이 작성: >

Re: [PATCH 05/28] KVM: nSVM: correctly inject INIT vmexits

2020-05-28 Thread Krish Sadhukhan
On 5/26/20 10:22 AM, Paolo Bonzini wrote: The usual drill at this point, except there is no code to remove because this case was not handled at all. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/svm/nested.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/a

linux-next: manual merge of the kvm tree with the s390 tree

2020-05-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the kvm tree got a conflict in: arch/s390/kvm/vsie.c between commit: 0b0ed657fe00 ("s390: remove critical section cleanup from entry.S") from the s390 tree and commit: d075fc3154be ("KVM: s390: vsie: Move conditional reschedule") from the kvm tree.

Re: [PATCH 0/6] arm64: dts: qcom: smmu/USB nodes and HDK855/HDK865 dts

2020-05-28 Thread Bjorn Andersson
On Thu 28 May 20:15 PDT 2020, Jonathan Marek wrote: > On 5/28/20 11:05 PM, Bjorn Andersson wrote: > > On Sat 23 May 19:38 PDT 2020, Jonathan Marek wrote: > > > > > Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. > > > > > > Also add initial dts files for HDK855 and HDK865, based

Re: [PATCH v4 1/2] clk: hisilicon: Use correct return value about hisi_reset_init()

2020-05-28 Thread Tiezhu Yang
On 05/29/2020 12:31 PM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-28 21:02:05) On 05/29/2020 11:58 AM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-28 19:03:54) On 05/29/2020 07:15 AM, Stephen Boyd wrote: Quoting Tiezhu Yang (2020-05-27 19:27:42) On 05/28/2020 03:06 AM, Stephen Bo

Re: [PATCH] mm, memory_failure: only send BUS_MCEERR_AO to early-kill process

2020-05-28 Thread 堀口 直也
On Fri, May 29, 2020 at 01:56:25PM +0800, wetp wrote: > On 2020/5/29 上午10:12, HORIGUCHI NAOYA(堀口 直也) wrote: ... > > > > > @@ -225,8 +225,9 @@ static int kill_proc(struct to_kill *tk, unsigned > > > > > long pfn, int flags) > > > > >* This could cause a loop when the user sets SIGBU

Re: linux-next: manual merge of the rcu tree with the tip tree

2020-05-28 Thread Stephen Rothwell
Hi all, On Fri, 29 May 2020 16:22:34 +1000 Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the rcu tree got a conflict in: > > kernel/rcu/tree.c > > between commits: > > 806f04e9fd2c ("rcu: Allow for smp_call_function() running callbacks from > idle") > aaf2bc50df1

Re: general protection fault in inet_unhash

2020-05-28 Thread Dmitry Vyukov
On Fri, May 29, 2020 at 8:33 AM Andrii Nakryiko wrote: > > On 5/28/20 11:23 PM, Dmitry Vyukov wrote: > > On Thu, May 28, 2020 at 11:01 PM 'Andrii Nakryiko' via syzkaller-bugs > > wrote: > >> > >> On 5/28/20 9:44 AM, syzbot wrote: > >>> Hello, > >>> > >>> syzbot found the following crash on: > >>>

[PATCH] x86/apic/flat64: Add back the early_param("apic", parse_apic)

2020-05-28 Thread Dexuan Cui
parse_apic() allows the user to try a different apic driver than the default one that's automatically chosen. It works for x86_32, but doesn't work for x86_64 becauase it was removed in 2009 for x86_64 by: commit 7b38725318f4 ("x86: remove subarchitecture support code"), whose changelog doesn't exp

Re: [PATCH 3/3] f2fs: fix to cover meta flush with cp_lock

2020-05-28 Thread Chao Yu
On 2020/5/29 3:00, Jaegeuk Kim wrote: > On 05/28, Chao Yu wrote: >> On 2020/5/28 9:26, Jaegeuk Kim wrote: >>> On 05/28, Chao Yu wrote: On 2020/5/28 5:02, Jaegeuk Kim wrote: > On 05/27, Chao Yu wrote: >> meta inode page should be flushed under cp_lock, fix it. > > It doesn't mat

Re: general protection fault in inet_unhash

2020-05-28 Thread Andrii Nakryiko
On 5/28/20 11:23 PM, Dmitry Vyukov wrote: On Thu, May 28, 2020 at 11:01 PM 'Andrii Nakryiko' via syzkaller-bugs wrote: On 5/28/20 9:44 AM, syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:dc0f3ed1 net: phy: at803x: add cable diagnostics support f.. git tree: n

Re: [PATCH 1/4] exfat: redefine PBR as boot_sector

2020-05-28 Thread Tetsuhiro Kohada
I'll make another small patch, OK? No, It make sense to make v3, because you have renamed the variables in boot_sector on this patch. OK. BTW I have a concern about fs_name. The exfat specification says that this field is "EXFAT". I think it's a important field for determining the filesyst

[PATCH] dt-bindings: clock: Convert i.MX8QXP LPCG to json-schema

2020-05-28 Thread Anson Huang
Convert the i.MX8QXP LPCG binding to DT schema format using json-schema. Signed-off-by: Anson Huang --- .../devicetree/bindings/clock/imx8qxp-lpcg.txt | 51 --- .../devicetree/bindings/clock/imx8qxp-lpcg.yaml| 72 ++ 2 files changed, 72 insertions(+), 51 d

Re: general protection fault in inet_unhash

2020-05-28 Thread Andrii Nakryiko
On 5/28/20 2:27 PM, Eric Dumazet wrote: On 5/28/20 2:01 PM, Andrii Nakryiko wrote: On 5/28/20 9:44 AM, syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:    dc0f3ed1 net: phy: at803x: add cable diagnostics support f.. git tree:   net-next console output: https://url

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-05-28 Thread Viresh Kumar
On 29-05-20, 00:20, Jassi Brar wrote: > The fact that all these bits are backed by one physical signal makes I believe that within the IP itself, there must be 32 signals, just that only one comes out of it all OR'd together. Maybe that can be verified by writing 0x01 to it multiple times and it s

Re: [PATCH] staging: gasket: Convert get_user_pages*() --> pin_user_pages*()

2020-05-28 Thread Souptick Joarder
On Fri, May 29, 2020 at 11:46 AM Souptick Joarder wrote: > > On Thu, May 28, 2020 at 4:34 PM Dan Carpenter > wrote: > > > > On Thu, May 28, 2020 at 02:32:42AM +0530, Souptick Joarder wrote: > > > This code was using get_user_pages_fast(), in a "Case 2" scenario > > > (DMA/RDMA), using the catego

Re: general protection fault in inet_unhash

2020-05-28 Thread Dmitry Vyukov
On Thu, May 28, 2020 at 11:01 PM 'Andrii Nakryiko' via syzkaller-bugs wrote: > > On 5/28/20 9:44 AM, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:dc0f3ed1 net: phy: at803x: add cable diagnostics support f.. > > git tree: net-next > > console o

Re: [PATCH] crypto: hisilicon/qm - allow smaller reads in debugfs

2020-05-28 Thread Zhou Wang
On 2020/5/28 20:37, Dan Carpenter wrote: > Originally this code rejected any read less than 256 bytes. There > is no need for this artificial limit. > > Also I have changed the snprintf() functions to scnprintf(). The > difference is that snprintf() returns the number of bytes which would > have

Re: [PATCH v2 1/3] seccomp: Add find_notification helper

2020-05-28 Thread Kees Cook
On Thu, May 28, 2020 at 04:08:56AM -0700, Sargun Dhillon wrote: > This adds a helper which can iterate through a seccomp_filter to > find a notification matching an ID. It removes several replicated > chunks of code. Nice, yes. I was noticing this redundancy too while I was looking at notify locki

linux-next: manual merge of the rcu tree with the tip tree

2020-05-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the rcu tree got a conflict in: kernel/rcu/tree.c between commits: 806f04e9fd2c ("rcu: Allow for smp_call_function() running callbacks from idle") aaf2bc50df1f ("rcu: Abstract out rcu_irq_enter_check_tick() from rcu_nmi_enter()") from the tip tree an

Re: WARNING: suspicious RCU usage in idtentry_exit

2020-05-28 Thread Dmitry Vyukov
On Thu, May 28, 2020 at 10:48 PM Paul E. McKenney wrote: > > On Thu, May 28, 2020 at 10:19:02PM +0200, Thomas Gleixner wrote: > > Paul, > > > > "Paul E. McKenney" writes: > > > On Thu, May 28, 2020 at 03:33:44PM +0200, Thomas Gleixner wrote: > > >> syzbot writes: > > >> Weird. I have no idea how

Re: [PATCH] staging: gasket: Convert get_user_pages*() --> pin_user_pages*()

2020-05-28 Thread Souptick Joarder
On Thu, May 28, 2020 at 4:34 PM Dan Carpenter wrote: > > On Thu, May 28, 2020 at 02:32:42AM +0530, Souptick Joarder wrote: > > This code was using get_user_pages_fast(), in a "Case 2" scenario > > (DMA/RDMA), using the categorization from [1]. That means that it's > > time to convert the get_user_

[PATCH 1/2] dt-bindings: rtc: add wakeup-source for FlexTimer

2020-05-28 Thread Ran Wang
Signed-off-by: Ran Wang --- Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt b/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt index fffac74..d7c482c 100644 --

[PATCH 2/2] rtc: fsl-ftm-alarm: fix freeze(s2idle) doesnot wake

2020-05-28 Thread Ran Wang
Use dev_pm_set_wake_irq() instead of flag IRQF_NO_SUSPEND to enable wakeup system feature for both freeze(s2idle) and mem(deep). Use property 'wakeup-source' to control this feature. Signed-off-by: Ran Wang --- drivers/rtc/rtc-fsl-ftm-alarm.c | 12 ++-- 1 file changed, 10 insertions(+),

Re: linux-next: Tree for May 14 (objtool 2/2)

2020-05-28 Thread Kees Cook
On Thu, May 28, 2020 at 10:44:04AM -0500, Josh Poimboeuf wrote: > On Thu, May 14, 2020 at 09:04:36AM -0700, Randy Dunlap wrote: > > On 5/14/20 4:07 AM, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20200512: > > > > > > > on x86_64: > > > > drivers/ide/ide-tape.o: warning: obj

Re: [PATCH V2 1/3] thermal/int340x_thermal: Export GDDV

2020-05-28 Thread Zhang Rui
On Fri, 2020-05-29 at 00:00 -0600, Pandruvada, Srinivas wrote: > On Mon, 2020-05-18 at 23:18 +, Pandruvada, Srinivas wrote: > > On Mon, 2020-04-13 at 19:09 -0700, Matthew Garrett wrote: > > > From: Matthew Garrett > > > > > > Implementing DPTF properly requires making use of firmware- > > > p

[PATCH v2] usb/phy-generic: Add support for OTG VBUS supply control

2020-05-28 Thread Mike Looijmans
This enables support for VBUS on boards where the power is supplied by a regulator. The regulator is enabled when the USB port enters HOST mode. Signed-off-by: Mike Looijmans --- v2: Added missing "return 0;" in set_vbus method .../devicetree/bindings/usb/usb-nop-xceiv.txt | 3 ++ drivers/usb/

Re: [PATCH V2 1/3] thermal/int340x_thermal: Export GDDV

2020-05-28 Thread Pandruvada, Srinivas
On Mon, 2020-05-18 at 23:18 +, Pandruvada, Srinivas wrote: > On Mon, 2020-04-13 at 19:09 -0700, Matthew Garrett wrote: > > From: Matthew Garrett > > > > Implementing DPTF properly requires making use of firmware-provided > > information associated with the INT3400 device. Calling GDDV > > pro

Re: [PATCH 4/4] selftests/sysctl: Make sysctl test driver as a module

2020-05-28 Thread Kees Cook
On Thu, May 28, 2020 at 11:52:37PM +0900, Masami Hiramatsu wrote: > Fix config file to require CONFIG_TEST_SYSCTL=m instead of y > because this driver introduces a test sysctl interfaces which > are normally not used, and only used for the selftest. > > Signed-off-by: Masami Hiramatsu Reviewed-b

Re: [PATCH 3/4] selftests/sysctl: Fix to load test_sysctl module

2020-05-28 Thread Kees Cook
On Thu, May 28, 2020 at 11:52:26PM +0900, Masami Hiramatsu wrote: > Fix to load test_sysctl.ko module correctly. > > sysctl.sh checks whether the test module is embedded (or loaded > already) or not at first, and if not, it returns skip error > instead of trying modprobe. Thus, there is no chance

Re: [PATCH][V3] arm64: perf: Get the wrong PC value in REGS_ABI_32 mode

2020-05-28 Thread Jiping Ma
On 05/28/2020 03:54 PM, Will Deacon wrote: On Thu, May 28, 2020 at 09:06:07AM +0800, Jiping Ma wrote: On 05/27/2020 11:19 PM, Mark Rutland wrote: On Wed, May 27, 2020 at 09:33:00AM +0800, Jiping Ma wrote: On 05/26/2020 06:26 PM, Mark Rutland wrote: On Mon, May 11, 2020 at 10:52:07AM +0800,

Re: [PATCH 1/4] lib: Make prime number generator independently selectable

2020-05-28 Thread Kees Cook
On Thu, May 28, 2020 at 11:52:06PM +0900, Masami Hiramatsu wrote: > Make prime number generator independently selectable from > kconfig. This allows us to enable CONFIG_PRIME_NUMBERS=m > and run the tools/testing/selftests/lib/prime_numbers.sh > without other DRM selftest modules. Nice catch! I se

Re: [PATCH 09/14] fs: don't change the address limit for ->write_iter in __kernel_write

2020-05-28 Thread Christoph Hellwig
On Thu, May 28, 2020 at 08:00:52PM +0100, Al Viro wrote: > On Thu, May 28, 2020 at 07:40:38AM +0200, Christoph Hellwig wrote: > > If we write to a file that implements ->write_iter there is no need > > to change the address limit if we send a kvec down. Implement that > > case, and prefer it over

Re: [PATCH] mm, memory_failure: only send BUS_MCEERR_AO to early-kill process

2020-05-28 Thread wetp
On 2020/5/29 上午10:12, HORIGUCHI NAOYA(堀口 直也) wrote: On Thu, May 28, 2020 at 02:50:09PM +0800, wetp wrote: On 2020/5/28 上午10:22, HORIGUCHI NAOYA(堀口 直也) wrote: Hi Zhang, Sorry for my late response. On Tue, May 26, 2020 at 03:06:41PM +0800, Wetp Zhang wrote: From: Zhang Yi If a process don'

Re: [PATCH 2/4] lib: Make test_sysctl initialized as module

2020-05-28 Thread Kees Cook
On Thu, May 28, 2020 at 11:52:16PM +0900, Masami Hiramatsu wrote: > test_sysctl.c is expected to be used as a module, but since > it does not use module_init(), it never be registered as > a module and not appeared under /sys/module/. > In the result, the selftests/sysctl/sysctl.sh always fails > t

Re: [PATCH 06/14] fs: remove the call_{read,write}_iter functions

2020-05-28 Thread Christoph Hellwig
On Thu, May 28, 2020 at 07:56:43PM +0100, Al Viro wrote: > On Thu, May 28, 2020 at 07:40:35AM +0200, Christoph Hellwig wrote: > > Just open coding the methods calls is a lot easier to follow. > > Not sure about this one, TBH - it's harder to grep that way, since > you get all the initializers for

Re: [PATCH linux-rcu] docs/litmus-tests: add BPF ringbuf MPSC litmus tests

2020-05-28 Thread Andrii Nakryiko
On Thu, May 28, 2020 at 3:54 PM Joel Fernandes wrote: > > Hello Andrii, > This is quite exciting. Some comments below: > > On Wed, May 27, 2020 at 11:24:08PM -0700, Andrii Nakryiko wrote: > [...] > > diff --git a/Documentation/litmus-tests/bpf-rb/bpf-rb+1p1c+bounded.litmus > > b/Documentation/lit

Re: [RFC 02/17] dma-fence: basic lockdep annotations

2020-05-28 Thread Daniel Vetter
On Thu, May 28, 2020 at 11:54 PM Luben Tuikov wrote: > > On 2020-05-12 4:59 a.m., Daniel Vetter wrote: > > Design is similar to the lockdep annotations for workers, but with > > some twists: > > > > - We use a read-lock for the execution/worker/completion side, so that > > this explicit annotati

Re: [PATCH] usb/phy-generic: Add support for OTG VBUS supply control

2020-05-28 Thread Mike Looijmans
Met vriendelijke groet / kind regards, Mike Looijmans System Expert TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands T: +31 (0) 499 33 69 69 E: mike.looijm...@topicproducts.com W: www.topicproducts.com Please consider the environment before printing this e-mail On 2

Re: [PATCH] PCI: Fix reference count leak in pci_create_slot()

2020-05-28 Thread Markus Elfring
Please add a prefix to the patch subject. > kobject_init_and_add() takes reference even when it fails. I suggest to extend this description another bit. Which object is affected here? > If this function returns an error, kobject_put() must be called to > properly clean up the memory associated

Re: [PATCH v3 4/4] kdb: Switch kdb_msg_write() to use safer polling I/O

2020-05-28 Thread Sumit Garg
On Thu, 28 May 2020 at 20:27, Petr Mladek wrote: > > On Thu 2020-05-28 12:26:20, Daniel Thompson wrote: > > On Thu, May 28, 2020 at 11:48:48AM +0530, Sumit Garg wrote: > > > On Wed, 27 May 2020 at 19:01, Daniel Thompson > > > wrote: > > > > > > > > On Wed, May 27, 2020 at 11:55:59AM +0530, Sumit

Re: [PATCH] regulator: do not balance regulators without constraints

2020-05-28 Thread Marek Szyprowski
Hi Mark, On 28.05.2020 15:43, Mark Brown wrote: > On Thu, May 28, 2020 at 03:11:30PM +0200, Marek Szyprowski wrote: >> Balancing coupled regulators must wait until the clients for all of the >> coupled regualtors set their constraints, otherwise the balancing code >> might change the voltage of th

Re: [PATCH v2 2/2] tests: test seccomp filter notifications

2020-05-28 Thread Kees Cook
On Thu, May 28, 2020 at 05:14:12PM +0200, Christian Brauner wrote: > This verifies we're correctly notified when a seccomp filter becomes > unused when a notifier is in use. While you're adding this, can you adjust the other user_notif tests to check for POLLHUP as well (i.e fail if it appears)?

Re: [PATCH] misc: mic: Replace kmalloc with kzalloc in the error message

2020-05-28 Thread Greg KH
On Fri, May 29, 2020 at 09:01:21AM +0800, Yi Wang wrote: > From: Liao Pingfang > > Use kzalloc instead of kmalloc in the error message according to > the previous kzalloc() call. > > Signed-off-by: Liao Pingfang > --- > drivers/misc/mic/host/mic_main.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH v4 3/4] mm/util.c: remove the VM_WARN_ONCE for vm_committed_as underflow check

2020-05-28 Thread Feng Tang
On Thu, May 28, 2020 at 10:49:28PM -0400, Qian Cai wrote: > On Fri, May 29, 2020 at 09:06:09AM +0800, Feng Tang wrote: > > As is explained by Michal Hocko: > > > > : Looking at the history, this has been added by 82f71ae4a2b8 > > : ("mm: catch memory commitment underflow") to have a safety check >

Re: [PATCH 1/2] mtd: spi-nor: create/Export parameter softwareseq for intel-spi driver to user

2020-05-28 Thread Mika Westerberg
Hi, I wonder if we can "generalize" this a bit and use SW sequencer to run commands HW sequencer does not support? The BIOS can then setup the allowed SW sequencer opcodes and lock the thing down if needed. There are couple of other commands related to FSR register where this could be useful. On

Re: [PATCH v2 1/2] seccomp: notify user trap about unused filter

2020-05-28 Thread Kees Cook
On Fri, May 29, 2020 at 01:32:03AM +0200, Jann Horn wrote: > On Fri, May 29, 2020 at 1:11 AM Kees Cook wrote: > > So, is it safe to detach the filter in release_task()? Has dethreading > > happened yet? i.e. can we race TSYNC? -- is there a possible > > inc-from-zero? > > release_task -> __exit_s

RE: [PATCH net-next v3] ice: Replace one-element arrays with flexible-arrays

2020-05-28 Thread Kirsher, Jeffrey T
> -Original Message- > From: Gustavo A. R. Silva > Sent: Wednesday, May 27, 2020 07:11 > To: Kirsher, Jeffrey T ; David S. Miller > ; Jakub Kicinski > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Gustavo A. R. Silva ; > Kees Cook > Subjec

Re: [PATCH 1/2] workqueue: pin the pool while it is managing

2020-05-28 Thread Lai Jiangshan
On Thu, May 28, 2020 at 10:35 PM Tejun Heo wrote: > > Hello, > > On Thu, May 28, 2020 at 03:06:55AM +, Lai Jiangshan wrote: > > @@ -2129,10 +2128,21 @@ __acquires(&pool->lock) > > static bool manage_workers(struct worker *worker) > > { > > struct worker_pool *pool = worker->pool; > > +

linux-next: manual merge of the tip tree with the arm tree

2020-05-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tip tree got a conflict in: drivers/firmware/efi/libstub/arm32-stub.c between commit: d0f9ca9be11f ("ARM: decompressor: run decompressor in place if loaded via UEFI") from the arm tree and commit: 793473c28a4b ("efi/libstub: Move pr_efi/pr_efi_er

Re: [PATCHv2 2/2] tpm_ftpm_tee: register driver on TEE bus

2020-05-28 Thread Sumit Garg
On Thu, 28 May 2020 at 15:41, Jens Wiklander wrote: > > On Thu, May 28, 2020 at 11:08:18AM +0300, Maxim Uvarov wrote: > > On Wed, 27 May 2020 at 22:42, Jarkko Sakkinen > > wrote: > > > > > > On Mon, 2020-05-25 at 09:50 +0300, Maxim Uvarov wrote: > > > > Jakko, > > > > tee-supplicant application p

RE: [PATCH 1/4] exfat: redefine PBR as boot_sector

2020-05-28 Thread Sungjong Seo
> > [snip] > >> +/* EXFAT: Main and Backup Boot Sector (512 bytes) */ struct > >> +boot_sector { > >> + __u8jmp_boot[BOOTSEC_JUMP_BOOT_LEN]; > >> + __u8oem_name[BOOTSEC_OEM_NAME_LEN]; > > > > According to the exFAT specification, fs_name and BOOTSEC_FS_NAME_LEN > > look better. > > Oops.

Re: [PATCH v3 00/14] mtd: spi-nor: add xSPI Octal DTR support

2020-05-28 Thread masonccyang
Hi Boris, > > > > > > Summary of change log > > v3: > > Add support command sequences to change octal DTR mode and based on > > part of Pratyush's patches set. > > > > v2: > > Parse BFPT & xSPI table for Octal 8D-8D-8D mode parameters and enable Octal > > mode in spi_nor_late_init_params().

Re: next-20200528 - build error in kernel/rcu/refperf.c

2020-05-28 Thread Valdis Klētnieks
On Thu, 28 May 2020 21:48:18 -0700, Randy Dunlap said: > > ERROR: modpost: "__aeabi_uldivmod" [kernel/rcu/refperf.ko] undefined! Gaah. And the reason I didn't spot Paul's post while grepping my linux-kernel mailbox is because *that* thread had a different undefined reference: > > > > > > m68k-l

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-05-28 Thread Jassi Brar
On Thu, May 28, 2020 at 2:20 PM Rob Herring wrote: > > On Fri, May 15, 2020 at 10:47:38AM +0530, Viresh Kumar wrote: > > From: Sudeep Holla > > > > Hi Rob, Arnd and Jassi, > > > > This stuff has been doing rounds on the mailing list since several years > > now with no agreed conclusion by all the

Re: [PATCH] OPP: Check for bandwidth values before creating icc paths

2020-05-28 Thread Viresh Kumar
On 28-05-20, 00:54, Sibi Sankar wrote: > Prevent the core from creating and voting on icc paths when the > opp-table does not have the bandwidth values populated. Currently > this check is performed on the first OPP node. > > Signed-off-by: Sibi Sankar > --- > drivers/opp/of.c | 15 +

[tip:ras/core] BUILD SUCCESS 45811ba140593e288a288c2a2e45d25f38d20d73

2020-05-28 Thread kbuild test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ras/core branch HEAD: 45811ba140593e288a288c2a2e45d25f38d20d73 x86/mce/dev-mcelog: Fix -Wstringop-truncation warning about strncpy() elapsed time: 2010m configs tested: 100 configs skipped: 5 The following configs have

Re: Some -serious- BPF-related litmus tests

2020-05-28 Thread Andrii Nakryiko
On Thu, May 28, 2020 at 3:17 PM Peter Zijlstra wrote: > > On Thu, May 28, 2020 at 06:00:47PM -0400, Joel Fernandes wrote: > > > Any idea why this choice of locking-based ring buffer implementation in BPF? > > The ftrace ring buffer can support NMI interruptions as well for writes. > > > > Also, is

不況に強い社会福祉事業 新規参入オンラインセミナー

2020-05-28 Thread 社会福祉プロジェクト
代表者様 社会福祉事業を応援するメディアを運営しております 社会福祉プロジェクトと申します。 今、新規事業をお考えの経営者様を対象に 社会福祉事業が大変注目されているのを ご存知でしょうか? 今月複数回にわたって開催された 社会福祉プロジェクトオンラインセミナーも 大変な盛会のうちに終える事となりました。 社会福祉プロジェクトセミナーを少しのぞいてみる。 https://fukushi-service.work/seminar/ 実際にセミナーに参加された方からも 「福祉総合企業というビジネスモデルが 印象的でした。」 「リピート率が高い、高収益、貢献ビジネス。 青山先生の

Re: [PATCH] twist: allow converting pr_devel()/pr_debug() into printk(KERN_DEBUG)

2020-05-28 Thread Tetsuo Handa
On 2020/05/29 11:04, Sergey Senozhatsky wrote: > You are not going to add pr_debug() all over the kernel, are you? Of course, I'm not planning to add pr_debug() all over the kernel. When I need to print something to consoles, I will use one-time patch (like https://syzkaller.appspot.com/text?tag=

Re: [PATCH v30 08/20] x86/sgx: Add functions to allocate and free EPC pages

2020-05-28 Thread Jarkko Sakkinen
On Thu, May 28, 2020 at 08:37:16PM -0700, Sean Christopherson wrote: > On Fri, May 29, 2020 at 06:28:16AM +0300, Jarkko Sakkinen wrote: > > On Thu, May 28, 2020 at 12:59:17PM -0700, Sean Christopherson wrote: > > > On Thu, May 28, 2020 at 10:07:18PM +0300, Jarkko Sakkinen wrote: > > > > * sgx_grab

Re: [PATCHES] uaccess i915

2020-05-28 Thread Jani Nikula
On Fri, 29 May 2020, Al Viro wrote: > Low-hanging fruit in i915 uaccess-related stuff. > There's some subtler stuff remaining after that; these > are the simple ones. Please Cc: intel-...@lists.freedesktop.org for i915 changes. Also added Chris who I believe will be able to best review the

Re: [02/12] net: hns3: Destroy a mutex after initialisation failure in hclge_init_ae_dev()

2020-05-28 Thread Markus Elfring
>>> Add a mutex destroy call in hclge_init_ae_dev() when fails. >> >> How do you think about a wording variant like the following? … > It looks better. I will try to improve the skill of patch description > and make as many as people can understand the patch. Thanks for your positive feedback. I

Re: [PATCH v5 4/6] clocksource/drivers/timer-riscv: Use per-CPU timer interrupt

2020-05-28 Thread Atish Patra
On Thu, May 21, 2020 at 6:34 AM Anup Patel wrote: > > Instead of directly calling RISC-V timer interrupt handler from > RISC-V local interrupt conntroller driver, this patch implements > RISC-V timer interrupt as a per-CPU interrupt using per-CPU APIs > of Linux IRQ subsystem. > > Signed-off-by: A

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-28 Thread Oleksij Rempel
On Thu, May 28, 2020 at 06:08:39PM +0200, Andrew Lunn wrote: > On Thu, May 28, 2020 at 03:10:06PM +0200, Geert Uytterhoeven wrote: > > Hi Andrew, > > > > On Wed, May 27, 2020 at 10:52 PM Andrew Lunn wrote: > > > > You may wonder what's the difference between 3 and 4? It's not just the > > > > PHY

Re: nilfs2: Fix reference count leak in nilfs_sysfs_create_snapshot_group()

2020-05-28 Thread Markus Elfring
> I think there is only one object that can be modified in this function, Such a view can be reasonable. > so I didn't mention it. I suggest to reconsider the conclusion. >> I guess that an imperative wording is preferred also for this change >> description. > > This sentence is referenced f

Re: [PATCH v2] twist: allow converting pr_devel()/pr_debug() into snprintf()

2020-05-28 Thread Tetsuo Handa
On 2020/05/29 11:24, Linus Torvalds wrote: > Some flags do end up having to be practically system-wide, because > they end up being used in contexts other than the test environment (ie > anything that ends up doing workqueues or networking or VM or whatever > - it's a "global context"). Right. And

Re: next-20200528 - build error in kernel/rcu/refperf.c

2020-05-28 Thread Randy Dunlap
On 5/28/20 9:16 PM, Valdis Klētnieks wrote: > commit 9088b449814f788d24f35a5840b6b2c2a23cd32a > Author: Paul E. McKenney > Date: Mon May 25 17:22:24 2020 -0700 > > refperf: Provide module parameter to specify number of experiments > > changes this line of code (line 389) > > -

Re: [PATCH v8 04/10] OPP: Add support for parsing interconnect bandwidth

2020-05-28 Thread Viresh Kumar
On 12-05-20, 15:53, Georgi Djakov wrote: > struct dev_pm_opp *_opp_allocate(struct opp_table *table) > { > struct dev_pm_opp *opp; > - int count, supply_size; > + int supply_count, supply_size, icc_size; > > /* Allocate space for at least one supply */ > - count = table-

[tip:sched/urgent] BUILD SUCCESS 18f855e574d9799a0e7489f8ae6fd8447d0dd74a

2020-05-28 Thread kbuild test robot
00527 i386 randconfig-a002-20200527 i386 randconfig-a005-20200527 x86_64 randconfig-a013-20200528 x86_64 randconfig-a015-20200528 x86_64 randconfig-a012-20200528 x86_64 randconfig-a016-20200528 x

Re: Some -serious- BPF-related litmus tests

2020-05-28 Thread Andrii Nakryiko
On Thu, May 28, 2020 at 2:48 PM Joel Fernandes wrote: > > On Mon, May 25, 2020 at 11:38:23AM -0700, Andrii Nakryiko wrote: > > On Mon, May 25, 2020 at 7:53 AM Boqun Feng wrote: > > > > > > Hi Andrii, > > > > > > On Fri, May 22, 2020 at 12:38:21PM -0700, Andrii Nakryiko wrote: > > > > On 5/22/20 1

Re: [PATCH 0/3] MIPS: Loongson64: Initial LS7A PCH support

2020-05-28 Thread Jiaxun Yang
于 2020年5月29日 GMT+08:00 下午12:13:36, Huacai Chen 写到: >Hi, Jiaxun, > >On Fri, May 29, 2020 at 11:45 AM Jiaxun Yang wrote: >> >> With this series, LS7A and Loongson-3A4000 is finally supported >> note that this series should depend on irqchip support[1], which >> is likely to get merged soon. >> >

[PATCH v2] usb: host: xhci-mtk: avoid runtime suspend when removing hcd

2020-05-28 Thread Macpaul Lin
When runtime suspend was enabled, runtime suspend might happened when xhci is removing hcd. This might cause kernel panic when hcd has been freed but runtime pm suspend related handle need to reference it. Signed-off-by: Macpaul Lin --- drivers/usb/host/xhci-mtk.c |5 +++-- 1 file changed, 3

Re: [PATCH v4 1/2] clk: hisilicon: Use correct return value about hisi_reset_init()

2020-05-28 Thread Stephen Boyd
Quoting Tiezhu Yang (2020-05-28 21:02:05) > On 05/29/2020 11:58 AM, Stephen Boyd wrote: > > Quoting Tiezhu Yang (2020-05-28 19:03:54) > >> On 05/29/2020 07:15 AM, Stephen Boyd wrote: > >>> Quoting Tiezhu Yang (2020-05-27 19:27:42) > On 05/28/2020 03:06 AM, Stephen Boyd wrote: > > Quoting T

[PATCH] usb: host: xhci-mtk: avoid runtime suspend when removing hcd

2020-05-28 Thread Macpaul Lin
When runtime suspend was enabled, runtime suspend might happened when xhci is removing hcd. This might cause kernel panic when hcd has been freed but runtime pm suspend related handle need to reference it. Change-Id: I70a5dc8006207caeecbac6955ce8e5345dcc70e6 Signed-off-by: Macpaul Lin --- driver

Re: [PATCH V2 1/3] clk: vc5: Allow Versaclock driver to support multiple instances

2020-05-28 Thread Stephen Boyd
Quoting Adam Ford (2020-05-02 05:21:24) > diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c > index fa96659f8023..81255d923f00 100644 > --- a/drivers/clk/clk-versaclock5.c > +++ b/drivers/clk/clk-versaclock5.c > @@ -881,6 +871,8 @@ static int vc5_probe(struct i2c_client *cl

Re: [PATCH v2] clk: mediatek: assign the initial value to clk_init_data of mtk_mux

2020-05-28 Thread Stephen Boyd
Quoting Weiyi Lu (2020-05-26 23:25:49) > When some new clock supports are introduced, e.g. [1] > it might lead to an error although it should be NULL because > clk_init_data is on the stack and it might have random values > if using without initialization. > Add the missing initial value to clk_ini

RE: [PATCH v5 0/6] New RISC-V Local Interrupt Controller Driver

2020-05-28 Thread Anup Patel
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Palmer Dabbelt > Sent: 29 May 2020 09:43 > To: a...@brainfault.org > Cc: Marc Zyngier ; Anup Patel ; Paul > Walmsley ; a...@eecs.berkeley.edu; > daniel.lezc...@linaro.org; t...@linutronix.

Re: [PATCH] PCI: ERR: Don't override the status returned by error_detect()

2020-05-28 Thread Kuppuswamy, Sathyanarayanan
On 5/28/20 9:04 PM, Z.q. Hou wrote: Hi Kuppuswamy, -Original Message- From: Kuppuswamy, Sathyanarayanan Sent: 2020年5月29日 5:19 To: Z.q. Hou ; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; rus...@russell.cc; sbobr...@linux.ibm.com; ooh...@gmail.com; bhelg...@google.com Subj

Re: [PATCH v4 1/2] powerpc/uaccess: Implement unsafe_put_user() using 'asm goto'

2020-05-28 Thread Michael Ellerman
On Fri, 2020-04-17 at 17:08:51 UTC, Christophe Leroy wrote: > unsafe_put_user() is designed to take benefit of 'asm goto'. > > Instead of using the standard __put_user() approach and branch > based on the returned error, use 'asm goto' and make the > exception code branch directly to the error lab

Re: [PATCH v2 4/5] powerpc/uaccess: Implement user_read_access_begin and user_write_access_begin

2020-05-28 Thread Michael Ellerman
On Fri, 2020-04-03 at 07:20:53 UTC, Christophe Leroy wrote: > Add support for selective read or write user access with > user_read_access_begin/end and user_write_access_begin/end. > > Signed-off-by: Christophe Leroy > Reviewed-by: Kees Cook Applied to powerpc topic/uaccess-ppc, thanks. https:

Re: [PATCH 3/5] dt-bindings: clock: mediatek: document clk bindings vcodecsys for Mediatek MT6765 SoC

2020-05-28 Thread Stephen Boyd
Quoting Macpaul Lin (2020-02-21 01:52:20) > This patch adds the binding documentation for vcodecsys. > > Signed-off-by: Mars Cheng > Signed-off-by: Owen Chen > Signed-off-by: Macpaul Lin > --- Applied to clk-next

Re: [RFC PATCH 3/6] dt-bindings: display/bridge/nwl-dsi: Drop mux handling

2020-05-28 Thread Guido Günther
Hi Rob, On Thu, May 28, 2020 at 01:59:14PM -0600, Rob Herring wrote: > On Fri, May 15, 2020 at 03:12:12PM +0200, Guido Günther wrote: > > No need to encode the SoC specifics in the bridge driver. For the > > imx8mq we can use the mux-input-bridge. > > You can't just change bindings like this. You'

Re: [PATCH v4 2/2] powerpc/uaccess: Implement unsafe_copy_to_user() as a simple loop

2020-05-28 Thread Michael Ellerman
On Fri, 2020-04-17 at 17:08:52 UTC, Christophe Leroy wrote: > At the time being, unsafe_copy_to_user() is based on > raw_copy_to_user() which calls __copy_tofrom_user(). > > __copy_tofrom_user() is a big optimised function to copy big amount > of data. It aligns destinations to cache line in order

Re: [PATCH 4/5] clk: mediatek: add mt6765 clock IDs

2020-05-28 Thread Stephen Boyd
Quoting Macpaul Lin (2020-02-21 01:52:21) > From: Mars Cheng > > Add MT6765 clock dt-bindings, include topckgen, apmixedsys, > infracfg, mcucfg and subsystem clocks. > > Signed-off-by: Mars Cheng > Signed-off-by: Owen Chen > Signed-off-by: Macpaul Lin > Reviewed-by: Rob Herring > --- Applie

Re: [PATCH 5/5] clk: mediatek: Add MT6765 clock support

2020-05-28 Thread Stephen Boyd
Quoting Macpaul Lin (2020-02-21 01:52:22) > From: Owen Chen > > Add MT6765 clock support, include topckgen, apmixedsys, > infracfg, mcucfg and subsystem clocks. > > Signed-off-by: Owen Chen > Signed-off-by: Mars Cheng > Signed-off-by: Macpaul Lin > --- Applied to clk-next

Re: [PATCH v2 2/5] uaccess: Selectively open read or write user access

2020-05-28 Thread Michael Ellerman
On Fri, 2020-04-03 at 07:20:51 UTC, Christophe Leroy wrote: > When opening user access to only perform reads, only open read access. > When opening user access to only perform writes, only open write > access. > > Signed-off-by: Christophe Leroy > Reviewed-by: Kees Cook Applied to powerpc topic

Re: [PATCH v2 1/5] uaccess: Add user_read_access_begin/end and user_write_access_begin/end

2020-05-28 Thread Michael Ellerman
On Fri, 2020-04-03 at 07:20:50 UTC, Christophe Leroy wrote: > Some architectures like powerpc64 have the capability to separate > read access and write access protection. > For get_user() and copy_from_user(), powerpc64 only open read access. > For put_user() and copy_to_user(), powerpc64 only open

Re: [PATCH v2 3/5] drm/i915/gem: Replace user_access_begin by user_write_access_begin

2020-05-28 Thread Michael Ellerman
On Fri, 2020-04-03 at 07:20:52 UTC, Christophe Leroy wrote: > When i915_gem_execbuffer2_ioctl() is using user_access_begin(), > that's only to perform unsafe_put_user() so use > user_write_access_begin() in order to only open write access. > > Signed-off-by: Christophe Leroy > Reviewed-by: Kees C

Re: [PATCH 1/5] dt-bindings: clock: mediatek: document clk bindings for Mediatek MT6765 SoC

2020-05-28 Thread Stephen Boyd
Quoting Macpaul Lin (2020-02-21 01:52:18) > This patch adds the binding documentation for apmixedsys, audsys, camsys, > imgsys, infracfg, mmsys, pericfg, topckgen > > Signed-off-by: Mars Cheng > Signed-off-by: Owen Chen > Signed-off-by: Macpaul Lin > --- Applied to clk-next

Re: [PATCH 2/5] dt-bindings: clock: mediatek: document clk bindings mipi0a for Mediatek MT6765 SoC

2020-05-28 Thread Stephen Boyd
Quoting Macpaul Lin (2020-02-21 01:52:19) > This patch adds the binding documentation for mipi0a. > > Signed-off-by: Mars Cheng > Signed-off-by: Owen Chen > Signed-off-by: Macpaul Lin > --- Applied to clk-next

  1   2   3   4   5   6   7   8   9   10   >