Re: [RFC, WIP, v4 09/11] media: vidtv: implement a PES packetizer

2020-05-05 Thread Daniel W. S. Almeida
Hi Mauro, > As commented, don't use WARN_ON(). At most, you could use WARN_ON_ONCE(), > as otherwise, you may end by causing serious performance issues if > the code starts to produce a flood of warnings at the dmesg. > > I would use pr_warn_ratelimit() on all such cases. > OK. > I don't l

Re: [f2fs-dev] [PATCH] f2fs: get parent inode when recovering pino

2020-05-05 Thread Chao Yu
On 2020/5/6 9:24, Eric Biggers wrote: > On Wed, May 06, 2020 at 08:14:07AM +0800, Gao Xiang wrote: >>> >>> Actually, I think this is wrong because the fsync can be done via a file >>> descriptor that was opened to a now-deleted link to the file. >> >> I'm still confused about this... >> >> I don't

Re: [PATCH v2] checkpatch: use patch subject when reading from stdin

2020-05-05 Thread Geert Uytterhoeven
Hi Andrew, On Tue, May 5, 2020 at 9:18 PM Andrew Morton wrote: > On Tue, 5 May 2020 15:26:13 +0200 Geert Uytterhoeven > wrote: > > While "git am" can apply an mbox file containing multiple patches (e.g. > > as created by b4[1], or a patch bundle downloaded from patchwork), > > checkpatch does

[PATCH rdma-next 0/3] mlx5 QP cleanup (cont.)

2020-05-05 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This short series continue to cleanup qp.c file, which grew to be completely unmaintainable. Thanks Leon Romanovsky (2): RDMA/mlx5: Update mlx5_ib to use new cmd interface RDMA/mlx5: Move all WR logic from qp.c to separate file Max Gurtovoy (1): RDMA/mlx5: Refa

Re: [RFC PATCH v12 6/9] media: tegra: Add Tegra210 Video input driver

2020-05-05 Thread Hans Verkuil
On 05/05/2020 04:31, Sowjanya Komatineni wrote: > Tegra210 contains a powerful Video Input (VI) hardware controller > which can support up to 6 MIPI CSI camera sensors. > > Each Tegra CSI port can be one-to-one mapped to VI channel and can > capture from an external camera sensor connected to CSI

Re: [RFC PATCH v12 7/9] MAINTAINERS: Add Tegra Video driver section

2020-05-05 Thread Hans Verkuil
On 05/05/2020 04:31, Sowjanya Komatineni wrote: > Add maintainers and mailing list entries to Tegra Video driver section. > > Acked-by: Thierry Reding > Signed-off-by: Sowjanya Komatineni Since this goes through Thierry: Signed-off-by: Hans Verkuil Regards, Hans > --- > MAINTAINER

Re: [EXT] [PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-05-05 Thread Igor Russkikh
> #include > +#include > #include > #include > #include > @@ -574,13 +575,13 @@ int qede_add_tc_flower_fltr(struct qede_dev *edev, > __be16 proto, > #define RX_RING_SIZE ((u16)BIT(RX_RING_SIZE_POW)) > #define NUM_RX_BDS_MAX (RX_RING_SIZE - 1) > #define NUM_RX_BD

[PATCH] powerpc/8xx: Update email address in MAINTAINERS

2020-05-05 Thread Christophe Leroy
Since 01 May 2020, our email adresses have changed to @csgroup.eu Update MAINTAINERS accordingly. Signed-off-by: Christophe Leroy --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2926327e4976..e8714328cc90 100644 --- a/MAINTAINE

Re: [PATCH v4 1/9] w1_therm: creating w1_therm.h

2020-05-05 Thread Greg KH
On Tue, May 05, 2020 at 11:04:39PM +0200, Akira shimahara wrote: > Le mardi 05 mai 2020 à 16:48 +0200, Greg KH a écrit : > > > Creating w1_therm.h header to organize code. Organize the > > > w1_therm.c file > > > to gather hardware functions, device specific functions, interface > > > functions and

Re: [PATCH v2] net: ethernet: ti: Remove TI_CPTS_MOD workaround

2020-05-05 Thread Clay McClure
On Tue, May 05, 2020 at 10:41:26AM +0300, Grygorii Strashko wrote: > It's better if you send v2 not as reply to v1. Noted, thank you, and thank you for taking the time to review my patch. > just to clarify. After these two patches > - the PTP_1588_CLOCK can still be set to "M" > - which will c

[PATCH] netfilter: fix make target xt_TCPMSS.o error.

2020-05-05 Thread Huang Qijun
When compiling netfilter, there will be an error "No rule to make target 'net/netfilter/xt_TCPMSS.o'", because the xt_TCPMSS.c in the makefile is uppercase, and the file name of the source file (xt_tcpmss.c) is lowercase. Therefore, change the xt_TCPMSS.c name in the makefile to all lowercase. Sig

Re: [PATCH v9 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2020-05-05 Thread Xin Ji
On Fri, May 01, 2020 at 04:11:50PM -0500, Rob Herring wrote: > On Thu, 30 Apr 2020 17:34:11 +0800, Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > > for portable device. It converts MIPI to DisplayPort 1.3 4K. > > > > You can add support to your board with b

Re: [f2fs-dev] [PATCH] f2fs: get parent inode when recovering pino

2020-05-05 Thread Gao Xiang
On Wed, May 06, 2020 at 09:58:22AM +0800, Gao Xiang wrote: > On Tue, May 05, 2020 at 06:24:28PM -0700, Eric Biggers wrote: > > On Wed, May 06, 2020 at 08:14:07AM +0800, Gao Xiang wrote: > > > > > > > > Actually, I think this is wrong because the fsync can be done via a file > > > > descriptor that

Re: [f2fs-dev] [PATCH] f2fs: remove redundant check in f2fs_force_buffered_io

2020-05-05 Thread Chao Yu
On 2020/5/5 11:23, Jaegeuk Kim wrote: > On 05/05, Chao Yu wrote: >> On 2020-5-4 22:35, Jaegeuk Kim wrote: >>> From: Daeho Jeong >>> >>> We already checked whether the file is compressed or not in >>> f2fs_post_read_required(). So removed f2fs_compressed_file() >>> in f2fs_force_buffered_io(). >> >

Re: [PATCH 0/2] Backport to 4.19 - sctp: fully support memory accounting

2020-05-05 Thread Greg KH
On Wed, May 06, 2020 at 07:50:52PM +0530, ashwin-h wrote: > Backport below upstream commits to 4.19 to address CVE-2019-3874. > 1033990ac5b2ab6cee93734cb6d301aa3a35bcaa > sctp: implement memory accounting on tx path > > 9dde27de3e5efa0d032f3c891a0ca833a0d31911 > sctp: implement memory accounting o

[PATCH] arm64/mm: Remove add_huge_page_size()

2020-05-05 Thread Gavin Shan
The function add_huge_page_size(), wrapper of hugetlb_add_hstate(), avoids to register duplicated huge page states for same size. However, the same logic has been included in hugetlb_add_hstate(). So it seems unnecessary to keep add_huge_page_size() and this just removes it. Signed-off-by: Gavin S

Re: [PATCH 1/2] sctp: implement memory accounting on tx path

2020-05-05 Thread Greg KH
On Wed, May 06, 2020 at 07:50:53PM +0530, ashwin-h wrote: > From: Xin Long > > commit 1033990ac5b2ab6cee93734cb6d301aa3a35bcaa upstream. > > Now when sending packets, sk_mem_charge() and sk_mem_uncharge() have been > used to set sk_forward_alloc. We just need to call sk_wmem_schedule() to > chec

Re: [PATCH 2/2] sctp: implement memory accounting on rx path

2020-05-05 Thread Greg KH
On Wed, May 06, 2020 at 07:50:54PM +0530, ashwin-h wrote: > From: Xin Long > > commit 9dde27de3e5efa0d032f3c891a0ca833a0d31911 upstream. > > sk_forward_alloc's updating is also done on rx path, but to be consistent > we change to use sk_mem_charge() in sctp_skb_set_owner_r(). > > In sctp_eat_da

[PATCH -next] x86/platform/uv: Use false for return type bool

2020-05-05 Thread Samuel Zou
Fix the following coccicheck warning: arch/x86/include/asm/uv/uv.h:45:53-54: WARNING: return of 0/1 in function 'is_early_uv_system' with return type bool Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- arch/x86/include/asm/uv/uv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-05 Thread Bartosz Golaszewski
wt., 5 maj 2020 o 21:25 Edwin Peer napisał(a): > > + > > +static void devm_netdev_release(struct device *dev, void *this) > > +{ > > + struct netdevice_devres *res = this; > > + > > + unregister_netdev(res->ndev); > > +} > > + > > +/** > > + * devm_register_netdev - resource manage

Re: [PATCH V3 08/16] arm64/cpufeature: Add remaining feature bits in ID_MMFR4 register

2020-05-05 Thread Anshuman Khandual
On 05/05/2020 04:44 PM, Will Deacon wrote: > On Sat, May 02, 2020 at 07:03:57PM +0530, Anshuman Khandual wrote: >> Enable all remaining feature bits like EVT, CCIDX, LSM, HPDS, CnP, XNX, >> SpecSEI in ID_MMFR4 register per ARM DDI 0487F.a. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Ma

[PATCH 4/4] clk: stm32f4: fix ltdc driver hang as clk set rate failed

2020-05-05 Thread dillon . minfei
From: dillon min should use PLL_SAI offset of clks , not PLL_VCO_SAI else can not get clk gate. Signed-off-by: dillon min --- drivers/clk/clk-stm32f4.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c index 18117ce

[no subject]

2020-05-05 Thread dillon . minfei
Fix stm32f429's ltdc driver loading hang in ltdc clk enable. set clk_hw to the wrong offset of clks in stm32f4_rcc_register_pll, should be PLL_SAI

Re: [PATCH] serial: lantiq: Add x86 in Kconfig dependencies for Lantiq serial driver

2020-05-05 Thread Greg KH
On Wed, May 06, 2020 at 12:49:57PM +0800, Tanwar, Rahul wrote: > > On 5/5/2020 10:25 pm, Greg KH wrote: > > On Mon, May 04, 2020 at 04:03:52PM +0800, Rahul Tanwar wrote: > >> Lantiq serial driver/IP is reused for a x86 based SoC as well. > >> Update the Kconfig accordingly. > >> > >> Signed-off-by

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-05 Thread Bartosz Golaszewski
wt., 5 maj 2020 o 19:31 Jakub Kicinski napisał(a): > > On Tue, 5 May 2020 16:02:25 +0200 Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Provide devm_register_netdev() - a device resource managed variant > > of register_netdev(). This new helper will only work for net_device > >

Re: [PATCH v6] MIPS: Loongson: Add DMA support for LS7A

2020-05-05 Thread Tiezhu Yang
On 04/30/2020 02:19 PM, Huacai Chen wrote: Hi Christoph, On Thu, Apr 30, 2020 at 10:31 AM Tiezhu Yang wrote: In the current market, the most used bridge chip on the Loongson platform are RS780E and LS7A, the RS780E bridge chip is already supported by the mainline kernel. In order to use the

Re: [PATCH] ALSA: hda: Return true,false for return type bool

2020-05-05 Thread Takashi Iwai
On Wed, 06 May 2020 08:17:16 +0200, Jason Yan wrote: > > Fix the following coccicheck warning: > > include/sound/hdaudio.h:210:73-74: WARNING: return of 0/1 in function > 'snd_hdac_is_in_pm' with return type bool > include/sound/hdaudio.h:211:76-77: WARNING: return of 0/1 in function > 'snd_hdac_

[PATCH 3/4] drm/panel: Add Ilitek ILI9341 driver

2020-05-05 Thread dillon . minfei
From: dillon min This adds support for the Ilitek ILI9341 QVGA (240x320) TFT panel driver. This panel driver supports parallel RGB input. The controller is combined with a physical panel and configured through the device tree. Signed-off-by: dillon min --- drivers/gpu/drm/panel/Kconfig

[PATCH] lib/flex_proportions.c: aging counts when fraction smaller than max_frac/FPROP_FRAC_BASE

2020-05-05 Thread Tan Hu
If the given type has fraction smaller than max_frac/FPROP_FRAC_BASE, __fprop_inc_percpu_max should follow the design formula and aging fraction too. Signed-off-by: Tan Hu --- lib/flex_proportions.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/flex_proportions.c

[PATCH 3/4] drm/panel: Add Ilitek ILI9341 driver

2020-05-05 Thread dillon . minfei
Add drm panel driver ilitek ili9341 , based on panel/panel-ilitek-ili9322.c currently just support rgb input only

Re: [PATCH V3 10/16] arm64/cpufeature: Add remaining feature bits in ID_AA64PFR0 register

2020-05-05 Thread Anshuman Khandual
On 05/05/2020 10:29 AM, Suzuki K Poulose wrote: > On 05/02/2020 02:33 PM, Anshuman Khandual wrote: >> Enable MPAM and SEL2 features bits in ID_AA64PFR0 register as per ARM DDI >> 0487F.a specification. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Mark Rutland >> Cc: Suzuki K Poulose >

Re: [PATCH V3 11/16] arm64/cpufeature: Add remaining feature bits in ID_AA64PFR1 register

2020-05-05 Thread Anshuman Khandual
On 05/05/2020 02:54 PM, Suzuki K Poulose wrote: > On 05/02/2020 02:34 PM, Anshuman Khandual wrote: >> Enable the following features bits in ID_AA64PFR1 register as per ARM DDI >> 0487F.a specification. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Mark Rutland >> Cc: Suzuki K Poulose >

[PATCH 2/2] sctp: implement memory accounting on rx path

2020-05-05 Thread ashwin-h
From: Xin Long commit 9dde27de3e5efa0d032f3c891a0ca833a0d31911 upstream. sk_forward_alloc's updating is also done on rx path, but to be consistent we change to use sk_mem_charge() in sctp_skb_set_owner_r(). In sctp_eat_data(), it's not enough to check sctp_memory_pressure only, which doesn't wo

[PATCH 2/4] dt-bindings: display: Add ilitek-9341 binding

2020-05-05 Thread dillon . minfei
Add document for ilitek 9341 binding to stm32f429-disco board some hardware resource can be found here, https://www.st.com/zh/evaluation-tools/32f429idiscovery.html

Re: remove set_fs calls from the coredump code v6

2020-05-05 Thread Christoph Hellwig
On Tue, May 05, 2020 at 03:28:50PM -0500, Eric W. Biederman wrote: > We probably can. After introducing a kernel_compat_siginfo that is > the size that userspace actually would need. > > It isn't something I want to mess with until this code gets merged, as I > think the set_fs cleanups are more

[PATCH 2/4] dt-bindings: display: Add ilitek-9341 binding

2020-05-05 Thread dillon . minfei
From: dillon min add ili9341 for stm32f429-disco board some hardware resources can be found here https://www.st.com/zh/evaluation-tools/32f429idiscovery.html Signed-off-by: dillon min --- .../bindings/display/panel/ilitek,ili9341.yaml | 55 ++ 1 file changed, 55 inserti

[PATCH 0/2] Backport to 4.19 - sctp: fully support memory accounting

2020-05-05 Thread ashwin-h
Backport below upstream commits to 4.19 to address CVE-2019-3874. 1033990ac5b2ab6cee93734cb6d301aa3a35bcaa sctp: implement memory accounting on tx path 9dde27de3e5efa0d032f3c891a0ca833a0d31911 sctp: implement memory accounting on rx path Xin Long (2): sctp: implement memory accounting on tx pat

[PATCH 1/2] sctp: implement memory accounting on tx path

2020-05-05 Thread ashwin-h
From: Xin Long commit 1033990ac5b2ab6cee93734cb6d301aa3a35bcaa upstream. Now when sending packets, sk_mem_charge() and sk_mem_uncharge() have been used to set sk_forward_alloc. We just need to call sk_wmem_schedule() to check if the allocated should be raised, and call sk_mem_reclaim() to check

Re: [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg

2020-05-05 Thread 'Greg Kroah-Hartman'
On Wed, May 06, 2020 at 08:30:46AM +0900, Hyunki Koo wrote: > On Tuesday, May 5, 2020 at 2020 11:23:00 PM +0900, Greg Kroah-Hartman wrote: > > On Mon, Apr 20, 2020 at 10:32:56AM +0900, Hyunki Koo wrote: > > > This patch change the name of macro for general usage. > > > > > > Signed-off-by: Hyunki K

Re: [RFC, WIP, v4 08/11] media: vidtv: implement a PSI generator

2020-05-05 Thread Daniel W. S. Almeida
Hi Mauro, >> +static u32 >> +vidtv_psi_ts_psi_write_into(struct psi_write_args args) >> +{ >> +/* >> + * Packetize PSI sections into TS packets: >> + * push a TS header (4bytes) every 184 bytes >> + * manage the continuity_counter >> + * add stuffing after the CRC >> + */

[PATCH 1/4] ARM: dts: stm32: Add drm panel ili9341 support for stm32f429-disco board

2020-05-05 Thread dillon . minfei
From: dillon min 1, add stm32f429-disco ltdc pins mux config 2, add ltdc nodes pinned with ili9341 3, add spi5 node Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 67 ++ arch/arm/boot/dts/stm32f429-disco.dts | 40 2

[PATCH] ipc/util.c: sysvipc_find_ipc() incorrectly updates position index

2020-05-05 Thread Vasily Averin
new_pos should jump through hole of unused ids, pos can be updated inside "for" cycle. Cc: sta...@vger.kernel.org Fixes: 89163f93c6f9 ("ipc/util.c: sysvipc_find_ipc() should increase position index") Signed-off-by: Vasily Averin --- ipc/util.c | 12 ++-- 1 file changed, 6 insertions(+),

Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

2020-05-05 Thread SeongJae Park
On Tue, 05 May 2020 12:00:49 -0700 (PDT) David Miller wrote: > From: David Miller > Date: Tue, 05 May 2020 11:48:25 -0700 (PDT) > > > Series applied and queued up for -stable, thanks. > > Nevermind, this doesn't even compile. > > net/smc/af_smc.c: In function ‘smc_switch_to_fallback’: > net/

[PATCH 10/15] maccess: unify the probe kernel arch hooks

2020-05-05 Thread Christoph Hellwig
Currently architectures have to override every routine that probes kernel memory, which includes a pure read and strcpy, both in strict and not strict variants. Just provide a single arch hooks instead to make sure all architectures cover all the cases. Signed-off-by: Christoph Hellwig --- arch

Re: [PATCH] ath11k: Replace zero-length array with flexible-array

2020-05-05 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: > > struct foo { > int

[PATCH 15/15] x86: use non-set_fs based maccess routines

2020-05-05 Thread Christoph Hellwig
Provide arch_kernel_read and arch_kernel_write routines to implement the maccess routines without messing with set_fs and without stac/clac that opens up access to user space. Signed-off-by: Christoph Hellwig --- arch/x86/include/asm/uaccess.h | 16 1 file changed, 16 insertions

[PATCH 11/15] maccess: remove strncpy_from_unsafe

2020-05-05 Thread Christoph Hellwig
All three callers really should try the explicit kernel and user copies instead. One has already deprecated the somewhat dangerous either kernel or user address concept, the other two still need to follow up eventually. Signed-off-by: Christoph Hellwig --- include/linux/uaccess.h | 1 - ke

Re: [PATCH 0/3] kasan: memorize and print call_rcu stack

2020-05-05 Thread Walter Wu
On Wed, 2020-05-06 at 01:53 -0400, Qian Cai wrote: > > > On May 6, 2020, at 1:19 AM, Walter Wu wrote: > > > > This patchset improves KASAN reports by making them to have > > call_rcu() call stack information. It is helpful for programmers > > to solve use-after-free or double-free memory issue.

[PATCH 08/15] maccess: rename strnlen_unsafe_user to strnlen_user_unsafe

2020-05-05 Thread Christoph Hellwig
This matches the convention of always having _unsafe as a suffix, as well as match the naming of strncpy_from_user_unsafe. Signed-off-by: Christoph Hellwig --- include/linux/uaccess.h | 2 +- kernel/trace/trace_kprobe.c | 2 +- mm/maccess.c| 4 ++-- 3 files changed, 4 inserti

[PATCH 02/15] maccess: remove various unused weak aliases

2020-05-05 Thread Christoph Hellwig
maccess tends to define lots of underscore prefixed symbols that then have other weak aliases. But except for two cases they are never actually used, so remove them. Signed-off-by: Christoph Hellwig --- include/linux/uaccess.h | 3 --- mm/maccess.c| 19 +++ 2 files

[PATCH 04/15] maccess: clarify kerneldoc comments

2020-05-05 Thread Christoph Hellwig
Add proper kerneldoc comments for probe_kernel_read_strict and probe_kernel_read strncpy_from_unsafe_strict and explain the different versus the non-strict version. Signed-off-by: Christoph Hellwig --- mm/maccess.c | 61 1 file changed, 43 ins

[PATCH 03/15] maccess: remove duplicate kerneldoc commens

2020-05-05 Thread Christoph Hellwig
Many of the maccess routines have a copy of the kerneldoc comment in the header. Remove it as it is not useful and will get out of sync sooner or later. Signed-off-by: Christoph Hellwig --- include/linux/uaccess.h | 38 -- 1 file changed, 38 deletions(-) dif

[PATCH 06/15] maccess: rename strncpy_from_unsafe_user to strncpy_from_user_unsafe

2020-05-05 Thread Christoph Hellwig
This matches the convention of always having _unsafe as a suffix, as well as match the naming of strncpy_from_user. Signed-off-by: Christoph Hellwig --- include/linux/uaccess.h | 2 +- kernel/trace/bpf_trace.c| 2 +- kernel/trace/trace_kprobe.c | 2 +- mm/maccess.c| 4 ++-

[PATCH 07/15] maccess: rename strncpy_from_unsafe_strict to strncpy_from_kernel_unsafe

2020-05-05 Thread Christoph Hellwig
This matches the convention of always having _unsafe as a suffix, as well as match the naming of strncpy_from_user_unsafe. Signed-off-by: Christoph Hellwig --- arch/x86/mm/maccess.c| 2 +- include/linux/uaccess.h | 2 +- kernel/trace/bpf_trace.c | 2 +- mm/maccess.c | 6 +++---

[PATCH 05/15] maccess: update the top of file comment

2020-05-05 Thread Christoph Hellwig
This file now also contains several helpers for accessing user memory. Signed-off-by: Christoph Hellwig --- mm/maccess.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/maccess.c b/mm/maccess.c index 747581ac50dc9..65880ba2ca376 100644 --- a/mm/maccess.c +++ b/mm/maccess.c

clean up and streamline probe_kernel_* and friends

2020-05-05 Thread Christoph Hellwig
Hi all, this series start cleaning up the safe kernel and user memory probing helpers in mm/maccess.c, and then allows architectures to implement the kernel probing without overriding the address space limit and temporarily allowing access to user memory. It then switches x86 over to this new mec

[PATCH 01/15] maccess: unexport probe_kernel_write and probe_user_write

2020-05-05 Thread Christoph Hellwig
These two functions are not used by any modular code. Signed-off-by: Christoph Hellwig --- mm/maccess.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/maccess.c b/mm/maccess.c index 3ca8d97e50106..cf21e604f78cb 100644 --- a/mm/maccess.c +++ b/mm/maccess.c @@ -121,7 +121,6 @@ long __prob

[PATCH 09/15] maccess: remove probe_read_common and probe_write_common

2020-05-05 Thread Christoph Hellwig
Each of the helpers has just two callers, which also different in dealing with kernel or userspace pointers. Just open code the logic in the callers. Signed-off-by: Christoph Hellwig --- mm/maccess.c | 63 1 file changed, 29 insertions(+), 34

[PATCH 14/15] maccess: allow architectures to provide kernel probing directly

2020-05-05 Thread Christoph Hellwig
Provide alternative versions of probe_kernel_read, probe_kernel_write and strncpy_from_kernel_unsafe that don't need set_fs magic, but instead use arch hooks that are modelled after unsafe_{get,put}_user to access kernel memory in an exception safe way. Signed-off-by: Christoph Hellwig --- mm/ma

[PATCH 12/15] maccess: always use strict semantics for probe_kernel_read

2020-05-05 Thread Christoph Hellwig
Except for historical confusion in the kprobes/uprobes and bpf tracers there is no good reason to ever allow user memory accesses from probe_kernel_read. Make the tracers fall back to a probe_user_read if the probe_kernel_read falls to keep the core API clean. Signed-off-by: Christoph Hellwig --

[PATCH 13/15] maccess: move user access routines together

2020-05-05 Thread Christoph Hellwig
Move kernel access vs user access routines together to ease upcoming ifdefs. Signed-off-by: Christoph Hellwig --- mm/maccess.c | 110 +-- 1 file changed, 55 insertions(+), 55 deletions(-) diff --git a/mm/maccess.c b/mm/maccess.c index 811f49e8de11

Re: [PATCH] powerpc/5200: update contact email

2020-05-05 Thread Michael Ellerman
Wolfram Sang writes: >> > My 'pengutronix' address is defunct for years. Merge the entries and use >> > the proper contact address. >> >> Is there any point adding the new address? It's just likely to bit-rot >> one day too. > > At least, this one is a group address, not an individual one, so les

Re: [PATCH V4] f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-05-05 Thread Chao Yu
On 2020/4/30 18:58, Sayali Lokhande wrote: > There could be a scenario where f2fs_sync_node_pages gets > called during checkpoint, which in turn tries to flush > inline data and calls iput(). This results in deadlock as > iput() tries to hold cp_rwsem, which is already held at the > beginning by ch

[PATCH -next] net: ethernet: mediatek: Make mtk_m32 static

2020-05-05 Thread Samuel Zou
Fix the following sparse warning: drivers/net/ethernet/mediatek/mtk_eth_soc.c:68:5: warning: symbol 'mtk_m32' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH] ath6kl: Replace zero-length array with flexible-array

2020-05-05 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: > > struct foo { > int

Re: [PATCH v6 2/2] watchdog: Add new arm_smc_wdt watchdog driver

2020-05-05 Thread Xingyu Chen
Tested on the Meson-A1. Tested-by: Xingyu Chen On 2020/5/5 11:13, Evan Benn wrote: From: Julius Werner This patch adds a watchdog driver that can be used on ARM systems with the appropriate watchdog implemented in Secure Monitor firmware. The driver communicates with firmware via a Secure Mon

[PATCH] dma-buf: heaps: Remove Unneeded variable "ret" in dma_heap_dma_buf_begin_cpu_access()

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/dma-buf/heaps/heap-helpers.c:203:5-8: Unneeded variable: "ret". Return "0" on line 216 Signed-off-by: Jason Yan --- drivers/dma-buf/heaps/heap-helpers.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma-buf/heaps/heap

[PATCH] spi: a3700: make a3700_spi_init() return void

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/spi/spi-armada-3700.c:283:8-11: Unneeded variable: "ret". Return "0" on line 315 Signed-off-by: Jason Yan --- drivers/spi/spi-armada-3700.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-armada-3700.c

[PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata()

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 Signed-off-by: Jason Yan --- arch/arm/mach-omap2/dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-o

[PATCH net-next] i40e: Make i40e_shutdown_adminq() return void

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/ethernet/intel/i40e/i40e_adminq.c:699:13-21: Unneeded variable: "ret_code". Return "0" on line 710 Signed-off-by: Jason Yan --- drivers/net/ethernet/intel/i40e/i40e_adminq.c| 6 +- drivers/net/ethernet/intel/i40e/i40e_prototype.h | 2 +-

[PATCH] video: fbdev: pxa168fb: make pxa168fb_init_mode() return void

2020-05-05 Thread Jason Yan
No other functions use the return value of pxa168fb_init_mode() and the return value is always 0 now. Make it return void. This fixes the following coccicheck warning: drivers/video/fbdev/pxa168fb.c:565:5-8: Unneeded variable: "ret". Return "0" on line 597 Signed-off-by: Jason Yan --- drivers/v

[PATCH] scsi: qla2xxx: make qlafx00_process_aen() return void

2020-05-05 Thread Jason Yan
No other functions use the return value of qlafx00_process_aen() and the return value is always 0 now. Make it return void. This fixes the following coccicheck warning: drivers/scsi/qla2xxx/qla_mr.c:1716:5-9: Unneeded variable: "rval". Return "0" on line 1768 Signed-off-by: Jason Yan --- driver

[PATCH] tty: mxser: make mxser_change_speed() return void

2020-05-05 Thread Jason Yan
No other functions use the return value of mxser_change_speed() and the return value is always 0 now. Make it return void. This fixes the following coccicheck warning: drivers/tty/mxser.c:645:5-8: Unneeded variable: "ret". Return "0" on line 650 Signed-off-by: Jason Yan --- drivers/tty/mxser.c

[PATCH] ALSA: hda: Return true,false for return type bool

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: include/sound/hdaudio.h:210:73-74: WARNING: return of 0/1 in function 'snd_hdac_is_in_pm' with return type bool include/sound/hdaudio.h:211:76-77: WARNING: return of 0/1 in function 'snd_hdac_is_power_on' with return type bool Signed-off-by: Jason Yan --- i

[PATCH] regulator: db8500-prcmu: Use true,false for bool variable

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/regulator/db8500-prcmu.c:184:1-17: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/regulator/db8500-prcmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/db8500-prcmu.c b/drive

[PATCH] sparc: mm: return true,false in kern_addr_valid()

2020-05-05 Thread Jason Yan
This function's return type is bool and returns both true/false and 0/1. This fixes the following coccicheck warning: arch/sparc/mm/init_64.c:1652:9-10: WARNING: return of 0/1 in function 'kern_addr_valid' with return type bool Signed-off-by: Jason Yan --- arch/sparc/mm/init_64.c | 10 +

[PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_get_rxfh()

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1238:5-8: Unneeded variable: "err". Return "0" on line 1252 Signed-off-by: Jason Yan --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dr

[PATCH net-next] net: bridge: return false in br_mrp_enabled()

2020-05-05 Thread Jason Yan
Fix the following coccicheck warning: net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function 'br_mrp_enabled' with return type bool Signed-off-by: Jason Yan --- net/bridge/br_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_private.h b/ne

[PATCH net-next 2/2] virtio-net: fix the XDP truesize calculation for mergeable buffers

2020-05-05 Thread Jason Wang
We should not exclude headroom and tailroom when XDP is set. So this patch fixes this by initializing the truesize from PAGE_SIZE when XDP is set. Cc: Jesper Dangaard Brouer Signed-off-by: Jason Wang --- drivers/net/virtio_net.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH net-next 1/2] virtio-net: don't reserve space for vnet header for XDP

2020-05-05 Thread Jason Wang
We tried to reserve space for vnet header before xdp.data_hard_start. But this is useless since the packet could be modified by XDP which may invalidate the information stored in the header and there's no way for XDP to know the existence of the vnet header currently. So let's just not reserve spa

Re: [PATCH v3] PCI/ASPM: Enable ASPM for bridge-to-bridge link

2020-05-05 Thread Mika Westerberg
On Wed, May 06, 2020 at 01:34:21AM +0800, Kai-Heng Feng wrote: > The TI PCIe-to-PCI bridge prevents the Intel SoC from entering power > state deeper than PC3 due to disabled ASPM, consumes lots of unnecessary > power. On Windows ASPM L1 is enabled on the device and its upstream > bridge, so it can

Re: [PATCH V2 10/11] arch/kmap: Define kmap_atomic_prot() for all arch's

2020-05-05 Thread Christoph Hellwig
On Sun, May 03, 2020 at 06:09:11PM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > To support kmap_atomic_prot(), all architectures need to support > protections passed to their kmap_atomic_high() function. Pass > protections into kmap_atomic_high() and change the name to > kmap_atomic_h

Re: [v3] nfp: abm: Fix incomplete release of system resources in nfp_abm_vnic_set_mac()

2020-05-05 Thread Markus Elfring
> I'm curious if I could still modify these commit message information for the > v1 patch, > which has already been applied and queued up? The maintainer found the provided information good enough. Thus he committed the software correction with the subject “nfp: abm: fix a memory leak bug” on 202

[PATCH V2 3/3] mm/hugetlb: Define a generic fallback for arch_clear_hugepage_flags()

2020-05-05 Thread Anshuman Khandual
There are multiple similar definitions for arch_clear_hugepage_flags() on various platforms. Lets just add it's generic fallback definition for platforms that do not override. This help reduce code duplication. Cc: Russell King Cc: Catalin Marinas Cc: Will Deacon Cc: Tony Luck Cc: Fenghua Yu

Re: [PATCH V2 08/11] arch/kmap: Ensure kmap_prot visibility

2020-05-05 Thread Christoph Hellwig
On Sun, May 03, 2020 at 06:09:09PM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > We want to support kmap_atomic_prot() on all architectures and it makes > sense to define kmap_atomic() to use the default kmap_prot. > > So we ensure all arch's have a globally available kmap_prot either

[PATCH V2 1/3] arm64/mm: Drop __HAVE_ARCH_HUGE_PTEP_GET

2020-05-05 Thread Anshuman Khandual
Platform specific huge_ptep_get() is required only when fetching the huge PTE involves more than just dereferencing the page table pointer. This is not the case on arm64 platform. Hence huge_ptep_pte() can be dropped along with it's __HAVE_ARCH_HUGE_PTEP_GET subscription. Cc: Catalin Marinas Cc:

[PATCH V2 2/3] mm/hugetlb: Define a generic fallback for is_hugepage_only_range()

2020-05-05 Thread Anshuman Khandual
There are multiple similar definitions for is_hugepage_only_range() on various platforms. Lets just add it's generic fallback definition for platforms that do not override. This help reduce code duplication. Cc: Russell King Cc: Catalin Marinas Cc: Will Deacon Cc: Tony Luck Cc: Fenghua Yu Cc:

[PATCH V2 0/3] mm/hugetlb: Add some new generic fallbacks

2020-05-05 Thread Anshuman Khandual
This series adds the following new generic fallbacks. Before that it drops __HAVE_ARCH_HUGE_PTEP_GET from arm64 platform. 1. is_hugepage_only_range() 2. arch_clear_hugepage_flags() This has been boot tested on arm64 and x86 platforms but built tested on some more platforms including the changed o

Re: [PATCH V2 07/11] arch/kunmap_atomic: Consolidate duplicate code

2020-05-05 Thread Christoph Hellwig
On Sun, May 03, 2020 at 06:09:08PM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > Every single architecture (including !CONFIG_HIGHMEM) calls... > > pagefault_enable(); > preempt_enable(); > > ... before returning from __kunmap_atomic(). Lift this code into the > kunmap_at

Re: [PATCH V2 06/11] arch/kmap_atomic: Consolidate duplicate code

2020-05-05 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH V2 05/11] {x86,powerpc,microblaze}/kmap: Move preempt disable

2020-05-05 Thread Christoph Hellwig
On Sun, May 03, 2020 at 06:09:06PM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > During this kmap() conversion series we must maintain bisect-ability. > To do this, kmap_atomic_prot() in x86, powerpc, and microblaze need to > remain functional. > > Create a temporary inline version of

Re: [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl

2020-05-05 Thread Christoph Hellwig
Thanks, this looks very nice! Reviewed-by: Christoph Hellwig Are you also going to submit a patch to util-linux to use the new ioctl?

Re: [PATCH v7 2/5] PCI: Add Loongson PCI Controller support

2020-05-05 Thread Jiaxun Yang
On Mon, 4 May 2020 18:43:29 -0500 Bjorn Helgaas wrote: > On Tue, Apr 28, 2020 at 09:14:17AM +0800, Jiaxun Yang wrote: > > This controller can be found on Loongson-2K SoC, Loongson-3 > > systems with RS780E/LS7A PCH. > > > > The RS780E part of code was previously located at > > arch/mips/pci/ops-

Re: [PATCH v4 09/10] loop: Clean up LOOP_SET_STATUS lo_flags handling.

2020-05-05 Thread Christoph Hellwig
On Wed, Apr 29, 2020 at 04:03:40PM +0200, Martijn Coenen wrote: > LOOP_SET_STATUS(64) will actually allow some lo_flags to be modified; in > particular, LO_FLAGS_AUTOCLEAR can be set and cleared, whereas > LO_FLAGS_PARTSCAN can be set to request a partition scan. Make this > explicit by updating th

Re: [PATCH v4 08/10] loop: Rework lo_ioctl() __user argument casting

2020-05-05 Thread Christoph Hellwig
On Wed, Apr 29, 2020 at 04:03:39PM +0200, Martijn Coenen wrote: > In preparation for a new ioctl that needs to copy_from_user(); makes the > code easier to read as well. > > Signed-off-by: Martijn Coenen Looks good, Reviewed-by: Christoph Hellwig Btw, it seems like you have dropped all the re

Re: [PATCH v4 07/10] loop: Move loop_set_status_from_info() and friends up

2020-05-05 Thread Christoph Hellwig
On Wed, Apr 29, 2020 at 04:03:38PM +0200, Martijn Coenen wrote: > So we can use it without forward declaration. This is a separate commit > to make it easier to verify that this is just a move, without functional > modifications. > > Signed-off-by: Martijn Coenen Looks good, Reviewed-by: Christ

Re: [PATCH v4 06/10] loop: Factor out configuring loop from status

2020-05-05 Thread Christoph Hellwig
On Wed, Apr 29, 2020 at 04:03:37PM +0200, Martijn Coenen wrote: > Factor out this code into a separate function, so it can be reused by > other code more easily. > > Signed-off-by: Martijn Coenen Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v4 05/10] loop: Remove figure_loop_size()

2020-05-05 Thread Christoph Hellwig
On Wed, Apr 29, 2020 at 04:03:36PM +0200, Martijn Coenen wrote: > This function was now only used by loop_set_capacity(). Just open code > the remaining code in the caller instead. > > Signed-off-by: Martijn Coenen Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v4 04/10] loop: Refactor loop_set_status() size calculation

2020-05-05 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

[PATCH v13 2/5] usb: renesas-xhci: Add the renesas xhci driver

2020-05-05 Thread Vinod Koul
From: Christian Lamparter This add a new driver for renesas xhci which is basically a firmware loader for uPD720201 and uPD720202 w/o ROM. The xhci-pci driver will invoke this driver for loading/unloading on relevant devices. This patch adds a firmware loader for the uPD720201K8-711-BAC-A and uP

  1   2   3   4   5   6   7   8   9   10   >