[PATCH] net: mscc: ocelot: add missing of_node_put after calling of_get_child_by_name

2019-09-28 Thread Wen Yang
of_node_put needs to be called when the device node which is got from of_get_child_by_name finished using. In both cases of success and failure, we need to release 'ports', so clean up the code using goto. fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") Signed-off-by: Wen Yang

linux-kernel@vger.kernel.org

2019-09-28 Thread Peter Chen
On Sat, Sep 28, 2019 at 1:11 AM Alan Stern wrote: > > On Tue, 24 Sep 2019, Ran Wang wrote: > > > Hi Greg, > > > > On Monday, September 23, 2019 19:07, Greg Kroah-Hartman wrote: > > > > > > On Mon, Sep 23, 2019 at 06:51:02PM +0800, Ran Wang wrote: > > > > USB 2.0 Embedded Host PET Automated Test (C

linux-kernel@vger.kernel.org

2019-09-28 Thread Peter Chen
> > > > > > In fact, the system should respond the same way to any unrecognized > > > device that doesn't support HNP, right? There's nothing special about > > > these VID/PID values. > > > > Yes, but I saw there are already some implementation in upstream kernel for > > this > > purpose, just PI

[PATCH v3 1/3] arm64: dts: meson: add reset controller for Meson-A1 SoC

2019-09-28 Thread Xingyu Chen
Add the reset controller device of Meson-A1 SoC family Signed-off-by: Xingyu Chen --- arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi index 7210ad0..1c588ab

[PATCH v3 2/3] dt-bindings: reset: add bindings for the Meson-A1 SoC Reset Controller

2019-09-28 Thread Xingyu Chen
Add DT bindings for the Meson-A1 SoC Reset Controller include file, and also slightly update documentation. Signed-off-by: Xingyu Chen --- .../bindings/reset/amlogic,meson-reset.yaml| 1 + include/dt-bindings/reset/amlogic,meson-a1-reset.h | 74 ++ 2 files changed, 7

[PATCH v3 0/3] reset: meson: add Meson-A1 SoC support

2019-09-28 Thread Xingyu Chen
This patchset adds support for Meson-A1 SoC Reset Controller. A new struct meson_reset_param is introduced to describe the register differences between Meson-A1 and previous SoCs. Changes since v2 at [1]: - add comments in header file to indicate holes - reorder the Signed-off-by and Reviewed-by -

[PATCH v3 3/3] reset: add support for the Meson-A1 SoC Reset Controller

2019-09-28 Thread Xingyu Chen
The number of RESET registers and offset of RESET_LEVEL register for Meson-A1 are different from previous SoCs, In order to describe these differences, we introduce the struct meson_reset_param. Reviewed-by: Kevin Hilman Reviewed-by: Neil Armstrong Signed-off-by: Xingyu Chen --- drivers/reset/

Re: [PATCH 2/2] clk: meson: a1: add support for Amlogic A1 clock driver

2019-09-28 Thread Jian Hu
On 2019/9/27 20:56, Jerome Brunet wrote: On Fri 27 Sep 2019 at 05:11, Jian Hu wrote: Hi, Stephen Thank you for review On 2019/9/25 21:12, Stephen Boyd wrote: Quoting Jian Hu (2019-09-25 04:44:48) The Amlogic A1 clock includes three parts: peripheral clocks, pll clocks, CPU clocks. sys p

[PATCH] arm64: armv8_deprecated: Checking return value for memory allocation

2019-09-28 Thread Yunfeng Ye
There are no return value checking when using kzalloc() and kcalloc() for memory allocation. so add it. Signed-off-by: Yunfeng Ye --- arch/arm64/kernel/armv8_deprecated.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_depr

Re: [GIT PULL] More Kbuild updates for v5.4-rc1

2019-09-28 Thread Masahiro Yamada
Hi Linus, On Sun, Sep 29, 2019 at 11:57 AM Linus Torvalds wrote: > > On Sat, Sep 28, 2019 at 11:41 AM Masahiro Yamada > wrote: > > > > Please pull some more updates for v5.4-rc1 > > I pulled this, but I'm not sure if I'm going to keep it. > > There's thousands of lines of changes because of the

[PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box

2019-09-28 Thread Vivek Unune
Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3 Signed-off-by: Vivek Unune --- arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts b/arch/arm64/boot/dts/rockchip/

GREETINGS MY DEAR,

2019-09-28 Thread Mrs A Gaddafi
Dear Friend, I came across your e-mail contact prior a private search whilst in need of your partnership for investment assistance in your country. I am opportune to use this medium to exhibit my legal intentions towards investing to your country under your management. I am fully convinced that yo

linux-kernel@vger.kernel.org

2019-09-28 Thread Ran Wang
Hi Alan, On Sunday, September 29, 2019 10:35, wrote: > > Hi Alan, > > On Saturday, September 28, 2019 01:08, Alan Stern wrote: > > > > In fact, the system should respond the same way to any unrecognized > > device that doesn't support HNP, right? There's nothing special about > > these VID/PID

Re: [GIT PULL] More Kbuild updates for v5.4-rc1

2019-09-28 Thread Linus Torvalds
On Sat, Sep 28, 2019 at 11:41 AM Masahiro Yamada wrote: > > Please pull some more updates for v5.4-rc1 I pulled this, but I'm not sure if I'm going to keep it. There's thousands of lines of changes because of the header-test-y thing, and I'm honestly considering just getting rid of that thing en

linux-kernel@vger.kernel.org

2019-09-28 Thread Ran Wang
Hi Alan, On Saturday, September 28, 2019 01:08, Alan Stern wrote: > > On Tue, 24 Sep 2019, Ran Wang wrote: > > > Hi Greg, > > > > On Monday, September 23, 2019 19:07, Greg Kroah-Hartman wrote: > > > > > > On Mon, Sep 23, 2019 at 06:51:02PM +0800, Ran Wang wrote: > > > > USB 2.0 Embedded Host PET

Re: [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle()

2019-09-28 Thread Baolin Wang
Hi Stephen, On Sat, 28 Sep 2019 at 02:45, Stephen Boyd wrote: > > Quoting Baolin Wang (2019-09-26 20:50:53) > > The syscon_regmap_lookup_by_phandle() will never return NULL, thus use > > IS_ERR() to validate the return value instead of IS_ERR_OR_NULL(). > > > > Signed-off-by: Baolin Wang > > ---

[GIT PULL] libnvdimm fixes for v5.4-rc1

2019-09-28 Thread Dan Williams
Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm tags/libnvdimm-fixes-5.4-rc1 ...to receive the completion of the work to fixup libnvdimm operation on powerpc as well as a collection of typical -rc class fixes. This powerpc work missed the initial libnvdim

Re: [PATCH 7/7] nsdeps: make generated patches independent of locale

2019-09-28 Thread Masahiro Yamada
On Sun, Sep 29, 2019 at 10:18 AM Masahiro Yamada wrote: > > On Sat, Sep 28, 2019 at 3:14 AM Greg Kroah-Hartman > wrote: > > > > On Sat, Sep 28, 2019 at 12:42:28AM +0900, Masahiro Yamada wrote: > > > On Fri, Sep 27, 2019 at 10:27 PM Matthias Maennich > > > wrote: > > > > > > > > On Fri, Sep 27,

Re: [PATCH 7/7] nsdeps: make generated patches independent of locale

2019-09-28 Thread Masahiro Yamada
On Sat, Sep 28, 2019 at 3:14 AM Greg Kroah-Hartman wrote: > > On Sat, Sep 28, 2019 at 12:42:28AM +0900, Masahiro Yamada wrote: > > On Fri, Sep 27, 2019 at 10:27 PM Matthias Maennich > > wrote: > > > > > > On Fri, Sep 27, 2019 at 06:36:03PM +0900, Masahiro Yamada wrote: > > > >scripts/nsdeps auto

[PATCH v2] PCI: mobiveil: Fix csr_read/write build issue

2019-09-28 Thread Kefeng Wang
The riscv has csr_read/write macro, see arch/riscv/include/asm/csr.h, the same function naming will cause build error, using such generic names in a driver is bad, rename csr_[read,write][l,] to mobiveil_csr_read/write to fix it. drivers/pci/controller/pcie-mobiveil.c:238:69: error: macro "csr_rea

RE: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-28 Thread Anson Huang
Hi, Leonard/Marco I think we should get aligned first, my original thought is to let SCU API caller NOT aware of those special APIs, so have to do the special handling in imx_scu_call_rpc(). And the short loop check has to be used which would impact the performance a little bit I think.

Re: WARNING: locking bug in selinux_netlbl_socket_connect

2019-09-28 Thread Paul Moore
On Fri, Sep 27, 2019 at 10:45 PM Eric Biggers wrote: > On Tue, Sep 24, 2019 at 09:17:35AM -0400, Paul Moore wrote: > > On Tue, Sep 24, 2019 at 4:21 AM Dmitry Vyukov wrote: > > > On Tue, Sep 24, 2019 at 4:14 AM Paul Moore wrote: > > > > On Sat, Sep 21, 2019 at 11:50 AM syzbot > > > > wrote: > >

[PATCH v2] KVM: Don't shrink/grow vCPU halt_poll_ns if host side polling is disabled

2019-09-28 Thread Wanpeng Li
From: Wanpeng Li Don't waste cycles to shrink/grow vCPU halt_poll_ns if host side polling is disabled. Acked-by: Marcelo Tosatti Cc: Marcelo Tosatti Signed-off-by: Wanpeng Li --- v1 -> v2: * fix coding style virt/kvm/kvm_main.c | 29 - 1 file changed, 16 inser

Re: [GIT] Networking

2019-09-28 Thread pr-tracker-bot
The pull request you sent on Sat, 28 Sep 2019 15:49:21 +0200 (CEST): > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/02dc96ef6c25f990452c114c59d75c368a1f4c8f Thank you! -- Deet-doot-dot,

Re: [PATCH] KVM: Don't shrink/grow vCPU halt_poll_ns if host side polling is disabled

2019-09-28 Thread Wanpeng Li
On Sat, 28 Sep 2019 at 01:24, Marcelo Tosatti wrote: > > On Fri, Sep 27, 2019 at 04:27:02PM +0800, Wanpeng Li wrote: > > From: Wanpeng Li > > > > Don't waste cycles to shrink/grow vCPU halt_poll_ns if host > > side polling is disabled. > > > > Cc: Marcelo Tosatti > > Signed-off-by: Wanpeng Li >

Re: [PATCH] KVM: Don't shrink/grow vCPU halt_poll_ns if host side polling is disabled

2019-09-28 Thread Wanpeng Li
On Fri, 27 Sep 2019 at 22:42, Sean Christopherson wrote: > > On Fri, Sep 27, 2019 at 04:27:02PM +0800, Wanpeng Li wrote: > > From: Wanpeng Li > > > > Don't waste cycles to shrink/grow vCPU halt_poll_ns if host > > side polling is disabled. > > > > Cc: Marcelo Tosatti > > Signed-off-by: Wanpeng L

[PATCH 2/3] Staging: exfat: exfat_super.c: fixed multiple coding style issues with camelcase and parentheses

2019-09-28 Thread Jesse Barton
Fixed coding style issues with camelcase on functions and various parentheses that were not needed Signed-off-by: Jesse Barton --- drivers/staging/exfat/exfat_super.c | 210 ++-- 1 file changed, 105 insertions(+), 105 deletions(-) diff --git a/drivers/staging/exfat/exfa

[PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.

2019-09-28 Thread Jesse Barton
Fixed Coding Style issues Signed-off-by: Jesse Barton --- drivers/staging/exfat/exfat_super.c | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c index 3c7e2b7c2195..b9656ec0

Re: [PATCH] namespace: fix namespace.pl script to support relative paths

2019-09-28 Thread Masahiro Yamada
On Sat, Sep 28, 2019 at 8:30 AM Keller, Jacob E wrote: > > > -Original Message- > > From: Randy Dunlap [mailto:rdun...@infradead.org] > > Sent: Friday, September 27, 2019 4:12 PM > > To: Keller, Jacob E > > Cc: intel-wired-...@lists.osuosl.org; linux-kernel@vger.kernel.org; > > linux-kbu

Re: [Patch 02/16] media: ti-vpe: vpe: Add missing null pointer checks

2019-09-28 Thread Austin Kim
2019년 9월 28일 (토) 오전 3:37, Benoit Parrot 님이 작성: > > A few NULL pointer checks were missing. > Add check with appropriate return code. > > Signed-off-by: Benoit Parrot > --- > drivers/media/platform/ti-vpe/vpe.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/

Re: x86/random: Speculation to the rescue

2019-09-28 Thread Linus Torvalds
On Sat, Sep 28, 2019 at 3:24 PM Thomas Gleixner wrote: > > Nicholas presented the idea to (ab)use speculative execution for random > number generation years ago at the Real-Time Linux Workshop: What you describe is just a particularly simple version of the jitter entropy. Not very reliable. But

[PATCH] Staging: exfat: exfat_super.c: fixed camelcase coding style issue

2019-09-28 Thread Jesse Barton
Fixed a coding style issue. Signed-off-by: Jesse Barton --- drivers/staging/exfat/exfat_super.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c index 5f6caee819a6..665eb25e318d 1

[GIT PULL] Thermal-SoC management changes for v5.4-rc1

2019-09-28 Thread Eduardo Valentin
Hello Linus, Please consider the following thermal soc changes for v5.4-rc1. This is a really small pull in the midst of a lot of pending patches. We are in the middle of restructuring how we are maintaining the thermal subsystem, as per discussion in our last LPC. For now, I am sending just some

Re: [RFC PATCH 05/27] containers: Open a socket inside a container

2019-09-28 Thread Alun Evans
On Fri 27 Sep '19 at 07:46 ebied...@xmission.com (Eric W. Biederman) wrote: > > Alun Evans writes: > >> Hi Eric, >> >> >> On Tue, 19 Feb 2019, Eric W. Biederman wrote: >>> >>> David Howells writes: >>> >>> > Provide a system call to open a socket inside of a container, using that >>> > conta

x86/random: Speculation to the rescue

2019-09-28 Thread Thomas Gleixner
Nicholas presented the idea to (ab)use speculative execution for random number generation years ago at the Real-Time Linux Workshop: https://static.lwn.net/images/conf/rtlws11/random-hardware.pdf The idea is to use the non-constant execution time of loops on speculative CPUs. The trick is to "

Re: [PATCH] mm, vmpressure: Fix a signedness bug in vmpressure_register_event()

2019-09-28 Thread Andrew Morton
On Sat, 28 Sep 2019 14:47:02 -0700 Matthew Wilcox wrote: > On Sat, Sep 28, 2019 at 02:23:56PM -0700, Andrew Morton wrote: > > How about doing it this way? Only copy the int to the enum once we > > know it's within range? > > This will return a positive integer on success instead of 0. We need:

Re: [PATCH] mm, vmpressure: Fix a signedness bug in vmpressure_register_event()

2019-09-28 Thread Matthew Wilcox
On Sat, Sep 28, 2019 at 02:23:56PM -0700, Andrew Morton wrote: > How about doing it this way? Only copy the int to the enum once we > know it's within range? This will return a positive integer on success instead of 0. We need: mutex_unlock(&vmpr->events_lock); + ret = 0; out: w

[GIT PULL] SMB3 Fixes

2019-09-28 Thread Steve French
Please update the following changes since commit 4d6bcba70aeb4a512ead9c9eaf9edc6bbab00b14: cifs: update internal module version number (2019-09-16 19:18:39 -0500) are available in the Git repository at: git://git.samba.org/sfrench/cifs-2.6.git tags/5.4-rc-smb3-fixes for you to fetch changes

Re: [PATCH] genirq: replace notify with old_notify in irq_set_affinity_notifier()

2019-09-28 Thread Steven Rostedt
On Sat, 28 Sep 2019 18:19:20 +0300 Ivan Safonov wrote: > This patch is for Linux 4.19 with a RT patch. > > The second 'if' block does not check notify for NULL, > this leads to a system crash. > > Most likely, there is a typo here. > > With old_notify system works as expected. > > Signed-off-

Re: [PATCH] mm, vmpressure: Fix a signedness bug in vmpressure_register_event()

2019-09-28 Thread Andrew Morton
On Wed, 25 Sep 2019 14:04:49 +0300 Dan Carpenter wrote: > The "mode" and "level" variables are enums and in this context GCC will > treat them as unsigned ints so the error handling is never triggered. > > I also removed the bogus initializer because it isn't required any more > and it's sort o

Re: x86/purgatory: undefined symbol __stack_chk_fail

2019-09-28 Thread Arvind Sankar
On Sat, Sep 28, 2019 at 12:41:29PM +, Ingo Molnar wrote: > > * Randy Dunlap wrote: > > > On 9/3/19 8:50 AM, Andreas Smas wrote: > > > Hi, > > > > > > For me, kernels built including this commit > > > b059f801a937 (x86/purgatory: Use CFLAGS_REMOVE rather than reset > > > KBUILD_CFLAGS) > >

Re: [PATCH] tracing/probe: Fix to check the difference of nr_args before adding probe

2019-09-28 Thread Steven Rostedt
On Sat, 28 Sep 2019 02:59:08 -0700 Masami Hiramatsu wrote: > Fix to check the difference of nr_args before adding probe > on existing probes. This also may set the error log index > bigger than the number of command parameters. In that case > it sets the error position is next to the last paramet

Re: [patch for-5.3 0/4] revert immediate fallback to remote hugepages

2019-09-28 Thread Linus Torvalds
On Fri, Sep 27, 2019 at 12:48 AM Michal Hocko wrote: > > - page = get_page_from_freelist(gfp_mask, order, alloc_flags, ac); > + if (!order) > + page = get_page_from_freelist(gfp_mask, order, alloc_flags, > ac); > if (page) > goto got_pg; > > The w

Re: [GIT PULL] scheduler fixes

2019-09-28 Thread pr-tracker-bot
The pull request you sent on Sat, 28 Sep 2019 14:39:05 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9c5efe9ae7df78600c0ee7bcce27516eb687fa6e Thank you! -- Deet-doot-dot, I

Re: [GIT PULL] x86 fix

2019-09-28 Thread pr-tracker-bot
The pull request you sent on Sat, 28 Sep 2019 14:42:43 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f19e00ee84be14e840386cb4f3c0bda5b9cfb5ab Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.4-2 tag

2019-09-28 Thread pr-tracker-bot
The pull request you sent on Sat, 28 Sep 2019 22:14:15 +1000: > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git > tags/powerpc-5.4-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a2953204b576ea3ba4afd07b917811d50fc49778 Thank you! -- Deet-doot-do

Re: [BACKPORT 4.19.y 0/3] Candidates from Spreadtrum 4.14 product kernel

2019-09-28 Thread Sasha Levin
On Wed, Sep 25, 2019 at 05:52:26PM +0800, Baolin Wang wrote: With Arnd's script [1] help, I found some bugfixes in Spreadtrum 4.14 product kernel, but missing in v4.19.75: 513e1073d52e locking/lockdep: Add debug_locks check in __lock_downgrade() 957063c92473 pinctrl: sprd: Use define directive f

Re: [PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-09-28 Thread Roman Penyaev
On 2019-09-28 04:29, Andrew Morton wrote: On Wed, 25 Sep 2019 09:56:03 +0800 hev wrote: From: Heiher Take the case where we have: t0 | (ew) e0 | (et) e1 | (lt) s0 t0: thread 0 e0: epoll fd 0 e1: epoll fd 1 s0: socket fd 0 ew: epoll

linux-next: Fixes tag needs some work in the net tree

2019-09-28 Thread Stephen Rothwell
Hi all, In commit 6b3656a60f20 ("tcp_bbr: fix quantization code to not raise cwnd if not probing bandwidth") Fixes tag Fixes: 3c346b233c68 ("tcp_bbr: fix bw probing to raise in-flight data for very small BDPs") has these problem(s): - Target SHA1 does not exist Did you mean Fixes: 3

[GIT PULL] More Kbuild updates for v5.4-rc1

2019-09-28 Thread Masahiro Yamada
Hi Linus, Please pull some more updates for v5.4-rc1 Thanks. The following changes since commit 351c8a09b00b5c51c8f58b016fffe51f87e2d820: Merge branch 'i2c/for-5.4' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux (2019-09-24 16:48:02 -0700) are available in the Git repository at

Re: [PATCH] i2c: i2c-mt65xx: fix NULL ptr dereference

2019-09-28 Thread Wolfram Sang
> - if (adap->quirks->flags & I2C_AQ_NO_ZERO_LEN) > + if (adap->quirks && adap->quirks->flags & I2C_AQ_NO_ZERO_LEN) Right. Please use i2c_check_quirks(). Otherwise thanks for the catch! @Mediatek-people: can we have a dedicated maintainer for this driver to better prevent stuff like this

Re: [PATCH v9 05/15] leds: multicolor: Introduce a multicolor class definition

2019-09-28 Thread Jacek Anaszewski
On 9/28/19 12:09 PM, Jacek Anaszewski wrote: > Dan, [...] >>> >>> +    brightness_val[i] = brightness * +    priv->intensity / priv->max_intensity; > > Now, looking closer at this equation it becomes obvious to me > why Pavel opted for common max_brightness: in case o

Re: [PATCH v2 1/1] i2c: iproc: Add i2c repeated start capability

2019-09-28 Thread Wolfram Sang
On Thu, Sep 26, 2019 at 10:10:08AM +0530, Rayagonda Kokatanur wrote: > From: Lori Hikichi > > Enable handling of i2c repeated start. The current code > handles a multi msg i2c transfer as separate i2c bus > transactions. This change will now handle this case > using the i2c repeated start protoco

Re: [PATCH v2] selftests: Add kselftest-all and kselftest-install targets

2019-09-28 Thread Masahiro Yamada
On Fri, Sep 27, 2019 at 7:40 AM Shuah Khan wrote: > > Add kselftest-all target to build tests from the top level > Makefile. This is to simplify kselftest use-cases for CI and > distributions where build and test systems are different. > > Current kselftest target builds and runs tests on a develo

Re: [PATCH v4 0/4] tpm: add update_durations class op to allow override of chip supplied values

2019-09-28 Thread Jerry Snitselaar
On Mon Sep 02 19, Jerry Snitselaar wrote: We've run into a case where a customer has an STM TPM 1.2 chip (version 1.2.8.28), that is getting into an inconsistent state and they end up getting tpm transmit errors. In really old tpm code this wasn't seen because the code that grabbed the duration

[PATCH 05/14] KVM: monolithic: add more section prefixes in the KVM common code

2019-09-28 Thread Andrea Arcangeli
Add more section prefixes of some KVM common code function because with the monolithic KVM model the section checker can now do a more accurate static analysis at build time and this allows to build without CONFIG_SECTION_MISMATCH_WARN_ONLY=n. Signed-off-by: Andrea Arcangeli --- arch/x86/kvm/x86

[PATCH 01/14] KVM: monolithic: x86: remove kvm.ko

2019-09-28 Thread Andrea Arcangeli
This is the first commit of a patch series that aims to replace the modular kvm.ko kernel module with a monolithic kvm-intel/kvm-amd model. This change has the only possible cons of wasting some disk space in /lib/modules/. The pros are that it saves CPUS and some minor RAM which are more scarse re

[PATCH 04/14] KVM: monolithic: x86: handle the request_immediate_exit variation

2019-09-28 Thread Andrea Arcangeli
request_immediate_exit is one of those few cases where the pointer to function of the method isn't fixed at build time and it requires special handling because hardware_setup() may override it at runtime. Signed-off-by: Andrea Arcangeli --- arch/x86/kvm/vmx/vmx.c | 5 - 1 file changed, 4 ins

[PATCH 07/14] KVM: monolithic: x86: remove __init section prefix from kvm_x86_cpu_has_kvm_support

2019-09-28 Thread Andrea Arcangeli
Adjusts the section prefixes of some KVM x86 code function because with the monolithic KVM model the section checker can now do a more accurate static analysis at build time. This also allows to build without CONFIG_SECTION_MISMATCH_WARN_ONLY=n. The __init needs to be removed on vmx despite it's o

[PATCH 00/14] KVM monolithic v2

2019-09-28 Thread Andrea Arcangeli
Hello, as usual the last 4 patches could be splitted off but I did more measurements in that area and I altered the commit headers. They're fairly small commits compared to the previous part so I kept it considering they're needed to benchmark the previous part. The KVM monolithic enhancement is

[PATCH 08/14] KVM: monolithic: x86: remove exports

2019-09-28 Thread Andrea Arcangeli
The exports would be duplicated across kvm-amd and kvm-intel if they're kept, this cleanup various harmless warnings about it. The following warning remains for now to be able to load the kvmgt driver. These remaining warnings can be handled later. WARNING: arch/x86/kvm/kvm-amd: 'kvm_slot_page_tr

[PATCH 06/14] KVM: monolithic: x86: remove __exit section prefix from machine_unsetup

2019-09-28 Thread Andrea Arcangeli
Adjusts the section prefixes of some KVM x86 code function because with the monolithic KVM model the section checker can now do a more accurate static analysis at build time and it found a potentially kernel crashing bug. This also allows to build without CONFIG_SECTION_MISMATCH_WARN_ONLY=n. The _

[PATCH 11/14] KVM: x86: optimize more exit handlers in vmx.c

2019-09-28 Thread Andrea Arcangeli
Eliminate wasteful call/ret non RETPOLINE case and unnecessary fentry dynamic tracing hooking points. Signed-off-by: Andrea Arcangeli --- arch/x86/kvm/vmx/vmx.c | 30 +- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/k

[PATCH 12/14] KVM: retpolines: x86: eliminate retpoline from vmx.c exit handlers

2019-09-28 Thread Andrea Arcangeli
It's enough to check the exit value and issue a direct call to avoid the retpoline for all the common vmexit reasons. Reducing this list to only EXIT_REASON_MSR_WRITE, EXIT_REASON_PREEMPTION_TIMER, EXIT_REASON_EPT_MISCONFIG, EXIT_REASON_IO_INSTRUCTION increases the computation time of the hrtimer

[PATCH 02/14] KVM: monolithic: x86: disable linking vmx and svm at the same time into the kernel

2019-09-28 Thread Andrea Arcangeli
Linking both vmx and svm into the kernel at the same time isn't possible anymore or the kvm_x86/kvm_x86_pmu external function names would collide. Reported-by: kbuild test robot Signed-off-by: Andrea Arcangeli --- arch/x86/kvm/Kconfig | 24 ++-- 1 file changed, 22 insertions

[PATCH 09/14] KVM: monolithic: remove exports from KVM common code

2019-09-28 Thread Andrea Arcangeli
The exports would be duplicated across kvm-amd and kvm-intel if they're kept and that causes various harmless warnings. The warnings aren't particularly concerning because the two modules can't load at the same time, but it's cleaner to remove the warnings by removing the exports. This commit mig

[PATCH 14/14] x86: retpolines: eliminate retpoline from msr event handlers

2019-09-28 Thread Andrea Arcangeli
It's enough to check the value and issue the direct call. After this commit is applied, here the most common retpolines executed under a high resolution timer workload in the guest on a VMX host: [..] @[ trace_retpoline+1 __trace_retpoline+30 __x86_indirect_thunk_rax+33 do_syscall

[PATCH 13/14] KVM: retpolines: x86: eliminate retpoline from svm.c exit handlers

2019-09-28 Thread Andrea Arcangeli
It's enough to check the exit value and issue a direct call to avoid the retpoline for all the common vmexit reasons. After this commit is applied, here the most common retpolines executed under a high resolution timer workload in the guest on a SVM host: [..] @[ trace_retpoline+1 __trace

[PATCH 10/14] KVM: monolithic: x86: drop the kvm_pmu_ops structure

2019-09-28 Thread Andrea Arcangeli
Cleanup after the structure was finally left completely unused. Signed-off-by: Andrea Arcangeli --- arch/x86/include/asm/kvm_host.h | 3 --- arch/x86/kvm/pmu.h | 20 arch/x86/kvm/pmu_amd.c | 15 --- arch/x86/kvm/svm.c | 1 - a

Re: x86/purgatory: undefined symbol __stack_chk_fail

2019-09-28 Thread Rasmus Villemoes
On 03/09/2019 17.50, Andreas Smas wrote: > Hi, > > For me, kernels built including this commit > b059f801a937 (x86/purgatory: Use CFLAGS_REMOVE rather than reset > KBUILD_CFLAGS) > > results in kexec() failing to load the kernel: > > kexec: Undefined symbol: __stack_chk_fail > kexec-bzImage64:

[PATCH] x86/mce/amd: Make disable_err_thresholding() static

2019-09-28 Thread Borislav Petkov
From: Borislav Petkov No functional changes. Signed-off-by: Borislav Petkov --- arch/x86/kernel/cpu/mce/amd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 6ea7fdc82f3c..5167bd2bb6b1 100644 --- a/arch/x86

Re: [PATCH v2] media: vimc: fla: Add virtual flash subdevice

2019-09-28 Thread Lucas Magalhães
Hi Hans, Thanks for the review. Sorry about the style mistakes, will be careful next time. Just a couple of questions. On Fri, Sep 20, 2019 at 8:32 AM Hans Verkuil wrote: > > > +static int vimc_fla_s_ctrl(struct v4l2_ctrl *c) > > +{ > > + > > + struct vimc_fla_device *vfla = > > +

[PATCH] x86/microcode/amd: Fix two -Wunused-but-set-variable warnings

2019-09-28 Thread Borislav Petkov
From: Borislav Petkov The dummy variable is the high part of the microcode revision MSR which is defined as reserved. Mark it unused so that W=1 builds don't trigger the above warning. No functional changes. Signed-off-by: Borislav Petkov --- arch/x86/kernel/cpu/microcode/amd.c | 4 ++-- 1 fi

Re: [GIT PULL][SECURITY] Kernel lockdown patches for v5.4

2019-09-28 Thread pr-tracker-bot
The pull request you sent on Tue, 10 Sep 2019 15:01:12 -0700 (PDT): > git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git > next-lockdown has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/aefcf2f4b58155d27340ba5f9ddbe9513da8286d Thank you! -- Deet

Re: [GIT PULL][SECURITY] Kernel lockdown patches for v5.4

2019-09-28 Thread Linus Torvalds
On Fri, Sep 27, 2019 at 11:19 AM Linus Torvalds wrote: > > This is one of the pull requests that I have to go through commit by > commit because of the history of this thing. > > And I've yet to empty my queue of all the _regular_ things that came > in this merge window, so I haven't had time. I'

[PATCH] genirq: replace notify with old_notify in irq_set_affinity_notifier()

2019-09-28 Thread Ivan Safonov
This patch is for Linux 4.19 with a RT patch. The second 'if' block does not check notify for NULL, this leads to a system crash. Most likely, there is a typo here. With old_notify system works as expected. Signed-off-by: Ivan Safonov --- kernel/irq/manage.c | 2 +- 1 file changed, 1 insertio

[GIT PULL] remove dead mutt url and add active mutt url

2019-09-28 Thread Bhaskar Chowdhury
The following changes since commit 4e4327891fe2a2a4db342985bff4d4c48703c707: replace dead mutt url with active one. (2019-09-28 20:11:00 +0530) are available in the Git repository at: https://github.com/unixbhaskar/linux.git gpg: Signature made Sat 28 Sep 2019 08:11:25 PM IST gpg:

Re: pivot_root(".", ".") and the fchdir() dance

2019-09-28 Thread Michael Kerrisk (man-pages)
Hello Eric, A ping on my question below. Could you take a look please? Thanks, Michael The concern from our conversation at the container mini-summit was that there is a pathology if in your initial mount namespace all of the mounts are marked MS_SHARED like systemd does (and is

[PATCH] can: dev: add missing of_node_put after calling of_get_child_by_name

2019-09-28 Thread Wen Yang
of_node_put needs to be called when the device node which is got from of_get_child_by_name finished using. fixes: 2290aefa2e90 ("can: dev: Add support for limiting configured bitrate") Signed-off-by: Wen Yang Cc: Wolfgang Grandegger Cc: Marc Kleine-Budde Cc: "David S. Miller" Cc: Franklin S Co

Re: [GIT PULL] Thermal management updates for v5.4-rc1

2019-09-28 Thread Zhang Rui
Hi, Linus, I'm really sorry about this. I thought no code change could be a reason that a rebase can be accepted, but didn't realize this is exactly the case we should avoid it. I wish I could read Documentation/maintainer/rebasing-and- merging.rst earlier so that I didn't make this mistake. Sorr

[GIT] Networking

2019-09-28 Thread David Miller
1) Sanity check URB networking device parameters to avoid divide by zero, from Oliver Neukum. 2) Disable global multicast filter in NCSI, otherwise LLDP and IPV6 don't work properly. Longer term this needs a better fix tho. From Vijay Khemka. 3) Small fixes to selftests (use ping when

Re: [PATCH] powerpc/vio: use simple dummy struct device as bus parent

2019-09-28 Thread Dan Streetman
On Sat, Sep 28, 2019 at 3:41 AM Greg Kroah-Hartman wrote: > > On Fri, Sep 27, 2019 at 03:48:49PM -0400, Dan Streetman wrote: > > On Fri, Sep 27, 2019 at 2:19 PM Greg Kroah-Hartman > > wrote: > > > > > > On Fri, Sep 27, 2019 at 09:04:02AM -0400, Dan Streetman wrote: > > > > The dummy vio_bus_devic

[GIT PULL] x86 fix

2019-09-28 Thread Ingo Molnar
Linus, Please pull the latest x86-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus # HEAD: ca14c996afe7228ff9b480cf225211cc17212688 x86/purgatory: Disable the stackleak GCC plugin for the purgatory A kexec fix for the case wh

Re: x86/purgatory: undefined symbol __stack_chk_fail

2019-09-28 Thread Ingo Molnar
* Randy Dunlap wrote: > On 9/3/19 8:50 AM, Andreas Smas wrote: > > Hi, > > > > For me, kernels built including this commit > > b059f801a937 (x86/purgatory: Use CFLAGS_REMOVE rather than reset > > KBUILD_CFLAGS) > > > > results in kexec() failing to load the kernel: > > > > kexec: Undefined

[GIT PULL] scheduler fixes

2019-09-28 Thread Ingo Molnar
Linus, Please pull the latest sched-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched-urgent-for-linus # HEAD: 4892f51ad54ddff2883a60b6ad4323c1f632a9d6 sched/fair: Avoid redundant EAS calculation The changes are: - Apply a number of membar

[GIT PULL] Please pull powerpc/linux.git powerpc-5.4-2 tag

2019-09-28 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc updates for 5.4: The following changes since commit 45824fc0da6e46cc5d563105e1eaaf3098a686f9: Merge tag 'powerpc-5.4-1' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux (2019-09-20 11:48:06

Re:Need your input [PATCH V2] Remove dead url and added active url .

2019-09-28 Thread Bhaskar Chowdhury
On 01:23 Sat 28 Sep 2019, Jonathan Corbet wrote: On Fri, 27 Sep 2019 20:14:11 +0530 Bhaskar Chowdhury wrote: diff --git a/Documentation/process/email-clients.rst b/Documentation/process/email-clients.rst index 1f920d445a8b..15781bf10b8d 100644 --- a/Documentation/process/email-clients.rst +++

[PATCH] ARM: dts: kirkwood: synology: Fix rs5c372 RTC entry

2019-09-28 Thread Walter Schweizer
In the rtc-rs5c372.c driver the compatible entry has been renamed from rs5c372 to rs5c372a. Most dts files have been adapted. This patch completes the change. Signed-off-by: Walter Schweizer --- arch/arm/boot/dts/kirkwood-synology.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v9 07/15] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-09-28 Thread Jacek Anaszewski
Dan, On 9/26/19 1:59 PM, Dan Murphy wrote: > Jacek > > On 9/25/19 4:27 PM, Jacek Anaszewski wrote: >> Dan, >> >> On 9/25/19 7:46 PM, Dan Murphy wrote: > > > >>> + >>> +static int lp50xx_brightness_set(struct led_classdev *cdev, >>> + enum led_brightness brightness) >>> +{ >>> +

Re: [PATCH v9 05/15] leds: multicolor: Introduce a multicolor class definition

2019-09-28 Thread Jacek Anaszewski
Dan, On 9/26/19 1:52 PM, Dan Murphy wrote: > Jacek > > On 9/25/19 4:12 PM, Jacek Anaszewski wrote: >> Dan, >> >> On 9/25/19 7:46 PM, Dan Murphy wrote: >>> Introduce a multicolor class that groups colored LEDs >>> within a LED node. >>> >>> The multi color class groups monochrome LEDs and allows c

[PATCH] tracing/probe: Fix to check the difference of nr_args before adding probe

2019-09-28 Thread Masami Hiramatsu
Fix to check the difference of nr_args before adding probe on existing probes. This also may set the error log index bigger than the number of command parameters. In that case it sets the error position is next to the last parameter. Fixes: ca89bc071d5e ("tracing/kprobe: Add multi-probe per event

Re: [PATCH RFC 2/2] interconnect: qcom: add msm8974 driver

2019-09-28 Thread Brian Masney
On Mon, Sep 02, 2019 at 05:19:25PM -0400, Brian Masney wrote: > Add driver for the Qualcomm MSM8974 interconnect providers that support > setting system bandwidth requirements between various network-on-chip > fabrics. > > I marked this as a PATCH RFC since I'm not able to write to all of the > ma

Re: [PATCH] tracing/probe: Test nr_args match in looking for same probe events

2019-09-28 Thread Masami Hiramatsu
On Sat, 28 Sep 2019 01:17:48 -0700 Masami Hiramatsu wrote: > If we found that 2 probes have different number of argument should not be > folded at all. > Also, we have to adjust error log position. Attached patch will fix those > errors correctly as bellow. Oops, missed the fixed tag. Anyway I'l

Re: [PATCH] virt: vbox: fix memory leak in hgcm_call_preprocess_linaddr

2019-09-28 Thread Hans de Goede
Hi, On 28-09-2019 01:04, Navid Emamdoost wrote: In hgcm_call_preprocess_linaddr memory is allocated for bounce_buf but is not released if copy_form_user fails. The release is added. Fixes: 579db9d45cb4 ("virt: Add vboxguest VMMDEV communication code") Signed-off-by: Navid Emamdoost Thank yo

[PATCH v2] z3fold: claim page in the beginning of free

2019-09-28 Thread Vitaly Wool
There's a really hard to reproduce race in z3fold between z3fold_free() and z3fold_reclaim_page(). z3fold_reclaim_page() can claim the page after z3fold_free() has checked if the page was claimed and z3fold_free() will then schedule this page for compaction which may in turn lead to random page fau

Re: [PATCH v5 1/1] random: getrandom(2): warn on large CRNG waits, introduce new flags

2019-09-28 Thread Ahmed S. Darwish
On Thu, Sep 26, 2019 at 02:39:44PM -0700, Andy Lutomirski wrote: > On 9/26/19 1:44 PM, Ahmed S. Darwish wrote: > > Since Linux v3.17, getrandom(2) has been created as a new and more > > secure interface for pseudorandom data requests. It attempted to > > solve three problems, as compared to /dev/u

Re: [PATCH v6 2/2] dt/bindings: Add bindings for Layerscape external irqs

2019-09-28 Thread Kurt Kanzenbach
On Fri, Sep 27, 2019 at 09:16:50PM +, Rasmus Villemoes wrote: > On 27/09/2019 18.11, Rob Herring wrote: > > On Mon, Sep 23, 2019 at 12:15:13PM +0200, Kurt Kanzenbach wrote: > >> +Required properties: > >> +- compatible: should be "fsl,-extirq", e.g. > >> "fsl,ls1021a-extirq". > >> +- interrupt

Re: [PATCH] mm/page_alloc: fix a crash in free_pages_prepare()

2019-09-28 Thread David Hildenbrand
On 28.09.19 00:17, Alexander Duyck wrote: > On Fri, Sep 27, 2019 at 2:59 PM Andrew Morton > wrote: >> >> On Fri, 27 Sep 2019 17:28:06 -0400 Qian Cai wrote: >> So I think you've moved the arch_free_page() to be after the final thing which can access page contents, yes? If so, we s

RE: [PATCH net 0/8] net: stmmac: Fixes for -net

2019-09-28 Thread Jose Abreu
From: Jose Abreu Date: Sep/27/2019, 08:48:48 (UTC+00:00) > Misc fixes for -net tree. More info in commit logs. David, please do not apply these. I forgot to rebase my tree against -net and this was based on -next. I'll resend. Sorry for the mess :( --- Thanks, Jose Miguel Abreu

[PATCH -next] regulator: pcap-regulator: remove unused variable 'SW3_table'

2019-09-28 Thread YueHaibing
drivers/regulator/pcap-regulator.c:89:27: warning: SW3_table defined but not used [-Wunused-const-variable=] It is never used, so can be removed. Signed-off-by: YueHaibing --- drivers/regulator/pcap-regulator.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/regulator/pcap-regul

  1   2   >