Re: cleanup the walk_page_range interface

2019-08-16 Thread Stephen Rothwell
Hi Christoph, On Sat, 17 Aug 2019 08:43:01 +0200 Christoph Hellwig wrote: > > On Sat, Aug 17, 2019 at 04:41:24PM +1000, Stephen Rothwell wrote: > > I certainly prefer that method of API change :-) > > (see the current "keys: Replace uid/gid/perm permissions checking with > > an ACL" in linux-next

Re: [PATCH] Fix an OOB bug in uac_mixer_unit_bmControls

2019-08-16 Thread Takashi Iwai
On Sat, 17 Aug 2019 06:32:07 +0200, Hui Peng wrote: > > `uac_mixer_unit_get_channels` calls `uac_mixer_unit_bmControls` > to get pointer to bmControls field. The current implementation of > `uac_mixer_unit_get_channels` does properly check the size of > uac_mixer_unit_descriptor descriptor and may

[PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue

2019-08-16 Thread Matthew Hanzelik
Fixed an unnamed parameter style issue. Signed-off-by: Matthew Hanzelik --- drivers/staging/speakup/spk_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h index a2fc72c29894..afa64eb9afb4 100644 -

Re: cleanup the walk_page_range interface

2019-08-16 Thread Christoph Hellwig
On Sat, Aug 17, 2019 at 04:41:24PM +1000, Stephen Rothwell wrote: > I certainly prefer that method of API change :-) > (see the current "keys: Replace uid/gid/perm permissions checking with > an ACL" in linux-next and the (currently) three merge fixup patches I > am carrying. Its not bad when peop

[PATCH] media: dvb-frontends: fix memory leaks

2019-08-16 Thread Wenwen Wang
In dib7000pc_detection(), 'tx' and 'rx' are allocated through kzalloc() respectively. However, if DiB7000PC is detected, they are not deallocated, leading to memory leaks. To fix this issue, create a label to free 'tx' and 'rx' before returning from the function. Signed-off-by: Wenwen Wang --- d

Re: cleanup the walk_page_range interface

2019-08-16 Thread Stephen Rothwell
Hi all, On Fri, 16 Aug 2019 14:06:23 -0700 Andrew Morton wrote: > > On Fri, 16 Aug 2019 14:32:58 +0200 Christoph Hellwig wrote: > > > On Fri, Aug 16, 2019 at 11:57:40AM +, Jason Gunthorpe wrote: > > > Are there conflicts with trees other than hmm? > > > > > > We can put it on a topic br

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-16 Thread Greg KH
On Fri, Aug 16, 2019 at 05:47:26PM -0700, Roman Gushchin wrote: > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > with the hierarchical ones") effectively decreased the precision of > per-memcg vmstats_local and per-memcg-per-node lruvec percpu counters. > > That's good for

[PATCH] clk: Remove extraneous 'for' word in comments

2019-08-16 Thread Rishi Gupta
An extra 'for' word is grammatically incorrect in the comment 'verifying ops for multi-parent clks'. This commit removes this extra for word. Signed-off-by: Rishi Gupta --- drivers/clk/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c

[PATCH] media: usb: cx231xx-417: fix a memory leak bug

2019-08-16 Thread Wenwen Wang
In cx231xx_load_firmware(), 'p_buffer' is allocated through vmalloc() to hold the firmware. However, after the usage, it is not deallocated, leading to a memory leak bug. Signed-off-by: Wenwen Wang --- drivers/media/usb/cx231xx/cx231xx-417.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dr

Re: [PATCH v2 10/14] dt-bindings: power: avs: Add support for CPR (Core Power Reduction)

2019-08-16 Thread Stephen Boyd
Quoting Niklas Cassel (2019-07-25 03:41:38) > + cpr@b018000 { > + compatible = "qcom,qcs404-cpr", "qcom,cpr"; > + reg = <0x0b018000 0x1000>; > + interrupts = <0 15 IRQ_TYPE_EDGE_RISING>; > + clocks = <&xo_board>; > + clock-

Re: [PATCH 15/15] drivers: thermal: tsens: Add interrupt support

2019-08-16 Thread Stephen Boyd
Quoting Amit Kucheria (2019-07-25 15:18:50) > diff --git a/drivers/thermal/qcom/tsens-common.c > b/drivers/thermal/qcom/tsens-common.c > index 13a875b99094..f94ef79c37bc 100644 > --- a/drivers/thermal/qcom/tsens-common.c > +++ b/drivers/thermal/qcom/tsens-common.c > @@ -13,6 +13,22 @@ > #include

Re: [PATCH v4 1/2] rcu/tree: Add basic support for kfree_rcu() batching

2019-08-16 Thread Joel Fernandes
On Fri, Aug 16, 2019 at 10:20:23PM -0700, Paul E. McKenney wrote: > On Sat, Aug 17, 2019 at 12:30:24AM -0400, Joel Fernandes wrote: > > On Fri, Aug 16, 2019 at 08:56:37PM -0700, Paul E. McKenney wrote: > > > On Fri, Aug 16, 2019 at 09:32:23PM -0400, Joel Fernandes wrote: > > > > Hi Paul, > > > > >

[PATCH] media: cpia2_usb: fix memory leaks

2019-08-16 Thread Wenwen Wang
In submit_urbs(), 'cam->sbuf[i].data' is allocated through kmalloc_array(). However, it is not deallocated if the following allocation for urbs fails. To fix this issue, free 'cam->sbuf[i].data' if usb_alloc_urb() fails. Signed-off-by: Wenwen Wang --- drivers/media/usb/cpia2/cpia2_usb.c | 4

Re: [PATCH v4 1/2] rcu/tree: Add basic support for kfree_rcu() batching

2019-08-16 Thread Paul E. McKenney
On Sat, Aug 17, 2019 at 12:30:24AM -0400, Joel Fernandes wrote: > On Fri, Aug 16, 2019 at 08:56:37PM -0700, Paul E. McKenney wrote: > > On Fri, Aug 16, 2019 at 09:32:23PM -0400, Joel Fernandes wrote: > > > Hi Paul, > > > > > > On Fri, Aug 16, 2019 at 3:16 PM Paul E. McKenney > > > wrote: > > > >

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-16 Thread Paul E. McKenney
On Fri, Aug 16, 2019 at 03:57:43PM -0700, Linus Torvalds wrote: [ . . . ] > We add READ_ONCE and WRITE_ONCE annotations when they make sense. Not > because of some theoretical "compiler is free to do garbage" > arguments. If such garbage happens, we need to fix the compiler, the > same way we alr

Re: [PATCH -rcu/dev] Please squash: fixup! rcu/tree: Add basic support for kfree_rcu() batching

2019-08-16 Thread Joel Fernandes
On Fri, Aug 16, 2019 at 09:38:54PM -0700, Paul Walmsley wrote: > On Sat, 17 Aug 2019, Joel Fernandes (Google) wrote: > > > xchg() on a bool is causing issues on riscv and arm32. > > Indeed, it seems best not to use xchg() on any type that's not 32 bits > long or that's not the CPU's native word

Re: [PATCH -rcu/dev] Please squash: fixup! rcu/tree: Add basic support for kfree_rcu() batching

2019-08-16 Thread Paul Walmsley
On Sat, 17 Aug 2019, Joel Fernandes (Google) wrote: > xchg() on a bool is causing issues on riscv and arm32. Indeed, it seems best not to use xchg() on any type that's not 32 bits long or that's not the CPU's native word size. Probably we should update the documentation. > Please squash this

[PATCH] Fix an OOB bug in uac_mixer_unit_bmControls

2019-08-16 Thread Hui Peng
`uac_mixer_unit_get_channels` calls `uac_mixer_unit_bmControls` to get pointer to bmControls field. The current implementation of `uac_mixer_unit_get_channels` does properly check the size of uac_mixer_unit_descriptor descriptor and may allow OOB access in `uac_mixer_unit_bmControls`. Reported-by:

Re: [PATCH v4 1/2] rcu/tree: Add basic support for kfree_rcu() batching

2019-08-16 Thread Joel Fernandes
On Fri, Aug 16, 2019 at 08:56:37PM -0700, Paul E. McKenney wrote: > On Fri, Aug 16, 2019 at 09:32:23PM -0400, Joel Fernandes wrote: > > Hi Paul, > > > > On Fri, Aug 16, 2019 at 3:16 PM Paul E. McKenney > > wrote: > > > > > Hello, Joel, > > > > > > > > > > I reworked the commit log as follows, bu

[PATCH -rcu/dev] Please squash: fixup! rcu/tree: Add basic support for kfree_rcu() batching

2019-08-16 Thread Joel Fernandes (Google)
xchg() on a bool is causing issues on riscv and arm32. Please squash this into the -rcu dev branch to resolve the issue. Please squash this fix. Fixes: -rcu dev commit 3cbd3aa7d9c7bdf ("rcu/tree: Add basic support for kfree_rcu() batching") Signed-off-by: Joel Fernandes (Google) --- kernel/rc

Re: [PATCH 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature

2019-08-16 Thread Stephen Boyd
Quoting Amit Kucheria (2019-07-25 15:18:49) > diff --git a/drivers/thermal/qcom/tsens-common.c > b/drivers/thermal/qcom/tsens-common.c > index 7ab2e740a1da..13a875b99094 100644 > --- a/drivers/thermal/qcom/tsens-common.c > +++ b/drivers/thermal/qcom/tsens-common.c > @@ -84,13 +84,35 @@ static inli

Re: [PATCH 07/15] dt: thermal: tsens: Document interrupt support in tsens driver

2019-08-16 Thread Stephen Boyd
Quoting Amit Kucheria (2019-08-16 15:02:08) > > Depending on the version of the tsens IP, there can be 1 (upper/lower > threshold), 2 (upper/lower + critical threshold) or 3 (upper/lower + > critical + zero degree) interrupts. This patch series only introduces > support for a single interrupt (upp

[PATCH] Drivers: hv: balloon: Remove dependencies on guest page size

2019-08-16 Thread Himadri Pandya
Hyper-V assumes page size to be 4K. This might not be the case for ARM64 architecture. Hence use hyper-v specific page size and page shift definitions to avoid conflicts between different host and guest page sizes on ARM64. Also, remove some old and incorrect comments and redefine ballooning granu

Re: [PATCH 04/15] drivers: thermal: tsens: Add debugfs support

2019-08-16 Thread Stephen Boyd
Quoting Amit Kucheria (2019-07-25 15:18:39) > Dump some basic version info and sensor details into debugfs > Maybe you can put some sample output in the commit text. > Signed-off-by: Amit Kucheria > --- > drivers/thermal/qcom/tsens-common.c | 85 + > drivers/thermal

Re: [PATCH 03/15] drivers: thermal: tsens: Add __func__ identifier to debug statements

2019-08-16 Thread Stephen Boyd
Quoting Amit Kucheria (2019-07-25 15:18:38) > Printing the function name when enabling debugging makes logs easier to > read. > > Signed-off-by: Amit Kucheria > --- Reviewed-by: Stephen Boyd

Re: [PATCH 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe

2019-08-16 Thread Stephen Boyd
Quoting Amit Kucheria (2019-07-25 15:18:37) > Move platform_set_drvdata up to avoid an extra 'if (ret)' check after > the call to tsens_register. > > Signed-off-by: Amit Kucheria > --- Reviewed-by: Stephen Boyd

Re: [PATCH 01/15] drivers: thermal: tsens: Get rid of id field in tsens_sensor

2019-08-16 Thread Stephen Boyd
Quoting Amit Kucheria (2019-07-25 15:18:36) > There are two fields - id and hw_id - to track what sensor an action was > to performed on. This was because the sensors connected to a TSENS IP > might not be contiguous i.e. 1, 2, 4, 5 with 3 being skipped. > > This causes confusion in the code which

Re: [PATCH 1/5] dt-bindings: clock: Add Bitmain BM1880 SoC clock controller binding

2019-08-16 Thread Manivannan Sadhasivam
On Fri, Aug 16, 2019 at 08:46:11PM -0700, Stephen Boyd wrote: > Quoting Manivannan Sadhasivam (2019-08-16 20:34:22) > > On Wed, Aug 07, 2019 at 10:01:28PM -0700, Stephen Boyd wrote: > > > Quoting Manivannan Sadhasivam (2019-07-05 08:14:36) > > > > +It is expected that it is defined using standard c

[PATCH] libata: Fix a memory leak bug

2019-08-16 Thread Wenwen Wang
In ata_init(), 'ata_force_tbl' is allocated through kcalloc() in ata_parse_force_param(). However, it is not deallocated if ata_attach_transport() fails, leading to a memory leak bug. To fix this issue, free 'ata_force_tbl' before go to the 'err_out' label. Signed-off-by: Wenwen Wang --- drivers

Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning

2019-08-16 Thread Dan Williams
On Fri, Aug 16, 2019 at 8:34 PM Qian Cai wrote: > > > > > On Aug 16, 2019, at 5:48 PM, Dan Williams wrote: > > > > On Fri, Aug 16, 2019 at 2:36 PM Qian Cai wrote: > >> > >> Every so often recently, booting Intel CPU server on linux-next triggers > >> this > >> warning. Trying to figure out if

Re: [PATCH v4 1/2] rcu/tree: Add basic support for kfree_rcu() batching

2019-08-16 Thread Paul E. McKenney
On Fri, Aug 16, 2019 at 09:32:23PM -0400, Joel Fernandes wrote: > Hi Paul, > > On Fri, Aug 16, 2019 at 3:16 PM Paul E. McKenney > wrote: > > > > Hello, Joel, > > > > > > > > I reworked the commit log as follows, but was then unsuccessful in > > > > working out which -rcu commit to apply it to.

Re: [PATCH 4/5] clk: Add driver for Bitmain BM1880 SoC clock controller

2019-08-16 Thread Manivannan Sadhasivam
Hi Stephen, On Wed, Aug 07, 2019 at 10:15:59PM -0700, Stephen Boyd wrote: > Quoting Manivannan Sadhasivam (2019-07-05 08:14:39) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > > index fc1e0cf44995..ffc61ed85ade 100644 > > --- a/drivers/clk/Kconfig > > +++ b/drivers/clk/Kconfig > > @@

Re: [PATCH 5/6] clk: imx8mn: Add necessary frequency support for ARM PLL table

2019-08-16 Thread Stephen Boyd
Quoting anson.hu...@nxp.com (2019-08-15 03:59:42) > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c > index ecd1062..3f1239a 100644 > --- a/drivers/clk/imx/clk-imx8mn.c > +++ b/drivers/clk/imx/clk-imx8mn.c > @@ -82,6 +84,7 @@ static struct imx_pll14xx_clk imx8mn_dram_pll =

Re: [PATCH 1/5] dt-bindings: clock: Add Bitmain BM1880 SoC clock controller binding

2019-08-16 Thread Stephen Boyd
Quoting Manivannan Sadhasivam (2019-08-16 20:34:22) > On Wed, Aug 07, 2019 at 10:01:28PM -0700, Stephen Boyd wrote: > > Quoting Manivannan Sadhasivam (2019-07-05 08:14:36) > > > +It is expected that it is defined using standard clock bindings as "osc". > > > + > > > +Example: > > > + > > > +

Re: [PATCH] arch : arm : add a criteria for pfn_valid

2019-08-16 Thread Matthew Wilcox
On Sat, Aug 17, 2019 at 11:00:13AM +0800, Zhaoyang Huang wrote: > #ifdef CONFIG_HAVE_ARCH_PFN_VALID > int pfn_valid(unsigned long pfn) > { > - return memblock_is_map_memory(__pfn_to_phys(pfn)); > + return (pfn > max_pfn) ? > + false : memblock_is_map_memory(__pfn_to_phys(pfn)

Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning

2019-08-16 Thread Qian Cai
> On Aug 16, 2019, at 5:48 PM, Dan Williams wrote: > > On Fri, Aug 16, 2019 at 2:36 PM Qian Cai wrote: >> >> Every so often recently, booting Intel CPU server on linux-next triggers this >> warning. Trying to figure out if the commit 7cc7867fb061 >> ("mm/devm_memremap_pages: enable sub-sect

Re: [PATCH 1/5] dt-bindings: clock: Add Bitmain BM1880 SoC clock controller binding

2019-08-16 Thread Manivannan Sadhasivam
Hi Stephen, On Wed, Aug 07, 2019 at 10:01:28PM -0700, Stephen Boyd wrote: > Quoting Manivannan Sadhasivam (2019-07-05 08:14:36) > > Add devicetree binding for Bitmain BM1880 SoC clock controller. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > .../bindings/clock/bitmain,bm1880-clk.txt

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-16 Thread Yafang Shao
On Sat, Aug 17, 2019 at 8:47 AM Roman Gushchin wrote: > > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > with the hierarchical ones") effectively decreased the precision of > per-memcg vmstats_local and per-memcg-per-node lruvec percpu counters. > > That's good for display

Re: [PATCH net-next 1/3] net: mdio: add support for passing a PTP system timestamp to the mii_bus driver

2019-08-16 Thread Richard Cochran
On Fri, Aug 16, 2019 at 06:31:55PM +0200, Hubert Feurstein wrote: > > int __mdiobus_read(struct mii_bus *bus, int addr, u32 regnum); > int __mdiobus_write(struct mii_bus *bus, int addr, u32 regnum, u16 val); > +int __mdiobus_write_sts(struct mii_bus *bus, int addr, u32 regnum, u16 val, > +

Re: [rcu:from-joel.2019.08.16a 143/172] kernel/rcu/tree.c:2808:6: note: in expansion of macro 'xchg'

2019-08-16 Thread Paul Walmsley
On Fri, 16 Aug 2019, Joel Fernandes wrote: > On Sat, Aug 17, 2019 at 05:10:59AM +0800, kbuild test robot wrote: > > tree: > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > > from-joel.2019.08.16a > > head: 01b0e4d3e0ac279b295bc06a3591f0b810b9908f > > commit

[PATCH] arch : arm : add a criteria for pfn_valid

2019-08-16 Thread Zhaoyang Huang
From: Zhaoyang Huang pfn_valid can be wrong while the MSB of physical address be trimed as pfn larger than the max_pfn. Signed-off-by: Zhaoyang Huang --- arch/arm/mm/init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index c2daa

Re: [RFC PATCH v2 2/3] mm/gup: introduce FOLL_PIN flag for get_user_pages()

2019-08-16 Thread John Hubbard
On 8/16/19 7:24 PM, jhubb...@nvidia.com wrote: > From: John Hubbard > DKIM-Signature: v a a-sha256; claxed/relaxed; d idia.com; s; > t66008674; bhMai0va6k/z2enpQJ4Nfvbj5WByFxGAO1JwdIBbXioh > PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: >In-Reply-To:Referen

Re: [RFC PATCH v2 00/19] RDMA/FS DAX truncate proposal V1,000,002 ;-)

2019-08-16 Thread Dave Chinner
On Fri, Aug 16, 2019 at 12:05:28PM -0700, Ira Weiny wrote: > On Thu, Aug 15, 2019 at 03:05:58PM +0200, Jan Kara wrote: > > On Wed 14-08-19 11:08:49, Ira Weiny wrote: > > > On Wed, Aug 14, 2019 at 12:17:14PM +0200, Jan Kara wrote: > 2) Second reason is that I thought I did not have a good way to tel

[PATCH net-next] net: hns: add phy_attached_info() to the hns driver

2019-08-16 Thread Yonglong Liu
This patch adds the call to phy_attached_info() to the hns driver to identify which exact PHY drivers is in use. Suggested-by: Heiner Kallweit Signed-off-by: Yonglong Liu --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet

[RFC PATCH v2 0/3] mm/gup: introduce vaddr_pin_pages_remote(), FOLL_PIN

2019-08-16 Thread jhubbard
From: John Hubbard Hi Ira, As requested, this is for your tree: https://github.com/weiny2/linux-kernel.git (mmotm-rdmafsdax-b0-v4), to be applied at your last authored commit, which is: commit f625f92ecfb4 ("mm/gup: Remove FOLL_LONGTERM DAX exclusion"). In other words, please delete my previous

[RFC PATCH v2 2/3] mm/gup: introduce FOLL_PIN flag for get_user_pages()

2019-08-16 Thread jhubbard
From: John Hubbard DKIM-Signature: v a* - * In the CMA case: longterm pins in a CMA region would unnecessarily fragment - * that region. And so CMA attempts to migrate the page before pinning when + * In the CMA case: long term pins in a CMA region would unnecessarily fragment + * that region.

[RFC PATCH v2 3/3] mm/gup: introduce vaddr_pin_pages_remote(), and invoke it

2019-08-16 Thread jhubbard
From: John Hubbard vaddr_pin_user_pages_remote() is the "vaddr_pin_pages" corresponding variant to get_user_pages_remote(): it adds the ability to handle FOLL_PIN, FOLL_LONGTERM, or both. Note that the put_user_page*() requirement won't be truly required until all of the call sites have been con

[RFC PATCH v2 1/3] For Ira: tiny formatting tweak to kerneldoc

2019-08-16 Thread jhubbard
From: John Hubbard For your vaddr_pin_pages() and vaddr_unpin_pages(). Just merge it into wherever it goes please. Didn't want to cause merge problems so it's a separate patch-let. Signed-off-by: John Hubbard --- mm/gup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

Re: [PATCH] ASoC: imx-audmux: Add driver suspend and resume to support MEGA Fast

2019-08-16 Thread S.j. Wang
Hi Mark > > On Fri, Aug 16, 2019 at 01:03:14AM -0400, Shengjiu Wang wrote: > > > + for (i = 0; i < reg_max; i++) > > + regcache[i] = readl(audmux_base + i * 4); > > If only there were some framework which provided a register cache! 😝 Yes, next step I can refine this driver to use

Re: [PATCH net] net: hns: add phy_attached_info() to the hns driver

2019-08-16 Thread Yonglong Liu
Please ignore this patch, it is not bugfix, should send to net-next. Sorry for the noise. On 2019/8/17 9:56, Yonglong Liu wrote: > This patch add the call to phy_attached_info() to the hns driver > to identify which exact PHY drivers is in use. > > Signed-off-by: Yonglong Liu > --- > drivers/ne

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-16 Thread Steven Rostedt
On Fri, 16 Aug 2019 21:36:49 -0400 (EDT) Mathieu Desnoyers wrote: > - On Aug 16, 2019, at 5:04 PM, Linus Torvalds > torva...@linux-foundation.org wrote: > > > On Fri, Aug 16, 2019 at 1:49 PM Thomas Gleixner wrote: > > > >> > >> Can we finally put a foot down and tell compiler and standa

[PATCH v2 RFC 3/2] fstests: check that we can't write to swap files

2019-08-16 Thread Darrick J. Wong
From: Darrick J. Wong While active, the media backing a swap file is leased to the kernel. Userspace has no business writing to it. Make sure we can't do this. Signed-off-by: Darrick J. Wong --- v2: add tests for writable fds after swapon --- src/swapon.c | 135 +

[PATCH net] net: hns: add phy_attached_info() to the hns driver

2019-08-16 Thread Yonglong Liu
This patch add the call to phy_attached_info() to the hns driver to identify which exact PHY drivers is in use. Signed-off-by: Yonglong Liu --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/dri

[rcu:from-joel.2019.08.16a 143/172] tree.c:undefined reference to `__bad_xchg'

2019-08-16 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/paulmck/linux-rcu.git from-joel.2019.08.16a head: 01b0e4d3e0ac279b295bc06a3591f0b810b9908f commit: bda80ba9decc7a32413e88d2f070de180c4b76ab [143/172] rcu/tree: Add basic support for kfree_rcu() batching config: arm-allmodconfig (

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-16 Thread Mathieu Desnoyers
- On Aug 16, 2019, at 6:57 PM, Linus Torvalds torva...@linux-foundation.org wrote: > So in general, we very much expect the compiler to do sane code > generation, and not (for example) do store tearing on normal > word-sized things or add writes that weren't there originally etc. My understa

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-16 Thread Mathieu Desnoyers
- On Aug 16, 2019, at 5:04 PM, Linus Torvalds torva...@linux-foundation.org wrote: > On Fri, Aug 16, 2019 at 1:49 PM Thomas Gleixner wrote: >> >> Can we finally put a foot down and tell compiler and standard committee >> people to stop this insanity? > > It's already effectively done. > >

Re: [PATCH v4 1/2] rcu/tree: Add basic support for kfree_rcu() batching

2019-08-16 Thread Joel Fernandes
Hi Paul, On Fri, Aug 16, 2019 at 3:16 PM Paul E. McKenney wrote: > > > Hello, Joel, > > > > > > I reworked the commit log as follows, but was then unsuccessful in > > > working out which -rcu commit to apply it to. Could you please > > > tell me what commit to apply this to? (Once applied, git

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-16 Thread Mathieu Desnoyers
- On Aug 16, 2019, at 4:49 PM, rostedt rost...@goodmis.org wrote: > On Fri, 16 Aug 2019 16:44:10 -0400 > Joel Fernandes wrote: > > >> I am also more on the side of using *_ONCE. To me, by principal, I >> would be willing to convert any concurrent plain access using _ONCE, >> just so we don'

[GIT PULL] RISC-V updates for v5.3-rc5

2019-08-16 Thread Paul Walmsley
Linus, The following changes since commit d45331b00ddb179e291766617259261c112db872: Linux 5.3-rc4 (2019-08-11 13:26:41 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git tags/riscv/for-v5.3-rc5 for you to fetch changes up to 6970

Re: Kernel 5.2.8 - au0828 - Tuner Is Busy

2019-08-16 Thread Nathan Royce
On Fri, Aug 16, 2019 at 1:42 PM Greg Kroah-Hartman wrote: > If you revert that one commit, does things start working again? > > thanks, > > greg k-h Hey Greg, I just got finished building it after running "$ git revert 812658d88d26" and verifying it reverted by comparing one of the files from git

Re: [rcu:from-joel.2019.08.16a 143/172] kernel/rcu/tree.c:2808:6: note: in expansion of macro 'xchg'

2019-08-16 Thread Joel Fernandes
Resending with more folks added. On Sat, Aug 17, 2019 at 05:10:59AM +0800, kbuild test robot wrote: > tree: > https://kernel.googlesource.com/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > from-joel.2019.08.16a > head: 01b0e4d3e0ac279b295bc06a3591f0b810b9908f > commit: bda80ba9decc7a32413e

Re: [rcu:from-joel.2019.08.16a 143/172] kernel/rcu/tree.c:2808:6: note: in expansion of macro 'xchg'

2019-08-16 Thread Joel Fernandes
On Sat, Aug 17, 2019 at 05:10:59AM +0800, kbuild test robot wrote: > tree: > https://kernel.googlesource.com/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > from-joel.2019.08.16a > head: 01b0e4d3e0ac279b295bc06a3591f0b810b9908f > commit: bda80ba9decc7a32413e88d2f070de180c4b76ab [143/172] rcu

[PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-16 Thread Roman Gushchin
Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones") effectively decreased the precision of per-memcg vmstats_local and per-memcg-per-node lruvec percpu counters. That's good for displaying in memory.stat, but brings a serious regression into the recla

Re: [PULL 0/1] Xtensa fix for v5.3

2019-08-16 Thread pr-tracker-bot
The pull request you sent on Fri, 16 Aug 2019 17:23:49 -0700: > git://github.com/jcmvbkbc/linux-xtensa.git tags/xtensa-20190816 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6e625a1a3f471d63989d3a66cdf6a0c307654848 Thank you! -- Deet-doot-dot, I am a bot. ht

[PULL 0/1] Xtensa fix for v5.3

2019-08-16 Thread Max Filippov
-20190816 for you to fetch changes up to cd8869f4cb257f22b89495ca40f5281e58ba359c: xtensa: add missing isync to the cpu_reset TLB code (2019-08-12 15:05:48 -0700) Xtensa fixes for v5.3: - add missing isync into cpu_reset to make sure

[PATCH v6 5/8] PCI/ATS: Add PRI support for PCIe VF devices

2019-08-16 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan When IOMMU tries to enable Page Request Interface (PRI) for VF device in iommu_enable_dev_iotlb(), it always fails because PRI support for PCIe VF device is currently broken. Current implementation expects the given PCIe device (PF & VF) to implement PRI capabilit

[PATCH v6 3/8] PCI/ATS: Cache PASID capability check result

2019-08-16 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Currently, PASID capability checks are repeated across all PASID API's. Instead, cache the capability check result in pci_pasid_init() and use it in other PASID API's. Signed-off-by: Kuppuswamy Sathyanarayanan --- drivers/pci/ats.c | 50 +

[PATCH v6 4/8] PCI/IOV: Add pci_physfn_reslock/unlock() interfaces

2019-08-16 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan As per PCIe spec r5.0, sec 9.3.7, in SR-IOV devices, capabilities like PASID, PRI, VC, etc are shared between PF and its associated VFs. So, to prevent race conditions between PF/VF while updating configuration registers of these shared capabilities, a new synchro

[PATCH v6 8/8] PCI: Skip Enhanced Allocation (EA) initialization for VF device

2019-08-16 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan As per PCIe r4.0, sec 9.3.6, VF must not implement Enhanced Allocation Capability. So skip pci_ea_init() for virtual devices. Cc: Ashok Raj Cc: Keith Busch Suggested-by: Ashok Raj Signed-off-by: Kuppuswamy Sathyanarayanan --- drivers/pci/pci.c | 7 +++

[PATCH v6 7/8] PCI/ATS: Disable PF/VF ATS service independently

2019-08-16 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Currently all VF's needs to be disable their ATS service before disabling the ATS service in corresponding PF device. But this logic is incorrect and does not align with the spec. Also it might lead to some power and performance impact in the system. As per PCIe s

[PATCH v6 2/8] PCI/ATS: Cache PRI capability check result

2019-08-16 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Currently, PRI capability checks are repeated across all PRI API's. Instead, cache the capability check result in pci_pri_init() and use it in other PRI API's. Signed-off-by: Kuppuswamy Sathyanarayanan --- drivers/pci/ats.c | 56 +

[PATCH v6 6/8] PCI/ATS: Add PASID support for PCIe VF devices

2019-08-16 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan When IOMMU tries to enable PASID for VF device in iommu_enable_dev_iotlb(), it always fails because PASID support for PCIe VF device is currently broken in PCIE driver. Current implementation expects the given PCIe device (PF & VF) to implement PASID capability be

[PATCH v6 1/8] PCI/ATS: Fix pci_prg_resp_pasid_required() dependency issues

2019-08-16 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Since pci_prg_resp_pasid_required() function has dependency on both PASID and PRI, define it only if both CONFIG_PCI_PRI and CONFIG_PCI_PASID config options are enabled. Fixes: e5567f5f6762 ("PCI/ATS: Add pci_prg_resp_pasid_required() interface.") Signed-off-by:

Re: [PATCH][next] bus: moxtet: fix unsigned comparison to less than zero

2019-08-16 Thread Marek Behun
On Fri, 16 Aug 2019 23:41:06 +0100 Colin King wrote: > From: Colin Ian King > > Currently the size_t variable res is being checked for > an error failure however the unsigned variable is never > less than zero so this test is always false. Fix this by > making variable res ssize_t > > Addresse

[PATCH v6 0/8] Fix PF/VF dependency issue

2019-08-16 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Current implementation of ATS, PASID, PRI does not handle VF dependencies correctly. Following patches addresses this issue. Changes since v5: * Created new patches for PRI/PASID capability caching. * Removed individual locks (pri_lock, pasid_lock) and added co

Re: add a not device managed memremap_pages v2

2019-08-16 Thread Ira Weiny
On Fri, Aug 16, 2019 at 08:54:30AM +0200, Christoph Hellwig wrote: > Hi Dan and Jason, > > Bharata has been working on secure page management for kvmppc guests, > and one I thing I noticed is that he had to fake up a struct device > just so that it could be passed to the devm_memremap_pages > inst

[PATCH] lib/hexdump: Make print_hex_dump_bytes() a nop on !DEBUG builds

2019-08-16 Thread Stephen Boyd
I'm seeing a bunch of debug prints from a user of print_hex_dump_bytes() in my kernel logs, but I don't have CONFIG_DYNAMIC_DEBUG enabled nor do I have DEBUG defined in my build. The problem is that print_hex_dump_bytes() calls a wrapper function in lib/hexdump.c that calls print_hex_dump() with K

Re: [PATCH v2 1/6] hwrng: core: Freeze khwrng thread during suspend

2019-08-16 Thread Jarkko Sakkinen
On Fri, Aug 16, 2019 at 05:56:12PM +0200, Alexander Steffen wrote: > > Andrey talked to me a little about this today. Andrey would prefer we > > don't just let the TPM go into a wonky state if it's used during > > suspend/resume so that it can stay resilient to errors. Sounds OK to me, > > but my p

Re: [RFC PATCH v2 00/19] RDMA/FS DAX truncate proposal V1,000,002 ; -)

2019-08-16 Thread Ira Weiny
On Fri, Aug 16, 2019 at 12:05:28PM -0700, 'Ira Weiny' wrote: > On Thu, Aug 15, 2019 at 03:05:58PM +0200, Jan Kara wrote: > > On Wed 14-08-19 11:08:49, Ira Weiny wrote: > > > On Wed, Aug 14, 2019 at 12:17:14PM +0200, Jan Kara wrote: > > > > Hello! > > > > > > > > On Fri 09-08-19 15:58:14, ira.we...

Re: Lay common foundation to make PVR/SGX work without hacks on OMAP34xx, OMAP36xx, AM335x and potentially OMAP4, OMAP5

2019-08-16 Thread Adam Ford
On Wed, Aug 14, 2019 at 8:16 AM Tony Lindgren wrote: > > * H. Nikolaus Schaller [190814 10:34]: > > > > > Am 14.08.2019 um 11:47 schrieb Tony Lindgren : > > > > > > * H. Nikolaus Schaller [190814 08:57]: > > >> I also have pushed good news to > > >> > > >>https://github.com/openpvrsgx-devgro

Re: [PATCH] ipvlan: set hw_enc_features like macvlan

2019-08-16 Thread David Miller
From: Bill Sommerfeld Date: Wed, 14 Aug 2019 17:10:43 -0700 > Allow encapsulated packets sent to tunnels layered over ipvlan to use > offloads rather than forcing SW fallbacks. > > Since commit f21e5077010acda73a60 ("macvlan: add offload features for > encapsulation"), macvlan has set dev->hw_en

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-16 Thread Linus Torvalds
On Fri, Aug 16, 2019 at 3:27 PM Valentin Schneider wrote: > > How would you differentiate optimizations you want from those you don't with > just a flag? There's a reason we use volatile casts instead of declaring > everything volatile: we actually *want* those optimizations. It just so > happens

Re: [PATCHv6 23/36] x86/vdso: Allocate timens vdso

2019-08-16 Thread Dmitry Safonov
Hi Andy, Thomas, thank you very much for your time and the reviews, appreciate that. On 8/16/19 9:10 PM, Thomas Gleixner wrote: > On Fri, 16 Aug 2019, Andy Lutomirski wrote: [..] >> I'm unconvinced that any of this magic is wise. I think you should make a >> special timens vvar page that causes

Re: Kernel 5.2.8 - au0828 - Tuner Is Busy

2019-08-16 Thread Brad Love
Hi Nathan, On 16/08/2019 13.18, Nathan Royce wrote: > Right up front, I must say I do NOT have a Hauppauge tuner. I think > it's like maybe Mygica/Geniatech: > Bus 002 Device 004: ID 05e1:0400 Syntek Semiconductor Co., Ltd > > Whenever I update my kernel, I edit the > ./drivers/media/usb/au0828/a

[PATCH][next] bus: moxtet: fix unsigned comparison to less than zero

2019-08-16 Thread Colin King
From: Colin Ian King Currently the size_t variable res is being checked for an error failure however the unsigned variable is never less than zero so this test is always false. Fix this by making variable res ssize_t Addresses-Coverity: ("Unsigned compared against 0") Fixes: 5bc7f990cd98 ("bus:

Re: [PATCH v6 4/4] net: phy: realtek: Add LED configuration support for RTL8211E

2019-08-16 Thread Matthias Kaehlcke
On Fri, Aug 16, 2019 at 03:12:47PM -0700, Florian Fainelli wrote: > On 8/16/19 2:27 PM, Matthias Kaehlcke wrote: > > On Fri, Aug 16, 2019 at 10:13:42PM +0200, Pavel Machek wrote: > >> On Tue 2019-08-13 12:11:47, Matthias Kaehlcke wrote: > >>> Add a .config_led hook which is called by the PHY core w

Re: [PATCH v6 4/4] net: phy: realtek: Add LED configuration support for RTL8211E

2019-08-16 Thread Doug Anderson
Hi, On Fri, Aug 16, 2019 at 3:12 PM Florian Fainelli wrote: > > On 8/16/19 2:27 PM, Matthias Kaehlcke wrote: > > On Fri, Aug 16, 2019 at 10:13:42PM +0200, Pavel Machek wrote: > >> On Tue 2019-08-13 12:11:47, Matthias Kaehlcke wrote: > >>> Add a .config_led hook which is called by the PHY core whe

Re: [PATCH] PM / wakeup: Register wakeup class kobj after device is added

2019-08-16 Thread Tri Vo
On Fri, Aug 16, 2019 at 2:46 PM Stephen Boyd wrote: > > Quoting Tri Vo (2019-08-16 14:27:35) > > On Fri, Aug 16, 2019 at 7:56 AM Stephen Boyd wrote: > > > diff --git a/drivers/base/power/sysfs.c b/drivers/base/power/sysfs.c > > > index 1b9c281cbe41..27ee00f50bd7 100644 > > > --- a/drivers/base/po

Re: [RFC PATCH 2/2] mm/gup: introduce vaddr_pin_pages_remote()

2019-08-16 Thread John Hubbard
On 8/16/19 2:59 PM, Ira Weiny wrote: > On Fri, Aug 16, 2019 at 11:50:09AM -0700, John Hubbard wrote: ... >>> John could you send a formal patch using vaddr_pin* and I'll add it to the >>> tree? >>> >> >> Yes...hints about which struct file to use here are very welcome, btw. This >> part >> of mm i

[PATCH v3 bpf-next 3/4] tracing/probe: Sync perf_event.h to tools

2019-08-16 Thread Daniel Xu
Signed-off-by: Daniel Xu --- tools/include/uapi/linux/perf_event.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h index 7198ddd0c6b1..8783d29a807a 100644 --- a/tools/include/uapi/linux/per

[PATCH v3 bpf-next 1/4] tracing/probe: Add PERF_EVENT_IOC_QUERY_PROBE ioctl

2019-08-16 Thread Daniel Xu
It's useful to know [uk]probe's nmissed and nhit stats. For example with tracing tools, it's important to know when events may have been lost. debugfs currently exposes a control file to get this information, but it is not compatible with probes registered with the perf API. While bpf programs may

[PATCH v3 bpf-next 2/4] libbpf: Add helpers to extract perf fd from bpf_link

2019-08-16 Thread Daniel Xu
It is sometimes necessary to perform ioctl's on the underlying perf fd. There is not currently a way to extract the fd given a bpf_link, so add a a pair of casting and getting helpers. The casting and getting helpers are nice because they let us define broad categories of links that makes it clear

[PATCH v3 bpf-next 0/4] tracing/probe: Add PERF_EVENT_IOC_QUERY_PROBE

2019-08-16 Thread Daniel Xu
It's useful to know [uk]probe's nmissed and nhit stats. For example with tracing tools, it's important to know when events may have been lost. debugfs currently exposes a control file to get this information, but it is not compatible with probes registered with the perf API. While bpf programs may

[PATCH v3 bpf-next 4/4] tracing/probe: Add self test for PERF_EVENT_IOC_QUERY_PROBE

2019-08-16 Thread Daniel Xu
Acked-by: Andrii Nakryiko Signed-off-by: Daniel Xu --- .../selftests/bpf/prog_tests/attach_probe.c | 106 ++ 1 file changed, 106 insertions(+) diff --git a/tools/testing/selftests/bpf/prog_tests/attach_probe.c b/tools/testing/selftests/bpf/prog_tests/attach_probe.c index 5ecc

re: clk: actions: Don't reference clk_init_data after registration [bug report]

2019-08-16 Thread Colin Ian King
Hi, Static analysis with Coverity Scan on linux-next has found an issue with the following commit: commit 20cac6d02815edcc0b1c87bc3e8858b3d1fda3fa Author: Stephen Boyd Date: Wed Jul 31 12:35:09 2019 -0700 clk: actions: Don't reference clk_init_data after registration The analysis is as f

Re: linux-next: manual merge of the gpio-brgl tree with the gpio tree

2019-08-16 Thread Linus Walleij
On Fri, Aug 16, 2019 at 8:56 AM Stephen Rothwell wrote: > Today's linux-next merge of the gpio-brgl tree got a conflict in: > > include/linux/gpio/driver.h > > between commit: > > fdd61a013a24 ("gpio: Add support for hierarchical IRQ domains") > > from the gpio tree and commit: > > 9091373a

Re: [PATCH] gpio: of: fix Freescale SPI CS quirk handling

2019-08-16 Thread Linus Walleij
On Fri, Aug 16, 2019 at 6:50 PM Andreas Kemnade wrote: > On the gta04 we see: > spi_gpio: probe of spi_lcd failed with error -2 > > The quirk introduced in > commit e3023bf80639 ("gpio: of: Handle the Freescale SPI CS") > can also be triggered by a temporary -EPROBE_DEFER and > so "convert" it to

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-16 Thread Valentin Schneider
On 16/08/2019 21:57, Joel Fernandes wrote: >> Can we finally put a foot down and tell compiler and standard committee >> people to stop this insanity? > > Sure, or could the compilers provide flags which prevent such optimization > similar to -O* flags? > How would you differentiate optimization

Re: linux-next: build failure after merge of the gpio tree

2019-08-16 Thread Linus Walleij
On Fri, Aug 16, 2019 at 1:38 PM Stephen Rothwell wrote: > After merging the gpio tree, today's linux-next build (powerpc > ppc44x_defconfig) failed like this: Oops! > I have applied the following patch for today: > > From: Stephen Rothwell > Date: Fri, 16 Aug 2019 21:29:30 +1000 > Subject: [PA

NEED YOUR ASSIST PLEASE

2019-08-16 Thread Mrs Ann Johnson
Hello My name Mrs. Ann Johnson from UK,I am a dying woman who had decided to donate what I have left to you. I am 59 years old and was diagnosed of ovarian cancer about 2 years ago immediately after the death of my husband, who had left me with everything he worked for. I have decided to dona

  1   2   3   4   5   6   7   8   9   >