Re: [RFC 1/5] media: dt-bindings: Document 'location' property

2019-08-14 Thread Sakari Ailus
Hi Jacopo, On Wed, Aug 14, 2019 at 10:28:11PM +0200, Jacopo Mondi wrote: > Add the 'location' device property, used to specify the camera device > mounting position. The property is particularly meaningful for mobile > devices with a well defined usage orientation. > > Signed-off-by: Jacopo Mondi

Re: [PATCH] Fix a stack buffer overflow bug check_input_term

2019-08-14 Thread Takashi Iwai
On Thu, 15 Aug 2019 08:13:57 +0200, Takashi Iwai wrote: > > On Thu, 15 Aug 2019 06:35:49 +0200, > Hui Peng wrote: > > > > `check_input_term` recursively calls itself with input > > from device side (e.g., uac_input_terminal_descriptor.bCSourceID) > > as argument (id). In `check_input_term`, if `c

[GIT PULL] tee subsys for v5.4

2019-08-14 Thread Jens Wiklander
Hello arm-soc maintainers, Please pull this OP-TEE driver patch. It adds a call to might_sleep() during RPC in the OP-TEE driver in order to be more friendly with CONFIG_PREEMPT_VOLUNTARY. Thanks, Jens The following changes since commit 0ecfebd2b52404ae0c54a878c872bb93363ada36: Linux 5.2 (201

Re: [PATCH] netfilter: nft_bitwise: Adjust parentheses to fix memcmp size argument

2019-08-14 Thread Joe Perches
On Wed, 2019-08-14 at 09:58 -0700, Nathan Chancellor wrote: > clang warns: > > net/netfilter/nft_bitwise.c:138:50: error: size argument in 'memcmp' > call is a comparison [-Werror,-Wmemsize-comparison] > if (memcmp(&priv->xor, &zero, sizeof(priv->xor) || >

Re: [PATCH 4/6] powerpc: Chunk calls to flush_dcache_range in arch_*_memory

2019-08-14 Thread Mike Rapoport
On Thu, Aug 15, 2019 at 02:10:49PM +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > When presented with large amounts of memory being hotplugged > (in my test case, ~890GB), the call to flush_dcache_range takes > a while (~50 seconds), triggering RCU stalls. > > This patch breaks up t

Re: [PATCH] Bluetooth: hci_qca: Make structure qca_proto constant

2019-08-14 Thread Marcel Holtmann
Hi Nishka, > Static structure qca_proto, of type hci_uart_proto, is used four times: > as the last argument in function hci_uart_register_device(), and as the > only argument to functions hci_uart_register_proto() and > hci_uart_unregister_proto(). In all three of these functions, the > parameter

Re: [PATCH] Bluetooth: 6lowpan: Make variable header_ops constant

2019-08-14 Thread Marcel Holtmann
Hi Nishka, > Static variable header_ops, of type header_ops, is used only once, when > it is assigned to field header_ops of a variable having type net_device. > This corresponding field is declared as const in the definition of > net_device. Hence make header_ops constant as well to protect it fr

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-14 Thread Arnd Bergmann
On Wed, Aug 14, 2019 at 11:39 PM Dave Chinner wrote: > > case XFS_IOC_BULKSTAT: > > case XFS_IOC_INUMBERS: > > - return xfs_file_ioctl(filp, cmd, p); > > + return xfs_file_ioctl(filp, cmd, (unsigned long)arg); > > I don't really like having to sprinkle special c

Re: [PATCH v3 11/16] powerpc/pseries/svm: Export guest SVM status to user space via sysfs

2019-08-14 Thread Michael Ellerman
Thiago Jung Bauermann writes: > Michael Ellerman writes: >> Thiago Jung Bauermann writes: >>> From: Ryan Grimm >>> User space might want to know it's running in a secure VM. It can't do >>> a mfmsr because mfmsr is a privileged instruction. >>> >>> The solution here is to create a cpu attribut

Re: [PATCH] mm/oom: Add killed process selection information

2019-08-14 Thread Edward Chron
On Mon, Aug 12, 2019 at 4:42 AM Michal Hocko wrote: > > On Fri 09-08-19 15:15:18, Edward Chron wrote: > [...] > > So it is optimal if you only have to go and find the correct log and search > > or run your script(s) when you absolutely need to, not on every OOM event. > > OK, understood. > > > Tha

Re: [PATCH v3 2/2] pwm: sprd: Add Spreadtrum PWM support

2019-08-14 Thread Uwe Kleine-König
Hello Baolin, On Thu, Aug 15, 2019 at 11:34:27AM +0800, Baolin Wang wrote: > On Wed, 14 Aug 2019 at 23:03, Uwe Kleine-König > wrote: > > > > On Wed, Aug 14, 2019 at 08:46:11PM +0800, Baolin Wang wrote: > > > > + > > > + /* > > > + * The hardware provides a counter that is feed by the so

Re: [PATCH] Fix a stack buffer overflow bug check_input_term

2019-08-14 Thread Takashi Iwai
On Thu, 15 Aug 2019 06:35:49 +0200, Hui Peng wrote: > > `check_input_term` recursively calls itself with input > from device side (e.g., uac_input_terminal_descriptor.bCSourceID) > as argument (id). In `check_input_term`, if `check_input_term` > is called with the same `id` argument as the caller,

[PATCH] mm/oom: Add killed process selection information

2019-08-14 Thread Edward Chron
For an OOM event: print oom_score_adj value for the OOM Killed process to document what the oom score adjust value was at the time the process at the time of the OOM event. The value can be set by the user and it effects the resulting oom_score so useful to document this value. Sample message outp

[PATCH] bus: arm-cci: Add of_node_put() before break

2019-08-14 Thread Nishka Dasgupta
Each iteration of for_each_child_of_node puts the previous node, but in the case of a break from the middle of the loop, there is no put, thus causing a memory leak. Add an of_node_put before the break. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/bus/arm-cci.c | 4 +++

[PATCH] ata: libahci_platform: Add of_node_put() before loop exit

2019-08-14 Thread Nishka Dasgupta
Each iteration of for_each_child_of_node puts the previous node, but in the case of a goto from the middle of the loop, there is no put, thus causing a memory leak. Add an of_node_put before three such goto statements. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/ata/l

[PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant

2019-08-14 Thread Nishka Dasgupta
Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only when it is assigned to constant field algo of a variable having type i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it const as well to protect it from unintended modification. Issue found with Coccinelle. S

Re: [RFC PATCH 1/5] x86: tsc: add tsc to art helpers

2019-08-14 Thread Felipe Balbi
Hi, Thomas Gleixner writes: > Felipe, > > On Tue, 16 Jul 2019, Felipe Balbi wrote: > > -ENOCHANGELOG > > As you said in the cover letter: > >> (3) The change in arch/x86/kernel/tsc.c needs to be reviewed at length >> before going in. > > So some information what those interfaces are use

[PATCH] Bluetooth: 6lowpan: Make variable header_ops constant

2019-08-14 Thread Nishka Dasgupta
Static variable header_ops, of type header_ops, is used only once, when it is assigned to field header_ops of a variable having type net_device. This corresponding field is declared as const in the definition of net_device. Hence make header_ops constant as well to protect it from unnecessary modif

[PATCH] Bluetooth: hci_qca: Make structure qca_proto constant

2019-08-14 Thread Nishka Dasgupta
Static structure qca_proto, of type hci_uart_proto, is used four times: as the last argument in function hci_uart_register_device(), and as the only argument to functions hci_uart_register_proto() and hci_uart_unregister_proto(). In all three of these functions, the parameter corresponding to qca_p

Re: [PATCH] lsilogic mpt fusion: mptctl: Fixed race condition around mptctl_id variable using mutexes

2019-08-14 Thread kbuild test robot
Hi Mark, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.3-rc4 next-20190814] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[PATCH v4] bus: ti-sysc: Change return types of functions

2019-08-14 Thread Nishka Dasgupta
Change return type of functions sysc_check_one_child() and sysc_check_children() from int to void as neither ever returns an error. Modify call sites of both functions accordingly. Signed-off-by: Nishka Dasgupta --- Changes in v4: - Merge into a single patch the two patches for sysc_check_one_chi

[PATCH v2 2/2] iommu/arm-smmu-v3: add nr_ats_masters for quickly check

2019-08-14 Thread Zhen Lei
When (smmu_domain->smmu->features & ARM_SMMU_FEAT_ATS) is true, even if a smmu domain does not contain any ats master, the operations of arm_smmu_atc_inv_to_cmd() and lock protection in arm_smmu_atc_inv_domain() are always executed. This will impact performance, especially in multi-core and stress

[PATCH v4 0/2] mm,thp: Add filemap_huge_fault() for THP

2019-08-14 Thread William Kucharski
This set of patches is the first step towards a mechanism for automatically mapping read-only text areas of appropriate size and alignment to THPs whenever possible. For now, the central routine, filemap_huge_fault(), amd various support routines are only included if the experimental kernel config

[PATCH v4 1/2] mm: Allow the page cache to allocate large pages

2019-08-14 Thread William Kucharski
Add an 'order' argument to __page_cache_alloc() and do_read_cache_page(). Ensure the allocated pages are compound pages. Signed-off-by: Matthew Wilcox (Oracle) Signed-off-by: William Kucharski Reported-by: kbuild test robot --- fs/afs/dir.c| 2 +- fs/btrfs/compression.c | 2 +-

[PATCH v4 2/2] mm,thp: Add experimental config option RO_EXEC_FILEMAP_HUGE_FAULT_THP

2019-08-14 Thread William Kucharski
Add filemap_huge_fault() to attempt to satisfy page faults on memory-mapped read-only text pages using THP when possible. Signed-off-by: William Kucharski --- include/linux/mm.h | 2 + mm/Kconfig | 15 ++ mm/filemap.c | 337 +++-- mm/huge_

Re: [PATCH] PCI: dwc: Add map irq callback

2019-08-14 Thread Dilip Kota
On 8/14/2019 6:59 PM, Christoph Hellwig wrote: On Wed, Aug 14, 2019 at 04:31:14PM +0800, Dilip Kota wrote: callback. pp->map_irq() must assign the callback along with the platform specific configuration. In Intel PCIe driver pp->map_irq() does the same. (Driver is not yet present in mainline,

Re: [PATCH v5 1/2] dt-bindings: mmc: Document Aspeed SD controller

2019-08-14 Thread Andrew Jeffery
On Thu, 15 Aug 2019, at 15:06, Joel Stanley wrote: > On Wed, 7 Aug 2019 at 00:38, Andrew Jeffery wrote: > > > > The ASPEED SD/SDIO/MMC controller exposes two slots implementing the > > SDIO Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit > > data bus if only a single slot is e

[PATCH v2] regulator: core: Add label to collate of_node_put() statements

2019-08-14 Thread Nishka Dasgupta
In function of_get_child_regulator(), the loop for_each_child_of_node() contains two mid-loop return statements, each preceded by a statement putting child. In order to reduce this repetition, create a new label, err_node_put, that puts child and then returns the required value; edit the mid-loop r

Re: [PATCH v5 1/2] dt-bindings: mmc: Document Aspeed SD controller

2019-08-14 Thread Joel Stanley
On Wed, 7 Aug 2019 at 00:38, Andrew Jeffery wrote: > > The ASPEED SD/SDIO/MMC controller exposes two slots implementing the > SDIO Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit > data bus if only a single slot is enabled. > > Signed-off-by: Andrew Jeffery Reviewed-by: Joel St

Re: [PATCH v5 2/2] mmc: Add support for the ASPEED SD controller

2019-08-14 Thread Joel Stanley
On Wed, 7 Aug 2019 at 00:38, Andrew Jeffery wrote: > > Add a minimal driver for ASPEED's SD controller, which exposes two > SDHCIs. > > The ASPEED design implements a common register set for the SDHCIs, and > moves some of the standard configuration elements out to this common > area (e.g. 8-bit m

Re: [PATCH v5 5/7] PCI/ATS: Add PASID support for PCIe VF devices

2019-08-14 Thread Bjorn Helgaas
On Tue, Aug 13, 2019 at 03:19:58PM -0700, Kuppuswamy Sathyanarayanan wrote: > On Mon, Aug 12, 2019 at 03:05:08PM -0500, Bjorn Helgaas wrote: > > On Thu, Aug 01, 2019 at 05:06:02PM -0700, > > sathyanarayanan.kuppusw...@linux.intel.com wrote: > > > From: Kuppuswamy Sathyanarayanan > > > > > > > >

Re: [PATCH] x86/apic: Handle missing global clockevent gracefully

2019-08-14 Thread Daniel Drake
On Mon, Aug 12, 2019 at 2:16 PM Daniel Drake wrote: > I can do a bit of testing on other platforms too. Are there any > specific tests I should run, other than checking that the system boots > and doesn't have any timer watchdog complaints in the log? Tested this on 2 AMD platforms that were not

Re: [PATCH v5 3/7] PCI/ATS: Initialize PASID in pci_ats_init()

2019-08-14 Thread Bjorn Helgaas
On Thu, Aug 01, 2019 at 05:06:00PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > Currently, PASID Capability checks are repeated across all PASID API's. > Instead, cache the capability check result in pci_pasid_init() and use > it in other PASID

[PATCH] powerpc: Allow flush_(inval_)dcache_range to work across ranges >4GB

2019-08-14 Thread Alastair D'Silva
From: Alastair D'Silva Heads Up: This patch cannot be submitted to Linus's tree, as the affected assembler functions have already been converted to C. When calling flush_(inval_)dcache_range with a size >4GB, we were masking off the upper 32 bits, so we would incorrectly flush a range smaller th

Re: [RESEND PATCH 1/2 -mm] mm: account lazy free pages separately

2019-08-14 Thread Yang Shi
On 8/14/19 5:55 AM, Vlastimil Babka wrote: On 8/12/19 7:00 PM, Yang Shi wrote: I can see that memcg rss size was the primary problem David was looking at. But MemAvailable will not help with that, right? Moreover is Yes, but David actually would like to have memcg MemAvailable (the accounter

Re: [RESEND PATCH 1/2 -mm] mm: account lazy free pages separately

2019-08-14 Thread Yang Shi
On 8/14/19 5:49 AM, Vlastimil Babka wrote: On 8/9/19 8:26 PM, Yang Shi wrote: Here the new counter is introduced for patch 2/2 to account deferred split THPs into available memory since NR_ANON_THPS may contain non-deferred split THPs. I could use an internal counter for deferred split THPs,

Re: [RESEND PATCH 1/2 -mm] mm: account lazy free pages separately

2019-08-14 Thread Yang Shi
On 8/14/19 4:08 AM, Michal Hocko wrote: On Mon 12-08-19 10:00:17, Yang Shi wrote: On 8/12/19 2:34 AM, Michal Hocko wrote: On Fri 09-08-19 16:54:43, Yang Shi wrote: On 8/9/19 11:26 AM, Yang Shi wrote: On 8/9/19 11:02 AM, Michal Hocko wrote: [...] I have to study the code some more but is

Re: [PATCH v5 3/7] PCI/ATS: Initialize PASID in pci_ats_init()

2019-08-14 Thread Bjorn Helgaas
On Thu, Aug 01, 2019 at 05:06:00PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > Currently, PASID Capability checks are repeated across all PASID API's. > Instead, cache the capability check result in pci_pasid_init() and use > it in other PASID

Re: [PATCH] Fix a stack buffer overflow bug check_input_term

2019-08-14 Thread Hui Peng
The stack trace differs from test to test, the attached trace1 file is taken from one of the tests. The bug is confirmed by adding some printk statement in `check_input_term`, the trace with output of printk is attached in trace2 file. This patch is a tentative fix to the bug, please give me feed

RE: [EXT] Re: [v1 1/3] clk: ls1028a: Add clock driver for Display output interface

2019-08-14 Thread Wen He
> -Original Message- > From: Stephen Boyd > Sent: 2019年8月15日 1:27 > To: linux-...@vger.kernel.org; linux-de...@linux.nxdi.nxp.com; > linux-kernel@vger.kernel.org; liviu.du...@arm.com; Leo Li > ; Michael Turquette ; Wen > He > Subject: RE: [EXT] Re: [v1 1/3] clk: ls1028a: Add clock drive

Re: [PATCH v5 2/7] PCI/ATS: Initialize PRI in pci_ats_init()

2019-08-14 Thread Bjorn Helgaas
On Thu, Aug 01, 2019 at 05:05:59PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > Currently, PRI Capability checks are repeated across all PRI API's. > Instead, cache the capability check result in pci_pri_init() and use it > in other PRI API's. A

[PATCH] Fix a stack buffer overflow bug check_input_term

2019-08-14 Thread Hui Peng
`check_input_term` recursively calls itself with input from device side (e.g., uac_input_terminal_descriptor.bCSourceID) as argument (id). In `check_input_term`, if `check_input_term` is called with the same `id` argument as the caller, it triggers endless recursive call, resulting kernel space sta

[PATCH] clk: composite: Drop unused clk.h include

2019-08-14 Thread Stephen Boyd
This include isn't used. Drop it. Signed-off-by: Stephen Boyd --- drivers/clk/clk-composite.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c index b06038b8f658..4f13a681ddfc 100644 --- a/drivers/clk/clk-composite.c +++ b/drivers/clk/c

RE: [EXT] Re: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

2019-08-14 Thread Biwen Li
> Caution: EXT Email > > Hi, > > On 14/08/2019 17:32:49+0800, Biwen Li wrote: > > Issue: > > # hwclock -w > > hwclock: RTC_SET_TIME: Invalid argument > > > > The patch fixes error when run command hwclock -w with rtc > > pcf85363/pcf85263 > > > > Could you describe a bit more the issue a

RE: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

2019-08-14 Thread Biwen Li
> > Subject: rtc: pcf85363/pcf85263: fix error that failed to run hwclock > > -w > > > > Issue: > > # hwclock -w > > hwclock: RTC_SET_TIME: Invalid argument > > > > The patch fixes error when run command hwclock -w with rtc > > pcf85363/pcf85263 > > Can you explain a little bit more in the

[PATCH 0/6] powerpc: convert cache asm to C

2019-08-14 Thread Alastair D'Silva
From: Alastair D'Silva This series addresses a few issues discovered in how we flush caches: 1. Flushes were truncated at 4GB, so larger flushes were incorrect. 2. Flushing the dcache in arch_add_memory was unnecessary This series also converts much of the cache assembler to C, with the aim of m

[PATCH 6/6] powerpc: Don't flush caches when adding memory

2019-08-14 Thread Alastair D'Silva
From: Alastair D'Silva This operation takes a significant amount of time when hotplugging large amounts of memory (~50 seconds with 890GB of persistent memory). This was orignally in commit fb5924fddf9e ("powerpc/mm: Flush cache on memory hot(un)plug") to support memtrace, but the flush on add i

[PATCH 5/6] powerpc: Remove 'extern' from func prototypes in cache headers

2019-08-14 Thread Alastair D'Silva
From: Alastair D'Silva The 'extern' keyword does not value-add for function prototypes. Signed-off-by: Alastair D'Silva --- arch/powerpc/include/asm/cache.h | 8 arch/powerpc/include/asm/cacheflush.h | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/

[PATCH 3/6] powerpc: Convert flush_icache_range & friends to C

2019-08-14 Thread Alastair D'Silva
From: Alastair D'Silva Similar to commit 22e9c88d486a ("powerpc/64: reuse PPC32 static inline flush_dcache_range()") this patch converts flush_icache_range() to C, and reimplements the following functions as wrappers around it: __flush_dcache_icache __flush_dcache_icache_phys This was done as we

[PATCH 4/6] powerpc: Chunk calls to flush_dcache_range in arch_*_memory

2019-08-14 Thread Alastair D'Silva
From: Alastair D'Silva When presented with large amounts of memory being hotplugged (in my test case, ~890GB), the call to flush_dcache_range takes a while (~50 seconds), triggering RCU stalls. This patch breaks up the call into 16GB chunks, calling cond_resched() inbetween to allow the schedule

[PATCH 2/6] powerpc: define helpers to get L1 icache sizes

2019-08-14 Thread Alastair D'Silva
From: Alastair D'Silva This patch adds helpers to retrieve icache sizes, and renames the existing helpers to make it clear that they are for dcache. Signed-off-by: Alastair D'Silva --- arch/powerpc/include/asm/cache.h | 29 +++ arch/powerpc/include/asm/cacheflush.h

[PATCH 1/6] powerpc: Allow flush_icache_range to work across ranges >4GB

2019-08-14 Thread Alastair D'Silva
From: Alastair D'Silva When calling flush_icache_range with a size >4GB, we were masking off the upper 32 bits, so we would incorrectly flush a range smaller than intended. This patch replaces the 32 bit shifts with 64 bit ones, so that the full size is accounted for. Signed-off-by: Alastair D'

[PATCH] clk: sunxi: Don't call clk_hw_get_name() on a hw that isn't registered

2019-08-14 Thread Stephen Boyd
The implementation of clk_hw_get_name() relies on the clk_core associated with the clk_hw pointer existing. If of_clk_hw_register() fails, there isn't a clk_core created yet, so calling clk_hw_get_name() here fails. Extract the name first so we can print it later. Fixes: 1d80c14248d6 ("clk: sunxi-

Re: [PATCH] KVM: LAPIC: Periodically revaluate appropriate lapic_timer_advance_ns

2019-08-14 Thread Wanpeng Li
On Wed, 14 Aug 2019 at 20:50, Paolo Bonzini wrote: > > On 12/08/19 11:06, Wanpeng Li wrote: > > On Fri, 9 Aug 2019 at 18:24, Paolo Bonzini wrote: > >> > >> On 09/08/19 07:45, Wanpeng Li wrote: > >>> From: Wanpeng Li > >>> > >>> Even if for realtime CPUs, cache line bounces, frequency scaling, pr

[PATCH v2] KVM: LAPIC: Periodically revaluate to get conservative lapic_timer_advance_ns

2019-08-14 Thread Wanpeng Li
From: Wanpeng Li Even if for realtime CPUs, cache line bounces, frequency scaling, presence of higher-priority RT tasks, etc can still cause different response. These interferences should be considered and periodically revaluate whether or not the lapic_timer_advance_ns value is the best, do n

Re: clk/clk-next boot bisection: v5.3-rc1-79-g31f58d2f58cb on sun8i-h3-libretech-all-h3-cc

2019-08-14 Thread Stephen Boyd
Quoting kernelci.org bot (2019-08-14 20:35:25) > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > * This automated bisection report was sent to you on the basis * > * that you may be involved with the breaking commit it has * > * found. No manual investigation has been don

[PATCH] perf vendor events intel: Add Tremontx event file v1.02

2019-08-14 Thread Haiyan Song
Add a Intel event file for perf. Signed-off-by: Haiyan Song --- tools/perf/pmu-events/arch/x86/mapfile.csv | 1 + tools/perf/pmu-events/arch/x86/tremontx/cache.json | 111 ++ .../pmu-events/arch/x86/tremontx/frontend.json | 26 ++ .../perf/pmu-events/arch/x86/tremontx/memory.j

Re: [5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra

2019-08-14 Thread Bart Van Assche
On 8/14/19 10:18 AM, Abdul Haleem wrote: On Wed, 2019-08-14 at 10:05 -0700, Bart Van Assche wrote: On 8/14/19 9:52 AM, Abdul Haleem wrote: Greeting's Today's linux-next kernel (5.3.0-rc4-next-20190813) booted with warning on my powerpc power 8 lpar The WARN_ON_ONCE() was introduced by commi

[PATCH v5] arm64: dts: ls1028a: Add esdhc node in dts

2019-08-14 Thread Yinbo Zhu
From: Ashish Kumar This patch is to add esdhc node and enable SD UHS-I, eMMC HS200 for ls1028ardb/ls1028aqds board. Signed-off-by: Ashish Kumar Signed-off-by: Yangbo Lu Signed-off-by: Yinbo Zhu --- Change in v5: Fix indent. arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts |

clk/clk-next boot bisection: v5.3-rc1-79-g31f58d2f58cb on sun8i-h3-libretech-all-h3-cc

2019-08-14 Thread kernelci.org bot
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem

Re: [PATCH v3 2/2] pwm: sprd: Add Spreadtrum PWM support

2019-08-14 Thread Baolin Wang
Hi Uwe, On Wed, 14 Aug 2019 at 23:03, Uwe Kleine-König wrote: > > On Wed, Aug 14, 2019 at 08:46:11PM +0800, Baolin Wang wrote: > > + > > + /* > > + * The hardware provides a counter that is feed by the source clock. > > + * The period length is (PRESCALE + 1) * MOD counter steps. >

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-14 Thread Jason Wang
On 2019/8/14 上午12:41, Christoph Hellwig wrote: On Tue, Aug 13, 2019 at 08:57:07AM -0300, Jason Gunthorpe wrote: On Tue, Aug 13, 2019 at 04:31:07PM +0800, Jason Wang wrote: What kind of issues do you see? Spinlock is to synchronize GUP with MMU notifier in this series. A GUP that can't sleep

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-14 Thread Jason Wang
On 2019/8/13 下午7:57, Jason Gunthorpe wrote: On Tue, Aug 13, 2019 at 04:31:07PM +0800, Jason Wang wrote: What kind of issues do you see? Spinlock is to synchronize GUP with MMU notifier in this series. A GUP that can't sleep can't pagefault which makes it a really weird pattern My understa

Re: [PATCH] virtio-net: lower min ring num_free for efficiency

2019-08-14 Thread Jason Wang
On 2019/8/15 上午11:11, 冉 jiang wrote: On 2019/8/15 11:01, Jason Wang wrote: On 2019/8/14 上午10:06, ? jiang wrote: This change lowers ring buffer reclaim threshold from 1/2*queue to budget for better performance. According to our test with qemu + dpdk, packet dropping happens when the guest is n

[PATCH] arm64: dts: imx8mn: Add gpio-ranges property

2019-08-14 Thread Anson . Huang
From: Anson Huang Add "gpio-ranges" property to establish connections between GPIOs and PINs on i.MX8MN pinctrl driver. Signed-off-by: Anson Huang --- arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b

Re: [PATCH] sh: Drop -Werror from kernel Makefile

2019-08-14 Thread Guenter Roeck
On 8/14/19 5:59 PM, Gustavo A. R. Silva wrote: Guenter, On 8/13/19 8:18 AM, Guenter Roeck wrote: Please note that _mainline_ builds are currently broken. This should be fixed now: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=41de59634046b19cd53a1983594a9513

Re: [PATCH 1/2] riscv: Add memmove string operation.

2019-08-14 Thread Nick Hu
Hi Paul, On Wed, Aug 14, 2019 at 10:03:39AM -0700, Paul Walmsley wrote: > Hi Nick, > > On Wed, 14 Aug 2019, Nick Hu wrote: > > > On Wed, Aug 14, 2019 at 10:22:15AM +0800, Paul Walmsley wrote: > > > On Tue, 13 Aug 2019, Palmer Dabbelt wrote: > > > > > > > On Mon, 12 Aug 2019 08:04:46 PDT (-0700)

Re: [PATCH] nbd: add a missed nbd_config_put() in nbd_xmit_timeout()

2019-08-14 Thread Mike Christie
Josef had ackd my patch for the same thing here: https://www.spinics.net/lists/linux-block/msg43800.html so maybe Jens will pick that up with the rest of the set Josef had acked: https://www.spinics.net/lists/linux-block/msg43809.html to make it easier. On 08/14/2019 08:27 PM, sunke (E) wrote:

Re: [PATCH] cxgb4: fix a memory leak bug

2019-08-14 Thread David Miller
From: Wenwen Wang Date: Tue, 13 Aug 2019 04:18:52 -0500 > In blocked_fl_write(), 't' is not deallocated if bitmap_parse_user() fails, > leading to a memory leak bug. To fix this issue, free t before returning > the error. > > Signed-off-by: Wenwen Wang Applied.

Re: [RFC PATCH 2/2] mm/gup: introduce vaddr_pin_pages_remote()

2019-08-14 Thread John Hubbard
On 8/14/19 5:02 PM, John Hubbard wrote: On 8/14/19 4:50 PM, Ira Weiny wrote: On Tue, Aug 13, 2019 at 05:56:31PM -0700, John Hubbard wrote: On 8/13/19 5:51 PM, John Hubbard wrote: On 8/13/19 2:08 PM, Ira Weiny wrote: On Mon, Aug 12, 2019 at 05:07:32PM -0700, John Hubbard wrote: On 8/12/19 4:4

Re: [PATCH] virtio-net: lower min ring num_free for efficiency

2019-08-14 Thread Jason Wang
On 2019/8/14 上午10:06, ? jiang wrote: This change lowers ring buffer reclaim threshold from 1/2*queue to budget for better performance. According to our test with qemu + dpdk, packet dropping happens when the guest is not able to provide free buffer in avail ring timely with default 1/2*queue. T

[PATCH] arm: dts: rockchip: fix vcc_host_5v regulator for usb3 host

2019-08-14 Thread Kever Yang
According to rock64 schemetic V2 and V3, the VCC_HOST_5V output is controlled by USB_20_HOST_DRV, which is the same as VCC_HOST1_5V. Signed-off-by: Kever Yang --- arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/arch/a

Re: [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly.

2019-08-14 Thread Vincent Chen
On Thu, Aug 15, 2019 at 6:17 AM Andreas Schwab wrote: > > On Aug 14 2019, Palmer Dabbelt wrote: > > > On Wed, 14 Aug 2019 13:32:50 PDT (-0700), Paul Walmsley wrote: > >> On Wed, 14 Aug 2019, Vincent Chen wrote: > >> > >>> Make the __fstate_clean() function correctly set the > >>> state of sstatus

Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang

2019-08-14 Thread Joe Perches
On Tue, 2019-08-13 at 14:44 +0200, Miguel Ojeda wrote: > Hm... I would go for either __fallthrough as the rest of attributes, > or simply fallthrough -- FALLTHROUGH seems wrong. If you want it that > way for visibility, then I would choose __fallthrough, since the > underscores are quite prominent

Re: [PATCH] x86/fixmap: update stale comments

2019-08-14 Thread Cao jin
Hi, Wish to know whether the patch make sense. On 8/9/19 7:46 PM, Cao jin wrote: > Signed-off-by: Cao jin > --- > arch/x86/include/asm/fixmap.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h > index 9

Re: [PATCH V3 4/4] dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192

2019-08-14 Thread Rob Herring
On Wed, Aug 14, 2019 at 1:32 AM Mircea Caprioru wrote: > > This patch add device tree binding documentation for AD7192 adc in YAML > format. > > Signed-off-by: Mircea Caprioru > --- > Changelog V2: > - remove description from spi and interrupt properties > - changed the name of the device from ad

[PATCH] afs: Move comments after /* fallthrough */

2019-08-14 Thread Joe Perches
Make the code a bit easier for a script to appropriately convert case statement blocks with /* fallthrough */ comments to a macro by moving comments describing the next case block to the case statement. Signed-off-by: Joe Perches --- fs/afs/cmservice.c | 10 +++--- fs/afs/fsclient.c | 51 ++

[GIT PULL] Devicetree fixes for 5.3-rc, take 3

2019-08-14 Thread Rob Herring
Linus, Please pull DT fixes for 5.3. Rob The following changes since commit 609488bc979f99f805f34e9a32c1e3b71179d10b: Linux 5.3-rc2 (2019-07-28 12:47:02 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git tags/devicetree-fixes-for-5.

Re: [PATCH] scsi: fnic: remove redundant assignment of variable rc

2019-08-14 Thread Martin K. Petersen
Colin, > Variable ret is initialized to a value that is never read and it is > re-assigned later and immediatetly returns. Clean up the code by > removing rc and just returning 0. Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] of: irq: fix a trivial typo in a doc comment

2019-08-14 Thread Rob Herring
On Wed, 7 Aug 2019 15:22:31 +0200, Lubomir Rintel wrote: > Diverged from what the code does with commit 530210c7814e ("of/irq: Replace > of_irq with of_phandle_args"). > > Signed-off-by: Lubomir Rintel > --- > drivers/of/irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied,

Re: [PATCH] scsi: ufs: Fix NULL pointer dereference in ufshcd_config_vreg_hpm()

2019-08-14 Thread Martin K. Petersen
Adrian, > Fix the following BUG: > > [ 187.065689] BUG: kernel NULL pointer dereference, address: > 001c > [ 187.065790] RIP: 0010:ufshcd_vreg_set_hpm+0x3c/0x110 [ufshcd_core] > [ 187.065938] Call Trace: > [ 187.065959] ufshcd_resume+0x72/0x290 [ufshcd_core] > [ 187.065980

Re: [PATCH v2] psi: get poll_work to run when calling poll syscall next time

2019-08-14 Thread Jason Xing
Hello, It's been delayed for no reason a couple of days. Any comments and suggestions on this patch V2 would be appreciated. Thanks, Jason On 2019/7/30 下午1:16, Jason Xing wrote: Only when calling the poll syscall the first time can user receive POLLPRI correctly. After that, user always fail

Re: [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly.

2019-08-14 Thread Palmer Dabbelt
On Wed, 14 Aug 2019 15:17:18 PDT (-0700), sch...@linux-m68k.org wrote: On Aug 14 2019, Palmer Dabbelt wrote: On Wed, 14 Aug 2019 13:32:50 PDT (-0700), Paul Walmsley wrote: On Wed, 14 Aug 2019, Vincent Chen wrote: Make the __fstate_clean() function correctly set the state of sstatus.FS in pt

Re: [PATCH 5.2 000/144] 5.2.9-stable review

2019-08-14 Thread Naresh Kamboju
On Wed, 14 Aug 2019 at 22:33, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.2.9 release. > There are 144 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Resp

[PATCH 3/3] libnvdimm/security: Consolidate 'security' operations

2019-08-14 Thread Dan Williams
The security operations are exported from libnvdimm/security.c to libnvdimm/dimm_devs.c, and libnvdimm/security.c is optionally compiled based on the CONFIG_NVDIMM_KEYS config symbol. Rather than export the operations across compile objects, just move the __security_store() entry point to live wit

[PATCH 1/3] libnvdimm/security: Introduce a 'frozen' attribute

2019-08-14 Thread Dan Williams
In the process of debugging a system with an NVDIMM that was failing to unlock it was found that the kernel is reporting 'locked' while the DIMM security interface is 'frozen'. Unfortunately the security state is tracked internally as an enum which prevents it from communicating the difference betw

[PATCH 2/3] libnvdimm/security: Tighten scope of nvdimm->busy vs security operations

2019-08-14 Thread Dan Williams
The blanket blocking of all security operations while the DIMM is in active use in a region is too restrictive. The only security operations that need to be aware of the ->busy state are those that mutate the state of data, i.e. erase and overwrite. Refactor the ->busy checks to be applied at the

[PATCH 0/3] libnvdimm/security: Enumerate the frozen state and other cleanups

2019-08-14 Thread Dan Williams
Jeff reported a scenario where ndctl was failing to unlock DIMMs [1]. Through the course of debug it was discovered that the security interface on the DIMMs was in the 'frozen' state disallowing unlock, or any security operation. Unfortunately the kernel only showed that the DIMMs were 'locked', n

Re: [PATCH 4.19 00/91] 4.19.67-stable review

2019-08-14 Thread Naresh Kamboju
On Wed, 14 Aug 2019 at 22:38, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.67 release. > There are 91 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Res

Re: WARNING in cgroup_rstat_updated

2019-08-14 Thread syzbot
syzbot has bisected this bug to: commit e9db4ef6bf4ca9894bb324c76e01b8f1a16b2650 Author: John Fastabend Date: Sat Jun 30 13:17:47 2018 + bpf: sockhash fix omitted bucket lock in sock_close bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=143286e260 start commit: 31c

Re: [PATCH 4.14 00/69] 4.14.139-stable review

2019-08-14 Thread Naresh Kamboju
On Wed, 14 Aug 2019 at 22:42, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.139 release. > There are 69 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Re

CONFIRM AND ACKNOWLEDGE

2019-08-14 Thread Reese Bechnam
Good day, I write you today with optimism regarding a discussion that will benefit us both immensely I am Reese Bechnam. LLB (Hons). Head Attorney with Clifford Bryant Solicitors, Miami, FL and I got your information from the International directory here in Miami and after extensive rese

Re: [PATCH] sh: Drop -Werror from kernel Makefile

2019-08-14 Thread Gustavo A. R. Silva
Guenter, On 8/13/19 8:18 AM, Guenter Roeck wrote: > > Please note that _mainline_ builds are currently broken. > This should be fixed now: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=41de59634046b19cd53a1983594a95135c656997 Thanks -- Gustavo

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2019-08-14 Thread Helen Koike
Hi Sakari, Thanks for your review. I just have some comments/questions below. On 8/8/19 6:14 AM, Sakari Ailus wrote: > Hi Helen, > > On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote: >> From: Jacob Chen >> >> Add the subdev driver for rockchip isp1. >> >> Signed-off-by: Jacob Chen >

RE: [PATCH] scsi: fnic: remove redundant assignment of variable rc

2019-08-14 Thread Karan Tilak Kumar (kartilak)
Acked-by: Karan Tilak Kumar -Original Message- From: Colin King Sent: Tuesday, August 13, 2019 6:24 AM To: Satish Kharat (satishkh) ; Sesidhar Baddela (sebaddel) ; Karan Tilak Kumar (kartilak) ; James E . J . Bottomley ; Martin K . Petersen ; linux-s...@vger.kernel.org Cc: kernel

[PATCH v10 5/7] powerpc/memcpy: Add memcpy_mcsafe for pmem

2019-08-14 Thread Santosh Sivaraj
From: Balbir Singh The pmem infrastructure uses memcpy_mcsafe in the pmem layer so as to convert machine check exceptions into a return value on failure in case a machine check exception is encountered during the memcpy. The return value is the number of bytes remaining to be copied. This patch

[PATCH v10 6/7] powerpc/mce: Handle UE event for memcpy_mcsafe

2019-08-14 Thread Santosh Sivaraj
From: Balbir Singh If we take a UE on one of the instructions with a fixup entry, set nip to continue execution at the fixup entry. Stop processing the event further or print it. Co-developed-by: Reza Arbab Signed-off-by: Reza Arbab Signed-off-by: Balbir Singh Signed-off-by: Santosh Sivaraj

[PATCH v10 7/7] powerpc: add machine check safe copy_to_user

2019-08-14 Thread Santosh Sivaraj
Use memcpy_mcsafe() implementation to define copy_to_user_mcsafe() Signed-off-by: Santosh Sivaraj --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/uaccess.h | 14 ++ 2 files changed, 15 insertions(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig in

[PATCH v10 4/7] extable: Add function to search only kernel exception table

2019-08-14 Thread Santosh Sivaraj
Certain architecture specific operating modes (e.g., in powerpc machine check handler that is unable to access vmalloc memory), the search_exception_tables cannot be called because it also searches the module exception tables if entry is not found in the kernel exception table. Cc: Thomas Gleixner

[PATCH v10 2/7] powerpc/mce: Fix MCE handling for huge pages

2019-08-14 Thread Santosh Sivaraj
From: Balbir Singh The current code would fail on huge pages addresses, since the shift would be incorrect. Use the correct page shift value returned by __find_linux_pte() to get the correct physical address. The code is more generic and can handle both regular and compound pages. Fixes: ba41e1e

  1   2   3   4   5   6   7   8   9   10   >