Re: [PATCH v2] arm64: mm: print hexadecimal EC value in mem_abort_decode()

On Thu, 2019-08-08 at 11:51 +0530, Anshuman Khandual wrote: > > On 08/08/2019 11:31 AM, Miles Chen wrote: > > On Thu, 2019-08-08 at 11:19 +0530, Anshuman Khandual wrote: > >> > >> On 08/07/2019 06:03 AM, Miles Chen wrote: > >>> This change prints the hexadecimal EC value in mem_abort_decode(), > >

Re: [PATCH] arm64: mm: add missing PTE_SPECIAL in pte_mkdevmap on arm64

On 08/08/2019 11:50 AM, Justin He (Arm Technology China) wrote: > Hi Anshuman > Thanks for the comments, please see my comments below > >> -Original Message- >> From: Anshuman Khandual >> Sent: 2019年8月8日 13:19 >> To: Justin He (Arm Technology China) ; Catalin >> Marinas ; Will Deacon ;

powerpc flush_inval_dcache_range() was buggy until v5.3-rc1 (was Re: [PATCH 4/4] powerpc/64: reuse PPC32 static inline flush_dcache_range())

[ deliberately broke threading so this doesn't get buried ] Christophe Leroy writes: > diff --git a/arch/powerpc/kernel/misc_64.S b/arch/powerpc/kernel/misc_64.S > index a4fd536efb44..1b0a42c50ef1 100644 > --- a/arch/powerpc/kernel/misc_64.S > +++ b/arch/powerpc/kernel/misc_64.S > @@ -115,35 +115

[tip:irq/urgent] genirq/affinity: Create affinity mask for single vector

Commit-ID: 491beed3b102b6e6c0e7734200661242226e3933 Gitweb: https://git.kernel.org/tip/491beed3b102b6e6c0e7734200661242226e3933 Author: Ming Lei AuthorDate: Mon, 5 Aug 2019 09:19:06 +0800 Committer: Thomas Gleixner CommitDate: Thu, 8 Aug 2019 08:47:55 +0200 genirq/affinity: Create affi

Re: [RFC][PATCH 12/13] sched/deadline: Introduce deadline servers

Hi Dietmar, On 07/08/19 18:31, Dietmar Eggemann wrote: > On 7/26/19 4:54 PM, Peter Zijlstra wrote: > > > > > > Signed-off-by: Peter Zijlstra (Intel) > > [...] > > > @@ -889,6 +891,8 @@ static void update_curr(struct cfs_rq *c > > trace_sched_stat_runtime(curtask, delta_exec, curr-

Re: remove sn2, hpsim and ia64 machvecs

On Wed, Aug 07, 2019 at 04:07:37PM -0700, Luck, Tony wrote: > On Wed, Aug 07, 2019 at 01:26:17PM -0700, Luck, Tony wrote: > > Ugh! The rule to do the compression was in arch/ia64/hp/sim/boot/Makefile > > which went away as part of the deletion of hpsim. > > This fixes it ... should fold into the p

[PATCH] perf db-export: Fix thread__exec_comm()

Threads synthesized from /proc have comms with a start time of zero, and not marked as "exec". Currently, there can be 2 such comms. The first is created by processing a synthesized fork event and is set to the parent's comm string, and the second by processing a synthesized comm event set to the t

[GIT PULL] SMB3 Fixes

Please pull the following changes since commit e21a712a9685488f5ce80495b37b9fdbe96c230d: Linux 5.3-rc3 (2019-08-04 18:40:12 -0700) are available in the Git repository at: git://git.samba.org/sfrench/cifs-2.6.git tags/5.3-rc3-smb3-fixes for you to fetch changes up to ee9d66182392695535cc9fcc

Re: [RFC PATCH v3 00/16] Core scheduling v3

On Tue, Aug 06, 2019 at 02:19:57PM -0700, Tim Chen wrote: > +void account_core_idletime(struct task_struct *p, u64 exec) > +{ > + const struct cpumask *smt_mask; > + struct rq *rq; > + bool force_idle, refill; > + int i, cpu; > + > + rq = task_rq(p); > + if (!sched_core_enab

Re: [RT BUG] isolcpus causes sleeping function called from invalid context (4.19.59-rt24)

Hi, On 07/08/19 16:07, Steven Rostedt wrote: > On Mon, 5 Aug 2019 12:06:46 +0200 > Juri Lelli wrote: > > > This only happens if isolcpus are configured at boot. > > > > AFAIU, RT is reworking workqueues and 5.x-rt shouldn't suffer from this. > > As a matter of fact, I could verify that backport

Re: [f2fs-dev] [PATCH] f2fs: Fix build error while CONFIG_NLS=m

On 2019/8/8 14:18, Chao Yu wrote: > Hi Haibing, > > Thanks for the patch! > > Out of curiosity, does Hulk Robot check linux-next git repo as well? This will > be more valuable if the bug can be found during development of related patch? Yes, Hulk Robot now do this on linux-next.git and linux.git

Re: [PATCH] kernfs: fix memleak in kernel_ops_readdir()

On Wed, Aug 07, 2019 at 11:45:18AM -0700, Tejun Heo wrote: > Hello, > > On Wed, Aug 07, 2019 at 06:29:28AM -0700, Tony Lindgren wrote: > > Hi, > > > > * Tejun Heo [691231 23:00]: > > > From: Andrea Arcangeli > > > > > > If getdents64 is killed or hits on segfault, it'll leave cgroups > > > dir

[PATCH v6 14/14] riscv: Make mmap allocation top-down by default

In order to avoid wasting user address space by using bottom-up mmap allocation scheme, prefer top-down scheme when possible. Before: root@qemuriscv64:~# cat /proc/self/maps 0001-00016000 r-xp fe:00 6389 /bin/cat.coreutils 00016000-00017000 r--p 5000 fe:00 6389 /bin/ca

Re: Please revert c4b230ac34ce for today's linux-next

Hi Masahiro, On Thu, 8 Aug 2019 15:20:11 +0900 Masahiro Yamada wrote: > > I queued the following commit in linux-kbuild/fixes, > but it turned out to produce false-positive warnings for single-targets. > > commit c4b230ac34ce64bdd4006f5e0e9be880b8a4d0a5 (origin/fixes) > Author: Masahiro Yamada

[tip:x86/urgent] x86/purgatory: Use CFLAGS_REMOVE rather than reset KBUILD_CFLAGS

Commit-ID: b059f801a937d164e03b33c1848bb3dca67c0b04 Gitweb: https://git.kernel.org/tip/b059f801a937d164e03b33c1848bb3dca67c0b04 Author: Nick Desaulniers AuthorDate: Wed, 7 Aug 2019 15:15:33 -0700 Committer: Thomas Gleixner CommitDate: Thu, 8 Aug 2019 08:25:53 +0200 x86/purgatory: Use C

[PATCH v6 13/14] mips: Use generic mmap top-down layout and brk randomization

mips uses a top-down layout by default that exactly fits the generic functions, so get rid of arch specific code and use the generic version by selecting ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT. As ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT selects ARCH_HAS_ELF_RANDOMIZE, use the generic version of arch_

[tip:x86/urgent] x86/purgatory: Do not use __builtin_memcpy and __builtin_memset

Commit-ID: 4ce97317f41d38584fb93578e922fcd19e535f5b Gitweb: https://git.kernel.org/tip/4ce97317f41d38584fb93578e922fcd19e535f5b Author: Nick Desaulniers AuthorDate: Wed, 7 Aug 2019 15:15:32 -0700 Committer: Thomas Gleixner CommitDate: Thu, 8 Aug 2019 08:25:52 +0200 x86/purgatory: Do no

[PATCH v6 12/14] mips: Replace arch specific way to determine 32bit task with generic version

Mips uses TASK_IS_32BIT_ADDR to determine if a task is 32bit, but this define is mips specific and other arches do not have it: instead, use !IS_ENABLED(CONFIG_64BIT) || is_compat_task() condition. Signed-off-by: Alexandre Ghiti Acked-by: Paul Burton Reviewed-by: Kees Cook Reviewed-by: Luis Cha

Re: [PATCH 3/3] kbuild: show hint if subdir-y/m is used to visit module Makefile

On Tue, Aug 6, 2019 at 7:03 PM Masahiro Yamada wrote: > > Since commit ff9b45c55b26 ("kbuild: modpost: read modules.order instead > of $(MODVERDIR)/*.mod"), a module is no longer built in the following > pattern: > > [Makefile] > subdir-y := some-module > > [some-module/Makefile] > obj-m :

[PATCH v6 11/14] mips: Adjust brk randomization offset to fit generic version

This commit simply bumps up to 32MB and 1GB the random offset of brk, compared to 8MB and 256MB, for 32bit and 64bit respectively. Suggested-by: Kees Cook Signed-off-by: Alexandre Ghiti Acked-by: Paul Burton Reviewed-by: Kees Cook Reviewed-by: Luis Chamberlain --- arch/mips/mm/mmap.c | 7 +++

[PATCH v3] arm64: mm: print hexadecimal EC value in mem_abort_decode()

This change prints the hexadecimal EC value in mem_abort_decode(), which makes it easier to lookup the corresponding EC in the ARM Architecture Reference Manual. The commit 1f9b8936f36f ("arm64: Decode information from ESR upon mem faults") prints useful information when memory abort occurs. It wo

[PATCH v6 10/14] mips: Use STACK_TOP when computing mmap base address

mmap base address must be computed wrt stack top address, using TASK_SIZE is wrong since STACK_TOP and TASK_SIZE are not equivalent. Signed-off-by: Alexandre Ghiti Acked-by: Kees Cook Acked-by: Paul Burton Reviewed-by: Luis Chamberlain --- arch/mips/mm/mmap.c | 4 ++-- 1 file changed, 2 inser

RE: [Regression] "drm/amdgpu: enable gfxoff again on raven series (v2)"

> -Original Message- > From: Kai-Heng Feng > Sent: Thursday, August 08, 2019 1:45 AM > To: Huang, Ray > Cc: Deucher, Alexander ; Koenig, Christian > ; Zhou, David(ChunMing) > ; amd-gfx list ; > dri-de...@lists.freedesktop.org; LKML ; > Anthony Wong > Subject: Re: [Regression] "drm/amdgpu

Re: [Sound-open-firmware] [PATCH v2 3/5] ASoC: SOF: Add DT DSP device support

On Wed, Aug 7, 2019 at 6:28 PM Daniel Baluta wrote: > > On Wed, Aug 7, 2019 at 6:22 PM Pierre-Louis Bossart > wrote: > > > > > > +static int sof_dt_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + const struct sof_dev_desc *desc;

[PATCH v6 09/14] mips: Properly account for stack randomization and stack guard gap

This commit takes care of stack randomization and stack guard gap when computing mmap base address and checks if the task asked for randomization. This fixes the problem uncovered and not fixed for arm here: https://lkml.kernel.org/r/20170622200033.25714-1-r...@redhat.com Signed-off-by: Alexandre

[PATCH v6 08/14] arm: Use generic mmap top-down layout and brk randomization

arm uses a top-down mmap layout by default that exactly fits the generic functions, so get rid of arch specific code and use the generic version by selecting ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT. As ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT selects ARCH_HAS_ELF_RANDOMIZE, use the generic version of a

[PATCH v6 07/14] arm: Use STACK_TOP when computing mmap base address

mmap base address must be computed wrt stack top address, using TASK_SIZE is wrong since STACK_TOP and TASK_SIZE are not equivalent. Signed-off-by: Alexandre Ghiti Acked-by: Kees Cook Reviewed-by: Luis Chamberlain --- arch/arm/mm/mmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v6 06/14] arm: Properly account for stack randomization and stack guard gap

This commit takes care of stack randomization and stack guard gap when computing mmap base address and checks if the task asked for randomization. This fixes the problem uncovered and not fixed for arm here: https://lkml.kernel.org/r/20170622200033.25714-1-r...@redhat.com Signed-off-by: Alexandre

[PATCH v6 05/14] arm64, mm: Make randomization selected by generic topdown mmap layout

This commits selects ARCH_HAS_ELF_RANDOMIZE when an arch uses the generic topdown mmap layout functions so that this security feature is on by default. Note that this commit also removes the possibility for arm64 to have elf randomization and no MMU: without MMU, the security added by randomizatio

[PATCH v2] team: Add vlan tx offload to hw_enc_features

We should also enable team's vlan tx offload in hw_enc_features, pass the vlan packets to the slave devices with vlan tci, let the slave handle vlan tunneling offload implementation. Fixes: 3268e5cb494d ("team: Advertise tunneling offload features") Signed-off-by: YueHaibing --- v2: fix commit lo

[PATCH v6 04/14] arm64, mm: Move generic mmap layout functions to mm

arm64 handles top-down mmap layout in a way that can be easily reused by other architectures, so make it available in mm. It then introduces a new config ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT that can be set by other architectures to benefit from those functions. Note that this new config depends

Re: [PATCH 1/3] mm/mlock.c: convert put_page() to put_user_page*()

On Wed 07-08-19 16:32:08, John Hubbard wrote: > On 8/7/19 4:01 AM, Michal Hocko wrote: > > On Mon 05-08-19 15:20:17, john.hubb...@gmail.com wrote: > >> From: John Hubbard > >> > >> For pages that were retained via get_user_pages*(), release those pages > >> via the new put_user_page*() routines, i

RE: [PATCH] arm64: mm: add missing PTE_SPECIAL in pte_mkdevmap on arm64

Hi Anshuman Thanks for the comments, please see my comments below > -Original Message- > From: Anshuman Khandual > Sent: 2019年8月8日 13:19 > To: Justin He (Arm Technology China) ; Catalin > Marinas ; Will Deacon ; > Mark Rutland ; James Morse > > Cc: Christoffer Dall ; Punit Agrawal > ; Qi

Re: [PATCH v2] arm64: mm: print hexadecimal EC value in mem_abort_decode()

On 08/08/2019 11:31 AM, Miles Chen wrote: > On Thu, 2019-08-08 at 11:19 +0530, Anshuman Khandual wrote: >> >> On 08/07/2019 06:03 AM, Miles Chen wrote: >>> This change prints the hexadecimal EC value in mem_abort_decode(), >>> which makes it easier to lookup the corresponding EC in >>> the ARM A

[PATCH v6 03/14] arm64: Consider stack randomization for mmap base only when necessary

Do not offset mmap base address because of stack randomization if current task does not want randomization. Note that x86 already implements this behaviour. Signed-off-by: Alexandre Ghiti Acked-by: Catalin Marinas Acked-by: Kees Cook Reviewed-by: Christoph Hellwig Reviewed-by: Luis Chamberlain

[PATCH v6 02/14] arm64: Make use of is_compat_task instead of hardcoding this test

Each architecture has its own way to determine if a task is a compat task, by using is_compat_task in arch_mmap_rnd, it allows more genericity and then it prepares its moving to mm/. Signed-off-by: Alexandre Ghiti Acked-by: Catalin Marinas Acked-by: Kees Cook Reviewed-by: Christoph Hellwig Rev

Re: [PATCH] sound: fix a memory leak bug

On Thu, 08 Aug 2019 07:15:21 +0200, Wenwen Wang wrote: > > In sound_insert_unit(), the controlling structure 's' is allocated through > kmalloc(). Then it is added to the sound driver list by invoking > __sound_insert_unit(). Later on, if __register_chrdev() fails, 's' is > removed from the list t

Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

On 2019/8/8 14:11, Heiner Kallweit wrote: > On 08.08.2019 03:15, Yonglong Liu wrote: >> >> >> On 2019/8/8 0:47, Heiner Kallweit wrote: >>> On 07.08.2019 15:16, Yonglong Liu wrote: [ 27.232781] hns3 :bd:00.3 eth7: net open [ 27.237303] 8021q: adding VLAN 0 to HW filter on device

Please revert c4b230ac34ce for today's linux-next

Hi Stephen, I queued the following commit in linux-kbuild/fixes, but it turned out to produce false-positive warnings for single-targets. commit c4b230ac34ce64bdd4006f5e0e9be880b8a4d0a5 (origin/fixes) Author: Masahiro Yamada Date: Tue Aug 6 19:03:23 2019 +0900 kbuild: show hint if subdir-

Re: [PATCH v5 06/10] powerpc/fsl_booke/32: implement KASLR infrastructure

On 2019/8/7 21:04, Michael Ellerman wrote: Jason Yan writes: This patch add support to boot kernel from places other than KERNELBASE. Since CONFIG_RELOCATABLE has already supported, what we need to do is map or copy kernel to a proper place and relocate. Freescale Book-E parts expect lowmem

[PATCH v6 01/14] mm, fs: Move randomize_stack_top from fs to mm

This preparatory commit moves this function so that further introduction of generic topdown mmap layout is contained only in mm/util.c. Signed-off-by: Alexandre Ghiti Acked-by: Kees Cook Reviewed-by: Christoph Hellwig Reviewed-by: Luis Chamberlain --- fs/binfmt_elf.c| 20 -

Re: [PATCHv5 06/37] alarmtimer: Provide get_timespec() callback

On Wed, Aug 07, 2019 at 08:04:10AM +0200, Thomas Gleixner wrote: > On Mon, 29 Jul 2019, Dmitry Safonov wrote: > > /** > > @@ -869,8 +871,10 @@ static int __init alarmtimer_init(void) > > /* Initialize alarm bases */ > > alarm_bases[ALARM_REALTIME].base_clockid = CLOCK_REALTIME; > > ala

Re: [f2fs-dev] [PATCH] f2fs: Fix build error while CONFIG_NLS=m

Hi Haibing, Thanks for the patch! Out of curiosity, does Hulk Robot check linux-next git repo as well? This will be more valuable if the bug can be found during development of related patch? On 2019/8/8 10:02, YueHaibing wrote: > If CONFIG_F2FS_FS=y but CONFIG_NLS=m, building fails: > > fs/f2fs

[PATCH v6 00/14] Provide generic top-down mmap layout functions

This series introduces generic functions to make top-down mmap layout easily accessible to architectures, in particular riscv which was the initial goal of this series. The generic implementation was taken from arm64 and used successively by arm, mips and finally riscv. Note that in addition the s

Re: [PATCH] scripts/checkpatch.pl - fix *_NOTIFIER_HEAD handling

On Thu, 2019-08-08 at 02:08 -0400, Valdis Klētnieks wrote: > On Wed, 07 Aug 2019 22:50:47 -0700, Joe Perches said: > > On Wed, 2019-08-07 at 21:36 -0400, Valdis Kltnieks wrote: > > > ^.DEFINE_$Ident\(\Q$name\E\)| > > > ^.DECLARE_$Ident\(\Q$name\E\

[PATCH 2/2] drivers: qcom: Add SoC sleep stats driver

Qualcomm Technologies Inc's (QTI) chipsets support SoC level low power modes. Statistics for SoC sleep stats are produced by remote processor. Lets's add a driver to read the shared memory exported by the remote processor and export to sysfs. Signed-off-by: Mahesh Sivasubramanian Signed-off-by:

[PATCH 1/2] dt-bindings: Introduce soc sleep stats bindings for Qualcomm SoCs

Add device binding documentation for Qualcomm Technology Inc's (QTI) SoC sleep stats driver. The driver is used for displaying SoC sleep statistic maintained by Always On Processor or Resource Power Manager. Cc: devicet...@vger.kernel.org Signed-off-by: Mahesh Sivasubramanian Signed-off-by: Lina

[PATCH 0/2] Introduce SoC sleep stats driver

Qualcomm Technologies Inc's (QTI) chipsets support SoC level low power modes. SoCs Always On Processor/Resource Power Manager produces statistics of the SoC sleep modes involving lowering or powering down of the backbone rails - Cx and Mx and the oscillator clock, XO. Statistics includes SoC slee

Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

On 08.08.2019 03:15, Yonglong Liu wrote: > > > On 2019/8/8 0:47, Heiner Kallweit wrote: >> On 07.08.2019 15:16, Yonglong Liu wrote: >>> [ 27.232781] hns3 :bd:00.3 eth7: net open >>> [ 27.237303] 8021q: adding VLAN 0 to HW filter on device eth7 >>> [ 27.242972] IPv6: ADDRCONF(NETDEV_CHAN

Re: [Intel-wired-lan] MDI errors during resume from ACPI S3 (suspend to ram)

On 8/7/2019 17:55, Paul Menzel wrote: Dear Sasha, On 07.08.19 09:23, Neftin, Sasha wrote: On 8/6/2019 18:53, mario.limoncie...@dell.com wrote: -Original Message- From: Paul Menzel Sent: Tuesday, August 6, 2019 10:36 AM To: Jeff Kirsher Cc: intel-wired-...@lists.osuosl.org; Linux Ker

Re: [PATCH] scripts/checkpatch.pl - fix *_NOTIFIER_HEAD handling

On Wed, 07 Aug 2019 22:50:47 -0700, Joe Perches said: > On Wed, 2019-08-07 at 21:36 -0400, Valdis Klētnieks wrote: > > ^.DEFINE_$Ident\(\Q$name\E\)| > > ^.DECLARE_$Ident\(\Q$name\E\)| > > ^.LIST_HEAD\(\Q$name\E\)|

RE: [PATCH V2] usb: dwc3: gadget: trb_dequeue is not updated properly

Hi, "Yang, Fei" writes: >> I need tracepoints to see what's going on, please collect tracepoints. > > See attached. Search for "length 16384/16384" to the USB request using > sg list. And the transfer stalls at a request with "length 512/512". which gadget driver is this btw? Let's look at wha

Re: [PATCH] mm/mmap.c: refine data locality of find_vma_prev

On Thu 08-08-19 11:26:38, Wei Yang wrote: > On Wed, Aug 07, 2019 at 09:51:01AM +0200, Michal Hocko wrote: > >On Wed 07-08-19 08:31:09, Wei Yang wrote: > >> On Tue, Aug 06, 2019 at 11:29:52AM +0200, Vlastimil Babka wrote: > >> >On 8/6/19 10:11 AM, Wei Yang wrote: > >> >> When addr is out of the rang

Re: [PATCH v2] arm64: mm: print hexadecimal EC value in mem_abort_decode()

On Thu, 2019-08-08 at 11:19 +0530, Anshuman Khandual wrote: > > On 08/07/2019 06:03 AM, Miles Chen wrote: > > This change prints the hexadecimal EC value in mem_abort_decode(), > > which makes it easier to lookup the corresponding EC in > > the ARM Architecture Reference Manual. > > > > The commi

[PATCH] ALSA: firewire: fix a memory leak bug

In iso_packets_buffer_init(), 'b->packets' is allocated through kmalloc_array(). Then, the aligned packet size is checked. If it is larger than PAGE_SIZE, -EINVAL will be returned to indicate the error. However, the allocated 'b->packets' is not deallocated on this path, leading to a memory leak.

Re: [PATCH] scripts/checkpatch.pl - fix *_NOTIFIER_HEAD handling

On Wed, 2019-08-07 at 21:36 -0400, Valdis Klētnieks wrote: > commit 81398d99e9de80d9dbe65dfe7aadec9497f88242 > Author: Gilad Ben-Yossef > Date: Wed Jul 31 14:44:23 2019 +1000 > > checkpatch: add *_NOTIFIER_HEAD as var definition > > has a typo, resulting in a truly amazing error message:

Re: [PATCH v2] arm64: mm: print hexadecimal EC value in mem_abort_decode()

On 08/07/2019 06:03 AM, Miles Chen wrote: > This change prints the hexadecimal EC value in mem_abort_decode(), > which makes it easier to lookup the corresponding EC in > the ARM Architecture Reference Manual. > > The commit 1f9b8936f36f ("arm64: Decode information from ESR upon mem > faults")

Re: [linux-sunxi] [PATCH 0/3] Add basic support for RTC on Allwinner H6 SoC

On Wed, Aug 7, 2019 at 6:55 PM Alexandre Belloni wrote: > > Hi, > > On 06/08/2019 20:30:45+0200, Ondřej Jirman wrote: > > Maybe whether XO or DCXO is used also matters if you want to do some fine > > tunning of DCXO (control register has pletny of options), but that's > > probably > > better done

Re: [PATCH] team: Add vlan tx offload to hw_enc_features

On Wed, 7 Aug 2019 10:38:08 +0800 YueHaibing wrote: > We should also enable bonding's vlan tx offload in hw_enc_features, You mean team's vlan tx offload? > pass the vlan packets to the slave devices with vlan tci, let them s/let them to/let the slave/ > to handle vlan tunneling offload imple

[PATCH] net/netfilter/nf_nat_proto.c - make tables static

Sparse warns about two tables not being declared. CHECK net/netfilter/nf_nat_proto.c net/netfilter/nf_nat_proto.c:725:26: warning: symbol 'nf_nat_ipv4_ops' was not declared. Should it be static? net/netfilter/nf_nat_proto.c:964:26: warning: symbol 'nf_nat_ipv6_ops' was not declared. Should i

Re: [PATCH] myri10ge: remove unneeded variable

On Wed, 31 Jul 2019 16:53:46 +0800 Ding Xiang wrote: > "error" is unneeded,just return 0 > > Signed-off-by: Ding Xiang Reviewed-by: Jesse Brandeburg

Re: [PATCH 2/2] net: ag71xx: Use GFP_KERNEL instead of GFP_ATOMIC in 'ag71xx_rings_init()'

On Wed, 31 Jul 2019 10:06:48 +0200 Christophe JAILLET wrote: > There is no need to use GFP_ATOMIC here, GFP_KERNEL should be enough. > The 'kcalloc()' just a few lines above, already uses GFP_KERNEL. > > Signed-off-by: Christophe JAILLET Reviewed-by: Jesse Brandeburg

Re: [PATCH 1/2] net: ag71xx: Slighly simplify code in 'ag71xx_rings_init()'

On Wed, 31 Jul 2019 10:06:38 +0200 Christophe JAILLET wrote: > A few lines above, we have: >tx_size = BIT(tx->order); > > So use 'tx_size' directly to be consistent with the way 'rx->descs_cpu' and > 'rx->descs_dma' are computed below. > > Signed-off-by: Christophe JAILLET Reviewed-by: Je

[PATCH] net/netfilter - add missing prototypes.

Sparse rightly complains about undeclared symbols. CHECK net/netfilter/nft_set_hash.c net/netfilter/nft_set_hash.c:647:21: warning: symbol 'nft_set_rhash_type' was not declared. Should it be static? net/netfilter/nft_set_hash.c:670:21: warning: symbol 'nft_set_hash_type' was not declared. Sh

Re: [PATCH] net: ethernet: et131x: Use GFP_KERNEL instead of GFP_ATOMIC when allocating tx_ring->tcb_ring

On Wed, 31 Jul 2019 09:38:42 +0200 Christophe JAILLET wrote: > There is no good reason to use GFP_ATOMIC here. Other memory allocations > are performed with GFP_KERNEL (see other 'dma_alloc_coherent()' below and > 'kzalloc()' in 'et131x_rx_dma_memory_alloc()') > > Use GFP_KERNEL which should be

Re: [PATCH] arm64: mm: add missing PTE_SPECIAL in pte_mkdevmap on arm64

On 08/07/2019 10:28 AM, Jia He wrote: > Without this patch, the MAP_SYNC test case will cause a print_bad_pte > warning on arm64 as follows: > [ 25.542693] BUG: Bad page map in process mapdax333 > pte:2e8000448800f53 pmd:41ff5f003 > [ 25.546360] page:7e001022 refcount:1 mapcount:-1 >

Re: [PATCH 4/5] clk: Add driver for Bitmain BM1880 SoC clock controller

Quoting Manivannan Sadhasivam (2019-07-05 08:14:39) > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index fc1e0cf44995..ffc61ed85ade 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -304,6 +304,12 @@ config COMMON_CLK_FIXED_MMIO > help > Support for M

[PATCH] sound: fix a memory leak bug

In sound_insert_unit(), the controlling structure 's' is allocated through kmalloc(). Then it is added to the sound driver list by invoking __sound_insert_unit(). Later on, if __register_chrdev() fails, 's' is removed from the list through __sound_remove_unit(). If 'index' is not less than 0, -EBUS

Re: [PATCH v1 2/2] clk: qcom: Add Global Clock controller (GCC) driver for SC7180

On 07-08-19, 23:43, Taniya Das wrote: > +static struct clk_alpha_pll gpll0; > +static struct clk_alpha_pll gpll1; > +static struct clk_alpha_pll gpll4; > +static struct clk_alpha_pll gpll6; > +static struct clk_alpha_pll gpll7; > +static struct clk_alpha_pll_postdiv gpll0_out_even; I am not sure

Re: linux-next: Tree for Aug 7

Stephen Rothwell writes: > Hi all, > > Changes since 20190806: > > The arm64 tree introduced a patch that stopped the powerpc ppc64_defconfig > build from completing so I reverted that commit. > > The mips tree gained a conflict against Linus' tree. > > The crypto tree still had its build failure

Re: linux-next: build failure after merge of the crypto tree

Hi Herbert, On Thu, 8 Aug 2019 15:00:04 +1000 Herbert Xu wrote: > > On Thu, Aug 08, 2019 at 01:17:10PM +1000, Stephen Rothwell wrote: > > > > Excellent, thanks. Should I add the crypto mailing list as a contact > > for problems? Mostly the emails are just reporting conflicts and only > > very

Re: [PATCH v1 1/2] clk: qcom: Add DT bindings for SC7180 gcc clock controller

On 07-08-19, 23:43, Taniya Das wrote: > Add compatible string and the include file for gcc clock > controller for SC7180. > > Signed-off-by: Taniya Das > --- > .../devicetree/bindings/clock/qcom,gcc.txt| 1 + > include/dt-bindings/clock/qcom,gcc-sc7180.h | 155 ++ > 2 fil

Re: [PATCH 1/5] dt-bindings: clock: Add Bitmain BM1880 SoC clock controller binding

Quoting Manivannan Sadhasivam (2019-07-05 08:14:36) > Add devicetree binding for Bitmain BM1880 SoC clock controller. > > Signed-off-by: Manivannan Sadhasivam > --- > .../bindings/clock/bitmain,bm1880-clk.txt | 47 +++ Can you convert this to YAML? It's all the rage right now. > in

Re: linux-next: build failure after merge of the crypto tree

On Thu, Aug 08, 2019 at 01:17:10PM +1000, Stephen Rothwell wrote: > > Excellent, thanks. Should I add the crypto mailing list as a contact > for problems? Mostly the emails are just reporting conflicts and only > very occasionally do I actually send a useful patch. If so, what is > its address?

[PATCH] liquidio: Use pcie_flr() instead of reimplementing it

octeon_mbox_process_cmd() directly writes the PCI_EXP_DEVCTL_BCR_FLR bit, which bypasses timing requirements imposed by the PCIe spec. This patch fixes the function to use the pcie_flr() interface instead. Signed-off-by: Denis Efremov --- drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c | 4

Re: [PATCH v2] clk: Constify struct clk_bulk_data * where possible

Quoting Andrey Smirnov (2019-07-17 07:56:51) > The following functions: > > - clk_bulk_enable() > - clk_bulk_prepare() > - clk_bulk_disable() > - clk_bulk_unprepare() > > already expect const clk_bulk_data * as a second parameter, however > their no-op version have mismatching pro

Re: [PATCH v2 0/7] Add support for Qualcomm SM8150 and SC7180 SoCs

On 07-08-19, 12:39, Sibi Sankar wrote: > This patch series adds SCM, APSS shared mailbox and QMP AOSS PD/clock > support on SM8150 and SC7180 SoCs. > > v2: > * re-arrange the compatible lists in sort order i checked these lgtm and tested on SM8150 Tested-by: Vinod Koul Reviewed-by: Vinod Koul

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

On 8/7/19 10:36 AM, Vijay Khemka wrote: > Lgtm except one small comment below. > > On 8/6/19, 5:22 PM, "openbmc on behalf of Tao Ren" > tao...@fb.com> wrote: > > Currently BMC's MAC address is calculated by adding 1 to NCSI NIC's base > MAC address when CONFIG_NCSI_OEM_CMD_GET_MAC opti

Re: [PATCH] arm64/cache: silence -Woverride-init warnings

On Wed, Aug 07, 2019 at 11:29:16PM -0400, Qian Cai wrote: > The commit 155433cb365e ("arm64: cache: Remove support for ASID-tagged > VIVT I-caches") introduced some compiation warnings from GCC (and > Clang) with -Winitializer-overrides), > > arch/arm64/kernel/cpuinfo.c:38:26: warning: initialized

linux-next: build failure after merge of the tip tree

Hi all, After merging the tip tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: kernel/locking/mutex-debug.c: In function 'debug_mutex_lock_common': kernel/locking/mutex-debug.c:32:42: error: dereferencing pointer to incomplete type 'struct mutex_waiter' memset(waiter,

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

On 8/7/19 11:41 AM, Andrew Lunn wrote: > On Wed, Aug 07, 2019 at 11:25:18AM -0700, Jakub Kicinski wrote: >> On Tue, 6 Aug 2019 17:21:18 -0700, Tao Ren wrote: >>> Currently BMC's MAC address is calculated by adding 1 to NCSI NIC's base >>> MAC address when CONFIG_NCSI_OEM_CMD_GET_MAC option is enabl

Re: [PATCH v2 1/4] clk: core: introduce clk_hw_set_parent()

Quoting Jerome Brunet (2019-08-06 01:28:19) > On Wed 31 Jul 2019 at 10:40, Neil Armstrong wrote: > > > Introduce the clk_hw_set_parent() provider call to change parent of > > a clock by using the clk_hw pointers. > > > > This eases the clock reparenting from clock rate notifiers and > > implement

Re: [RFC/RFT v3 07/14] clk: meson: g12a: add notifiers to handle cpu clock change

Quoting Martin Blumenstingl (2019-07-02 16:28:55) > Hi Stephen, Hi Neil, > > On Mon, Jul 1, 2019 at 11:13 AM Neil Armstrong > wrote: > > > > In order to implement clock switching for the CLKID_CPU_CLK and > > CLKID_CPUB_CLK, notifiers are added on specific points of the > > clock tree : > > > >

Re: [PATCH v4 2/5] clk: qcom: clk-alpha-pll: Remove post_div_table checks

Quoting Vinod Koul (2019-07-22 00:43:45) > We want users to code properly and fix the post_div_table missing and > not rely on core to check. So remove the post_div_table check. > > Signed-off-by: Vinod Koul > Reviewed-by: Bjorn Andersson > --- Applied to clk-next

Re: [PATCH v4 4/5] dt-bindings: clock: Document gcc bindings for SM8150

Quoting Vinod Koul (2019-07-22 00:43:47) > From: Deepak Katragadda > > Document the global clock controller found on SM8150. > > Signed-off-by: Deepak Katragadda > Signed-off-by: Taniya Das > [vkoul: port to upstream and add external clocks > split binding to this patch]] > Signed-off-

Re: [PATCH v4 5/5] clk: qcom: gcc: Add global clock controller driver for SM8150

Quoting Vinod Koul (2019-07-22 00:43:48) > From: Deepak Katragadda > > Add the clocks supported in global clock controller which clock the > peripherals like BLSPs, SDCC, USB, MDSS etc. Register all the clocks > to the clock framework for the clients to be able to request for them. > > Signed-of

Re: [PATCH v4 1/5] clk: qcom: clk-alpha-pll: Remove unnecessary cast

Quoting Vinod Koul (2019-07-22 00:43:44) > Commit 8f9fab480c7a ("linux/kernel.h: fix overflow for > DIV_ROUND_UP_ULL") fixed the overflow for DIV_ROUND_UP_ULL, so we no > longer need the cast for DIV_ROUND_UP_ULL, so remove the unnecessary > u64 casts. > > Signed-off-by: Vinod Koul > --- Applied

Re: [PATCH v4 3/5] clk: qcom: clk-alpha-pll: Add support for Trion PLLs

Quoting Vinod Koul (2019-07-22 00:43:46) > From: Deepak Katragadda > > Add programming sequence support for managing the Trion > PLLs. > > Signed-off-by: Deepak Katragadda > Signed-off-by: Taniya Das > [vkoul: port to upstream and tidy-up > use upstream way of specifying PLLs] > Signed

Re: [PATCH v5 03/10] powerpc: introduce kimage_vaddr to store the kernel base

On 2019/8/7 21:03, Michael Ellerman wrote: Jason Yan writes: Now the kernel base is a fixed value - KERNELBASE. To support KASLR, we need a variable to store the kernel base. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt

Re: [PATCH net-next v4 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

Hi Heiner, On 8/7/19 12:18 PM, Heiner Kallweit wrote: > On 06.08.2019 23:42, Tao Ren wrote: >> Hi Andrew / Heiner / Vladimir, >> >> On 8/6/19 2:09 PM, Tao Ren wrote: >>> The BCM54616S PHY cannot work properly in RGMII->1000Base-KX mode (for >>> example, on Facebook CMM BMC platform), mainly becaus

Re: [PATCH] clk: ingenic: Use CLK_OF_DECLARE_DRIVER macro

Quoting Paul Cercueil (2019-07-16 10:08:00) > By using CLK_OF_DECLARE_DRIVER instead of the CLK_OF_DECLARE macro, we > allow the driver to probe also as a platform driver. > > While this driver does not have code to probe as a platform driver, this > is still useful for probing children devices in

Re: [PATCH] clk: ingenic/jz4740: Fix "pll half" divider not read/written properly

Quoting Paul Cercueil (2019-08-07 16:28:10) > > > Le mer. 7 août 2019 à 23:33, Stephen Boyd a écrit > : > > Quoting Paul Cercueil (2019-07-01 04:36:06) > >> The code was setting the bit 21 of the CPCCR register to use a > >> divider > >> of 2 for the "pll half" clock, and clearing the bit to

[PATCH v3 1/1] ixgbe: sync the first fragment unconditionally

In Xen environment, if Xen-swiotlb is enabled, ixgbe driver could possibly allocate a page, DMA memory buffer, for the first fragment which is not suitable for Xen-swiotlb to do DMA operations. Xen-swiotlb have to internally allocate another page for doing DMA operations. This mechanism requires sy

Re: [PATCH v4 02/20] RISC-V: Add bitmap reprensenting ISA features common across CPUs

On Thu, Aug 8, 2019 at 12:18 AM Atish Patra wrote: > > On Wed, 2019-08-07 at 12:28 +, Anup Patel wrote: > > This patch adds riscv_isa bitmap which represents Host ISA features > > common across all Host CPUs. The riscv_isa is not same as elf_hwcap > > because elf_hwcap will only have ISA featu

i2c: imx: support slave mode for imx I2C driver

The patch supports slave mode for imx I2C driver Signed-off-by: Biwen Li --- drivers/i2c/busses/i2c-imx.c | 199 --- 1 file changed, 185 insertions(+), 14 deletions(-) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index b1b8b938d7f4..f7

[PATCH] lib/generic-radix-tree.c - make 2 functions static inline

When building with W=1, we get some warnings: l CC lib/generic-radix-tree.o lib/generic-radix-tree.c:39:10: warning: no previous prototype for 'genradix_root_to_depth' [-Wmissing-prototypes] 39 | unsigned genradix_root_to_depth(struct genradix_root *r) | ^~

Re: [PATCH v2 1/1] ixgbe: sync the first fragment unconditionally

On Wed, Aug 7, 2019 at 6:58 PM Jacob Wen wrote: > > > On 8/7/19 4:38 PM, Firo Yang wrote: > > The 08/07/2019 15:56, Jacob Wen wrote: > >> I think the description is not correct. Consider using something like > >> below. > > Thank you for comments. > > > >> In Xen environment, due to memory fragme

Re: [PATCH v2 1/2] linux/bits.h: Clarify macro argument names

On Fri, Aug 2, 2019 at 8:04 AM Rikard Falkeborn wrote: > > Be a little more verbose to improve readability. > > Signed-off-by: Rikard Falkeborn BTW, I do not understand what the improvement is. I tend to regard this as a noise commit. > --- > Changes in v2: > - This patch is new in v2 > > i

[PATCH] lib/extable.c - add missing prototypes.

When building with W=1, a number of warnings are issued: CC lib/extable.o lib/extable.c:63:6: warning: no previous prototype for 'sort_extable' [-Wmissing-prototypes] 63 | void sort_extable(struct exception_table_entry *start, | ^~~~ lib/extable.c:75:6: warning: no pr

[PATCH v1 2/2] i2c: iproc: Add full name of devicetree node to adapter name

From: Lori Hikichi Add the full name of the devicetree node to the adapter name. Without this change, all adapters have the same name making it difficult to distinguish between multiple instances. The most obvious way to see this is to use the utility i2c_detect. e.g. "i2c-detect -l" Before i2c-

  1   2   3   4   5   6   7   8   9   >