Re: "mm: account nr_isolated_xxx in [isolate|putback]_lru_page" breaks OOM with swap

2019-07-31 Thread Minchan Kim
On Wed, Jul 31, 2019 at 02:18:00PM -0400, Qian Cai wrote: > On Wed, 2019-07-31 at 12:09 -0400, Qian Cai wrote: > > On Wed, 2019-07-31 at 14:34 +0900, Minchan Kim wrote: > > > On Tue, Jul 30, 2019 at 12:25:28PM -0400, Qian Cai wrote: > > > > OOM workloads with swapping is unable to recover with linu

Re: [PATCH 3/3] mtd: spi-nor: Introduce spi_nor_get_flash_info()

2019-07-31 Thread Boris Brezillon
On Wed, 31 Jul 2019 09:18:49 + wrote: > From: Tudor Ambarus > > Dedicate a function for getting the pointer to the flash_info > const struct. Trim a bit the spi_nor_scan() huge function. > > Signed-off-by: Tudor Ambarus Reviewed-by: Boris Brezillon > --- > drivers/mtd/spi-nor/spi-nor.

Re: [PATCH v1] drivers/base/memory.c: Don't store end_section_nr in memory blocks

2019-07-31 Thread David Hildenbrand
On 31.07.19 22:57, Andrew Morton wrote: > On Wed, 31 Jul 2019 14:22:13 +0200 David Hildenbrand wrote: > >> Each memory block spans the same amount of sections/pages/bytes. The size >> is determined before the first memory block is created. No need to store >> what we can easily calculate - and th

Re: [PATCHv5 28/37] x86/vdso: Enable static branches for the timens vdso

2019-07-31 Thread Thomas Gleixner
On Wed, 31 Jul 2019, Andy Lutomirski wrote: > On Mon, Jul 29, 2019 at 2:58 PM Dmitry Safonov wrote: > > As it has been discussed on timens RFC, adding a new conditional branch > > `if (inside_time_ns)` on VDSO for all processes is undesirable. > > > > Addressing those problems, there are two versi

Re: [PATCH 2/3] mtd: spi_nor: Introduce spi_nor_set_addr_width()

2019-07-31 Thread Boris Brezillon
On Wed, 31 Jul 2019 09:18:47 + wrote: > From: Tudor Ambarus > > Parsing of flash parameters were interleaved with setting of the > nor addr width. Dedicate a function for setting nor addr width. > > Signed-off-by: Tudor Ambarus Reviewed-by: Boris Brezillon > --- > drivers/mtd/spi-nor/

Re: [PATCH 1/3] mtd: spi-nor: Bring flash params init together

2019-07-31 Thread Boris Brezillon
On Wed, 31 Jul 2019 09:18:45 + wrote: > From: Tudor Ambarus > > Bring all flash parameters default initialization in > spi_nor_default_params_init(). > > Signed-off-by: Tudor Ambarus Reviewed-by: Boris Brezillon > --- > drivers/mtd/spi-nor/spi-nor.c | 29 +++--

Re: [PATCH v3 2/3] mtd: spi-nor: Move m25p80 code in spi-nor.c

2019-07-31 Thread Vignesh Raghavendra
On 01/08/19 11:22 AM, Boris Brezillon wrote: > On Thu, 1 Aug 2019 10:00:51 +0530 > Vignesh Raghavendra wrote: > >> From: Boris Brezillon >> >> The m25p80 driver is actually a generic wrapper around the spi-mem >> layer. Not only the driver name is misleading, but we'd expect such a >> common

Re: [PATCH v3 1/3] mtd: spi-nor: always use bounce buffer for register read/writes

2019-07-31 Thread Vignesh Raghavendra
Hi Boris On 01/08/19 11:16 AM, Boris Brezillon wrote: > On Thu, 1 Aug 2019 10:00:50 +0530 > Vignesh Raghavendra wrote: > >> spi-mem layer expects all buffers passed to it to be DMA'able. But >> spi-nor layer mostly allocates buffers on stack for reading/writing to >> registers and therefore are

Re: [PATCH] mm/madvise: reduce code duplication in error handling paths

2019-07-31 Thread Pankaj Gupta
> > The madvise_behavior() function converts -ENOMEM to -EAGAIN in several > places using identical code. > > Move that code to a common error handling path. > > No functional changes. > > Signed-off-by: Mike Rapoport > --- > mm/madvise.c | 52 ---

Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups()

2019-07-31 Thread Boris Brezillon
On Wed, 31 Jul 2019 09:12:16 + wrote: > From: Tudor Ambarus > > s3an_nor_scan() was overriding the opcode selection done in > spi_nor_default_setup(). Set nor->setup() method in order to > avoid unnecessary call to spi_nor_default_setup(). > > Signed-off-by: Tudor Ambarus > --- > drivers

Re: linux-next: build warning after merge of the akpm-current tree

2019-07-31 Thread Miles Chen
On Thu, 2019-08-01 at 16:39 +1000, Stephen Rothwell wrote: > Hi Miles, > > On Thu, 1 Aug 2019 14:30:03 +0800 Miles Chen wrote: > > > > It's the first time that I receive a build warning after the patch has > > been merged to -mm tree. The build warning had been fixed by Qian, > > should I send an

Re: [PATCH v2] mm: kmemleak: Use mempool allocations for kmemleak objects

2019-07-31 Thread Michal Hocko
On Wed 31-07-19 16:44:50, Catalin Marinas wrote: > On Tue, Jul 30, 2019 at 01:02:15PM -0700, Andrew Morton wrote: > > On Sat, 27 Jul 2019 14:23:33 +0100 Catalin Marinas > > wrote: > > > > > Add mempool allocations for struct kmemleak_object and > > > kmemleak_scan_area as slightly more resilient

Re: [PATCH v9 12/21] mm: pagewalk: Allow walking without vma

2019-07-31 Thread Anshuman Khandual
On 07/29/2019 05:59 PM, Steven Price wrote: > On 28/07/2019 15:20, Anshuman Khandual wrote: >> >> >> On 07/22/2019 09:12 PM, Steven Price wrote: >>> Since 48684a65b4e3: "mm: pagewalk: fix misbehavior of walk_page_range >>> for vma(VM_PFNMAP)", page_table_walk() will report any kernel area as >>>

Re: linux-next: build warning after merge of the akpm-current tree

2019-07-31 Thread Stephen Rothwell
Hi Miles, On Thu, 1 Aug 2019 14:30:03 +0800 Miles Chen wrote: > > It's the first time that I receive a build warning after the patch has > been merged to -mm tree. The build warning had been fixed by Qian, > should I send another change for this? No, that will do. -- Cheers, Stephen Rothwell

Re: linux-next: build warning after merge of the akpm-current tree

2019-07-31 Thread Michal Hocko
On Thu 01-08-19 14:30:03, Miles Chen wrote: [...] > It's the first time that I receive a build warning after the patch has > been merged to -mm tree. The build warning had been fixed by Qian, > should I send another change for this? No need. Andrew has already picked up the fix for mmotm tree and

Re: [PATCH 4/6] mtd: spi_nor: Add nor->setup() method

2019-07-31 Thread Boris Brezillon
On Wed, 31 Jul 2019 09:12:14 + wrote: > static inline bool spi_nor_protocol_is_dtr(enum spi_nor_protocol proto) > { > return !!(proto & SNOR_PROTO_IS_DTR); > @@ -384,6 +522,7 @@ struct flash_info; > * useful when pagesize is not a power-of-2 > * @disable_writ

RE: [PATCH] x86/entry/64: randomize kernel stack offset upon syscall

2019-07-31 Thread Reshetova, Elena
>> The in-stack randomization is really a very small change both code wise and >> logic wise. >> It does not affect real workloads and does not require enablement of other >> features (such as GCC plugins). >> So, I think we should really reconsider its inclusion. >I'd agree: the code is tiny and

Re: [PATCH 4/7] mtd: spi-nor: Split spi_nor_init_params()

2019-07-31 Thread Boris Brezillon
On Wed, 31 Jul 2019 09:03:33 + wrote: > From: Tudor Ambarus > > Add functions to delimit what the chunks of code do: > > static void spi_nor_init_params() > { > spi_nor_default_init_params() > spi_nor_manufacturer_init_params() > spi_nor_sfdp_init_params() > } > > spi_no

Re: [PATCH 3/7] mtd: spi_nor: Rework quad_enable()

2019-07-31 Thread Boris Brezillon
On Wed, 31 Jul 2019 09:03:31 + wrote: > From: Tudor Ambarus > > The goal is to move the quad_enable manufacturer specific init in the > nor->manufacturer->fixups->default_init() > > The legacy/core quad_enable() implementation is spansion_quad_enable(), > select this method by default. >

Re: linux-next: build warning after merge of the akpm-current tree

2019-07-31 Thread Miles Chen
On Thu, 2019-08-01 at 08:15 +0200, Michal Hocko wrote: > On Thu 01-08-19 15:51:30, Stephen Rothwell wrote: > > Hi Miles, > > > > On Wed, 31 Jul 2019 14:28:04 +0800 Miles Chen > > wrote: > > > > > > On Wed, 2019-07-31 at 16:11 +1000, Stephen Rothwell wrote: > > > > > > > > After merging the akpm

[PATCH] mm/madvise: reduce code duplication in error handling paths

2019-07-31 Thread Mike Rapoport
The madvise_behavior() function converts -ENOMEM to -EAGAIN in several places using identical code. Move that code to a common error handling path. No functional changes. Signed-off-by: Mike Rapoport --- mm/madvise.c | 52 1 file changed, 16

setup_boot_APIC_clock() NULL dereference during early boot on reduced hardware platforms

2019-07-31 Thread Daniel Drake
Hi, Working with a new consumer laptop based on AMD R7-3700U, we are seeing a kernel panic during early boot (before the display initializes). It's a new product and there is no previous known working kernel version (tested 5.0, 5.2 and current linus master). We may have also seen this problem on

Re: [PATCH 1/7] mtd: spi-nor: Add default_init() hook to tweak flash parameters

2019-07-31 Thread Boris Brezillon
On Wed, 31 Jul 2019 09:03:27 + wrote: > From: Tudor Ambarus > > As of now, the flash parameters initialization logic is as following: > > a/ default flash parameters init in spi_nor_init_params() > b/ manufacturer specific flash parameters updates, split across entire >spi-nor core cod

Re: [PATCH v6 1/2] mtd: rawnand: Add Macronix raw NAND controller driver

2019-07-31 Thread Boris Brezillon
On Thu, 1 Aug 2019 11:55:09 +0800 Mason Yang wrote: > Add a driver for Macronix raw NAND controller. > > Signed-off-by: Mason Yang > --- > drivers/mtd/nand/raw/Kconfig | 6 + > drivers/mtd/nand/raw/Makefile| 1 + > drivers/mtd/nand/raw/mxic_nand.c | 554 >

Re: [PATCH v2] PM/sleep: Expose suspend stats in sysfs

2019-07-31 Thread Greg KH
On Wed, Jul 31, 2019 at 02:29:33PM -0700, Kalesh Singh wrote: > Userspace can get suspend stats from the suspend stats debugfs node. > Since debugfs doesn't have stable ABI, expose suspend stats in > sysfs under /sys/power/suspend_stats. > > Signed-off-by: Kalesh Singh > --- > Changes in v2: >

Re: [PATCH 2/3] firmware: add offset to request_firmware_into_buf

2019-07-31 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2019 at 05:18:32PM -0700, Scott Branden wrote: > Hi Greg, > > I am now back from leave to continue this patch.  Comment below. > > On 2019-05-23 10:22 p.m., Greg Kroah-Hartman wrote: > > On Thu, May 23, 2019 at 10:01:38PM -0700, Scott Branden wrote: > > > On 2019-05-23 9:54 a.m.,

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-31 Thread Viresh Kumar
On 31-07-19, 17:20, Doug Smythies wrote: > Hi Viresh, > > Summary: > > The old way, using UINT_MAX had two purposes: first, > as a "need to do a frequency update" flag; but also second, to > force any subsequent old/new frequency comparison to NOT be "the same, > so why bother actually updating"

[BUG] lseek on /proc/meminfo is broken in 4.19.59

2019-07-31 Thread Sergei Turchanov
Hello! (I sent this e-mail two weeks ago with no feedback. Does anyone care? Wrong mailing list? Anything?) Seeking (to an offset within file size) in /proc/meminfo is broken in 4.19.59. It does seek to a desired position, but reading from that position returns the remainder of file and

Re: [PATCH v4] modpost: check for static EXPORT_SYMBOL* functions

2019-07-31 Thread Denis Efremov
On 01.08.2019 05:20, Masahiro Yamada wrote: The build time impact is very limited. I guess this measurement is unnecessary in the commit log. Thank you for your observations! It was not easy for me to guess to do it this way because of my limited knowledge about kbuild && modpost work. In v5

Re: linux-next: build warning after merge of the akpm-current tree

2019-07-31 Thread Michal Hocko
On Thu 01-08-19 15:51:30, Stephen Rothwell wrote: > Hi Miles, > > On Wed, 31 Jul 2019 14:28:04 +0800 Miles Chen wrote: > > > > On Wed, 2019-07-31 at 16:11 +1000, Stephen Rothwell wrote: > > > > > > After merging the akpm-current tree, today's linux-next build (powerpc > > > ppc64_defconfig) prod

linux-next: Tree for Aug 1

2019-07-31 Thread Stephen Rothwell
Hi all, Changes since 20190731: New trees: pidfd-fixes, renesas-geert My fixes tree contains: 15b9fc624ba4 ("drivers/macintosh/smu.c: Mark expected switch fall-through") The pm tree lost its build failure. The drm-misc tree gained a build failure so I used the version from nex

Re: [PATCH v2] powerpc: Support CMDLINE_EXTEND

2019-07-31 Thread Christophe Leroy
Le 01/08/2019 à 04:12, Chris Packham a écrit : Bring powerpc in line with other architectures that support extending or overriding the bootloader provided command line. The current behaviour is most like CMDLINE_FROM_BOOTLOADER where the bootloader command line is preferred but the kernel con

Re: [PATCH v1] drivers/base/memory.c: Don't store end_section_nr in memory blocks

2019-07-31 Thread Michal Hocko
On Wed 31-07-19 16:43:58, David Hildenbrand wrote: > On 31.07.19 16:37, Michal Hocko wrote: > > On Wed 31-07-19 16:21:46, David Hildenbrand wrote: > > [...] > >>> Thinking about it some more, I believe that we can reasonably provide > >>> both APIs controlable by a command line parameter for backwa

Re: [PATCH v9 10/21] mm: Add generic p?d_leaf() macros

2019-07-31 Thread Anshuman Khandual
On 07/29/2019 06:20 PM, Mark Rutland wrote: > On Sun, Jul 28, 2019 at 05:14:31PM +0530, Anshuman Khandual wrote: >> On 07/23/2019 03:11 PM, Mark Rutland wrote: >>> It might also be worth pointing out the reasons for this naming, e.g. >>> p?d_large() aren't currently generic, and this name minimi

Re: [PATCH v9 0/7] Solve postboot supplier cleanup and optimize probe ordering

2019-07-31 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2019 at 03:17:13PM -0700, Saravana Kannan wrote: > Add device-links to track functional dependencies between devices > after they are created (but before they are probed) by looking at > their common DT bindings like clocks, interconnects, etc. > > Having functional dependencies au

Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use

2019-07-31 Thread hpa
On July 31, 2019 4:55:47 PM PDT, Miguel Ojeda wrote: >On Wed, Jul 31, 2019 at 11:01 PM wrote: >> >> The standard is moving toward adding this as an attribute with the >[[fallthrough]] syntax; it is in C++17, not sure when it will be in C >be if it isn't already. > >Not yet, but it seems to be co

Re: [PATCH] ACPI: PM: Fix regression in acpi_device_set_power()

2019-07-31 Thread Kai-Heng Feng
at 07:31, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Commit f850a48a0799 ("ACPI: PM: Allow transitions to D0 to occur in special cases") overlooked the fact that acpi_power_transition() may change the power.state value for the target device and if that happens, it may confuse acpi_devic

Re: linux-next: build warning after merge of the driver-core tree

2019-07-31 Thread Greg KH
On Thu, Aug 01, 2019 at 03:05:37PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the driver-core tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > drivers/i2c/i2c-core-acpi.c:347:12: warning: 'i2c_acpi_find_match_adapter' > defined but not used [-Wunu

Re: [PATCHv5 25/37] x86/vdso: Switch image on setns()/clone()

2019-07-31 Thread hpa
On July 31, 2019 10:34:26 PM PDT, Andy Lutomirski wrote: >On Mon, Jul 29, 2019 at 2:58 PM Dmitry Safonov wrote: >> >> As it has been discussed on timens RFC, adding a new conditional >branch >> `if (inside_time_ns)` on VDSO for all processes is undesirable. >> It will add a penalty for everybody

Re: [PATCH] mailbox: imx: Fix Tx doorbell shutdown path

2019-07-31 Thread Oleksij Rempel
Hi Daniel, your patch is in conflicht with Richard's Zhu patch "[PATCH v3] mailbox: imx: add support for imx v1 mu". Please sync your works. On Wed, Jul 31, 2019 at 11:55:39PM +0300, Daniel Baluta wrote: > Tx doorbell is handled by txdb_tasklet and doesn't > have an associated IRQ. > > Anyhow,

Re: [PATCH v9 10/21] mm: Add generic p?d_leaf() macros

2019-07-31 Thread Anshuman Khandual
On 07/29/2019 05:08 PM, Steven Price wrote: > On 28/07/2019 12:44, Anshuman Khandual wrote: >> >> >> On 07/23/2019 03:11 PM, Mark Rutland wrote: >>> On Mon, Jul 22, 2019 at 04:41:59PM +0100, Steven Price wrote: Exposing the pud/pgd levels of the page tables to walk_page_range() means w

[PATCH v5] modpost: check for static EXPORT_SYMBOL* functions

2019-07-31 Thread Denis Efremov
This patch adds a check to warn about static EXPORT_SYMBOL* functions during the modpost. In most of the cases, a static symbol marked for exporting is an odd combination that should be fixed either by deleting the exporting mark or by removing the static attribute and adding the appropriate declar

Re: [PATCH v6 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings

2019-07-31 Thread Boris Brezillon
On Thu, 1 Aug 2019 11:55:10 +0800 Mason Yang wrote: > Document the bindings used by the Macronix raw NAND controller. > > Signed-off-by: Mason Yang > --- > Documentation/devicetree/bindings/mtd/mxic-nand.txt | 19 +++ > 1 file changed, 19 insertions(+) > create mode 100644 Do

Re: linux-next: build warning after merge of the akpm-current tree

2019-07-31 Thread Stephen Rothwell
Hi Miles, On Wed, 31 Jul 2019 14:28:04 +0800 Miles Chen wrote: > > On Wed, 2019-07-31 at 16:11 +1000, Stephen Rothwell wrote: > > > > After merging the akpm-current tree, today's linux-next build (powerpc > > ppc64_defconfig) produced this warning: > > > > mm/memcontrol.c: In function 'invalida

Re: [PATCH v3 2/3] mtd: spi-nor: Move m25p80 code in spi-nor.c

2019-07-31 Thread Boris Brezillon
On Thu, 1 Aug 2019 10:00:51 +0530 Vignesh Raghavendra wrote: > From: Boris Brezillon > > The m25p80 driver is actually a generic wrapper around the spi-mem > layer. Not only the driver name is misleading, but we'd expect such a > common logic to be directly available in the core. Another reason

Re: [PATCH] fork: Improve error message for corrupted page tables

2019-07-31 Thread Anshuman Khandual
On 07/31/2019 03:48 AM, Sai Praneeth Prakhya wrote: > When a user process exits, the kernel cleans up the mm_struct of the user > process and during cleanup, check_mm() checks the page tables of the user > process for corruption (E.g: unexpected page flags set/cleared). For > corrupted page tabl

Re: [PATCH v3 1/3] mtd: spi-nor: always use bounce buffer for register read/writes

2019-07-31 Thread Boris Brezillon
On Thu, 1 Aug 2019 10:00:50 +0530 Vignesh Raghavendra wrote: > spi-mem layer expects all buffers passed to it to be DMA'able. But > spi-nor layer mostly allocates buffers on stack for reading/writing to > registers and therefore are not DMA'able. Introduce bounce buffer to be > used to read/write

Re: [PATCH 0/3] ARM: dts: aspeed: Deprecate g[45]-style compatibles

2019-07-31 Thread Andrew Jeffery
On Tue, 30 Jul 2019, at 10:27, Andrew Jeffery wrote: > > > On Tue, 30 Jul 2019, at 07:23, Linus Walleij wrote: > > On Wed, Jul 24, 2019 at 10:13 AM Andrew Jeffery wrote: > > > > > It's probably best if we push the three patches all through one tree > > > rather > > > than fragmenting. Is ev

Re: [PATCH 7/9] media: hantro: Add core bits to support H264 decoding

2019-07-31 Thread Boris Brezillon
On Thu, 1 Aug 2019 13:06:10 +0900 Tomasz Figa wrote: > Hi Boris, > > On Wed, Jun 19, 2019 at 9:15 PM Boris Brezillon > wrote: > [snip] > > @@ -533,10 +535,21 @@ hantro_queue_setup(struct vb2_queue *vq, unsigned int > > *num_buffers, > > return -EINVAL; > > } > > > > +

Re: [PATCH v7 11/20] cpufreq: tegra124: Add suspend and resume support

2019-07-31 Thread Viresh Kumar
On 31-07-19, 14:10, Sowjanya Komatineni wrote: > This patch adds suspend and resume pm ops for cpufreq driver. > > PLLP is the safe clock source for CPU during system suspend and > resume as PLLP rate is below the CPU Fmax at Vmin. > > CPUFreq driver suspend switches the CPU clock source to PLLP

Re: [PATCHv5 25/37] x86/vdso: Switch image on setns()/clone()

2019-07-31 Thread Andy Lutomirski
On Mon, Jul 29, 2019 at 2:58 PM Dmitry Safonov wrote: > > As it has been discussed on timens RFC, adding a new conditional branch > `if (inside_time_ns)` on VDSO for all processes is undesirable. > It will add a penalty for everybody as branch predictor may mispredict > the jump. Also there are in

Re: [PATCH v3 3/4] arm64: Make debug exception handlers visible from RCU

2019-07-31 Thread Masami Hiramatsu
Hi Will, On Wed, 31 Jul 2019 18:26:03 +0100 Will Deacon wrote: > On Thu, Jul 25, 2019 at 05:16:15PM +0900, Masami Hiramatsu wrote: > > Make debug exceptions visible from RCU so that synchronize_rcu() > > correctly track the debug exception handler. > > > > This also introduces sanity checks for

Re: [linux-sunxi] Re: [PATCH v4 6/9] ASoC: sun4i-i2s: Add multi-lane functionality

2019-07-31 Thread Jernej Škrabec
Dne sreda, 31. julij 2019 ob 14:29:53 CEST je Maxime Ripard napisal(a): > On Tue, Jul 30, 2019 at 07:57:10PM +0200, Jernej Škrabec wrote: > > Dne torek, 04. junij 2019 ob 11:38:44 CEST je Code Kipper napisal(a): > > > On Tue, 4 Jun 2019 at 11:02, Christopher Obbard wrote: > > > > On Tue, 4 Jun 20

Re: [PATCHv5 01/37] ns: Introduce Time Namespace

2019-07-31 Thread Andy Lutomirski
On Mon, Jul 29, 2019 at 2:58 PM Dmitry Safonov wrote: > > From: Andrei Vagin > > Time Namespace isolates clock values. > +static int timens_install(struct nsproxy *nsproxy, struct ns_common *new) > +{ > + struct time_namespace *ns = to_time_ns(new); > + > + if (!thread_group_empty(cu

Re: [PATCHv5 21/37] x86/vdso: Restrict splitting VVAR VMA

2019-07-31 Thread Andy Lutomirski
On Mon, Jul 29, 2019 at 2:58 PM Dmitry Safonov wrote: > > Although, time namespace can work with VVAR VMA split, it seems worth > to forbid splitting VVAR resulting in stricter ABI and reducing amount > of corner-cases to consider while working further on VDSO. > > I don't think there is any use-c

Re: [PATCHv5 23/37] x86/vdso: Add offsets page in vvar

2019-07-31 Thread Andy Lutomirski
On Mon, Jul 29, 2019 at 2:58 PM Dmitry Safonov wrote: > > From: Andrei Vagin > > As modern applications fetch time from VDSO without entering the kernel, > it's needed to provide offsets for userspace code inside time namespace. > > A page for timens offsets is allocated on time namespace constru

Re: [PATCHv5 28/37] x86/vdso: Enable static branches for the timens vdso

2019-07-31 Thread Andy Lutomirski
On Mon, Jul 29, 2019 at 2:58 PM Dmitry Safonov wrote: > > From: Andrei Vagin > > As it has been discussed on timens RFC, adding a new conditional branch > `if (inside_time_ns)` on VDSO for all processes is undesirable. > > Addressing those problems, there are two versions of VDSO's .so: > for hos

Re: [PATCH net-next 1/2] net: phy: broadcom: set features explicitly for BCM54616S

2019-07-31 Thread Tao Ren
On 7/30/19 11:00 PM, Tao Ren wrote: > On 7/30/19 10:53 PM, Heiner Kallweit wrote: >> On 31.07.2019 02:12, Tao Ren wrote: >>> On 7/29/19 11:00 PM, Heiner Kallweit wrote: On 30.07.2019 07:05, Tao Ren wrote: > On 7/29/19 8:35 PM, Andrew Lunn wrote: >> On Mon, Jul 29, 2019 at 05:25:32PM -0

[PATCH 3/5] x86: KVM: svm: clear interrupt shadow on all paths in skip_emulated_instruction()

2019-07-31 Thread Vitaly Kuznetsov
Regardless of the way how we skip instruction, interrupt shadow needs to be cleared. Signed-off-by: Vitaly Kuznetsov Reviewed-by: Jim Mattson --- arch/x86/kvm/svm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 80f576e05112.

[PATCH 0/5] x86: KVM: svm: get rid of hardcoded instructions lengths

2019-07-31 Thread Vitaly Kuznetsov
Changes since RFC (It's been awhile and I apologize for that): - Dropped ' + 3' from vmrun_interception() as well. - Added xsetbv's implementation to the emulator [Paolo Bonzini] - Added Jim's R-b tags to PATCHes 2 and 3. - Tested with the newly added 'nrips' svm module parameter. Original descri

[PATCH 4/5] x86: KVM: add xsetbv to the emulator

2019-07-31 Thread Vitaly Kuznetsov
To avoid hardcoding xsetbv length to '3' we need to support decoding it in the emulator. Signed-off-by: Vitaly Kuznetsov --- arch/x86/include/asm/kvm_emulate.h | 3 ++- arch/x86/kvm/emulate.c | 23 ++- arch/x86/kvm/svm.c | 1 + arch/x86/kvm/x86.c

[PATCH 2/5] x86: KVM: svm: avoid flooding logs when skip_emulated_instruction() fails

2019-07-31 Thread Vitaly Kuznetsov
When we're unable to skip instruction with kvm_emulate_instruction() we will not advance RIP and most likely the guest will get stuck as consequitive attempts to execute the same instruction will likely result in the same behavior. As we're not supposed to see these messages under normal condition

[PATCH 1/5] x86: KVM: svm: don't pretend to advance RIP in case wrmsr_interception() results in #GP

2019-07-31 Thread Vitaly Kuznetsov
svm->next_rip is only used by skip_emulated_instruction() and in case kvm_set_msr() fails we rightfully don't do that. Move svm->next_rip advancement to 'else' branch to avoid creating false impression that it's always advanced (and make it look like rdmsr_interception()). This is a preparatory ch

[PATCH 5/5] x86: KVM: svm: remove hardcoded instruction length from intercepts

2019-07-31 Thread Vitaly Kuznetsov
Various intercepts hard-code the respective instruction lengths to optimize skip_emulated_instruction(): when next_rip is pre-set we skip kvm_emulate_instruction(vcpu, EMULTYPE_SKIP). The optimization is, however, incorrect: different (redundant) prefixes could be used to enlarge the instruction. W

Re: [PATCH v2] media:dvb-frontends:Remove dvb_pll_devcount and id module parameters.

2019-07-31 Thread Sean Young
On Wed, Jul 24, 2019 at 06:36:35AM +0100, Sean Young wrote: > On Sat, Jul 20, 2019 at 11:43:02AM +0530, Vandana BN wrote: > > Syzbot reported global-out-of-bounds Read in dvb_pll_attach, while > > accessing id[dvb_pll_devcount], because dvb_pll_devcount was 65, > > that is more than size of 'id' wh

Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-07-31 Thread Tao Ren
On 7/30/19 10:55 PM, Tao Ren wrote: > On 7/30/19 7:34 PM, Andrew Lunn wrote: >>> Hi Andrew, >>> >>> The BCM54616S PHY on my machine is connected to a BCM5396 switch chip over >>> backplane (1000Base-KX). >> >> Ah, that is different. So the board is using it for RGMII to 1000Base-KX? >> >> phy-mode

linux-next: build warning after merge of the driver-core tree

2019-07-31 Thread Stephen Rothwell
Hi all, After merging the driver-core tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/i2c/i2c-core-acpi.c:347:12: warning: 'i2c_acpi_find_match_adapter' defined but not used [-Wunused-function] static int i2c_acpi_find_match_adapter(struct device *dev, const

Re: [PATCH V2 4/9] vhost: reset invalidate_count in vhost_set_vring_num_addr()

2019-07-31 Thread Jason Wang
On 2019/8/1 上午3:32, Jason Gunthorpe wrote: On Wed, Jul 31, 2019 at 09:29:28PM +0800, Jason Wang wrote: On 2019/7/31 下午8:41, Jason Gunthorpe wrote: On Wed, Jul 31, 2019 at 04:46:50AM -0400, Jason Wang wrote: The vhost_set_vring_num_addr() could be called in the middle of invalidate_range_star

Re: [PATCH V2 7/9] vhost: do not use RCU to synchronize MMU notifier with worker

2019-07-31 Thread Jason Wang
On 2019/8/1 上午3:30, Jason Gunthorpe wrote: On Wed, Jul 31, 2019 at 09:28:20PM +0800, Jason Wang wrote: On 2019/7/31 下午8:39, Jason Gunthorpe wrote: On Wed, Jul 31, 2019 at 04:46:53AM -0400, Jason Wang wrote: We used to use RCU to synchronize MMU notifier with worker. This leads calling synchr

Re: [PATCH] linux-next 20190731 - aegis128-core.c fails to build

2019-07-31 Thread Ard Biesheuvel
(+ Arnd) On Thu, 1 Aug 2019 at 07:52, Valdis Klētnieks wrote: > > The recent NEON SIMD patches break the build if CONFIG_CRYPTO_AEGIS128_SIMD > isn't set: > > MODPOST 558 modules > ERROR: "crypto_aegis128_decrypt_chunk_simd" [crypto/aegis128.ko] undefined! > ERROR: "crypto_aegis128_update_simd

RE: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups()

2019-07-31 Thread Naga Sureshkumar Relli
Hi Tudor, > -Original Message- > From: tudor.amba...@microchip.com > Sent: Wednesday, July 31, 2019 6:37 PM > To: Naga Sureshkumar Relli ; > boris.brezil...@collabora.com; > marek.va...@gmail.com; vigne...@ti.com > Cc: rich...@nod.at; linux-kernel@vger.kernel.org; > linux-...@lists.infr

RE: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups()

2019-07-31 Thread Naga Sureshkumar Relli
> -Original Message- > From: Boris Brezillon > Sent: Wednesday, July 31, 2019 6:08 PM > To: Naga Sureshkumar Relli > Cc: tudor.amba...@microchip.com; marek.va...@gmail.com; vigne...@ti.com; > rich...@nod.at; linux-kernel@vger.kernel.org; linux-...@lists.infradead.org; > miquel.ray...@b

[PATCH v3 1/3] mtd: spi-nor: always use bounce buffer for register read/writes

2019-07-31 Thread Vignesh Raghavendra
spi-mem layer expects all buffers passed to it to be DMA'able. But spi-nor layer mostly allocates buffers on stack for reading/writing to registers and therefore are not DMA'able. Introduce bounce buffer to be used to read/write to registers. This ensures that buffer passed to spi-mem layer during

[PATCH v3 2/3] mtd: spi-nor: Move m25p80 code in spi-nor.c

2019-07-31 Thread Vignesh Raghavendra
From: Boris Brezillon The m25p80 driver is actually a generic wrapper around the spi-mem layer. Not only the driver name is misleading, but we'd expect such a common logic to be directly available in the core. Another reason for moving this code is that SPI NOR controller drivers should progressi

[PATCH v3 3/3] mtd: spi-nor: Rework hwcaps selection for the spi-mem case

2019-07-31 Thread Vignesh Raghavendra
From: Boris Brezillon The spi-mem layer provides a spi_mem_supports_op() function to check whether a specific operation is supported by the controller or not. This is much more accurate than the hwcaps selection logic based on SPI_{RX,TX}_ flags. Rework the hwcaps selection logic to use spi_mem_

[PATCH v3 0/3] Merge m25p80 into spi-nor

2019-07-31 Thread Vignesh Raghavendra
This is repost of patch 6 and 7 split from from Boris Brezillon's X-X-X mode support series[1] Background from cover letter for RFC[1]: m25p80 is just a simple SPI NOR controller driver (a wrapper around the SPI mem API). Not only it shouldn't be named after a specific SPI NOR chip, but it also do

Re: [PATCH] fork: Improve error message for corrupted page tables

2019-07-31 Thread Andrew Morton
On Wed, 31 Jul 2019 15:36:49 -0700 Sai Praneeth Prakhya wrote: > > > +static const char * const resident_page_types[NR_MM_COUNTERS] = { > > > + "MM_FILEPAGES", > > > + "MM_ANONPAGES", > > > + "MM_SWAPENTS", > > > + "MM_SHMEMPAGES", > > > +}; > > > > But please let's not put this in a header fil

Re: [PATCH 2/2] net: gmii2rgmii: Switch priv field in mdio device structure

2019-07-31 Thread Andrew Lunn
On Wed, Jul 31, 2019 at 03:06:19PM +0530, Harini Katakam wrote: > Use the priv field in mdio device structure instead of the one in > phy device structure. The phy device priv field may be used by the > external phy driver and should not be overwritten. Hi Harini I _think_ you could use dev_set_d

Re: [PATCH 7/9] media: hantro: Add core bits to support H264 decoding

2019-07-31 Thread Tomasz Figa
Hi Boris, On Wed, Jun 19, 2019 at 9:15 PM Boris Brezillon wrote: [snip] > @@ -533,10 +535,21 @@ hantro_queue_setup(struct vb2_queue *vq, unsigned int > *num_buffers, > return -EINVAL; > } > > + /* The H264 decoder needs extra size on the output buffer. */ > +

[PATCH net-next 05/12] net: hns3: remove unnecessary variable in hclge_get_mac_vlan_cmd_status()

2019-07-31 Thread Huazhong Tan
From: Jian Shen The local variable return_status in hclge_get_mac_val_cmd_status() is useless. So this patch returns the error code directly, instead of using this variable. Also, replace some '%d' with '%u' in hclge_get_mac_val_cmd_status(). Signed-off-by: Jian Shen Reviewed-by: Peng Li Signe

[PATCH net-next 10/12] net: hns3: fix some reset handshake issue

2019-07-31 Thread Huazhong Tan
Currently, the driver sets handshake status to tell the hardware that the driver have downed the netdev and it can continue with reset process. The driver will clear the handshake status when re-initializing the CMDQ, and does not recover this status when reset fail, which may cause the hardware to

[PATCH net-next 00/12] net: hns3: some code optimizations & bugfixes & features

2019-07-31 Thread Huazhong Tan
This patch-set includes code optimizations, bugfixes and features for the HNS3 ethernet controller driver. [patch 01/12] adds support for reporting link change event. [patch 02/12] adds handler for NCSI error. [patch 03/12] fixes bug related to debugfs. [patch 04/12] adds a code optimization fo

[PATCH net-next 02/12] net: hns3: add handler for NCSI error mailbox

2019-07-31 Thread Huazhong Tan
When NCSI has HW error, the IMP will report this error to the driver by sending a mailbox. After received this message, the driver should assert a global reset to fix this kind of HW error. Signed-off-by: Huazhong Tan Reviewed-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h

[PATCH net-next 01/12] net: hns3: add link change event report

2019-07-31 Thread Huazhong Tan
From: Jian Shen Previously, PF updates link status per second. For some scenario, it requires link down event being reported more quickly. To solve it, firmware pushes the link change event to PF with CMDQ message, and driver updates the link status directly. Signed-off-by: Jian Shen Reviewed-b

[PATCH net-next 03/12] net: hns3: do not query unsupported commands in debugfs

2019-07-31 Thread Huazhong Tan
From: Yufeng Mo Some commands are not supported on DCB-unsupported ports. This patch distinguishes these commands and does not query unsupported commands in debugfs. This patch also fix an error in the dump "qos buf cfg" command in debugfs. Fixes: 2849d4e7a1be ("net: hns3: Add "tc config" info

[PATCH net-next 09/12] net: hns3: rename a member in struct hclge_mac_ethertype_idx_rd_cmd

2019-07-31 Thread Huazhong Tan
From: Guojia Liao The member 'mac_add' defined in hclge_mac_ethertype_idx_rd_cmd means MAC address, so 'mac_addr' is a better name for it. Signed-off-by: Guojia Liao Signed-off-by: Guangbin Huang Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 2 +

[PATCH net-next 07/12] net: hns3: minior error handling change for hclge_tm_schd_info_init

2019-07-31 Thread Huazhong Tan
From: Yunsheng Lin When hclge_tm_schd_info_update calls hclge_tm_schd_info_init to initialize the schedule info, hdev->tm_info.num_pg and hdev->tx_sch_mode is not changed, which makes the checking in hclge_tm_schd_info_init unnecessary. So this patch moves the hdev->tm_info.num_pg and hdev->tx_s

[PATCH net-next 08/12] net: hns3: simplify hclge_cmd_query_error()

2019-07-31 Thread Huazhong Tan
From: Weihang Li The 4th and 5th parameter of hclge_cmd_query_error is useless, so this patch removes them. Signed-off-by: Weihang Li Reviewed-by: Peng Li Signed-off-by: Huazhong Tan --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c| 19 +-- 1 file changed, 5 inserti

[PATCH net-next 06/12] net: hns3: minor cleanup in hns3_clean_rx_ring

2019-07-31 Thread Huazhong Tan
From: Yunsheng Lin The unused_count variable is used to indicate how many RX BD need attaching new buffer in hns3_clean_rx_ring, and the clean_count variable has the similar meaning. This patch removes the clean_count variable and use unused_count to uniformly indicate the RX BD that need attach

[PATCH net-next 04/12] net: hns3: refine for set ring parameters

2019-07-31 Thread Huazhong Tan
From: Jian Shen Previously, when changing the ring parameters, we free the old ring resources firstly, and then setup the new ring resources. In some case of an memory allocation fail, there will be no resources to use. This patch refines it by setup new ring resources and free the old ring resou

[PATCH net-next 12/12] net: hns3: activate reset timer when calling reset_event

2019-07-31 Thread Huazhong Tan
When calling hclge_reset_event() within HCLGE_RESET_INTERVAL, it returns directly now. If no one call it again, then the error which needs a reset to fix it can not be fixed. So this patch activates the reset timer for this case, and adds checking in the end of the reset procedure to make this err

[PATCH net-next 11/12] net: hns3: clear reset interrupt status in hclge_irq_handle()

2019-07-31 Thread Huazhong Tan
Currently, the reset interrupt is cleared in the reset task, which is too late. Since, when the hardware finish the previous reset, it can begin to do a new global/IMP reset, if this new coming reset type is same as the previous one, the driver will clear them together, then driver can not get that

Re: [PATCH net-next v2 4/4] net: ftgmac100: Select ASPEED MDIO driver for the AST2600

2019-07-31 Thread Andrew Lunn
On Wed, Jul 31, 2019 at 03:09:59PM +0930, Andrew Jeffery wrote: > Ensures we can talk to a PHY via MDIO on the AST2600, as the MDIO > controller is now separate from the MAC. > > Signed-off-by: Andrew Jeffery Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v2 3/4] net: ftgmac100: Add support for DT phy-handle property

2019-07-31 Thread Andrew Lunn
On Wed, Jul 31, 2019 at 03:09:58PM +0930, Andrew Jeffery wrote: > phy-handle is necessary for the AST2600 which separates the MDIO > controllers from the MAC. > > I've tried to minimise the intrusion of supporting the AST2600 to the > FTGMAC100 by leaving in place the existing MDIO support for the

Re: [PATCH net-next v2 2/4] net: phy: Add mdio-aspeed

2019-07-31 Thread Andrew Lunn
On Wed, Jul 31, 2019 at 03:09:57PM +0930, Andrew Jeffery wrote: > The AST2600 design separates the MDIO controllers from the MAC, which is > where they were placed in the AST2400 and AST2500. Further, the register > interface is reworked again, so now we have three possible different > interface im

Re: [PATCH net-next v2 6/6] net: dsa: mv88e6xxx: add PTP support for MV88E6250 family

2019-07-31 Thread Andrew Lunn
On Wed, Jul 31, 2019 at 10:23:51AM +0200, Hubert Feurstein wrote: > This adds PTP support for the MV88E6250 family. > > Signed-off-by: Hubert Feurstein Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v2 5/6] net: dsa: mv88e6xxx: order ptp structs numerically ascending

2019-07-31 Thread Andrew Lunn
On Wed, Jul 31, 2019 at 10:23:50AM +0200, Hubert Feurstein wrote: > As it is done for all the other structs within this driver. > > Signed-off-by: Hubert Feurstein Reviewed-by: Andrew Lunn Andrew

[PATCH v3 06/26] drm: kirin: Remove out_format from ade_crtc

2019-07-31 Thread John Stultz
From: Xu YiPing As part of refactoring the kirin driver to better support different hardware revisions, this patch removes the out_format field in the struct ade_crtc, which was only ever set to LDI_OUT_RGB_888. Thus this patch removes the field and instead directly uses LDI_OUT_RGB_888. Cc: Ro

[PATCH v3 05/26] drm: kirin: Remove uncessary parameter indirection

2019-07-31 Thread John Stultz
From: Xu YiPing In a few functions, we pass in a struct ade_crtc, which we only use to get to the underlying struct ade_hw_ctx. Thus this patch refactors the functions to just take the struct ade_hw_ctx directly. Cc: Rongrong Zou Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel Cc: Sam Ravn

Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: introduce invalid_port_mask in mv88e6xxx_info

2019-07-31 Thread Andrew Lunn
On Wed, Jul 31, 2019 at 10:23:48AM +0200, Hubert Feurstein wrote: > With this it is possible to mark certain chip ports as invalid. This is > required for example for the MV88E6220 (which is in general a MV88E6250 > with 7 ports) but the ports 2-4 are not routed to pins. > > If a user configures a

  1   2   3   4   5   6   7   8   9   10   >