[PATCH] ACPI/IORT: Fix build without CONFIG_IOMMU_API

2019-05-19 Thread Christoph Hellwig
IOMMU_FWSPEC_PCI_RC_ATS is only defined if CONFIG_IOMMU_API is enabled. Fixes: 5702ee24182f ("ACPI/IORT: Check ATS capability in root complex nodes") Signed-off-by: Christoph Hellwig --- drivers/acpi/arm64/iort.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/

Re: [Patch] perf stat: always separate stalled cycles per insn

2019-05-19 Thread Jiri Olsa
On Fri, May 17, 2019 at 03:10:39PM -0700, Cong Wang wrote: > The "stalled cycles per insn" is appended to "instructions" when > the CPU has this hardware counter directly. We should always make it > a separate line, which also aligns to the output when we hit the > "if (total && avg)" branch. > >

[PATCH v3 1/3] PM: wakeup: Add routine to help fetch wakeup source object.

2019-05-19 Thread Ran Wang
Some user might want to go through all registered wakeup sources and doing things accordingly. For example, SoC PM driver might need to do HW programming to prevent powering down specific IP which wakeup source depending on. And is user's responsibility to identify if this wakeup source he is inter

[PATCH v3 2/3] Documentation: dt: binding: fsl: Add 'little-endian' and update Chassis define

2019-05-19 Thread Ran Wang
By default, QorIQ SoC's RCPM register block is Big Endian. But there are some exceptions, such as LS1088A and LS2088A, are Little Endian. So add this optional property to help identify them. Actually LS2021A and other Layerscapes won't totally follow Chassis 2.1, so separate them from powerpc SoC.

[PATCH v3 3/3] soc: fsl: add RCPM driver

2019-05-19 Thread Ran Wang
The NXP's QorIQ Processors based on ARM Core have RCPM module (Run Control and Power Management), which performs all device-level tasks associated with power management such as wakeup source control. This driver depends on PM wakeup source framework which help to collect wake information. Signed-

sound/soc//intel/boards/bxt_da7219_max98357a.c:19:10: fatal error: asm/cpu_device_id.h: No such file or directory

2019-05-19 Thread kbuild test robot
Hi Mark, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a188339ca5a396acc588e5851ed7e19f66b0ebd9 commit: 164a263bf8d003e4cbb197d52b74d26df72604d7 ASoC: Intel: Make boards more available for compile test date: 3 w

[PATCH] pstore: Set tfm to NULL on free_buf_for_compression.

2019-05-19 Thread Pi-Hsun Shih
Set tfm to NULL on free_buf_for_compression after crypto_free_comp. This avoid a use-after-free when allocate_buf_for_compression and free_buf_for_compression are called twice. Although free_buf_for_compression freed the tfm, allocate_buf_for_compression won't reinitialize the tfm since the tfm po

RE: [PATCH V2 3/3] soc: fsl: add RCPM driver

2019-05-19 Thread Ran Wang
Hi Pavel, On Monday, May 20, 2019 05:39, Pavel Machek wrote: > > Hi! > > > > + > > +struct rcpm { > > + unsigned int wakeup_cells; > > + void __iomem *ippdexpcr_base; > > + boollittle_endian; > > +}; > > Inconsistent whitespace OK, will make them aligned. > > > +static int rcpm_pm

Re: [PATCH 1/4] dt-bindings: iio: adc: mediatek: Add document for mt6765

2019-05-19 Thread Chun-Hung Wu
Hi Jonathan, On Sat, 2019-05-18 at 11:33 +0100, Jonathan Cameron wrote: > On Thu, 16 May 2019 16:10:44 +0800 > Chun-Hung Wu wrote: > > > Add compatible node for mt6765 auxadc > > > > Signed-off-by: Chun-Hung Wu > Applied, but in numeric order. There was also another clashing patch > that caus

[PATCH v4] tipc: fix modprobe tipc failed after switch order of device registration

2019-05-19 Thread hujunwei
From: Junwei Hu Error message printed: modprobe: ERROR: could not insert 'tipc': Address family not supported by protocol. when modprobe tipc after the following patch: switch order of device registration, commit 7e27e8d6130c ("tipc: switch order of device registration to fix a crash") Because s

Re: [PATCH v3 4/5] KVM: LAPIC: Delay trace advance expire delta

2019-05-19 Thread Wanpeng Li
On Sat, 18 May 2019 at 03:44, Sean Christopherson wrote: > > On Thu, May 16, 2019 at 11:06:19AM +0800, Wanpeng Li wrote: > > From: Wanpeng Li > > > > wait_lapic_expire() call was moved above guest_enter_irqoff() because of > > its tracepoint, which violated the RCU extended quiescent state invoke

Re: [RFC 0/7] introduce memory hinting API for external process

2019-05-19 Thread Anshuman Khandual
On 05/20/2019 09:22 AM, Minchan Kim wrote: > - Problem > > Naturally, cached apps were dominant consumers of memory on the system. > However, they were not significant consumers of swap even though they are > good candidate for swap. Under investigation, swapping out only begins > once the low

Re: [PATCH RESEND] clk: imx7ulp: update nic1_bus_clk parent info

2019-05-19 Thread Shawn Guo
On Sun, May 12, 2019 at 10:30:41AM +, Anson Huang wrote: > Since i.MX7ULP B0 chip, nic1_bus_clk's parent is changed to > from nic0_clk directly, update it accordingly. > > Signed-off-by: Anson Huang Applied, thanks.

[RESEND PATCH] intel_th: msu: Fix unused variable warning on arm64 platform

2019-05-19 Thread Shaokun Zhang
drivers/hwtracing/intel_th/msu.c: In function ‘msc_buffer_win_alloc’: drivers/hwtracing/intel_th/msu.c:783:21: warning: unused variable ‘i’ [-Wunused-variable] int ret = -ENOMEM, i; ^ drivers/hwtracing/intel_th/msu.c: In function ‘msc_buffer_win_free’: drivers/hwtracing/inte

Re: [PATCH RESEND 1/2] clk: imx: Add common API for masking MMDC handshake

2019-05-19 Thread Shawn Guo
On Sun, May 12, 2019 at 10:24:12AM +, Anson Huang wrote: > All i.MX6 SoCs need to mask unused MMDC channel's handshake > for low power modes, this patch provides common API for masking > the MMDC channel passed from caller. > > Signed-off-by: Anson Huang > Reviewed-by: Dong Aisheng Applied

[GIT] Networking

2019-05-19 Thread David Miller
1) Use after free in __dev_map_entry_free(), from Eric Dumazet. 2) Fix TCP retransmission timestamps on passive Fast Open, from Yuchung Cheng. 3) Orphan NFC, we'll take the patches directly into my tree. From Johannes Berg. 4) We can't recycle cloned TCP skbs, from Eric Dumazet. 5) Som

Re: [PATCH RESEND 1/3] dt-bindings: clock: imx8mm: Add GPIO clocks

2019-05-19 Thread Shawn Guo
On Sun, May 12, 2019 at 10:17:08AM +, Anson Huang wrote: > Add macro for the GPIO clocks of the i.MX8MM. > > Signed-off-by: Anson Huang > Reviewed-by: Dong Aisheng Applied all, thanks.

Re: [PATCH] mm: add account_locked_vm utility function

2019-05-19 Thread Alexey Kardashevskiy
On 04/05/2019 06:16, Daniel Jordan wrote: > locked_vm accounting is done roughly the same way in five places, so > unify them in a helper. Standardize the debug prints, which vary > slightly. And I rather liked that prints were different and tell precisely which one of three each printk is. I

Re: [PATCH V2 0/5] cpufreq: Use QoS layer to manage freq-constraints

2019-05-19 Thread Viresh Kumar
On 21-02-19, 12:30, Rafael J. Wysocki wrote: > On Thursday, February 21, 2019 12:29:26 PM CET Viresh Kumar wrote: > > Hello, > > > > This patchset attempts to manage CPU frequency constraints using the PM > > QoS framework. It only does the basic stuff right now and moves the > > userspace constra

Re: [PATCH 1/2] eeprom: at24: use devm_i2c_new_dummy_device()

2019-05-19 Thread Bartosz Golaszewski
niedz., 19 maj 2019 o 22:52 Wolfram Sang napisał(a): > > > > Now that it's upstream, use the resource managed version > > of i2c_new_dummy(). > > That was fast :) > > > - dummy_client = i2c_new_dummy(base_client->adapter, > > - base_client->addr + index); > > +

Re: [PATCH 4/4] iio: auxadc: mediatek: change to subsys_initcall

2019-05-19 Thread Chun-Hung Wu
Hi Jonathan, On Sat, 2019-05-18 at 11:36 +0100, Jonathan Cameron wrote: > On Thu, 16 May 2019 16:10:47 +0800 > Chun-Hung Wu wrote: > > > Move auxadc platform_driver_register() from module_init > > to subsys_initcall because auxadc user drivers > > are all moudle drivers, need to gurantee > > a

Re: [PATCH 3/4] iio: adc: mediatek: SET_LATE_SYSTEM_SLEEP_PM_OPS support

2019-05-19 Thread Chun-Hung Wu
Hi Jonathan: Thanks for the prompt reply, On Sat, 2019-05-18 at 11:35 +0100, Jonathan Cameron wrote: > On Thu, 16 May 2019 16:10:46 +0800 > Chun-Hung Wu wrote: > > > Move suspend/resume to late_suspend and > > early_resume to gurantee users can use auxadc > guarantee > will fix it in next

Re: [v2] drm/komeda: Creates plane alpha and blend mode properties

2019-05-19 Thread james qian wang (Arm Technology China)
On Thu, Apr 11, 2019 at 08:37:43AM +, Lowry Li (Arm Technology China) wrote: > Creates plane alpha and blend mode properties attached to plane. > > This patch depends on: > - https://patchwork.freedesktop.org/series/54448/ > - https://patchwork.freedesktop.org/series/54449/ > - https://patchwo

Re: [PATCH] PM: sleep: Add kerneldoc comments to some functions

2019-05-19 Thread Christoph Hellwig
> > +/** > + * pm_suspend_via_firmware - Check if platform firmware will suspend the > system. > + * > + * To be called during system-wide power management transitions to sleep > states. > + * > + * Return 'true' if the platform firmware is going to be invoked at the end > of > + * the system-

[PATCH 3/5] sh: don't use asm-generic/ptrace.h

2019-05-19 Thread Christoph Hellwig
Doing the indirection through macros for the regs accessors just makes them harder to read, so implement the helpers directly. Note that only the helpers actually used are implemented now. Signed-off-by: Christoph Hellwig --- arch/sh/include/asm/ptrace.h | 29 + 1 fi

[PATCH 5/5] asm-generic: remove ptrace.h

2019-05-19 Thread Christoph Hellwig
No one is using this header anymore. Signed-off-by: Christoph Hellwig Acked-by: Arnd Bergmann --- MAINTAINERS| 1 - arch/mips/include/asm/ptrace.h | 5 --- include/asm-generic/ptrace.h | 74 -- 3 files changed, 80 deletions(-) delete mode

[PATCH 4/5] x86: don't use asm-generic/ptrace.h

2019-05-19 Thread Christoph Hellwig
Doing the indirection through macros for the regs accessors just makes them harder to read, so implement the helpers directly. Note that only the helpers actually used are implemented now. Signed-off-by: Christoph Hellwig Acked-by: Ingo Molnar --- arch/x86/include/asm/ptrace.h | 30 +++

remove asm-generic/ptrace.h v2

2019-05-19 Thread Christoph Hellwig
Hi all, asm-generic/ptrace.h is a little weird in that it doesn't actually implement any functionality, but it provided multiple layers of macros that just implement trivial inline functions. We implement those directly in the few architectures and be off with a much simpler design. Changes sinc

[PATCH] powerpc: dts: Fix the bug that intx interrupt not work in P1010RDB-PB

2019-05-19 Thread Xiaowei Bao
Due to the INTA is shared with the active-low PHY2 interrupt on P1010RDB-PA board, so configure P1010RDB-PA's INTA with polarity as active-low, the P1010RDB-PB board is used separately, so configure P1010RDB-PB's INTA with polarity as active-high. The INTX in P1010RDB-PB do not work because of the

[PATCH 2/5] powerpc: don't use asm-generic/ptrace.h

2019-05-19 Thread Christoph Hellwig
Doing the indirection through macros for the regs accessors just makes them harder to read, so implement the helpers directly. Note that only the helpers actually used are implemented now. Signed-off-by: Christoph Hellwig --- arch/powerpc/include/asm/ptrace.h | 29 ++---

[PATCH 1/5] arm64: don't use asm-generic/ptrace.h

2019-05-19 Thread Christoph Hellwig
Doing the indirection through macros for the regs accessors just makes them harder to read, so implement the helpers directly. Note that only the helpers actually used are implemented now. Signed-off-by: Christoph Hellwig Acked-by: Catalin Marinas --- arch/arm64/include/asm/ptrace.h | 31 +

fix filler_t callback type mismatches v2

2019-05-19 Thread Christoph Hellwig
Casting mapping->a_ops->readpage to filler_t causes an indirect call type mismatch with Control-Flow Integrity checking. This change fixes the mismatch in read_cache_page_gfp and read_mapping_page by adding using a NULL filler argument as an indication to call ->readpage directly, and by passing th

Re: PROBLEM: Power9: kernel oops on memory hotunplug from ppc64le guest

2019-05-19 Thread Bharata B Rao
On Mon, May 20, 2019 at 02:48:35PM +1000, Nicholas Piggin wrote: > >> > git bisect points to > >> > > >> > commit 4231aba000f5a4583dd9f67057aadb68c3eca99d > >> > Author: Nicholas Piggin > >> > Date: Fri Jul 27 21:48:17 2018 +1000 > >> > > >> > powerpc/64s: Fix page table fragment refcount ra

[PATCH 3/4] jffs2: pass the correct prototype to read_cache_page

2019-05-19 Thread Christoph Hellwig
Fix the callback jffs2 passes to read_cache_page to actually have the proper type expected. Casting around function pointers can easily hide typing bugs, and defeats control flow protection. Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook --- fs/jffs2/file.c | 4 ++-- fs/jffs2/fs.c

[PATCH 4/4] 9p: pass the correct prototype to read_cache_page

2019-05-19 Thread Christoph Hellwig
Fix the callback 9p passes to read_cache_page to actually have the proper type expected. Casting around function pointers can easily hide typing bugs, and defeats control flow protection. Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook --- fs/9p/vfs_addr.c | 6 -- 1 file changed, 4

[PATCH 2/4] mm: don't cast ->readpage to filler_t for do_read_cache_page

2019-05-19 Thread Christoph Hellwig
We can just pass a NULL filler and do the right thing inside of do_read_cache_page based on the NULL parameter. Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook --- include/linux/pagemap.h | 3 +-- mm/filemap.c| 10 ++ 2 files changed, 7 insertions(+), 6 deletions(-)

[PATCH 1/4] mm: fix an overly long line in read_cache_page

2019-05-19 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook --- mm/filemap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/filemap.c b/mm/filemap.c index c5af80c43d36..6a8048477bc6 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2862,7 +2862,8 @@ struct page *read_cache_p

Re: [RFC PATCH] usb: host: xhci: allow __GFP_FS in dma allocation

2019-05-19 Thread Christoph Hellwig
Folks, you can't just pass arbitary GFP_ flags to dma allocation routines, beause very often they are not just wrappers around the page allocator. So no, you can't just fine grained control the flags, but the existing code is just as buggy. Please switch to use memalloc_noio_save() instead.

Re: arch/xtensa/include/asm/uaccess.h:40:22: error: implicit declaration of function 'uaccess_kernel'; did you mean 'getname_kernel'?

2019-05-19 Thread Max Filippov
Hello, On Sun, May 19, 2019 at 10:39 PM kbuild test robot wrote: > Hi Matt, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: a188339ca5a396acc588e5851ed7e19f66b0ebd9 > commit: 7df95299b94a63ec67a6389fc02dc

Re: [PATCH] intel_th: msu: Fix unused variable warning on arm64 platform

2019-05-19 Thread Zhangshaokun
please ignore this patch, I will update it and resend it. On 2019/5/20 11:23, Shaokun Zhang wrote: > Fix this compiler warning on arm64 platform. > > Cc: Alexander Shishkin > Cc: Greg Kroah-Hartman > Signed-off-by: Shaokun Zhang > --- > drivers/hwtracing/intel_th/msu.c | 8 +++- > 1 file

[RFC PATCH v5 12/16] slub: Enable moving objects to/from specific nodes

2019-05-19 Thread Tobin C. Harding
We have just implemented Slab Movable Objects (object migration). Currently object migration is used to defrag a cache. On NUMA systems it would be nice to be able to control the source and destination nodes when moving objects. Add CONFIG_SMO_NODE to guard this feature. CONFIG_SMO_NODE depends

[RFC PATCH v5 15/16] dcache: Implement partial shrink via Slab Movable Objects

2019-05-19 Thread Tobin C. Harding
The dentry slab cache is susceptible to internal fragmentation. Now that we have Slab Movable Objects we can attempt to defragment the dcache. Dentry objects are inherently _not_ relocatable however under some conditions they can be free'd. This is the same as shrinking the dcache but instead of

[RFC PATCH v5 13/16] slub: Enable balancing slabs across nodes

2019-05-19 Thread Tobin C. Harding
We have just implemented Slab Movable Objects (SMO). On NUMA systems slabs can become unbalanced i.e. many slabs on one node while other nodes have few slabs. Using SMO we can balance the slabs across all the nodes. The algorithm used is as follows: 1. Move all objects to node 0 (this has the

[RFC PATCH v5 16/16] dcache: Add CONFIG_DCACHE_SMO

2019-05-19 Thread Tobin C. Harding
In an attempt to make the SMO patchset as non-invasive as possible add a config option CONFIG_DCACHE_SMO (under "Memory Management options") for enabling SMO for the DCACHE. Whithout this option dcache constructor is used but no other code is built in, with this option enabled slab mobility is ena

[RFC PATCH v5 11/16] tools/testing/slab: Add XArray movable objects tests

2019-05-19 Thread Tobin C. Harding
We just implemented movable objects for the XArray. Let's test it intree. Add test module for the XArray's movable objects implementation. Functionality of the XArray Slab Movable Object implementation can usually be seen by simply by using `slabinfo` on a running machine since the radix tree is

[RFC PATCH v5 14/16] dcache: Provide a dentry constructor

2019-05-19 Thread Tobin C. Harding
In order to support object migration on the dentry cache we need to have a determined object state at all times. Without a constructor the object would have a random state after allocation. Provide a dentry constructor. Signed-off-by: Tobin C. Harding --- fs/dcache.c | 30 +-

[RFC PATCH v5 05/16] tools/vm/slabinfo: Add remote node defrag ratio output

2019-05-19 Thread Tobin C. Harding
Add output line for NUMA remote node defrag ratio. Signed-off-by: Tobin C. Harding --- tools/vm/slabinfo.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c index cbfc56c44c2f..d2c22f9ee2d8 100644 --- a/tools/vm/slabinfo.c +++ b/tools/vm/slabinf

[RFC PATCH v5 08/16] tools/testing/slab: Add object migration test suite

2019-05-19 Thread Tobin C. Harding
We just added a module that enables testing the SLUB allocators ability to defrag/shrink caches via movable objects. Tests are better when they are automated. Add automated testing via a python script for SLUB movable objects. Example output: $ cd path/to/linux/tools/testing/slab $ /slub_de

[RFC PATCH v5 07/16] tools/testing/slab: Add object migration test module

2019-05-19 Thread Tobin C. Harding
We just implemented slab movable objects for the SLUB allocator. We should test that code. In order to do so we need to be able to do a number of things - Create a cache - Enable Slab Movable Objects for the cache - Allocate objects to the cache - Free objects from within specific slabs of t

[RFC PATCH v5 06/16] tools/vm/slabinfo: Add defrag_used_ratio output

2019-05-19 Thread Tobin C. Harding
Add output for the newly added defrag_used_ratio sysfs knob. Signed-off-by: Tobin C. Harding --- tools/vm/slabinfo.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c index d2c22f9ee2d8..ef4ff93df4cc 100644 --- a/tools/vm/slabinfo.c +++ b/tools/vm/

[RFC PATCH v5 09/16] lib: Separate radix_tree_node and xa_node slab cache

2019-05-19 Thread Tobin C. Harding
Earlier, Slab Movable Objects (SMO) was implemented. The XArray is now able to take advantage of SMO in order to make xarray nodes movable (when using the SLUB allocator). Currently the radix tree uses the same slab cache as the XArray. Only XArray nodes are movable _not_ radix tree nodes. We c

[RFC PATCH v5 10/16] xarray: Implement migration function for xa_node objects

2019-05-19 Thread Tobin C. Harding
Recently Slab Movable Objects (SMO) was implemented for the SLUB allocator. The XArray can take advantage of this and make the xa_node slab cache objects movable. Implement functions to migrate objects and activate SMO when we initialise the XArray slab cache. This is based on initial code by Ma

[RFC PATCH v5 03/16] slub: Sort slab cache list

2019-05-19 Thread Tobin C. Harding
It is advantageous to have all defragmentable slabs together at the beginning of the list of slabs so that there is no need to scan the complete list. Put defragmentable caches first when adding a slab cache and others last. Co-developed-by: Christoph Lameter Signed-off-by: Tobin C. Harding ---

[RFC PATCH v5 04/16] slub: Slab defrag core

2019-05-19 Thread Tobin C. Harding
Internal fragmentation can occur within pages used by the slub allocator. Under some workloads large numbers of pages can be used by partial slab pages. This under-utilisation is bad simply because it wastes memory but also because if the system is under memory pressure higher order allocations m

[RFC PATCH v5 02/16] tools/vm/slabinfo: Add support for -C and -M options

2019-05-19 Thread Tobin C. Harding
-C lists caches that use a ctor. -M lists caches that support object migration. Add command line options to show caches with a constructor and caches that are movable (i.e. have migrate function). Co-developed-by: Christoph Lameter Signed-off-by: Tobin C. Harding --- tools/vm/slabinfo.c | 40

[RFC PATCH v5 00/16] Slab Movable Objects (SMO)

2019-05-19 Thread Tobin C. Harding
Hi, Another iteration of the SMO patch set, updates to this version are restricted to the XArray patches (#9 and #10 and tested with module implemented in #11). Applies on top of Linus' tree (tag: v5.2-rc1). This is a patch set implementing movable objects within the SLUB allocator. This is wor

[RFC PATCH v5 01/16] slub: Add isolate() and migrate() methods

2019-05-19 Thread Tobin C. Harding
Add the two methods needed for moving objects and enable the display of the callbacks via the /sys/kernel/slab interface. Add documentation explaining the use of these methods and the prototypes for slab.h. Add functions to setup the callbacks method for a slab cache. Add empty functions for SLAB

[PATCH v1 5/9] perf diff: Use hists to manage basic blocks

2019-05-19 Thread Jin Yao
The function hist__account_cycles() can account cycles per basic block. The basic block information are saved in a per-symbol cycles_hist structure. This patch processes each symbol, get basic blocks from cycles_hist and add the basic block entry to a hists. Using a hists is because we need to com

[PATCH v1 4/9] perf diff: Get a list of symbols(functions)

2019-05-19 Thread Jin Yao
We already have a function hist__account_cycles() which can be used to account cycles per basic block in symbol/function. But we also need to know what the symbols are, since we need to get basic blocks of all symbols(functions) before diff. This patch records the sorted symbols in sym_hists, whic

[PATCH v1 0/9] perf diff: diff cycles at basic block level

2019-05-19 Thread Jin Yao
In some cases small changes in hot loops can show big differences. But it's difficult to identify these differences. perf diff currently can only diff symbols (functions). We can also expand it to diff cycles of individual programs blocks as reported by timed LBR. This would allow to identify chan

[PATCH v1 3/9] perf diff: Check if all data files with branch stacks

2019-05-19 Thread Jin Yao
We will expand perf diff to support diff cycles of individual programs blocks, so it requires all data files having branch stacks. This patch checks HEADER_BRANCH_STACK in header, and only set the flag has_br_stack when HEADER_BRANCH_STACK are set in all data files. Signed-off-by: Jin Yao --- t

[PATCH v1 2/9] perf util: Add block_info in hist_entry

2019-05-19 Thread Jin Yao
The block_info contains the program basic block information, i.e, contains the start address and the end address of this basic block and how much cycles it takes. We need to compare, sort and even print out the basic block by some orders, i.e. sort by cycles. For this purpose, we add block_info fi

[PATCH v1 1/9] perf util: Create block_info structure

2019-05-19 Thread Jin Yao
perf diff currently can only diff symbols(functions). We should expand it to diff cycles of individual programs blocks as reported by timed LBR. This would allow to identify changes in specific code accurately. We need a new structure to maintain the basic block information, such as, symbol(functi

[PATCH v1 9/9] perf diff: Documentation --basic-block option

2019-05-19 Thread Jin Yao
Documentation the new option '--basic-block'. Signed-off-by: Jin Yao --- tools/perf/Documentation/perf-diff.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/perf/Documentation/perf-diff.txt b/tools/perf/Documentation/perf-diff.txt index da7809b..b242af8 100644 --- a/tools/perf

[PATCH v1 7/9] perf diff: Compute cycles diff of basic blocks

2019-05-19 Thread Jin Yao
In previous patch, we have already linked up the same basic blocks. Now we compute the cycles diff value of basic blocks, in order to sort by diff cycles later. Signed-off-by: Jin Yao --- tools/perf/builtin-diff.c | 31 +++ tools/perf/util/sort.h| 2 ++ 2 files c

[PATCH v1 8/9] perf diff: Print the basic block cycles diff

2019-05-19 Thread Jin Yao
Currently we only support sorting by diff cycles. For example, perf record -b ./div perf record -b ./div perf diff --basic-block # Cycles diff Basic block (start:end) # ... ... # -20 native_write_msr (7fff9a069900:7fff9a06990b) -3 __indir

[PATCH v1 6/9] perf diff: Link same basic blocks among different data files

2019-05-19 Thread Jin Yao
The target is to compare the performance difference (cycles diff) for the same basic blocks in different data files. The same basic block means same function, same start address and same end address. This patch finds the same basic blocks from different data files and link them together. Signed-o

Re: [PATCH] mm/dev_pfn: Exclude MEMORY_DEVICE_PRIVATE while computing virtual address

2019-05-19 Thread Anshuman Khandual
On 05/18/2019 03:20 AM, Andrew Morton wrote: > On Fri, 17 May 2019 16:08:34 +0530 Anshuman Khandual > wrote: > >> The presence of struct page does not guarantee linear mapping for the pfn >> physical range. Device private memory which is non-coherent is excluded >> from linear mapping during dev

[PATCH V4 3/4] arm64/mm: Hold memory hotplug lock while walking for kernel page table dump

2019-05-19 Thread Anshuman Khandual
The arm64 page table dump code can race with concurrent modification of the kernel page tables. When a leaf entries are modified concurrently, the dump code may log stale or inconsistent information for a VA range, but this is otherwise not harmful. When intermediate levels of table are freed, the

[PATCH V4 1/4] mm/hotplug: Reorder arch_remove_memory() call in __remove_memory()

2019-05-19 Thread Anshuman Khandual
Memory hot remove uses get_nid_for_pfn() while tearing down linked sysfs entries between memory block and node. It first checks pfn validity with pfn_valid_within() before fetching nid. With CONFIG_HOLES_IN_ZONE config (arm64 has this enabled) pfn_valid_within() calls pfn_valid(). pfn_valid() is a

[PATCH V4 2/4] arm64/mm: Inhibit huge-vmap with ptdump

2019-05-19 Thread Anshuman Khandual
From: Mark Rutland The arm64 ptdump code can race with concurrent modification of the kernel page tables. At the time this was added, this was sound as: * Modifications to leaf entries could result in stale information being logged, but would not result in a functional problem. * Boot time mo

[PATCH V4 4/4] arm64/mm: Enable memory hot remove

2019-05-19 Thread Anshuman Khandual
The arch code for hot-remove must tear down portions of the linear map and vmemmap corresponding to memory being removed. In both cases the page tables mapping these regions must be freed, and when sparse vmemmap is in use the memory backing the vmemmap must also be freed. This patch adds a new re

[PATCH V4 0/4] arm64/mm: Enable memory hot remove

2019-05-19 Thread Anshuman Khandual
This series enables memory hot remove on arm64 after fixing a memblock removal ordering problem in generic __remove_memory() and two possible arm64 platform specific kernel page table race conditions. This series is based on latest v5.2-rc1 tag. Testing: Memory hot remove has been tested on arm64

[PATCH] intel-svm: fix typos in code comments

2019-05-19 Thread Weitao Hou
fix acccess to access Signed-off-by: Weitao Hou --- include/linux/intel-svm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/intel-svm.h b/include/linux/intel-svm.h index e3f76315ca4d..8dfead70699c 100644 --- a/include/linux/intel-svm.h +++ b/include/linux/inte

Re: PROBLEM: Power9: kernel oops on memory hotunplug from ppc64le guest

2019-05-19 Thread Nicholas Piggin
Bharata B Rao's on May 20, 2019 2:25 pm: > On Mon, May 20, 2019 at 12:02:23PM +1000, Michael Ellerman wrote: >> Bharata B Rao writes: >> > On Thu, May 16, 2019 at 07:44:20PM +0530, srikanth wrote: >> >> Hello, >> >> >> >> On power9 host, performing memory hotunplug from ppc64le guest results in >

[PATCH] fddi: fix typos in code comments

2019-05-19 Thread Weitao Hou
fix abord to abort Signed-off-by: Weitao Hou --- drivers/net/fddi/skfp/hwmtm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/fddi/skfp/hwmtm.c b/drivers/net/fddi/skfp/hwmtm.c index abbe309051d9..3d0f417e8586 100644 --- a/drivers/net/fddi/skfp/hwmtm.c +++ b/d

[PATCH] mm/failslab: By default, do not fail allocations with direct reclaim only

2019-05-19 Thread Nicolas Boichat
When failslab was originally written, the intention of the "ignore-gfp-wait" flag default value ("N") was to fail GFP_ATOMIC allocations. Those were defined as (__GFP_HIGH), and the code would test for __GFP_WAIT (0x10u). However, since then, __GFP_WAIT was replaced by __GFP_RECLAIM (___GFP_DIRECT

Re: [PATCH] vfio: vfio_pci_nvlink2: use a vma helper function

2019-05-19 Thread Alexey Kardashevskiy
On 17/05/2019 00:48, Alex Williamson wrote: > [Cc Alexey + kvm] > > On Thu, 16 May 2019 20:38:26 +0800 > "richard.p...@oppo.com" wrote: > >> Use a vma helper function to simply code. >> >> Signed-off-by: Peng Hao >> --- >>  drivers/vfio/pci/vfio_pci_nvlink2.c | 3 +-- >>  1 file changed, 1 in

Re: [PATCH 6/8] PM / OPP: Support adjusting OPP voltages at runtime

2019-05-19 Thread Viresh Kumar
On 16-05-19, 17:08, Andrew-sh.Cheng wrote: > From: Stephen Boyd > > On some SoCs the Adaptive Voltage Scaling (AVS) technique is > employed to optimize the operating voltage of a device. At a > given frequency, the hardware monitors dynamic factors and either > makes a suggestion for how much to

Re: [PATCH 4/8] dt-bindings: devfreq: add compatible for mt8183 cci devfreq

2019-05-19 Thread Viresh Kumar
On 16-05-19, 17:08, Andrew-sh.Cheng wrote: > From: "Andrew-sh.Cheng" > > This adds dt-binding documentation of cci devfreq > for Mediatek MT8183 SoC platform. > > Signed-off-by: Andrew-sh.Cheng > --- > .../bindings/devfreq/mt8183-cci-devfreq.txt | 20 > > 1 file

Re: [EXT] Re: [PATCH 1/3] enetc: add hardware timestamping support

2019-05-19 Thread Richard Cochran
On Mon, May 20, 2019 at 03:20:23AM +, Y.b. Lu wrote: > > > +config FSL_ENETC_HW_TIMESTAMPING > > > + bool "ENETC hardware timestamping support" > > > + depends on FSL_ENETC || FSL_ENETC_VF > > > + help > > > + Enable hardware timestamping support on the Ethernet packets > > >

Re: [RFC 5/5] cpufreq: add driver for Raspbery Pi

2019-05-19 Thread Viresh Kumar
On 17-05-19, 17:35, Nicolas Saenz Julienne wrote: > Raspberry Pi's firmware offers and interface though which update it's > performance requirements. It allows us to request for specific runtime > frequencies, which the firmware might or might not respect, depending on > the firmware configuration

[PATCH] kvm: vmx: Fix -Wmissing-prototypes warnings

2019-05-19 Thread Yi Wang
We get a warning when build kernel W=1: arch/x86/kvm/vmx/vmx.c:6365:6: warning: no previous prototype for ‘vmx_update_host_rsp’ [-Wmissing-prototypes] void vmx_update_host_rsp(struct vcpu_vmx *vmx, unsigned long host_rsp) Add the missing declaration to fix this. Signed-off-by: Yi Wang --- arc

Re: PROBLEM: Power9: kernel oops on memory hotunplug from ppc64le guest

2019-05-19 Thread Bharata B Rao
On Mon, May 20, 2019 at 12:02:23PM +1000, Michael Ellerman wrote: > Bharata B Rao writes: > > On Thu, May 16, 2019 at 07:44:20PM +0530, srikanth wrote: > >> Hello, > >> > >> On power9 host, performing memory hotunplug from ppc64le guest results in > >> kernel oops. > >> > >> Kernel used : https:

Re: [PATCH v3 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC

2019-05-19 Thread Sagar Kadam
Hi Andrew, On Thu, May 16, 2019 at 6:37 PM Andrew Lunn wrote: > > On Thu, May 16, 2019 at 10:38:40AM +0530, Sagar Shrikant Kadam wrote: > > The i2c-ocore driver already has a polling mode interface.But it needs > > a workaround for FU540 Chipset on HiFive unleashed board (RevA00). > > There is an

arch/xtensa/include/asm/uaccess.h:40:22: error: implicit declaration of function 'uaccess_kernel'; did you mean 'getname_kernel'?

2019-05-19 Thread kbuild test robot
Hi Matt, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a188339ca5a396acc588e5851ed7e19f66b0ebd9 commit: 7df95299b94a63ec67a6389fc02dc25019a80ee8 staging: kpc2000: Add DMA driver date: 4 weeks ago config: xtensa-

drivers//pinctrl/pinctrl-stmfx.c:652:17: error: 'struct gpio_chip' has no member named 'of_node'

2019-05-19 Thread kbuild test robot
Hi Amelie, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a188339ca5a396acc588e5851ed7e19f66b0ebd9 commit: 1490d9f841b186664f9d3ca213dcfa4464a60680 pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver date: 10 da

ERROR: "uio_unregister_device" [drivers/staging/kpc2000/kpc2000/kpc2000.ko] undefined!

2019-05-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a188339ca5a396acc588e5851ed7e19f66b0ebd9 commit: 7dc7967fc39af81191558f63eeaf3d2b83899b1c staging: kpc2000: add initial set of Daktronics drivers date: 4 weeks ago config: x86_64-randconfig-m3-05200349 (at

Re: [PATCH v2] pstore: Add boot loader log messages support

2019-05-19 Thread Yue Hu
On Wed, 15 May 2019 15:04:09 -0700 Kees Cook wrote: > Hi! > > Thanks for the reminder to review this code. :) Sorry for the delay! > > On Thu, Feb 14, 2019 at 11:49 PM Yue Hu wrote: > > > > From: Yue Hu > > > > Sometimes we hope to check boot loader log messages (e.g. Android > > Verified Boo

Re: [PATCH v3] kbuild: check uniqueness of module names

2019-05-19 Thread Masahiro Yamada
On Mon, May 20, 2019 at 8:52 AM Stephen Rothwell wrote: > > Hi Masahiro, > > On Sat, 18 May 2019 01:07:15 +0900 Masahiro Yamada > wrote: > > > > It checks not only real modules, but also built-in modules (i.e. > > controlled by tristate CONFIG option, but currently compiled with =y). > > Non-uni

[RFC 7/7] mm: madvise support MADV_ANONYMOUS_FILTER and MADV_FILE_FILTER

2019-05-19 Thread Minchan Kim
System could have much faster swap device like zRAM. In that case, swapping is extremely cheaper than file-IO on the low-end storage. In this configuration, userspace could handle different strategy for each kinds of vma. IOW, they want to reclaim anonymous pages by MADV_COLD while it keeps file-ba

[RFC 4/7] mm: factor out madvise's core functionality

2019-05-19 Thread Minchan Kim
This patch factor out madvise's core functionality so that upcoming patch can reuse it without duplication. It shouldn't change any behavior. Signed-off-by: Minchan Kim --- mm/madvise.c | 168 +++ 1 file changed, 89 insertions(+), 79 deletions(-)

[RFC 3/7] mm: introduce MADV_COLD

2019-05-19 Thread Minchan Kim
When a process expects no accesses to a certain memory range for a long time, it could hint kernel that the pages can be reclaimed instantly but data should be preserved for future use. This could reduce workingset eviction so it ends up increasing performance. This patch introduces the new MADV_C

[RFC 5/7] mm: introduce external memory hinting API

2019-05-19 Thread Minchan Kim
There is some usecase that centralized userspace daemon want to give a memory hint like MADV_[COOL|COLD] to other process. Android's ActivityManagerService is one of them. It's similar in spirit to madvise(MADV_WONTNEED), but the information required to make the reclaim decision is not known to th

[RFC 6/7] mm: extend process_madvise syscall to support vector arrary

2019-05-19 Thread Minchan Kim
Currently, process_madvise syscall works for only one address range so user should call the syscall several times to give hints to multiple address range. This patch extends process_madvise syscall to support multiple hints, address ranges and return vaules so user could give hints all at once. s

[RFC 2/7] mm: change PAGEREF_RECLAIM_CLEAN with PAGE_REFRECLAIM

2019-05-19 Thread Minchan Kim
The local variable references in shrink_page_list is PAGEREF_RECLAIM_CLEAN as default. It is for preventing to reclaim dirty pages when CMA try to migrate pages. Strictly speaking, we don't need it because CMA didn't allow to write out by .may_writepage = 0 in reclaim_clean_pages_from_list. Moreov

[RFC 1/7] mm: introduce MADV_COOL

2019-05-19 Thread Minchan Kim
When a process expects no accesses to a certain memory range it could hint kernel that the pages can be reclaimed when memory pressure happens but data should be preserved for future use. This could reduce workingset eviction so it ends up increasing performance. This patch introduces the new MAD

[RFC 0/7] introduce memory hinting API for external process

2019-05-19 Thread Minchan Kim
- Background The Android terminology used for forking a new process and starting an app from scratch is a cold start, while resuming an existing app is a hot start. While we continually try to improve the performance of cold starts, hot starts will always be significantly less power hungry as well

Re: [Qemu-devel] [PATCH v9 2/7] virtio-pmem: Add virtio pmem driver

2019-05-19 Thread Pankaj Gupta
> > > > On 5/16/19 10:35 PM, Pankaj Gupta wrote: > > > Can I take it your reviewed/acked-by? or tested-by tag? for the virtio > > > patch :)I don't feel that I have enough expertise to give the reviewed-by > > > tag, but you can > > take my acked-by + tested-by. > > > > Acked-by: Jakub Staron

[PATCH v2] tipc: Avoid copying bytes beyond the supplied data

2019-05-19 Thread Chris Packham
TLV_SET is called with a data pointer and a len parameter that tells us how many bytes are pointed to by data. When invoking memcpy() we need to careful to only copy len bytes. Previously we would copy TLV_LENGTH(len) bytes which would copy an extra 4 bytes past the end of the data pointer which n

  1   2   3   >